[INFO] fetching crate playit-agent-core 0.17.5... [INFO] checking playit-agent-core-0.17.5 against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] extracting crate playit-agent-core 0.17.5 into /workspace/builds/worker-6-tc1/source [INFO] validating manifest of crates.io crate playit-agent-core 0.17.5 on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate playit-agent-core 0.17.5 [INFO] finished tweaking crates.io crate playit-agent-core 0.17.5 [INFO] tweaked toml for crates.io crate playit-agent-core 0.17.5 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 175 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded message-encoding v0.2.2 [INFO] [stderr] Downloaded playit-api-client v0.1.0 [INFO] [stderr] Downloaded playit-agent-proto v1.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dbdae34af6574227011dddb5c68be5311e9df7c62dbbc4aee0989c2c93d0732a [INFO] running `Command { std: "docker" "start" "-a" "dbdae34af6574227011dddb5c68be5311e9df7c62dbbc4aee0989c2c93d0732a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dbdae34af6574227011dddb5c68be5311e9df7c62dbbc4aee0989c2c93d0732a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbdae34af6574227011dddb5c68be5311e9df7c62dbbc4aee0989c2c93d0732a", kill_on_drop: false }` [INFO] [stdout] dbdae34af6574227011dddb5c68be5311e9df7c62dbbc4aee0989c2c93d0732a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b497511d993de1b453b0e275b301a36156f7120a0eb85b1c37e35a8cc6ff5fe [INFO] running `Command { std: "docker" "start" "-a" "1b497511d993de1b453b0e275b301a36156f7120a0eb85b1c37e35a8cc6ff5fe", kill_on_drop: false }` [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking message-encoding v0.2.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking rustls v0.23.12 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking playit-agent-proto v1.1.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking playit-api-client v0.1.0 [INFO] [stderr] Checking playit-agent-core v0.17.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `dropper` is never read [INFO] [stdout] --> src/network/tcp_clients.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 95 | pub struct TcpClientWrite { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 96 | stream: OwnedWriteHalf, [INFO] [stdout] 97 | dropper: Arc, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `dropper` is never read [INFO] [stdout] --> src/network/tcp_clients.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 100 | pub struct TcpClientRead { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 101 | stream: OwnedReadHalf, [INFO] [stdout] 102 | dropper: Arc, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `dropper` is never read [INFO] [stdout] --> src/network/tcp_clients.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 95 | pub struct TcpClientWrite { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 96 | stream: OwnedWriteHalf, [INFO] [stdout] 97 | dropper: Arc, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `dropper` is never read [INFO] [stdout] --> src/network/tcp_clients.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 100 | pub struct TcpClientRead { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 101 | stream: OwnedReadHalf, [INFO] [stdout] 102 | dropper: Arc, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.99s [INFO] running `Command { std: "docker" "inspect" "1b497511d993de1b453b0e275b301a36156f7120a0eb85b1c37e35a8cc6ff5fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b497511d993de1b453b0e275b301a36156f7120a0eb85b1c37e35a8cc6ff5fe", kill_on_drop: false }` [INFO] [stdout] 1b497511d993de1b453b0e275b301a36156f7120a0eb85b1c37e35a8cc6ff5fe [INFO] checking playit-agent-core-0.17.5 against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] extracting crate playit-agent-core 0.17.5 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate playit-agent-core 0.17.5 on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate playit-agent-core 0.17.5 [INFO] finished tweaking crates.io crate playit-agent-core 0.17.5 [INFO] tweaked toml for crates.io crate playit-agent-core 0.17.5 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 175 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d50b835e40e958d116ce21d63be33bc39fcbcfc77aea9c9a1d78b84cfa99f1e3 [INFO] running `Command { std: "docker" "start" "-a" "d50b835e40e958d116ce21d63be33bc39fcbcfc77aea9c9a1d78b84cfa99f1e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d50b835e40e958d116ce21d63be33bc39fcbcfc77aea9c9a1d78b84cfa99f1e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d50b835e40e958d116ce21d63be33bc39fcbcfc77aea9c9a1d78b84cfa99f1e3", kill_on_drop: false }` [INFO] [stdout] d50b835e40e958d116ce21d63be33bc39fcbcfc77aea9c9a1d78b84cfa99f1e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9822cf7bfc5b5d8d9980cd107f12e9c22e566e6a4d0dffc922e9d803bb3b461f [INFO] running `Command { std: "docker" "start" "-a" "9822cf7bfc5b5d8d9980cd107f12e9c22e566e6a4d0dffc922e9d803bb3b461f", kill_on_drop: false }` [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking message-encoding v0.2.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking rustls v0.23.12 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking playit-agent-proto v1.1.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking playit-api-client v0.1.0 [INFO] [stderr] Checking playit-agent-core v0.17.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `dropper` is never read [INFO] [stdout] --> src/network/tcp_clients.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 95 | pub struct TcpClientWrite { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 96 | stream: OwnedWriteHalf, [INFO] [stdout] 97 | dropper: Arc, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `dropper` is never read [INFO] [stdout] --> src/network/tcp_clients.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 100 | pub struct TcpClientRead { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 101 | stream: OwnedReadHalf, [INFO] [stdout] 102 | dropper: Arc, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agent_control/udp_channel.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(packet_io: I) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | UdpChannel { [INFO] [stdout] 40 | inner: Arc::new(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 41 | | packet_io, [INFO] [stdout] 42 | | details: RwLock::new(ChannelDetails { [INFO] [stdout] 43 | | udp: None, [INFO] [stdout] ... | [INFO] [stdout] 47 | | last_send: AtomicU32::new(0), [INFO] [stdout] 48 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/udp_clients.rs:36:26 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(tunnel: UdpChannel, lookup: L) -> Self { [INFO] [stdout] | --------------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | udp_clients: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/tcp_clients.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn into_split(self) -> (TcpClientRead, TcpClientWrite) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let (read, write) = self.stream.into_split(); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let dropper = Arc::new(self.dropper); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | / TcpClientRead { [INFO] [stdout] 117 | | stream: read, [INFO] [stdout] 118 | | dropper: dropper.clone(), [INFO] [stdout] 119 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/tcp_clients.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn into_split(self) -> (TcpClientRead, TcpClientWrite) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let (read, write) = self.stream.into_split(); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let dropper = Arc::new(self.dropper); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / TcpClientWrite { [INFO] [stdout] 121 | | stream: write, [INFO] [stdout] 122 | | dropper: dropper.clone(), [INFO] [stdout] 123 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `dropper` is never read [INFO] [stdout] --> src/network/tcp_clients.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 95 | pub struct TcpClientWrite { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 96 | stream: OwnedWriteHalf, [INFO] [stdout] 97 | dropper: Arc, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `dropper` is never read [INFO] [stdout] --> src/network/tcp_clients.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 100 | pub struct TcpClientRead { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 101 | stream: OwnedReadHalf, [INFO] [stdout] 102 | dropper: Arc, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agent_control/udp_channel.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(packet_io: I) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | UdpChannel { [INFO] [stdout] 40 | inner: Arc::new(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 41 | | packet_io, [INFO] [stdout] 42 | | details: RwLock::new(ChannelDetails { [INFO] [stdout] 43 | | udp: None, [INFO] [stdout] ... | [INFO] [stdout] 47 | | last_send: AtomicU32::new(0), [INFO] [stdout] 48 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/udp_clients.rs:36:26 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(tunnel: UdpChannel, lookup: L) -> Self { [INFO] [stdout] | --------------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | udp_clients: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/tcp_clients.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn into_split(self) -> (TcpClientRead, TcpClientWrite) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let (read, write) = self.stream.into_split(); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let dropper = Arc::new(self.dropper); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | / TcpClientRead { [INFO] [stdout] 117 | | stream: read, [INFO] [stdout] 118 | | dropper: dropper.clone(), [INFO] [stdout] 119 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/tcp_clients.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn into_split(self) -> (TcpClientRead, TcpClientWrite) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let (read, write) = self.stream.into_split(); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let dropper = Arc::new(self.dropper); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / TcpClientWrite { [INFO] [stdout] 121 | | stream: write, [INFO] [stdout] 122 | | dropper: dropper.clone(), [INFO] [stdout] 123 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `playit-agent-core` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `playit-agent-core` (lib) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9822cf7bfc5b5d8d9980cd107f12e9c22e566e6a4d0dffc922e9d803bb3b461f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9822cf7bfc5b5d8d9980cd107f12e9c22e566e6a4d0dffc922e9d803bb3b461f", kill_on_drop: false }` [INFO] [stdout] 9822cf7bfc5b5d8d9980cd107f12e9c22e566e6a4d0dffc922e9d803bb3b461f