[INFO] fetching crate pingora-pool 0.3.0... [INFO] checking pingora-pool-0.3.0 against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] extracting crate pingora-pool 0.3.0 into /workspace/builds/worker-4-tc1/source [INFO] validating manifest of crates.io crate pingora-pool 0.3.0 on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pingora-pool 0.3.0 [INFO] finished tweaking crates.io crate pingora-pool 0.3.0 [INFO] tweaked toml for crates.io crate pingora-pool 0.3.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 66 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pingora-timeout v0.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e2499f01df53022581b78137357d52b5f007834cf225fb696e490dfec8b405f4 [INFO] running `Command { std: "docker" "start" "-a" "e2499f01df53022581b78137357d52b5f007834cf225fb696e490dfec8b405f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e2499f01df53022581b78137357d52b5f007834cf225fb696e490dfec8b405f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2499f01df53022581b78137357d52b5f007834cf225fb696e490dfec8b405f4", kill_on_drop: false }` [INFO] [stdout] e2499f01df53022581b78137357d52b5f007834cf225fb696e490dfec8b405f4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e5be57cd1c1bbbfd58b834f0f8409dcb40d3326d8a267a4e7aa8b183598939a3 [INFO] running `Command { std: "docker" "start" "-a" "e5be57cd1c1bbbfd58b834f0f8409dcb40d3326d8a267a4e7aa8b183598939a3", kill_on_drop: false }` [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking pingora-timeout v0.3.0 [INFO] [stderr] Checking pingora-pool v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.17s [INFO] running `Command { std: "docker" "inspect" "e5be57cd1c1bbbfd58b834f0f8409dcb40d3326d8a267a4e7aa8b183598939a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5be57cd1c1bbbfd58b834f0f8409dcb40d3326d8a267a4e7aa8b183598939a3", kill_on_drop: false }` [INFO] [stdout] e5be57cd1c1bbbfd58b834f0f8409dcb40d3326d8a267a4e7aa8b183598939a3 [INFO] checking pingora-pool-0.3.0 against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] extracting crate pingora-pool 0.3.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate pingora-pool 0.3.0 on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pingora-pool 0.3.0 [INFO] finished tweaking crates.io crate pingora-pool 0.3.0 [INFO] tweaked toml for crates.io crate pingora-pool 0.3.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 66 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e917e5d295f9509e4113ed9f5cabb9dcd5035fb952d30ed407613d9820b28b8b [INFO] running `Command { std: "docker" "start" "-a" "e917e5d295f9509e4113ed9f5cabb9dcd5035fb952d30ed407613d9820b28b8b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e917e5d295f9509e4113ed9f5cabb9dcd5035fb952d30ed407613d9820b28b8b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e917e5d295f9509e4113ed9f5cabb9dcd5035fb952d30ed407613d9820b28b8b", kill_on_drop: false }` [INFO] [stdout] e917e5d295f9509e4113ed9f5cabb9dcd5035fb952d30ed407613d9820b28b8b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b7c9cb2261036b3a9b1097240246b6e2c646fbd3933efb29fac44540b3db0e88 [INFO] running `Command { std: "docker" "start" "-a" "b7c9cb2261036b3a9b1097240246b6e2c646fbd3933efb29fac44540b3db0e88", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking pingora-timeout v0.3.0 [INFO] [stderr] Checking pingora-pool v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:111:14 [INFO] [stdout] | [INFO] [stdout] 96 | let hot_conn = self.hot_queue.pop(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let mut connections = self.connections.lock(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let connection = connections.remove(&id).unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | Some((id, connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lru.rs:32:29 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(meta: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Node { [INFO] [stdout] 32 | close_notifier: Arc::new(Notify::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lru.rs:73:37 [INFO] [stdout] | [INFO] [stdout] 73 | .get_or(|| RefCell::new(LruCache::unbounded())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lru.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn add(&self, key: K, meta: T) -> (Arc, Option) { [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let node = Node::new(meta); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let notifier = node.close_notifier.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | // TODO: check if the key is already in it [INFO] [stdout] 94 | (notifier, self.put(key, node)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lru.rs:100:37 [INFO] [stdout] | [INFO] [stdout] 100 | .get_or(|| RefCell::new(LruCache::unbounded())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pingora-pool` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b7c9cb2261036b3a9b1097240246b6e2c646fbd3933efb29fac44540b3db0e88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7c9cb2261036b3a9b1097240246b6e2c646fbd3933efb29fac44540b3db0e88", kill_on_drop: false }` [INFO] [stdout] b7c9cb2261036b3a9b1097240246b6e2c646fbd3933efb29fac44540b3db0e88