[INFO] fetching crate lightning_encoding 0.9.3... [INFO] checking lightning_encoding-0.9.3 against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] extracting crate lightning_encoding 0.9.3 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate lightning_encoding 0.9.3 on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lightning_encoding 0.9.3 [INFO] finished tweaking crates.io crate lightning_encoding 0.9.3 [INFO] tweaked toml for crates.io crate lightning_encoding 0.9.3 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding amplify v3.14.2 (latest: v4.7.0) [INFO] [stderr] Adding amplify_derive v2.11.3 (latest: v4.0.1) [INFO] [stderr] Adding amplify_num v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding amplify_syn v1.1.6 (latest: v2.0.1) [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding bitcoin v0.29.2 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin_hashes v0.11.0 (latest: v0.14.0) [INFO] [stderr] Adding bitcoin_scripts v0.9.1 (latest: v0.10.0) [INFO] [stderr] Adding encoding_derive_helpers v0.8.1 (latest: v1.7.6) [INFO] [stderr] Adding encoding_derive_helpers v0.9.0 (latest: v1.7.6) [INFO] [stderr] Adding secp256k1 v0.24.3 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.6.1 (latest: v0.10.0) [INFO] [stderr] Adding stability v0.1.1 (latest: v0.2.1) [INFO] [stderr] Adding strict_encoding v0.9.0 (latest: v2.6.2) [INFO] [stderr] Adding strict_encoding_derive v0.9.0 (latest: v2.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.76) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strict_encoding v0.9.0 [INFO] [stderr] Downloaded amplify v3.14.2 [INFO] [stderr] Downloaded amplify_num v0.4.1 [INFO] [stderr] Downloaded amplify_syn v1.1.6 [INFO] [stderr] Downloaded amplify_derive v2.11.3 [INFO] [stderr] Downloaded stability v0.1.1 [INFO] [stderr] Downloaded bitcoin_scripts v0.9.1 [INFO] [stderr] Downloaded encoding_derive_helpers v0.9.0 [INFO] [stderr] Downloaded lightning_encoding_derive v0.9.1 [INFO] [stderr] Downloaded lnpbp_chain v0.9.0 [INFO] [stderr] Downloaded encoding_derive_helpers v0.8.1 [INFO] [stderr] Downloaded strict_encoding_derive v0.9.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 125342a23bc60f24838dc0ddf84ef7f5a6af54aa60c4c9d847b895d15d17becd [INFO] running `Command { std: "docker" "start" "-a" "125342a23bc60f24838dc0ddf84ef7f5a6af54aa60c4c9d847b895d15d17becd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "125342a23bc60f24838dc0ddf84ef7f5a6af54aa60c4c9d847b895d15d17becd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "125342a23bc60f24838dc0ddf84ef7f5a6af54aa60c4c9d847b895d15d17becd", kill_on_drop: false }` [INFO] [stdout] 125342a23bc60f24838dc0ddf84ef7f5a6af54aa60c4c9d847b895d15d17becd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0a6c3ee22f16740967a280d659b80a0fcc625732ac4453307c74e132ac8ed8e8 [INFO] running `Command { std: "docker" "start" "-a" "0a6c3ee22f16740967a280d659b80a0fcc625732ac4453307c74e132ac8ed8e8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling amplify_num v0.4.1 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking amplify_syn v1.1.6 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Compiling amplify_derive v2.11.3 [INFO] [stderr] Compiling stability v0.1.1 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Compiling amplify v3.14.2 [INFO] [stderr] Compiling encoding_derive_helpers v0.8.1 [INFO] [stderr] Compiling encoding_derive_helpers v0.9.0 [INFO] [stderr] Compiling strict_encoding_derive v0.9.0 [INFO] [stderr] Compiling lightning_encoding_derive v0.9.1 [INFO] [stderr] Checking strict_encoding v0.9.0 [INFO] [stderr] Checking lnpbp_chain v0.9.0 [INFO] [stderr] Checking bitcoin_scripts v0.9.1 [INFO] [stderr] Checking lightning_encoding v0.9.3 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.80s [INFO] running `Command { std: "docker" "inspect" "0a6c3ee22f16740967a280d659b80a0fcc625732ac4453307c74e132ac8ed8e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a6c3ee22f16740967a280d659b80a0fcc625732ac4453307c74e132ac8ed8e8", kill_on_drop: false }` [INFO] [stdout] 0a6c3ee22f16740967a280d659b80a0fcc625732ac4453307c74e132ac8ed8e8 [INFO] checking lightning_encoding-0.9.3 against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] extracting crate lightning_encoding 0.9.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate lightning_encoding 0.9.3 on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lightning_encoding 0.9.3 [INFO] finished tweaking crates.io crate lightning_encoding 0.9.3 [INFO] tweaked toml for crates.io crate lightning_encoding 0.9.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding amplify v3.14.2 (latest: v4.7.0) [INFO] [stderr] Adding amplify_derive v2.11.3 (latest: v4.0.1) [INFO] [stderr] Adding amplify_num v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding amplify_syn v1.1.6 (latest: v2.0.1) [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding bitcoin v0.29.2 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin_hashes v0.11.0 (latest: v0.14.0) [INFO] [stderr] Adding bitcoin_scripts v0.9.1 (latest: v0.10.0) [INFO] [stderr] Adding encoding_derive_helpers v0.8.1 (latest: v1.7.6) [INFO] [stderr] Adding encoding_derive_helpers v0.9.0 (latest: v1.7.6) [INFO] [stderr] Adding secp256k1 v0.24.3 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.6.1 (latest: v0.10.0) [INFO] [stderr] Adding stability v0.1.1 (latest: v0.2.1) [INFO] [stderr] Adding strict_encoding v0.9.0 (latest: v2.6.2) [INFO] [stderr] Adding strict_encoding_derive v0.9.0 (latest: v2.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.76) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d4a4b16424cddcb4df20852298929c360012e1f9a9a5ec17fc7279359eba0d47 [INFO] running `Command { std: "docker" "start" "-a" "d4a4b16424cddcb4df20852298929c360012e1f9a9a5ec17fc7279359eba0d47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d4a4b16424cddcb4df20852298929c360012e1f9a9a5ec17fc7279359eba0d47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4a4b16424cddcb4df20852298929c360012e1f9a9a5ec17fc7279359eba0d47", kill_on_drop: false }` [INFO] [stdout] d4a4b16424cddcb4df20852298929c360012e1f9a9a5ec17fc7279359eba0d47 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] baeac8a8ce3a0e1d9f5f62e343d00c4c18bb2915e53a00dda106603a6f664297 [INFO] running `Command { std: "docker" "start" "-a" "baeac8a8ce3a0e1d9f5f62e343d00c4c18bb2915e53a00dda106603a6f664297", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling amplify_num v0.4.1 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking amplify_syn v1.1.6 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Compiling amplify_derive v2.11.3 [INFO] [stderr] Compiling stability v0.1.1 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Compiling amplify v3.14.2 [INFO] [stderr] Compiling encoding_derive_helpers v0.8.1 [INFO] [stderr] Compiling encoding_derive_helpers v0.9.0 [INFO] [stderr] Compiling strict_encoding_derive v0.9.0 [INFO] [stderr] Compiling lightning_encoding_derive v0.9.1 [INFO] [stderr] Checking strict_encoding v0.9.0 [INFO] [stderr] Checking lnpbp_chain v0.9.0 [INFO] [stderr] Checking bitcoin_scripts v0.9.1 [INFO] [stderr] Checking lightning_encoding v0.9.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/big_size.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 138 | fn lightning_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | match d.read_u8().map_err(|_| Error::BigSizeNoValue)? { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitcoin.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 100 | fn lightning_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | consensus::deserialize(&bytes) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_str.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 52 | fn lightning_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Ok(ret.into_boxed_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 210 | fn lightning_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | let a = K::lightning_decode(&mut d)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | let b = V::lightning_decode(&mut d)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | Ok((a, b)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strategies.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 38 | fn lightning_encode(&self, e: E) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | amplify::Holder::new(self.clone()).lightning_encode(e) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strategies.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 49 | fn lightning_decode(d: D) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Ok(amplify::Holder::lightning_decode(d)?.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strategies.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 69 | fn lightning_decode(d: D) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(Self::new(T::strict_decode(d)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strategies.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 113 | fn lightning_decode(d: D) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Ok(Self::new(T::from_inner(T::Inner::lightning_decode(d)?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strategies.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 123 | fn lightning_decode(d: D) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Ok(Self::new(T::from(BigSize::lightning_decode(d)?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/big_size.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 138 | fn lightning_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | match d.read_u8().map_err(|_| Error::BigSizeNoValue)? { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitcoin.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 100 | fn lightning_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | consensus::deserialize(&bytes) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_str.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 52 | fn lightning_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Ok(ret.into_boxed_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 210 | fn lightning_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | let a = K::lightning_decode(&mut d)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | let b = V::lightning_decode(&mut d)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | Ok((a, b)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strategies.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 38 | fn lightning_encode(&self, e: E) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | amplify::Holder::new(self.clone()).lightning_encode(e) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strategies.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 49 | fn lightning_decode(d: D) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Ok(amplify::Holder::lightning_decode(d)?.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strategies.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 69 | fn lightning_decode(d: D) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(Self::new(T::strict_decode(d)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strategies.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 113 | fn lightning_decode(d: D) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Ok(Self::new(T::from_inner(T::Inner::lightning_decode(d)?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strategies.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 123 | fn lightning_decode(d: D) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Ok(Self::new(T::from(BigSize::lightning_decode(d)?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lightning_encoding` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lightning_encoding` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "baeac8a8ce3a0e1d9f5f62e343d00c4c18bb2915e53a00dda106603a6f664297", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "baeac8a8ce3a0e1d9f5f62e343d00c4c18bb2915e53a00dda106603a6f664297", kill_on_drop: false }` [INFO] [stdout] baeac8a8ce3a0e1d9f5f62e343d00c4c18bb2915e53a00dda106603a6f664297