[INFO] fetching crate dropcheck 0.1.1... [INFO] checking dropcheck-0.1.1 against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] extracting crate dropcheck 0.1.1 into /workspace/builds/worker-4-tc1/source [INFO] validating manifest of crates.io crate dropcheck 0.1.1 on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dropcheck 0.1.1 [INFO] finished tweaking crates.io crate dropcheck 0.1.1 [INFO] tweaked toml for crates.io crate dropcheck 0.1.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 36323338b6e835b4f55aafa7cd0fdabc33248a8f92bc59237998aefdd648b646 [INFO] running `Command { std: "docker" "start" "-a" "36323338b6e835b4f55aafa7cd0fdabc33248a8f92bc59237998aefdd648b646", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "36323338b6e835b4f55aafa7cd0fdabc33248a8f92bc59237998aefdd648b646", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36323338b6e835b4f55aafa7cd0fdabc33248a8f92bc59237998aefdd648b646", kill_on_drop: false }` [INFO] [stdout] 36323338b6e835b4f55aafa7cd0fdabc33248a8f92bc59237998aefdd648b646 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 12248bb3c5c19c59e110b1fdd1401585f1b63ab64d6f866e3f9b6e0c79f19b0c [INFO] running `Command { std: "docker" "start" "-a" "12248bb3c5c19c59e110b1fdd1401585f1b63ab64d6f866e3f9b6e0c79f19b0c", kill_on_drop: false }` [INFO] [stderr] Checking dropcheck v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/lib.rs:113:46 [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("invalid drop count: {}"), [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("invalid drop count: {}", ...), [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("{}", "invalid drop count: {}"), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/lib.rs:113:46 [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("invalid drop count: {}"), [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("invalid drop count: {}", ...), [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("{}", "invalid drop count: {}"), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s [INFO] running `Command { std: "docker" "inspect" "12248bb3c5c19c59e110b1fdd1401585f1b63ab64d6f866e3f9b6e0c79f19b0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "12248bb3c5c19c59e110b1fdd1401585f1b63ab64d6f866e3f9b6e0c79f19b0c", kill_on_drop: false }` [INFO] [stdout] 12248bb3c5c19c59e110b1fdd1401585f1b63ab64d6f866e3f9b6e0c79f19b0c [INFO] checking dropcheck-0.1.1 against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] extracting crate dropcheck 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate dropcheck 0.1.1 on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dropcheck 0.1.1 [INFO] finished tweaking crates.io crate dropcheck 0.1.1 [INFO] tweaked toml for crates.io crate dropcheck 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 55803bbd35b8d2f9f960244fee445e65c160ad025fdc2dffb1631b1aa31437dc [INFO] running `Command { std: "docker" "start" "-a" "55803bbd35b8d2f9f960244fee445e65c160ad025fdc2dffb1631b1aa31437dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "55803bbd35b8d2f9f960244fee445e65c160ad025fdc2dffb1631b1aa31437dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55803bbd35b8d2f9f960244fee445e65c160ad025fdc2dffb1631b1aa31437dc", kill_on_drop: false }` [INFO] [stdout] 55803bbd35b8d2f9f960244fee445e65c160ad025fdc2dffb1631b1aa31437dc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76fa0e5b9f0be1adec06403295c4f96b606c3f5ec672fa50d80ce71f85d209b4 [INFO] running `Command { std: "docker" "start" "-a" "76fa0e5b9f0be1adec06403295c4f96b606c3f5ec672fa50d80ce71f85d209b4", kill_on_drop: false }` [INFO] [stderr] Checking dropcheck v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/lib.rs:113:46 [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("invalid drop count: {}"), [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("invalid drop count: {}", ...), [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("{}", "invalid drop count: {}"), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 164 | fn push(&self, state: Arc) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | self.set.write().unwrap().push(state) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 170 | let state = DropState::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | set: Arc::downgrade(&self.set), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:202:10 [INFO] [stdout] | [INFO] [stdout] 199 | let state = DropState::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | (DropToken { [INFO] [stdout] | __________^ [INFO] [stdout] 203 | | set: Arc::downgrade(&self.set), [INFO] [stdout] 204 | | state: Arc::clone(&state), [INFO] [stdout] 205 | | }, state) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/lib.rs:113:46 [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("invalid drop count: {}"), [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("invalid drop count: {}", ...), [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("{}", "invalid drop count: {}"), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 164 | fn push(&self, state: Arc) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | self.set.write().unwrap().push(state) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 170 | let state = DropState::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | set: Arc::downgrade(&self.set), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:202:10 [INFO] [stdout] | [INFO] [stdout] 199 | let state = DropState::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | (DropToken { [INFO] [stdout] | __________^ [INFO] [stdout] 203 | | set: Arc::downgrade(&self.set), [INFO] [stdout] 204 | | state: Arc::clone(&state), [INFO] [stdout] 205 | | }, state) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dropcheck` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `dropcheck` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "76fa0e5b9f0be1adec06403295c4f96b606c3f5ec672fa50d80ce71f85d209b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76fa0e5b9f0be1adec06403295c4f96b606c3f5ec672fa50d80ce71f85d209b4", kill_on_drop: false }` [INFO] [stdout] 76fa0e5b9f0be1adec06403295c4f96b606c3f5ec672fa50d80ce71f85d209b4