[INFO] fetching crate difftastic_mod_for_windows 0.27.0... [INFO] checking difftastic_mod_for_windows-0.27.0 against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] extracting crate difftastic_mod_for_windows 0.27.0 into /workspace/builds/worker-1-tc1/source [INFO] validating manifest of crates.io crate difftastic_mod_for_windows 0.27.0 on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate difftastic_mod_for_windows 0.27.0 [INFO] finished tweaking crates.io crate difftastic_mod_for_windows 0.27.0 [INFO] tweaked toml for crates.io crate difftastic_mod_for_windows 0.27.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate crates.io crate difftastic_mod_for_windows 0.27.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rpds v0.10.0 [INFO] [stderr] Downloaded output_vt100 v0.1.2 [INFO] [stderr] Downloaded typed-arena v2.0.1 [INFO] [stderr] Downloaded radix-heap v0.4.2 [INFO] [stderr] Downloaded mimalloc v0.1.27 [INFO] [stderr] Downloaded const_format_proc_macros v0.2.22 [INFO] [stderr] Downloaded any_terminal_size v0.1.21 [INFO] [stderr] Downloaded owo-colors v3.2.0 [INFO] [stderr] Downloaded quote v1.0.13 [INFO] [stderr] Downloaded pretty_assertions v1.0.0 [INFO] [stderr] Downloaded const_format v0.2.22 [INFO] [stderr] Downloaded tree-sitter v0.20.5 [INFO] [stderr] Downloaded ctor v0.1.21 [INFO] [stderr] Downloaded wu-diff v0.1.2 [INFO] [stderr] Downloaded diff v0.1.12 [INFO] [stderr] Downloaded clap v3.0.13 [INFO] [stderr] Downloaded archery v0.4.0 [INFO] [stderr] Downloaded syn v1.0.84 [INFO] [stderr] Downloaded libmimalloc-sys v0.1.23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e8806b3f73279ae00cd70eeffeb9415508e60f2877c05576020f8518a0885806 [INFO] running `Command { std: "docker" "start" "-a" "e8806b3f73279ae00cd70eeffeb9415508e60f2877c05576020f8518a0885806", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e8806b3f73279ae00cd70eeffeb9415508e60f2877c05576020f8518a0885806", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8806b3f73279ae00cd70eeffeb9415508e60f2877c05576020f8518a0885806", kill_on_drop: false }` [INFO] [stdout] e8806b3f73279ae00cd70eeffeb9415508e60f2877c05576020f8518a0885806 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e514250f3547317a56a494a3267c73492d79c6d4186579a0eaef87ac85234d36 [INFO] running `Command { std: "docker" "start" "-a" "e514250f3547317a56a494a3267c73492d79c6d4186579a0eaef87ac85234d36", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling scopeguard v1.1.0 [INFO] [stderr] Compiling quote v1.0.13 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.7 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling libmimalloc-sys v0.1.23 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling tree-sitter v0.20.5 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling any_terminal_size v0.1.21 [INFO] [stderr] Checking archery v0.4.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking rpds v0.10.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking radix-heap v0.4.2 [INFO] [stderr] Checking owo-colors v3.2.0 [INFO] [stderr] Checking wu-diff v0.1.2 [INFO] [stderr] Checking typed-arena v2.0.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling crossbeam-channel v0.5.1 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Checking pretty_assertions v1.0.0 [INFO] [stderr] Compiling const_format_proc_macros v0.2.22 [INFO] [stderr] Compiling num_cpus v1.13.1 [INFO] [stderr] Compiling crossbeam-deque v0.8.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking clap v3.0.13 [INFO] [stderr] Checking mimalloc v0.1.27 [INFO] [stderr] Checking const_format v0.2.22 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling difftastic_mod_for_windows v0.27.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `LinePosition` is never constructed [INFO] [stdout] --> src/lines.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | struct LinePosition { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/guess_language.rs:96:63 [INFO] [stdout] | [INFO] [stdout] 96 | let lang = match mode_name.to_ascii_lowercase().trim().borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/options.rs:252:31 [INFO] [stdout] | [INFO] [stdout] 252 | match display_mode_str.borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LinePosition` is never constructed [INFO] [stdout] --> src/lines.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | struct LinePosition { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/guess_language.rs:96:63 [INFO] [stdout] | [INFO] [stdout] 96 | let lang = match mode_name.to_ascii_lowercase().trim().borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/options.rs:252:31 [INFO] [stdout] | [INFO] [stdout] 252 | match display_mode_str.borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.61s [INFO] running `Command { std: "docker" "inspect" "e514250f3547317a56a494a3267c73492d79c6d4186579a0eaef87ac85234d36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e514250f3547317a56a494a3267c73492d79c6d4186579a0eaef87ac85234d36", kill_on_drop: false }` [INFO] [stdout] e514250f3547317a56a494a3267c73492d79c6d4186579a0eaef87ac85234d36 [INFO] checking difftastic_mod_for_windows-0.27.0 against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] extracting crate difftastic_mod_for_windows 0.27.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate difftastic_mod_for_windows 0.27.0 on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate difftastic_mod_for_windows 0.27.0 [INFO] finished tweaking crates.io crate difftastic_mod_for_windows 0.27.0 [INFO] tweaked toml for crates.io crate difftastic_mod_for_windows 0.27.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate difftastic_mod_for_windows 0.27.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cbdf97986cb5e0371ee566443023e5f52220a6817bf115075485001ecdedba3e [INFO] running `Command { std: "docker" "start" "-a" "cbdf97986cb5e0371ee566443023e5f52220a6817bf115075485001ecdedba3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cbdf97986cb5e0371ee566443023e5f52220a6817bf115075485001ecdedba3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbdf97986cb5e0371ee566443023e5f52220a6817bf115075485001ecdedba3e", kill_on_drop: false }` [INFO] [stdout] cbdf97986cb5e0371ee566443023e5f52220a6817bf115075485001ecdedba3e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9754ac1ac2256b7bb7eb8455fec4106d9cf232fe06ec36405e2d9e84f7a433cf [INFO] running `Command { std: "docker" "start" "-a" "9754ac1ac2256b7bb7eb8455fec4106d9cf232fe06ec36405e2d9e84f7a433cf", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling scopeguard v1.1.0 [INFO] [stderr] Compiling quote v1.0.13 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.7 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling libmimalloc-sys v0.1.23 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling tree-sitter v0.20.5 [INFO] [stderr] Compiling any_terminal_size v0.1.21 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking archery v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking rpds v0.10.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking owo-colors v3.2.0 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking wu-diff v0.1.2 [INFO] [stderr] Checking radix-heap v0.4.2 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling crossbeam-channel v0.5.1 [INFO] [stderr] Checking typed-arena v2.0.1 [INFO] [stderr] Compiling const_format_proc_macros v0.2.22 [INFO] [stderr] Checking pretty_assertions v1.0.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Compiling crossbeam-deque v0.8.1 [INFO] [stderr] Compiling num_cpus v1.13.1 [INFO] [stderr] Checking clap v3.0.13 [INFO] [stderr] Checking mimalloc v0.1.27 [INFO] [stderr] Checking const_format v0.2.22 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling difftastic_mod_for_windows v0.27.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `LinePosition` is never constructed [INFO] [stdout] --> src/lines.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | struct LinePosition { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 10 | let lhs_res = fs::read(lhs_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let rhs_res = fs::read(rhs_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | [INFO] [stdout] 13 | match (lhs_res, rhs_res) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:223:18 [INFO] [stdout] | [INFO] [stdout] 209 | let (mut lhs_delims, rhs_delims) = match entered.peek() { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | let entered = if modifying_head { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | entered.push(EnteredDelimiter::PopEither((lhs_delims, rhs_delims))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:245:18 [INFO] [stdout] | [INFO] [stdout] 231 | let (lhs_delims, mut rhs_delims) = match entered.peek() { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | let entered = if modifying_head { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | entered.push(EnteredDelimiter::PopEither((lhs_delims, rhs_delims))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/guess_language.rs:96:63 [INFO] [stdout] | [INFO] [stdout] 96 | let lang = match mode_name.to_ascii_lowercase().trim().borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hunks.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn merge(self, other: &Self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let mut lhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut rhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | novel_lhs: self.novel_lhs.union(&other.novel_lhs).copied().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hunks.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn merge(self, other: &Self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let mut lhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut rhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | novel_rhs: self.novel_rhs.union(&other.novel_rhs).copied().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/options.rs:252:31 [INFO] [stdout] | [INFO] [stdout] 252 | match display_mode_str.borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree_sitter_parser.rs:606:5 [INFO] [stdout] | [INFO] [stdout] 601 | let mut parser = ts::Parser::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 606 | parser.parse(src, None).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `difftastic_mod_for_windows` (bin "difft") due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `LinePosition` is never constructed [INFO] [stdout] --> src/lines.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | struct LinePosition { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 10 | let lhs_res = fs::read(lhs_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let rhs_res = fs::read(rhs_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | [INFO] [stdout] 13 | match (lhs_res, rhs_res) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:223:18 [INFO] [stdout] | [INFO] [stdout] 209 | let (mut lhs_delims, rhs_delims) = match entered.peek() { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | let entered = if modifying_head { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | entered.push(EnteredDelimiter::PopEither((lhs_delims, rhs_delims))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:245:18 [INFO] [stdout] | [INFO] [stdout] 231 | let (lhs_delims, mut rhs_delims) = match entered.peek() { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | let entered = if modifying_head { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | entered.push(EnteredDelimiter::PopEither((lhs_delims, rhs_delims))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/guess_language.rs:96:63 [INFO] [stdout] | [INFO] [stdout] 96 | let lang = match mode_name.to_ascii_lowercase().trim().borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hunks.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn merge(self, other: &Self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let mut lhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut rhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | novel_lhs: self.novel_lhs.union(&other.novel_lhs).copied().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hunks.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn merge(self, other: &Self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let mut lhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut rhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | novel_rhs: self.novel_rhs.union(&other.novel_rhs).copied().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/options.rs:252:31 [INFO] [stdout] | [INFO] [stdout] 252 | match display_mode_str.borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree_sitter_parser.rs:606:5 [INFO] [stdout] | [INFO] [stdout] 601 | let mut parser = ts::Parser::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 606 | parser.parse(src, None).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `difftastic_mod_for_windows` (bin "difft" test) due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9754ac1ac2256b7bb7eb8455fec4106d9cf232fe06ec36405e2d9e84f7a433cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9754ac1ac2256b7bb7eb8455fec4106d9cf232fe06ec36405e2d9e84f7a433cf", kill_on_drop: false }` [INFO] [stdout] 9754ac1ac2256b7bb7eb8455fec4106d9cf232fe06ec36405e2d9e84f7a433cf