[INFO] fetching crate async_dataloader 0.1.3... [INFO] checking async_dataloader-0.1.3 against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] extracting crate async_dataloader 0.1.3 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate async_dataloader 0.1.3 on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async_dataloader 0.1.3 [INFO] finished tweaking crates.io crate async_dataloader 0.1.3 [INFO] tweaked toml for crates.io crate async_dataloader 0.1.3 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 518f5f376334b44040c39e41fd80a5a1377ed57ebd329595d62d237b1c8ccbf3 [INFO] running `Command { std: "docker" "start" "-a" "518f5f376334b44040c39e41fd80a5a1377ed57ebd329595d62d237b1c8ccbf3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "518f5f376334b44040c39e41fd80a5a1377ed57ebd329595d62d237b1c8ccbf3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "518f5f376334b44040c39e41fd80a5a1377ed57ebd329595d62d237b1c8ccbf3", kill_on_drop: false }` [INFO] [stdout] 518f5f376334b44040c39e41fd80a5a1377ed57ebd329595d62d237b1c8ccbf3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7be5942da876600d53747c88c89c3ebbf1cbf73cd8fcf1506eb1e8fa8eeecf9f [INFO] running `Command { std: "docker" "start" "-a" "7be5942da876600d53747c88c89c3ebbf1cbf73cd8fcf1506eb1e8fa8eeecf9f", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking async_dataloader v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused pinned boxed `futures::Future` trait object that must be used [INFO] [stdout] --> src/lib.rs:400:17 [INFO] [stdout] | [INFO] [stdout] 400 | batch_futures.remove(idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: futures do nothing unless you `.await` or poll them [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused pinned boxed `futures::Future` trait object that must be used [INFO] [stdout] --> src/lib.rs:400:17 [INFO] [stdout] | [INFO] [stdout] 400 | batch_futures.remove(idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: futures do nothing unless you `.await` or poll them [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.75s [INFO] running `Command { std: "docker" "inspect" "7be5942da876600d53747c88c89c3ebbf1cbf73cd8fcf1506eb1e8fa8eeecf9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7be5942da876600d53747c88c89c3ebbf1cbf73cd8fcf1506eb1e8fa8eeecf9f", kill_on_drop: false }` [INFO] [stdout] 7be5942da876600d53747c88c89c3ebbf1cbf73cd8fcf1506eb1e8fa8eeecf9f [INFO] checking async_dataloader-0.1.3 against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] extracting crate async_dataloader 0.1.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate async_dataloader 0.1.3 on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate async_dataloader 0.1.3 [INFO] finished tweaking crates.io crate async_dataloader 0.1.3 [INFO] tweaked toml for crates.io crate async_dataloader 0.1.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b68a7cc3d1bed9a444c6bfaed81fa9e75c1a52f932a717d3ca0d44dfea724ab [INFO] running `Command { std: "docker" "start" "-a" "1b68a7cc3d1bed9a444c6bfaed81fa9e75c1a52f932a717d3ca0d44dfea724ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b68a7cc3d1bed9a444c6bfaed81fa9e75c1a52f932a717d3ca0d44dfea724ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b68a7cc3d1bed9a444c6bfaed81fa9e75c1a52f932a717d3ca0d44dfea724ab", kill_on_drop: false }` [INFO] [stdout] 1b68a7cc3d1bed9a444c6bfaed81fa9e75c1a52f932a717d3ca0d44dfea724ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7923472cf5f97b747acc857abf404d8630748d0dd6cfe19e39795c8c26ad97f4 [INFO] running `Command { std: "docker" "start" "-a" "7923472cf5f97b747acc857abf404d8630748d0dd6cfe19e39795c8c26ad97f4", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking async_dataloader v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:24 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn batched(fut: F) -> Batched { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | batch_futures: Slab::new(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn batched(fut: F) -> Batched { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | ctx: Rc::new(RefCell::new(BatchContext { [INFO] [stdout] | ______________^ [INFO] [stdout] 41 | | accumulating: HashMap::new(), [INFO] [stdout] 42 | | postpone_loading: 0, [INFO] [stdout] 43 | | user_ctx: HashMap::new() [INFO] [stdout] 44 | | })) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:229:13 [INFO] [stdout] | [INFO] [stdout] 228 | poll.map(|val| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | val.downcast().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:254:22 [INFO] [stdout] | [INFO] [stdout] 252 | fn provide_batch_ctx(ctx: Rc>, cb: impl FnOnce() -> T) -> T { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | let existing_ctx = BATCH_CONTEXT.with(|cell| { [INFO] [stdout] 254 | cell.replace(Some(ctx)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:268:24 [INFO] [stdout] | [INFO] [stdout] 267 | pub fn with_batch_ctx(cb: impl FnOnce(&mut BatchContext) -> T) -> T { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | BATCH_CONTEXT.with(|cell| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 269 | | let ctx = cell.borrow(); [INFO] [stdout] 270 | | let ctx = ctx.as_ref().expect("Tried to call a batched loader outside of a batching context."); [INFO] [stdout] 271 | | let mut ctx = (&*ctx).borrow_mut(); [INFO] [stdout] 272 | | cb(&mut ctx) [INFO] [stdout] 273 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:417:31 [INFO] [stdout] | [INFO] [stdout] 407 | let batches = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | let mut ctx = (**ctx).borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | provide_batch_ctx(ctx.clone(), || { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:417:44 [INFO] [stdout] | [INFO] [stdout] 407 | let batches = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | let mut ctx = (**ctx).borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | provide_batch_ctx(ctx.clone(), || { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 418 | | for (loader, batch) in batches.into_iter() { [INFO] [stdout] 419 | | let mut fut = (loader)(batch); [INFO] [stdout] ... | [INFO] [stdout] 424 | | } [INFO] [stdout] 425 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused pinned boxed `futures::Future` trait object that must be used [INFO] [stdout] --> src/lib.rs:400:17 [INFO] [stdout] | [INFO] [stdout] 400 | batch_futures.remove(idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: futures do nothing unless you `.await` or poll them [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async_dataloader` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:24 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn batched(fut: F) -> Batched { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | batch_futures: Slab::new(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn batched(fut: F) -> Batched { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | ctx: Rc::new(RefCell::new(BatchContext { [INFO] [stdout] | ______________^ [INFO] [stdout] 41 | | accumulating: HashMap::new(), [INFO] [stdout] 42 | | postpone_loading: 0, [INFO] [stdout] 43 | | user_ctx: HashMap::new() [INFO] [stdout] 44 | | })) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:229:13 [INFO] [stdout] | [INFO] [stdout] 228 | poll.map(|val| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | val.downcast().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:254:22 [INFO] [stdout] | [INFO] [stdout] 252 | fn provide_batch_ctx(ctx: Rc>, cb: impl FnOnce() -> T) -> T { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | let existing_ctx = BATCH_CONTEXT.with(|cell| { [INFO] [stdout] 254 | cell.replace(Some(ctx)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:268:24 [INFO] [stdout] | [INFO] [stdout] 267 | pub fn with_batch_ctx(cb: impl FnOnce(&mut BatchContext) -> T) -> T { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | BATCH_CONTEXT.with(|cell| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 269 | | let ctx = cell.borrow(); [INFO] [stdout] 270 | | let ctx = ctx.as_ref().expect("Tried to call a batched loader outside of a batching context."); [INFO] [stdout] 271 | | let mut ctx = (&*ctx).borrow_mut(); [INFO] [stdout] 272 | | cb(&mut ctx) [INFO] [stdout] 273 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:417:31 [INFO] [stdout] | [INFO] [stdout] 407 | let batches = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | let mut ctx = (**ctx).borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | provide_batch_ctx(ctx.clone(), || { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:417:44 [INFO] [stdout] | [INFO] [stdout] 407 | let batches = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | let mut ctx = (**ctx).borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | provide_batch_ctx(ctx.clone(), || { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 418 | | for (loader, batch) in batches.into_iter() { [INFO] [stdout] 419 | | let mut fut = (loader)(batch); [INFO] [stdout] ... | [INFO] [stdout] 424 | | } [INFO] [stdout] 425 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused pinned boxed `futures::Future` trait object that must be used [INFO] [stdout] --> src/lib.rs:400:17 [INFO] [stdout] | [INFO] [stdout] 400 | batch_futures.remove(idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: futures do nothing unless you `.await` or poll them [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 108 | let inputs = batch.inputs.into_iter().map(|input| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | // It should be impossible to pass in an input of the wrong type through the public API [INFO] [stdout] 110 | input.downcast::<$input_ty>().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 463 | / def_batch_loader! { [INFO] [stdout] 464 | | /// Hello there! [INFO] [stdout] 465 | | pub async fn load_foobar_batched(inputs: u64) -> (Vec, String) { [INFO] [stdout] 466 | | let inputs: Vec<_> = inputs.map(|a| *a).collect(); [INFO] [stdout] ... | [INFO] [stdout] 474 | | } [INFO] [stdout] 475 | | } [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `def_batch_loader` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 108 | let inputs = batch.inputs.into_iter().map(|input| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | // It should be impossible to pass in an input of the wrong type through the public API [INFO] [stdout] 110 | input.downcast::<$input_ty>().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 521 | / def_batch_loader! { [INFO] [stdout] 522 | | pub async fn counter(inputs: &'static str) -> (&'static str, usize) { [INFO] [stdout] 523 | | inputs.map(|input| { [INFO] [stdout] 524 | | let count = super::with_batch_ctx(|ctx| { [INFO] [stdout] ... | [INFO] [stdout] 534 | | } [INFO] [stdout] 535 | | } [INFO] [stdout] | |_____________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `def_batch_loader` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async_dataloader` (lib test) due to 10 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "7923472cf5f97b747acc857abf404d8630748d0dd6cfe19e39795c8c26ad97f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7923472cf5f97b747acc857abf404d8630748d0dd6cfe19e39795c8c26ad97f4", kill_on_drop: false }` [INFO] [stdout] 7923472cf5f97b747acc857abf404d8630748d0dd6cfe19e39795c8c26ad97f4