[INFO] cloning repository https://github.com/zhxiaogg/surl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zhxiaogg/surl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzhxiaogg%2Fsurl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzhxiaogg%2Fsurl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7ac562af693e044868936ce5675f391e05c7b2ba [INFO] checking zhxiaogg/surl against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzhxiaogg%2Fsurl" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/zhxiaogg/surl on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/zhxiaogg/surl [INFO] finished tweaking git repo https://github.com/zhxiaogg/surl [INFO] tweaked toml for git repo https://github.com/zhxiaogg/surl written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/zhxiaogg/surl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded futures-sink-preview v0.3.0-alpha.19 [INFO] [stderr] Downloaded futures-io-preview v0.3.0-alpha.19 [INFO] [stderr] Downloaded tracing-attributes v0.1.5 [INFO] [stderr] Downloaded tokio-timer v0.3.0-alpha.6 [INFO] [stderr] Downloaded tower-service v0.3.0-alpha.2 [INFO] [stderr] Downloaded tokio v0.2.0-alpha.6 [INFO] [stderr] Downloaded http-body v0.2.0-alpha.3 [INFO] [stderr] Downloaded tower-make v0.3.0-alpha.2a [INFO] [stderr] Downloaded tracing-core v0.1.7 [INFO] [stderr] Downloaded sha-1 v0.8.1 [INFO] [stderr] Downloaded boxfnonce v0.1.1 [INFO] [stderr] Downloaded walkdir v2.2.9 [INFO] [stderr] Downloaded futures-preview v0.3.0-alpha.19 [INFO] [stderr] Downloaded ucd-trie v0.1.2 [INFO] [stderr] Downloaded pest v2.1.2 [INFO] [stderr] Downloaded hyper v0.13.0-alpha.4 [INFO] [stderr] Downloaded h2 v0.2.0-alpha.3 [INFO] [stderr] Downloaded syn v1.0.7 [INFO] [stderr] Downloaded tokio-net v0.2.0-alpha.6 [INFO] [stderr] Downloaded handlebars v2.0.2 [INFO] [stderr] Downloaded http v0.1.19 [INFO] [stderr] Downloaded serde_json v1.0.41 [INFO] [stderr] Downloaded pest_meta v2.1.2 [INFO] [stderr] Downloaded serde_derive v1.0.102 [INFO] [stderr] Downloaded pin-project v0.4.5 [INFO] [stderr] Downloaded daemonize v0.4.1 [INFO] [stderr] Downloaded same-file v1.0.5 [INFO] [stderr] Downloaded tokio-fs v0.2.0-alpha.6 [INFO] [stderr] Downloaded pin-project-internal v0.4.5 [INFO] [stderr] Downloaded tokio-io v0.2.0-alpha.6 [INFO] [stderr] Downloaded tracing v0.1.10 [INFO] [stderr] Downloaded pest_generator v2.1.1 [INFO] [stderr] Downloaded lock_api v0.3.1 [INFO] [stderr] Downloaded tokio-codec v0.2.0-alpha.6 [INFO] [stderr] Downloaded memoffset v0.5.2 [INFO] [stderr] Downloaded tokio-macros v0.2.0-alpha.6 [INFO] [stderr] Downloaded smallvec v0.6.12 [INFO] [stderr] Downloaded futures-executor-preview v0.3.0-alpha.19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2d2f0e578c49487f9c6f8e100e16e963f082dc7e3e4ce73b4d0f2e32ca24c137 [INFO] running `Command { std: "docker" "start" "-a" "2d2f0e578c49487f9c6f8e100e16e963f082dc7e3e4ce73b4d0f2e32ca24c137", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2d2f0e578c49487f9c6f8e100e16e963f082dc7e3e4ce73b4d0f2e32ca24c137", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d2f0e578c49487f9c6f8e100e16e963f082dc7e3e4ce73b4d0f2e32ca24c137", kill_on_drop: false }` [INFO] [stdout] 2d2f0e578c49487f9c6f8e100e16e963f082dc7e3e4ce73b4d0f2e32ca24c137 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a31fe4994d72029b98d34e44cad5ed207072044fc20f1b3cfd59eb2177244505 [INFO] running `Command { std: "docker" "start" "-a" "a31fe4994d72029b98d34e44cad5ed207072044fc20f1b3cfd59eb2177244505", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling syn v1.0.7 [INFO] [stderr] Checking futures-core-preview v0.3.0-alpha.19 [INFO] [stderr] Checking futures-sink-preview v0.3.0-alpha.19 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking futures-io-preview v0.3.0-alpha.19 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking memchr v2.2.1 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking tracing-core v0.1.7 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling memoffset v0.5.2 [INFO] [stderr] Compiling ucd-trie v0.1.2 [INFO] [stderr] Checking smallvec v0.6.12 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking futures-channel-preview v0.3.0-alpha.19 [INFO] [stderr] Checking tower-service v0.3.0-alpha.2 [INFO] [stderr] Compiling pest v2.1.2 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking boxfnonce v0.1.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking futures-util-preview v0.3.0-alpha.19 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.11.0 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking parking_lot_core v0.6.2 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking daemonize v0.4.1 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling pest_meta v2.1.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking parking_lot v0.9.0 [INFO] [stderr] Checking mio v0.6.19 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking http v0.1.19 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking tokio-sync v0.2.0-alpha.6 [INFO] [stderr] Checking futures-executor-preview v0.3.0-alpha.19 [INFO] [stderr] Checking futures-preview v0.3.0-alpha.19 [INFO] [stderr] Checking http-body v0.2.0-alpha.3 [INFO] [stderr] Compiling pest_generator v2.1.1 [INFO] [stderr] Compiling pin-project-internal v0.4.5 [INFO] [stderr] Compiling tracing-attributes v0.1.5 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Compiling tokio-macros v0.2.0-alpha.6 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking tracing v0.1.10 [INFO] [stderr] Checking tokio-executor v0.2.0-alpha.6 [INFO] [stderr] Checking pin-project v0.4.5 [INFO] [stderr] Checking tokio-io v0.2.0-alpha.6 [INFO] [stderr] Checking tokio-codec v0.2.0-alpha.6 [INFO] [stderr] Checking tower-make v0.3.0-alpha.2a [INFO] [stderr] Checking h2 v0.2.0-alpha.3 [INFO] [stderr] Checking tokio-timer v0.3.0-alpha.6 [INFO] [stderr] Checking tokio-fs v0.2.0-alpha.6 [INFO] [stderr] Checking tokio-net v0.2.0-alpha.6 [INFO] [stderr] Checking tokio v0.2.0-alpha.6 [INFO] [stderr] Checking hyper v0.13.0-alpha.4 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Checking hashbrown v0.5.0 [INFO] [stderr] Checking handlebars v2.0.2 [INFO] [stderr] Checking surl v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/cmds/http/path_var.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/server/tpl/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::from_str` [INFO] [stdout] --> src/server/tpl/mod.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | use serde_json::from_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HelperDef`, `JsonRender`, and `RenderError` [INFO] [stdout] --> src/utils/tpl.rs:2:34 [INFO] [stdout] | [INFO] [stdout] 2 | Context, Handlebars, Helper, HelperDef, HelperResult, JsonRender, Output, RenderContext, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] 3 | RenderError, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HelperDef`, `JsonRender`, and `RenderError` [INFO] [stdout] --> src/utils/tpl.rs:2:34 [INFO] [stdout] | [INFO] [stdout] 2 | Context, Handlebars, Helper, HelperDef, HelperResult, JsonRender, Output, RenderContext, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] 3 | RenderError, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `parts` [INFO] [stdout] --> src/server/internal.rs:45:22 [INFO] [stdout] | [INFO] [stdout] 45 | let (parts, mut body) = req.into_parts(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_parts` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `parts` [INFO] [stdout] --> src/server/internal.rs:45:22 [INFO] [stdout] | [INFO] [stdout] 45 | let (parts, mut body) = req.into_parts(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_parts` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/utils/tpl.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/utils/tpl.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server/mod.rs:46:27 [INFO] [stdout] | [INFO] [stdout] 46 | let (kill_sender, mut kill_receiver) = tokio::sync::oneshot::channel::<()>(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/utils/tpl.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | h: &Helper, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/utils/tpl.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | h: &Helper, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/cmds/server/startup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct StartupCmd { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 8 | config: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/cmds/server/stop.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct StopCmd { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 6 | config: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `address` is never read [INFO] [stdout] --> src/server/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct HttpServer { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 16 | address: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `stop`, `address`, and `port` are never used [INFO] [stdout] --> src/server/mod.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 20 | impl HttpServer { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | fn stop(&mut self) -> Result<(), String> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 95 | pub fn address(&self) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | pub fn port(&self) -> u16 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server/mod.rs:46:27 [INFO] [stdout] | [INFO] [stdout] 46 | let (kill_sender, mut kill_receiver) = tokio::sync::oneshot::channel::<()>(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/utils/tpl.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | h: &Helper, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/utils/tpl.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | h: &Helper, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/cmds/server/startup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct StartupCmd { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 8 | config: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/cmds/server/stop.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct StopCmd { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 6 | config: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `address` is never read [INFO] [stdout] --> src/server/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct HttpServer { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 16 | address: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `stop`, `address`, and `port` are never used [INFO] [stdout] --> src/server/mod.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 20 | impl HttpServer { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | fn stop(&mut self) -> Result<(), String> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 95 | pub fn address(&self) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | pub fn port(&self) -> u16 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.59s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: daemonize v0.4.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "a31fe4994d72029b98d34e44cad5ed207072044fc20f1b3cfd59eb2177244505", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a31fe4994d72029b98d34e44cad5ed207072044fc20f1b3cfd59eb2177244505", kill_on_drop: false }` [INFO] [stdout] a31fe4994d72029b98d34e44cad5ed207072044fc20f1b3cfd59eb2177244505 [INFO] checking zhxiaogg/surl against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzhxiaogg%2Fsurl" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/zhxiaogg/surl on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/zhxiaogg/surl [INFO] finished tweaking git repo https://github.com/zhxiaogg/surl [INFO] tweaked toml for git repo https://github.com/zhxiaogg/surl written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/zhxiaogg/surl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 56af7fc2478c7b79ff91eeae5a773e349563a37f8b3119e9fa2c222149355bbb [INFO] running `Command { std: "docker" "start" "-a" "56af7fc2478c7b79ff91eeae5a773e349563a37f8b3119e9fa2c222149355bbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "56af7fc2478c7b79ff91eeae5a773e349563a37f8b3119e9fa2c222149355bbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56af7fc2478c7b79ff91eeae5a773e349563a37f8b3119e9fa2c222149355bbb", kill_on_drop: false }` [INFO] [stdout] 56af7fc2478c7b79ff91eeae5a773e349563a37f8b3119e9fa2c222149355bbb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c4ec3ad0c8bc81e1d7d0b10db2100484bc2e866a1995edd85fb7ea64795e2c1 [INFO] running `Command { std: "docker" "start" "-a" "5c4ec3ad0c8bc81e1d7d0b10db2100484bc2e866a1995edd85fb7ea64795e2c1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling syn v1.0.7 [INFO] [stderr] Checking futures-core-preview v0.3.0-alpha.19 [INFO] [stderr] Checking futures-sink-preview v0.3.0-alpha.19 [INFO] [stderr] Checking futures-io-preview v0.3.0-alpha.19 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking memchr v2.2.1 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking tracing-core v0.1.7 [INFO] [stderr] Checking smallvec v0.6.12 [INFO] [stderr] Compiling memoffset v0.5.2 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling ucd-trie v0.1.2 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking tower-service v0.3.0-alpha.2 [INFO] [stderr] Checking futures-channel-preview v0.3.0-alpha.19 [INFO] [stderr] Compiling pest v2.1.2 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking futures-util-preview v0.3.0-alpha.19 [INFO] [stderr] Checking boxfnonce v0.1.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.11.0 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking parking_lot_core v0.6.2 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking daemonize v0.4.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking parking_lot v0.9.0 [INFO] [stderr] Checking mio v0.6.19 [INFO] [stderr] Compiling pest_meta v2.1.2 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking http v0.1.19 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking tokio-sync v0.2.0-alpha.6 [INFO] [stderr] Checking futures-executor-preview v0.3.0-alpha.19 [INFO] [stderr] Checking futures-preview v0.3.0-alpha.19 [INFO] [stderr] Checking http-body v0.2.0-alpha.3 [INFO] [stderr] Compiling pest_generator v2.1.1 [INFO] [stderr] Compiling pin-project-internal v0.4.5 [INFO] [stderr] Compiling tracing-attributes v0.1.5 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Compiling tokio-macros v0.2.0-alpha.6 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking tracing v0.1.10 [INFO] [stderr] Checking tokio-executor v0.2.0-alpha.6 [INFO] [stderr] Checking pin-project v0.4.5 [INFO] [stderr] Checking tokio-io v0.2.0-alpha.6 [INFO] [stderr] Checking tokio-codec v0.2.0-alpha.6 [INFO] [stderr] Checking tower-make v0.3.0-alpha.2a [INFO] [stderr] Checking h2 v0.2.0-alpha.3 [INFO] [stderr] Checking tokio-timer v0.3.0-alpha.6 [INFO] [stderr] Checking tokio-fs v0.2.0-alpha.6 [INFO] [stderr] Checking tokio-net v0.2.0-alpha.6 [INFO] [stderr] Checking tokio v0.2.0-alpha.6 [INFO] [stderr] Checking hyper v0.13.0-alpha.4 [INFO] [stderr] Checking hashbrown v0.5.0 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Checking handlebars v2.0.2 [INFO] [stderr] Checking surl v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/cmds/http/path_var.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/server/tpl/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::from_str` [INFO] [stdout] --> src/server/tpl/mod.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | use serde_json::from_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HelperDef`, `JsonRender`, and `RenderError` [INFO] [stdout] --> src/utils/tpl.rs:2:34 [INFO] [stdout] | [INFO] [stdout] 2 | Context, Handlebars, Helper, HelperDef, HelperResult, JsonRender, Output, RenderContext, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] 3 | RenderError, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HelperDef`, `JsonRender`, and `RenderError` [INFO] [stdout] --> src/utils/tpl.rs:2:34 [INFO] [stdout] | [INFO] [stdout] 2 | Context, Handlebars, Helper, HelperDef, HelperResult, JsonRender, Output, RenderContext, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] 3 | RenderError, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `parts` [INFO] [stdout] --> src/server/internal.rs:45:22 [INFO] [stdout] | [INFO] [stdout] 45 | let (parts, mut body) = req.into_parts(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_parts` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `parts` [INFO] [stdout] --> src/server/internal.rs:45:22 [INFO] [stdout] | [INFO] [stdout] 45 | let (parts, mut body) = req.into_parts(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_parts` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/utils/tpl.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/utils/tpl.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server/mod.rs:46:27 [INFO] [stdout] | [INFO] [stdout] 46 | let (kill_sender, mut kill_receiver) = tokio::sync::oneshot::channel::<()>(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/utils/tpl.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | h: &Helper, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/utils/tpl.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | h: &Helper, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/cmds/server/startup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct StartupCmd { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 8 | config: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/cmds/server/stop.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct StopCmd { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 6 | config: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `address` is never read [INFO] [stdout] --> src/server/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct HttpServer { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 16 | address: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `stop`, `address`, and `port` are never used [INFO] [stdout] --> src/server/mod.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 20 | impl HttpServer { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | fn stop(&mut self) -> Result<(), String> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 95 | pub fn address(&self) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | pub fn port(&self) -> u16 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds/mod.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 45 | fn add_http_directives(app: App<'static, 'static>) -> App<'static, 'static> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | / app.arg( [INFO] [stdout] 47 | | Arg::with_name("request") [INFO] [stdout] 48 | | .short("X") [INFO] [stdout] 49 | | .long("request") [INFO] [stdout] ... | [INFO] [stdout] 70 | | .takes_value(true), [INFO] [stdout] 71 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 45 | fn add_http_directives(app: App<'static, 'static>) -> App<'static, 'static> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | / Arg::with_name("header") [INFO] [stdout] 74 | | .short("H") [INFO] [stdout] 75 | | .long("header") [INFO] [stdout] 76 | | .value_name("LINE") [INFO] [stdout] 77 | | .help("response with custom headers") [INFO] [stdout] 78 | | .required(false) [INFO] [stdout] 79 | | .takes_value(true), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds/server/stop.rs:28:44 [INFO] [stdout] | [INFO] [stdout] 27 | let req = Request::post(url).body(Body::empty()).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Client::new().request(req).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds/http/mod.rs:66:44 [INFO] [stdout] | [INFO] [stdout] 65 | let req = Request::post(url).body(Body::from(json)).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Client::new().request(req).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 58 | let internal_service = internal_service.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let service_container = service_container.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | async move { [INFO] [stdout] 61 | Ok::<_, Error>(service_fn(move |req| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 62 | | let internal_service = internal_service.clone(); [INFO] [stdout] 63 | | let service_container = service_container.clone(); [INFO] [stdout] 64 | | async move { HttpServer::handler(req, internal_service, service_container).await } [INFO] [stdout] 65 | | })) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:64:96 [INFO] [stdout] | [INFO] [stdout] 61 | Ok::<_, Error>(service_fn(move |req| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let internal_service = internal_service.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let service_container = service_container.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | async move { HttpServer::handler(req, internal_service, service_container).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:74:66 [INFO] [stdout] | [INFO] [stdout] 46 | let (kill_sender, mut kill_receiver) = tokio::sync::oneshot::channel::<()>(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | tokio::timer::delay_for(Duration::from_millis(1000)).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/container.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 48 | let mut b = Response::builder(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(b.status(StatusCode::OK) [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | .body(self.body(service, ctx)) [INFO] [stdout] 54 | | .unwrap()) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/internal.rs:85:26 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(kill_sender: Sender<()>) -> ShutdownHandle { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | ShutdownHandle { [INFO] [stdout] 85 | kill_sender: Some(kill_sender), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/tpl/mod.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | .map(|ref s| serde_json::from_str::(s).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server/mod.rs:46:27 [INFO] [stdout] | [INFO] [stdout] 46 | let (kill_sender, mut kill_receiver) = tokio::sync::oneshot::channel::<()>(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/utils/tpl.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | h: &Helper, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/utils/tpl.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | h: &Helper, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/cmds/server/startup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct StartupCmd { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 8 | config: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/cmds/server/stop.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct StopCmd { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 6 | config: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `address` is never read [INFO] [stdout] --> src/server/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct HttpServer { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 16 | address: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `stop`, `address`, and `port` are never used [INFO] [stdout] --> src/server/mod.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 20 | impl HttpServer { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | fn stop(&mut self) -> Result<(), String> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 95 | pub fn address(&self) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | pub fn port(&self) -> u16 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds/mod.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 45 | fn add_http_directives(app: App<'static, 'static>) -> App<'static, 'static> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | / app.arg( [INFO] [stdout] 47 | | Arg::with_name("request") [INFO] [stdout] 48 | | .short("X") [INFO] [stdout] 49 | | .long("request") [INFO] [stdout] ... | [INFO] [stdout] 70 | | .takes_value(true), [INFO] [stdout] 71 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 45 | fn add_http_directives(app: App<'static, 'static>) -> App<'static, 'static> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | / Arg::with_name("header") [INFO] [stdout] 74 | | .short("H") [INFO] [stdout] 75 | | .long("header") [INFO] [stdout] 76 | | .value_name("LINE") [INFO] [stdout] 77 | | .help("response with custom headers") [INFO] [stdout] 78 | | .required(false) [INFO] [stdout] 79 | | .takes_value(true), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds/server/stop.rs:28:44 [INFO] [stdout] | [INFO] [stdout] 27 | let req = Request::post(url).body(Body::empty()).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Client::new().request(req).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds/http/mod.rs:66:44 [INFO] [stdout] | [INFO] [stdout] 65 | let req = Request::post(url).body(Body::from(json)).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Client::new().request(req).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 58 | let internal_service = internal_service.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let service_container = service_container.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | async move { [INFO] [stdout] 61 | Ok::<_, Error>(service_fn(move |req| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 62 | | let internal_service = internal_service.clone(); [INFO] [stdout] 63 | | let service_container = service_container.clone(); [INFO] [stdout] 64 | | async move { HttpServer::handler(req, internal_service, service_container).await } [INFO] [stdout] 65 | | })) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:64:96 [INFO] [stdout] | [INFO] [stdout] 61 | Ok::<_, Error>(service_fn(move |req| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let internal_service = internal_service.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let service_container = service_container.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | async move { HttpServer::handler(req, internal_service, service_container).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:74:66 [INFO] [stdout] | [INFO] [stdout] 46 | let (kill_sender, mut kill_receiver) = tokio::sync::oneshot::channel::<()>(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | tokio::timer::delay_for(Duration::from_millis(1000)).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/container.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 48 | let mut b = Response::builder(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(b.status(StatusCode::OK) [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | .body(self.body(service, ctx)) [INFO] [stdout] 54 | | .unwrap()) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/internal.rs:85:26 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(kill_sender: Sender<()>) -> ShutdownHandle { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | ShutdownHandle { [INFO] [stdout] 85 | kill_sender: Some(kill_sender), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/tpl/mod.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | .map(|ref s| serde_json::from_str::(s).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `surl` (bin "surl") due to 11 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 10 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `surl` (bin "surl" test) due to 11 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5c4ec3ad0c8bc81e1d7d0b10db2100484bc2e866a1995edd85fb7ea64795e2c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c4ec3ad0c8bc81e1d7d0b10db2100484bc2e866a1995edd85fb7ea64795e2c1", kill_on_drop: false }` [INFO] [stdout] 5c4ec3ad0c8bc81e1d7d0b10db2100484bc2e866a1995edd85fb7ea64795e2c1