[INFO] cloning repository https://github.com/zengzengzenghuy/circuit_build [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zengzengzenghuy/circuit_build" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzengzengzenghuy%2Fcircuit_build", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzengzengzenghuy%2Fcircuit_build'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7d9775a2e51383ff94945c51a4814d881fe04d57 [INFO] checking zengzengzenghuy/circuit_build against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzengzengzenghuy%2Fcircuit_build" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/zengzengzenghuy/circuit_build on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/zengzengzenghuy/circuit_build [INFO] finished tweaking git repo https://github.com/zengzengzenghuy/circuit_build [INFO] tweaked toml for git repo https://github.com/zengzengzenghuy/circuit_build written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/zengzengzenghuy/circuit_build already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [ERROR] error running command: no output for 300 seconds [ERROR] this task or one of its parent failed! [ERROR] no output for 300 seconds [ERROR] note: run with `RUST_BACKTRACE=1` to display a backtrace. [INFO] checking zengzengzenghuy/circuit_build against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzengzengzenghuy%2Fcircuit_build" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/zengzengzenghuy/circuit_build on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/zengzengzenghuy/circuit_build [INFO] finished tweaking git repo https://github.com/zengzengzenghuy/circuit_build [INFO] tweaked toml for git repo https://github.com/zengzengzenghuy/circuit_build written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/zengzengzenghuy/circuit_build already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [ERROR] error running command: no output for 300 seconds [INFO] checking zengzengzenghuy/circuit_build against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzengzengzenghuy%2Fcircuit_build" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/zengzengzenghuy/circuit_build on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/zengzengzenghuy/circuit_build [INFO] finished tweaking git repo https://github.com/zengzengzenghuy/circuit_build [INFO] tweaked toml for git repo https://github.com/zengzengzenghuy/circuit_build written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/zengzengzenghuy/circuit_build already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zeroize_derive v1.3.2 [INFO] [stderr] Downloaded once_cell v1.14.0 [INFO] [stderr] Downloaded ark-test-curves v0.3.0 [INFO] [stderr] Downloaded pest v2.3.0 [INFO] [stderr] Downloaded unicode-xid v0.2.3 [INFO] [stderr] Downloaded ark-ec v0.3.0 [INFO] [stderr] Downloaded thiserror-impl v1.0.34 [INFO] [stderr] Downloaded tracing v0.1.36 [INFO] [stderr] Downloaded tracing-core v0.1.29 [INFO] [stderr] Downloaded thiserror v1.0.34 [INFO] [stderr] Downloaded zeroize v1.5.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b74c55c2770faf31ece64ce3a798b57661c79c12d8af4f9a0e6e5106f3c4106d [INFO] running `Command { std: "docker" "start" "-a" "b74c55c2770faf31ece64ce3a798b57661c79c12d8af4f9a0e6e5106f3c4106d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b74c55c2770faf31ece64ce3a798b57661c79c12d8af4f9a0e6e5106f3c4106d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b74c55c2770faf31ece64ce3a798b57661c79c12d8af4f9a0e6e5106f3c4106d", kill_on_drop: false }` [INFO] [stdout] b74c55c2770faf31ece64ce3a798b57661c79c12d8af4f9a0e6e5106f3c4106d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3fcbb528ae53f0de1153635ef5c8e82694875277101404b7147ef9b5a56b594d [INFO] running `Command { std: "docker" "start" "-a" "3fcbb528ae53f0de1153635ef5c8e82694875277101404b7147ef9b5a56b594d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling ucd-trie v0.1.5 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling paste v1.0.9 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Checking ark-std v0.3.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking ark-serialize v0.3.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling thiserror-impl v1.0.34 [INFO] [stderr] Compiling zeroize_derive v1.3.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling ark-ff-asm v0.3.0 [INFO] [stderr] Compiling ark-ff-macros v0.3.0 [INFO] [stderr] Checking zeroize v1.5.7 [INFO] [stderr] Compiling thiserror v1.0.34 [INFO] [stderr] Compiling pest v2.3.0 [INFO] [stderr] Compiling semver-parser v0.10.2 [INFO] [stderr] Compiling semver v0.11.0 [INFO] [stderr] Compiling rustc_version v0.3.3 [INFO] [stderr] Compiling ark-ff v0.3.0 [INFO] [stderr] Checking ark-ec v0.3.0 [INFO] [stderr] Checking ark-test-curves v0.3.0 [INFO] [stderr] Checking cs_build v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `fs::File` and `io::Write` [INFO] [stdout] --> src/r1cs/constraint_system.rs:1028:15 [INFO] [stdout] | [INFO] [stdout] 1028 | use std::{fs::File, io::Write}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | unused, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = note: `#[warn(unused_imports)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a function [INFO] [stdout] --> src/lib.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn add_from_diff_crate(x: i32) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | missing_docs [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a module [INFO] [stdout] --> src/r1cs/mod.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | pub mod impl_lc; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a module [INFO] [stdout] --> src/r1cs/mod.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | pub mod constraint_system; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a module [INFO] [stdout] --> src/r1cs/mod.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | pub mod error; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a function [INFO] [stdout] --> src/r1cs/mod.rs:149:1 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn add_one(x: u8) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/r1cs/constraint_system.rs:739:9 [INFO] [stdout] | [INFO] [stdout] 739 | drop(&mut self.inner) [INFO] [stdout] | ^^^^^---------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut ConstraintSystemRef` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:760:18 [INFO] [stdout] | [INFO] [stdout] 759 | pub fn new(inner: ConstraintSystem) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 760 | Self::CS(Rc::new(RefCell::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:800:38 [INFO] [stdout] | [INFO] [stdout] 800 | self.inner().map_or((), |cs| cs.borrow_mut().set_mode(mode)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:807:33 [INFO] [stdout] | [INFO] [stdout] 807 | .map_or(false, |cs| cs.borrow().is_in_setup_mode()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:813:37 [INFO] [stdout] | [INFO] [stdout] 813 | self.inner().map_or(0, |cs| cs.borrow().num_constraints) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:820:29 [INFO] [stdout] | [INFO] [stdout] 820 | .map_or(0, |cs| cs.borrow().num_instance_variables) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:827:29 [INFO] [stdout] | [INFO] [stdout] 827 | .map_or(0, |cs| cs.borrow().num_witness_variables) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:844:30 [INFO] [stdout] | [INFO] [stdout] 844 | .map_or((), |cs| cs.borrow_mut().set_optimization_goal(goal)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:851:33 [INFO] [stdout] | [INFO] [stdout] 851 | .map_or(false, |cs| cs.borrow().should_construct_matrices()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:862:23 [INFO] [stdout] | [INFO] [stdout] 856 | pub fn new_input_variable(&self, f: Func) -> crate::r1cs::Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 862 | .and_then(|cs| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 863 | | if !self.is_in_setup_mode() { [INFO] [stdout] 864 | | // This is needed to avoid double-borrows, because `f` [INFO] [stdout] 865 | | // might itself mutably borrow `cs` (eg: `f = || g.value()`). [INFO] [stdout] ... | [INFO] [stdout] 870 | | } [INFO] [stdout] 871 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:882:23 [INFO] [stdout] | [INFO] [stdout] 876 | pub fn new_witness_variable(&self, f: Func) -> crate::r1cs::Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 882 | .and_then(|cs| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 883 | | if !self.is_in_setup_mode() { [INFO] [stdout] 884 | | // This is needed to avoid double-borrows, because `f` [INFO] [stdout] 885 | | // might itself mutably borrow `cs` (eg: `f = || g.value()`). [INFO] [stdout] ... | [INFO] [stdout] 890 | | } [INFO] [stdout] 891 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:899:28 [INFO] [stdout] | [INFO] [stdout] 899 | .and_then(|cs| cs.borrow_mut().new_lc(lc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:912:28 [INFO] [stdout] | [INFO] [stdout] 912 | .and_then(|cs| cs.borrow_mut().enforce_constraint(a, b, c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:942:36 [INFO] [stdout] | [INFO] [stdout] 942 | self.inner().and_then(|cs| cs.borrow().to_matrices()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:968:36 [INFO] [stdout] | [INFO] [stdout] 968 | self.inner().and_then(|cs| cs.borrow().assigned_value(v)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cs_build` (lib) due to 15 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/r1cs/constraint_system.rs:739:9 [INFO] [stdout] | [INFO] [stdout] 739 | drop(&mut self.inner) [INFO] [stdout] | ^^^^^---------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut ConstraintSystemRef` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:760:18 [INFO] [stdout] | [INFO] [stdout] 759 | pub fn new(inner: ConstraintSystem) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 760 | Self::CS(Rc::new(RefCell::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:800:38 [INFO] [stdout] | [INFO] [stdout] 800 | self.inner().map_or((), |cs| cs.borrow_mut().set_mode(mode)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:807:33 [INFO] [stdout] | [INFO] [stdout] 807 | .map_or(false, |cs| cs.borrow().is_in_setup_mode()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:813:37 [INFO] [stdout] | [INFO] [stdout] 813 | self.inner().map_or(0, |cs| cs.borrow().num_constraints) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:820:29 [INFO] [stdout] | [INFO] [stdout] 820 | .map_or(0, |cs| cs.borrow().num_instance_variables) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:827:29 [INFO] [stdout] | [INFO] [stdout] 827 | .map_or(0, |cs| cs.borrow().num_witness_variables) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:844:30 [INFO] [stdout] | [INFO] [stdout] 844 | .map_or((), |cs| cs.borrow_mut().set_optimization_goal(goal)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:851:33 [INFO] [stdout] | [INFO] [stdout] 851 | .map_or(false, |cs| cs.borrow().should_construct_matrices()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:862:23 [INFO] [stdout] | [INFO] [stdout] 856 | pub fn new_input_variable(&self, f: Func) -> crate::r1cs::Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 862 | .and_then(|cs| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 863 | | if !self.is_in_setup_mode() { [INFO] [stdout] 864 | | // This is needed to avoid double-borrows, because `f` [INFO] [stdout] 865 | | // might itself mutably borrow `cs` (eg: `f = || g.value()`). [INFO] [stdout] ... | [INFO] [stdout] 870 | | } [INFO] [stdout] 871 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:882:23 [INFO] [stdout] | [INFO] [stdout] 876 | pub fn new_witness_variable(&self, f: Func) -> crate::r1cs::Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 882 | .and_then(|cs| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 883 | | if !self.is_in_setup_mode() { [INFO] [stdout] 884 | | // This is needed to avoid double-borrows, because `f` [INFO] [stdout] 885 | | // might itself mutably borrow `cs` (eg: `f = || g.value()`). [INFO] [stdout] ... | [INFO] [stdout] 890 | | } [INFO] [stdout] 891 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:899:28 [INFO] [stdout] | [INFO] [stdout] 899 | .and_then(|cs| cs.borrow_mut().new_lc(lc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:912:28 [INFO] [stdout] | [INFO] [stdout] 912 | .and_then(|cs| cs.borrow_mut().enforce_constraint(a, b, c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:942:36 [INFO] [stdout] | [INFO] [stdout] 942 | self.inner().and_then(|cs| cs.borrow().to_matrices()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/r1cs/constraint_system.rs:968:36 [INFO] [stdout] | [INFO] [stdout] 968 | self.inner().and_then(|cs| cs.borrow().assigned_value(v)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `lastAccess` should have a snake case name [INFO] [stdout] --> src/r1cs/constraint_system.rs:1180:13 [INFO] [stdout] | [INFO] [stdout] 1180 | let lastAccess = Fr::one(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `last_access` [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | nonstandard_style, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(non_snake_case)]` implied by `#[warn(nonstandard_style)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `LA` should have a snake case name [INFO] [stdout] --> src/r1cs/constraint_system.rs:1182:13 [INFO] [stdout] | [INFO] [stdout] 1182 | let LA = cs.new_witness_variable(|| Ok(lastAccess))?; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `la` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `lastAccess` should have a snake case name [INFO] [stdout] --> src/r1cs/constraint_system.rs:1214:13 [INFO] [stdout] | [INFO] [stdout] 1214 | let lastAccess = cs.new_witness_variable(|| Ok(Fr::one()))?; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `last_access` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cs_build` (lib test) due to 15 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3fcbb528ae53f0de1153635ef5c8e82694875277101404b7147ef9b5a56b594d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fcbb528ae53f0de1153635ef5c8e82694875277101404b7147ef9b5a56b594d", kill_on_drop: false }` [INFO] [stdout] 3fcbb528ae53f0de1153635ef5c8e82694875277101404b7147ef9b5a56b594d