[INFO] cloning repository https://github.com/zam-5/SerialCLI-app [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zam-5/SerialCLI-app" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzam-5%2FSerialCLI-app", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzam-5%2FSerialCLI-app'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f6d5c1ce902cdea4cc329468f96981902d414618 [INFO] checking zam-5/SerialCLI-app against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzam-5%2FSerialCLI-app" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/zam-5/SerialCLI-app on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/zam-5/SerialCLI-app [INFO] finished tweaking git repo https://github.com/zam-5/SerialCLI-app [INFO] tweaked toml for git repo https://github.com/zam-5/SerialCLI-app written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/zam-5/SerialCLI-app already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0078e80655987a33b7b6a11c9b36fc23cf86db2979cff68f9708eb71789a73b1 [INFO] running `Command { std: "docker" "start" "-a" "0078e80655987a33b7b6a11c9b36fc23cf86db2979cff68f9708eb71789a73b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0078e80655987a33b7b6a11c9b36fc23cf86db2979cff68f9708eb71789a73b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0078e80655987a33b7b6a11c9b36fc23cf86db2979cff68f9708eb71789a73b1", kill_on_drop: false }` [INFO] [stdout] 0078e80655987a33b7b6a11c9b36fc23cf86db2979cff68f9708eb71789a73b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96c33ccf291c05674fb2596c5633ee289ff0a366b593813bbd6e9ec6276a506a [INFO] running `Command { std: "docker" "start" "-a" "96c33ccf291c05674fb2596c5633ee289ff0a366b593813bbd6e9ec6276a506a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Compiling nix v0.16.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking serialport v4.0.1 [INFO] [stderr] Checking serial_cli_app v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/shell.rs:66:59 [INFO] [stdout] | [INFO] [stdout] 66 | .for_each(|str| argv.push(String::from(str.clone()))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/shell.rs:66:59 [INFO] [stdout] | [INFO] [stdout] 66 | .for_each(|str| argv.push(String::from(str.clone()))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.24s [INFO] running `Command { std: "docker" "inspect" "96c33ccf291c05674fb2596c5633ee289ff0a366b593813bbd6e9ec6276a506a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96c33ccf291c05674fb2596c5633ee289ff0a366b593813bbd6e9ec6276a506a", kill_on_drop: false }` [INFO] [stdout] 96c33ccf291c05674fb2596c5633ee289ff0a366b593813bbd6e9ec6276a506a [INFO] checking zam-5/SerialCLI-app against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzam-5%2FSerialCLI-app" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/zam-5/SerialCLI-app on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/zam-5/SerialCLI-app [INFO] finished tweaking git repo https://github.com/zam-5/SerialCLI-app [INFO] tweaked toml for git repo https://github.com/zam-5/SerialCLI-app written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/zam-5/SerialCLI-app already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff1e824afce2635717e6cc1a9b74bb986bb517ce2e09f3790d81910cb9453f03 [INFO] running `Command { std: "docker" "start" "-a" "ff1e824afce2635717e6cc1a9b74bb986bb517ce2e09f3790d81910cb9453f03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff1e824afce2635717e6cc1a9b74bb986bb517ce2e09f3790d81910cb9453f03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff1e824afce2635717e6cc1a9b74bb986bb517ce2e09f3790d81910cb9453f03", kill_on_drop: false }` [INFO] [stdout] ff1e824afce2635717e6cc1a9b74bb986bb517ce2e09f3790d81910cb9453f03 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 020d1f1f65f75b33c46d5eee7b6912028d394d943a7d4b653efaf68c7e7b81c5 [INFO] running `Command { std: "docker" "start" "-a" "020d1f1f65f75b33c46d5eee7b6912028d394d943a7d4b653efaf68c7e7b81c5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Compiling nix v0.16.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking serialport v4.0.1 [INFO] [stderr] Checking serial_cli_app v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/communicator.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 9 | let port = match serialport::new(addr, baudrate) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | Ok(port) => port, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Ok(Self { port }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 29 | let communicator = match Communicator::new(port_name, 9600) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(c) => Arc::new(Mutex::new(c)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | input_buf: String::new(), [INFO] [stdout] 46 | | output_buf: String::new(), [INFO] [stdout] 47 | | communicator, [INFO] [stdout] 48 | | com_vec, [INFO] [stdout] 49 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/shell.rs:66:59 [INFO] [stdout] | [INFO] [stdout] 66 | .for_each(|str| argv.push(String::from(str.clone()))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/communicator.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 9 | let port = match serialport::new(addr, baudrate) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | Ok(port) => port, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Ok(Self { port }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 29 | let communicator = match Communicator::new(port_name, 9600) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(c) => Arc::new(Mutex::new(c)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | input_buf: String::new(), [INFO] [stdout] 46 | | output_buf: String::new(), [INFO] [stdout] 47 | | communicator, [INFO] [stdout] 48 | | com_vec, [INFO] [stdout] 49 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/shell.rs:66:59 [INFO] [stdout] | [INFO] [stdout] 66 | .for_each(|str| argv.push(String::from(str.clone()))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serial_cli_app` (bin "serial_cli_app") due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `serial_cli_app` (bin "serial_cli_app" test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "020d1f1f65f75b33c46d5eee7b6912028d394d943a7d4b653efaf68c7e7b81c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "020d1f1f65f75b33c46d5eee7b6912028d394d943a7d4b653efaf68c7e7b81c5", kill_on_drop: false }` [INFO] [stdout] 020d1f1f65f75b33c46d5eee7b6912028d394d943a7d4b653efaf68c7e7b81c5