[INFO] cloning repository https://github.com/wzhd/kseqi [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/wzhd/kseqi" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwzhd%2Fkseqi", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwzhd%2Fkseqi'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8cf7804ed7ee5f57884b9d6d4a101a7563f9ec6a [INFO] checking wzhd/kseqi against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwzhd%2Fkseqi" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/wzhd/kseqi on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/wzhd/kseqi [INFO] finished tweaking git repo https://github.com/wzhd/kseqi [INFO] tweaked toml for git repo https://github.com/wzhd/kseqi written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/wzhd/kseqi already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c3e58d13cc5d0646ed3d7dfc72c6397b90c726f8e6c574a65e95fc224ced380b [INFO] running `Command { std: "docker" "start" "-a" "c3e58d13cc5d0646ed3d7dfc72c6397b90c726f8e6c574a65e95fc224ced380b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c3e58d13cc5d0646ed3d7dfc72c6397b90c726f8e6c574a65e95fc224ced380b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3e58d13cc5d0646ed3d7dfc72c6397b90c726f8e6c574a65e95fc224ced380b", kill_on_drop: false }` [INFO] [stdout] c3e58d13cc5d0646ed3d7dfc72c6397b90c726f8e6c574a65e95fc224ced380b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28546ef89e79479c7b04cc80379eb11da8e1ba15e1d92a3e7c994910daa3f3e8 [INFO] running `Command { std: "docker" "start" "-a" "28546ef89e79479c7b04cc80379eb11da8e1ba15e1d92a3e7c994910daa3f3e8", kill_on_drop: false }` [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling x11-dl v2.20.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking kseqi-desktop v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/xdl/xinput2.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | Ok((xip2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - Ok((xip2)) [INFO] [stdout] 28 + Ok(xip2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/xinput2.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | let attach = (self.xidi.attachment ); [INFO] [stdout] | ^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 294 - let attach = (self.xidi.attachment ); [INFO] [stdout] 294 + let attach = self.xidi.attachment; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let event = (&*event); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - let event = (&*event); [INFO] [stdout] 115 + let event = &*event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:527:20 [INFO] [stdout] | [INFO] [stdout] 527 | kbs ^= (1 << b1p); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 527 - kbs ^= (1 << b1p); [INFO] [stdout] 527 + kbs ^= 1 << b1p; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | for (a) in self.acts.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 118 - for (a) in self.acts.iter() { [INFO] [stdout] 118 + for a in self.acts.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/conf/mod.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 173 | let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 173 - let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] 173 + let a = if &self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0 { "↘"}else {"↗"}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:213:43 [INFO] [stdout] | [INFO] [stdout] 213 | Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] 213 + Ok((input, a)) => if let Some(sqa) = a { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/signal.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | Ok((r)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - Ok((r)) [INFO] [stdout] 32 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lib.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | Some((de)) => { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - Some((de)) => { [INFO] [stdout] 192 + Some(de) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/xdl/xinput2.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | Ok((xip2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - Ok((xip2)) [INFO] [stdout] 28 + Ok(xip2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/xinput2.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | let attach = (self.xidi.attachment ); [INFO] [stdout] | ^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 294 - let attach = (self.xidi.attachment ); [INFO] [stdout] 294 + let attach = self.xidi.attachment; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let event = (&*event); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - let event = (&*event); [INFO] [stdout] 115 + let event = &*event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:527:20 [INFO] [stdout] | [INFO] [stdout] 527 | kbs ^= (1 << b1p); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 527 - kbs ^= (1 << b1p); [INFO] [stdout] 527 + kbs ^= 1 << b1p; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | for (a) in self.acts.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 118 - for (a) in self.acts.iter() { [INFO] [stdout] 118 + for a in self.acts.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/conf/mod.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 173 | let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 173 - let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] 173 + let a = if &self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0 { "↘"}else {"↗"}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:213:43 [INFO] [stdout] | [INFO] [stdout] 213 | Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] 213 + Ok((input, a)) => if let Some(sqa) = a { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:378:36 [INFO] [stdout] | [INFO] [stdout] 378 | let sv = SmoVec::from_iter((0..10)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 378 - let sv = SmoVec::from_iter((0..10)).unwrap(); [INFO] [stdout] 378 + let sv = SmoVec::from_iter(0..10).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:380:36 [INFO] [stdout] | [INFO] [stdout] 380 | let sv = SmoVec::from_iter((0..6)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 380 - let sv = SmoVec::from_iter((0..6)).unwrap(); [INFO] [stdout] 380 + let sv = SmoVec::from_iter(0..6).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:382:36 [INFO] [stdout] | [INFO] [stdout] 382 | let sv = SmoVec::from_iter((0..8)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 382 - let sv = SmoVec::from_iter((0..8)).unwrap(); [INFO] [stdout] 382 + let sv = SmoVec::from_iter(0..8).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:384:36 [INFO] [stdout] | [INFO] [stdout] 384 | let sv = SmoVec::from_iter((0..7)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 384 - let sv = SmoVec::from_iter((0..7)); [INFO] [stdout] 384 + let sv = SmoVec::from_iter(0..7); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/signal.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | Ok((r)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - Ok((r)) [INFO] [stdout] 32 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lib.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | Some((de)) => { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - Some((de)) => { [INFO] [stdout] 192 + Some(de) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `XFreer` is never constructed [INFO] [stdout] --> src/xdl/util.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | pub(crate) struct XFreer<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `HierarchyInfo` is never used [INFO] [stdout] --> src/xdl/data.rs:71:7 [INFO] [stdout] | [INFO] [stdout] 71 | trait HierarchyInfo { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_HierarchyChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | XI_HierarchyChanged => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_HIERARCHY_CHANGED` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_DeviceChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:295:17 [INFO] [stdout] | [INFO] [stdout] 295 | XI_DeviceChanged => Some(Event::XIDeviceChange(*(xcookie.data as *mut _))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_DEVICE_CHANGED` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadAccess` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | BadAccess => XlibErr::Access, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_ACCESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadValue` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | BadValue => XlibErr::Value, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `BAD_VALUE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadWindow` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | BadWindow => XlibErr::Window, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_WINDOW` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIKeyClass` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | XIKeyClass => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper case: `XIKEY_CLASS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterPointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | XIMasterPointer => Self::MasterPointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | XIMasterKeyboard => Self::MasterKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlavePointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | XISlavePointer => Self::SlavePointer, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlaveKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | XISlaveKeyboard => Self::SlaveKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIFloatingSlave` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | XIFloatingSlave => Self::FloatingSlave, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIFLOATING_SLAVE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyPress` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | XI_KeyPress => { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_PRESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyRelease` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | XI_KeyRelease => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_RELEASE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/bin/keyv.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] | ^^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] 22 + let Some(e) = x.recv_timeout(None) else { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `XFreer` is never constructed [INFO] [stdout] --> src/xdl/util.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | pub(crate) struct XFreer<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `HierarchyInfo` is never used [INFO] [stdout] --> src/xdl/data.rs:71:7 [INFO] [stdout] | [INFO] [stdout] 71 | trait HierarchyInfo { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_HierarchyChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | XI_HierarchyChanged => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_HIERARCHY_CHANGED` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_DeviceChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:295:17 [INFO] [stdout] | [INFO] [stdout] 295 | XI_DeviceChanged => Some(Event::XIDeviceChange(*(xcookie.data as *mut _))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_DEVICE_CHANGED` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadAccess` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | BadAccess => XlibErr::Access, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_ACCESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadValue` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | BadValue => XlibErr::Value, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `BAD_VALUE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadWindow` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | BadWindow => XlibErr::Window, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_WINDOW` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIKeyClass` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | XIKeyClass => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper case: `XIKEY_CLASS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterPointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | XIMasterPointer => Self::MasterPointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | XIMasterKeyboard => Self::MasterKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlavePointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | XISlavePointer => Self::SlavePointer, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlaveKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | XISlaveKeyboard => Self::SlaveKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIFloatingSlave` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | XIFloatingSlave => Self::FloatingSlave, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIFLOATING_SLAVE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyPress` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | XI_KeyPress => { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_PRESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyRelease` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | XI_KeyRelease => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_RELEASE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/bin/keyv.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] | ^^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] 22 + let Some(e) = x.recv_timeout(None) else { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 28 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.18s [INFO] running `Command { std: "docker" "inspect" "28546ef89e79479c7b04cc80379eb11da8e1ba15e1d92a3e7c994910daa3f3e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28546ef89e79479c7b04cc80379eb11da8e1ba15e1d92a3e7c994910daa3f3e8", kill_on_drop: false }` [INFO] [stdout] 28546ef89e79479c7b04cc80379eb11da8e1ba15e1d92a3e7c994910daa3f3e8 [INFO] checking wzhd/kseqi against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwzhd%2Fkseqi" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/wzhd/kseqi on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/wzhd/kseqi [INFO] finished tweaking git repo https://github.com/wzhd/kseqi [INFO] tweaked toml for git repo https://github.com/wzhd/kseqi written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/wzhd/kseqi already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eebfb5c140f879586d69893af7a7d22badb3dc094bda3b094075482c497a367b [INFO] running `Command { std: "docker" "start" "-a" "eebfb5c140f879586d69893af7a7d22badb3dc094bda3b094075482c497a367b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eebfb5c140f879586d69893af7a7d22badb3dc094bda3b094075482c497a367b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eebfb5c140f879586d69893af7a7d22badb3dc094bda3b094075482c497a367b", kill_on_drop: false }` [INFO] [stdout] eebfb5c140f879586d69893af7a7d22badb3dc094bda3b094075482c497a367b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c57b5ab73ac49184d2da1fe2800d8910dd165d1deee56a9e0f0a3a33ea5a88e [INFO] running `Command { std: "docker" "start" "-a" "2c57b5ab73ac49184d2da1fe2800d8910dd165d1deee56a9e0f0a3a33ea5a88e", kill_on_drop: false }` [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling x11-dl v2.20.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking kseqi-desktop v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/xdl/xinput2.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | Ok((xip2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - Ok((xip2)) [INFO] [stdout] 28 + Ok(xip2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/xinput2.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | let attach = (self.xidi.attachment ); [INFO] [stdout] | ^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 294 - let attach = (self.xidi.attachment ); [INFO] [stdout] 294 + let attach = self.xidi.attachment; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let event = (&*event); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - let event = (&*event); [INFO] [stdout] 115 + let event = &*event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:527:20 [INFO] [stdout] | [INFO] [stdout] 527 | kbs ^= (1 << b1p); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 527 - kbs ^= (1 << b1p); [INFO] [stdout] 527 + kbs ^= 1 << b1p; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | for (a) in self.acts.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 118 - for (a) in self.acts.iter() { [INFO] [stdout] 118 + for a in self.acts.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/conf/mod.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 173 | let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 173 - let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] 173 + let a = if &self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0 { "↘"}else {"↗"}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:213:43 [INFO] [stdout] | [INFO] [stdout] 213 | Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] 213 + Ok((input, a)) => if let Some(sqa) = a { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/signal.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | Ok((r)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - Ok((r)) [INFO] [stdout] 32 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lib.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | Some((de)) => { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - Some((de)) => { [INFO] [stdout] 192 + Some(de) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/xdl/xinput2.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | Ok((xip2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - Ok((xip2)) [INFO] [stdout] 28 + Ok(xip2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/xinput2.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | let attach = (self.xidi.attachment ); [INFO] [stdout] | ^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 294 - let attach = (self.xidi.attachment ); [INFO] [stdout] 294 + let attach = self.xidi.attachment; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let event = (&*event); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - let event = (&*event); [INFO] [stdout] 115 + let event = &*event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:527:20 [INFO] [stdout] | [INFO] [stdout] 527 | kbs ^= (1 << b1p); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 527 - kbs ^= (1 << b1p); [INFO] [stdout] 527 + kbs ^= 1 << b1p; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | for (a) in self.acts.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 118 - for (a) in self.acts.iter() { [INFO] [stdout] 118 + for a in self.acts.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/conf/mod.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 173 | let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 173 - let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] 173 + let a = if &self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0 { "↘"}else {"↗"}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:213:43 [INFO] [stdout] | [INFO] [stdout] 213 | Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] 213 + Ok((input, a)) => if let Some(sqa) = a { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:378:36 [INFO] [stdout] | [INFO] [stdout] 378 | let sv = SmoVec::from_iter((0..10)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 378 - let sv = SmoVec::from_iter((0..10)).unwrap(); [INFO] [stdout] 378 + let sv = SmoVec::from_iter(0..10).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:380:36 [INFO] [stdout] | [INFO] [stdout] 380 | let sv = SmoVec::from_iter((0..6)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 380 - let sv = SmoVec::from_iter((0..6)).unwrap(); [INFO] [stdout] 380 + let sv = SmoVec::from_iter(0..6).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:382:36 [INFO] [stdout] | [INFO] [stdout] 382 | let sv = SmoVec::from_iter((0..8)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 382 - let sv = SmoVec::from_iter((0..8)).unwrap(); [INFO] [stdout] 382 + let sv = SmoVec::from_iter(0..8).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:384:36 [INFO] [stdout] | [INFO] [stdout] 384 | let sv = SmoVec::from_iter((0..7)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 384 - let sv = SmoVec::from_iter((0..7)); [INFO] [stdout] 384 + let sv = SmoVec::from_iter(0..7); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/signal.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | Ok((r)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - Ok((r)) [INFO] [stdout] 32 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lib.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | Some((de)) => { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - Some((de)) => { [INFO] [stdout] 192 + Some(de) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `XFreer` is never constructed [INFO] [stdout] --> src/xdl/util.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | pub(crate) struct XFreer<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `HierarchyInfo` is never used [INFO] [stdout] --> src/xdl/data.rs:71:7 [INFO] [stdout] | [INFO] [stdout] 71 | trait HierarchyInfo { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:36 [INFO] [stdout] | [INFO] [stdout] 70 | let modifiers=with_xl(|xl| xl.unwrap().modifier_codes().iter().collect()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/mod.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 65 | pub(crate) fn with_xl(call: F)-> R [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | where F: FnOnce(Result<&Rc, &OpenError>) -> R { [INFO] [stdout] 67 | LOCAL_X.with(|lz|{ [INFO] [stdout] | __________________^ [INFO] [stdout] 68 | | if lz.borrow().uninit() { [INFO] [stdout] 69 | | match Xlib::open() { [INFO] [stdout] 70 | | Ok(xlib) => { [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/mod.rs:80:16 [INFO] [stdout] | [INFO] [stdout] 65 | pub(crate) fn with_xl(call: F)-> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | match &*lz.borrow() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/mod.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 137 | pub(crate) fn newx(xdpy: Rc) -> Result> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let xinput: XInput2 = open_xinput2(display)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | // if it fails, probably reached limit or lack memory [INFO] [stdout] 153 | let poll = Poll::new().expect("can't create epoll"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let mut sigr = quit_recver()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | xdp: xdpy, [INFO] [stdout] 162 | | rootwin, [INFO] [stdout] 163 | | display, [INFO] [stdout] ... | [INFO] [stdout] 167 | | xiopcode, [INFO] [stdout] 168 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/mod.rs:275:14 [INFO] [stdout] | [INFO] [stdout] 271 | let xe = self.xinput_dev_ev(&e); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | Some(Event::newx(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_HierarchyChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | XI_HierarchyChanged => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_HIERARCHY_CHANGED` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_DeviceChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:295:17 [INFO] [stdout] | [INFO] [stdout] 295 | XI_DeviceChanged => Some(Event::XIDeviceChange(*(xcookie.data as *mut _))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_DEVICE_CHANGED` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/mod.rs:435:12 [INFO] [stdout] | [INFO] [stdout] 432 | let lsl = unsafe{ [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 435 | Ok(SymsOfCodes{ syms: lsl, each: syms_each as usize , last: last as u8, }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadAccess` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | BadAccess => XlibErr::Access, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_ACCESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadValue` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | BadValue => XlibErr::Value, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `BAD_VALUE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadWindow` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | BadWindow => XlibErr::Window, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_WINDOW` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/xinput1.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 14 | let xin: XInput = XInput::open()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let xin= Rc::new(xin); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Xinput1{ xin, disp }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIKeyClass` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | XIKeyClass => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper case: `XIKEY_CLASS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterPointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | XIMasterPointer => Self::MasterPointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | XIMasterKeyboard => Self::MasterKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlavePointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | XISlavePointer => Self::SlavePointer, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlaveKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | XISlaveKeyboard => Self::SlaveKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIFloatingSlave` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | XIFloatingSlave => Self::FloatingSlave, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIFLOATING_SLAVE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyPress` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | XI_KeyPress => { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_PRESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyRelease` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | XI_KeyRelease => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_RELEASE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dev.rs:13:64 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(xinput: Xinput1) -> Self { Self { xinput, devs: Default::default() } } [INFO] [stdout] | --------------- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dev.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 36 | let xin =Xinput1::new(x.display)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let mut devs = Devs::new(xin); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut xtdev = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok( (xtdev, devs)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch.rs:36:26 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(xt: Xtestdl) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | sym_code: SymCode::new().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch/key_changer.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 51 | let xl: Rc = get_x().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let (cs, shif) = with_xl(|r| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let cs = cs?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | def_syms: cs.sym_key_code(), [INFO] [stdout] 64 | | mut_syms: v, [INFO] [stdout] 65 | | shift: shif, [INFO] [stdout] 66 | | xl, [INFO] [stdout] 67 | | uu: SpecUni::new(), [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kseqi-desktop` (lib) due to 12 previous errors; 24 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `XFreer` is never constructed [INFO] [stdout] --> src/xdl/util.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | pub(crate) struct XFreer<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `HierarchyInfo` is never used [INFO] [stdout] --> src/xdl/data.rs:71:7 [INFO] [stdout] | [INFO] [stdout] 71 | trait HierarchyInfo { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:36 [INFO] [stdout] | [INFO] [stdout] 70 | let modifiers=with_xl(|xl| xl.unwrap().modifier_codes().iter().collect()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/mod.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 65 | pub(crate) fn with_xl(call: F)-> R [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | where F: FnOnce(Result<&Rc, &OpenError>) -> R { [INFO] [stdout] 67 | LOCAL_X.with(|lz|{ [INFO] [stdout] | __________________^ [INFO] [stdout] 68 | | if lz.borrow().uninit() { [INFO] [stdout] 69 | | match Xlib::open() { [INFO] [stdout] 70 | | Ok(xlib) => { [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/mod.rs:80:16 [INFO] [stdout] | [INFO] [stdout] 65 | pub(crate) fn with_xl(call: F)-> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | match &*lz.borrow() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/mod.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 137 | pub(crate) fn newx(xdpy: Rc) -> Result> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let xinput: XInput2 = open_xinput2(display)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | // if it fails, probably reached limit or lack memory [INFO] [stdout] 153 | let poll = Poll::new().expect("can't create epoll"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let mut sigr = quit_recver()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | xdp: xdpy, [INFO] [stdout] 162 | | rootwin, [INFO] [stdout] 163 | | display, [INFO] [stdout] ... | [INFO] [stdout] 167 | | xiopcode, [INFO] [stdout] 168 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/mod.rs:275:14 [INFO] [stdout] | [INFO] [stdout] 271 | let xe = self.xinput_dev_ev(&e); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | Some(Event::newx(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_HierarchyChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | XI_HierarchyChanged => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_HIERARCHY_CHANGED` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_DeviceChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:295:17 [INFO] [stdout] | [INFO] [stdout] 295 | XI_DeviceChanged => Some(Event::XIDeviceChange(*(xcookie.data as *mut _))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_DEVICE_CHANGED` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/mod.rs:435:12 [INFO] [stdout] | [INFO] [stdout] 432 | let lsl = unsafe{ [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 435 | Ok(SymsOfCodes{ syms: lsl, each: syms_each as usize , last: last as u8, }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadAccess` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | BadAccess => XlibErr::Access, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_ACCESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadValue` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | BadValue => XlibErr::Value, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `BAD_VALUE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadWindow` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | BadWindow => XlibErr::Window, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_WINDOW` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xdl/xinput1.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 14 | let xin: XInput = XInput::open()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let xin= Rc::new(xin); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Xinput1{ xin, disp }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIKeyClass` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | XIKeyClass => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper case: `XIKEY_CLASS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterPointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | XIMasterPointer => Self::MasterPointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | XIMasterKeyboard => Self::MasterKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlavePointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | XISlavePointer => Self::SlavePointer, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlaveKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | XISlaveKeyboard => Self::SlaveKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIFloatingSlave` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | XIFloatingSlave => Self::FloatingSlave, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIFLOATING_SLAVE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyPress` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | XI_KeyPress => { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_PRESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyRelease` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | XI_KeyRelease => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_RELEASE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dev.rs:13:64 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(xinput: Xinput1) -> Self { Self { xinput, devs: Default::default() } } [INFO] [stdout] | --------------- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dev.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 36 | let xin =Xinput1::new(x.display)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let mut devs = Devs::new(xin); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut xtdev = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok( (xtdev, devs)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch.rs:36:26 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(xt: Xtestdl) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | sym_code: SymCode::new().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch/key_changer.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 51 | let xl: Rc = get_x().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let (cs, shif) = with_xl(|r| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let cs = cs?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | def_syms: cs.sym_key_code(), [INFO] [stdout] 64 | | mut_syms: v, [INFO] [stdout] 65 | | shift: shif, [INFO] [stdout] 66 | | xl, [INFO] [stdout] 67 | | uu: SpecUni::new(), [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 28 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kseqi-desktop` (lib test) due to 12 previous errors; 28 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2c57b5ab73ac49184d2da1fe2800d8910dd165d1deee56a9e0f0a3a33ea5a88e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c57b5ab73ac49184d2da1fe2800d8910dd165d1deee56a9e0f0a3a33ea5a88e", kill_on_drop: false }` [INFO] [stdout] 2c57b5ab73ac49184d2da1fe2800d8910dd165d1deee56a9e0f0a3a33ea5a88e