[INFO] cloning repository https://github.com/whiteand/protos-ts [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/whiteand/protos-ts" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwhiteand%2Fprotos-ts", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwhiteand%2Fprotos-ts'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7f137e4f6cf4377f9ad2f0b2803c23b100ffc9fd [INFO] checking whiteand/protos-ts against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwhiteand%2Fprotos-ts" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/whiteand/protos-ts on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/whiteand/protos-ts [INFO] finished tweaking git repo https://github.com/whiteand/protos-ts [INFO] tweaked toml for git repo https://github.com/whiteand/protos-ts written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/whiteand/protos-ts already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded path-clean v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d294845a3b0e5ffa220ba997468ba4c49c094f473abeb908e597878db379e11b [INFO] running `Command { std: "docker" "start" "-a" "d294845a3b0e5ffa220ba997468ba4c49c094f473abeb908e597878db379e11b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d294845a3b0e5ffa220ba997468ba4c49c094f473abeb908e597878db379e11b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d294845a3b0e5ffa220ba997468ba4c49c094f473abeb908e597878db379e11b", kill_on_drop: false }` [INFO] [stdout] d294845a3b0e5ffa220ba997468ba4c49c094f473abeb908e597878db379e11b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 405bf442ab9c43cd6ff2f9d833bb14305705839ad4cec271750ace0cbc420af0 [INFO] running `Command { std: "docker" "start" "-a" "405bf442ab9c43cd6ff2f9d833bb14305705839ad4cec271750ace0cbc420af0", kill_on_drop: false }` [INFO] [stderr] Checking path-clean v0.1.0 [INFO] [stderr] Checking protos-ts v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `or` and `not` are never used [INFO] [stdout] --> proto/compiler/ts/ast.rs:705:8 [INFO] [stdout] | [INFO] [stdout] 702 | pub(crate) trait ExpressionChain { [INFO] [stdout] | --------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 705 | fn or(&self, other: Rc) -> Expression; [INFO] [stdout] | ^^ [INFO] [stdout] 706 | fn not(&self) -> Expression; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `WrapableExpr` is never used [INFO] [stdout] --> proto/compiler/ts/ast.rs:709:18 [INFO] [stdout] | [INFO] [stdout] 709 | pub(crate) trait WrapableExpr { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `SetParent` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | pub(in crate::proto) trait SetParent { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ParentScope` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | pub(in crate::proto) trait ParentScope { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `RegisterDeclaration` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:20:28 [INFO] [stdout] | [INFO] [stdout] 20 | pub(in crate::proto) trait RegisterDeclaration { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/file_to_folder.rs:60:50 [INFO] [stdout] | [INFO] [stdout] 60 | let message_declaration = match message_scope.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ProtoScope` does not implement `Deref`, so calling `deref` on `&ProtoScope` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 60 - let message_declaration = match message_scope.deref() { [INFO] [stdout] 60 + let message_declaration = match message_scope { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ProtoScope`, implement `Clone` for it [INFO] [stdout] --> proto/proto_scope.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 + #[derive(Clone)] [INFO] [stdout] 20 | pub(crate) enum ProtoScope { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:438:63 [INFO] [stdout] | [INFO] [stdout] 438 | Expression::CallExpression(call_exrp) => call_exrp.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::CallExpression` does not implement `Deref`, so calling `deref` on `&ast::CallExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 438 - Expression::CallExpression(call_exrp) => call_exrp.deref().into(), [INFO] [stdout] 438 + Expression::CallExpression(call_exrp) => call_exrp.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::CallExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:502:1 [INFO] [stdout] | [INFO] [stdout] 502 + #[derive(Clone)] [INFO] [stdout] 503 | pub(crate) struct CallExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:457:36 [INFO] [stdout] | [INFO] [stdout] 457 | element_access_expr.deref().into() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::ElementAccessExpression` does not implement `Deref`, so calling `deref` on `&ast::ElementAccessExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 457 - element_access_expr.deref().into() [INFO] [stdout] 457 + element_access_expr.into() [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::ElementAccessExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:567:1 [INFO] [stdout] | [INFO] [stdout] 567 + #[derive(Clone)] [INFO] [stdout] 568 | pub(crate) struct ElementAccessExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:459:72 [INFO] [stdout] | [INFO] [stdout] 459 | Expression::PrefixUnaryExpression(unary_expr) => unary_expr.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::PrefixUnaryExpression` does not implement `Deref`, so calling `deref` on `&ast::PrefixUnaryExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 459 - Expression::PrefixUnaryExpression(unary_expr) => unary_expr.deref().into(), [INFO] [stdout] 459 + Expression::PrefixUnaryExpression(unary_expr) => unary_expr.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::PrefixUnaryExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:609:1 [INFO] [stdout] | [INFO] [stdout] 609 + #[derive(Clone)] [INFO] [stdout] 610 | pub(crate) struct PrefixUnaryExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:460:60 [INFO] [stdout] | [INFO] [stdout] 460 | Expression::ConditionalExpression(cond) => cond.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::ConditionalExpression` does not implement `Deref`, so calling `deref` on `&ast::ConditionalExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 460 - Expression::ConditionalExpression(cond) => cond.deref().into(), [INFO] [stdout] 460 + Expression::ConditionalExpression(cond) => cond.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::ConditionalExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:588:1 [INFO] [stdout] | [INFO] [stdout] 588 + #[derive(Clone)] [INFO] [stdout] 589 | pub(crate) struct ConditionalExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:693:55 [INFO] [stdout] | [INFO] [stdout] 693 | Statement::IfStatement(if_stmt) => if_stmt.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::IfStatement` does not implement `Deref`, so calling `deref` on `&ast::IfStatement` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 693 - Statement::IfStatement(if_stmt) => if_stmt.deref().into(), [INFO] [stdout] 693 + Statement::IfStatement(if_stmt) => if_stmt.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::IfStatement`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:943:1 [INFO] [stdout] | [INFO] [stdout] 943 + #[derive(Clone)] [INFO] [stdout] 944 | pub(crate) struct IfStatement { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:694:45 [INFO] [stdout] | [INFO] [stdout] 694 | Statement::Block(block) => block.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::Block` does not implement `Deref`, so calling `deref` on `&ast::Block` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 694 - Statement::Block(block) => block.deref().into(), [INFO] [stdout] 694 + Statement::Block(block) => block.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::Block`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:950:1 [INFO] [stdout] | [INFO] [stdout] 950 + #[derive(Clone)] [INFO] [stdout] 951 | pub(crate) struct Block { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> proto/syntax.rs:833:51 [INFO] [stdout] | [INFO] [stdout] 833 | let file_name = Rc::from(parts.last().unwrap().deref()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `or` and `not` are never used [INFO] [stdout] --> proto/compiler/ts/ast.rs:705:8 [INFO] [stdout] | [INFO] [stdout] 702 | pub(crate) trait ExpressionChain { [INFO] [stdout] | --------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 705 | fn or(&self, other: Rc) -> Expression; [INFO] [stdout] | ^^ [INFO] [stdout] 706 | fn not(&self) -> Expression; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `WrapableExpr` is never used [INFO] [stdout] --> proto/compiler/ts/ast.rs:709:18 [INFO] [stdout] | [INFO] [stdout] 709 | pub(crate) trait WrapableExpr { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `SetParent` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | pub(in crate::proto) trait SetParent { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ParentScope` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | pub(in crate::proto) trait ParentScope { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `RegisterDeclaration` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:20:28 [INFO] [stdout] | [INFO] [stdout] 20 | pub(in crate::proto) trait RegisterDeclaration { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/file_to_folder.rs:60:50 [INFO] [stdout] | [INFO] [stdout] 60 | let message_declaration = match message_scope.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ProtoScope` does not implement `Deref`, so calling `deref` on `&ProtoScope` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 60 - let message_declaration = match message_scope.deref() { [INFO] [stdout] 60 + let message_declaration = match message_scope { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ProtoScope`, implement `Clone` for it [INFO] [stdout] --> proto/proto_scope.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 + #[derive(Clone)] [INFO] [stdout] 20 | pub(crate) enum ProtoScope { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:438:63 [INFO] [stdout] | [INFO] [stdout] 438 | Expression::CallExpression(call_exrp) => call_exrp.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::CallExpression` does not implement `Deref`, so calling `deref` on `&ast::CallExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 438 - Expression::CallExpression(call_exrp) => call_exrp.deref().into(), [INFO] [stdout] 438 + Expression::CallExpression(call_exrp) => call_exrp.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::CallExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:502:1 [INFO] [stdout] | [INFO] [stdout] 502 + #[derive(Clone)] [INFO] [stdout] 503 | pub(crate) struct CallExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:457:36 [INFO] [stdout] | [INFO] [stdout] 457 | element_access_expr.deref().into() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::ElementAccessExpression` does not implement `Deref`, so calling `deref` on `&ast::ElementAccessExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 457 - element_access_expr.deref().into() [INFO] [stdout] 457 + element_access_expr.into() [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::ElementAccessExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:567:1 [INFO] [stdout] | [INFO] [stdout] 567 + #[derive(Clone)] [INFO] [stdout] 568 | pub(crate) struct ElementAccessExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:459:72 [INFO] [stdout] | [INFO] [stdout] 459 | Expression::PrefixUnaryExpression(unary_expr) => unary_expr.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::PrefixUnaryExpression` does not implement `Deref`, so calling `deref` on `&ast::PrefixUnaryExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 459 - Expression::PrefixUnaryExpression(unary_expr) => unary_expr.deref().into(), [INFO] [stdout] 459 + Expression::PrefixUnaryExpression(unary_expr) => unary_expr.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::PrefixUnaryExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:609:1 [INFO] [stdout] | [INFO] [stdout] 609 + #[derive(Clone)] [INFO] [stdout] 610 | pub(crate) struct PrefixUnaryExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:460:60 [INFO] [stdout] | [INFO] [stdout] 460 | Expression::ConditionalExpression(cond) => cond.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::ConditionalExpression` does not implement `Deref`, so calling `deref` on `&ast::ConditionalExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 460 - Expression::ConditionalExpression(cond) => cond.deref().into(), [INFO] [stdout] 460 + Expression::ConditionalExpression(cond) => cond.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::ConditionalExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:588:1 [INFO] [stdout] | [INFO] [stdout] 588 + #[derive(Clone)] [INFO] [stdout] 589 | pub(crate) struct ConditionalExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:693:55 [INFO] [stdout] | [INFO] [stdout] 693 | Statement::IfStatement(if_stmt) => if_stmt.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::IfStatement` does not implement `Deref`, so calling `deref` on `&ast::IfStatement` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 693 - Statement::IfStatement(if_stmt) => if_stmt.deref().into(), [INFO] [stdout] 693 + Statement::IfStatement(if_stmt) => if_stmt.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::IfStatement`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:943:1 [INFO] [stdout] | [INFO] [stdout] 943 + #[derive(Clone)] [INFO] [stdout] 944 | pub(crate) struct IfStatement { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:694:45 [INFO] [stdout] | [INFO] [stdout] 694 | Statement::Block(block) => block.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::Block` does not implement `Deref`, so calling `deref` on `&ast::Block` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 694 - Statement::Block(block) => block.deref().into(), [INFO] [stdout] 694 + Statement::Block(block) => block.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::Block`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:950:1 [INFO] [stdout] | [INFO] [stdout] 950 + #[derive(Clone)] [INFO] [stdout] 951 | pub(crate) struct Block { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> proto/syntax.rs:833:51 [INFO] [stdout] | [INFO] [stdout] 833 | let file_name = Rc::from(parts.last().unwrap().deref()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.59s [INFO] running `Command { std: "docker" "inspect" "405bf442ab9c43cd6ff2f9d833bb14305705839ad4cec271750ace0cbc420af0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "405bf442ab9c43cd6ff2f9d833bb14305705839ad4cec271750ace0cbc420af0", kill_on_drop: false }` [INFO] [stdout] 405bf442ab9c43cd6ff2f9d833bb14305705839ad4cec271750ace0cbc420af0 [INFO] checking whiteand/protos-ts against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwhiteand%2Fprotos-ts" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/whiteand/protos-ts on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/whiteand/protos-ts [INFO] finished tweaking git repo https://github.com/whiteand/protos-ts [INFO] tweaked toml for git repo https://github.com/whiteand/protos-ts written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/whiteand/protos-ts already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c1edf44ed627694f336e40f66574fe39d93799d72c75c976e3531bd2a50fcfd4 [INFO] running `Command { std: "docker" "start" "-a" "c1edf44ed627694f336e40f66574fe39d93799d72c75c976e3531bd2a50fcfd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c1edf44ed627694f336e40f66574fe39d93799d72c75c976e3531bd2a50fcfd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1edf44ed627694f336e40f66574fe39d93799d72c75c976e3531bd2a50fcfd4", kill_on_drop: false }` [INFO] [stdout] c1edf44ed627694f336e40f66574fe39d93799d72c75c976e3531bd2a50fcfd4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96060603e9d91ec7ebead1e488634203b0d3029cc1cd52c7b09fff115bcdcfe7 [INFO] running `Command { std: "docker" "start" "-a" "96060603e9d91ec7ebead1e488634203b0d3029cc1cd52c7b09fff115bcdcfe7", kill_on_drop: false }` [INFO] [stderr] Checking path-clean v0.1.0 [INFO] [stderr] Checking protos-ts v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `or` and `not` are never used [INFO] [stdout] --> proto/compiler/ts/ast.rs:705:8 [INFO] [stdout] | [INFO] [stdout] 702 | pub(crate) trait ExpressionChain { [INFO] [stdout] | --------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 705 | fn or(&self, other: Rc) -> Expression; [INFO] [stdout] | ^^ [INFO] [stdout] 706 | fn not(&self) -> Expression; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `WrapableExpr` is never used [INFO] [stdout] --> proto/compiler/ts/ast.rs:709:18 [INFO] [stdout] | [INFO] [stdout] 709 | pub(crate) trait WrapableExpr { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `SetParent` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | pub(in crate::proto) trait SetParent { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ParentScope` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | pub(in crate::proto) trait ParentScope { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `RegisterDeclaration` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:20:28 [INFO] [stdout] | [INFO] [stdout] 20 | pub(in crate::proto) trait RegisterDeclaration { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> main.rs:63:11 [INFO] [stdout] | [INFO] [stdout] 34 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let folder: Folder = match root_scope_to_folder(&root_scope, root_file_name) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | match commit_folder(&folder) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/package.rs:324:38 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn repeated(t: Self) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | FieldTypeReference::Repeated(Box::new(t)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:309:25 [INFO] [stdout] | [INFO] [stdout] 308 | pub fn array(t: Type) -> Type { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | Type::ArrayType(Box::new(t)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:379:29 [INFO] [stdout] | [INFO] [stdout] 375 | pub fn new(name: &str, _type: Type) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 379 | parameter_type: Rc::new(_type), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:386:15 [INFO] [stdout] | [INFO] [stdout] 383 | pub fn new_optional(name: &str, _type: Type) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | ..Self::new(name, _type) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1094:22 [INFO] [stdout] | [INFO] [stdout] 1090 | pub fn new(expression: Rc, default: DefaultClause) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1094 | default: default.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1127:22 [INFO] [stdout] | [INFO] [stdout] 1126 | fn from(s: SwitchStatement) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1127 | Self::Switch(s.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1133:21 [INFO] [stdout] | [INFO] [stdout] 1132 | fn from(wh: WhileStatement) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1133 | Self::While(Rc::new(wh)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1145:19 [INFO] [stdout] | [INFO] [stdout] 1144 | fn from(for_stmt: ForStatement) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1145 | Self::For(Rc::new(for_stmt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1175:33 [INFO] [stdout] | [INFO] [stdout] 1174 | fn from(list: VariableDeclarationList) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1175 | Self::VariableStatement(Rc::new(list)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1186:38 [INFO] [stdout] | [INFO] [stdout] 1185 | fn from(import_declaration: ImportDeclaration) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1186 | Statement::ImportDeclaration(Box::new(import_declaration)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1191:41 [INFO] [stdout] | [INFO] [stdout] 1190 | fn from(interface_declaration: InterfaceDeclaration) -> Self { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1191 | Statement::InterfaceDeclaration(Box::new(interface_declaration)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1196:40 [INFO] [stdout] | [INFO] [stdout] 1195 | fn from(interface_declaration: FunctionDeclaration) -> Self { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1196 | Statement::FunctionDeclaration(Box::new(interface_declaration)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1231:20 [INFO] [stdout] | [INFO] [stdout] 1230 | fn from(file: File) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1231 | Self::File(Box::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1236:22 [INFO] [stdout] | [INFO] [stdout] 1235 | fn from(folder: Folder) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1236 | Self::Folder(Box::new(folder)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1254:27 [INFO] [stdout] | [INFO] [stdout] 1253 | pub fn push_file(&mut self, file: File) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1254 | self.entries.push(file.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1316:24 [INFO] [stdout] | [INFO] [stdout] 1314 | fn place<'a, C: Into>(&'a mut self, child: C) -> StatementPlaceholder<'a, Self, C> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1315 | StatementPlaceholder { [INFO] [stdout] 1316 | statement: Some(child), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/encode_basic_repeated_type_field.rs:36:33 [INFO] [stdout] | [INFO] [stdout] 25 | let encode_elements_stmt = match field_type { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | ast::Statement::IfStatement(ast::IfStatement { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 37 | | expression: field_exists_expression, [INFO] [stdout] 38 | | then_statement: encode_elements_stmt.into(), [INFO] [stdout] 39 | | else_statement: None, [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/encode_enum_field.rs:44:33 [INFO] [stdout] | [INFO] [stdout] 30 | let encode_field_stmt = ast::Statement::Expression( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | ast::Statement::IfStatement(ast::IfStatement { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 45 | | expression: field_exists_expression, [INFO] [stdout] 46 | | then_statement: ast::Statement::from(ast::Block { [INFO] [stdout] 47 | | statements: vec![encode_field_stmt.into()], [INFO] [stdout] ... | [INFO] [stdout] 50 | | else_statement: None, [INFO] [stdout] 51 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `or` and `not` are never used [INFO] [stdout] --> proto/compiler/ts/ast.rs:705:8 [INFO] [stdout] | [INFO] [stdout] 702 | pub(crate) trait ExpressionChain { [INFO] [stdout] | --------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 705 | fn or(&self, other: Rc) -> Expression; [INFO] [stdout] | ^^ [INFO] [stdout] 706 | fn not(&self) -> Expression; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `WrapableExpr` is never used [INFO] [stdout] --> proto/compiler/ts/ast.rs:709:18 [INFO] [stdout] | [INFO] [stdout] 709 | pub(crate) trait WrapableExpr { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `SetParent` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | pub(in crate::proto) trait SetParent { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ParentScope` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | pub(in crate::proto) trait ParentScope { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `RegisterDeclaration` is never used [INFO] [stdout] --> proto/proto_scope/traits.rs:20:28 [INFO] [stdout] | [INFO] [stdout] 20 | pub(in crate::proto) trait RegisterDeclaration { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> main.rs:63:11 [INFO] [stdout] | [INFO] [stdout] 34 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let folder: Folder = match root_scope_to_folder(&root_scope, root_file_name) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | match commit_folder(&folder) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/package.rs:324:38 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn repeated(t: Self) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | FieldTypeReference::Repeated(Box::new(t)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:309:25 [INFO] [stdout] | [INFO] [stdout] 308 | pub fn array(t: Type) -> Type { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | Type::ArrayType(Box::new(t)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:379:29 [INFO] [stdout] | [INFO] [stdout] 375 | pub fn new(name: &str, _type: Type) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 379 | parameter_type: Rc::new(_type), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/file_to_folder.rs:60:50 [INFO] [stdout] | [INFO] [stdout] 60 | let message_declaration = match message_scope.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ProtoScope` does not implement `Deref`, so calling `deref` on `&ProtoScope` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 60 - let message_declaration = match message_scope.deref() { [INFO] [stdout] 60 + let message_declaration = match message_scope { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ProtoScope`, implement `Clone` for it [INFO] [stdout] --> proto/proto_scope.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 + #[derive(Clone)] [INFO] [stdout] 20 | pub(crate) enum ProtoScope { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:386:15 [INFO] [stdout] | [INFO] [stdout] 383 | pub fn new_optional(name: &str, _type: Type) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | ..Self::new(name, _type) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/get_relative_import.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | import_clause: ast::ImportClause { [INFO] [stdout] | ________________________^ [INFO] [stdout] 64 | | name: None, [INFO] [stdout] 65 | | named_bindings: Some(vec![ast::ImportSpecifier::new( [INFO] [stdout] 66 | | ast::Identifier::new(&imported_name).into(), [INFO] [stdout] 67 | | )]), [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | .into(), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:438:63 [INFO] [stdout] | [INFO] [stdout] 438 | Expression::CallExpression(call_exrp) => call_exrp.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::CallExpression` does not implement `Deref`, so calling `deref` on `&ast::CallExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 438 - Expression::CallExpression(call_exrp) => call_exrp.deref().into(), [INFO] [stdout] 438 + Expression::CallExpression(call_exrp) => call_exrp.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::CallExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:502:1 [INFO] [stdout] | [INFO] [stdout] 502 + #[derive(Clone)] [INFO] [stdout] 503 | pub(crate) struct CallExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:457:36 [INFO] [stdout] | [INFO] [stdout] 457 | element_access_expr.deref().into() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::ElementAccessExpression` does not implement `Deref`, so calling `deref` on `&ast::ElementAccessExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 457 - element_access_expr.deref().into() [INFO] [stdout] 457 + element_access_expr.into() [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::ElementAccessExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:567:1 [INFO] [stdout] | [INFO] [stdout] 567 + #[derive(Clone)] [INFO] [stdout] 568 | pub(crate) struct ElementAccessExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1094:22 [INFO] [stdout] | [INFO] [stdout] 1090 | pub fn new(expression: Rc, default: DefaultClause) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1094 | default: default.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:459:72 [INFO] [stdout] | [INFO] [stdout] 459 | Expression::PrefixUnaryExpression(unary_expr) => unary_expr.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::PrefixUnaryExpression` does not implement `Deref`, so calling `deref` on `&ast::PrefixUnaryExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 459 - Expression::PrefixUnaryExpression(unary_expr) => unary_expr.deref().into(), [INFO] [stdout] 459 + Expression::PrefixUnaryExpression(unary_expr) => unary_expr.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::PrefixUnaryExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:609:1 [INFO] [stdout] | [INFO] [stdout] 609 + #[derive(Clone)] [INFO] [stdout] 610 | pub(crate) struct PrefixUnaryExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:460:60 [INFO] [stdout] | [INFO] [stdout] 460 | Expression::ConditionalExpression(cond) => cond.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::ConditionalExpression` does not implement `Deref`, so calling `deref` on `&ast::ConditionalExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 460 - Expression::ConditionalExpression(cond) => cond.deref().into(), [INFO] [stdout] 460 + Expression::ConditionalExpression(cond) => cond.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::ConditionalExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:588:1 [INFO] [stdout] | [INFO] [stdout] 588 + #[derive(Clone)] [INFO] [stdout] 589 | pub(crate) struct ConditionalExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1127:22 [INFO] [stdout] | [INFO] [stdout] 1126 | fn from(s: SwitchStatement) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1127 | Self::Switch(s.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1133:21 [INFO] [stdout] | [INFO] [stdout] 1132 | fn from(wh: WhileStatement) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1133 | Self::While(Rc::new(wh)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1145:19 [INFO] [stdout] | [INFO] [stdout] 1144 | fn from(for_stmt: ForStatement) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1145 | Self::For(Rc::new(for_stmt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:693:55 [INFO] [stdout] | [INFO] [stdout] 693 | Statement::IfStatement(if_stmt) => if_stmt.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::IfStatement` does not implement `Deref`, so calling `deref` on `&ast::IfStatement` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 693 - Statement::IfStatement(if_stmt) => if_stmt.deref().into(), [INFO] [stdout] 693 + Statement::IfStatement(if_stmt) => if_stmt.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::IfStatement`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:943:1 [INFO] [stdout] | [INFO] [stdout] 943 + #[derive(Clone)] [INFO] [stdout] 944 | pub(crate) struct IfStatement { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1175:33 [INFO] [stdout] | [INFO] [stdout] 1174 | fn from(list: VariableDeclarationList) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1175 | Self::VariableStatement(Rc::new(list)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:694:45 [INFO] [stdout] | [INFO] [stdout] 694 | Statement::Block(block) => block.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::Block` does not implement `Deref`, so calling `deref` on `&ast::Block` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 694 - Statement::Block(block) => block.deref().into(), [INFO] [stdout] 694 + Statement::Block(block) => block.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::Block`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:950:1 [INFO] [stdout] | [INFO] [stdout] 950 + #[derive(Clone)] [INFO] [stdout] 951 | pub(crate) struct Block { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1186:38 [INFO] [stdout] | [INFO] [stdout] 1185 | fn from(import_declaration: ImportDeclaration) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1186 | Statement::ImportDeclaration(Box::new(import_declaration)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1191:41 [INFO] [stdout] | [INFO] [stdout] 1190 | fn from(interface_declaration: InterfaceDeclaration) -> Self { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1191 | Statement::InterfaceDeclaration(Box::new(interface_declaration)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1196:40 [INFO] [stdout] | [INFO] [stdout] 1195 | fn from(interface_declaration: FunctionDeclaration) -> Self { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1196 | Statement::FunctionDeclaration(Box::new(interface_declaration)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1231:20 [INFO] [stdout] | [INFO] [stdout] 1230 | fn from(file: File) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1231 | Self::File(Box::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1236:22 [INFO] [stdout] | [INFO] [stdout] 1235 | fn from(folder: Folder) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1236 | Self::Folder(Box::new(folder)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1254:27 [INFO] [stdout] | [INFO] [stdout] 1253 | pub fn push_file(&mut self, file: File) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1254 | self.entries.push(file.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/ast.rs:1316:24 [INFO] [stdout] | [INFO] [stdout] 1314 | fn place<'a, C: Into>(&'a mut self, child: C) -> StatementPlaceholder<'a, Self, C> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1315 | StatementPlaceholder { [INFO] [stdout] 1316 | statement: Some(child), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/encode_basic_repeated_type_field.rs:36:33 [INFO] [stdout] | [INFO] [stdout] 25 | let encode_elements_stmt = match field_type { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | ast::Statement::IfStatement(ast::IfStatement { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 37 | | expression: field_exists_expression, [INFO] [stdout] 38 | | then_statement: encode_elements_stmt.into(), [INFO] [stdout] 39 | | else_statement: None, [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/encode_enum_field.rs:44:33 [INFO] [stdout] | [INFO] [stdout] 30 | let encode_field_stmt = ast::Statement::Expression( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | ast::Statement::IfStatement(ast::IfStatement { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 45 | | expression: field_exists_expression, [INFO] [stdout] 46 | | then_statement: ast::Statement::from(ast::Block { [INFO] [stdout] 47 | | statements: vec![encode_field_stmt.into()], [INFO] [stdout] ... | [INFO] [stdout] 50 | | else_statement: None, [INFO] [stdout] 51 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> proto/syntax.rs:833:51 [INFO] [stdout] | [INFO] [stdout] 833 | let file_name = Rc::from(parts.last().unwrap().deref()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:322:19 [INFO] [stdout] | [INFO] [stdout] 320 | fn new_package(name: Rc, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | Self { [INFO] [stdout] 322 | data: ScopeData::Package(PackageData { name }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:323:23 [INFO] [stdout] | [INFO] [stdout] 320 | fn new_package(name: Rc, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:324:21 [INFO] [stdout] | [INFO] [stdout] 320 | fn new_package(name: Rc, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | parent: Some(Rc::downgrade(&parent)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:333:19 [INFO] [stdout] | [INFO] [stdout] 330 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | data: ScopeData::File(FileData { name, imports }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:334:23 [INFO] [stdout] | [INFO] [stdout] 330 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:335:21 [INFO] [stdout] | [INFO] [stdout] 330 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | parent: Some(Rc::downgrade(&parent)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:346:19 [INFO] [stdout] | [INFO] [stdout] 342 | fields: Vec, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | data: ScopeData::Message(MessageData { name, fields, id }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:347:23 [INFO] [stdout] | [INFO] [stdout] 342 | fields: Vec, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 347 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:348:21 [INFO] [stdout] | [INFO] [stdout] 342 | fields: Vec, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | parent: Some(Rc::downgrade(&parent)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:354:19 [INFO] [stdout] | [INFO] [stdout] 352 | fn new_enum(e: EnumDeclaration, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | Self { [INFO] [stdout] 354 | data: ScopeData::Enum(e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:355:23 [INFO] [stdout] | [INFO] [stdout] 352 | fn new_enum(e: EnumDeclaration, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:356:21 [INFO] [stdout] | [INFO] [stdout] 352 | fn new_enum(e: EnumDeclaration, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | parent: Some(Rc::downgrade(&parent)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:395:21 [INFO] [stdout] | [INFO] [stdout] 395 | |c| c.borrow().is_file_with_name(imp) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:627:18 [INFO] [stdout] | [INFO] [stdout] 627 | .map(|p| builder.get_builder_by_absolute_path(&p).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:739:27 [INFO] [stdout] | [INFO] [stdout] 739 | .and_then(|w| w.borrow().get_type()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder/well_known/wrappers.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 54 | field_type: FieldTypeReference, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | ) -> MessageData { [INFO] [stdout] 56 | id_gen.create(( [INFO] [stdout] | ___________________^ [INFO] [stdout] 57 | | wrapper_name.into(), [INFO] [stdout] 58 | | vec![FieldDeclaration::new("value", field_type, 1).into()], [INFO] [stdout] 59 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/file_to_folder.rs:60:50 [INFO] [stdout] | [INFO] [stdout] 60 | let message_declaration = match message_scope.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ProtoScope` does not implement `Deref`, so calling `deref` on `&ProtoScope` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 60 - let message_declaration = match message_scope.deref() { [INFO] [stdout] 60 + let message_declaration = match message_scope { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ProtoScope`, implement `Clone` for it [INFO] [stdout] --> proto/proto_scope.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 + #[derive(Clone)] [INFO] [stdout] 20 | pub(crate) enum ProtoScope { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/compiler/ts/get_relative_import.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | import_clause: ast::ImportClause { [INFO] [stdout] | ________________________^ [INFO] [stdout] 64 | | name: None, [INFO] [stdout] 65 | | named_bindings: Some(vec![ast::ImportSpecifier::new( [INFO] [stdout] 66 | | ast::Identifier::new(&imported_name).into(), [INFO] [stdout] 67 | | )]), [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | .into(), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:438:63 [INFO] [stdout] | [INFO] [stdout] 438 | Expression::CallExpression(call_exrp) => call_exrp.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::CallExpression` does not implement `Deref`, so calling `deref` on `&ast::CallExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 438 - Expression::CallExpression(call_exrp) => call_exrp.deref().into(), [INFO] [stdout] 438 + Expression::CallExpression(call_exrp) => call_exrp.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::CallExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:502:1 [INFO] [stdout] | [INFO] [stdout] 502 + #[derive(Clone)] [INFO] [stdout] 503 | pub(crate) struct CallExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:457:36 [INFO] [stdout] | [INFO] [stdout] 457 | element_access_expr.deref().into() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::ElementAccessExpression` does not implement `Deref`, so calling `deref` on `&ast::ElementAccessExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 457 - element_access_expr.deref().into() [INFO] [stdout] 457 + element_access_expr.into() [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::ElementAccessExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:567:1 [INFO] [stdout] | [INFO] [stdout] 567 + #[derive(Clone)] [INFO] [stdout] 568 | pub(crate) struct ElementAccessExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:459:72 [INFO] [stdout] | [INFO] [stdout] 459 | Expression::PrefixUnaryExpression(unary_expr) => unary_expr.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::PrefixUnaryExpression` does not implement `Deref`, so calling `deref` on `&ast::PrefixUnaryExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 459 - Expression::PrefixUnaryExpression(unary_expr) => unary_expr.deref().into(), [INFO] [stdout] 459 + Expression::PrefixUnaryExpression(unary_expr) => unary_expr.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::PrefixUnaryExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:609:1 [INFO] [stdout] | [INFO] [stdout] 609 + #[derive(Clone)] [INFO] [stdout] 610 | pub(crate) struct PrefixUnaryExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:460:60 [INFO] [stdout] | [INFO] [stdout] 460 | Expression::ConditionalExpression(cond) => cond.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::ConditionalExpression` does not implement `Deref`, so calling `deref` on `&ast::ConditionalExpression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 460 - Expression::ConditionalExpression(cond) => cond.deref().into(), [INFO] [stdout] 460 + Expression::ConditionalExpression(cond) => cond.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::ConditionalExpression`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:588:1 [INFO] [stdout] | [INFO] [stdout] 588 + #[derive(Clone)] [INFO] [stdout] 589 | pub(crate) struct ConditionalExpression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:693:55 [INFO] [stdout] | [INFO] [stdout] 693 | Statement::IfStatement(if_stmt) => if_stmt.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::IfStatement` does not implement `Deref`, so calling `deref` on `&ast::IfStatement` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 693 - Statement::IfStatement(if_stmt) => if_stmt.deref().into(), [INFO] [stdout] 693 + Statement::IfStatement(if_stmt) => if_stmt.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::IfStatement`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:943:1 [INFO] [stdout] | [INFO] [stdout] 943 + #[derive(Clone)] [INFO] [stdout] 944 | pub(crate) struct IfStatement { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> proto/compiler/ts/render_file.rs:694:45 [INFO] [stdout] | [INFO] [stdout] 694 | Statement::Block(block) => block.deref().into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::Block` does not implement `Deref`, so calling `deref` on `&ast::Block` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 694 - Statement::Block(block) => block.deref().into(), [INFO] [stdout] 694 + Statement::Block(block) => block.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::Block`, implement `Clone` for it [INFO] [stdout] --> proto/compiler/ts/ast.rs:950:1 [INFO] [stdout] | [INFO] [stdout] 950 + #[derive(Clone)] [INFO] [stdout] 951 | pub(crate) struct Block { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> proto/syntax.rs:833:51 [INFO] [stdout] | [INFO] [stdout] 833 | let file_name = Rc::from(parts.last().unwrap().deref()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:322:19 [INFO] [stdout] | [INFO] [stdout] 320 | fn new_package(name: Rc, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | Self { [INFO] [stdout] 322 | data: ScopeData::Package(PackageData { name }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:323:23 [INFO] [stdout] | [INFO] [stdout] 320 | fn new_package(name: Rc, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:324:21 [INFO] [stdout] | [INFO] [stdout] 320 | fn new_package(name: Rc, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | parent: Some(Rc::downgrade(&parent)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:333:19 [INFO] [stdout] | [INFO] [stdout] 330 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | data: ScopeData::File(FileData { name, imports }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:334:23 [INFO] [stdout] | [INFO] [stdout] 330 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:335:21 [INFO] [stdout] | [INFO] [stdout] 330 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | parent: Some(Rc::downgrade(&parent)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:346:19 [INFO] [stdout] | [INFO] [stdout] 342 | fields: Vec, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | data: ScopeData::Message(MessageData { name, fields, id }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:347:23 [INFO] [stdout] | [INFO] [stdout] 342 | fields: Vec, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 347 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:348:21 [INFO] [stdout] | [INFO] [stdout] 342 | fields: Vec, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | parent: Rc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | parent: Some(Rc::downgrade(&parent)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:354:19 [INFO] [stdout] | [INFO] [stdout] 352 | fn new_enum(e: EnumDeclaration, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | Self { [INFO] [stdout] 354 | data: ScopeData::Enum(e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:355:23 [INFO] [stdout] | [INFO] [stdout] 352 | fn new_enum(e: EnumDeclaration, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:356:21 [INFO] [stdout] | [INFO] [stdout] 352 | fn new_enum(e: EnumDeclaration, parent: Rc>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | parent: Some(Rc::downgrade(&parent)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:395:21 [INFO] [stdout] | [INFO] [stdout] 395 | |c| c.borrow().is_file_with_name(imp) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:627:18 [INFO] [stdout] | [INFO] [stdout] 627 | .map(|p| builder.get_builder_by_absolute_path(&p).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder.rs:739:27 [INFO] [stdout] | [INFO] [stdout] 739 | .and_then(|w| w.borrow().get_type()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> proto/proto_scope/builder/well_known/wrappers.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 54 | field_type: FieldTypeReference, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | ) -> MessageData { [INFO] [stdout] 56 | id_gen.create(( [INFO] [stdout] | ___________________^ [INFO] [stdout] 57 | | wrapper_name.into(), [INFO] [stdout] 58 | | vec![FieldDeclaration::new("value", field_type, 1).into()], [INFO] [stdout] 59 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 36 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 36 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protos-ts` (bin "protos-ts") due to 37 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `protos-ts` (bin "protos-ts" test) due to 37 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "96060603e9d91ec7ebead1e488634203b0d3029cc1cd52c7b09fff115bcdcfe7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96060603e9d91ec7ebead1e488634203b0d3029cc1cd52c7b09fff115bcdcfe7", kill_on_drop: false }` [INFO] [stdout] 96060603e9d91ec7ebead1e488634203b0d3029cc1cd52c7b09fff115bcdcfe7