[INFO] cloning repository https://github.com/wehjin/trove [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/wehjin/trove" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwehjin%2Ftrove", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwehjin%2Ftrove'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 028d80333b4b9ee60a79bce1f34fe63f9c901236 [INFO] checking wehjin/trove against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwehjin%2Ftrove" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/wehjin/trove on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/wehjin/trove [INFO] finished tweaking git repo https://github.com/wehjin/trove [INFO] tweaked toml for git repo https://github.com/wehjin/trove written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/wehjin/trove already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/wehjin/chad-core.git` [INFO] [stderr] Updating git repository `https://github.com/wehjin/gal-core.git` [INFO] [stderr] Updating git repository `https://github.com/wehjin/stringedit.git` [INFO] [stderr] Updating git repository `https://github.com/wehjin/yui.git` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ncurses v5.100.0 [INFO] [stderr] Downloaded simplelog v0.7.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de7cc5a4ac4961581e1df2a250100be6220e4a99e3de18ac6b0ff9fdfad03575 [INFO] running `Command { std: "docker" "start" "-a" "de7cc5a4ac4961581e1df2a250100be6220e4a99e3de18ac6b0ff9fdfad03575", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de7cc5a4ac4961581e1df2a250100be6220e4a99e3de18ac6b0ff9fdfad03575", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de7cc5a4ac4961581e1df2a250100be6220e4a99e3de18ac6b0ff9fdfad03575", kill_on_drop: false }` [INFO] [stdout] de7cc5a4ac4961581e1df2a250100be6220e4a99e3de18ac6b0ff9fdfad03575 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e4d615318839954abd10f47da9fafb4f2da2a92a82f7f01cf0f862992ae5903b [INFO] running `Command { std: "docker" "start" "-a" "e4d615318839954abd10f47da9fafb4f2da2a92a82f7f01cf0f862992ae5903b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling log v0.4.13 [INFO] [stderr] Checking stringedit v0.1.0 (https://github.com/wehjin/stringedit.git#7c5abff0) [INFO] [stderr] Compiling ncurses v5.100.0 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking simplelog v0.7.6 [INFO] [stderr] Checking echo-lib v0.1.0 (https://github.com/wehjin/gal-core.git#2e865b09) [INFO] [stderr] Checking yui v0.1.0 (https://github.com/wehjin/yui.git#0adef640) [INFO] [stderr] Checking chad-core v0.1.0 (https://github.com/wehjin/chad-core.git#ac63afd6) [INFO] [stderr] Checking trove v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.61s [INFO] running `Command { std: "docker" "inspect" "e4d615318839954abd10f47da9fafb4f2da2a92a82f7f01cf0f862992ae5903b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4d615318839954abd10f47da9fafb4f2da2a92a82f7f01cf0f862992ae5903b", kill_on_drop: false }` [INFO] [stdout] e4d615318839954abd10f47da9fafb4f2da2a92a82f7f01cf0f862992ae5903b [INFO] checking wehjin/trove against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwehjin%2Ftrove" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/wehjin/trove on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/wehjin/trove [INFO] finished tweaking git repo https://github.com/wehjin/trove [INFO] tweaked toml for git repo https://github.com/wehjin/trove written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/wehjin/trove already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] af3c8956042c7c566cbcf0e65a6f1499cf5b2c128e2946b342b9585f4f5419cc [INFO] running `Command { std: "docker" "start" "-a" "af3c8956042c7c566cbcf0e65a6f1499cf5b2c128e2946b342b9585f4f5419cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "af3c8956042c7c566cbcf0e65a6f1499cf5b2c128e2946b342b9585f4f5419cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af3c8956042c7c566cbcf0e65a6f1499cf5b2c128e2946b342b9585f4f5419cc", kill_on_drop: false }` [INFO] [stdout] af3c8956042c7c566cbcf0e65a6f1499cf5b2c128e2946b342b9585f4f5419cc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 95bfd7e2a53a9b9c7db3197e5d9271de2e15f1b35686e630b6b0ff0225898b9d [INFO] running `Command { std: "docker" "start" "-a" "95bfd7e2a53a9b9c7db3197e5d9271de2e15f1b35686e630b6b0ff0225898b9d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling log v0.4.13 [INFO] [stderr] Checking stringedit v0.1.0 (https://github.com/wehjin/stringedit.git#7c5abff0) [INFO] [stderr] Compiling ncurses v5.100.0 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking simplelog v0.7.6 [INFO] [stderr] Checking echo-lib v0.1.0 (https://github.com/wehjin/gal-core.git#2e865b09) [INFO] [stderr] Checking yui v0.1.0 (https://github.com/wehjin/yui.git#0adef640) [INFO] [stderr] Checking chad-core v0.1.0 (https://github.com/wehjin/chad-core.git#ac63afd6) [INFO] [stderr] Checking trove v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:51:2 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn member_view(member: &SquadMember, squad: &Squad, lot_link: SenderLink<(u64, String, Option)>) -> ArcYard { [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let lots = squad.lots.iter().filter(|it| it.symbol == member.symbol).collect::>(); [INFO] [stdout] 19 | let header = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let title = yard::title(&member.symbol, StrokeColor::BodyOnPrimary, Cling::Left); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let shares = lots.iter().map(|it| it.shares).sum::(); [INFO] [stdout] 22 | let shares_label = yard::label(format!("Shares: {}", sprint::amount_prefix(shares, "")), StrokeColor::BodyOnPrimary, Cling::Lef... [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let market_value = shares * squad.prices[&member.symbol]; [INFO] [stdout] 24 | let market_label = yard::label(format!("Market value: {}", sprint::amount(market_value)), StrokeColor::BodyOnPrimary, Cling::Left); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let front = title [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let content = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let lots_label = yard::label(format!("Lots ({})", lots.len()), StrokeColor::BodyOnBackground, Cling::Left); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let lot_list = if lots.is_empty() { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let lot_items = lots.into_iter() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let add_button = yard::button("Add Lot", ButtonState::default(lot_link.map({ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | content.pad(1).pack_top(7, header) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:37:31 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|it| lot_summary(it, lot_link.map({ [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 38 | | let path = (it.squad_id, it.symbol.to_string(), Some(it.id)); [INFO] [stdout] 39 | | move |_| path.clone() [INFO] [stdout] 40 | | }))) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:174:2 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn dialog(title: &str, close_link: SenderLink<()>, submit_button_state: ButtonState, delete_link: Option>, content: ArcYard) -... [INFO] [stdout] | -------------------------- -------------------------------- ----------------------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | const LEFT_COLS: i32 = 7; [INFO] [stdout] 162 | let close = yard::button("x", ButtonState::default(close_link.map(|_| ()))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let title = yard::title(title, StrokeColor::BodyOnBackground, Cling::LeftBottom).pack_top(1, yard::empty()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | let submit = yard::button("Submit", submit_button_state); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | let header = title.pad_cols(2).pack_left(LEFT_COLS, close); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let footer = match delete_link { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | None => submit.confine(14, 3, Cling::Top), [INFO] [stdout] 168 | Some(link) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let delete = yard::button("Delete", ButtonState::enabled(link.map(|_| ()))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let content = content.pad(1).pack_left(LEFT_COLS, yard::empty()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | content.pack_top(3, header) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:175:19 [INFO] [stdout] | [INFO] [stdout] 160 | ...n dialog(title: &str, close_link: SenderLink<()>, submit_button_state: ButtonState, delete_link: Option>, content: ArcYard) -... [INFO] [stdout] | -------------------------- -------------------------------- ----------------------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | ...onst LEFT_COLS: i32 = 7; [INFO] [stdout] 162 | ...et close = yard::button("x", ButtonState::default(close_link.map(|_| ()))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | ...et title = yard::title(title, StrokeColor::BodyOnBackground, Cling::LeftBottom).pack_top(1, yard::empty()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | ...et submit = yard::button("Submit", submit_button_state); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | ...et header = title.pad_cols(2).pack_left(LEFT_COLS, close); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | ...et footer = match delete_link { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | ... None => submit.confine(14, 3, Cling::Top), [INFO] [stdout] 168 | ... Some(link) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | ... let delete = yard::button("Delete", ButtonState::enabled(link.map(|_| ()))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | ...et content = content.pad(1).pack_left(LEFT_COLS, yard::empty()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | ...ontent.pack_top(3, header) [INFO] [stdout] 175 | ... .pack_bottom(4, footer.confine_height(3, Cling::Top).pad_cols(2).pack_left(LEFT_COLS, yard::empty())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:51:2 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn member_view(member: &SquadMember, squad: &Squad, lot_link: SenderLink<(u64, String, Option)>) -> ArcYard { [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let lots = squad.lots.iter().filter(|it| it.symbol == member.symbol).collect::>(); [INFO] [stdout] 19 | let header = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let title = yard::title(&member.symbol, StrokeColor::BodyOnPrimary, Cling::Left); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let shares = lots.iter().map(|it| it.shares).sum::(); [INFO] [stdout] 22 | let shares_label = yard::label(format!("Shares: {}", sprint::amount_prefix(shares, "")), StrokeColor::BodyOnPrimary, Cling::Lef... [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let market_value = shares * squad.prices[&member.symbol]; [INFO] [stdout] 24 | let market_label = yard::label(format!("Market value: {}", sprint::amount(market_value)), StrokeColor::BodyOnPrimary, Cling::Left); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let front = title [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let content = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let lots_label = yard::label(format!("Lots ({})", lots.len()), StrokeColor::BodyOnBackground, Cling::Left); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let lot_list = if lots.is_empty() { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let lot_items = lots.into_iter() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let add_button = yard::button("Add Lot", ButtonState::default(lot_link.map({ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | content.pad(1).pack_top(7, header) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:37:31 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|it| lot_summary(it, lot_link.map({ [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 38 | | let path = (it.squad_id, it.symbol.to_string(), Some(it.id)); [INFO] [stdout] 39 | | move |_| path.clone() [INFO] [stdout] 40 | | }))) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:174:2 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn dialog(title: &str, close_link: SenderLink<()>, submit_button_state: ButtonState, delete_link: Option>, content: ArcYard) -... [INFO] [stdout] | -------------------------- -------------------------------- ----------------------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | const LEFT_COLS: i32 = 7; [INFO] [stdout] 162 | let close = yard::button("x", ButtonState::default(close_link.map(|_| ()))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let title = yard::title(title, StrokeColor::BodyOnBackground, Cling::LeftBottom).pack_top(1, yard::empty()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | let submit = yard::button("Submit", submit_button_state); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | let header = title.pad_cols(2).pack_left(LEFT_COLS, close); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let footer = match delete_link { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | None => submit.confine(14, 3, Cling::Top), [INFO] [stdout] 168 | Some(link) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let delete = yard::button("Delete", ButtonState::enabled(link.map(|_| ()))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let content = content.pad(1).pack_left(LEFT_COLS, yard::empty()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | content.pack_top(3, header) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:175:19 [INFO] [stdout] | [INFO] [stdout] 160 | ...n dialog(title: &str, close_link: SenderLink<()>, submit_button_state: ButtonState, delete_link: Option>, content: ArcYard) -... [INFO] [stdout] | -------------------------- -------------------------------- ----------------------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | ...onst LEFT_COLS: i32 = 7; [INFO] [stdout] 162 | ...et close = yard::button("x", ButtonState::default(close_link.map(|_| ()))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | ...et title = yard::title(title, StrokeColor::BodyOnBackground, Cling::LeftBottom).pack_top(1, yard::empty()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | ...et submit = yard::button("Submit", submit_button_state); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | ...et header = title.pad_cols(2).pack_left(LEFT_COLS, close); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | ...et footer = match delete_link { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | ... None => submit.confine(14, 3, Cling::Top), [INFO] [stdout] 168 | ... Some(link) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | ... let delete = yard::button("Delete", ButtonState::enabled(link.map(|_| ()))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | ...et content = content.pad(1).pack_left(LEFT_COLS, yard::empty()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | ...ontent.pack_top(3, header) [INFO] [stdout] 175 | ... .pack_bottom(4, footer.confine_height(3, Cling::Top).pad_cols(2).pack_left(LEFT_COLS, yard::empty())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trove` (bin "trove") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `trove` (bin "trove" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "95bfd7e2a53a9b9c7db3197e5d9271de2e15f1b35686e630b6b0ff0225898b9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95bfd7e2a53a9b9c7db3197e5d9271de2e15f1b35686e630b6b0ff0225898b9d", kill_on_drop: false }` [INFO] [stdout] 95bfd7e2a53a9b9c7db3197e5d9271de2e15f1b35686e630b6b0ff0225898b9d