[INFO] cloning repository https://github.com/tomchaplin/phlite [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tomchaplin/phlite" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftomchaplin%2Fphlite", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftomchaplin%2Fphlite'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f82764a3cc4623570966154726116f0d172d90cc [INFO] checking tomchaplin/phlite against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftomchaplin%2Fphlite" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/tomchaplin/phlite on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/tomchaplin/phlite [INFO] finished tweaking git repo https://github.com/tomchaplin/phlite [INFO] tweaked toml for git repo https://github.com/tomchaplin/phlite written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/tomchaplin/phlite already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pyo3-log v0.10.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 30bc301fd072a2f38537f9623a670d26fe681e8bed6e8d1c4e1b9cafb2e6ad45 [INFO] running `Command { std: "docker" "start" "-a" "30bc301fd072a2f38537f9623a670d26fe681e8bed6e8d1c4e1b9cafb2e6ad45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "30bc301fd072a2f38537f9623a670d26fe681e8bed6e8d1c4e1b9cafb2e6ad45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30bc301fd072a2f38537f9623a670d26fe681e8bed6e8d1c4e1b9cafb2e6ad45", kill_on_drop: false }` [INFO] [stdout] 30bc301fd072a2f38537f9623a670d26fe681e8bed6e8d1c4e1b9cafb2e6ad45 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e60c7b2b977f154d67d98e8919e6a0a599b7f37a1b531a68bde827604ef4a5b9 [INFO] running `Command { std: "docker" "start" "-a" "e60c7b2b977f154d67d98e8919e6a0a599b7f37a1b531a68bde827604ef4a5b9", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking pyo3-ffi v0.21.2 [INFO] [stderr] Checking petgraph v0.6.4 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking ordered-float v4.2.0 [INFO] [stderr] Checking phlite v0.1.0 (/opt/rustwide/workdir/phlite) [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking phlite_rips v0.1.0 (/opt/rustwide/workdir/phlite_rips) [INFO] [stderr] Compiling pyo3-macros-backend v0.21.2 [INFO] [stderr] Compiling pyo3-macros v0.21.2 [INFO] [stderr] Checking pyo3 v0.21.2 [INFO] [stderr] Checking pyo3-log v0.10.0 [INFO] [stderr] Checking phlite_grpph v0.1.0 (/opt/rustwide/workdir/phlite_grpph) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.69s [INFO] running `Command { std: "docker" "inspect" "e60c7b2b977f154d67d98e8919e6a0a599b7f37a1b531a68bde827604ef4a5b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e60c7b2b977f154d67d98e8919e6a0a599b7f37a1b531a68bde827604ef4a5b9", kill_on_drop: false }` [INFO] [stdout] e60c7b2b977f154d67d98e8919e6a0a599b7f37a1b531a68bde827604ef4a5b9 [INFO] checking tomchaplin/phlite against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftomchaplin%2Fphlite" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/tomchaplin/phlite on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/tomchaplin/phlite [INFO] finished tweaking git repo https://github.com/tomchaplin/phlite [INFO] tweaked toml for git repo https://github.com/tomchaplin/phlite written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/tomchaplin/phlite already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7c21f7d2ed4673891efe39828349193d3c9e0502731de456dc2bba5ff26f99ab [INFO] running `Command { std: "docker" "start" "-a" "7c21f7d2ed4673891efe39828349193d3c9e0502731de456dc2bba5ff26f99ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7c21f7d2ed4673891efe39828349193d3c9e0502731de456dc2bba5ff26f99ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c21f7d2ed4673891efe39828349193d3c9e0502731de456dc2bba5ff26f99ab", kill_on_drop: false }` [INFO] [stdout] 7c21f7d2ed4673891efe39828349193d3c9e0502731de456dc2bba5ff26f99ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0155e58a5867c1763363859fd456972473fd617d21e8e5a61b92eb5a1e08a3b4 [INFO] running `Command { std: "docker" "start" "-a" "0155e58a5867c1763363859fd456972473fd617d21e8e5a61b92eb5a1e08a3b4", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking pyo3-ffi v0.21.2 [INFO] [stderr] Checking petgraph v0.6.4 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking ordered-float v4.2.0 [INFO] [stderr] Checking phlite v0.1.0 (/opt/rustwide/workdir/phlite) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/columns.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn add_entries(&mut self, entries: impl Iterator>) [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | self.add_tuples(entries.map(|e| e.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/matrices/mod.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 189 | let column = self.column(col)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | Ok(column.map(|(coeff, row_index)| { [INFO] [stdout] | ____________^ [INFO] [stdout] 191 | | let f_val = self [INFO] [stdout] 192 | | .filtration_value(row_index) [INFO] [stdout] 193 | | .expect("Rows should all have filtration values"); [INFO] [stdout] 194 | | let entry = (coeff, row_index, f_val).into(); [INFO] [stdout] 195 | | entry [INFO] [stdout] 196 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/matrices/adaptors.rs:445:12 [INFO] [stdout] | [INFO] [stdout] 444 | let reversed = self.oracle.column(Reverse(col))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 445 | Ok(reversed.map(|(coeff, rev_row)| (coeff, rev_row.0))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/matrices/adaptors.rs:468:12 [INFO] [stdout] | [INFO] [stdout] 467 | let rev_col = self.oracle.column_with_filtration(Reverse(col))?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | Ok(rev_col.map(|entry| ColumnEntry { [INFO] [stdout] | ____________^ [INFO] [stdout] 469 | | filtration_value: entry.filtration_value.0, [INFO] [stdout] 470 | | row_index: entry.row_index.0, [INFO] [stdout] 471 | | coeff: entry.coeff, [INFO] [stdout] 472 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/matrices/combinators.rs:24:40 [INFO] [stdout] | [INFO] [stdout] 24 | ( $matrix: expr, $col: expr ) => {{ [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 25 | | $col.flat_map(|(right_coeff, right_row_index)| { [INFO] [stdout] 26 | | let left_col = $matrix.column(right_row_index).unwrap(); [INFO] [stdout] 27 | | left_col [INFO] [stdout] 28 | | .map(move |(left_coeff, left_row_index)| (left_coeff * right_coeff, left_row_index)) [INFO] [stdout] 29 | | }) [INFO] [stdout] 30 | | }}; [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] ... [INFO] [stdout] 48 | let right_col = self.right.column(col)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(matrix_col_product!(self.left, right_col)) [INFO] [stdout] | ----------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `matrix_col_product` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/matrices/combinators.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 72 | let right_col = self.right.column(col)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(right_col.flat_map(|(right_coeff, right_row_index)| { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | let left_col = self.left.column_with_filtration(right_row_index).unwrap(); [INFO] [stdout] 75 | | left_col.map(move |left_entry| ColumnEntry { [INFO] [stdout] 76 | | coeff: left_entry.coeff * right_coeff, [INFO] [stdout] ... | [INFO] [stdout] 79 | | }) [INFO] [stdout] 80 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phlite` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/columns.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn add_entries(&mut self, entries: impl Iterator>) [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | self.add_tuples(entries.map(|e| e.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/matrices/mod.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 189 | let column = self.column(col)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | Ok(column.map(|(coeff, row_index)| { [INFO] [stdout] | ____________^ [INFO] [stdout] 191 | | let f_val = self [INFO] [stdout] 192 | | .filtration_value(row_index) [INFO] [stdout] 193 | | .expect("Rows should all have filtration values"); [INFO] [stdout] 194 | | let entry = (coeff, row_index, f_val).into(); [INFO] [stdout] 195 | | entry [INFO] [stdout] 196 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/matrices/adaptors.rs:445:12 [INFO] [stdout] | [INFO] [stdout] 444 | let reversed = self.oracle.column(Reverse(col))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 445 | Ok(reversed.map(|(coeff, rev_row)| (coeff, rev_row.0))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/matrices/adaptors.rs:468:12 [INFO] [stdout] | [INFO] [stdout] 467 | let rev_col = self.oracle.column_with_filtration(Reverse(col))?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | Ok(rev_col.map(|entry| ColumnEntry { [INFO] [stdout] | ____________^ [INFO] [stdout] 469 | | filtration_value: entry.filtration_value.0, [INFO] [stdout] 470 | | row_index: entry.row_index.0, [INFO] [stdout] 471 | | coeff: entry.coeff, [INFO] [stdout] 472 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/matrices/combinators.rs:24:40 [INFO] [stdout] | [INFO] [stdout] 24 | ( $matrix: expr, $col: expr ) => {{ [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 25 | | $col.flat_map(|(right_coeff, right_row_index)| { [INFO] [stdout] 26 | | let left_col = $matrix.column(right_row_index).unwrap(); [INFO] [stdout] 27 | | left_col [INFO] [stdout] 28 | | .map(move |(left_coeff, left_row_index)| (left_coeff * right_coeff, left_row_index)) [INFO] [stdout] 29 | | }) [INFO] [stdout] 30 | | }}; [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] ... [INFO] [stdout] 48 | let right_col = self.right.column(col)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(matrix_col_product!(self.left, right_col)) [INFO] [stdout] | ----------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `matrix_col_product` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> phlite/src/matrices/combinators.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 72 | let right_col = self.right.column(col)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(right_col.flat_map(|(right_coeff, right_row_index)| { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | let left_col = self.left.column_with_filtration(right_row_index).unwrap(); [INFO] [stdout] 75 | | left_col.map(move |left_entry| ColumnEntry { [INFO] [stdout] 76 | | coeff: left_entry.coeff * right_coeff, [INFO] [stdout] ... | [INFO] [stdout] 79 | | }) [INFO] [stdout] 80 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phlite` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "0155e58a5867c1763363859fd456972473fd617d21e8e5a61b92eb5a1e08a3b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0155e58a5867c1763363859fd456972473fd617d21e8e5a61b92eb5a1e08a3b4", kill_on_drop: false }` [INFO] [stdout] 0155e58a5867c1763363859fd456972473fd617d21e8e5a61b92eb5a1e08a3b4