[INFO] cloning repository https://github.com/taraka/nes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/taraka/nes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftaraka%2Fnes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftaraka%2Fnes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7e140c5567dfc2e08caf7476e1ca420c3930fd8e [INFO] checking taraka/nes against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftaraka%2Fnes" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/taraka/nes on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/taraka/nes [INFO] finished tweaking git repo https://github.com/taraka/nes [INFO] tweaked toml for git repo https://github.com/taraka/nes written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/taraka/nes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 910fd27ba8781425980103578b26b9874f7aa7847ce775236f7316d20ff1eec0 [INFO] running `Command { std: "docker" "start" "-a" "910fd27ba8781425980103578b26b9874f7aa7847ce775236f7316d20ff1eec0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "910fd27ba8781425980103578b26b9874f7aa7847ce775236f7316d20ff1eec0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "910fd27ba8781425980103578b26b9874f7aa7847ce775236f7316d20ff1eec0", kill_on_drop: false }` [INFO] [stdout] 910fd27ba8781425980103578b26b9874f7aa7847ce775236f7316d20ff1eec0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5f6bf4d0960668cea860eba0f36f5ed9c151a21c679dbf90f8c26ed2e1e3f1f5 [INFO] running `Command { std: "docker" "start" "-a" "5f6bf4d0960668cea860eba0f36f5ed9c151a21c679dbf90f8c26ed2e1e3f1f5", kill_on_drop: false }` [INFO] [stderr] Checking nes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `thread` and `time` [INFO] [stdout] --> src/main.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | use std::{thread, time}; [INFO] [stdout] | ^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::rc::Rc` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::rc::Rc; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `thread` and `time` [INFO] [stdout] --> src/main.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | use std::{thread, time}; [INFO] [stdout] | ^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::rc::Rc` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::rc::Rc; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/mos6502.rs:831:9 [INFO] [stdout] | [INFO] [stdout] 830 | panic!("Unknown opcode as: {:#04x}", self.pc); [INFO] [stdout] | --------------------------------------------- any code following this expression is unreachable [INFO] [stdout] 831 | self.additional_cycles(&amr, 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/mos6502.rs:831:9 [INFO] [stdout] | [INFO] [stdout] 830 | panic!("Unknown opcode as: {:#04x}", self.pc); [INFO] [stdout] | --------------------------------------------- any code following this expression is unreachable [INFO] [stdout] 831 | self.additional_cycles(&amr, 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mos6502.rs:311:13 [INFO] [stdout] | [INFO] [stdout] 311 | let mut addr = self.read(self.pc) ; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mos6502.rs:311:13 [INFO] [stdout] | [INFO] [stdout] 311 | let mut addr = self.read(self.pc) ; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `amr` [INFO] [stdout] --> src/mos6502.rs:829:23 [INFO] [stdout] | [INFO] [stdout] 829 | fn xxx(&mut self, amr: AddrModeResult) -> u8 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_amr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `amr` [INFO] [stdout] --> src/mos6502.rs:829:23 [INFO] [stdout] | [INFO] [stdout] 829 | fn xxx(&mut self, amr: AddrModeResult) -> u8 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_amr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes.rs:94:24 [INFO] [stdout] | [INFO] [stdout] 94 | fn ppu_read(&self, addr: u16) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes.rs:98:29 [INFO] [stdout] | [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/nes.rs:98:40 [INFO] [stdout] | [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes.rs:94:24 [INFO] [stdout] | [INFO] [stdout] 94 | fn ppu_read(&self, addr: u16) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes.rs:98:29 [INFO] [stdout] | [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/nes.rs:98:40 [INFO] [stdout] | [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/cartridge.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | if let Some(a) = self.mapper.write(addr, data) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/cartridge.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | if let Some(a) = self.mapper.write(addr, data) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | fn write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | fn write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/mappers/mapper0.rs:31:36 [INFO] [stdout] | [INFO] [stdout] 31 | fn write(&mut self, addr: u16, data: u8) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/mappers/mapper0.rs:31:36 [INFO] [stdout] | [INFO] [stdout] 31 | fn write(&mut self, addr: u16, data: u8) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/mappers/mapper0.rs:41:40 [INFO] [stdout] | [INFO] [stdout] 41 | fn ppu_write(&mut self, addr: u16, data: u8) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/mappers/mapper0.rs:41:40 [INFO] [stdout] | [INFO] [stdout] 41 | fn ppu_write(&mut self, addr: u16, data: u8) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `next_inst`, `irq`, and `nmi` are never used [INFO] [stdout] --> src/mos6502.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 58 | impl <'a> Cpu <'a> { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn next_inst(&mut self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 146 | fn irq(&mut self) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 162 | fn nmi(&mut self) { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ppu_read` and `ppu_write` are never used [INFO] [stdout] --> src/nes.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 73 | impl Bus { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 94 | fn ppu_read(&self, addr: u16) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `print_range` is never used [INFO] [stdout] --> src/ram.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Ram { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 15 | pub fn print_range(&mut self, r: std::ops::Range) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `header` and `chr_mem` are never read [INFO] [stdout] --> src/cartridge.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Cartridge { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 10 | header: Header, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | chr_mem: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Cartridge` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `next_inst`, `irq`, and `nmi` are never used [INFO] [stdout] --> src/mos6502.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 58 | impl <'a> Cpu <'a> { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn next_inst(&mut self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 146 | fn irq(&mut self) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 162 | fn nmi(&mut self) { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ppu_read` and `ppu_write` are never used [INFO] [stdout] --> src/nes.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 73 | impl Bus { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 94 | fn ppu_read(&self, addr: u16) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `mapper1`, `mapper2`, `prg_ram_size`, `tv_system1`, and `tv_system2` are never read [INFO] [stdout] --> src/cartridge.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | struct Header { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 19 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | mapper1: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 23 | mapper2: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 24 | prg_ram_size: u8, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 25 | tv_system1: u8, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 26 | tv_system2: u8, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ppu_read` and `ppu_write` are never used [INFO] [stdout] --> src/cartridge.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 48 | impl Cartridge { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 92 | fn ppu_read(&mut self, addr: u16) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 100 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/ppu.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Ppu { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | bus: Rc>, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `write`, `ppu_read`, and `ppu_write` are never used [INFO] [stdout] --> src/mappers.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Mapper: std::fmt::Debug { [INFO] [stdout] | ------ methods in this trait [INFO] [stdout] 5 | fn read(&mut self, addr: u16) -> Option; [INFO] [stdout] 6 | fn write(&mut self, addr: u16, data: u8) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | [INFO] [stdout] 8 | fn ppu_read(&mut self, addr: u16) -> Option; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 9 | fn ppu_write(&mut self, addr: u16, data: u8) -> Option; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `prg_rom_banks` is never read [INFO] [stdout] --> src/mappers/mapper0.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Mapper0 { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 5 | prg_rom_banks: u8, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mapper0` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `print_range` is never used [INFO] [stdout] --> src/ram.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Ram { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 15 | pub fn print_range(&mut self, r: std::ops::Range) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `header` and `chr_mem` are never read [INFO] [stdout] --> src/cartridge.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Cartridge { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 10 | header: Header, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | chr_mem: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Cartridge` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `mapper1`, `mapper2`, `prg_ram_size`, `tv_system1`, and `tv_system2` are never read [INFO] [stdout] --> src/cartridge.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | struct Header { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 19 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | mapper1: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 23 | mapper2: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 24 | prg_ram_size: u8, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 25 | tv_system1: u8, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 26 | tv_system2: u8, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mappers/mapper0.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 26 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mappers/mapper0.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 32 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ppu_read` and `ppu_write` are never used [INFO] [stdout] --> src/cartridge.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 48 | impl Cartridge { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 92 | fn ppu_read(&mut self, addr: u16) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 100 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/ppu.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Ppu { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | bus: Rc>, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `write`, `ppu_read`, and `ppu_write` are never used [INFO] [stdout] --> src/mappers.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Mapper: std::fmt::Debug { [INFO] [stdout] | ------ methods in this trait [INFO] [stdout] 5 | fn read(&mut self, addr: u16) -> Option; [INFO] [stdout] 6 | fn write(&mut self, addr: u16, data: u8) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | [INFO] [stdout] 8 | fn ppu_read(&mut self, addr: u16) -> Option; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 9 | fn ppu_write(&mut self, addr: u16, data: u8) -> Option; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `prg_rom_banks` is never read [INFO] [stdout] --> src/mappers/mapper0.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Mapper0 { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 5 | prg_rom_banks: u8, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mapper0` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mappers/mapper0.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 26 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mappers/mapper0.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 32 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.13s [INFO] running `Command { std: "docker" "inspect" "5f6bf4d0960668cea860eba0f36f5ed9c151a21c679dbf90f8c26ed2e1e3f1f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f6bf4d0960668cea860eba0f36f5ed9c151a21c679dbf90f8c26ed2e1e3f1f5", kill_on_drop: false }` [INFO] [stdout] 5f6bf4d0960668cea860eba0f36f5ed9c151a21c679dbf90f8c26ed2e1e3f1f5 [INFO] checking taraka/nes against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftaraka%2Fnes" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/taraka/nes on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/taraka/nes [INFO] finished tweaking git repo https://github.com/taraka/nes [INFO] tweaked toml for git repo https://github.com/taraka/nes written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/taraka/nes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2b111309c15baf579ff98aa3a2ca403954df7e21d3c6c82b90956c7213e730fe [INFO] running `Command { std: "docker" "start" "-a" "2b111309c15baf579ff98aa3a2ca403954df7e21d3c6c82b90956c7213e730fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2b111309c15baf579ff98aa3a2ca403954df7e21d3c6c82b90956c7213e730fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b111309c15baf579ff98aa3a2ca403954df7e21d3c6c82b90956c7213e730fe", kill_on_drop: false }` [INFO] [stdout] 2b111309c15baf579ff98aa3a2ca403954df7e21d3c6c82b90956c7213e730fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9ca039f1b81435d53c815d36e8dec8510c5e80eaa9baaaabe8be47627ced59d [INFO] running `Command { std: "docker" "start" "-a" "a9ca039f1b81435d53c815d36e8dec8510c5e80eaa9baaaabe8be47627ced59d", kill_on_drop: false }` [INFO] [stderr] Checking nes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `thread` and `time` [INFO] [stdout] --> src/main.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | use std::{thread, time}; [INFO] [stdout] | ^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::rc::Rc` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::rc::Rc; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `thread` and `time` [INFO] [stdout] --> src/main.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | use std::{thread, time}; [INFO] [stdout] | ^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::rc::Rc` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::rc::Rc; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/mos6502.rs:831:9 [INFO] [stdout] | [INFO] [stdout] 830 | panic!("Unknown opcode as: {:#04x}", self.pc); [INFO] [stdout] | --------------------------------------------- any code following this expression is unreachable [INFO] [stdout] 831 | self.additional_cycles(&amr, 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/mos6502.rs:831:9 [INFO] [stdout] | [INFO] [stdout] 830 | panic!("Unknown opcode as: {:#04x}", self.pc); [INFO] [stdout] | --------------------------------------------- any code following this expression is unreachable [INFO] [stdout] 831 | self.additional_cycles(&amr, 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mos6502.rs:311:13 [INFO] [stdout] | [INFO] [stdout] 311 | let mut addr = self.read(self.pc) ; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mos6502.rs:311:13 [INFO] [stdout] | [INFO] [stdout] 311 | let mut addr = self.read(self.pc) ; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `amr` [INFO] [stdout] --> src/mos6502.rs:829:23 [INFO] [stdout] | [INFO] [stdout] 829 | fn xxx(&mut self, amr: AddrModeResult) -> u8 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_amr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `amr` [INFO] [stdout] --> src/mos6502.rs:829:23 [INFO] [stdout] | [INFO] [stdout] 829 | fn xxx(&mut self, amr: AddrModeResult) -> u8 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_amr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes.rs:94:24 [INFO] [stdout] | [INFO] [stdout] 94 | fn ppu_read(&self, addr: u16) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes.rs:98:29 [INFO] [stdout] | [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/nes.rs:98:40 [INFO] [stdout] | [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes.rs:94:24 [INFO] [stdout] | [INFO] [stdout] 94 | fn ppu_read(&self, addr: u16) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/nes.rs:98:29 [INFO] [stdout] | [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/nes.rs:98:40 [INFO] [stdout] | [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/cartridge.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | if let Some(a) = self.mapper.write(addr, data) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | fn write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/mappers/mapper0.rs:31:36 [INFO] [stdout] | [INFO] [stdout] 31 | fn write(&mut self, addr: u16, data: u8) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/mappers/mapper0.rs:41:40 [INFO] [stdout] | [INFO] [stdout] 41 | fn ppu_write(&mut self, addr: u16, data: u8) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/cartridge.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | if let Some(a) = self.mapper.write(addr, data) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | fn write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `next_inst`, `irq`, and `nmi` are never used [INFO] [stdout] --> src/mos6502.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 58 | impl <'a> Cpu <'a> { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn next_inst(&mut self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 146 | fn irq(&mut self) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 162 | fn nmi(&mut self) { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ppu_read` and `ppu_write` are never used [INFO] [stdout] --> src/nes.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 73 | impl Bus { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 94 | fn ppu_read(&self, addr: u16) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `print_range` is never used [INFO] [stdout] --> src/ram.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Ram { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 15 | pub fn print_range(&mut self, r: std::ops::Range) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `header` and `chr_mem` are never read [INFO] [stdout] --> src/cartridge.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Cartridge { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 10 | header: Header, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | chr_mem: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Cartridge` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `mapper1`, `mapper2`, `prg_ram_size`, `tv_system1`, and `tv_system2` are never read [INFO] [stdout] --> src/cartridge.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | struct Header { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 19 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | mapper1: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 23 | mapper2: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 24 | prg_ram_size: u8, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 25 | tv_system1: u8, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 26 | tv_system2: u8, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ppu_read` and `ppu_write` are never used [INFO] [stdout] --> src/cartridge.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 48 | impl Cartridge { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 92 | fn ppu_read(&mut self, addr: u16) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 100 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/ppu.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Ppu { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | bus: Rc>, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `write`, `ppu_read`, and `ppu_write` are never used [INFO] [stdout] --> src/mappers.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Mapper: std::fmt::Debug { [INFO] [stdout] | ------ methods in this trait [INFO] [stdout] 5 | fn read(&mut self, addr: u16) -> Option; [INFO] [stdout] 6 | fn write(&mut self, addr: u16, data: u8) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | [INFO] [stdout] 8 | fn ppu_read(&mut self, addr: u16) -> Option; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 9 | fn ppu_write(&mut self, addr: u16, data: u8) -> Option; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `prg_rom_banks` is never read [INFO] [stdout] --> src/mappers/mapper0.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Mapper0 { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 5 | prg_rom_banks: u8, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mapper0` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nes.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 32 | let bus = Rc::new(RefCell::new(Bus::new())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let ppu = Rc::new(RefCell::new(Ppu::new(Rc::clone(&bus)))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let cpu = Rc::new(RefCell::new(Cpu::new(Rc::clone(&bus)))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | cartridge: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nes.rs:85:48 [INFO] [stdout] | [INFO] [stdout] 85 | self.devices.iter_mut().find_map(|dev| dev.borrow_mut().read(addr) ).unwrap_or(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mappers/mapper0.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 26 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mappers/mapper0.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 32 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/mappers/mapper0.rs:31:36 [INFO] [stdout] | [INFO] [stdout] 31 | fn write(&mut self, addr: u16, data: u8) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/mappers/mapper0.rs:41:40 [INFO] [stdout] | [INFO] [stdout] 41 | fn ppu_write(&mut self, addr: u16, data: u8) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `next_inst`, `irq`, and `nmi` are never used [INFO] [stdout] --> src/mos6502.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 58 | impl <'a> Cpu <'a> { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn next_inst(&mut self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 146 | fn irq(&mut self) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 162 | fn nmi(&mut self) { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ppu_read` and `ppu_write` are never used [INFO] [stdout] --> src/nes.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 73 | impl Bus { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 94 | fn ppu_read(&self, addr: u16) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `print_range` is never used [INFO] [stdout] --> src/ram.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Ram { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 15 | pub fn print_range(&mut self, r: std::ops::Range) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `header` and `chr_mem` are never read [INFO] [stdout] --> src/cartridge.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Cartridge { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 10 | header: Header, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | chr_mem: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Cartridge` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `mapper1`, `mapper2`, `prg_ram_size`, `tv_system1`, and `tv_system2` are never read [INFO] [stdout] --> src/cartridge.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | struct Header { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 19 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | mapper1: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 23 | mapper2: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 24 | prg_ram_size: u8, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 25 | tv_system1: u8, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 26 | tv_system2: u8, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ppu_read` and `ppu_write` are never used [INFO] [stdout] --> src/cartridge.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 48 | impl Cartridge { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 92 | fn ppu_read(&mut self, addr: u16) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 100 | fn ppu_write(&mut self, addr: u16, data: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/ppu.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Ppu { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | bus: Rc>, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `write`, `ppu_read`, and `ppu_write` are never used [INFO] [stdout] --> src/mappers.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Mapper: std::fmt::Debug { [INFO] [stdout] | ------ methods in this trait [INFO] [stdout] 5 | fn read(&mut self, addr: u16) -> Option; [INFO] [stdout] 6 | fn write(&mut self, addr: u16, data: u8) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | [INFO] [stdout] 8 | fn ppu_read(&mut self, addr: u16) -> Option; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 9 | fn ppu_write(&mut self, addr: u16, data: u8) -> Option; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `prg_rom_banks` is never read [INFO] [stdout] --> src/mappers/mapper0.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Mapper0 { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 5 | prg_rom_banks: u8, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mapper0` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nes.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 32 | let bus = Rc::new(RefCell::new(Bus::new())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let ppu = Rc::new(RefCell::new(Ppu::new(Rc::clone(&bus)))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let cpu = Rc::new(RefCell::new(Cpu::new(Rc::clone(&bus)))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | cartridge: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nes.rs:85:48 [INFO] [stdout] | [INFO] [stdout] 85 | self.devices.iter_mut().find_map(|dev| dev.borrow_mut().read(addr) ).unwrap_or(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mappers/mapper0.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 26 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mappers/mapper0.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 32 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nes` (bin "nes") due to 3 previous errors; 24 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `nes` (bin "nes" test) due to 3 previous errors; 24 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a9ca039f1b81435d53c815d36e8dec8510c5e80eaa9baaaabe8be47627ced59d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9ca039f1b81435d53c815d36e8dec8510c5e80eaa9baaaabe8be47627ced59d", kill_on_drop: false }` [INFO] [stdout] a9ca039f1b81435d53c815d36e8dec8510c5e80eaa9baaaabe8be47627ced59d