[INFO] cloning repository https://github.com/sriram98v/near-linear-cophenetic-distance [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sriram98v/near-linear-cophenetic-distance" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsriram98v%2Fnear-linear-cophenetic-distance", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsriram98v%2Fnear-linear-cophenetic-distance'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] aa4764d6aef339490f73f41812189a41ba0605a6 [INFO] checking sriram98v/near-linear-cophenetic-distance against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsriram98v%2Fnear-linear-cophenetic-distance" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/sriram98v/near-linear-cophenetic-distance on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/sriram98v/near-linear-cophenetic-distance [INFO] finished tweaking git repo https://github.com/sriram98v/near-linear-cophenetic-distance [INFO] tweaked toml for git repo https://github.com/sriram98v/near-linear-cophenetic-distance written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/sriram98v/near-linear-cophenetic-distance already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded divan-macros v0.1.14 [INFO] [stderr] Downloaded condtype v1.3.0 [INFO] [stderr] Downloaded vers-vecs v1.4.0 [INFO] [stderr] Downloaded phylo v0.1.1 [INFO] [stderr] Downloaded divan v0.1.14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e0b268a7cd59c4e2973f254b4dc6204d5165ca982dba513fd9a9c446d1b54407 [INFO] running `Command { std: "docker" "start" "-a" "e0b268a7cd59c4e2973f254b4dc6204d5165ca982dba513fd9a9c446d1b54407", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e0b268a7cd59c4e2973f254b4dc6204d5165ca982dba513fd9a9c446d1b54407", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0b268a7cd59c4e2973f254b4dc6204d5165ca982dba513fd9a9c446d1b54407", kill_on_drop: false }` [INFO] [stdout] e0b268a7cd59c4e2973f254b4dc6204d5165ca982dba513fd9a9c446d1b54407 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd8d17bf2b0596a7360ca1936b1f4c2a98b5a9f3b7a0fd265fef9ed4f08f3fe2 [INFO] running `Command { std: "docker" "start" "-a" "bd8d17bf2b0596a7360ca1936b1f4c2a98b5a9f3b7a0fd265fef9ed4f08f3fe2", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking vers-vecs v1.4.0 [INFO] [stderr] Checking condtype v1.3.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Compiling divan-macros v0.1.14 [INFO] [stderr] Checking phylo v0.1.1 [INFO] [stderr] Checking divan v0.1.14 [INFO] [stderr] Checking nlcd v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:369:78 [INFO] [stdout] | [INFO] [stdout] 369 | let taxa_set: HashSet<_> = binding1.intersection(&binding2).map(|x| x.clone().clone()).collect(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:436:48 [INFO] [stdout] | [INFO] [stdout] 436 | .filter(|x| taxa_set.contains(x.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:442:48 [INFO] [stdout] | [INFO] [stdout] 442 | .filter(|x| taxa_set.contains(x.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:369:78 [INFO] [stdout] | [INFO] [stdout] 369 | let taxa_set: HashSet<_> = binding1.intersection(&binding2).map(|x| x.clone().clone()).collect(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:436:48 [INFO] [stdout] | [INFO] [stdout] 436 | .filter(|x| taxa_set.contains(x.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:442:48 [INFO] [stdout] | [INFO] [stdout] 442 | .filter(|x| taxa_set.contains(x.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.30s [INFO] running `Command { std: "docker" "inspect" "bd8d17bf2b0596a7360ca1936b1f4c2a98b5a9f3b7a0fd265fef9ed4f08f3fe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd8d17bf2b0596a7360ca1936b1f4c2a98b5a9f3b7a0fd265fef9ed4f08f3fe2", kill_on_drop: false }` [INFO] [stdout] bd8d17bf2b0596a7360ca1936b1f4c2a98b5a9f3b7a0fd265fef9ed4f08f3fe2 [INFO] checking sriram98v/near-linear-cophenetic-distance against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsriram98v%2Fnear-linear-cophenetic-distance" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/sriram98v/near-linear-cophenetic-distance on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/sriram98v/near-linear-cophenetic-distance [INFO] finished tweaking git repo https://github.com/sriram98v/near-linear-cophenetic-distance [INFO] tweaked toml for git repo https://github.com/sriram98v/near-linear-cophenetic-distance written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/sriram98v/near-linear-cophenetic-distance already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f85855e2b411f604c9e3509db380b6573d78096503ca3024e269fe67bfafc135 [INFO] running `Command { std: "docker" "start" "-a" "f85855e2b411f604c9e3509db380b6573d78096503ca3024e269fe67bfafc135", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f85855e2b411f604c9e3509db380b6573d78096503ca3024e269fe67bfafc135", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f85855e2b411f604c9e3509db380b6573d78096503ca3024e269fe67bfafc135", kill_on_drop: false }` [INFO] [stdout] f85855e2b411f604c9e3509db380b6573d78096503ca3024e269fe67bfafc135 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2d54e55830eaf2549df127eb9a9d613c8fd80bc95e0b65156feeafc3cc532dca [INFO] running `Command { std: "docker" "start" "-a" "2d54e55830eaf2549df127eb9a9d613c8fd80bc95e0b65156feeafc3cc532dca", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking vers-vecs v1.4.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking condtype v1.3.0 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Compiling divan-macros v0.1.14 [INFO] [stderr] Checking phylo v0.1.1 [INFO] [stderr] Checking divan v0.1.14 [INFO] [stderr] Checking nlcd v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 274 | let lower_tree_taxa = self.lower_tree_taxa(median_node_id).collect::>(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | / self.get_leaf_ids() [INFO] [stdout] 276 | | .map(|x| self.get_node_taxa_cloned(x).unwrap()) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:277:21 [INFO] [stdout] | [INFO] [stdout] 274 | let lower_tree_taxa = self.lower_tree_taxa(median_node_id).collect::>(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | .filter(move |x| !lower_tree_taxa.contains(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:276:22 [INFO] [stdout] | [INFO] [stdout] 276 | .map(|x| self.get_node_taxa_cloned(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 288 | let lower_tree_leaf_ids = self [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | / self.get_leaves() [INFO] [stdout] 293 | | .filter(move |x| !lower_tree_leaf_ids.contains(&x.get_id())) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:369:78 [INFO] [stdout] | [INFO] [stdout] 369 | let taxa_set: HashSet<_> = binding1.intersection(&binding2).map(|x| x.clone().clone()).collect(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:434:60 [INFO] [stdout] | [INFO] [stdout] 434 | HashSet::from_iter(self.get_leaf_ids().map(|x| self.get_node_taxa_cloned(x).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:436:48 [INFO] [stdout] | [INFO] [stdout] 436 | .filter(|x| taxa_set.contains(x.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:440:60 [INFO] [stdout] | [INFO] [stdout] 440 | HashSet::from_iter(tree.get_leaf_ids().map(|x| tree.get_node_taxa_cloned(x).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:442:48 [INFO] [stdout] | [INFO] [stdout] 442 | .filter(|x| taxa_set.contains(x.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nlcd` (lib) due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 274 | let lower_tree_taxa = self.lower_tree_taxa(median_node_id).collect::>(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | / self.get_leaf_ids() [INFO] [stdout] 276 | | .map(|x| self.get_node_taxa_cloned(x).unwrap()) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:277:21 [INFO] [stdout] | [INFO] [stdout] 274 | let lower_tree_taxa = self.lower_tree_taxa(median_node_id).collect::>(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | .filter(move |x| !lower_tree_taxa.contains(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:276:22 [INFO] [stdout] | [INFO] [stdout] 276 | .map(|x| self.get_node_taxa_cloned(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 288 | let lower_tree_leaf_ids = self [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | / self.get_leaves() [INFO] [stdout] 293 | | .filter(move |x| !lower_tree_leaf_ids.contains(&x.get_id())) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:369:78 [INFO] [stdout] | [INFO] [stdout] 369 | let taxa_set: HashSet<_> = binding1.intersection(&binding2).map(|x| x.clone().clone()).collect(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:434:60 [INFO] [stdout] | [INFO] [stdout] 434 | HashSet::from_iter(self.get_leaf_ids().map(|x| self.get_node_taxa_cloned(x).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:436:48 [INFO] [stdout] | [INFO] [stdout] 436 | .filter(|x| taxa_set.contains(x.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:440:60 [INFO] [stdout] | [INFO] [stdout] 440 | HashSet::from_iter(tree.get_leaf_ids().map(|x| tree.get_node_taxa_cloned(x).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&<>::Node as phylo::prelude::RootedMetaNode<'_>>::Meta` instead of cloning the inner type [INFO] [stdout] --> src/nlcd/near_linear_cophenetic_distance.rs:442:48 [INFO] [stdout] | [INFO] [stdout] 442 | .filter(|x| taxa_set.contains(x.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nlcd` (lib test) due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2d54e55830eaf2549df127eb9a9d613c8fd80bc95e0b65156feeafc3cc532dca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d54e55830eaf2549df127eb9a9d613c8fd80bc95e0b65156feeafc3cc532dca", kill_on_drop: false }` [INFO] [stdout] 2d54e55830eaf2549df127eb9a9d613c8fd80bc95e0b65156feeafc3cc532dca