[INFO] cloning repository https://github.com/snipsco/dinghy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/snipsco/dinghy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsnipsco%2Fdinghy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsnipsco%2Fdinghy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a7e23772c6c7e098f87813944863a48b2f3ca77d [INFO] checking snipsco/dinghy against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsnipsco%2Fdinghy" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/snipsco/dinghy on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/snipsco/dinghy [INFO] finished tweaking git repo https://github.com/snipsco/dinghy [INFO] tweaked toml for git repo https://github.com/snipsco/dinghy written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/snipsco/dinghy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8f87147f5f50ec6443239f6ccefb7c32b46bbce3f35376a7470937825656cb2c [INFO] running `Command { std: "docker" "start" "-a" "8f87147f5f50ec6443239f6ccefb7c32b46bbce3f35376a7470937825656cb2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8f87147f5f50ec6443239f6ccefb7c32b46bbce3f35376a7470937825656cb2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f87147f5f50ec6443239f6ccefb7c32b46bbce3f35376a7470937825656cb2c", kill_on_drop: false }` [INFO] [stdout] 8f87147f5f50ec6443239f6ccefb7c32b46bbce3f35376a7470937825656cb2c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b619cf3814d2380bfae09431106636b7d0b87c15ec772b12c5fd92ee14210432 [INFO] running `Command { std: "docker" "start" "-a" "b619cf3814d2380bfae09431106636b7d0b87c15ec772b12c5fd92ee14210432", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Compiling fs-err v2.11.0 [INFO] [stderr] Checking anyhow v1.0.86 [INFO] [stderr] Checking cc v1.0.99 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking line-wrap v0.2.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Compiling dinghy-lib v0.7.3-pre (/opt/rustwide/workdir/dinghy-lib) [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking dinghy-build v0.7.3-pre (/opt/rustwide/workdir/dinghy-build) [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking dinghy-test v0.7.3-pre (/opt/rustwide/workdir/dinghy-test) [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking serde v1.0.203 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking plist v1.6.1 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking cargo_metadata v0.15.4 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking cargo-dinghy v0.7.3-pre (/opt/rustwide/workdir/cargo-dinghy) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.39s [INFO] running `Command { std: "docker" "inspect" "b619cf3814d2380bfae09431106636b7d0b87c15ec772b12c5fd92ee14210432", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b619cf3814d2380bfae09431106636b7d0b87c15ec772b12c5fd92ee14210432", kill_on_drop: false }` [INFO] [stdout] b619cf3814d2380bfae09431106636b7d0b87c15ec772b12c5fd92ee14210432 [INFO] checking snipsco/dinghy against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsnipsco%2Fdinghy" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/snipsco/dinghy on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/snipsco/dinghy [INFO] finished tweaking git repo https://github.com/snipsco/dinghy [INFO] tweaked toml for git repo https://github.com/snipsco/dinghy written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/snipsco/dinghy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 94977f0fdacb5694fcf148250fc5dd6eb9cb188694b3d40b728b9f930119fad8 [INFO] running `Command { std: "docker" "start" "-a" "94977f0fdacb5694fcf148250fc5dd6eb9cb188694b3d40b728b9f930119fad8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "94977f0fdacb5694fcf148250fc5dd6eb9cb188694b3d40b728b9f930119fad8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94977f0fdacb5694fcf148250fc5dd6eb9cb188694b3d40b728b9f930119fad8", kill_on_drop: false }` [INFO] [stdout] 94977f0fdacb5694fcf148250fc5dd6eb9cb188694b3d40b728b9f930119fad8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e30650f78e215540248df9f719e32cbcc46a53695e8db41974d383224085e1e3 [INFO] running `Command { std: "docker" "start" "-a" "e30650f78e215540248df9f719e32cbcc46a53695e8db41974d383224085e1e3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling fs-err v2.11.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking anyhow v1.0.86 [INFO] [stderr] Checking cc v1.0.99 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling dinghy-lib v0.7.3-pre (/opt/rustwide/workdir/dinghy-lib) [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking line-wrap v0.2.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking dinghy-build v0.7.3-pre (/opt/rustwide/workdir/dinghy-build) [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking dinghy-test v0.7.3-pre (/opt/rustwide/workdir/dinghy-test) [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking serde v1.0.203 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking plist v1.6.1 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking cargo_metadata v0.15.4 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/lib.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 42 | let mut managers: Vec> = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let mut devices = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut platforms = vec![]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(Dinghy { devices, platforms }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/lib.rs:82:41 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|it| (it.id(), sync::Arc::new(it))), [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/android/mod.rs:67:44 [INFO] [stdout] | [INFO] [stdout] 67 | ... .and_then(|it| it.file_type().ok().as_ref().map(FileType::is_dir)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/android/mod.rs:262:13 [INFO] [stdout] | [INFO] [stdout] 261 | .filter_map(|directory| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | / directory [INFO] [stdout] 263 | | .path() [INFO] [stdout] 264 | | .file_name() [INFO] [stdout] 265 | | .and_then(|name| { [INFO] [stdout] ... | [INFO] [stdout] 268 | | semver::Version::parse(&name).ok() [INFO] [stdout] 269 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/android/mod.rs:270:22 [INFO] [stdout] | [INFO] [stdout] 261 | .filter_map(|directory| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | .map(|version| (directory, version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/overlay.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 109 | fn from_directory>(overlay_root_dir: P) -> Result> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | Ok(read_dir(overlay_root_dir.as_ref())? [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | .filter_map(|it| it.ok()) // Ignore invalid directories [INFO] [stdout] 112 | | .map(|it| it.path()) [INFO] [stdout] 113 | | .filter(|it| it.is_dir()) [INFO] [stdout] ... | [INFO] [stdout] 118 | | scope: OverlayScope::Application, [INFO] [stdout] 119 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/overlay.rs:227:29 [INFO] [stdout] | [INFO] [stdout] 227 | .filter_map(|e| lib_name_from(e.path()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/project.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(conf: &Arc, metadata: Metadata) -> Project { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Project { [INFO] [stdout] 27 | conf: Arc::clone(conf), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/script/mod.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn probe(conf: sync::Arc) -> Option { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Some(ScriptDeviceManager { conf }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/ssh/mod.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn probe(conf: sync::Arc) -> Option { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Some(SshDeviceManager { conf }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/lib.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 42 | let mut managers: Vec> = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let mut devices = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut platforms = vec![]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(Dinghy { devices, platforms }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/lib.rs:82:41 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|it| (it.id(), sync::Arc::new(it))), [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/android/mod.rs:67:44 [INFO] [stdout] | [INFO] [stdout] 67 | ... .and_then(|it| it.file_type().ok().as_ref().map(FileType::is_dir)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/android/mod.rs:262:13 [INFO] [stdout] | [INFO] [stdout] 261 | .filter_map(|directory| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | / directory [INFO] [stdout] 263 | | .path() [INFO] [stdout] 264 | | .file_name() [INFO] [stdout] 265 | | .and_then(|name| { [INFO] [stdout] ... | [INFO] [stdout] 268 | | semver::Version::parse(&name).ok() [INFO] [stdout] 269 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/android/mod.rs:270:22 [INFO] [stdout] | [INFO] [stdout] 261 | .filter_map(|directory| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | .map(|version| (directory, version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/overlay.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 109 | fn from_directory>(overlay_root_dir: P) -> Result> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | Ok(read_dir(overlay_root_dir.as_ref())? [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | .filter_map(|it| it.ok()) // Ignore invalid directories [INFO] [stdout] 112 | | .map(|it| it.path()) [INFO] [stdout] 113 | | .filter(|it| it.is_dir()) [INFO] [stdout] ... | [INFO] [stdout] 118 | | scope: OverlayScope::Application, [INFO] [stdout] 119 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/overlay.rs:227:29 [INFO] [stdout] | [INFO] [stdout] 227 | .filter_map(|e| lib_name_from(e.path()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/project.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(conf: &Arc, metadata: Metadata) -> Project { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Project { [INFO] [stdout] 27 | conf: Arc::clone(conf), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/script/mod.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn probe(conf: sync::Arc) -> Option { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Some(ScriptDeviceManager { conf }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dinghy-lib/src/ssh/mod.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn probe(conf: sync::Arc) -> Option { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Some(SshDeviceManager { conf }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dinghy-lib` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `dinghy-lib` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "e30650f78e215540248df9f719e32cbcc46a53695e8db41974d383224085e1e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e30650f78e215540248df9f719e32cbcc46a53695e8db41974d383224085e1e3", kill_on_drop: false }` [INFO] [stdout] e30650f78e215540248df9f719e32cbcc46a53695e8db41974d383224085e1e3