[INFO] cloning repository https://github.com/smessmer/lockable [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/smessmer/lockable" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmessmer%2Flockable", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmessmer%2Flockable'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9aac36fea7d9070da51a122194fd1fdae7075b3f [INFO] checking smessmer/lockable against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmessmer%2Flockable" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/smessmer/lockable on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/smessmer/lockable [INFO] finished tweaking git repo https://github.com/smessmer/lockable [INFO] tweaked toml for git repo https://github.com/smessmer/lockable written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/smessmer/lockable already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ciborium-io v0.2.2 [INFO] [stderr] Downloaded plotters-svg v0.3.5 [INFO] [stderr] Downloaded plotters v0.3.5 [INFO] [stderr] Downloaded oorandom v11.1.3 [INFO] [stderr] Downloaded anes v0.1.6 [INFO] [stderr] Downloaded ciborium v0.2.2 [INFO] [stderr] Downloaded ciborium-ll v0.2.2 [INFO] [stderr] Downloaded half v2.3.1 [INFO] [stderr] Downloaded criterion-plot v0.5.0 [INFO] [stderr] Downloaded criterion v0.5.1 [INFO] [stderr] Downloaded is-terminal v0.4.10 [INFO] [stderr] Downloaded rayon v1.8.1 [INFO] [stderr] Downloaded ahash v0.8.7 [INFO] [stderr] Downloaded lru v0.12.1 [INFO] [stderr] Downloaded plotters-backend v0.3.5 [INFO] [stderr] Downloaded regex-automata v0.4.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 689337a97f38bd17c79e46cc6e1b412faace6ea08e859e37c3bcc08a6ef961c8 [INFO] running `Command { std: "docker" "start" "-a" "689337a97f38bd17c79e46cc6e1b412faace6ea08e859e37c3bcc08a6ef961c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "689337a97f38bd17c79e46cc6e1b412faace6ea08e859e37c3bcc08a6ef961c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "689337a97f38bd17c79e46cc6e1b412faace6ea08e859e37c3bcc08a6ef961c8", kill_on_drop: false }` [INFO] [stdout] 689337a97f38bd17c79e46cc6e1b412faace6ea08e859e37c3bcc08a6ef961c8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c11d54d38c6c3c8e4fbcce673024bc7640f07265c539f505006a976d75525187 [INFO] running `Command { std: "docker" "start" "-a" "c11d54d38c6c3c8e4fbcce673024bc7640f07265c539f505006a976d75525187", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking lru v0.12.1 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking regex-automata v0.4.4 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking lockable v0.0.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `next_if_ready` is never used [INFO] [stdout] --> src/utils/stream.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait MyStreamExt: Stream { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 28 | fn next_if_ready(&mut self) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.00s [INFO] running `Command { std: "docker" "inspect" "c11d54d38c6c3c8e4fbcce673024bc7640f07265c539f505006a976d75525187", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c11d54d38c6c3c8e4fbcce673024bc7640f07265c539f505006a976d75525187", kill_on_drop: false }` [INFO] [stdout] c11d54d38c6c3c8e4fbcce673024bc7640f07265c539f505006a976d75525187 [INFO] checking smessmer/lockable against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmessmer%2Flockable" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/smessmer/lockable on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/smessmer/lockable [INFO] finished tweaking git repo https://github.com/smessmer/lockable [INFO] tweaked toml for git repo https://github.com/smessmer/lockable written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/smessmer/lockable already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba8ce5d42e114bdaab19a24a525c27be9bd81275245d4d2516c2eb19a5e8e819 [INFO] running `Command { std: "docker" "start" "-a" "ba8ce5d42e114bdaab19a24a525c27be9bd81275245d4d2516c2eb19a5e8e819", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba8ce5d42e114bdaab19a24a525c27be9bd81275245d4d2516c2eb19a5e8e819", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba8ce5d42e114bdaab19a24a525c27be9bd81275245d4d2516c2eb19a5e8e819", kill_on_drop: false }` [INFO] [stdout] ba8ce5d42e114bdaab19a24a525c27be9bd81275245d4d2516c2eb19a5e8e819 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 69d74272763569f2f47bd4f740b243ad64bdd77018cc222f817a84573e9cc4a2 [INFO] running `Command { std: "docker" "start" "-a" "69d74272763569f2f47bd4f740b243ad64bdd77018cc222f817a84573e9cc4a2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking lru v0.12.1 [INFO] [stderr] Checking regex-automata v0.4.4 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking lockable v0.0.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `next_if_ready` is never used [INFO] [stdout] --> src/utils/stream.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait MyStreamExt: Stream { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 28 | fn next_if_ready(&mut self) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub(super) fn new(map: P, key: M::K, guard: OwnedMutexGuard>) -> Self { [INFO] [stdout] | ------ --------- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | guard: Some(guard), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:322:14 [INFO] [stdout] | [INFO] [stdout] 315 | pub fn value_or_insert_with(&mut self, value_fn: impl FnOnce() -> V) -> &mut V { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let hooks = self.map.borrow().hooks().clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | &mut *guard [INFO] [stdout] | ______________^ [INFO] [stdout] 323 | | .value [INFO] [stdout] 324 | | .as_mut() [INFO] [stdout] 325 | | .expect("We just created this item if it didn't already exist") [INFO] [stdout] 326 | | .borrow_mut() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:360:35 [INFO] [stdout] | [INFO] [stdout] 359 | pub fn value_or_insert(&mut self, value: V) -> &mut V { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | self.value_or_insert_with(move || value) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_map_impl.rs:92:28 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn new_with_hooks(hooks: H) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Self { [INFO] [stdout] 92 | cache_entries: Some(std::sync::Mutex::new(M::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_map_impl.rs:301:12 [INFO] [stdout] | [INFO] [stdout] 284 | this: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | key: M::K, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | limit: SyncLimit, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | let mutex = Self::_load_or_insert_mutex_for_key_sync(&this, &key, limit)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | let guard = match mutex { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | LoadOrInsertMutexResult::Existing { mutex } => mutex.blocking_lock_owned(), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | LoadOrInsertMutexResult::Inserted { guard } => guard, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | Ok(Self::_make_guard(this, key, guard)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_map_impl.rs:385:46 [INFO] [stdout] | [INFO] [stdout] 385 | .filter_map(|(key, mutex)| match Arc::clone(mutex).try_lock_owned() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_map_impl.rs:507:9 [INFO] [stdout] | [INFO] [stdout] 494 | pub fn into_entries_unordered(mut self) -> impl Iterator { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | let entries: M = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 507 | / entries [INFO] [stdout] 508 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_map_impl.rs:515:33 [INFO] [stdout] | [INFO] [stdout] 509 | .filter_map(|(key, value)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 510 | let value = Arc::try_unwrap(value) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 511 | .unwrap_or_else(|_| panic!("We... [INFO] [stdout] 512 | let value = value.into_inner(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | value.value.map(|value| (key, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_map_impl.rs:523:9 [INFO] [stdout] | [INFO] [stdout] 522 | let cache_entries = self._cache_entries(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 523 | / cache_entries [INFO] [stdout] 524 | | .iter() [INFO] [stdout] 525 | | .map(|(key, _value)| key) [INFO] [stdout] 526 | | .cloned() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/stream.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 36 | let noop_waker = task::noop_waker(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut cx = Context::from_waker(&noop_waker); [INFO] [stdout] 38 | match self.poll_next_unpin(&mut cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_hash_map.rs:375:40 [INFO] [stdout] | [INFO] [stdout] 369 | key: K, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 370 | limit: >::SyncLimitOwned, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | LockableMapImpl::blocking_lock(Arc::clone(self), key, limit) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_hash_map.rs:460:35 [INFO] [stdout] | [INFO] [stdout] 454 | key: K, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 455 | limit: >::SyncLimitOwned, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 460 | LockableMapImpl::try_lock(Arc::clone(self), key, limit) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_lru_cache.rs:321:23 [INFO] [stdout] | [INFO] [stdout] 319 | let time_provider = Time::default(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | Self { [INFO] [stdout] 321 | map_impl: LockableMapImpl::new_with_hooks(LruCacheHooks { time_provider }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_lru_cache.rs:446:40 [INFO] [stdout] | [INFO] [stdout] 440 | key: K, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 441 | limit: >::SyncLimitOwned, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | LockableMapImpl::blocking_lock(Arc::clone(self), key, limit) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_lru_cache.rs:531:35 [INFO] [stdout] | [INFO] [stdout] 525 | key: K, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 526 | limit: >::SyncLimitOwned, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 531 | LockableMapImpl::try_lock(Arc::clone(self), key, limit) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_lru_cache.rs:750:9 [INFO] [stdout] | [INFO] [stdout] 749 | pub fn into_entries_unordered(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 750 | / self.map_impl [INFO] [stdout] 751 | | .into_entries_unordered() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockable_lru_cache.rs:1005:9 [INFO] [stdout] | [INFO] [stdout] 1000 | this: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1005 | / LockableMapImpl::lock_all_unlocked(this, &move |entry| { [INFO] [stdout] 1006 | | let entry = entry.value_raw().expect("There must be a value, otherwise it cannot exist in the map as an 'unlocked' entry"); [INFO] [stdout] 1007 | | entry.last_unlocked <= cutoff [INFO] [stdout] 1008 | | }).into_iter() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockpool.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 172 | pub fn blocking_lock(&self, key: K) -> >::Guard<'_> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | / self.map [INFO] [stdout] 174 | | .blocking_lock(key, SyncLimit::no_limit()) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockpool.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 244 | pub fn try_lock(&self, key: K) -> Option<>::Guard<'_>> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | / self.map [INFO] [stdout] 246 | | .try_lock(key, SyncLimit::no_limit()) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lockable` (lib) due to 20 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "69d74272763569f2f47bd4f740b243ad64bdd77018cc222f817a84573e9cc4a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69d74272763569f2f47bd4f740b243ad64bdd77018cc222f817a84573e9cc4a2", kill_on_drop: false }` [INFO] [stdout] 69d74272763569f2f47bd4f740b243ad64bdd77018cc222f817a84573e9cc4a2