[INFO] cloning repository https://github.com/smb123w64gb/vtfTrans-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/smb123w64gb/vtfTrans-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmb123w64gb%2FvtfTrans-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmb123w64gb%2FvtfTrans-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d893e6ddf150fff750bcfa6dec7a935636bb63c5 [INFO] checking smb123w64gb/vtfTrans-rs against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmb123w64gb%2FvtfTrans-rs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/smb123w64gb/vtfTrans-rs on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/smb123w64gb/vtfTrans-rs [INFO] finished tweaking git repo https://github.com/smb123w64gb/vtfTrans-rs [INFO] tweaked toml for git repo https://github.com/smb123w64gb/vtfTrans-rs written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/smb123w64gb/vtfTrans-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded binrw_derive v0.11.2 [INFO] [stderr] Downloaded binrw v0.11.2 [INFO] [stderr] Downloaded bitmask-enum v2.2.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9b13881011e610f8210eed52cab51abbb88dadb918668850aba568de9d33cdc [INFO] running `Command { std: "docker" "start" "-a" "b9b13881011e610f8210eed52cab51abbb88dadb918668850aba568de9d33cdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9b13881011e610f8210eed52cab51abbb88dadb918668850aba568de9d33cdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9b13881011e610f8210eed52cab51abbb88dadb918668850aba568de9d33cdc", kill_on_drop: false }` [INFO] [stdout] b9b13881011e610f8210eed52cab51abbb88dadb918668850aba568de9d33cdc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 086842f14b748da6307b550f16f1d0bc6f25dcaf14311aad202b9a89f8f224f6 [INFO] running `Command { std: "docker" "start" "-a" "086842f14b748da6307b550f16f1d0bc6f25dcaf14311aad202b9a89f8f224f6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustix v0.38.3 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Compiling binrw_derive v0.11.2 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling either v1.8.1 [INFO] [stderr] Compiling binrw v0.11.2 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking is-terminal v0.4.8 [INFO] [stderr] Compiling syn v2.0.23 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.11 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Compiling bitmask-enum v2.2.1 [INFO] [stderr] Compiling modular-bitfield-impl v0.11.2 [INFO] [stderr] Checking clap v4.3.11 [INFO] [stderr] Checking modular-bitfield v0.11.2 [INFO] [stderr] Checking vtfTrans-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Arg` [INFO] [stdout] --> src/main.rs:2:20 [INFO] [stdout] | [INFO] [stdout] 2 | use clap::{Parser, Arg,CommandFactory}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mip_helper::Mips` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use mip_helper::Mips; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::BufReader` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::BufReader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/vtf.rs:1:84 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult, io::{Read,Write,Cursor, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bitmask_enum::bitmask` [INFO] [stdout] --> src/vtf.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use bitmask_enum::bitmask; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Mips` [INFO] [stdout] --> src/vtf.rs:6:72 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::{image_format::{ImageFormat,ImageFlags}, mip_helper::{self, Mips}}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/vtf.rs:88:37 [INFO] [stdout] | [INFO] [stdout] 88 | reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 88 - reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] 88 + reader.seek(SeekFrom::Start(hdr.header_size as u64)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/xtf.rs:1:77 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult,io::{Read,Cursor,Write, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `modular_bitfield::private::checks::False` [INFO] [stdout] --> src/xtf.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use modular_bitfield::private::checks::False; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufWriter` [INFO] [stdout] --> src/xtf.rs:3:25 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{BufReader,BufWriter}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UNKNOWN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:8:2 [INFO] [stdout] | [INFO] [stdout] 8 | IMAGE_FORMAT_UNKNOWN = -1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUnknown` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:9:2 [INFO] [stdout] | [INFO] [stdout] 9 | IMAGE_FORMAT_RGBA8888 = 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_ABGR8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 10 | IMAGE_FORMAT_ABGR8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatAbgr8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 11 | IMAGE_FORMAT_RGB888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | IMAGE_FORMAT_BGR888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB565` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:13:2 [INFO] [stdout] | [INFO] [stdout] 13 | IMAGE_FORMAT_RGB565, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb565` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_I8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | IMAGE_FORMAT_I8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatI8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_IA88` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | IMAGE_FORMAT_IA88, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatIa88` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_P8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 16 | IMAGE_FORMAT_P8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatP8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_A8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:17:2 [INFO] [stdout] | [INFO] [stdout] 17 | IMAGE_FORMAT_A8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatA8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB888_BLUESCREEN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 18 | IMAGE_FORMAT_RGB888_BLUESCREEN, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb888Bluescreen` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR888_BLUESCREEN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 19 | IMAGE_FORMAT_BGR888_BLUESCREEN, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr888Bluescreen` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_ARGB8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:20:2 [INFO] [stdout] | [INFO] [stdout] 20 | IMAGE_FORMAT_ARGB8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatArgb8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:21:2 [INFO] [stdout] | [INFO] [stdout] 21 | IMAGE_FORMAT_BGRA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT1` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:22:2 [INFO] [stdout] | [INFO] [stdout] 22 | IMAGE_FORMAT_DXT1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT3` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:23:2 [INFO] [stdout] | [INFO] [stdout] 23 | IMAGE_FORMAT_DXT3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT5` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:24:2 [INFO] [stdout] | [INFO] [stdout] 24 | IMAGE_FORMAT_DXT5, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt5` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:25:2 [INFO] [stdout] | [INFO] [stdout] 25 | IMAGE_FORMAT_BGRX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgrx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR565` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:26:2 [INFO] [stdout] | [INFO] [stdout] 26 | IMAGE_FORMAT_BGR565, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr565` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRX5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:27:2 [INFO] [stdout] | [INFO] [stdout] 27 | IMAGE_FORMAT_BGRX5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgrx5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA4444` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:28:2 [INFO] [stdout] | [INFO] [stdout] 28 | IMAGE_FORMAT_BGRA4444, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra4444` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT1_ONEBITALPHA` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:29:2 [INFO] [stdout] | [INFO] [stdout] 29 | IMAGE_FORMAT_DXT1_ONEBITALPHA, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt1Onebitalpha` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:30:2 [INFO] [stdout] | [INFO] [stdout] 30 | IMAGE_FORMAT_BGRA5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UV88` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:31:2 [INFO] [stdout] | [INFO] [stdout] 31 | IMAGE_FORMAT_UV88, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUv88` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UVWQ8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:32:2 [INFO] [stdout] | [INFO] [stdout] 32 | IMAGE_FORMAT_UVWQ8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUvwq8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA16161616F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:33:2 [INFO] [stdout] | [INFO] [stdout] 33 | IMAGE_FORMAT_RGBA16161616F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba16161616f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA16161616` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:35:2 [INFO] [stdout] | [INFO] [stdout] 35 | IMAGE_FORMAT_RGBA16161616, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba16161616` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UVLX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:36:2 [INFO] [stdout] | [INFO] [stdout] 36 | IMAGE_FORMAT_UVLX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUvlx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_R32F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:37:2 [INFO] [stdout] | [INFO] [stdout] 37 | IMAGE_FORMAT_R32F, // Single-channel 32-bit floating point [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatR32f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB323232F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:38:2 [INFO] [stdout] | [INFO] [stdout] 38 | IMAGE_FORMAT_RGB323232F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb323232f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA32323232F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:39:2 [INFO] [stdout] | [INFO] [stdout] 39 | IMAGE_FORMAT_RGBA32323232F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba32323232f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:40:2 [INFO] [stdout] | [INFO] [stdout] 40 | IMAGE_FORMAT_LINEAR_BGRX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgrx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_RGBA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:41:2 [INFO] [stdout] | [INFO] [stdout] 41 | IMAGE_FORMAT_LINEAR_RGBA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearRgba8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_ABGR8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:42:2 [INFO] [stdout] | [INFO] [stdout] 42 | IMAGE_FORMAT_LINEAR_ABGR8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearAbgr8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_ARGB8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:43:2 [INFO] [stdout] | [INFO] [stdout] 43 | IMAGE_FORMAT_LINEAR_ARGB8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearArgb8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:44:2 [INFO] [stdout] | [INFO] [stdout] 44 | IMAGE_FORMAT_LINEAR_BGRA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgra8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_RGB888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:45:2 [INFO] [stdout] | [INFO] [stdout] 45 | IMAGE_FORMAT_LINEAR_RGB888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearRgb888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGR888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:46:2 [INFO] [stdout] | [INFO] [stdout] 46 | IMAGE_FORMAT_LINEAR_BGR888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgr888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRX5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:47:2 [INFO] [stdout] | [INFO] [stdout] 47 | IMAGE_FORMAT_LINEAR_BGRX5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgrx5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_I8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:48:2 [INFO] [stdout] | [INFO] [stdout] 48 | IMAGE_FORMAT_LINEAR_I8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearI8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NUM_IMAGE_FORMATS` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:49:2 [INFO] [stdout] | [INFO] [stdout] 49 | NUM_IMAGE_FORMATS [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `NumImageFormats` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufReader` and `BufWriter` [INFO] [stdout] --> src/mip_helper.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{BufReader,BufWriter,Write,Read}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `little` should have an upper camel case name [INFO] [stdout] --> src/mip_helper.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | little, [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Little` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `big` should have an upper camel case name [INFO] [stdout] --> src/mip_helper.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | big, [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case: `Big` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/mip_helper.rs:24:71 [INFO] [stdout] | [INFO] [stdout] 24 | let w = if self.resolution.0%4 == 0{self.resolution.0} else {(self.resolution.0+(4-(self.resolution.0 % 4)))}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - let w = if self.resolution.0%4 == 0{self.resolution.0} else {(self.resolution.0+(4-(self.resolution.0 % 4)))}; [INFO] [stdout] 24 + let w = if self.resolution.0%4 == 0{self.resolution.0} else {self.resolution.0+(4-(self.resolution.0 % 4))}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Arg` [INFO] [stdout] --> src/main.rs:2:20 [INFO] [stdout] | [INFO] [stdout] 2 | use clap::{Parser, Arg,CommandFactory}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/mip_helper.rs:25:71 [INFO] [stdout] | [INFO] [stdout] 25 | let h = if self.resolution.1%4 == 0{self.resolution.1} else {(self.resolution.1+(4-(self.resolution.1 % 4)))}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - let h = if self.resolution.1%4 == 0{self.resolution.1} else {(self.resolution.1+(4-(self.resolution.1 % 4)))}; [INFO] [stdout] 25 + let h = if self.resolution.1%4 == 0{self.resolution.1} else {self.resolution.1+(4-(self.resolution.1 % 4))}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:29:61 [INFO] [stdout] | [INFO] [stdout] 29 | image_format::ImageFormat::IMAGE_FORMAT_DXT3 => (w*h), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - image_format::ImageFormat::IMAGE_FORMAT_DXT3 => (w*h), [INFO] [stdout] 29 + image_format::ImageFormat::IMAGE_FORMAT_DXT3 => w*h, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:30:61 [INFO] [stdout] | [INFO] [stdout] 30 | image_format::ImageFormat::IMAGE_FORMAT_DXT5 => (w*h), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 30 - image_format::ImageFormat::IMAGE_FORMAT_DXT5 => (w*h), [INFO] [stdout] 30 + image_format::ImageFormat::IMAGE_FORMAT_DXT5 => w*h, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | _ => (((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 31 - _ => (((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize]), [INFO] [stdout] 31 + _ => ((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/mip_helper.rs:62:11 [INFO] [stdout] | [INFO] [stdout] 62 | if(single){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 62 - if(single){ [INFO] [stdout] 62 + if single { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/transition.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | let low_res = match (infile.hdr.image_format == infile.hdr.low_res_image_format) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 42 - let low_res = match (infile.hdr.image_format == infile.hdr.low_res_image_format) { [INFO] [stdout] 42 + let low_res = match infile.hdr.image_format == infile.hdr.low_res_image_format { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/swizzle.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | while(!done){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - while(!done){ [INFO] [stdout] 13 + while !done { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if (bit < width) { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 15 - if (bit < width) { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 15 + if bit < width { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | if (bit < height) { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - if (bit < height) { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 16 + if bit < height { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | if (bit < depth) { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - if (bit < depth) { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 17 + if bit < depth { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/swizzle.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 28 | while(value!=0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - while(value!=0){ [INFO] [stdout] 28 + while value!=0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | if ((pattern & bit) != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - if ((pattern & bit) != 0) { [INFO] [stdout] 29 + if (pattern & bit) != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/swizzle.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let dst = (dst_off + y*row_pitch+x*bytes_per_pixel); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - let dst = (dst_off + y*row_pitch+x*bytes_per_pixel); [INFO] [stdout] 59 + let dst = dst_off + y*row_pitch+x*bytes_per_pixel; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mip_helper::Mips` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use mip_helper::Mips; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::BufReader` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::BufReader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/vtf.rs:1:84 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult, io::{Read,Write,Cursor, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bitmask_enum::bitmask` [INFO] [stdout] --> src/vtf.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use bitmask_enum::bitmask; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Mips` [INFO] [stdout] --> src/vtf.rs:6:72 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::{image_format::{ImageFormat,ImageFlags}, mip_helper::{self, Mips}}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/vtf.rs:88:37 [INFO] [stdout] | [INFO] [stdout] 88 | reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 88 - reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] 88 + reader.seek(SeekFrom::Start(hdr.header_size as u64)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/xtf.rs:1:77 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult,io::{Read,Cursor,Write, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `modular_bitfield::private::checks::False` [INFO] [stdout] --> src/xtf.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use modular_bitfield::private::checks::False; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufWriter` [INFO] [stdout] --> src/xtf.rs:3:25 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{BufReader,BufWriter}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UNKNOWN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:8:2 [INFO] [stdout] | [INFO] [stdout] 8 | IMAGE_FORMAT_UNKNOWN = -1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUnknown` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:9:2 [INFO] [stdout] | [INFO] [stdout] 9 | IMAGE_FORMAT_RGBA8888 = 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_ABGR8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 10 | IMAGE_FORMAT_ABGR8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatAbgr8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 11 | IMAGE_FORMAT_RGB888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | IMAGE_FORMAT_BGR888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB565` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:13:2 [INFO] [stdout] | [INFO] [stdout] 13 | IMAGE_FORMAT_RGB565, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb565` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_I8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | IMAGE_FORMAT_I8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatI8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_IA88` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | IMAGE_FORMAT_IA88, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatIa88` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_P8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 16 | IMAGE_FORMAT_P8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatP8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_A8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:17:2 [INFO] [stdout] | [INFO] [stdout] 17 | IMAGE_FORMAT_A8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatA8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB888_BLUESCREEN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 18 | IMAGE_FORMAT_RGB888_BLUESCREEN, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb888Bluescreen` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR888_BLUESCREEN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 19 | IMAGE_FORMAT_BGR888_BLUESCREEN, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr888Bluescreen` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_ARGB8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:20:2 [INFO] [stdout] | [INFO] [stdout] 20 | IMAGE_FORMAT_ARGB8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatArgb8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:21:2 [INFO] [stdout] | [INFO] [stdout] 21 | IMAGE_FORMAT_BGRA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT1` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:22:2 [INFO] [stdout] | [INFO] [stdout] 22 | IMAGE_FORMAT_DXT1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT3` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:23:2 [INFO] [stdout] | [INFO] [stdout] 23 | IMAGE_FORMAT_DXT3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT5` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:24:2 [INFO] [stdout] | [INFO] [stdout] 24 | IMAGE_FORMAT_DXT5, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt5` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:25:2 [INFO] [stdout] | [INFO] [stdout] 25 | IMAGE_FORMAT_BGRX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgrx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR565` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:26:2 [INFO] [stdout] | [INFO] [stdout] 26 | IMAGE_FORMAT_BGR565, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr565` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRX5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:27:2 [INFO] [stdout] | [INFO] [stdout] 27 | IMAGE_FORMAT_BGRX5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgrx5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA4444` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:28:2 [INFO] [stdout] | [INFO] [stdout] 28 | IMAGE_FORMAT_BGRA4444, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra4444` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT1_ONEBITALPHA` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:29:2 [INFO] [stdout] | [INFO] [stdout] 29 | IMAGE_FORMAT_DXT1_ONEBITALPHA, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt1Onebitalpha` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:30:2 [INFO] [stdout] | [INFO] [stdout] 30 | IMAGE_FORMAT_BGRA5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UV88` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:31:2 [INFO] [stdout] | [INFO] [stdout] 31 | IMAGE_FORMAT_UV88, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUv88` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UVWQ8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:32:2 [INFO] [stdout] | [INFO] [stdout] 32 | IMAGE_FORMAT_UVWQ8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUvwq8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA16161616F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:33:2 [INFO] [stdout] | [INFO] [stdout] 33 | IMAGE_FORMAT_RGBA16161616F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba16161616f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA16161616` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:35:2 [INFO] [stdout] | [INFO] [stdout] 35 | IMAGE_FORMAT_RGBA16161616, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba16161616` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UVLX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:36:2 [INFO] [stdout] | [INFO] [stdout] 36 | IMAGE_FORMAT_UVLX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUvlx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_R32F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:37:2 [INFO] [stdout] | [INFO] [stdout] 37 | IMAGE_FORMAT_R32F, // Single-channel 32-bit floating point [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatR32f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB323232F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:38:2 [INFO] [stdout] | [INFO] [stdout] 38 | IMAGE_FORMAT_RGB323232F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb323232f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA32323232F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:39:2 [INFO] [stdout] | [INFO] [stdout] 39 | IMAGE_FORMAT_RGBA32323232F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba32323232f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:40:2 [INFO] [stdout] | [INFO] [stdout] 40 | IMAGE_FORMAT_LINEAR_BGRX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgrx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_RGBA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:41:2 [INFO] [stdout] | [INFO] [stdout] 41 | IMAGE_FORMAT_LINEAR_RGBA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearRgba8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_ABGR8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:42:2 [INFO] [stdout] | [INFO] [stdout] 42 | IMAGE_FORMAT_LINEAR_ABGR8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearAbgr8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_ARGB8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:43:2 [INFO] [stdout] | [INFO] [stdout] 43 | IMAGE_FORMAT_LINEAR_ARGB8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearArgb8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:44:2 [INFO] [stdout] | [INFO] [stdout] 44 | IMAGE_FORMAT_LINEAR_BGRA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgra8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_RGB888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:45:2 [INFO] [stdout] | [INFO] [stdout] 45 | IMAGE_FORMAT_LINEAR_RGB888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearRgb888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGR888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:46:2 [INFO] [stdout] | [INFO] [stdout] 46 | IMAGE_FORMAT_LINEAR_BGR888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgr888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRX5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:47:2 [INFO] [stdout] | [INFO] [stdout] 47 | IMAGE_FORMAT_LINEAR_BGRX5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgrx5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_I8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:48:2 [INFO] [stdout] | [INFO] [stdout] 48 | IMAGE_FORMAT_LINEAR_I8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearI8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NUM_IMAGE_FORMATS` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:49:2 [INFO] [stdout] | [INFO] [stdout] 49 | NUM_IMAGE_FORMATS [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `NumImageFormats` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufReader` and `BufWriter` [INFO] [stdout] --> src/mip_helper.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{BufReader,BufWriter,Write,Read}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `little` should have an upper camel case name [INFO] [stdout] --> src/mip_helper.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | little, [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Little` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `big` should have an upper camel case name [INFO] [stdout] --> src/mip_helper.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | big, [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case: `Big` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/mip_helper.rs:24:71 [INFO] [stdout] | [INFO] [stdout] 24 | let w = if self.resolution.0%4 == 0{self.resolution.0} else {(self.resolution.0+(4-(self.resolution.0 % 4)))}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - let w = if self.resolution.0%4 == 0{self.resolution.0} else {(self.resolution.0+(4-(self.resolution.0 % 4)))}; [INFO] [stdout] 24 + let w = if self.resolution.0%4 == 0{self.resolution.0} else {self.resolution.0+(4-(self.resolution.0 % 4))}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/mip_helper.rs:25:71 [INFO] [stdout] | [INFO] [stdout] 25 | let h = if self.resolution.1%4 == 0{self.resolution.1} else {(self.resolution.1+(4-(self.resolution.1 % 4)))}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - let h = if self.resolution.1%4 == 0{self.resolution.1} else {(self.resolution.1+(4-(self.resolution.1 % 4)))}; [INFO] [stdout] 25 + let h = if self.resolution.1%4 == 0{self.resolution.1} else {self.resolution.1+(4-(self.resolution.1 % 4))}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:29:61 [INFO] [stdout] | [INFO] [stdout] 29 | image_format::ImageFormat::IMAGE_FORMAT_DXT3 => (w*h), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - image_format::ImageFormat::IMAGE_FORMAT_DXT3 => (w*h), [INFO] [stdout] 29 + image_format::ImageFormat::IMAGE_FORMAT_DXT3 => w*h, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:30:61 [INFO] [stdout] | [INFO] [stdout] 30 | image_format::ImageFormat::IMAGE_FORMAT_DXT5 => (w*h), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 30 - image_format::ImageFormat::IMAGE_FORMAT_DXT5 => (w*h), [INFO] [stdout] 30 + image_format::ImageFormat::IMAGE_FORMAT_DXT5 => w*h, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | _ => (((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 31 - _ => (((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize]), [INFO] [stdout] 31 + _ => ((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/mip_helper.rs:62:11 [INFO] [stdout] | [INFO] [stdout] 62 | if(single){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 62 - if(single){ [INFO] [stdout] 62 + if single { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/transition.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | let low_res = match (infile.hdr.image_format == infile.hdr.low_res_image_format) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 42 - let low_res = match (infile.hdr.image_format == infile.hdr.low_res_image_format) { [INFO] [stdout] 42 + let low_res = match infile.hdr.image_format == infile.hdr.low_res_image_format { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/swizzle.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | while(!done){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - while(!done){ [INFO] [stdout] 13 + while !done { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if (bit < width) { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 15 - if (bit < width) { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 15 + if bit < width { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | if (bit < height) { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - if (bit < height) { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 16 + if bit < height { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | if (bit < depth) { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - if (bit < depth) { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 17 + if bit < depth { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/swizzle.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 28 | while(value!=0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - while(value!=0){ [INFO] [stdout] 28 + while value!=0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | if ((pattern & bit) != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - if ((pattern & bit) != 0) { [INFO] [stdout] 29 + if (pattern & bit) != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/swizzle.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let dst = (dst_off + y*row_pitch+x*bytes_per_pixel); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - let dst = (dst_off + y*row_pitch+x*bytes_per_pixel); [INFO] [stdout] 59 + let dst = dst_off + y*row_pitch+x*bytes_per_pixel; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BinWriterExt` [INFO] [stdout] --> src/xtf.rs:1:44 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult,io::{Read,Cursor,Write, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BinWriterExt` [INFO] [stdout] --> src/vtf.rs:1:44 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult, io::{Read,Write,Cursor, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BinWriterExt` [INFO] [stdout] --> src/xtf.rs:1:44 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult,io::{Read,Cursor,Write, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BinWriterExt` [INFO] [stdout] --> src/vtf.rs:1:44 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult, io::{Read,Write,Cursor, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/vtf.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | for i in 0..frame_count{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/vtf.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | ... let mut mips = mip_helper::Mips::generate_levels(hdr.width.into(), hdr.height.into(), mip_helper::Order::little,flags.intersects(Im... [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/vtf.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | let result = match &self.low_res.img_data { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/vtf.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | for i in 0..frame_count{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/vtf.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | ... let mut mips = mip_helper::Mips::generate_levels(hdr.width.into(), hdr.height.into(), mip_helper::Order::little,flags.intersects(Im... [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/vtf.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | let result = match &self.low_res.img_data { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/xtf.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | for i in 0..frame_count{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/xtf.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | ... let mut mips = mip_helper::Mips::generate_levels(hdr.width.into(), hdr.height.into(), mip_helper::Order::big,flags.intersects(Image... [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mip_helper.rs:23:40 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn read_mip(&mut self,mut reader: &mut R,format : &image_format::ImageFormat){ [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/mip_helper.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | let result = match &a.img_data { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/xtf.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | for i in 0..frame_count{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/xtf.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | ... let mut mips = mip_helper::Mips::generate_levels(hdr.width.into(), hdr.height.into(), mip_helper::Order::big,flags.intersects(Image... [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `newmip` is assigned to, but never used [INFO] [stdout] --> src/transition.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | let mut newmip = crate::mip_helper::Mip { resolution: (0,0), img_data: (None) }; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_newmip` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `newmip` is never read [INFO] [stdout] --> src/transition.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | newmip = a.level[3].clone(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/transition.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let mut lw; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/transition.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut lh; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/swizzle.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut x:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/swizzle.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let mut y:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | let mut z:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mask_z` [INFO] [stdout] --> src/swizzle.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 69 | let (mask_x,mask_y,mask_z) = generate_swizzle_masks(width, height, depth); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_mask_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/swizzle.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let mut x:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/swizzle.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | let mut y:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut z:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | for z in 0..depth { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VTF_MAJOR_VERSION` is never used [INFO] [stdout] --> src/vtf.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const VTF_MAJOR_VERSION:u32 = 7; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VTF_MINOR_VERSION` is never used [INFO] [stdout] --> src/vtf.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const VTF_MINOR_VERSION:u32 = 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mip_helper.rs:23:40 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn read_mip(&mut self,mut reader: &mut R,format : &image_format::ImageFormat){ [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `open`, `write`, and `new` are never used [INFO] [stdout] --> src/vtf.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 65 | impl VTFHdr{ [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 66 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn write(&self, f: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 76 | pub fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `XTF_MAJOR_VERSION` is never used [INFO] [stdout] --> src/xtf.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const XTF_MAJOR_VERSION:u32 = 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `XTF_MINOR_VERSION` is never used [INFO] [stdout] --> src/xtf.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const XTF_MINOR_VERSION:u32 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `open`, `write`, and `new` are never used [INFO] [stdout] --> src/xtf.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 62 | impl XTFHdr{ [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 63 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | pub fn write(&self, f: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/mip_helper.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | let result = match &a.img_data { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `newmip` is assigned to, but never used [INFO] [stdout] --> src/transition.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | let mut newmip = crate::mip_helper::Mip { resolution: (0,0), img_data: (None) }; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_newmip` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `newmip` is never read [INFO] [stdout] --> src/transition.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | newmip = a.level[3].clone(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/transition.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let mut lw; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/transition.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut lh; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/swizzle.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut x:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/swizzle.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let mut y:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | let mut z:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mask_z` [INFO] [stdout] --> src/swizzle.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 69 | let (mask_x,mask_y,mask_z) = generate_swizzle_masks(width, height, depth); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_mask_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/swizzle.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let mut x:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/swizzle.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | let mut y:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut z:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | for z in 0..depth { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | }else {cmd.print_help();} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | }else {let _ = cmd.print_help();} [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `numResources` should have a snake case name [INFO] [stdout] --> src/vtf.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | numResources : u32, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `num_resources` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | self.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | let _ = self.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 88 | let _ = reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | self.hdr.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 113 | let _ = self.hdr.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | f.seek(SeekFrom::Start(self.hdr.header_size as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 114 | let _ = f.seek(SeekFrom::Start(self.hdr.header_size as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | i.write_mips(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 120 | let _ = i.write_mips(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | self.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 70 | let _ = self.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | reader.seek(SeekFrom::Start(hdr.image_data_offset as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 86 | let _ = reader.seek(SeekFrom::Start(hdr.image_data_offset as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | self.hdr.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 115 | let _ = self.hdr.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | f.seek(SeekFrom::Start(self.hdr.image_data_offset as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 116 | let _ = f.seek(SeekFrom::Start(self.hdr.image_data_offset as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VTF_MAJOR_VERSION` is never used [INFO] [stdout] --> src/vtf.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const VTF_MAJOR_VERSION:u32 = 7; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `ImageFormatBlock` should have an upper case name [INFO] [stdout] --> src/image_format.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 113 | pub static ImageFormatBlock: &'static [usize] = &[4,4,3,3,2,1,2,1,1,3,3,4,4,8,16,16,4,2,2,2,8,2,2,4,64,64,4,12,16,4,4,4,4,4,3,3,2,1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `IMAGE_FORMAT_BLOCK` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VTF_MINOR_VERSION` is never used [INFO] [stdout] --> src/vtf.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const VTF_MINOR_VERSION:u32 = 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `open`, `write`, and `new` are never used [INFO] [stdout] --> src/vtf.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 65 | impl VTFHdr{ [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 66 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn write(&self, f: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 76 | pub fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/mip_helper.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | reader.read_exact(&mut data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 35 | let _ = reader.read_exact(&mut data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `XTF_MAJOR_VERSION` is never used [INFO] [stdout] --> src/xtf.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const XTF_MAJOR_VERSION:u32 = 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `XTF_MINOR_VERSION` is never used [INFO] [stdout] --> src/xtf.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const XTF_MINOR_VERSION:u32 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Order` should have a snake case name [INFO] [stdout] --> src/mip_helper.rs:58:44 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn generate_levels(w:usize,h:usize,Order:Order,single:bool) -> Self{ [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `open`, `write`, and `new` are never used [INFO] [stdout] --> src/xtf.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 62 | impl XTFHdr{ [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 63 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | pub fn write(&self, f: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/transition.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 26 | let _ = outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/transition.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | }else {cmd.print_help();} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | }else {let _ = cmd.print_help();} [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `numResources` should have a snake case name [INFO] [stdout] --> src/vtf.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | numResources : u32, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `num_resources` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | self.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | let _ = self.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 88 | let _ = reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | self.hdr.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 113 | let _ = self.hdr.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | f.seek(SeekFrom::Start(self.hdr.header_size as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 114 | let _ = f.seek(SeekFrom::Start(self.hdr.header_size as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | i.write_mips(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 120 | let _ = i.write_mips(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | self.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 70 | let _ = self.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | reader.seek(SeekFrom::Start(hdr.image_data_offset as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 86 | let _ = reader.seek(SeekFrom::Start(hdr.image_data_offset as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | self.hdr.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 115 | let _ = self.hdr.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | f.seek(SeekFrom::Start(self.hdr.image_data_offset as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 116 | let _ = f.seek(SeekFrom::Start(self.hdr.image_data_offset as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `ImageFormatBlock` should have an upper case name [INFO] [stdout] --> src/image_format.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 113 | pub static ImageFormatBlock: &'static [usize] = &[4,4,3,3,2,1,2,1,1,3,3,4,4,8,16,16,4,2,2,2,8,2,2,4,64,64,4,12,16,4,4,4,4,4,3,3,2,1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `IMAGE_FORMAT_BLOCK` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/mip_helper.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | reader.read_exact(&mut data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 35 | let _ = reader.read_exact(&mut data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Order` should have a snake case name [INFO] [stdout] --> src/mip_helper.rs:58:44 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn generate_levels(w:usize,h:usize,Order:Order,single:bool) -> Self{ [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/transition.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 26 | let _ = outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/transition.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 111 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 111 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.22s [INFO] running `Command { std: "docker" "inspect" "086842f14b748da6307b550f16f1d0bc6f25dcaf14311aad202b9a89f8f224f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "086842f14b748da6307b550f16f1d0bc6f25dcaf14311aad202b9a89f8f224f6", kill_on_drop: false }` [INFO] [stdout] 086842f14b748da6307b550f16f1d0bc6f25dcaf14311aad202b9a89f8f224f6 [INFO] checking smb123w64gb/vtfTrans-rs against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmb123w64gb%2FvtfTrans-rs" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/smb123w64gb/vtfTrans-rs on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/smb123w64gb/vtfTrans-rs [INFO] finished tweaking git repo https://github.com/smb123w64gb/vtfTrans-rs [INFO] tweaked toml for git repo https://github.com/smb123w64gb/vtfTrans-rs written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/smb123w64gb/vtfTrans-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28910ed7e5411f2793e8d728cf77ae1d9668141f6a9dd170d2eab52fe89d2d1f [INFO] running `Command { std: "docker" "start" "-a" "28910ed7e5411f2793e8d728cf77ae1d9668141f6a9dd170d2eab52fe89d2d1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28910ed7e5411f2793e8d728cf77ae1d9668141f6a9dd170d2eab52fe89d2d1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28910ed7e5411f2793e8d728cf77ae1d9668141f6a9dd170d2eab52fe89d2d1f", kill_on_drop: false }` [INFO] [stdout] 28910ed7e5411f2793e8d728cf77ae1d9668141f6a9dd170d2eab52fe89d2d1f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6a8b65fddb145598373cfb90383582c9ca8966d047e5be8136aab5ee7ec1a2c6 [INFO] running `Command { std: "docker" "start" "-a" "6a8b65fddb145598373cfb90383582c9ca8966d047e5be8136aab5ee7ec1a2c6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling rustix v0.38.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling binrw_derive v0.11.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling binrw v0.11.2 [INFO] [stderr] Compiling either v1.8.1 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling syn v2.0.23 [INFO] [stderr] Checking is-terminal v0.4.8 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.11 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Compiling bitmask-enum v2.2.1 [INFO] [stderr] Checking clap v4.3.11 [INFO] [stderr] Compiling modular-bitfield-impl v0.11.2 [INFO] [stderr] Checking modular-bitfield v0.11.2 [INFO] [stderr] Checking vtfTrans-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Arg` [INFO] [stdout] --> src/main.rs:2:20 [INFO] [stdout] | [INFO] [stdout] 2 | use clap::{Parser, Arg,CommandFactory}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mip_helper::Mips` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use mip_helper::Mips; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::BufReader` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::BufReader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/vtf.rs:1:84 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult, io::{Read,Write,Cursor, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bitmask_enum::bitmask` [INFO] [stdout] --> src/vtf.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use bitmask_enum::bitmask; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Mips` [INFO] [stdout] --> src/vtf.rs:6:72 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::{image_format::{ImageFormat,ImageFlags}, mip_helper::{self, Mips}}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/vtf.rs:88:37 [INFO] [stdout] | [INFO] [stdout] 88 | reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 88 - reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] 88 + reader.seek(SeekFrom::Start(hdr.header_size as u64)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/xtf.rs:1:77 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult,io::{Read,Cursor,Write, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `modular_bitfield::private::checks::False` [INFO] [stdout] --> src/xtf.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use modular_bitfield::private::checks::False; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufWriter` [INFO] [stdout] --> src/xtf.rs:3:25 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{BufReader,BufWriter}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UNKNOWN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:8:2 [INFO] [stdout] | [INFO] [stdout] 8 | IMAGE_FORMAT_UNKNOWN = -1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUnknown` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:9:2 [INFO] [stdout] | [INFO] [stdout] 9 | IMAGE_FORMAT_RGBA8888 = 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_ABGR8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 10 | IMAGE_FORMAT_ABGR8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatAbgr8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 11 | IMAGE_FORMAT_RGB888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | IMAGE_FORMAT_BGR888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB565` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:13:2 [INFO] [stdout] | [INFO] [stdout] 13 | IMAGE_FORMAT_RGB565, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb565` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_I8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | IMAGE_FORMAT_I8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatI8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_IA88` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | IMAGE_FORMAT_IA88, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatIa88` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_P8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 16 | IMAGE_FORMAT_P8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatP8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_A8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:17:2 [INFO] [stdout] | [INFO] [stdout] 17 | IMAGE_FORMAT_A8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatA8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB888_BLUESCREEN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 18 | IMAGE_FORMAT_RGB888_BLUESCREEN, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb888Bluescreen` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR888_BLUESCREEN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 19 | IMAGE_FORMAT_BGR888_BLUESCREEN, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr888Bluescreen` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_ARGB8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:20:2 [INFO] [stdout] | [INFO] [stdout] 20 | IMAGE_FORMAT_ARGB8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatArgb8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:21:2 [INFO] [stdout] | [INFO] [stdout] 21 | IMAGE_FORMAT_BGRA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT1` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:22:2 [INFO] [stdout] | [INFO] [stdout] 22 | IMAGE_FORMAT_DXT1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT3` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:23:2 [INFO] [stdout] | [INFO] [stdout] 23 | IMAGE_FORMAT_DXT3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT5` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:24:2 [INFO] [stdout] | [INFO] [stdout] 24 | IMAGE_FORMAT_DXT5, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt5` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:25:2 [INFO] [stdout] | [INFO] [stdout] 25 | IMAGE_FORMAT_BGRX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgrx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR565` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:26:2 [INFO] [stdout] | [INFO] [stdout] 26 | IMAGE_FORMAT_BGR565, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr565` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRX5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:27:2 [INFO] [stdout] | [INFO] [stdout] 27 | IMAGE_FORMAT_BGRX5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgrx5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA4444` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:28:2 [INFO] [stdout] | [INFO] [stdout] 28 | IMAGE_FORMAT_BGRA4444, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra4444` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT1_ONEBITALPHA` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:29:2 [INFO] [stdout] | [INFO] [stdout] 29 | IMAGE_FORMAT_DXT1_ONEBITALPHA, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt1Onebitalpha` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:30:2 [INFO] [stdout] | [INFO] [stdout] 30 | IMAGE_FORMAT_BGRA5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UV88` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:31:2 [INFO] [stdout] | [INFO] [stdout] 31 | IMAGE_FORMAT_UV88, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUv88` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UVWQ8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:32:2 [INFO] [stdout] | [INFO] [stdout] 32 | IMAGE_FORMAT_UVWQ8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUvwq8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA16161616F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:33:2 [INFO] [stdout] | [INFO] [stdout] 33 | IMAGE_FORMAT_RGBA16161616F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba16161616f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA16161616` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:35:2 [INFO] [stdout] | [INFO] [stdout] 35 | IMAGE_FORMAT_RGBA16161616, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba16161616` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UVLX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:36:2 [INFO] [stdout] | [INFO] [stdout] 36 | IMAGE_FORMAT_UVLX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUvlx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_R32F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:37:2 [INFO] [stdout] | [INFO] [stdout] 37 | IMAGE_FORMAT_R32F, // Single-channel 32-bit floating point [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatR32f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB323232F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:38:2 [INFO] [stdout] | [INFO] [stdout] 38 | IMAGE_FORMAT_RGB323232F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb323232f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA32323232F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:39:2 [INFO] [stdout] | [INFO] [stdout] 39 | IMAGE_FORMAT_RGBA32323232F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba32323232f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:40:2 [INFO] [stdout] | [INFO] [stdout] 40 | IMAGE_FORMAT_LINEAR_BGRX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgrx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_RGBA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:41:2 [INFO] [stdout] | [INFO] [stdout] 41 | IMAGE_FORMAT_LINEAR_RGBA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearRgba8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_ABGR8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:42:2 [INFO] [stdout] | [INFO] [stdout] 42 | IMAGE_FORMAT_LINEAR_ABGR8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearAbgr8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_ARGB8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:43:2 [INFO] [stdout] | [INFO] [stdout] 43 | IMAGE_FORMAT_LINEAR_ARGB8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearArgb8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:44:2 [INFO] [stdout] | [INFO] [stdout] 44 | IMAGE_FORMAT_LINEAR_BGRA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgra8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_RGB888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:45:2 [INFO] [stdout] | [INFO] [stdout] 45 | IMAGE_FORMAT_LINEAR_RGB888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearRgb888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGR888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:46:2 [INFO] [stdout] | [INFO] [stdout] 46 | IMAGE_FORMAT_LINEAR_BGR888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgr888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRX5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:47:2 [INFO] [stdout] | [INFO] [stdout] 47 | IMAGE_FORMAT_LINEAR_BGRX5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgrx5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_I8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:48:2 [INFO] [stdout] | [INFO] [stdout] 48 | IMAGE_FORMAT_LINEAR_I8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearI8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NUM_IMAGE_FORMATS` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:49:2 [INFO] [stdout] | [INFO] [stdout] 49 | NUM_IMAGE_FORMATS [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `NumImageFormats` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufReader` and `BufWriter` [INFO] [stdout] --> src/mip_helper.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{BufReader,BufWriter,Write,Read}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `little` should have an upper camel case name [INFO] [stdout] --> src/mip_helper.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | little, [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Little` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `big` should have an upper camel case name [INFO] [stdout] --> src/mip_helper.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | big, [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case: `Big` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/mip_helper.rs:24:71 [INFO] [stdout] | [INFO] [stdout] 24 | let w = if self.resolution.0%4 == 0{self.resolution.0} else {(self.resolution.0+(4-(self.resolution.0 % 4)))}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - let w = if self.resolution.0%4 == 0{self.resolution.0} else {(self.resolution.0+(4-(self.resolution.0 % 4)))}; [INFO] [stdout] 24 + let w = if self.resolution.0%4 == 0{self.resolution.0} else {self.resolution.0+(4-(self.resolution.0 % 4))}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/mip_helper.rs:25:71 [INFO] [stdout] | [INFO] [stdout] 25 | let h = if self.resolution.1%4 == 0{self.resolution.1} else {(self.resolution.1+(4-(self.resolution.1 % 4)))}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - let h = if self.resolution.1%4 == 0{self.resolution.1} else {(self.resolution.1+(4-(self.resolution.1 % 4)))}; [INFO] [stdout] 25 + let h = if self.resolution.1%4 == 0{self.resolution.1} else {self.resolution.1+(4-(self.resolution.1 % 4))}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:29:61 [INFO] [stdout] | [INFO] [stdout] 29 | image_format::ImageFormat::IMAGE_FORMAT_DXT3 => (w*h), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - image_format::ImageFormat::IMAGE_FORMAT_DXT3 => (w*h), [INFO] [stdout] 29 + image_format::ImageFormat::IMAGE_FORMAT_DXT3 => w*h, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:30:61 [INFO] [stdout] | [INFO] [stdout] 30 | image_format::ImageFormat::IMAGE_FORMAT_DXT5 => (w*h), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 30 - image_format::ImageFormat::IMAGE_FORMAT_DXT5 => (w*h), [INFO] [stdout] 30 + image_format::ImageFormat::IMAGE_FORMAT_DXT5 => w*h, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | _ => (((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 31 - _ => (((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize]), [INFO] [stdout] 31 + _ => ((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/mip_helper.rs:62:11 [INFO] [stdout] | [INFO] [stdout] 62 | if(single){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 62 - if(single){ [INFO] [stdout] 62 + if single { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/transition.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | let low_res = match (infile.hdr.image_format == infile.hdr.low_res_image_format) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 42 - let low_res = match (infile.hdr.image_format == infile.hdr.low_res_image_format) { [INFO] [stdout] 42 + let low_res = match infile.hdr.image_format == infile.hdr.low_res_image_format { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/swizzle.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | while(!done){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - while(!done){ [INFO] [stdout] 13 + while !done { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if (bit < width) { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 15 - if (bit < width) { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 15 + if bit < width { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | if (bit < height) { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - if (bit < height) { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 16 + if bit < height { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | if (bit < depth) { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - if (bit < depth) { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 17 + if bit < depth { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Arg` [INFO] [stdout] --> src/main.rs:2:20 [INFO] [stdout] | [INFO] [stdout] 2 | use clap::{Parser, Arg,CommandFactory}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/swizzle.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 28 | while(value!=0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - while(value!=0){ [INFO] [stdout] 28 + while value!=0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | if ((pattern & bit) != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - if ((pattern & bit) != 0) { [INFO] [stdout] 29 + if (pattern & bit) != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mip_helper::Mips` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use mip_helper::Mips; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/swizzle.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let dst = (dst_off + y*row_pitch+x*bytes_per_pixel); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - let dst = (dst_off + y*row_pitch+x*bytes_per_pixel); [INFO] [stdout] 59 + let dst = dst_off + y*row_pitch+x*bytes_per_pixel; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::BufReader` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::BufReader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/vtf.rs:1:84 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult, io::{Read,Write,Cursor, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bitmask_enum::bitmask` [INFO] [stdout] --> src/vtf.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use bitmask_enum::bitmask; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Mips` [INFO] [stdout] --> src/vtf.rs:6:72 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::{image_format::{ImageFormat,ImageFlags}, mip_helper::{self, Mips}}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/vtf.rs:88:37 [INFO] [stdout] | [INFO] [stdout] 88 | reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 88 - reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] 88 + reader.seek(SeekFrom::Start(hdr.header_size as u64)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/xtf.rs:1:77 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult,io::{Read,Cursor,Write, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `modular_bitfield::private::checks::False` [INFO] [stdout] --> src/xtf.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use modular_bitfield::private::checks::False; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufWriter` [INFO] [stdout] --> src/xtf.rs:3:25 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{BufReader,BufWriter}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UNKNOWN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:8:2 [INFO] [stdout] | [INFO] [stdout] 8 | IMAGE_FORMAT_UNKNOWN = -1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUnknown` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:9:2 [INFO] [stdout] | [INFO] [stdout] 9 | IMAGE_FORMAT_RGBA8888 = 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_ABGR8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 10 | IMAGE_FORMAT_ABGR8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatAbgr8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 11 | IMAGE_FORMAT_RGB888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | IMAGE_FORMAT_BGR888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB565` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:13:2 [INFO] [stdout] | [INFO] [stdout] 13 | IMAGE_FORMAT_RGB565, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb565` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_I8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | IMAGE_FORMAT_I8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatI8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_IA88` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | IMAGE_FORMAT_IA88, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatIa88` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_P8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 16 | IMAGE_FORMAT_P8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatP8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_A8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:17:2 [INFO] [stdout] | [INFO] [stdout] 17 | IMAGE_FORMAT_A8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatA8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB888_BLUESCREEN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 18 | IMAGE_FORMAT_RGB888_BLUESCREEN, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb888Bluescreen` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR888_BLUESCREEN` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 19 | IMAGE_FORMAT_BGR888_BLUESCREEN, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr888Bluescreen` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_ARGB8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:20:2 [INFO] [stdout] | [INFO] [stdout] 20 | IMAGE_FORMAT_ARGB8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatArgb8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:21:2 [INFO] [stdout] | [INFO] [stdout] 21 | IMAGE_FORMAT_BGRA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT1` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:22:2 [INFO] [stdout] | [INFO] [stdout] 22 | IMAGE_FORMAT_DXT1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT3` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:23:2 [INFO] [stdout] | [INFO] [stdout] 23 | IMAGE_FORMAT_DXT3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT5` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:24:2 [INFO] [stdout] | [INFO] [stdout] 24 | IMAGE_FORMAT_DXT5, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt5` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:25:2 [INFO] [stdout] | [INFO] [stdout] 25 | IMAGE_FORMAT_BGRX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgrx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGR565` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:26:2 [INFO] [stdout] | [INFO] [stdout] 26 | IMAGE_FORMAT_BGR565, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgr565` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRX5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:27:2 [INFO] [stdout] | [INFO] [stdout] 27 | IMAGE_FORMAT_BGRX5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgrx5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA4444` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:28:2 [INFO] [stdout] | [INFO] [stdout] 28 | IMAGE_FORMAT_BGRA4444, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra4444` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_DXT1_ONEBITALPHA` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:29:2 [INFO] [stdout] | [INFO] [stdout] 29 | IMAGE_FORMAT_DXT1_ONEBITALPHA, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatDxt1Onebitalpha` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_BGRA5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:30:2 [INFO] [stdout] | [INFO] [stdout] 30 | IMAGE_FORMAT_BGRA5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatBgra5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UV88` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:31:2 [INFO] [stdout] | [INFO] [stdout] 31 | IMAGE_FORMAT_UV88, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUv88` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UVWQ8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:32:2 [INFO] [stdout] | [INFO] [stdout] 32 | IMAGE_FORMAT_UVWQ8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUvwq8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA16161616F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:33:2 [INFO] [stdout] | [INFO] [stdout] 33 | IMAGE_FORMAT_RGBA16161616F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba16161616f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA16161616` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:35:2 [INFO] [stdout] | [INFO] [stdout] 35 | IMAGE_FORMAT_RGBA16161616, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba16161616` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_UVLX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:36:2 [INFO] [stdout] | [INFO] [stdout] 36 | IMAGE_FORMAT_UVLX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatUvlx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_R32F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:37:2 [INFO] [stdout] | [INFO] [stdout] 37 | IMAGE_FORMAT_R32F, // Single-channel 32-bit floating point [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatR32f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGB323232F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:38:2 [INFO] [stdout] | [INFO] [stdout] 38 | IMAGE_FORMAT_RGB323232F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgb323232f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_RGBA32323232F` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:39:2 [INFO] [stdout] | [INFO] [stdout] 39 | IMAGE_FORMAT_RGBA32323232F, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatRgba32323232f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRX8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:40:2 [INFO] [stdout] | [INFO] [stdout] 40 | IMAGE_FORMAT_LINEAR_BGRX8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgrx8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_RGBA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:41:2 [INFO] [stdout] | [INFO] [stdout] 41 | IMAGE_FORMAT_LINEAR_RGBA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearRgba8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_ABGR8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:42:2 [INFO] [stdout] | [INFO] [stdout] 42 | IMAGE_FORMAT_LINEAR_ABGR8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearAbgr8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_ARGB8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:43:2 [INFO] [stdout] | [INFO] [stdout] 43 | IMAGE_FORMAT_LINEAR_ARGB8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearArgb8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRA8888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:44:2 [INFO] [stdout] | [INFO] [stdout] 44 | IMAGE_FORMAT_LINEAR_BGRA8888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgra8888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_RGB888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:45:2 [INFO] [stdout] | [INFO] [stdout] 45 | IMAGE_FORMAT_LINEAR_RGB888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearRgb888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGR888` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:46:2 [INFO] [stdout] | [INFO] [stdout] 46 | IMAGE_FORMAT_LINEAR_BGR888, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgr888` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_BGRX5551` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:47:2 [INFO] [stdout] | [INFO] [stdout] 47 | IMAGE_FORMAT_LINEAR_BGRX5551, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearBgrx5551` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IMAGE_FORMAT_LINEAR_I8` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:48:2 [INFO] [stdout] | [INFO] [stdout] 48 | IMAGE_FORMAT_LINEAR_I8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ImageFormatLinearI8` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NUM_IMAGE_FORMATS` should have an upper camel case name [INFO] [stdout] --> src/image_format.rs:49:2 [INFO] [stdout] | [INFO] [stdout] 49 | NUM_IMAGE_FORMATS [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `NumImageFormats` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufReader` and `BufWriter` [INFO] [stdout] --> src/mip_helper.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{BufReader,BufWriter,Write,Read}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `little` should have an upper camel case name [INFO] [stdout] --> src/mip_helper.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | little, [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Little` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `big` should have an upper camel case name [INFO] [stdout] --> src/mip_helper.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | big, [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case: `Big` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/mip_helper.rs:24:71 [INFO] [stdout] | [INFO] [stdout] 24 | let w = if self.resolution.0%4 == 0{self.resolution.0} else {(self.resolution.0+(4-(self.resolution.0 % 4)))}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - let w = if self.resolution.0%4 == 0{self.resolution.0} else {(self.resolution.0+(4-(self.resolution.0 % 4)))}; [INFO] [stdout] 24 + let w = if self.resolution.0%4 == 0{self.resolution.0} else {self.resolution.0+(4-(self.resolution.0 % 4))}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/mip_helper.rs:25:71 [INFO] [stdout] | [INFO] [stdout] 25 | let h = if self.resolution.1%4 == 0{self.resolution.1} else {(self.resolution.1+(4-(self.resolution.1 % 4)))}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - let h = if self.resolution.1%4 == 0{self.resolution.1} else {(self.resolution.1+(4-(self.resolution.1 % 4)))}; [INFO] [stdout] 25 + let h = if self.resolution.1%4 == 0{self.resolution.1} else {self.resolution.1+(4-(self.resolution.1 % 4))}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:29:61 [INFO] [stdout] | [INFO] [stdout] 29 | image_format::ImageFormat::IMAGE_FORMAT_DXT3 => (w*h), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - image_format::ImageFormat::IMAGE_FORMAT_DXT3 => (w*h), [INFO] [stdout] 29 + image_format::ImageFormat::IMAGE_FORMAT_DXT3 => w*h, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:30:61 [INFO] [stdout] | [INFO] [stdout] 30 | image_format::ImageFormat::IMAGE_FORMAT_DXT5 => (w*h), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 30 - image_format::ImageFormat::IMAGE_FORMAT_DXT5 => (w*h), [INFO] [stdout] 30 + image_format::ImageFormat::IMAGE_FORMAT_DXT5 => w*h, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/mip_helper.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | _ => (((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 31 - _ => (((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize]), [INFO] [stdout] 31 + _ => ((self.resolution.0 * self.resolution.1) as usize)* image_format::ImageFormatBlock[*format as usize], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/mip_helper.rs:62:11 [INFO] [stdout] | [INFO] [stdout] 62 | if(single){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 62 - if(single){ [INFO] [stdout] 62 + if single { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/transition.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | let low_res = match (infile.hdr.image_format == infile.hdr.low_res_image_format) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 42 - let low_res = match (infile.hdr.image_format == infile.hdr.low_res_image_format) { [INFO] [stdout] 42 + let low_res = match infile.hdr.image_format == infile.hdr.low_res_image_format { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/swizzle.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | while(!done){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - while(!done){ [INFO] [stdout] 13 + while !done { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if (bit < width) { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 15 - if (bit < width) { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 15 + if bit < width { x |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | if (bit < height) { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - if (bit < height) { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 16 + if bit < height { y |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | if (bit < depth) { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - if (bit < depth) { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] 17 + if bit < depth { z |= mask_bit; mask_bit <<= 1; done = false; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/swizzle.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 28 | while(value!=0){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - while(value!=0){ [INFO] [stdout] 28 + while value!=0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/swizzle.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | if ((pattern & bit) != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 29 - if ((pattern & bit) != 0) { [INFO] [stdout] 29 + if (pattern & bit) != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/swizzle.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let dst = (dst_off + y*row_pitch+x*bytes_per_pixel); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - let dst = (dst_off + y*row_pitch+x*bytes_per_pixel); [INFO] [stdout] 59 + let dst = dst_off + y*row_pitch+x*bytes_per_pixel; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BinWriterExt` [INFO] [stdout] --> src/xtf.rs:1:44 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult,io::{Read,Cursor,Write, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BinWriterExt` [INFO] [stdout] --> src/vtf.rs:1:44 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult, io::{Read,Write,Cursor, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BinWriterExt` [INFO] [stdout] --> src/xtf.rs:1:44 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult,io::{Read,Cursor,Write, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BinWriterExt` [INFO] [stdout] --> src/vtf.rs:1:44 [INFO] [stdout] | [INFO] [stdout] 1 | use binrw::{BinRead, BinWrite,BinReaderExt,BinWriterExt,BinResult, io::{Read,Write,Cursor, Seek,SeekFrom}}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/vtf.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | for i in 0..frame_count{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/vtf.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | ... let mut mips = mip_helper::Mips::generate_levels(hdr.width.into(), hdr.height.into(), mip_helper::Order::little,flags.intersects(Im... [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/vtf.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | let result = match &self.low_res.img_data { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/xtf.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | for i in 0..frame_count{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/xtf.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | ... let mut mips = mip_helper::Mips::generate_levels(hdr.width.into(), hdr.height.into(), mip_helper::Order::big,flags.intersects(Image... [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/vtf.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | for i in 0..frame_count{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mip_helper.rs:23:40 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn read_mip(&mut self,mut reader: &mut R,format : &image_format::ImageFormat){ [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/vtf.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | ... let mut mips = mip_helper::Mips::generate_levels(hdr.width.into(), hdr.height.into(), mip_helper::Order::little,flags.intersects(Im... [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/vtf.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | let result = match &self.low_res.img_data { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/mip_helper.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | let result = match &a.img_data { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `newmip` is assigned to, but never used [INFO] [stdout] --> src/transition.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | let mut newmip = crate::mip_helper::Mip { resolution: (0,0), img_data: (None) }; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_newmip` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `newmip` is never read [INFO] [stdout] --> src/transition.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | newmip = a.level[3].clone(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/transition.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let mut lw; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/transition.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut lh; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/swizzle.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut x:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/swizzle.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let mut y:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | let mut z:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mask_z` [INFO] [stdout] --> src/swizzle.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 69 | let (mask_x,mask_y,mask_z) = generate_swizzle_masks(width, height, depth); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_mask_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/swizzle.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let mut x:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/swizzle.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | let mut y:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut z:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | for z in 0..depth { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VTF_MAJOR_VERSION` is never used [INFO] [stdout] --> src/vtf.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const VTF_MAJOR_VERSION:u32 = 7; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VTF_MINOR_VERSION` is never used [INFO] [stdout] --> src/vtf.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const VTF_MINOR_VERSION:u32 = 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `open`, `write`, and `new` are never used [INFO] [stdout] --> src/vtf.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 65 | impl VTFHdr{ [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 66 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn write(&self, f: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 76 | pub fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `XTF_MAJOR_VERSION` is never used [INFO] [stdout] --> src/xtf.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const XTF_MAJOR_VERSION:u32 = 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `XTF_MINOR_VERSION` is never used [INFO] [stdout] --> src/xtf.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const XTF_MINOR_VERSION:u32 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `open`, `write`, and `new` are never used [INFO] [stdout] --> src/xtf.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 62 | impl XTFHdr{ [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 63 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | pub fn write(&self, f: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | }else {cmd.print_help();} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | }else {let _ = cmd.print_help();} [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `numResources` should have a snake case name [INFO] [stdout] --> src/vtf.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | numResources : u32, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `num_resources` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/xtf.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | for i in 0..frame_count{ [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vtf.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | BufReader::new(std::fs::File::open(path)?).read_le() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | self.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | let _ = self.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 88 | let _ = reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | self.hdr.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 113 | let _ = self.hdr.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | f.seek(SeekFrom::Start(self.hdr.header_size as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 114 | let _ = f.seek(SeekFrom::Start(self.hdr.header_size as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | i.write_mips(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 120 | let _ = i.write_mips(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/xtf.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | ... let mut mips = mip_helper::Mips::generate_levels(hdr.width.into(), hdr.height.into(), mip_helper::Order::big,flags.intersects(Image... [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xtf.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | BufReader::new(std::fs::File::open(path)?).read_le() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | self.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 70 | let _ = self.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | reader.seek(SeekFrom::Start(hdr.image_data_offset as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 86 | let _ = reader.seek(SeekFrom::Start(hdr.image_data_offset as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | self.hdr.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 115 | let _ = self.hdr.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | f.seek(SeekFrom::Start(self.hdr.image_data_offset as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 116 | let _ = f.seek(SeekFrom::Start(self.hdr.image_data_offset as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `ImageFormatBlock` should have an upper case name [INFO] [stdout] --> src/image_format.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 113 | pub static ImageFormatBlock: &'static [usize] = &[4,4,3,3,2,1,2,1,1,3,3,4,4,8,16,16,4,2,2,2,8,2,2,4,64,64,4,12,16,4,4,4,4,4,3,3,2,1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `IMAGE_FORMAT_BLOCK` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/mip_helper.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | reader.read_exact(&mut data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 35 | let _ = reader.read_exact(&mut data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Order` should have a snake case name [INFO] [stdout] --> src/mip_helper.rs:58:44 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn generate_levels(w:usize,h:usize,Order:Order,single:bool) -> Self{ [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/transition.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 26 | let _ = outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/transition.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mip_helper.rs:23:40 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn read_mip(&mut self,mut reader: &mut R,format : &image_format::ImageFormat){ [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/mip_helper.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | let result = match &a.img_data { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 111 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `newmip` is assigned to, but never used [INFO] [stdout] --> src/transition.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | let mut newmip = crate::mip_helper::Mip { resolution: (0,0), img_data: (None) }; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_newmip` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `newmip` is never read [INFO] [stdout] --> src/transition.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | newmip = a.level[3].clone(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/transition.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let mut lw; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/transition.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut lh; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/swizzle.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut x:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/swizzle.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let mut y:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | let mut z:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mask_z` [INFO] [stdout] --> src/swizzle.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 69 | let (mask_x,mask_y,mask_z) = generate_swizzle_masks(width, height, depth); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_mask_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/swizzle.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let mut x:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/swizzle.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | let mut y:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut z:usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/swizzle.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | for z in 0..depth { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VTF_MAJOR_VERSION` is never used [INFO] [stdout] --> src/vtf.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const VTF_MAJOR_VERSION:u32 = 7; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VTF_MINOR_VERSION` is never used [INFO] [stdout] --> src/vtf.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const VTF_MINOR_VERSION:u32 = 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `open`, `write`, and `new` are never used [INFO] [stdout] --> src/vtf.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 65 | impl VTFHdr{ [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 66 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn write(&self, f: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 76 | pub fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `XTF_MAJOR_VERSION` is never used [INFO] [stdout] --> src/xtf.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const XTF_MAJOR_VERSION:u32 = 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `XTF_MINOR_VERSION` is never used [INFO] [stdout] --> src/xtf.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const XTF_MINOR_VERSION:u32 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `open`, `write`, and `new` are never used [INFO] [stdout] --> src/xtf.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 62 | impl XTFHdr{ [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 63 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | pub fn write(&self, f: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vtfTrans-rs` (bin "vtfTrans-rs") due to 3 previous errors; 111 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | }else {cmd.print_help();} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | }else {let _ = cmd.print_help();} [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `numResources` should have a snake case name [INFO] [stdout] --> src/vtf.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | numResources : u32, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `num_resources` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vtf.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | BufReader::new(std::fs::File::open(path)?).read_le() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | self.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | let _ = self.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 88 | let _ = reader.seek(SeekFrom::Start((hdr.header_size as u64))); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | self.hdr.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 113 | let _ = self.hdr.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | f.seek(SeekFrom::Start(self.hdr.header_size as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 114 | let _ = f.seek(SeekFrom::Start(self.hdr.header_size as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/vtf.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | i.write_mips(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 120 | let _ = i.write_mips(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xtf.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn open>(path: P) -> BinResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | BufReader::new(std::fs::File::open(path)?).read_le() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | self.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 70 | let _ = self.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | reader.seek(SeekFrom::Start(hdr.image_data_offset as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 86 | let _ = reader.seek(SeekFrom::Start(hdr.image_data_offset as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | self.hdr.write_le(f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 115 | let _ = self.hdr.write_le(f); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/xtf.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | f.seek(SeekFrom::Start(self.hdr.image_data_offset as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 116 | let _ = f.seek(SeekFrom::Start(self.hdr.image_data_offset as u64)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `ImageFormatBlock` should have an upper case name [INFO] [stdout] --> src/image_format.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 113 | pub static ImageFormatBlock: &'static [usize] = &[4,4,3,3,2,1,2,1,1,3,3,4,4,8,16,16,4,2,2,2,8,2,2,4,64,64,4,12,16,4,4,4,4,4,3,3,2,1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `IMAGE_FORMAT_BLOCK` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/mip_helper.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | reader.read_exact(&mut data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 35 | let _ = reader.read_exact(&mut data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Order` should have a snake case name [INFO] [stdout] --> src/mip_helper.rs:58:44 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn generate_levels(w:usize,h:usize,Order:Order,single:bool) -> Self{ [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/transition.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 26 | let _ = outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/transition.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = outfile.write(&mut BufWriter::new(std::fs::File::create(output).unwrap())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 111 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vtfTrans-rs` (bin "vtfTrans-rs" test) due to 3 previous errors; 111 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6a8b65fddb145598373cfb90383582c9ca8966d047e5be8136aab5ee7ec1a2c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a8b65fddb145598373cfb90383582c9ca8966d047e5be8136aab5ee7ec1a2c6", kill_on_drop: false }` [INFO] [stdout] 6a8b65fddb145598373cfb90383582c9ca8966d047e5be8136aab5ee7ec1a2c6