[INFO] cloning repository https://github.com/shybyte/rust-midi-patcher [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/shybyte/rust-midi-patcher" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshybyte%2Frust-midi-patcher", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshybyte%2Frust-midi-patcher'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a7dda29654452f47507f407dccbba8a138616ec5 [INFO] checking shybyte/rust-midi-patcher against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshybyte%2Frust-midi-patcher" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/shybyte/rust-midi-patcher on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/shybyte/rust-midi-patcher [INFO] finished tweaking git repo https://github.com/shybyte/rust-midi-patcher [INFO] tweaked toml for git repo https://github.com/shybyte/rust-midi-patcher written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/shybyte/rust-midi-patcher already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/shybyte/midi-message-rs` [INFO] [stderr] Updating git repository `https://github.com/shybyte/midi2opc` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lazy_static v0.2.4 [INFO] [stderr] Downloaded rustc_version v0.2.3 [INFO] [stderr] Downloaded stable_deref_trait v1.1.1 [INFO] [stderr] Downloaded bit-set v0.4.0 [INFO] [stderr] Downloaded winapi v0.3.6 [INFO] [stderr] Downloaded libc v0.2.43 [INFO] [stderr] Downloaded chan v0.1.23 [INFO] [stderr] Downloaded rand v0.3.15 [INFO] [stderr] Downloaded filetime v0.2.4 [INFO] [stderr] Downloaded bitflags v0.7.0 [INFO] [stderr] Downloaded fsevent-sys v0.1.6 [INFO] [stderr] Downloaded inotify-sys v0.1.3 [INFO] [stderr] Downloaded crossbeam-utils v0.5.0 [INFO] [stderr] Downloaded lazy_static v1.2.0 [INFO] [stderr] Downloaded num_cpus v1.8.0 [INFO] [stderr] Downloaded owning_ref v0.4.0 [INFO] [stderr] Downloaded cloudabi v0.0.3 [INFO] [stderr] Downloaded rand_core v0.3.0 [INFO] [stderr] Downloaded rand_core v0.2.2 [INFO] [stderr] Downloaded rand v0.5.5 [INFO] [stderr] Downloaded smallvec v0.6.6 [INFO] [stderr] Downloaded parking_lot v0.6.4 [INFO] [stderr] Downloaded tokio-executor v0.1.5 [INFO] [stderr] Downloaded byteorder v1.2.7 [INFO] [stderr] Downloaded futures v0.1.25 [INFO] [stderr] Downloaded tokio-io v0.1.10 [INFO] [stderr] Downloaded bitflags v1.0.4 [INFO] [stderr] Downloaded fuchsia-zircon v0.3.3 [INFO] [stderr] Downloaded fuchsia-zircon-sys v0.3.3 [INFO] [stderr] Downloaded lazycell v1.2.0 [INFO] [stderr] Downloaded log v0.4.6 [INFO] [stderr] Downloaded ws2_32-sys v0.2.1 [INFO] [stderr] Downloaded miow v0.2.1 [INFO] [stderr] Downloaded cfg-if v0.1.6 [INFO] [stderr] Downloaded net2 v0.2.33 [INFO] [stderr] Downloaded mio v0.6.16 [INFO] [stderr] Downloaded risp v0.7.0 [INFO] [stderr] Downloaded notify v4.0.6 [INFO] [stderr] Downloaded scopeguard v0.3.3 [INFO] [stderr] Downloaded same-file v1.0.4 [INFO] [stderr] Downloaded lock_api v0.1.5 [INFO] [stderr] Downloaded inotify v0.6.1 [INFO] [stderr] Downloaded mio-extras v2.0.5 [INFO] [stderr] Downloaded redox_syscall v0.1.17 [INFO] [stderr] Downloaded slab v0.4.1 [INFO] [stderr] Downloaded semver-parser v0.7.0 [INFO] [stderr] Downloaded semver v0.9.0 [INFO] [stderr] Downloaded iovec v0.1.2 [INFO] [stderr] Downloaded parking_lot_core v0.3.1 [INFO] [stderr] Downloaded portmidi v0.2.4 [INFO] [stderr] Downloaded fsevent v0.2.17 [INFO] [stderr] Downloaded tokio-reactor v0.1.6 [INFO] [stderr] Downloaded winapi-util v0.1.1 [INFO] [stderr] Downloaded walkdir v2.2.7 [INFO] [stderr] Downloaded bit-vec v0.4.3 [INFO] [stderr] Downloaded chan-signal v0.3.2 [INFO] [stderr] Downloaded bytes v0.4.11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 204ce87369c4b3aef98cb4420e8b47a5a17f4fdc8ca5e3fe7160c5694a9cbd6b [INFO] running `Command { std: "docker" "start" "-a" "204ce87369c4b3aef98cb4420e8b47a5a17f4fdc8ca5e3fe7160c5694a9cbd6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "204ce87369c4b3aef98cb4420e8b47a5a17f4fdc8ca5e3fe7160c5694a9cbd6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "204ce87369c4b3aef98cb4420e8b47a5a17f4fdc8ca5e3fe7160c5694a9cbd6b", kill_on_drop: false }` [INFO] [stdout] 204ce87369c4b3aef98cb4420e8b47a5a17f4fdc8ca5e3fe7160c5694a9cbd6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 327a42afecfe77307282d2f29c8dc34585637717da63dc92623c5a12500903b1 [INFO] running `Command { std: "docker" "start" "-a" "327a42afecfe77307282d2f29c8dc34585637717da63dc92623c5a12500903b1", kill_on_drop: false }` [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking lazycell v1.2.0 [INFO] [stderr] Checking slab v0.4.1 [INFO] [stderr] Checking futures v0.1.25 [INFO] [stderr] Checking lazy_static v0.2.4 [INFO] [stderr] Checking bit-vec v0.4.3 [INFO] [stderr] Checking crossbeam-utils v0.5.0 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Checking unreachable v0.1.1 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking regex-syntax v0.4.0 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking portmidi v0.2.4 [INFO] [stderr] Checking smallvec v0.6.6 [INFO] [stderr] Checking midi-message v0.1.0 (https://github.com/shybyte/midi-message-rs#cda61b2d) [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking bit-set v0.4.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking inotify-sys v0.1.3 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking chan v0.1.23 [INFO] [stderr] Checking chan-signal v0.3.2 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking midi2opc v0.1.0 (https://github.com/shybyte/midi2opc#825f0ab0) [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking tokio-executor v0.1.5 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking risp v0.7.0 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking notify v4.0.6 [INFO] [stderr] Checking rust_midi_patcher v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:37:62 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 37 - pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] 37 + pub fn new_simple>(name: S, effects: Vec>, program: u8) -> Patch { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | (midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - (midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0)) [INFO] [stdout] 94 + midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | (midi_message.status == 0x80) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 98 - (midi_message.status == 0x80) [INFO] [stdout] 98 + midi_message.status == 0x80 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | (midi_message.status == 0xB0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 102 - (midi_message.status == 0xB0) [INFO] [stdout] 102 + midi_message.status == 0xB0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::effects::sweep_down::SweepDown` [INFO] [stdout] --> src/songs/endstation_paradies.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use crate::effects::sweep_down::SweepDown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::Boxable` [INFO] [stdout] --> src/songs/endstation_paradies.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use crate::utils::Boxable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::microkorg::VOLUME` [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use crate::microkorg::VOLUME; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:37:62 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 37 - pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] 37 + pub fn new_simple>(name: S, effects: Vec>, program: u8) -> Patch { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | (midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - (midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0)) [INFO] [stdout] 94 + midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | (midi_message.status == 0x80) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 98 - (midi_message.status == 0x80) [INFO] [stdout] 98 + midi_message.status == 0x80 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | (midi_message.status == 0xB0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 102 - (midi_message.status == 0xB0) [INFO] [stdout] 102 + midi_message.status == 0xB0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::effects::sweep_down::SweepDown` [INFO] [stdout] --> src/songs/endstation_paradies.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use crate::effects::sweep_down::SweepDown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::Boxable` [INFO] [stdout] --> src/songs/endstation_paradies.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use crate::utils::Boxable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::microkorg::VOLUME` [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use crate::microkorg::VOLUME; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:15:37 [INFO] [stdout] | [INFO] [stdout] 15 | effects: Vec<(Box, Box)>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | effects: Vec<(Box, Box)>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:24:74 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new>(name: S, effects: Vec<(Box, Box)>, program: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new>(name: S, effects: Vec<(Box, Box)>, program: u8, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:37:67 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:15:37 [INFO] [stdout] | [INFO] [stdout] 15 | effects: Vec<(Box, Box)>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | effects: Vec<(Box, Box)>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:24:74 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new>(name: S, effects: Vec<(Box, Box)>, program: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new>(name: S, effects: Vec<(Box, Box)>, program: u8, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:37:67 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/load_patches.rs:110:119 [INFO] [stdout] | [INFO] [stdout] 110 | fn to_trigger_effect_pair(input: &RispType, default_time_per_note: i64, config: &Config) -> Result<(Box, Box), RispError> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 110 | fn to_trigger_effect_pair(input: &RispType, default_time_per_note: i64, config: &Config) -> Result<(Box, Box), RispError> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/load_patches.rs:110:119 [INFO] [stdout] | [INFO] [stdout] 110 | fn to_trigger_effect_pair(input: &RispType, default_time_per_note: i64, config: &Config) -> Result<(Box, Box), RispError> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 110 | fn to_trigger_effect_pair(input: &RispType, default_time_per_note: i64, config: &Config) -> Result<(Box, Box), RispError> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `BASE_NOTE` is never used [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | static BASE_NOTE: &str = "BASE_NOTE"; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `liebt_uns2` is never used [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn liebt_uns2(_config2: &Config) -> Patch { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `BASE_NOTE` is never used [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | static BASE_NOTE: &str = "BASE_NOTE"; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `liebt_uns2` is never used [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn liebt_uns2(_config2: &Config) -> Patch { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/absolute_sleep.rs:45:46 [INFO] [stdout] | [INFO] [stdout] 45 | assert!(sleep_time.abs() < 1000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 45 - assert!(sleep_time.abs() < 1000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] 45 + assert!(sleep_time.abs() < 1000_000, "sleep right time {}", sleep_time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/absolute_sleep.rs:55:46 [INFO] [stdout] | [INFO] [stdout] 55 | assert!(sleep_time.abs() < 1000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 55 - assert!(sleep_time.abs() < 1000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] 55 + assert!(sleep_time.abs() < 1000_000, "sleep right time {}", sleep_time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/absolute_sleep.rs:65:46 [INFO] [stdout] | [INFO] [stdout] 65 | assert!(sleep_time.abs() < 2000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 65 - assert!(sleep_time.abs() < 2000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] 65 + assert!(sleep_time.abs() < 2000_000, "sleep right time {}", sleep_time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.29s [INFO] running `Command { std: "docker" "inspect" "327a42afecfe77307282d2f29c8dc34585637717da63dc92623c5a12500903b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "327a42afecfe77307282d2f29c8dc34585637717da63dc92623c5a12500903b1", kill_on_drop: false }` [INFO] [stdout] 327a42afecfe77307282d2f29c8dc34585637717da63dc92623c5a12500903b1 [INFO] checking shybyte/rust-midi-patcher against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshybyte%2Frust-midi-patcher" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/shybyte/rust-midi-patcher on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/shybyte/rust-midi-patcher [INFO] finished tweaking git repo https://github.com/shybyte/rust-midi-patcher [INFO] tweaked toml for git repo https://github.com/shybyte/rust-midi-patcher written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/shybyte/rust-midi-patcher already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ccdb6bdd6872a0c6f454470e52b9d2db0a37026c18f8d2e0cfe74af5634f41eb [INFO] running `Command { std: "docker" "start" "-a" "ccdb6bdd6872a0c6f454470e52b9d2db0a37026c18f8d2e0cfe74af5634f41eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ccdb6bdd6872a0c6f454470e52b9d2db0a37026c18f8d2e0cfe74af5634f41eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccdb6bdd6872a0c6f454470e52b9d2db0a37026c18f8d2e0cfe74af5634f41eb", kill_on_drop: false }` [INFO] [stdout] ccdb6bdd6872a0c6f454470e52b9d2db0a37026c18f8d2e0cfe74af5634f41eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 67ea730bf29ec41efb792b4e7266880b051d35f31c1ccc6160abbd14fa2cded1 [INFO] running `Command { std: "docker" "start" "-a" "67ea730bf29ec41efb792b4e7266880b051d35f31c1ccc6160abbd14fa2cded1", kill_on_drop: false }` [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking futures v0.1.25 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking slab v0.4.1 [INFO] [stderr] Checking lazycell v1.2.0 [INFO] [stderr] Checking crossbeam-utils v0.5.0 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking lazy_static v0.2.4 [INFO] [stderr] Checking bit-vec v0.4.3 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking unreachable v0.1.1 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Checking regex-syntax v0.4.0 [INFO] [stderr] Checking portmidi v0.2.4 [INFO] [stderr] Checking midi-message v0.1.0 (https://github.com/shybyte/midi-message-rs#cda61b2d) [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Checking smallvec v0.6.6 [INFO] [stderr] Checking bit-set v0.4.0 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking inotify-sys v0.1.3 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking chan v0.1.23 [INFO] [stderr] Checking chan-signal v0.3.2 [INFO] [stderr] Checking tokio-executor v0.1.5 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking midi2opc v0.1.0 (https://github.com/shybyte/midi2opc#825f0ab0) [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking risp v0.7.0 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking notify v4.0.6 [INFO] [stderr] Checking rust_midi_patcher v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:37:62 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 37 - pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] 37 + pub fn new_simple>(name: S, effects: Vec>, program: u8) -> Patch { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | (midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - (midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0)) [INFO] [stdout] 94 + midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | (midi_message.status == 0x80) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 98 - (midi_message.status == 0x80) [INFO] [stdout] 98 + midi_message.status == 0x80 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | (midi_message.status == 0xB0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 102 - (midi_message.status == 0xB0) [INFO] [stdout] 102 + midi_message.status == 0xB0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::effects::sweep_down::SweepDown` [INFO] [stdout] --> src/songs/endstation_paradies.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use crate::effects::sweep_down::SweepDown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::Boxable` [INFO] [stdout] --> src/songs/endstation_paradies.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use crate::utils::Boxable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::microkorg::VOLUME` [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use crate::microkorg::VOLUME; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:37:62 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 37 - pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] 37 + pub fn new_simple>(name: S, effects: Vec>, program: u8) -> Patch { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | (midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - (midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0)) [INFO] [stdout] 94 + midi_message.status == 0x90 || (midi_message.status == 0x99 && midi_message.data2 > 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | (midi_message.status == 0x80) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 98 - (midi_message.status == 0x80) [INFO] [stdout] 98 + midi_message.status == 0x80 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils/mod.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | (midi_message.status == 0xB0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 102 - (midi_message.status == 0xB0) [INFO] [stdout] 102 + midi_message.status == 0xB0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::effects::sweep_down::SweepDown` [INFO] [stdout] --> src/songs/endstation_paradies.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use crate::effects::sweep_down::SweepDown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::Boxable` [INFO] [stdout] --> src/songs/endstation_paradies.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use crate::utils::Boxable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::microkorg::VOLUME` [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use crate::microkorg::VOLUME; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:15:37 [INFO] [stdout] | [INFO] [stdout] 15 | effects: Vec<(Box, Box)>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | effects: Vec<(Box, Box)>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:24:74 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new>(name: S, effects: Vec<(Box, Box)>, program: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new>(name: S, effects: Vec<(Box, Box)>, program: u8, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:37:67 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:15:37 [INFO] [stdout] | [INFO] [stdout] 15 | effects: Vec<(Box, Box)>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | effects: Vec<(Box, Box)>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:24:74 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new>(name: S, effects: Vec<(Box, Box)>, program: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new>(name: S, effects: Vec<(Box, Box)>, program: u8, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/patch.rs:37:67 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/load_patches.rs:110:119 [INFO] [stdout] | [INFO] [stdout] 110 | fn to_trigger_effect_pair(input: &RispType, default_time_per_note: i64, config: &Config) -> Result<(Box, Box), RispError> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 110 | fn to_trigger_effect_pair(input: &RispType, default_time_per_note: i64, config: &Config) -> Result<(Box, Box), RispError> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/load_patches.rs:110:119 [INFO] [stdout] | [INFO] [stdout] 110 | fn to_trigger_effect_pair(input: &RispType, default_time_per_note: i64, config: &Config) -> Result<(Box, Box), RispError> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 110 | fn to_trigger_effect_pair(input: &RispType, default_time_per_note: i64, config: &Config) -> Result<(Box, Box), RispError> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `BASE_NOTE` is never used [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | static BASE_NOTE: &str = "BASE_NOTE"; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `liebt_uns2` is never used [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn liebt_uns2(_config2: &Config) -> Patch { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patch.rs:40:22 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | ------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | effects: effects.into_iter().map(|e| (Box::new(Trigger::never()), e)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patch.rs:40:51 [INFO] [stdout] | [INFO] [stdout] 40 | effects: effects.into_iter().map(|e| (Box::new(Trigger::never()), e)).collect(), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/carla_starter.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new>(carla_path: S) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | child_process: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/load_patches.rs:90:16 [INFO] [stdout] | [INFO] [stdout] 88 | let effects: Result<_, _> = effects_risp.into_iter().map(|e| to_trigger_effect_pair(&e, time_per_note, config)).collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let lights_patch: Option = patch_risp.get("lights")?.map(|l| to_lights(&l)); [INFO] [stdout] 90 | Ok(Patch::new(name, effects?, program as u8, lights_patch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn concat(input: Vec>) -> Vec { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | input.into_iter().flat_map(|x| x).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watch.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn get_changed_files(events: T) -> Vec where [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | / events.filter_map(|event| match event{ [INFO] [stdout] 18 | | DebouncedEvent::Create(path_buf) => Some(path_buf), [INFO] [stdout] 19 | | _ => None [INFO] [stdout] 20 | | }).collect() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_midi.rs:28:74 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(context: &PortMidi, loopback_tx: Sender<(String, MidiMessage)>) -> VirtualMidiOutput { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let output_ports: Vec = context.devices().unwrap().into_iter() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let midi_light_strip = MidiLightStrip::start(MidiLightConfig { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | VirtualMidiOutput { output_ports, loopback_tx, midi_light_strip: midi_light_strip.ok() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_midi.rs:21:24 [INFO] [stdout] | [INFO] [stdout] 21 | .map(|dev| context.output_port(dev, BUF_LEN).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_midi_patcher` (bin "rust_midi_patcher") due to 9 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: static `BASE_NOTE` is never used [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | static BASE_NOTE: &str = "BASE_NOTE"; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `liebt_uns2` is never used [INFO] [stdout] --> src/songs/endstation/liebt_uns.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn liebt_uns2(_config2: &Config) -> Patch { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patch.rs:40:22 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new_simple>(name: S, effects: Vec<(Box)>, program: u8) -> Patch { [INFO] [stdout] | ------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | effects: effects.into_iter().map(|e| (Box::new(Trigger::never()), e)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patch.rs:40:51 [INFO] [stdout] | [INFO] [stdout] 40 | effects: effects.into_iter().map(|e| (Box::new(Trigger::never()), e)).collect(), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/carla_starter.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new>(carla_path: S) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | child_process: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/load_patches.rs:90:16 [INFO] [stdout] | [INFO] [stdout] 88 | let effects: Result<_, _> = effects_risp.into_iter().map(|e| to_trigger_effect_pair(&e, time_per_note, config)).collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let lights_patch: Option = patch_risp.get("lights")?.map(|l| to_lights(&l)); [INFO] [stdout] 90 | Ok(Patch::new(name, effects?, program as u8, lights_patch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/absolute_sleep.rs:45:46 [INFO] [stdout] | [INFO] [stdout] 45 | assert!(sleep_time.abs() < 1000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 45 - assert!(sleep_time.abs() < 1000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] 45 + assert!(sleep_time.abs() < 1000_000, "sleep right time {}", sleep_time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/absolute_sleep.rs:55:46 [INFO] [stdout] | [INFO] [stdout] 55 | assert!(sleep_time.abs() < 1000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 55 - assert!(sleep_time.abs() < 1000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] 55 + assert!(sleep_time.abs() < 1000_000, "sleep right time {}", sleep_time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/absolute_sleep.rs:65:46 [INFO] [stdout] | [INFO] [stdout] 65 | assert!(sleep_time.abs() < 2000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 65 - assert!(sleep_time.abs() < 2000_000, format!("sleep right time {}", sleep_time)); [INFO] [stdout] 65 + assert!(sleep_time.abs() < 2000_000, "sleep right time {}", sleep_time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn concat(input: Vec>) -> Vec { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | input.into_iter().flat_map(|x| x).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watch.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn get_changed_files(events: T) -> Vec where [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | / events.filter_map(|event| match event{ [INFO] [stdout] 18 | | DebouncedEvent::Create(path_buf) => Some(path_buf), [INFO] [stdout] 19 | | _ => None [INFO] [stdout] 20 | | }).collect() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_midi.rs:28:74 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(context: &PortMidi, loopback_tx: Sender<(String, MidiMessage)>) -> VirtualMidiOutput { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let output_ports: Vec = context.devices().unwrap().into_iter() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let midi_light_strip = MidiLightStrip::start(MidiLightConfig { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | VirtualMidiOutput { output_ports, loopback_tx, midi_light_strip: midi_light_strip.ok() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/virtual_midi.rs:21:24 [INFO] [stdout] | [INFO] [stdout] 21 | .map(|dev| context.output_port(dev, BUF_LEN).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_midi_patcher` (bin "rust_midi_patcher" test) due to 9 previous errors; 16 warnings emitted [INFO] running `Command { std: "docker" "inspect" "67ea730bf29ec41efb792b4e7266880b051d35f31c1ccc6160abbd14fa2cded1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67ea730bf29ec41efb792b4e7266880b051d35f31c1ccc6160abbd14fa2cded1", kill_on_drop: false }` [INFO] [stdout] 67ea730bf29ec41efb792b4e7266880b051d35f31c1ccc6160abbd14fa2cded1