[INFO] cloning repository https://github.com/shadyfennec/moongbc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/shadyfennec/moongbc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshadyfennec%2Fmoongbc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshadyfennec%2Fmoongbc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ec23e6d9463332332243f98ebfa8304b3dba8340 [INFO] checking shadyfennec/moongbc against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshadyfennec%2Fmoongbc" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/shadyfennec/moongbc on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/shadyfennec/moongbc [INFO] finished tweaking git repo https://github.com/shadyfennec/moongbc [INFO] tweaked toml for git repo https://github.com/shadyfennec/moongbc written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/shadyfennec/moongbc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded crossterm v0.17.6 [INFO] [stderr] Downloaded signal-hook v0.1.16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 746492e31897fcc6d51dfef8ece823dc425dfdffe1c1f24e324c42f0778405d0 [INFO] running `Command { std: "docker" "start" "-a" "746492e31897fcc6d51dfef8ece823dc425dfdffe1c1f24e324c42f0778405d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "746492e31897fcc6d51dfef8ece823dc425dfdffe1c1f24e324c42f0778405d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "746492e31897fcc6d51dfef8ece823dc425dfdffe1c1f24e324c42f0778405d0", kill_on_drop: false }` [INFO] [stdout] 746492e31897fcc6d51dfef8ece823dc425dfdffe1c1f24e324c42f0778405d0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5f4e9d9939eab27c5dce02029e0c41991c9e0cd7ae7ca4cd87049e38ece472e [INFO] running `Command { std: "docker" "start" "-a" "c5f4e9d9939eab27c5dce02029e0c41991c9e0cd7ae7ca4cd87049e38ece472e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.72 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking smallvec v1.4.1 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.6.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking mio v0.7.0 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking signal-hook v0.1.16 [INFO] [stderr] Checking crossterm v0.17.6 [INFO] [stderr] Checking tui v0.9.5 [INFO] [stderr] Checking moongbc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `sgb_flag` is never read [INFO] [stdout] --> src/core/cartridge.rs:426:16 [INFO] [stdout] | [INFO] [stdout] 425 | pub struct Cartridge { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 426 | pub(crate) sgb_flag: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/core/cartridge.rs:456:25 [INFO] [stdout] | [INFO] [stdout] 456 | _ => panic!(format!("Unsupported MBC: {:?}", cartridge_type)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 456 - _ => panic!(format!("Unsupported MBC: {:?}", cartridge_type)), [INFO] [stdout] 456 + _ => panic!("Unsupported MBC: {:?}", cartridge_type), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sgb_flag` is never read [INFO] [stdout] --> src/core/cartridge.rs:426:16 [INFO] [stdout] | [INFO] [stdout] 425 | pub struct Cartridge { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 426 | pub(crate) sgb_flag: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/core/cartridge.rs:456:25 [INFO] [stdout] | [INFO] [stdout] 456 | _ => panic!(format!("Unsupported MBC: {:?}", cartridge_type)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 456 - _ => panic!(format!("Unsupported MBC: {:?}", cartridge_type)), [INFO] [stdout] 456 + _ => panic!("Unsupported MBC: {:?}", cartridge_type), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.05s [INFO] running `Command { std: "docker" "inspect" "c5f4e9d9939eab27c5dce02029e0c41991c9e0cd7ae7ca4cd87049e38ece472e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5f4e9d9939eab27c5dce02029e0c41991c9e0cd7ae7ca4cd87049e38ece472e", kill_on_drop: false }` [INFO] [stdout] c5f4e9d9939eab27c5dce02029e0c41991c9e0cd7ae7ca4cd87049e38ece472e [INFO] checking shadyfennec/moongbc against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshadyfennec%2Fmoongbc" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/shadyfennec/moongbc on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/shadyfennec/moongbc [INFO] finished tweaking git repo https://github.com/shadyfennec/moongbc [INFO] tweaked toml for git repo https://github.com/shadyfennec/moongbc written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/shadyfennec/moongbc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 14d10790beaef8fcf0ce675d1a642cad52ebb62e805cb81c485cc5d61a21767d [INFO] running `Command { std: "docker" "start" "-a" "14d10790beaef8fcf0ce675d1a642cad52ebb62e805cb81c485cc5d61a21767d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "14d10790beaef8fcf0ce675d1a642cad52ebb62e805cb81c485cc5d61a21767d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14d10790beaef8fcf0ce675d1a642cad52ebb62e805cb81c485cc5d61a21767d", kill_on_drop: false }` [INFO] [stdout] 14d10790beaef8fcf0ce675d1a642cad52ebb62e805cb81c485cc5d61a21767d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0149f7bd8aa3d1523b764e1f8ede58fc38dbc6316e6b8da837375bd0597776d7 [INFO] running `Command { std: "docker" "start" "-a" "0149f7bd8aa3d1523b764e1f8ede58fc38dbc6316e6b8da837375bd0597776d7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.72 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking smallvec v1.4.1 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking unicode-segmentation v1.6.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking mio v0.7.0 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking signal-hook v0.1.16 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking crossterm v0.17.6 [INFO] [stderr] Checking tui v0.9.5 [INFO] [stderr] Checking moongbc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `sgb_flag` is never read [INFO] [stdout] --> src/core/cartridge.rs:426:16 [INFO] [stdout] | [INFO] [stdout] 425 | pub struct Cartridge { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 426 | pub(crate) sgb_flag: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/cartridge.rs:470:12 [INFO] [stdout] | [INFO] [stdout] 434 | pub fn load>(path: P) -> std::io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 435 | let mut file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | let mbc: Box = match cartridge_type { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | Ok(Cartridge { [INFO] [stdout] | ____________^ [INFO] [stdout] 471 | | sgb_flag, [INFO] [stdout] 472 | | mbc, [INFO] [stdout] 473 | | rom, [INFO] [stdout] 474 | | ram, [INFO] [stdout] 475 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/core/cartridge.rs:456:25 [INFO] [stdout] | [INFO] [stdout] 456 | _ => panic!(format!("Unsupported MBC: {:?}", cartridge_type)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 456 - _ => panic!(format!("Unsupported MBC: {:?}", cartridge_type)), [INFO] [stdout] 456 + _ => panic!("Unsupported MBC: {:?}", cartridge_type), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/cpu.rs:205:28 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn set_cartridge>(&mut self, path: P) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | self.memory_map [INFO] [stdout] 205 | .set_cartridge(Cartridge::load(path).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/util.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 88 | fn add(&self, cpu: &mut CPU, inc: T) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | self.write(cpu, self.read(cpu) + inc) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/util.rs:102:29 [INFO] [stdout] | [INFO] [stdout] 97 | fn try_add(&self, cpu: &mut CPU, inc: T) -> RWResult<()> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | self.try_write(cpu, self.read(cpu) + inc) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/util.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 106 | fn sub(&self, cpu: &mut CPU, dec: T) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | self.write(cpu, self.read(cpu) - dec) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/util.rs:120:29 [INFO] [stdout] | [INFO] [stdout] 115 | fn try_sub(&self, cpu: &mut CPU, dec: T) -> RWResult<()> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | self.try_write(cpu, self.read(cpu) - dec) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debug/debugger.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(cpu: CPU) -> Debugger { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | widgets: WidgetList::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moongbc` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `sgb_flag` is never read [INFO] [stdout] --> src/core/cartridge.rs:426:16 [INFO] [stdout] | [INFO] [stdout] 425 | pub struct Cartridge { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 426 | pub(crate) sgb_flag: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/cartridge.rs:470:12 [INFO] [stdout] | [INFO] [stdout] 434 | pub fn load>(path: P) -> std::io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 435 | let mut file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | let mbc: Box = match cartridge_type { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | Ok(Cartridge { [INFO] [stdout] | ____________^ [INFO] [stdout] 471 | | sgb_flag, [INFO] [stdout] 472 | | mbc, [INFO] [stdout] 473 | | rom, [INFO] [stdout] 474 | | ram, [INFO] [stdout] 475 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/core/cartridge.rs:456:25 [INFO] [stdout] | [INFO] [stdout] 456 | _ => panic!(format!("Unsupported MBC: {:?}", cartridge_type)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 456 - _ => panic!(format!("Unsupported MBC: {:?}", cartridge_type)), [INFO] [stdout] 456 + _ => panic!("Unsupported MBC: {:?}", cartridge_type), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/cpu.rs:205:28 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn set_cartridge>(&mut self, path: P) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | self.memory_map [INFO] [stdout] 205 | .set_cartridge(Cartridge::load(path).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/util.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 88 | fn add(&self, cpu: &mut CPU, inc: T) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | self.write(cpu, self.read(cpu) + inc) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/util.rs:102:29 [INFO] [stdout] | [INFO] [stdout] 97 | fn try_add(&self, cpu: &mut CPU, inc: T) -> RWResult<()> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | self.try_write(cpu, self.read(cpu) + inc) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/util.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 106 | fn sub(&self, cpu: &mut CPU, dec: T) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | self.write(cpu, self.read(cpu) - dec) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/util.rs:120:29 [INFO] [stdout] | [INFO] [stdout] 115 | fn try_sub(&self, cpu: &mut CPU, dec: T) -> RWResult<()> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | self.try_write(cpu, self.read(cpu) - dec) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debug/debugger.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(cpu: CPU) -> Debugger { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | widgets: WidgetList::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `moongbc` (lib) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0149f7bd8aa3d1523b764e1f8ede58fc38dbc6316e6b8da837375bd0597776d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0149f7bd8aa3d1523b764e1f8ede58fc38dbc6316e6b8da837375bd0597776d7", kill_on_drop: false }` [INFO] [stdout] 0149f7bd8aa3d1523b764e1f8ede58fc38dbc6316e6b8da837375bd0597776d7