[INFO] cloning repository https://github.com/sebasmagri/rust-concurrency-patterns [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sebasmagri/rust-concurrency-patterns" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsebasmagri%2Frust-concurrency-patterns", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsebasmagri%2Frust-concurrency-patterns'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c916fe831faec73a7fb5d652e91fa9da528d85c4 [INFO] checking sebasmagri/rust-concurrency-patterns against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsebasmagri%2Frust-concurrency-patterns" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/sebasmagri/rust-concurrency-patterns on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/sebasmagri/rust-concurrency-patterns [INFO] finished tweaking git repo https://github.com/sebasmagri/rust-concurrency-patterns [INFO] tweaked toml for git repo https://github.com/sebasmagri/rust-concurrency-patterns written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/sebasmagri/rust-concurrency-patterns already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 747190402a763162bce55ccf9edb06a6dadb15128ff36c7768503c2c6df262cd [INFO] running `Command { std: "docker" "start" "-a" "747190402a763162bce55ccf9edb06a6dadb15128ff36c7768503c2c6df262cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "747190402a763162bce55ccf9edb06a6dadb15128ff36c7768503c2c6df262cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "747190402a763162bce55ccf9edb06a6dadb15128ff36c7768503c2c6df262cd", kill_on_drop: false }` [INFO] [stdout] 747190402a763162bce55ccf9edb06a6dadb15128ff36c7768503c2c6df262cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 45c41940d16cd22a453f1c0d6c50b223565ea0feb327e197221120db87131220 [INFO] running `Command { std: "docker" "start" "-a" "45c41940d16cd22a453f1c0d6c50b223565ea0feb327e197221120db87131220", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking concurrency-patterns v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> examples/04-fan-in.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | consumer(Arc::new(Mutex::new(rx))).join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 32 | let _ = consumer(Arc::new(Mutex::new(rx))).join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.10s [INFO] running `Command { std: "docker" "inspect" "45c41940d16cd22a453f1c0d6c50b223565ea0feb327e197221120db87131220", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45c41940d16cd22a453f1c0d6c50b223565ea0feb327e197221120db87131220", kill_on_drop: false }` [INFO] [stdout] 45c41940d16cd22a453f1c0d6c50b223565ea0feb327e197221120db87131220 [INFO] checking sebasmagri/rust-concurrency-patterns against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsebasmagri%2Frust-concurrency-patterns" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/sebasmagri/rust-concurrency-patterns on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/sebasmagri/rust-concurrency-patterns [INFO] finished tweaking git repo https://github.com/sebasmagri/rust-concurrency-patterns [INFO] tweaked toml for git repo https://github.com/sebasmagri/rust-concurrency-patterns written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/sebasmagri/rust-concurrency-patterns already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31a70fce3bd4622e1c2844567a2c1d4b1f22d466aff0683d7653d56652ff6228 [INFO] running `Command { std: "docker" "start" "-a" "31a70fce3bd4622e1c2844567a2c1d4b1f22d466aff0683d7653d56652ff6228", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31a70fce3bd4622e1c2844567a2c1d4b1f22d466aff0683d7653d56652ff6228", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31a70fce3bd4622e1c2844567a2c1d4b1f22d466aff0683d7653d56652ff6228", kill_on_drop: false }` [INFO] [stdout] 31a70fce3bd4622e1c2844567a2c1d4b1f22d466aff0683d7653d56652ff6228 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e57c392ddc9d68963d9cf4f5798b7fac60adfa2d525f703d1d997ff8403174e [INFO] running `Command { std: "docker" "start" "-a" "6e57c392ddc9d68963d9cf4f5798b7fac60adfa2d525f703d1d997ff8403174e", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking concurrency-patterns v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/03-ping-pong.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 14 | racket: mpsc::Sender>, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | table: Arc>>>) [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 19 | | // Player is alive in its loop [INFO] [stdout] 20 | | println!("Player {}: ready...", id); [INFO] [stdout] 21 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/04-fan-in.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 17 | fn consumer(rx: Arc>>) -> thread::JoinHandle<()> { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 19 | | for v in rx.lock().unwrap().iter() { [INFO] [stdout] 20 | | println!("consumer got: {}", v); [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `concurrency-patterns` (example "03-ping-pong") due to 2 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/05-workers.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 10 | fn producer(tx: mpsc::SyncSender) -> thread::JoinHandle<()> { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | // lets use bigger numbers to be able to perceive the amount of work [INFO] [stdout] 12 | thread::spawn(move || for i in 100_000_000.. { [INFO] [stdout] | ___________________^ [INFO] [stdout] 13 | | tx.send(i).unwrap(); [INFO] [stdout] 14 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> examples/04-fan-in.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | consumer(Arc::new(Mutex::new(rx))).join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 32 | let _ = consumer(Arc::new(Mutex::new(rx))).join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `concurrency-patterns` (example "05-workers") due to 2 previous errors [INFO] [stderr] error: could not compile `concurrency-patterns` (example "04-fan-in") due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "6e57c392ddc9d68963d9cf4f5798b7fac60adfa2d525f703d1d997ff8403174e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e57c392ddc9d68963d9cf4f5798b7fac60adfa2d525f703d1d997ff8403174e", kill_on_drop: false }` [INFO] [stdout] 6e57c392ddc9d68963d9cf4f5798b7fac60adfa2d525f703d1d997ff8403174e