[INFO] cloning repository https://github.com/pwang697/OmniSpacetimeDB [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pwang697/OmniSpacetimeDB" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpwang697%2FOmniSpacetimeDB", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpwang697%2FOmniSpacetimeDB'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3803bcd0a5ffa2da7ccf992caa72688a6518e7ef [INFO] checking pwang697/OmniSpacetimeDB against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpwang697%2FOmniSpacetimeDB" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/pwang697/OmniSpacetimeDB on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/pwang697/OmniSpacetimeDB [INFO] finished tweaking git repo https://github.com/pwang697/OmniSpacetimeDB [INFO] tweaked toml for git repo https://github.com/pwang697/OmniSpacetimeDB written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/pwang697/OmniSpacetimeDB already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded omnipaxos v0.2.2 [INFO] [stderr] Downloaded crc32c v0.6.5 [INFO] [stderr] Downloaded commitlog v0.2.0 [INFO] [stderr] Downloaded omnipaxos_storage v0.2.2 [INFO] [stderr] Downloaded hermit-abi v0.3.5 [INFO] [stderr] Downloaded omnipaxos_macros v0.1.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 329006b8f7aba5184bfd3f69bee1faf44dc2fbdf78384fd8a5c803a9abcabc07 [INFO] running `Command { std: "docker" "start" "-a" "329006b8f7aba5184bfd3f69bee1faf44dc2fbdf78384fd8a5c803a9abcabc07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "329006b8f7aba5184bfd3f69bee1faf44dc2fbdf78384fd8a5c803a9abcabc07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "329006b8f7aba5184bfd3f69bee1faf44dc2fbdf78384fd8a5c803a9abcabc07", kill_on_drop: false }` [INFO] [stdout] 329006b8f7aba5184bfd3f69bee1faf44dc2fbdf78384fd8a5c803a9abcabc07 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 995f1716a877e1476a8ca3805a40186ad45da8b911de7f7d2a2f3a4ca1ce22ad [INFO] running `Command { std: "docker" "start" "-a" "995f1716a877e1476a8ca3805a40186ad45da8b911de7f7d2a2f3a4ca1ce22ad", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling crc32c v0.6.5 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking page_size v0.4.2 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking commitlog v0.2.0 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling zerocopy-derive v0.6.6 [INFO] [stderr] Compiling omnipaxos_macros v0.1.3 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking zerocopy v0.6.6 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking omnipaxos v0.2.2 [INFO] [stderr] Checking omnipaxos_storage v0.2.2 [INFO] [stderr] Checking omni-spacetimedb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/durability/mod.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct ObserverId(u64); [INFO] [stdout] | ---------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ObserverId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update_connection` is never used [INFO] [stdout] --> src/node/mod.rs:207:8 [INFO] [stdout] | [INFO] [stdout] 80 | impl Node { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 207 | fn update_connection(&mut self, connection: HashSet) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/durability/mod.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct ObserverId(u64); [INFO] [stdout] | ---------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ObserverId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.11s [INFO] running `Command { std: "docker" "inspect" "995f1716a877e1476a8ca3805a40186ad45da8b911de7f7d2a2f3a4ca1ce22ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "995f1716a877e1476a8ca3805a40186ad45da8b911de7f7d2a2f3a4ca1ce22ad", kill_on_drop: false }` [INFO] [stdout] 995f1716a877e1476a8ca3805a40186ad45da8b911de7f7d2a2f3a4ca1ce22ad [INFO] checking pwang697/OmniSpacetimeDB against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpwang697%2FOmniSpacetimeDB" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/pwang697/OmniSpacetimeDB on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/pwang697/OmniSpacetimeDB [INFO] finished tweaking git repo https://github.com/pwang697/OmniSpacetimeDB [INFO] tweaked toml for git repo https://github.com/pwang697/OmniSpacetimeDB written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/pwang697/OmniSpacetimeDB already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] af190560ac79755800fea7d6c34bb3dcdff4310743cb48eaa3adacb792222e89 [INFO] running `Command { std: "docker" "start" "-a" "af190560ac79755800fea7d6c34bb3dcdff4310743cb48eaa3adacb792222e89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "af190560ac79755800fea7d6c34bb3dcdff4310743cb48eaa3adacb792222e89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af190560ac79755800fea7d6c34bb3dcdff4310743cb48eaa3adacb792222e89", kill_on_drop: false }` [INFO] [stdout] af190560ac79755800fea7d6c34bb3dcdff4310743cb48eaa3adacb792222e89 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9425fc40975dcf43dcafba60c195fcea224b8a122b16a513a7fa7ea5b7d636ea [INFO] running `Command { std: "docker" "start" "-a" "9425fc40975dcf43dcafba60c195fcea224b8a122b16a513a7fa7ea5b7d636ea", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling crc32c v0.6.5 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking page_size v0.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking commitlog v0.2.0 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling omnipaxos_macros v0.1.3 [INFO] [stderr] Compiling zerocopy-derive v0.6.6 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking zerocopy v0.6.6 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking omnipaxos v0.2.2 [INFO] [stderr] Checking omnipaxos_storage v0.2.2 [INFO] [stderr] Checking omni-spacetimedb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/durability/mod.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct ObserverId(u64); [INFO] [stdout] | ---------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ObserverId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update_connection` is never used [INFO] [stdout] --> src/node/mod.rs:207:8 [INFO] [stdout] | [INFO] [stdout] 80 | impl Node { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 207 | fn update_connection(&mut self, connection: HashSet) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 240 | mut tx: Self::MutTx, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | let tx_data = TxData { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | Ok(TxResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 282 | | tx_offset: offset, [INFO] [stdout] 283 | | tx_data, [INFO] [stdout] 284 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:268:38 [INFO] [stdout] | [INFO] [stdout] 268 | .map(|s| RowData(Arc::from(serialize_example_row(s).unwrap()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:275:38 [INFO] [stdout] | [INFO] [stdout] 275 | .map(|s| RowData(Arc::from(s.as_bytes()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(RowData(Arc::from(buffer.into_boxed_slice()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 71 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(InsertList { [INFO] [stdout] | ________^ [INFO] [stdout] 76 | | table_id, [INFO] [stdout] 77 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 95 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(DeleteList { [INFO] [stdout] | ________^ [INFO] [stdout] 100 | | table_id, [INFO] [stdout] 101 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 133 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(TxData { [INFO] [stdout] | ____________^ [INFO] [stdout] 153 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 154 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 155 | | truncs: Arc::from(truncs.into_boxed_slice()), [INFO] [stdout] 156 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | let tx_data = TxData::deserialize(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(LogEntry { tx_offset, tx_data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 145 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | Box::new(std::iter::from_fn(move || { [INFO] [stdout] | __________________^ [INFO] [stdout] 149 | | match LogEntry::deserialize(&mut file) { [INFO] [stdout] 150 | | Ok(log_entry) => Some((log_entry.tx_offset, log_entry.tx_data)), [INFO] [stdout] 151 | | Err(_) => None, [INFO] [stdout] 152 | | } [INFO] [stdout] 153 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:149:19 [INFO] [stdout] | [INFO] [stdout] 145 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | match LogEntry::deserialize(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:85:24 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(node_id: NodeId, omni_durability: OmniPaxosDurability, connection: HashSet) -> Self { [INFO] [stdout] | ------------------------------------ --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | datastore: ExampleDatastore::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `omni-spacetimedb` (bin "omni-spacetimedb") due to 12 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/durability/mod.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct ObserverId(u64); [INFO] [stdout] | ---------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ObserverId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 240 | mut tx: Self::MutTx, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | let tx_data = TxData { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | Ok(TxResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 282 | | tx_offset: offset, [INFO] [stdout] 283 | | tx_data, [INFO] [stdout] 284 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:268:38 [INFO] [stdout] | [INFO] [stdout] 268 | .map(|s| RowData(Arc::from(serialize_example_row(s).unwrap()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:275:38 [INFO] [stdout] | [INFO] [stdout] 275 | .map(|s| RowData(Arc::from(s.as_bytes()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(RowData(Arc::from(buffer.into_boxed_slice()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 71 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(InsertList { [INFO] [stdout] | ________^ [INFO] [stdout] 76 | | table_id, [INFO] [stdout] 77 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 95 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(DeleteList { [INFO] [stdout] | ________^ [INFO] [stdout] 100 | | table_id, [INFO] [stdout] 101 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 133 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(TxData { [INFO] [stdout] | ____________^ [INFO] [stdout] 153 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 154 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 155 | | truncs: Arc::from(truncs.into_boxed_slice()), [INFO] [stdout] 156 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | let tx_data = TxData::deserialize(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(LogEntry { tx_offset, tx_data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 145 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | Box::new(std::iter::from_fn(move || { [INFO] [stdout] | __________________^ [INFO] [stdout] 149 | | match LogEntry::deserialize(&mut file) { [INFO] [stdout] 150 | | Ok(log_entry) => Some((log_entry.tx_offset, log_entry.tx_data)), [INFO] [stdout] 151 | | Err(_) => None, [INFO] [stdout] 152 | | } [INFO] [stdout] 153 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:149:19 [INFO] [stdout] | [INFO] [stdout] 145 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | match LogEntry::deserialize(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:85:24 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(node_id: NodeId, omni_durability: OmniPaxosDurability, connection: HashSet) -> Self { [INFO] [stdout] | ------------------------------------ --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | datastore: ExampleDatastore::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `omni-spacetimedb` (bin "omni-spacetimedb" test) due to 12 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9425fc40975dcf43dcafba60c195fcea224b8a122b16a513a7fa7ea5b7d636ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9425fc40975dcf43dcafba60c195fcea224b8a122b16a513a7fa7ea5b7d636ea", kill_on_drop: false }` [INFO] [stdout] 9425fc40975dcf43dcafba60c195fcea224b8a122b16a513a7fa7ea5b7d636ea