[INFO] cloning repository https://github.com/pontuslaestadius/ftp-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pontuslaestadius/ftp-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpontuslaestadius%2Fftp-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpontuslaestadius%2Fftp-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 10ae254549c0d4c88f0f4e7c91e132405818891b [INFO] checking pontuslaestadius/ftp-rust against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpontuslaestadius%2Fftp-rust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/pontuslaestadius/ftp-rust on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/pontuslaestadius/ftp-rust [INFO] finished tweaking git repo https://github.com/pontuslaestadius/ftp-rust [INFO] tweaked toml for git repo https://github.com/pontuslaestadius/ftp-rust written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/pontuslaestadius/ftp-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5efa65171f9a9f960e7bb4630e8645988eec03cd6808750e54c34bfa714f3aa [INFO] running `Command { std: "docker" "start" "-a" "c5efa65171f9a9f960e7bb4630e8645988eec03cd6808750e54c34bfa714f3aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5efa65171f9a9f960e7bb4630e8645988eec03cd6808750e54c34bfa714f3aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5efa65171f9a9f960e7bb4630e8645988eec03cd6808750e54c34bfa714f3aa", kill_on_drop: false }` [INFO] [stdout] c5efa65171f9a9f960e7bb4630e8645988eec03cd6808750e54c34bfa714f3aa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87d53ab082d1e425ad31ba4dd9b071c69d7b82375e4ed2aabc8ede1cea24ba0e [INFO] running `Command { std: "docker" "start" "-a" "87d53ab082d1e425ad31ba4dd9b071c69d7b82375e4ed2aabc8ede1cea24ba0e", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking ftp-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/ftp/mod.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `File` and `OpenOptions` [INFO] [stdout] --> src/ftp/server/mod.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/ftp/server/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/decode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/decode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/encode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/encode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/ftp/mod.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `File` and `OpenOptions` [INFO] [stdout] --> src/ftp/server/mod.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/ftp/server/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/decode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/decode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/encode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/encode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/ftp/server/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut stream = stream.unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/ftp/server/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `string` [INFO] [stdout] --> src/ftp/server/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_string` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/ftp/server/mod.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | let mut c: usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stream` [INFO] [stdout] --> src/ftp/server/mod.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | fn notify_client_err(stream: &mut TcpStream, error: io::Error) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/client/mod.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn start(address: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `client` [INFO] [stdout] --> src/ftp/client/mod.rs:30:26 [INFO] [stdout] | [INFO] [stdout] 30 | let (mut stream, client) = super::client::new(self.address)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_client` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/client/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let mut stream = super::connect(address)?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_size` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let mut decoded_size: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_size` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_pktn` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut decoded_pktn: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_pktn` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_size` is never read [INFO] [stdout] --> src/ftp/decode.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | "size" => decoded_size = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_pktn` is never read [INFO] [stdout] --> src/ftp/decode.rs:41:27 [INFO] [stdout] | [INFO] [stdout] 41 | "pktn" => decoded_pktn = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut stream = stream.unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/decode.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut rows = section2.next().unwrap().split(';'); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `string` [INFO] [stdout] --> src/ftp/server/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_string` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/ftp/server/mod.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | let mut c: usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/ftp/encode.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | let size = content.len(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stream` [INFO] [stdout] --> src/ftp/server/mod.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | fn notify_client_err(stream: &mut TcpStream, error: io::Error) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/encode.rs:24:53 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_meta_data(metadata: metadata::Metadata, mut content: &mut String) -> Result, io::Error> { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/client/mod.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn start(address: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut f = OpenOptions::new() [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/mod.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/ftp/mod.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `client` [INFO] [stdout] --> src/ftp/client/mod.rs:30:26 [INFO] [stdout] | [INFO] [stdout] 30 | let (mut stream, client) = super::client::new(self.address)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_client` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/client/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let mut stream = super::connect(address)?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_size` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let mut decoded_size: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_size` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_pktn` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut decoded_pktn: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_pktn` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | let mut files = "examples/files/foo.txt"; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_size` is never read [INFO] [stdout] --> src/ftp/decode.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | "size" => decoded_size = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_pktn` is never read [INFO] [stdout] --> src/ftp/decode.rs:41:27 [INFO] [stdout] | [INFO] [stdout] 41 | "pktn" => decoded_pktn = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/decode.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut rows = section2.next().unwrap().split(';'); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/client/mod.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | self.action(input.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 25 | let _ = self.action(input.as_str()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/encode.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | file.read_to_string(&mut content); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 11 | let _ = file.read_to_string(&mut content); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/ftp/encode.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | let size = content.len(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/encode.rs:24:53 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_meta_data(metadata: metadata::Metadata, mut content: &mut String) -> Result, io::Error> { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut f = OpenOptions::new() [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/mod.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/ftp/mod.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | let mut files = "examples/files/foo.txt"; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 29 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/client/mod.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | self.action(input.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 25 | let _ = self.action(input.as_str()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/encode.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | file.read_to_string(&mut content); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 11 | let _ = file.read_to_string(&mut content); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 29 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/ftp/mod.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `File` and `OpenOptions` [INFO] [stdout] --> src/ftp/server/mod.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/ftp/server/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/decode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/decode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/encode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/encode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/ftp/mod.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `File` and `OpenOptions` [INFO] [stdout] --> src/ftp/server/mod.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/ftp/server/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/decode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/decode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/encode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/encode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/ftp/server/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut stream = stream.unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `string` [INFO] [stdout] --> src/ftp/server/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_string` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/ftp/server/mod.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | let mut c: usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stream` [INFO] [stdout] --> src/ftp/server/mod.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | fn notify_client_err(stream: &mut TcpStream, error: io::Error) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/client/mod.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn start(address: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `client` [INFO] [stdout] --> src/ftp/client/mod.rs:30:26 [INFO] [stdout] | [INFO] [stdout] 30 | let (mut stream, client) = super::client::new(self.address)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_client` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/client/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let mut stream = super::connect(address)?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_size` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let mut decoded_size: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_size` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_pktn` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut decoded_pktn: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_pktn` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_size` is never read [INFO] [stdout] --> src/ftp/decode.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | "size" => decoded_size = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_pktn` is never read [INFO] [stdout] --> src/ftp/decode.rs:41:27 [INFO] [stdout] | [INFO] [stdout] 41 | "pktn" => decoded_pktn = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/decode.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut rows = section2.next().unwrap().split(';'); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/ftp/encode.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | let size = content.len(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/encode.rs:24:53 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_meta_data(metadata: metadata::Metadata, mut content: &mut String) -> Result, io::Error> { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut f = OpenOptions::new() [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/mod.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/ftp/mod.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | let mut files = "examples/files/foo.txt"; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/client/mod.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | self.action(input.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 25 | let _ = self.action(input.as_str()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/ftp/server/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/encode.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | file.read_to_string(&mut content); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 11 | let _ = file.read_to_string(&mut content); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut stream = stream.unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `string` [INFO] [stdout] --> src/ftp/server/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_string` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/ftp/server/mod.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | let mut c: usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stream` [INFO] [stdout] --> src/ftp/server/mod.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | fn notify_client_err(stream: &mut TcpStream, error: io::Error) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/client/mod.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn start(address: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `client` [INFO] [stdout] --> src/ftp/client/mod.rs:30:26 [INFO] [stdout] | [INFO] [stdout] 30 | let (mut stream, client) = super::client::new(self.address)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_client` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/client/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let mut stream = super::connect(address)?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 29 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_size` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let mut decoded_size: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_size` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_pktn` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut decoded_pktn: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_pktn` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_size` is never read [INFO] [stdout] --> src/ftp/decode.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | "size" => decoded_size = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_pktn` is never read [INFO] [stdout] --> src/ftp/decode.rs:41:27 [INFO] [stdout] | [INFO] [stdout] 41 | "pktn" => decoded_pktn = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/decode.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut rows = section2.next().unwrap().split(';'); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/ftp/encode.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | let size = content.len(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/encode.rs:24:53 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_meta_data(metadata: metadata::Metadata, mut content: &mut String) -> Result, io::Error> { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut f = OpenOptions::new() [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/mod.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/ftp/mod.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | let mut files = "examples/files/foo.txt"; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/client/mod.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | self.action(input.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 25 | let _ = self.action(input.as_str()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/encode.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | file.read_to_string(&mut content); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 11 | let _ = file.read_to_string(&mut content); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 29 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `Command { std: "docker" "inspect" "87d53ab082d1e425ad31ba4dd9b071c69d7b82375e4ed2aabc8ede1cea24ba0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87d53ab082d1e425ad31ba4dd9b071c69d7b82375e4ed2aabc8ede1cea24ba0e", kill_on_drop: false }` [INFO] [stdout] 87d53ab082d1e425ad31ba4dd9b071c69d7b82375e4ed2aabc8ede1cea24ba0e [INFO] checking pontuslaestadius/ftp-rust against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpontuslaestadius%2Fftp-rust" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/pontuslaestadius/ftp-rust on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/pontuslaestadius/ftp-rust [INFO] finished tweaking git repo https://github.com/pontuslaestadius/ftp-rust [INFO] tweaked toml for git repo https://github.com/pontuslaestadius/ftp-rust written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/pontuslaestadius/ftp-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a742e15520efd876fc33063eb8d810a38407a2c6fbb2f64dcef9a26240be0d6e [INFO] running `Command { std: "docker" "start" "-a" "a742e15520efd876fc33063eb8d810a38407a2c6fbb2f64dcef9a26240be0d6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a742e15520efd876fc33063eb8d810a38407a2c6fbb2f64dcef9a26240be0d6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a742e15520efd876fc33063eb8d810a38407a2c6fbb2f64dcef9a26240be0d6e", kill_on_drop: false }` [INFO] [stdout] a742e15520efd876fc33063eb8d810a38407a2c6fbb2f64dcef9a26240be0d6e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3b958f9f8c04991720bc9865e88150e8ad771283cfd76b4c82f7b8af3e84ff0b [INFO] running `Command { std: "docker" "start" "-a" "3b958f9f8c04991720bc9865e88150e8ad771283cfd76b4c82f7b8af3e84ff0b", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking ftp-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/ftp/mod.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `File` and `OpenOptions` [INFO] [stdout] --> src/ftp/server/mod.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/ftp/server/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/decode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/decode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/encode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/encode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/ftp/mod.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `File` and `OpenOptions` [INFO] [stdout] --> src/ftp/server/mod.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/ftp/server/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/decode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/decode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::net::TcpStream` [INFO] [stdout] --> src/ftp/encode.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::TcpStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OpenOptions` [INFO] [stdout] --> src/ftp/encode.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/ftp/server/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut stream = stream.unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `string` [INFO] [stdout] --> src/ftp/server/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_string` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/ftp/server/mod.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | let mut c: usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stream` [INFO] [stdout] --> src/ftp/server/mod.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | fn notify_client_err(stream: &mut TcpStream, error: io::Error) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/client/mod.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn start(address: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `client` [INFO] [stdout] --> src/ftp/client/mod.rs:30:26 [INFO] [stdout] | [INFO] [stdout] 30 | let (mut stream, client) = super::client::new(self.address)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_client` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/ftp/server/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/client/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let mut stream = super::connect(address)?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut stream = stream.unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `string` [INFO] [stdout] --> src/ftp/server/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_string` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/ftp/server/mod.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | let mut c: usize; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/server/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let mut string: String = String::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_size` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let mut decoded_size: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_size` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_pktn` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut decoded_pktn: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_pktn` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_size` is never read [INFO] [stdout] --> src/ftp/decode.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | "size" => decoded_size = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_pktn` is never read [INFO] [stdout] --> src/ftp/decode.rs:41:27 [INFO] [stdout] | [INFO] [stdout] 41 | "pktn" => decoded_pktn = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stream` [INFO] [stdout] --> src/ftp/server/mod.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | fn notify_client_err(stream: &mut TcpStream, error: io::Error) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/client/mod.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn start(address: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `client` [INFO] [stdout] --> src/ftp/client/mod.rs:30:26 [INFO] [stdout] | [INFO] [stdout] 30 | let (mut stream, client) = super::client::new(self.address)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_client` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/client/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let mut stream = super::connect(address)?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_size` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let mut decoded_size: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_size` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `decoded_pktn` is assigned to, but never used [INFO] [stdout] --> src/ftp/decode.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut decoded_pktn: &str = ""; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_decoded_pktn` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_size` is never read [INFO] [stdout] --> src/ftp/decode.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | "size" => decoded_size = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `decoded_pktn` is never read [INFO] [stdout] --> src/ftp/decode.rs:41:27 [INFO] [stdout] | [INFO] [stdout] 41 | "pktn" => decoded_pktn = value, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/decode.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut rows = section2.next().unwrap().split(';'); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/decode.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut rows = section2.next().unwrap().split(';'); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/ftp/encode.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | let size = content.len(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/ftp/encode.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | let size = content.len(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/encode.rs:24:53 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_meta_data(metadata: metadata::Metadata, mut content: &mut String) -> Result, io::Error> { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/encode.rs:24:53 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_meta_data(metadata: metadata::Metadata, mut content: &mut String) -> Result, io::Error> { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut f = OpenOptions::new() [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/mod.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/ftp/mod.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | let mut files = "examples/files/foo.txt"; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut f = OpenOptions::new() [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/ftp/mod.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/ftp/mod.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn start_server(address: &str, port: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ftp/mod.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | let mut files = "examples/files/foo.txt"; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/client/mod.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | self.action(input.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 25 | let _ = self.action(input.as_str()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ftp/client/mod.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 51 | let mut stream = super::connect(address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Ok((stream, Client {address})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/encode.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | file.read_to_string(&mut content); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 11 | let _ = file.read_to_string(&mut content); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 29 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/client/mod.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | self.action(input.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 25 | let _ = self.action(input.as_str()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ftp/client/mod.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 51 | let mut stream = super::connect(address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Ok((stream, Client {address})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/ftp/encode.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | file.read_to_string(&mut content); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 11 | let _ = file.read_to_string(&mut content); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 29 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ftp-rust` (lib) due to 2 previous errors; 29 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ftp-rust` (lib test) due to 2 previous errors; 29 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3b958f9f8c04991720bc9865e88150e8ad771283cfd76b4c82f7b8af3e84ff0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b958f9f8c04991720bc9865e88150e8ad771283cfd76b4c82f7b8af3e84ff0b", kill_on_drop: false }` [INFO] [stdout] 3b958f9f8c04991720bc9865e88150e8ad771283cfd76b4c82f7b8af3e84ff0b