[INFO] cloning repository https://github.com/picotan/geotool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/picotan/geotool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpicotan%2Fgeotool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpicotan%2Fgeotool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 81570c23c4092919a1b6228a9ab98f68d71679ea [INFO] checking picotan/geotool against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpicotan%2Fgeotool" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/picotan/geotool on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/picotan/geotool [INFO] finished tweaking git repo https://github.com/picotan/geotool [INFO] tweaked toml for git repo https://github.com/picotan/geotool written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding bitfield v0.14.0 (latest: v0.16.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bitfield v0.14.0 [INFO] [stderr] Downloaded num-complex v0.4.6 [INFO] [stderr] Downloaded num v0.4.3 [INFO] [stderr] Downloaded num-rational v0.4.2 [INFO] [stderr] Downloaded xmlwriter v0.1.0 [INFO] [stderr] Downloaded xml-rs v0.8.21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d0522fedc68858dcd0134ba0d01788fdb5053646338f6818a1183956b1513d48 [INFO] running `Command { std: "docker" "start" "-a" "d0522fedc68858dcd0134ba0d01788fdb5053646338f6818a1183956b1513d48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d0522fedc68858dcd0134ba0d01788fdb5053646338f6818a1183956b1513d48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0522fedc68858dcd0134ba0d01788fdb5053646338f6818a1183956b1513d48", kill_on_drop: false }` [INFO] [stdout] d0522fedc68858dcd0134ba0d01788fdb5053646338f6818a1183956b1513d48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cce0eda25983f06742a594de09f1713250216ccf6591cd8df661193807535175 [INFO] running `Command { std: "docker" "start" "-a" "cce0eda25983f06742a594de09f1713250216ccf6591cd8df661193807535175", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking xml-rs v0.8.21 [INFO] [stderr] Checking xmlwriter v0.1.0 [INFO] [stderr] Checking bitfield v0.14.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking cache v0.1.0 (/opt/rustwide/workdir/libs/cache) [INFO] [stderr] Checking geo v0.1.0 (/opt/rustwide/workdir/libs/geo) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:96:16 [INFO] [stdout] | [INFO] [stdout] 96 | if (s == e) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 96 - if (s == e) { [INFO] [stdout] 96 + if s == e { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | if (self.timetable[s].0 == *t) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 97 - if (self.timetable[s].0 == *t) { [INFO] [stdout] 97 + if self.timetable[s].0 == *t { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if ((t > &st) || (t < &et)) {return None} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 104 - if ((t > &st) || (t < &et)) {return None} [INFO] [stdout] 104 + if (t > &st) || (t < &et) {return None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:123:16 [INFO] [stdout] | [INFO] [stdout] 123 | if (s == e) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 123 - if (s == e) { [INFO] [stdout] 123 + if s == e { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:130:16 [INFO] [stdout] | [INFO] [stdout] 130 | if ((t.0 > st) || (t.0 < et)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 130 - if ((t.0 > st) || (t.0 < et)) { [INFO] [stdout] 130 + if (t.0 > st) || (t.0 < et) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:197:20 [INFO] [stdout] | [INFO] [stdout] 197 | if (l > self.life) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 197 - if (l > self.life) { [INFO] [stdout] 197 + if l > self.life { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:96:16 [INFO] [stdout] | [INFO] [stdout] 96 | if (s == e) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 96 - if (s == e) { [INFO] [stdout] 96 + if s == e { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | if (self.timetable[s].0 == *t) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 97 - if (self.timetable[s].0 == *t) { [INFO] [stdout] 97 + if self.timetable[s].0 == *t { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if ((t > &st) || (t < &et)) {return None} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 104 - if ((t > &st) || (t < &et)) {return None} [INFO] [stdout] 104 + if (t > &st) || (t < &et) {return None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:123:16 [INFO] [stdout] | [INFO] [stdout] 123 | if (s == e) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 123 - if (s == e) { [INFO] [stdout] 123 + if s == e { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:130:16 [INFO] [stdout] | [INFO] [stdout] 130 | if ((t.0 > st) || (t.0 < et)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 130 - if ((t.0 > st) || (t.0 < et)) { [INFO] [stdout] 130 + if (t.0 > st) || (t.0 < et) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:197:20 [INFO] [stdout] | [INFO] [stdout] 197 | if (l > self.life) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 197 - if (l > self.life) { [INFO] [stdout] 197 + if l > self.life { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:69:53 [INFO] [stdout] | [INFO] [stdout] 69 | fn process_route(self: &mut Self) -> Option<(TrackRoute)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - fn process_route(self: &mut Self) -> Option<(TrackRoute)> { [INFO] [stdout] 69 + fn process_route(self: &mut Self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:91:28 [INFO] [stdout] | [INFO] [stdout] 91 | if (name.local_name == "trk") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 91 - if (name.local_name == "trk") { [INFO] [stdout] 91 + if name.local_name == "trk" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:95:28 [INFO] [stdout] | [INFO] [stdout] 95 | if (tag == name) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - if (tag == name) { [INFO] [stdout] 95 + if tag == name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:133:28 [INFO] [stdout] | [INFO] [stdout] 133 | if (name.local_name == "extensions") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 133 - if (name.local_name == "extensions") { [INFO] [stdout] 133 + if name.local_name == "extensions" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:158:28 [INFO] [stdout] | [INFO] [stdout] 158 | if (name.local_name == n) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 158 - if (name.local_name == n) { [INFO] [stdout] 158 + if name.local_name == n { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:171:55 [INFO] [stdout] | [INFO] [stdout] 171 | fn process_segment(self: &mut Self) -> Option<(TrackSegment)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 171 - fn process_segment(self: &mut Self) -> Option<(TrackSegment)> { [INFO] [stdout] 171 + fn process_segment(self: &mut Self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:188:28 [INFO] [stdout] | [INFO] [stdout] 188 | if (name.local_name == "trkseg") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 188 - if (name.local_name == "trkseg") { [INFO] [stdout] 188 + if name.local_name == "trkseg" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:192:28 [INFO] [stdout] | [INFO] [stdout] 192 | if (tag == name) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - if (tag == name) { [INFO] [stdout] 192 + if tag == name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:69:53 [INFO] [stdout] | [INFO] [stdout] 69 | fn process_route(self: &mut Self) -> Option<(TrackRoute)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - fn process_route(self: &mut Self) -> Option<(TrackRoute)> { [INFO] [stdout] 69 + fn process_route(self: &mut Self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:229:28 [INFO] [stdout] | [INFO] [stdout] 229 | if (lat.is_nan()) { lat = a.value.parse().unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 229 - if (lat.is_nan()) { lat = a.value.parse().unwrap();} [INFO] [stdout] 229 + if lat.is_nan() { lat = a.value.parse().unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:233:28 [INFO] [stdout] | [INFO] [stdout] 233 | if (lon.is_nan()) { lon = a.value.parse().unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 233 - if (lon.is_nan()) { lon = a.value.parse().unwrap();} [INFO] [stdout] 233 + if lon.is_nan() { lon = a.value.parse().unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:91:28 [INFO] [stdout] | [INFO] [stdout] 91 | if (name.local_name == "trk") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 91 - if (name.local_name == "trk") { [INFO] [stdout] 91 + if name.local_name == "trk" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:239:16 [INFO] [stdout] | [INFO] [stdout] 239 | if (lat.is_nan() || lon.is_nan()) {return None;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 239 - if (lat.is_nan() || lon.is_nan()) {return None;} [INFO] [stdout] 239 + if lat.is_nan() || lon.is_nan() {return None;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:252:28 [INFO] [stdout] | [INFO] [stdout] 252 | if (name.local_name == "trkpt") {break;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 252 - if (name.local_name == "trkpt") {break;} [INFO] [stdout] 252 + if name.local_name == "trkpt" {break;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:95:28 [INFO] [stdout] | [INFO] [stdout] 95 | if (tag == name) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - if (tag == name) { [INFO] [stdout] 95 + if tag == name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:133:28 [INFO] [stdout] | [INFO] [stdout] 133 | if (name.local_name == "extensions") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 133 - if (name.local_name == "extensions") { [INFO] [stdout] 133 + if name.local_name == "extensions" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:273:28 [INFO] [stdout] | [INFO] [stdout] 273 | if (name.local_name == "extensions") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 273 - if (name.local_name == "extensions") { [INFO] [stdout] 273 + if name.local_name == "extensions" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:292:28 [INFO] [stdout] | [INFO] [stdout] 292 | if (name.local_name == "TrackPointExtension") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 292 - if (name.local_name == "TrackPointExtension") { [INFO] [stdout] 292 + if name.local_name == "TrackPointExtension" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:158:28 [INFO] [stdout] | [INFO] [stdout] 158 | if (name.local_name == n) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 158 - if (name.local_name == n) { [INFO] [stdout] 158 + if name.local_name == n { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:332:64 [INFO] [stdout] | [INFO] [stdout] 332 | ... "weather" => { p.weather = Weather((str.parse::().unwrap()))} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 332 - "weather" => { p.weather = Weather((str.parse::().unwrap()))} [INFO] [stdout] 332 + "weather" => { p.weather = Weather(str.parse::().unwrap())} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:171:55 [INFO] [stdout] | [INFO] [stdout] 171 | fn process_segment(self: &mut Self) -> Option<(TrackSegment)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 171 - fn process_segment(self: &mut Self) -> Option<(TrackSegment)> { [INFO] [stdout] 171 + fn process_segment(self: &mut Self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:188:28 [INFO] [stdout] | [INFO] [stdout] 188 | if (name.local_name == "trkseg") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 188 - if (name.local_name == "trkseg") { [INFO] [stdout] 188 + if name.local_name == "trkseg" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:192:28 [INFO] [stdout] | [INFO] [stdout] 192 | if (tag == name) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - if (tag == name) { [INFO] [stdout] 192 + if tag == name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:365:36 [INFO] [stdout] | [INFO] [stdout] 365 | ... if (error == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 365 - if (error == true) { [INFO] [stdout] 365 + if error == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:229:28 [INFO] [stdout] | [INFO] [stdout] 229 | if (lat.is_nan()) { lat = a.value.parse().unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 229 - if (lat.is_nan()) { lat = a.value.parse().unwrap();} [INFO] [stdout] 229 + if lat.is_nan() { lat = a.value.parse().unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:375:28 [INFO] [stdout] | [INFO] [stdout] 375 | if (name.local_name.as_str() == tag) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 375 - if (name.local_name.as_str() == tag) { [INFO] [stdout] 375 + if name.local_name.as_str() == tag { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:233:28 [INFO] [stdout] | [INFO] [stdout] 233 | if (lon.is_nan()) { lon = a.value.parse().unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 233 - if (lon.is_nan()) { lon = a.value.parse().unwrap();} [INFO] [stdout] 233 + if lon.is_nan() { lon = a.value.parse().unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:176:24 [INFO] [stdout] | [INFO] [stdout] 176 | if ((!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 176 - if ((!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN)) { [INFO] [stdout] 176 + if (!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:239:16 [INFO] [stdout] | [INFO] [stdout] 239 | if (lat.is_nan() || lon.is_nan()) {return None;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 239 - if (lat.is_nan() || lon.is_nan()) {return None;} [INFO] [stdout] 239 + if lat.is_nan() || lon.is_nan() {return None;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | if (!p.point.point_type.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 182 - if (!p.point.point_type.is_empty()) { [INFO] [stdout] 182 + if !p.point.point_type.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:252:28 [INFO] [stdout] | [INFO] [stdout] 252 | if (name.local_name == "trkpt") {break;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 252 - if (name.local_name == "trkpt") {break;} [INFO] [stdout] 252 + if name.local_name == "trkpt" {break;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Formatter` [INFO] [stdout] --> libs/geo/src/gpx.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fmt::Formatter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:202:16 [INFO] [stdout] | [INFO] [stdout] 202 | if (!self.heading.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 202 - if (!self.heading.is_nan()) {return true} [INFO] [stdout] 202 + if !self.heading.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:273:28 [INFO] [stdout] | [INFO] [stdout] 273 | if (name.local_name == "extensions") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 273 - if (name.local_name == "extensions") { [INFO] [stdout] 273 + if name.local_name == "extensions" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:203:16 [INFO] [stdout] | [INFO] [stdout] 203 | if (!self.pressure.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 - if (!self.pressure.is_nan()) {return true} [INFO] [stdout] 203 + if !self.pressure.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:292:28 [INFO] [stdout] | [INFO] [stdout] 292 | if (name.local_name == "TrackPointExtension") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 292 - if (name.local_name == "TrackPointExtension") { [INFO] [stdout] 292 + if name.local_name == "TrackPointExtension" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:204:16 [INFO] [stdout] | [INFO] [stdout] 204 | if (!self.temperature.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 204 - if (!self.temperature.is_nan()) {return true} [INFO] [stdout] 204 + if !self.temperature.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:332:64 [INFO] [stdout] | [INFO] [stdout] 332 | ... "weather" => { p.weather = Weather((str.parse::().unwrap()))} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 332 - "weather" => { p.weather = Weather((str.parse::().unwrap()))} [INFO] [stdout] 332 + "weather" => { p.weather = Weather(str.parse::().unwrap())} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:205:16 [INFO] [stdout] | [INFO] [stdout] 205 | if (!self.heart_rate.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 205 - if (!self.heart_rate.is_nan()) {return true} [INFO] [stdout] 205 + if !self.heart_rate.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:365:36 [INFO] [stdout] | [INFO] [stdout] 365 | ... if (error == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 365 - if (error == true) { [INFO] [stdout] 365 + if error == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:375:28 [INFO] [stdout] | [INFO] [stdout] 375 | if (name.local_name.as_str() == tag) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 375 - if (name.local_name.as_str() == tag) { [INFO] [stdout] 375 + if name.local_name.as_str() == tag { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:206:16 [INFO] [stdout] | [INFO] [stdout] 206 | if ((!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN)) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 206 - if ((!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN)) {return true} [INFO] [stdout] 206 + if (!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN) {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:207:16 [INFO] [stdout] | [INFO] [stdout] 207 | if (!self.luminance.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 207 - if (!self.luminance.is_nan()) {return true} [INFO] [stdout] 207 + if !self.luminance.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:176:24 [INFO] [stdout] | [INFO] [stdout] 176 | if ((!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 176 - if ((!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN)) { [INFO] [stdout] 176 + if (!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:208:16 [INFO] [stdout] | [INFO] [stdout] 208 | if (!self.radiation.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 208 - if (!self.radiation.is_nan()) {return true} [INFO] [stdout] 208 + if !self.radiation.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | if (!p.point.point_type.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 182 - if (!p.point.point_type.is_empty()) { [INFO] [stdout] 182 + if !p.point.point_type.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:209:16 [INFO] [stdout] | [INFO] [stdout] 209 | if (!self.distance.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - if (!self.distance.is_nan()) {return true} [INFO] [stdout] 209 + if !self.distance.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Formatter` [INFO] [stdout] --> libs/geo/src/gpx.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fmt::Formatter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:202:16 [INFO] [stdout] | [INFO] [stdout] 202 | if (!self.heading.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 202 - if (!self.heading.is_nan()) {return true} [INFO] [stdout] 202 + if !self.heading.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:210:16 [INFO] [stdout] | [INFO] [stdout] 210 | if (!self.energy.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 210 - if (!self.energy.is_nan()) {return true} [INFO] [stdout] 210 + if !self.energy.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:203:16 [INFO] [stdout] | [INFO] [stdout] 203 | if (!self.pressure.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 - if (!self.pressure.is_nan()) {return true} [INFO] [stdout] 203 + if !self.pressure.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:211:16 [INFO] [stdout] | [INFO] [stdout] 211 | if (!self.cadence.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 211 - if (!self.cadence.is_nan()) {return true} [INFO] [stdout] 211 + if !self.cadence.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:204:16 [INFO] [stdout] | [INFO] [stdout] 204 | if (!self.temperature.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 204 - if (!self.temperature.is_nan()) {return true} [INFO] [stdout] 204 + if !self.temperature.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:205:16 [INFO] [stdout] | [INFO] [stdout] 205 | if (!self.heart_rate.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 205 - if (!self.heart_rate.is_nan()) {return true} [INFO] [stdout] 205 + if !self.heart_rate.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:212:16 [INFO] [stdout] | [INFO] [stdout] 212 | if (!self.pace.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 212 - if (!self.pace.is_nan()) {return true} [INFO] [stdout] 212 + if !self.pace.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:206:16 [INFO] [stdout] | [INFO] [stdout] 206 | if ((!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN)) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 206 - if ((!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN)) {return true} [INFO] [stdout] 206 + if (!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN) {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:213:16 [INFO] [stdout] | [INFO] [stdout] 213 | if (!self.vertical_speed.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - if (!self.vertical_speed.is_nan()) {return true} [INFO] [stdout] 213 + if !self.vertical_speed.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:207:16 [INFO] [stdout] | [INFO] [stdout] 207 | if (!self.luminance.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 207 - if (!self.luminance.is_nan()) {return true} [INFO] [stdout] 207 + if !self.luminance.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:214:16 [INFO] [stdout] | [INFO] [stdout] 214 | if (self.weather != Weather(Weather::NONE)) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 214 - if (self.weather != Weather(Weather::NONE)) {return true} [INFO] [stdout] 214 + if self.weather != Weather(Weather::NONE) {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:208:16 [INFO] [stdout] | [INFO] [stdout] 208 | if (!self.radiation.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 208 - if (!self.radiation.is_nan()) {return true} [INFO] [stdout] 208 + if !self.radiation.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:215:16 [INFO] [stdout] | [INFO] [stdout] 215 | if (self.point_type.len() != 0) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 215 - if (self.point_type.len() != 0) {return true} [INFO] [stdout] 215 + if self.point_type.len() != 0 {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:209:16 [INFO] [stdout] | [INFO] [stdout] 209 | if (!self.distance.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - if (!self.distance.is_nan()) {return true} [INFO] [stdout] 209 + if !self.distance.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:216:16 [INFO] [stdout] | [INFO] [stdout] 216 | if (!self.comment.is_empty()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 216 - if (!self.comment.is_empty()) {return true} [INFO] [stdout] 216 + if !self.comment.is_empty() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:210:16 [INFO] [stdout] | [INFO] [stdout] 210 | if (!self.energy.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 210 - if (!self.energy.is_nan()) {return true} [INFO] [stdout] 210 + if !self.energy.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:217:16 [INFO] [stdout] | [INFO] [stdout] 217 | if (!self.name.is_empty()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 217 - if (!self.name.is_empty()) {return true} [INFO] [stdout] 217 + if !self.name.is_empty() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:211:16 [INFO] [stdout] | [INFO] [stdout] 211 | if (!self.cadence.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 211 - if (!self.cadence.is_nan()) {return true} [INFO] [stdout] 211 + if !self.cadence.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:212:16 [INFO] [stdout] | [INFO] [stdout] 212 | if (!self.pace.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 212 - if (!self.pace.is_nan()) {return true} [INFO] [stdout] 212 + if !self.pace.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:225:16 [INFO] [stdout] | [INFO] [stdout] 225 | if (!self.altitude.is_nan()) {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 225 - if (!self.altitude.is_nan()) {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] 225 + if !self.altitude.is_nan() {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:226:16 [INFO] [stdout] | [INFO] [stdout] 226 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 226 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 226 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:213:16 [INFO] [stdout] | [INFO] [stdout] 213 | if (!self.vertical_speed.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - if (!self.vertical_speed.is_nan()) {return true} [INFO] [stdout] 213 + if !self.vertical_speed.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:214:16 [INFO] [stdout] | [INFO] [stdout] 214 | if (self.weather != Weather(Weather::NONE)) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 214 - if (self.weather != Weather(Weather::NONE)) {return true} [INFO] [stdout] 214 + if self.weather != Weather(Weather::NONE) {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:215:16 [INFO] [stdout] | [INFO] [stdout] 215 | if (self.point_type.len() != 0) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 215 - if (self.point_type.len() != 0) {return true} [INFO] [stdout] 215 + if self.point_type.len() != 0 {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:216:16 [INFO] [stdout] | [INFO] [stdout] 216 | if (!self.comment.is_empty()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 216 - if (!self.comment.is_empty()) {return true} [INFO] [stdout] 216 + if !self.comment.is_empty() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:227:16 [INFO] [stdout] | [INFO] [stdout] 227 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 227 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 227 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:217:16 [INFO] [stdout] | [INFO] [stdout] 217 | if (!self.name.is_empty()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 217 - if (!self.name.is_empty()) {return true} [INFO] [stdout] 217 + if !self.name.is_empty() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:228:16 [INFO] [stdout] | [INFO] [stdout] 228 | if (!self.time.eq(&DateTime::::MIN_UTC)) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 228 - if (!self.time.eq(&DateTime::::MIN_UTC)) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] 228 + if !self.time.eq(&DateTime::::MIN_UTC) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:225:16 [INFO] [stdout] | [INFO] [stdout] 225 | if (!self.altitude.is_nan()) {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 225 - if (!self.altitude.is_nan()) {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] 225 + if !self.altitude.is_nan() {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:226:16 [INFO] [stdout] | [INFO] [stdout] 226 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 226 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 226 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:229:16 [INFO] [stdout] | [INFO] [stdout] 229 | if (!self.heading.is_nan()) {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 229 - if (!self.heading.is_nan()) {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] 229 + if !self.heading.is_nan() {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:230:16 [INFO] [stdout] | [INFO] [stdout] 230 | if (!self.pressure.is_nan()) {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 230 - if (!self.pressure.is_nan()) {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] 230 + if !self.pressure.is_nan() {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:227:16 [INFO] [stdout] | [INFO] [stdout] 227 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 227 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 227 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:231:16 [INFO] [stdout] | [INFO] [stdout] 231 | if (!self.temperature.is_nan()) {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 231 - if (!self.temperature.is_nan()) {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] 231 + if !self.temperature.is_nan() {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:228:16 [INFO] [stdout] | [INFO] [stdout] 228 | if (!self.time.eq(&DateTime::::MIN_UTC)) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 228 - if (!self.time.eq(&DateTime::::MIN_UTC)) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] 228 + if !self.time.eq(&DateTime::::MIN_UTC) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if (!self.heart_rate.is_nan()) {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 232 - if (!self.heart_rate.is_nan()) {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] 232 + if !self.heart_rate.is_nan() {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:229:16 [INFO] [stdout] | [INFO] [stdout] 229 | if (!self.heading.is_nan()) {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 229 - if (!self.heading.is_nan()) {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] 229 + if !self.heading.is_nan() {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:233:16 [INFO] [stdout] | [INFO] [stdout] 233 | if (!self.luminance.is_nan()) {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 233 - if (!self.luminance.is_nan()) {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] 233 + if !self.luminance.is_nan() {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:230:16 [INFO] [stdout] | [INFO] [stdout] 230 | if (!self.pressure.is_nan()) {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 230 - if (!self.pressure.is_nan()) {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] 230 + if !self.pressure.is_nan() {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:234:16 [INFO] [stdout] | [INFO] [stdout] 234 | if (!self.radiation.is_nan()) {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 234 - if (!self.radiation.is_nan()) {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] 234 + if !self.radiation.is_nan() {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:231:16 [INFO] [stdout] | [INFO] [stdout] 231 | if (!self.temperature.is_nan()) {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 231 - if (!self.temperature.is_nan()) {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] 231 + if !self.temperature.is_nan() {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if (!self.heart_rate.is_nan()) {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 232 - if (!self.heart_rate.is_nan()) {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] 232 + if !self.heart_rate.is_nan() {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:235:16 [INFO] [stdout] | [INFO] [stdout] 235 | if (self.weather != Weather(Weather::NONE)) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 235 - if (self.weather != Weather(Weather::NONE)) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] 235 + if self.weather != Weather(Weather::NONE) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:233:16 [INFO] [stdout] | [INFO] [stdout] 233 | if (!self.luminance.is_nan()) {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 233 - if (!self.luminance.is_nan()) {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] 233 + if !self.luminance.is_nan() {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:236:16 [INFO] [stdout] | [INFO] [stdout] 236 | if (self.point_type.len() != 0) {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 236 - if (self.point_type.len() != 0) {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] 236 + if self.point_type.len() != 0 {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:234:16 [INFO] [stdout] | [INFO] [stdout] 234 | if (!self.radiation.is_nan()) {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 234 - if (!self.radiation.is_nan()) {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] 234 + if !self.radiation.is_nan() {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:235:16 [INFO] [stdout] | [INFO] [stdout] 235 | if (self.weather != Weather(Weather::NONE)) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 235 - if (self.weather != Weather(Weather::NONE)) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] 235 + if self.weather != Weather(Weather::NONE) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:282:16 [INFO] [stdout] | [INFO] [stdout] 282 | if (self.highest < p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 282 - if (self.highest < p.altitude) { [INFO] [stdout] 282 + if self.highest < p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:236:16 [INFO] [stdout] | [INFO] [stdout] 236 | if (self.point_type.len() != 0) {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 236 - if (self.point_type.len() != 0) {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] 236 + if self.point_type.len() != 0 {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:285:16 [INFO] [stdout] | [INFO] [stdout] 285 | if (self.lowest > p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 285 - if (self.lowest > p.altitude) { [INFO] [stdout] 285 + if self.lowest > p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:282:16 [INFO] [stdout] | [INFO] [stdout] 282 | if (self.highest < p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 282 - if (self.highest < p.altitude) { [INFO] [stdout] 282 + if self.highest < p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | if (self.lowest > seg.lowest) {self.lowest = seg.lowest} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 301 - if (self.lowest > seg.lowest) {self.lowest = seg.lowest} [INFO] [stdout] 301 + if self.lowest > seg.lowest {self.lowest = seg.lowest} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:285:16 [INFO] [stdout] | [INFO] [stdout] 285 | if (self.lowest > p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 285 - if (self.lowest > p.altitude) { [INFO] [stdout] 285 + if self.lowest > p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:302:16 [INFO] [stdout] | [INFO] [stdout] 302 | if (self.highest < seg.highest) {self.highest = seg.highest} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 302 - if (self.highest < seg.highest) {self.highest = seg.highest} [INFO] [stdout] 302 + if self.highest < seg.highest {self.highest = seg.highest} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | if (self.lowest > seg.lowest) {self.lowest = seg.lowest} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 301 - if (self.lowest > seg.lowest) {self.lowest = seg.lowest} [INFO] [stdout] 301 + if self.lowest > seg.lowest {self.lowest = seg.lowest} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:321:16 [INFO] [stdout] | [INFO] [stdout] 321 | if (self.highest < segment.highest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 321 - if (self.highest < segment.highest) { [INFO] [stdout] 321 + if self.highest < segment.highest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:302:16 [INFO] [stdout] | [INFO] [stdout] 302 | if (self.highest < seg.highest) {self.highest = seg.highest} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 302 - if (self.highest < seg.highest) {self.highest = seg.highest} [INFO] [stdout] 302 + if self.highest < seg.highest {self.highest = seg.highest} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:324:16 [INFO] [stdout] | [INFO] [stdout] 324 | if (self.lowest > segment.lowest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 324 - if (self.lowest > segment.lowest) { [INFO] [stdout] 324 + if self.lowest > segment.lowest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:321:16 [INFO] [stdout] | [INFO] [stdout] 321 | if (self.highest < segment.highest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 321 - if (self.highest < segment.highest) { [INFO] [stdout] 321 + if self.highest < segment.highest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:327:16 [INFO] [stdout] | [INFO] [stdout] 327 | if (self.points.len() == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 327 - if (self.points.len() == 0) { [INFO] [stdout] 327 + if self.points.len() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:330:23 [INFO] [stdout] | [INFO] [stdout] 330 | } else if (i == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 330 - } else if (i == 0) { [INFO] [stdout] 330 + } else if i == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:324:16 [INFO] [stdout] | [INFO] [stdout] 324 | if (self.lowest > segment.lowest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 324 - if (self.lowest > segment.lowest) { [INFO] [stdout] 324 + if self.lowest > segment.lowest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:391:27 [INFO] [stdout] | [INFO] [stdout] 391 | } else if (i != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 391 - } else if (i != 0) { [INFO] [stdout] 391 + } else if i != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:327:16 [INFO] [stdout] | [INFO] [stdout] 327 | if (self.points.len() == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 327 - if (self.points.len() == 0) { [INFO] [stdout] 327 + if self.points.len() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:402:16 [INFO] [stdout] | [INFO] [stdout] 402 | if (self.points.len() < i) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 402 - if (self.points.len() < i) { [INFO] [stdout] 402 + if self.points.len() < i { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:330:23 [INFO] [stdout] | [INFO] [stdout] 330 | } else if (i == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 330 - } else if (i == 0) { [INFO] [stdout] 330 + } else if i == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:405:16 [INFO] [stdout] | [INFO] [stdout] 405 | if (self.highest < p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 405 - if (self.highest < p.altitude) { [INFO] [stdout] 405 + if self.highest < p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:391:27 [INFO] [stdout] | [INFO] [stdout] 391 | } else if (i != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 391 - } else if (i != 0) { [INFO] [stdout] 391 + } else if i != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:408:16 [INFO] [stdout] | [INFO] [stdout] 408 | if (self.lowest > p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 408 - if (self.lowest > p.altitude) { [INFO] [stdout] 408 + if self.lowest > p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:402:16 [INFO] [stdout] | [INFO] [stdout] 402 | if (self.points.len() < i) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 402 - if (self.points.len() < i) { [INFO] [stdout] 402 + if self.points.len() < i { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:405:16 [INFO] [stdout] | [INFO] [stdout] 405 | if (self.highest < p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 405 - if (self.highest < p.altitude) { [INFO] [stdout] 405 + if self.highest < p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:412:16 [INFO] [stdout] | [INFO] [stdout] 412 | if (self.points.len() != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 412 - if (self.points.len() != 0) { [INFO] [stdout] 412 + if self.points.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:408:16 [INFO] [stdout] | [INFO] [stdout] 408 | if (self.lowest > p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 408 - if (self.lowest > p.altitude) { [INFO] [stdout] 408 + if self.lowest > p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:414:20 [INFO] [stdout] | [INFO] [stdout] 414 | if (i != (self.points.len() - 1)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 414 - if (i != (self.points.len() - 1)) { [INFO] [stdout] 414 + if i != (self.points.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:412:16 [INFO] [stdout] | [INFO] [stdout] 412 | if (self.points.len() != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 412 - if (self.points.len() != 0) { [INFO] [stdout] 412 + if self.points.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:420:20 [INFO] [stdout] | [INFO] [stdout] 420 | if (i != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 420 - if (i != 0) { [INFO] [stdout] 420 + if i != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:414:20 [INFO] [stdout] | [INFO] [stdout] 414 | if (i != (self.points.len() - 1)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 414 - if (i != (self.points.len() - 1)) { [INFO] [stdout] 414 + if i != (self.points.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:432:16 [INFO] [stdout] | [INFO] [stdout] 432 | if (self.points.len() < i) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 432 - if (self.points.len() < i) { [INFO] [stdout] 432 + if self.points.len() < i { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:420:20 [INFO] [stdout] | [INFO] [stdout] 420 | if (i != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 420 - if (i != 0) { [INFO] [stdout] 420 + if i != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:432:16 [INFO] [stdout] | [INFO] [stdout] 432 | if (self.points.len() < i) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 432 - if (self.points.len() < i) { [INFO] [stdout] 432 + if self.points.len() < i { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:437:16 [INFO] [stdout] | [INFO] [stdout] 437 | if (self.points.len() > 1) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 437 - if (self.points.len() > 1) { [INFO] [stdout] 437 + if self.points.len() > 1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:439:20 [INFO] [stdout] | [INFO] [stdout] 439 | if (i == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 439 - if (i == 0) { [INFO] [stdout] 439 + if i == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:437:16 [INFO] [stdout] | [INFO] [stdout] 437 | if (self.points.len() > 1) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 437 - if (self.points.len() > 1) { [INFO] [stdout] 437 + if self.points.len() > 1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:452:16 [INFO] [stdout] | [INFO] [stdout] 452 | if (p.location.lat > self.area.north_west.lat) {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 452 - if (p.location.lat > self.area.north_west.lat) {} [INFO] [stdout] 452 + if p.location.lat > self.area.north_west.lat {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:439:20 [INFO] [stdout] | [INFO] [stdout] 439 | if (i == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 439 - if (i == 0) { [INFO] [stdout] 439 + if i == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:458:20 [INFO] [stdout] | [INFO] [stdout] 458 | if (p.point.altitude < self.lowest) {self.lowest = p.point.altitude;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 458 - if (p.point.altitude < self.lowest) {self.lowest = p.point.altitude;} [INFO] [stdout] 458 + if p.point.altitude < self.lowest {self.lowest = p.point.altitude;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:452:16 [INFO] [stdout] | [INFO] [stdout] 452 | if (p.location.lat > self.area.north_west.lat) {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 452 - if (p.location.lat > self.area.north_west.lat) {} [INFO] [stdout] 452 + if p.location.lat > self.area.north_west.lat {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:459:20 [INFO] [stdout] | [INFO] [stdout] 459 | if (p.point.altitude > self.highest) {self.highest = p.point.altitude;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 459 - if (p.point.altitude > self.highest) {self.highest = p.point.altitude;} [INFO] [stdout] 459 + if p.point.altitude > self.highest {self.highest = p.point.altitude;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:458:20 [INFO] [stdout] | [INFO] [stdout] 458 | if (p.point.altitude < self.lowest) {self.lowest = p.point.altitude;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 458 - if (p.point.altitude < self.lowest) {self.lowest = p.point.altitude;} [INFO] [stdout] 458 + if p.point.altitude < self.lowest {self.lowest = p.point.altitude;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:467:16 [INFO] [stdout] | [INFO] [stdout] 467 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 467 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 467 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:459:20 [INFO] [stdout] | [INFO] [stdout] 459 | if (p.point.altitude > self.highest) {self.highest = p.point.altitude;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 459 - if (p.point.altitude > self.highest) {self.highest = p.point.altitude;} [INFO] [stdout] 459 + if p.point.altitude > self.highest {self.highest = p.point.altitude;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:468:16 [INFO] [stdout] | [INFO] [stdout] 468 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 468 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 468 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:467:16 [INFO] [stdout] | [INFO] [stdout] 467 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 467 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 467 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:472:16 [INFO] [stdout] | [INFO] [stdout] 472 | if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 472 - if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] 472 + if !self.highest.is_nan() {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:468:16 [INFO] [stdout] | [INFO] [stdout] 468 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 468 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 468 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:473:16 [INFO] [stdout] | [INFO] [stdout] 473 | if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 473 - if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] 473 + if !self.lowest.is_nan() {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:472:16 [INFO] [stdout] | [INFO] [stdout] 472 | if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 472 - if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] 472 + if !self.highest.is_nan() {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:500:16 [INFO] [stdout] | [INFO] [stdout] 500 | if (segment.lowest < self.lowest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 500 - if (segment.lowest < self.lowest) { [INFO] [stdout] 500 + if segment.lowest < self.lowest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:473:16 [INFO] [stdout] | [INFO] [stdout] 473 | if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 473 - if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] 473 + if !self.lowest.is_nan() {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:504:16 [INFO] [stdout] | [INFO] [stdout] 504 | if (segment.highest < self.highest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 504 - if (segment.highest < self.highest) { [INFO] [stdout] 504 + if segment.highest < self.highest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:500:16 [INFO] [stdout] | [INFO] [stdout] 500 | if (segment.lowest < self.lowest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 500 - if (segment.lowest < self.lowest) { [INFO] [stdout] 500 + if segment.lowest < self.lowest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:515:16 [INFO] [stdout] | [INFO] [stdout] 515 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 515 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 515 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:504:16 [INFO] [stdout] | [INFO] [stdout] 504 | if (segment.highest < self.highest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 504 - if (segment.highest < self.highest) { [INFO] [stdout] 504 + if segment.highest < self.highest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:516:16 [INFO] [stdout] | [INFO] [stdout] 516 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 516 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 516 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:515:16 [INFO] [stdout] | [INFO] [stdout] 515 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 515 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 515 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:520:16 [INFO] [stdout] | [INFO] [stdout] 520 | if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 520 - if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] 520 + if !self.highest.is_nan() {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:516:16 [INFO] [stdout] | [INFO] [stdout] 516 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 516 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 516 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:521:16 [INFO] [stdout] | [INFO] [stdout] 521 | if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 521 - if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] 521 + if !self.lowest.is_nan() {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:520:16 [INFO] [stdout] | [INFO] [stdout] 520 | if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 520 - if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] 520 + if !self.highest.is_nan() {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:522:16 [INFO] [stdout] | [INFO] [stdout] 522 | if (!self.distance.is_nan()) {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 522 - if (!self.distance.is_nan()) {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] 522 + if !self.distance.is_nan() {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:521:16 [INFO] [stdout] | [INFO] [stdout] 521 | if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 521 - if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] 521 + if !self.lowest.is_nan() {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:567:16 [INFO] [stdout] | [INFO] [stdout] 567 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 567 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 567 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:522:16 [INFO] [stdout] | [INFO] [stdout] 522 | if (!self.distance.is_nan()) {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 522 - if (!self.distance.is_nan()) {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] 522 + if !self.distance.is_nan() {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:568:16 [INFO] [stdout] | [INFO] [stdout] 568 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 568 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 568 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::integer::sqrt` [INFO] [stdout] --> libs/geo/src/geometry.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | use num::integer::sqrt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:567:16 [INFO] [stdout] | [INFO] [stdout] 567 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 567 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 567 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | if (location.lat > self.north_west.lat) {self.north_west.lat = location.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - if (location.lat > self.north_west.lat) {self.north_west.lat = location.lat} [INFO] [stdout] 58 + if location.lat > self.north_west.lat {self.north_west.lat = location.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:568:16 [INFO] [stdout] | [INFO] [stdout] 568 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 568 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 568 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if (location.lon < self.north_west.lon) {self.north_west.lon = location.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - if (location.lon < self.north_west.lon) {self.north_west.lon = location.lon} [INFO] [stdout] 59 + if location.lon < self.north_west.lon {self.north_west.lon = location.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::integer::sqrt` [INFO] [stdout] --> libs/geo/src/geometry.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | use num::integer::sqrt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if (location.lat < self.south_east.lat) {self.south_east.lat = location.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - if (location.lat < self.south_east.lat) {self.south_east.lat = location.lat} [INFO] [stdout] 60 + if location.lat < self.south_east.lat {self.south_east.lat = location.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | if (location.lat > self.north_west.lat) {self.north_west.lat = location.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - if (location.lat > self.north_west.lat) {self.north_west.lat = location.lat} [INFO] [stdout] 58 + if location.lat > self.north_west.lat {self.north_west.lat = location.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:61:16 [INFO] [stdout] | [INFO] [stdout] 61 | if (location.lon > self.south_east.lon) {self.south_east.lon = location.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 61 - if (location.lon > self.south_east.lon) {self.south_east.lon = location.lon} [INFO] [stdout] 61 + if location.lon > self.south_east.lon {self.south_east.lon = location.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if (location.lon < self.north_west.lon) {self.north_west.lon = location.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - if (location.lon < self.north_west.lon) {self.north_west.lon = location.lon} [INFO] [stdout] 59 + if location.lon < self.north_west.lon {self.north_west.lon = location.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | if (area.north_west.lat > self.north_west.lat) {self.north_west.lat = area.north_west.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - if (area.north_west.lat > self.north_west.lat) {self.north_west.lat = area.north_west.lat} [INFO] [stdout] 65 + if area.north_west.lat > self.north_west.lat {self.north_west.lat = area.north_west.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if (location.lat < self.south_east.lat) {self.south_east.lat = location.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - if (location.lat < self.south_east.lat) {self.south_east.lat = location.lat} [INFO] [stdout] 60 + if location.lat < self.south_east.lat {self.south_east.lat = location.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | if (area.north_west.lon < self.north_west.lon) {self.north_west.lon = area.north_west.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - if (area.north_west.lon < self.north_west.lon) {self.north_west.lon = area.north_west.lon} [INFO] [stdout] 66 + if area.north_west.lon < self.north_west.lon {self.north_west.lon = area.north_west.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:61:16 [INFO] [stdout] | [INFO] [stdout] 61 | if (location.lon > self.south_east.lon) {self.south_east.lon = location.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 61 - if (location.lon > self.south_east.lon) {self.south_east.lon = location.lon} [INFO] [stdout] 61 + if location.lon > self.south_east.lon {self.south_east.lon = location.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | if (area.south_east.lat < self.south_east.lat) {self.south_east.lat = area.south_east.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - if (area.south_east.lat < self.south_east.lat) {self.south_east.lat = area.south_east.lat} [INFO] [stdout] 67 + if area.south_east.lat < self.south_east.lat {self.south_east.lat = area.south_east.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | if (area.north_west.lat > self.north_west.lat) {self.north_west.lat = area.north_west.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - if (area.north_west.lat > self.north_west.lat) {self.north_west.lat = area.north_west.lat} [INFO] [stdout] 65 + if area.north_west.lat > self.north_west.lat {self.north_west.lat = area.north_west.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if (area.south_east.lon > self.south_east.lon) {self.south_east.lon = area.south_east.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 68 - if (area.south_east.lon > self.south_east.lon) {self.south_east.lon = area.south_east.lon} [INFO] [stdout] 68 + if area.south_east.lon > self.south_east.lon {self.south_east.lon = area.south_east.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | if (area.north_west.lon < self.north_west.lon) {self.north_west.lon = area.north_west.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - if (area.north_west.lon < self.north_west.lon) {self.north_west.lon = area.north_west.lon} [INFO] [stdout] 66 + if area.north_west.lon < self.north_west.lon {self.north_west.lon = area.north_west.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:72:16 [INFO] [stdout] | [INFO] [stdout] 72 | if ((area.north_west.lat > self.north_west.lat) && (area.south_east.lat < self.south_east.lat) [INFO] [stdout] | ^ [INFO] [stdout] 73 | && (area.north_west.lon < self.north_west.lon) && (area.south_east.lon > self.south_east.lon)) { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 72 ~ if (area.north_west.lat > self.north_west.lat) && (area.south_east.lat < self.south_east.lat) [INFO] [stdout] 73 ~ && (area.north_west.lon < self.north_west.lon) && (area.south_east.lon > self.south_east.lon) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | if (area.south_east.lat < self.south_east.lat) {self.south_east.lat = area.south_east.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - if (area.south_east.lat < self.south_east.lat) {self.south_east.lat = area.south_east.lat} [INFO] [stdout] 67 + if area.south_east.lat < self.south_east.lat {self.south_east.lat = area.south_east.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if (area.south_east.lon > self.south_east.lon) {self.south_east.lon = area.south_east.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 68 - if (area.south_east.lon > self.south_east.lon) {self.south_east.lon = area.south_east.lon} [INFO] [stdout] 68 + if area.south_east.lon > self.south_east.lon {self.south_east.lon = area.south_east.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:72:16 [INFO] [stdout] | [INFO] [stdout] 72 | if ((area.north_west.lat > self.north_west.lat) && (area.south_east.lat < self.south_east.lat) [INFO] [stdout] | ^ [INFO] [stdout] 73 | && (area.north_west.lon < self.north_west.lon) && (area.south_east.lon > self.south_east.lon)) { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 72 ~ if (area.north_west.lat > self.north_west.lat) && (area.south_east.lat < self.south_east.lat) [INFO] [stdout] 73 ~ && (area.north_west.lon < self.north_west.lon) && (area.south_east.lon > self.south_east.lon) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/cache/src/cachedb.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | let mut f = File::open(path)?; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/cache/src/cachedb.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | let mut f = File::open(path)?; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/cache/src/cachedb.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 225 | let mut p = p.to_path_buf(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/cache/src/cachedb.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 225 | let mut p = p.to_path_buf(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `FileAttr` is more private than the item `Cache::get_attr` [INFO] [stdout] --> libs/cache/src/cachedb.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn get_attr(self: &Self, path: &OsString) -> Option<&FileAttr> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `Cache::get_attr` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileAttr` is only usable at visibility `pub(self)` [INFO] [stdout] --> libs/cache/src/cachedb.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | struct FileAttr { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `FileAttr` is more private than the item `Cache::set_path_sub` [INFO] [stdout] --> libs/cache/src/cachedb.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | / pub fn set_path_sub(path: &String, [INFO] [stdout] 221 | | create: bool, [INFO] [stdout] 222 | | list: &mut HashMap, [INFO] [stdout] 223 | | timetable: &mut Vec<(SystemTime, OsString)>) -> Result { [INFO] [stdout] | |_______________________________________________________________________________________________^ associated function `Cache::set_path_sub` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileAttr` is only usable at visibility `pub(self)` [INFO] [stdout] --> libs/cache/src/cachedb.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | struct FileAttr { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `FileAttr` is more private than the item `Cache::get_attr` [INFO] [stdout] --> libs/cache/src/cachedb.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn get_attr(self: &Self, path: &OsString) -> Option<&FileAttr> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `Cache::get_attr` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileAttr` is only usable at visibility `pub(self)` [INFO] [stdout] --> libs/cache/src/cachedb.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | struct FileAttr { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `parse` is never used [INFO] [stdout] --> libs/cache/src/cachedb.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl FileAttr { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 40 | fn parse(&self) -> Result<(i64, i64, i64), ParseIntError> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `FileAttr` is more private than the item `Cache::set_path_sub` [INFO] [stdout] --> libs/cache/src/cachedb.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | / pub fn set_path_sub(path: &String, [INFO] [stdout] 221 | | create: bool, [INFO] [stdout] 222 | | list: &mut HashMap, [INFO] [stdout] 223 | | timetable: &mut Vec<(SystemTime, OsString)>) -> Result { [INFO] [stdout] | |_______________________________________________________________________________________________^ associated function `Cache::set_path_sub` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileAttr` is only usable at visibility `pub(self)` [INFO] [stdout] --> libs/cache/src/cachedb.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | struct FileAttr { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `parse` is never used [INFO] [stdout] --> libs/cache/src/cachedb.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl FileAttr { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 40 | fn parse(&self) -> Result<(i64, i64, i64), ParseIntError> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `quick_find`, `quick_find_sub`, and `add` are never used [INFO] [stdout] --> libs/cache/src/cachedb.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 81 | impl Cache { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | fn quick_find(self: &Self, t: &SystemTime) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 95 | fn quick_find_sub(self: &Self, t: &SystemTime, s: usize, e:usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 141 | fn add(self: &mut Self, path: &PathBuf, attr: FileAttr) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `quick_find`, `quick_find_sub`, and `add` are never used [INFO] [stdout] --> libs/cache/src/cachedb.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 81 | impl Cache { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | fn quick_find(self: &Self, t: &SystemTime) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 95 | fn quick_find_sub(self: &Self, t: &SystemTime, s: usize, e:usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 141 | fn add(self: &mut Self, path: &PathBuf, attr: FileAttr) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bitfield::BitRangeMut` [INFO] [stdout] --> libs/geo/src/gpx.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | use bitfield::BitRangeMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/geometry.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bitfield::BitRangeMut` [INFO] [stdout] --> libs/geo/src/gpx.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | use bitfield::BitRangeMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/geometry.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | let mut route = self.process_gpx(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | let mut route = self.process_gpx(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:344:41 [INFO] [stdout] | [INFO] [stdout] 344 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:344:41 [INFO] [stdout] | [INFO] [stdout] 344 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:352:41 [INFO] [stdout] | [INFO] [stdout] 352 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:352:41 [INFO] [stdout] | [INFO] [stdout] 352 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:360:41 [INFO] [stdout] | [INFO] [stdout] 360 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:360:41 [INFO] [stdout] | [INFO] [stdout] 360 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx.rs:378:21 [INFO] [stdout] | [INFO] [stdout] 378 | let mut p = &mut self.points[usize::from(i)]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx.rs:378:21 [INFO] [stdout] | [INFO] [stdout] 378 | let mut p = &mut self.points[usize::from(i)]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx.rs:416:25 [INFO] [stdout] | [INFO] [stdout] 416 | let mut n = &mut self.points[i + 1]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx.rs:416:25 [INFO] [stdout] | [INFO] [stdout] 416 | let mut n = &mut self.points[i + 1]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `min` [INFO] [stdout] --> libs/geo/src/geometry.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | let min = self.alt.min(p.alt); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_min` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `min` [INFO] [stdout] --> libs/geo/src/geometry.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | let min = self.alt.min(p.alt); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_min` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `file` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Parser { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 15 | file: OsString, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `file` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Parser { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 15 | file: OsString, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | self.file.write(a.as_ref()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = self.file.write(a.as_ref()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | self.file.write(a.as_ref()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = self.file.write(a.as_ref()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 106 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 106 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking app v0.1.0 (/opt/rustwide/workdir/app) [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> app/src/main.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let a = LatLon::new(0f64, 0f64); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> app/src/main.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let a = LatLon::new(0f64, 0f64); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `l2` [INFO] [stdout] --> app/src/main.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let l2 = LatLon::new(35.535823, 139.634943); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_l2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `l2` [INFO] [stdout] --> app/src/main.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let l2 = LatLon::new(35.535823, 139.634943); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_l2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `l3` [INFO] [stdout] --> app/src/main.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let l3 = LatLon::new(35.457174, 139.606361); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_l3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `l3` [INFO] [stdout] --> app/src/main.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let l3 = LatLon::new(35.457174, 139.606361); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_l3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `l4` [INFO] [stdout] --> app/src/main.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let l4 = LatLon::new(35.571471, 139.688416); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_l4` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `l4` [INFO] [stdout] --> app/src/main.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let l4 = LatLon::new(35.571471, 139.688416); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_l4` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> app/src/main.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | let mut cache = match Cache::new(&String::from("/tmp/test"), 64) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> app/src/main.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | let mut cache = match Cache::new(&String::from("/tmp/test"), 64) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `max_tiles` is never used [INFO] [stdout] --> app/src/main.rs:48:4 [INFO] [stdout] | [INFO] [stdout] 48 | fn max_tiles(z: u32) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `coord_to_pixel` is never used [INFO] [stdout] --> app/src/main.rs:52:4 [INFO] [stdout] | [INFO] [stdout] 52 | fn coord_to_pixel(x: f64, y: f64, z: u32) -> (i64, i64) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `max_tiles` is never used [INFO] [stdout] --> app/src/main.rs:48:4 [INFO] [stdout] | [INFO] [stdout] 48 | fn max_tiles(z: u32) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `coord_to_pixel` is never used [INFO] [stdout] --> app/src/main.rs:52:4 [INFO] [stdout] | [INFO] [stdout] 52 | fn coord_to_pixel(x: f64, y: f64, z: u32) -> (i64, i64) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.25s [INFO] running `Command { std: "docker" "inspect" "cce0eda25983f06742a594de09f1713250216ccf6591cd8df661193807535175", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cce0eda25983f06742a594de09f1713250216ccf6591cd8df661193807535175", kill_on_drop: false }` [INFO] [stdout] cce0eda25983f06742a594de09f1713250216ccf6591cd8df661193807535175 [INFO] checking picotan/geotool against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpicotan%2Fgeotool" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/picotan/geotool on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/picotan/geotool [INFO] finished tweaking git repo https://github.com/picotan/geotool [INFO] tweaked toml for git repo https://github.com/picotan/geotool written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding bitfield v0.14.0 (latest: v0.16.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b2fdcff317e69322dafaf1ca24010e90e33184740972e588c62d24dea747dcb0 [INFO] running `Command { std: "docker" "start" "-a" "b2fdcff317e69322dafaf1ca24010e90e33184740972e588c62d24dea747dcb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b2fdcff317e69322dafaf1ca24010e90e33184740972e588c62d24dea747dcb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2fdcff317e69322dafaf1ca24010e90e33184740972e588c62d24dea747dcb0", kill_on_drop: false }` [INFO] [stdout] b2fdcff317e69322dafaf1ca24010e90e33184740972e588c62d24dea747dcb0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8729a3c0223192b91ae2aff13ad55a44e4d8e82a6b2c276c44b7f8d00d55dd8d [INFO] running `Command { std: "docker" "start" "-a" "8729a3c0223192b91ae2aff13ad55a44e4d8e82a6b2c276c44b7f8d00d55dd8d", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking bitfield v0.14.0 [INFO] [stderr] Checking xml-rs v0.8.21 [INFO] [stderr] Checking xmlwriter v0.1.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking geo v0.1.0 (/opt/rustwide/workdir/libs/geo) [INFO] [stderr] Checking cache v0.1.0 (/opt/rustwide/workdir/libs/cache) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:96:16 [INFO] [stdout] | [INFO] [stdout] 96 | if (s == e) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 96 - if (s == e) { [INFO] [stdout] 96 + if s == e { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | if (self.timetable[s].0 == *t) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 97 - if (self.timetable[s].0 == *t) { [INFO] [stdout] 97 + if self.timetable[s].0 == *t { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:96:16 [INFO] [stdout] | [INFO] [stdout] 96 | if (s == e) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 96 - if (s == e) { [INFO] [stdout] 96 + if s == e { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if ((t > &st) || (t < &et)) {return None} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 104 - if ((t > &st) || (t < &et)) {return None} [INFO] [stdout] 104 + if (t > &st) || (t < &et) {return None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:123:16 [INFO] [stdout] | [INFO] [stdout] 123 | if (s == e) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 123 - if (s == e) { [INFO] [stdout] 123 + if s == e { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:130:16 [INFO] [stdout] | [INFO] [stdout] 130 | if ((t.0 > st) || (t.0 < et)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 130 - if ((t.0 > st) || (t.0 < et)) { [INFO] [stdout] 130 + if (t.0 > st) || (t.0 < et) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:197:20 [INFO] [stdout] | [INFO] [stdout] 197 | if (l > self.life) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 197 - if (l > self.life) { [INFO] [stdout] 197 + if l > self.life { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | if (self.timetable[s].0 == *t) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 97 - if (self.timetable[s].0 == *t) { [INFO] [stdout] 97 + if self.timetable[s].0 == *t { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if ((t > &st) || (t < &et)) {return None} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 104 - if ((t > &st) || (t < &et)) {return None} [INFO] [stdout] 104 + if (t > &st) || (t < &et) {return None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:123:16 [INFO] [stdout] | [INFO] [stdout] 123 | if (s == e) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 123 - if (s == e) { [INFO] [stdout] 123 + if s == e { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:130:16 [INFO] [stdout] | [INFO] [stdout] 130 | if ((t.0 > st) || (t.0 < et)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 130 - if ((t.0 > st) || (t.0 < et)) { [INFO] [stdout] 130 + if (t.0 > st) || (t.0 < et) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/cache/src/cachedb.rs:197:20 [INFO] [stdout] | [INFO] [stdout] 197 | if (l > self.life) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 197 - if (l > self.life) { [INFO] [stdout] 197 + if l > self.life { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:69:53 [INFO] [stdout] | [INFO] [stdout] 69 | fn process_route(self: &mut Self) -> Option<(TrackRoute)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - fn process_route(self: &mut Self) -> Option<(TrackRoute)> { [INFO] [stdout] 69 + fn process_route(self: &mut Self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:69:53 [INFO] [stdout] | [INFO] [stdout] 69 | fn process_route(self: &mut Self) -> Option<(TrackRoute)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - fn process_route(self: &mut Self) -> Option<(TrackRoute)> { [INFO] [stdout] 69 + fn process_route(self: &mut Self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:91:28 [INFO] [stdout] | [INFO] [stdout] 91 | if (name.local_name == "trk") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 91 - if (name.local_name == "trk") { [INFO] [stdout] 91 + if name.local_name == "trk" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:91:28 [INFO] [stdout] | [INFO] [stdout] 91 | if (name.local_name == "trk") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 91 - if (name.local_name == "trk") { [INFO] [stdout] 91 + if name.local_name == "trk" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:95:28 [INFO] [stdout] | [INFO] [stdout] 95 | if (tag == name) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - if (tag == name) { [INFO] [stdout] 95 + if tag == name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:95:28 [INFO] [stdout] | [INFO] [stdout] 95 | if (tag == name) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - if (tag == name) { [INFO] [stdout] 95 + if tag == name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:133:28 [INFO] [stdout] | [INFO] [stdout] 133 | if (name.local_name == "extensions") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 133 - if (name.local_name == "extensions") { [INFO] [stdout] 133 + if name.local_name == "extensions" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:133:28 [INFO] [stdout] | [INFO] [stdout] 133 | if (name.local_name == "extensions") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 133 - if (name.local_name == "extensions") { [INFO] [stdout] 133 + if name.local_name == "extensions" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:158:28 [INFO] [stdout] | [INFO] [stdout] 158 | if (name.local_name == n) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 158 - if (name.local_name == n) { [INFO] [stdout] 158 + if name.local_name == n { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:158:28 [INFO] [stdout] | [INFO] [stdout] 158 | if (name.local_name == n) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 158 - if (name.local_name == n) { [INFO] [stdout] 158 + if name.local_name == n { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:171:55 [INFO] [stdout] | [INFO] [stdout] 171 | fn process_segment(self: &mut Self) -> Option<(TrackSegment)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 171 - fn process_segment(self: &mut Self) -> Option<(TrackSegment)> { [INFO] [stdout] 171 + fn process_segment(self: &mut Self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:188:28 [INFO] [stdout] | [INFO] [stdout] 188 | if (name.local_name == "trkseg") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 188 - if (name.local_name == "trkseg") { [INFO] [stdout] 188 + if name.local_name == "trkseg" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:171:55 [INFO] [stdout] | [INFO] [stdout] 171 | fn process_segment(self: &mut Self) -> Option<(TrackSegment)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 171 - fn process_segment(self: &mut Self) -> Option<(TrackSegment)> { [INFO] [stdout] 171 + fn process_segment(self: &mut Self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:192:28 [INFO] [stdout] | [INFO] [stdout] 192 | if (tag == name) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - if (tag == name) { [INFO] [stdout] 192 + if tag == name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:188:28 [INFO] [stdout] | [INFO] [stdout] 188 | if (name.local_name == "trkseg") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 188 - if (name.local_name == "trkseg") { [INFO] [stdout] 188 + if name.local_name == "trkseg" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:229:28 [INFO] [stdout] | [INFO] [stdout] 229 | if (lat.is_nan()) { lat = a.value.parse().unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 229 - if (lat.is_nan()) { lat = a.value.parse().unwrap();} [INFO] [stdout] 229 + if lat.is_nan() { lat = a.value.parse().unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:192:28 [INFO] [stdout] | [INFO] [stdout] 192 | if (tag == name) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - if (tag == name) { [INFO] [stdout] 192 + if tag == name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:233:28 [INFO] [stdout] | [INFO] [stdout] 233 | if (lon.is_nan()) { lon = a.value.parse().unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 233 - if (lon.is_nan()) { lon = a.value.parse().unwrap();} [INFO] [stdout] 233 + if lon.is_nan() { lon = a.value.parse().unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:229:28 [INFO] [stdout] | [INFO] [stdout] 229 | if (lat.is_nan()) { lat = a.value.parse().unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 229 - if (lat.is_nan()) { lat = a.value.parse().unwrap();} [INFO] [stdout] 229 + if lat.is_nan() { lat = a.value.parse().unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:239:16 [INFO] [stdout] | [INFO] [stdout] 239 | if (lat.is_nan() || lon.is_nan()) {return None;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 239 - if (lat.is_nan() || lon.is_nan()) {return None;} [INFO] [stdout] 239 + if lat.is_nan() || lon.is_nan() {return None;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:233:28 [INFO] [stdout] | [INFO] [stdout] 233 | if (lon.is_nan()) { lon = a.value.parse().unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 233 - if (lon.is_nan()) { lon = a.value.parse().unwrap();} [INFO] [stdout] 233 + if lon.is_nan() { lon = a.value.parse().unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:252:28 [INFO] [stdout] | [INFO] [stdout] 252 | if (name.local_name == "trkpt") {break;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 252 - if (name.local_name == "trkpt") {break;} [INFO] [stdout] 252 + if name.local_name == "trkpt" {break;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:239:16 [INFO] [stdout] | [INFO] [stdout] 239 | if (lat.is_nan() || lon.is_nan()) {return None;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 239 - if (lat.is_nan() || lon.is_nan()) {return None;} [INFO] [stdout] 239 + if lat.is_nan() || lon.is_nan() {return None;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:273:28 [INFO] [stdout] | [INFO] [stdout] 273 | if (name.local_name == "extensions") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 273 - if (name.local_name == "extensions") { [INFO] [stdout] 273 + if name.local_name == "extensions" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:252:28 [INFO] [stdout] | [INFO] [stdout] 252 | if (name.local_name == "trkpt") {break;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 252 - if (name.local_name == "trkpt") {break;} [INFO] [stdout] 252 + if name.local_name == "trkpt" {break;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:292:28 [INFO] [stdout] | [INFO] [stdout] 292 | if (name.local_name == "TrackPointExtension") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 292 - if (name.local_name == "TrackPointExtension") { [INFO] [stdout] 292 + if name.local_name == "TrackPointExtension" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:273:28 [INFO] [stdout] | [INFO] [stdout] 273 | if (name.local_name == "extensions") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 273 - if (name.local_name == "extensions") { [INFO] [stdout] 273 + if name.local_name == "extensions" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:332:64 [INFO] [stdout] | [INFO] [stdout] 332 | ... "weather" => { p.weather = Weather((str.parse::().unwrap()))} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 332 - "weather" => { p.weather = Weather((str.parse::().unwrap()))} [INFO] [stdout] 332 + "weather" => { p.weather = Weather(str.parse::().unwrap())} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:292:28 [INFO] [stdout] | [INFO] [stdout] 292 | if (name.local_name == "TrackPointExtension") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 292 - if (name.local_name == "TrackPointExtension") { [INFO] [stdout] 292 + if name.local_name == "TrackPointExtension" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:365:36 [INFO] [stdout] | [INFO] [stdout] 365 | ... if (error == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 365 - if (error == true) { [INFO] [stdout] 365 + if error == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:332:64 [INFO] [stdout] | [INFO] [stdout] 332 | ... "weather" => { p.weather = Weather((str.parse::().unwrap()))} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 332 - "weather" => { p.weather = Weather((str.parse::().unwrap()))} [INFO] [stdout] 332 + "weather" => { p.weather = Weather(str.parse::().unwrap())} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:375:28 [INFO] [stdout] | [INFO] [stdout] 375 | if (name.local_name.as_str() == tag) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 375 - if (name.local_name.as_str() == tag) { [INFO] [stdout] 375 + if name.local_name.as_str() == tag { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:365:36 [INFO] [stdout] | [INFO] [stdout] 365 | ... if (error == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 365 - if (error == true) { [INFO] [stdout] 365 + if error == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:176:24 [INFO] [stdout] | [INFO] [stdout] 176 | if ((!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 176 - if ((!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN)) { [INFO] [stdout] 176 + if (!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:375:28 [INFO] [stdout] | [INFO] [stdout] 375 | if (name.local_name.as_str() == tag) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 375 - if (name.local_name.as_str() == tag) { [INFO] [stdout] 375 + if name.local_name.as_str() == tag { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | if (!p.point.point_type.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 182 - if (!p.point.point_type.is_empty()) { [INFO] [stdout] 182 + if !p.point.point_type.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:176:24 [INFO] [stdout] | [INFO] [stdout] 176 | if ((!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 176 - if ((!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN)) { [INFO] [stdout] 176 + if (!p.point.wind.direction.is_nan()) && (p.point.wind.strong == u64::MIN) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Formatter` [INFO] [stdout] --> libs/geo/src/gpx.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fmt::Formatter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | if (!p.point.point_type.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 182 - if (!p.point.point_type.is_empty()) { [INFO] [stdout] 182 + if !p.point.point_type.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:202:16 [INFO] [stdout] | [INFO] [stdout] 202 | if (!self.heading.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 202 - if (!self.heading.is_nan()) {return true} [INFO] [stdout] 202 + if !self.heading.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Formatter` [INFO] [stdout] --> libs/geo/src/gpx.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fmt::Formatter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:203:16 [INFO] [stdout] | [INFO] [stdout] 203 | if (!self.pressure.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 - if (!self.pressure.is_nan()) {return true} [INFO] [stdout] 203 + if !self.pressure.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:202:16 [INFO] [stdout] | [INFO] [stdout] 202 | if (!self.heading.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 202 - if (!self.heading.is_nan()) {return true} [INFO] [stdout] 202 + if !self.heading.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:204:16 [INFO] [stdout] | [INFO] [stdout] 204 | if (!self.temperature.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 204 - if (!self.temperature.is_nan()) {return true} [INFO] [stdout] 204 + if !self.temperature.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:203:16 [INFO] [stdout] | [INFO] [stdout] 203 | if (!self.pressure.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 - if (!self.pressure.is_nan()) {return true} [INFO] [stdout] 203 + if !self.pressure.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:205:16 [INFO] [stdout] | [INFO] [stdout] 205 | if (!self.heart_rate.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 205 - if (!self.heart_rate.is_nan()) {return true} [INFO] [stdout] 205 + if !self.heart_rate.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:204:16 [INFO] [stdout] | [INFO] [stdout] 204 | if (!self.temperature.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 204 - if (!self.temperature.is_nan()) {return true} [INFO] [stdout] 204 + if !self.temperature.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:206:16 [INFO] [stdout] | [INFO] [stdout] 206 | if ((!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN)) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 206 - if ((!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN)) {return true} [INFO] [stdout] 206 + if (!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN) {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:205:16 [INFO] [stdout] | [INFO] [stdout] 205 | if (!self.heart_rate.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 205 - if (!self.heart_rate.is_nan()) {return true} [INFO] [stdout] 205 + if !self.heart_rate.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:207:16 [INFO] [stdout] | [INFO] [stdout] 207 | if (!self.luminance.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 207 - if (!self.luminance.is_nan()) {return true} [INFO] [stdout] 207 + if !self.luminance.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:206:16 [INFO] [stdout] | [INFO] [stdout] 206 | if ((!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN)) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 206 - if ((!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN)) {return true} [INFO] [stdout] 206 + if (!self.wind.direction.is_nan()) && (self.wind.strong == u64::MIN) {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:208:16 [INFO] [stdout] | [INFO] [stdout] 208 | if (!self.radiation.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 208 - if (!self.radiation.is_nan()) {return true} [INFO] [stdout] 208 + if !self.radiation.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:207:16 [INFO] [stdout] | [INFO] [stdout] 207 | if (!self.luminance.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 207 - if (!self.luminance.is_nan()) {return true} [INFO] [stdout] 207 + if !self.luminance.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:209:16 [INFO] [stdout] | [INFO] [stdout] 209 | if (!self.distance.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - if (!self.distance.is_nan()) {return true} [INFO] [stdout] 209 + if !self.distance.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:208:16 [INFO] [stdout] | [INFO] [stdout] 208 | if (!self.radiation.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 208 - if (!self.radiation.is_nan()) {return true} [INFO] [stdout] 208 + if !self.radiation.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:210:16 [INFO] [stdout] | [INFO] [stdout] 210 | if (!self.energy.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 210 - if (!self.energy.is_nan()) {return true} [INFO] [stdout] 210 + if !self.energy.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:209:16 [INFO] [stdout] | [INFO] [stdout] 209 | if (!self.distance.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - if (!self.distance.is_nan()) {return true} [INFO] [stdout] 209 + if !self.distance.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:211:16 [INFO] [stdout] | [INFO] [stdout] 211 | if (!self.cadence.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 211 - if (!self.cadence.is_nan()) {return true} [INFO] [stdout] 211 + if !self.cadence.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:212:16 [INFO] [stdout] | [INFO] [stdout] 212 | if (!self.pace.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 212 - if (!self.pace.is_nan()) {return true} [INFO] [stdout] 212 + if !self.pace.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:210:16 [INFO] [stdout] | [INFO] [stdout] 210 | if (!self.energy.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 210 - if (!self.energy.is_nan()) {return true} [INFO] [stdout] 210 + if !self.energy.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:213:16 [INFO] [stdout] | [INFO] [stdout] 213 | if (!self.vertical_speed.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - if (!self.vertical_speed.is_nan()) {return true} [INFO] [stdout] 213 + if !self.vertical_speed.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:211:16 [INFO] [stdout] | [INFO] [stdout] 211 | if (!self.cadence.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 211 - if (!self.cadence.is_nan()) {return true} [INFO] [stdout] 211 + if !self.cadence.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:214:16 [INFO] [stdout] | [INFO] [stdout] 214 | if (self.weather != Weather(Weather::NONE)) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 214 - if (self.weather != Weather(Weather::NONE)) {return true} [INFO] [stdout] 214 + if self.weather != Weather(Weather::NONE) {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:212:16 [INFO] [stdout] | [INFO] [stdout] 212 | if (!self.pace.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 212 - if (!self.pace.is_nan()) {return true} [INFO] [stdout] 212 + if !self.pace.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:213:16 [INFO] [stdout] | [INFO] [stdout] 213 | if (!self.vertical_speed.is_nan()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - if (!self.vertical_speed.is_nan()) {return true} [INFO] [stdout] 213 + if !self.vertical_speed.is_nan() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:215:16 [INFO] [stdout] | [INFO] [stdout] 215 | if (self.point_type.len() != 0) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 215 - if (self.point_type.len() != 0) {return true} [INFO] [stdout] 215 + if self.point_type.len() != 0 {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:214:16 [INFO] [stdout] | [INFO] [stdout] 214 | if (self.weather != Weather(Weather::NONE)) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 214 - if (self.weather != Weather(Weather::NONE)) {return true} [INFO] [stdout] 214 + if self.weather != Weather(Weather::NONE) {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:216:16 [INFO] [stdout] | [INFO] [stdout] 216 | if (!self.comment.is_empty()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 216 - if (!self.comment.is_empty()) {return true} [INFO] [stdout] 216 + if !self.comment.is_empty() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:215:16 [INFO] [stdout] | [INFO] [stdout] 215 | if (self.point_type.len() != 0) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 215 - if (self.point_type.len() != 0) {return true} [INFO] [stdout] 215 + if self.point_type.len() != 0 {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:217:16 [INFO] [stdout] | [INFO] [stdout] 217 | if (!self.name.is_empty()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 217 - if (!self.name.is_empty()) {return true} [INFO] [stdout] 217 + if !self.name.is_empty() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:216:16 [INFO] [stdout] | [INFO] [stdout] 216 | if (!self.comment.is_empty()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 216 - if (!self.comment.is_empty()) {return true} [INFO] [stdout] 216 + if !self.comment.is_empty() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:225:16 [INFO] [stdout] | [INFO] [stdout] 225 | if (!self.altitude.is_nan()) {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 225 - if (!self.altitude.is_nan()) {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] 225 + if !self.altitude.is_nan() {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:217:16 [INFO] [stdout] | [INFO] [stdout] 217 | if (!self.name.is_empty()) {return true} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 217 - if (!self.name.is_empty()) {return true} [INFO] [stdout] 217 + if !self.name.is_empty() {return true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:226:16 [INFO] [stdout] | [INFO] [stdout] 226 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 226 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 226 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:225:16 [INFO] [stdout] | [INFO] [stdout] 225 | if (!self.altitude.is_nan()) {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 225 - if (!self.altitude.is_nan()) {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] 225 + if !self.altitude.is_nan() {write!(f, "altitude: {}m", self.altitude).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:227:16 [INFO] [stdout] | [INFO] [stdout] 227 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 227 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 227 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:226:16 [INFO] [stdout] | [INFO] [stdout] 226 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 226 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 226 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:227:16 [INFO] [stdout] | [INFO] [stdout] 227 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 227 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 227 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:228:16 [INFO] [stdout] | [INFO] [stdout] 228 | if (!self.time.eq(&DateTime::::MIN_UTC)) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 228 - if (!self.time.eq(&DateTime::::MIN_UTC)) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] 228 + if !self.time.eq(&DateTime::::MIN_UTC) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:229:16 [INFO] [stdout] | [INFO] [stdout] 229 | if (!self.heading.is_nan()) {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 229 - if (!self.heading.is_nan()) {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] 229 + if !self.heading.is_nan() {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:228:16 [INFO] [stdout] | [INFO] [stdout] 228 | if (!self.time.eq(&DateTime::::MIN_UTC)) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 228 - if (!self.time.eq(&DateTime::::MIN_UTC)) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] 228 + if !self.time.eq(&DateTime::::MIN_UTC) {write!(f, "time: {:?}", self.time).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:230:16 [INFO] [stdout] | [INFO] [stdout] 230 | if (!self.pressure.is_nan()) {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 230 - if (!self.pressure.is_nan()) {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] 230 + if !self.pressure.is_nan() {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:229:16 [INFO] [stdout] | [INFO] [stdout] 229 | if (!self.heading.is_nan()) {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 229 - if (!self.heading.is_nan()) {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] 229 + if !self.heading.is_nan() {write!(f, "heading: {}", self.heading).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:230:16 [INFO] [stdout] | [INFO] [stdout] 230 | if (!self.pressure.is_nan()) {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 230 - if (!self.pressure.is_nan()) {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] 230 + if !self.pressure.is_nan() {write!(f, "pressure: {}hp", self.pressure).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:231:16 [INFO] [stdout] | [INFO] [stdout] 231 | if (!self.temperature.is_nan()) {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 231 - if (!self.temperature.is_nan()) {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] 231 + if !self.temperature.is_nan() {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if (!self.heart_rate.is_nan()) {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 232 - if (!self.heart_rate.is_nan()) {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] 232 + if !self.heart_rate.is_nan() {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:231:16 [INFO] [stdout] | [INFO] [stdout] 231 | if (!self.temperature.is_nan()) {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 231 - if (!self.temperature.is_nan()) {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] 231 + if !self.temperature.is_nan() {write!(f, "temperature: {}", self.temperature).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:233:16 [INFO] [stdout] | [INFO] [stdout] 233 | if (!self.luminance.is_nan()) {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 233 - if (!self.luminance.is_nan()) {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] 233 + if !self.luminance.is_nan() {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if (!self.heart_rate.is_nan()) {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 232 - if (!self.heart_rate.is_nan()) {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] 232 + if !self.heart_rate.is_nan() {write!(f, "heart nrate: {}bpm", self.heart_rate).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:234:16 [INFO] [stdout] | [INFO] [stdout] 234 | if (!self.radiation.is_nan()) {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 234 - if (!self.radiation.is_nan()) {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] 234 + if !self.radiation.is_nan() {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:233:16 [INFO] [stdout] | [INFO] [stdout] 233 | if (!self.luminance.is_nan()) {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 233 - if (!self.luminance.is_nan()) {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] 233 + if !self.luminance.is_nan() {write!(f, "luminance: {}lx", self.luminance).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:235:16 [INFO] [stdout] | [INFO] [stdout] 235 | if (self.weather != Weather(Weather::NONE)) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 235 - if (self.weather != Weather(Weather::NONE)) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] 235 + if self.weather != Weather(Weather::NONE) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:236:16 [INFO] [stdout] | [INFO] [stdout] 236 | if (self.point_type.len() != 0) {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 236 - if (self.point_type.len() != 0) {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] 236 + if self.point_type.len() != 0 {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:234:16 [INFO] [stdout] | [INFO] [stdout] 234 | if (!self.radiation.is_nan()) {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 234 - if (!self.radiation.is_nan()) {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] 234 + if !self.radiation.is_nan() {write!(f, "radiation: {}", self.radiation).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:282:16 [INFO] [stdout] | [INFO] [stdout] 282 | if (self.highest < p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 282 - if (self.highest < p.altitude) { [INFO] [stdout] 282 + if self.highest < p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:235:16 [INFO] [stdout] | [INFO] [stdout] 235 | if (self.weather != Weather(Weather::NONE)) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 235 - if (self.weather != Weather(Weather::NONE)) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] 235 + if self.weather != Weather(Weather::NONE) {write!(f, "time: {:?}", &self.weather_str()).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:285:16 [INFO] [stdout] | [INFO] [stdout] 285 | if (self.lowest > p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 285 - if (self.lowest > p.altitude) { [INFO] [stdout] 285 + if self.lowest > p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:236:16 [INFO] [stdout] | [INFO] [stdout] 236 | if (self.point_type.len() != 0) {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 236 - if (self.point_type.len() != 0) {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] 236 + if self.point_type.len() != 0 {write!(f, "time: {:?}", &self.type_str()).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | if (self.lowest > seg.lowest) {self.lowest = seg.lowest} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 301 - if (self.lowest > seg.lowest) {self.lowest = seg.lowest} [INFO] [stdout] 301 + if self.lowest > seg.lowest {self.lowest = seg.lowest} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:282:16 [INFO] [stdout] | [INFO] [stdout] 282 | if (self.highest < p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 282 - if (self.highest < p.altitude) { [INFO] [stdout] 282 + if self.highest < p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:285:16 [INFO] [stdout] | [INFO] [stdout] 285 | if (self.lowest > p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 285 - if (self.lowest > p.altitude) { [INFO] [stdout] 285 + if self.lowest > p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:302:16 [INFO] [stdout] | [INFO] [stdout] 302 | if (self.highest < seg.highest) {self.highest = seg.highest} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 302 - if (self.highest < seg.highest) {self.highest = seg.highest} [INFO] [stdout] 302 + if self.highest < seg.highest {self.highest = seg.highest} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:321:16 [INFO] [stdout] | [INFO] [stdout] 321 | if (self.highest < segment.highest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 321 - if (self.highest < segment.highest) { [INFO] [stdout] 321 + if self.highest < segment.highest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | if (self.lowest > seg.lowest) {self.lowest = seg.lowest} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 301 - if (self.lowest > seg.lowest) {self.lowest = seg.lowest} [INFO] [stdout] 301 + if self.lowest > seg.lowest {self.lowest = seg.lowest} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:302:16 [INFO] [stdout] | [INFO] [stdout] 302 | if (self.highest < seg.highest) {self.highest = seg.highest} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 302 - if (self.highest < seg.highest) {self.highest = seg.highest} [INFO] [stdout] 302 + if self.highest < seg.highest {self.highest = seg.highest} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:324:16 [INFO] [stdout] | [INFO] [stdout] 324 | if (self.lowest > segment.lowest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 324 - if (self.lowest > segment.lowest) { [INFO] [stdout] 324 + if self.lowest > segment.lowest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:327:16 [INFO] [stdout] | [INFO] [stdout] 327 | if (self.points.len() == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 327 - if (self.points.len() == 0) { [INFO] [stdout] 327 + if self.points.len() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:321:16 [INFO] [stdout] | [INFO] [stdout] 321 | if (self.highest < segment.highest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 321 - if (self.highest < segment.highest) { [INFO] [stdout] 321 + if self.highest < segment.highest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:324:16 [INFO] [stdout] | [INFO] [stdout] 324 | if (self.lowest > segment.lowest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 324 - if (self.lowest > segment.lowest) { [INFO] [stdout] 324 + if self.lowest > segment.lowest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:330:23 [INFO] [stdout] | [INFO] [stdout] 330 | } else if (i == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 330 - } else if (i == 0) { [INFO] [stdout] 330 + } else if i == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:391:27 [INFO] [stdout] | [INFO] [stdout] 391 | } else if (i != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 391 - } else if (i != 0) { [INFO] [stdout] 391 + } else if i != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:327:16 [INFO] [stdout] | [INFO] [stdout] 327 | if (self.points.len() == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 327 - if (self.points.len() == 0) { [INFO] [stdout] 327 + if self.points.len() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:402:16 [INFO] [stdout] | [INFO] [stdout] 402 | if (self.points.len() < i) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 402 - if (self.points.len() < i) { [INFO] [stdout] 402 + if self.points.len() < i { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:405:16 [INFO] [stdout] | [INFO] [stdout] 405 | if (self.highest < p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 405 - if (self.highest < p.altitude) { [INFO] [stdout] 405 + if self.highest < p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:330:23 [INFO] [stdout] | [INFO] [stdout] 330 | } else if (i == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 330 - } else if (i == 0) { [INFO] [stdout] 330 + } else if i == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:408:16 [INFO] [stdout] | [INFO] [stdout] 408 | if (self.lowest > p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 408 - if (self.lowest > p.altitude) { [INFO] [stdout] 408 + if self.lowest > p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:391:27 [INFO] [stdout] | [INFO] [stdout] 391 | } else if (i != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 391 - } else if (i != 0) { [INFO] [stdout] 391 + } else if i != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:402:16 [INFO] [stdout] | [INFO] [stdout] 402 | if (self.points.len() < i) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 402 - if (self.points.len() < i) { [INFO] [stdout] 402 + if self.points.len() < i { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:412:16 [INFO] [stdout] | [INFO] [stdout] 412 | if (self.points.len() != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 412 - if (self.points.len() != 0) { [INFO] [stdout] 412 + if self.points.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:405:16 [INFO] [stdout] | [INFO] [stdout] 405 | if (self.highest < p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 405 - if (self.highest < p.altitude) { [INFO] [stdout] 405 + if self.highest < p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:414:20 [INFO] [stdout] | [INFO] [stdout] 414 | if (i != (self.points.len() - 1)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 414 - if (i != (self.points.len() - 1)) { [INFO] [stdout] 414 + if i != (self.points.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:408:16 [INFO] [stdout] | [INFO] [stdout] 408 | if (self.lowest > p.altitude) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 408 - if (self.lowest > p.altitude) { [INFO] [stdout] 408 + if self.lowest > p.altitude { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:420:20 [INFO] [stdout] | [INFO] [stdout] 420 | if (i != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 420 - if (i != 0) { [INFO] [stdout] 420 + if i != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:412:16 [INFO] [stdout] | [INFO] [stdout] 412 | if (self.points.len() != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 412 - if (self.points.len() != 0) { [INFO] [stdout] 412 + if self.points.len() != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:432:16 [INFO] [stdout] | [INFO] [stdout] 432 | if (self.points.len() < i) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 432 - if (self.points.len() < i) { [INFO] [stdout] 432 + if self.points.len() < i { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:437:16 [INFO] [stdout] | [INFO] [stdout] 437 | if (self.points.len() > 1) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 437 - if (self.points.len() > 1) { [INFO] [stdout] 437 + if self.points.len() > 1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:414:20 [INFO] [stdout] | [INFO] [stdout] 414 | if (i != (self.points.len() - 1)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 414 - if (i != (self.points.len() - 1)) { [INFO] [stdout] 414 + if i != (self.points.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:439:20 [INFO] [stdout] | [INFO] [stdout] 439 | if (i == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 439 - if (i == 0) { [INFO] [stdout] 439 + if i == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:420:20 [INFO] [stdout] | [INFO] [stdout] 420 | if (i != 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 420 - if (i != 0) { [INFO] [stdout] 420 + if i != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:432:16 [INFO] [stdout] | [INFO] [stdout] 432 | if (self.points.len() < i) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 432 - if (self.points.len() < i) { [INFO] [stdout] 432 + if self.points.len() < i { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:452:16 [INFO] [stdout] | [INFO] [stdout] 452 | if (p.location.lat > self.area.north_west.lat) {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 452 - if (p.location.lat > self.area.north_west.lat) {} [INFO] [stdout] 452 + if p.location.lat > self.area.north_west.lat {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:458:20 [INFO] [stdout] | [INFO] [stdout] 458 | if (p.point.altitude < self.lowest) {self.lowest = p.point.altitude;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 458 - if (p.point.altitude < self.lowest) {self.lowest = p.point.altitude;} [INFO] [stdout] 458 + if p.point.altitude < self.lowest {self.lowest = p.point.altitude;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:437:16 [INFO] [stdout] | [INFO] [stdout] 437 | if (self.points.len() > 1) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 437 - if (self.points.len() > 1) { [INFO] [stdout] 437 + if self.points.len() > 1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:439:20 [INFO] [stdout] | [INFO] [stdout] 439 | if (i == 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 439 - if (i == 0) { [INFO] [stdout] 439 + if i == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:459:20 [INFO] [stdout] | [INFO] [stdout] 459 | if (p.point.altitude > self.highest) {self.highest = p.point.altitude;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 459 - if (p.point.altitude > self.highest) {self.highest = p.point.altitude;} [INFO] [stdout] 459 + if p.point.altitude > self.highest {self.highest = p.point.altitude;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:452:16 [INFO] [stdout] | [INFO] [stdout] 452 | if (p.location.lat > self.area.north_west.lat) {} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 452 - if (p.location.lat > self.area.north_west.lat) {} [INFO] [stdout] 452 + if p.location.lat > self.area.north_west.lat {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:467:16 [INFO] [stdout] | [INFO] [stdout] 467 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 467 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 467 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:458:20 [INFO] [stdout] | [INFO] [stdout] 458 | if (p.point.altitude < self.lowest) {self.lowest = p.point.altitude;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 458 - if (p.point.altitude < self.lowest) {self.lowest = p.point.altitude;} [INFO] [stdout] 458 + if p.point.altitude < self.lowest {self.lowest = p.point.altitude;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:468:16 [INFO] [stdout] | [INFO] [stdout] 468 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 468 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 468 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:472:16 [INFO] [stdout] | [INFO] [stdout] 472 | if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 472 - if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] 472 + if !self.highest.is_nan() {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:459:20 [INFO] [stdout] | [INFO] [stdout] 459 | if (p.point.altitude > self.highest) {self.highest = p.point.altitude;} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 459 - if (p.point.altitude > self.highest) {self.highest = p.point.altitude;} [INFO] [stdout] 459 + if p.point.altitude > self.highest {self.highest = p.point.altitude;} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:473:16 [INFO] [stdout] | [INFO] [stdout] 473 | if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 473 - if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] 473 + if !self.lowest.is_nan() {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:500:16 [INFO] [stdout] | [INFO] [stdout] 500 | if (segment.lowest < self.lowest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 500 - if (segment.lowest < self.lowest) { [INFO] [stdout] 500 + if segment.lowest < self.lowest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:467:16 [INFO] [stdout] | [INFO] [stdout] 467 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 467 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 467 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:504:16 [INFO] [stdout] | [INFO] [stdout] 504 | if (segment.highest < self.highest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 504 - if (segment.highest < self.highest) { [INFO] [stdout] 504 + if segment.highest < self.highest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:468:16 [INFO] [stdout] | [INFO] [stdout] 468 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 468 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 468 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:472:16 [INFO] [stdout] | [INFO] [stdout] 472 | if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 472 - if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] 472 + if !self.highest.is_nan() {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:515:16 [INFO] [stdout] | [INFO] [stdout] 515 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 515 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 515 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:516:16 [INFO] [stdout] | [INFO] [stdout] 516 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 516 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 516 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:473:16 [INFO] [stdout] | [INFO] [stdout] 473 | if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 473 - if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] 473 + if !self.lowest.is_nan() {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:500:16 [INFO] [stdout] | [INFO] [stdout] 500 | if (segment.lowest < self.lowest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 500 - if (segment.lowest < self.lowest) { [INFO] [stdout] 500 + if segment.lowest < self.lowest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:520:16 [INFO] [stdout] | [INFO] [stdout] 520 | if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 520 - if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] 520 + if !self.highest.is_nan() {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:521:16 [INFO] [stdout] | [INFO] [stdout] 521 | if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 521 - if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] 521 + if !self.lowest.is_nan() {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:504:16 [INFO] [stdout] | [INFO] [stdout] 504 | if (segment.highest < self.highest) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 504 - if (segment.highest < self.highest) { [INFO] [stdout] 504 + if segment.highest < self.highest { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:522:16 [INFO] [stdout] | [INFO] [stdout] 522 | if (!self.distance.is_nan()) {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 522 - if (!self.distance.is_nan()) {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] 522 + if !self.distance.is_nan() {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:515:16 [INFO] [stdout] | [INFO] [stdout] 515 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 515 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 515 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:567:16 [INFO] [stdout] | [INFO] [stdout] 567 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 567 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 567 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:516:16 [INFO] [stdout] | [INFO] [stdout] 516 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 516 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 516 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:520:16 [INFO] [stdout] | [INFO] [stdout] 520 | if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 520 - if (!self.highest.is_nan()) {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] 520 + if !self.highest.is_nan() {write!(f, "time: {}", self.highest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:568:16 [INFO] [stdout] | [INFO] [stdout] 568 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 568 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 568 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::integer::sqrt` [INFO] [stdout] --> libs/geo/src/geometry.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | use num::integer::sqrt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:521:16 [INFO] [stdout] | [INFO] [stdout] 521 | if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 521 - if (!self.lowest.is_nan()) {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] 521 + if !self.lowest.is_nan() {write!(f, "time: {}", self.lowest).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | if (location.lat > self.north_west.lat) {self.north_west.lat = location.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - if (location.lat > self.north_west.lat) {self.north_west.lat = location.lat} [INFO] [stdout] 58 + if location.lat > self.north_west.lat {self.north_west.lat = location.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:522:16 [INFO] [stdout] | [INFO] [stdout] 522 | if (!self.distance.is_nan()) {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 522 - if (!self.distance.is_nan()) {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] 522 + if !self.distance.is_nan() {write!(f, "time: {}", self.distance).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if (location.lon < self.north_west.lon) {self.north_west.lon = location.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - if (location.lon < self.north_west.lon) {self.north_west.lon = location.lon} [INFO] [stdout] 59 + if location.lon < self.north_west.lon {self.north_west.lon = location.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:567:16 [INFO] [stdout] | [INFO] [stdout] 567 | if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 567 - if (self.name != "") {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] 567 + if self.name != "" {write!(f, "name: {:?}", self.name).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if (location.lat < self.south_east.lat) {self.south_east.lat = location.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - if (location.lat < self.south_east.lat) {self.south_east.lat = location.lat} [INFO] [stdout] 60 + if location.lat < self.south_east.lat {self.south_east.lat = location.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/gpx.rs:568:16 [INFO] [stdout] | [INFO] [stdout] 568 | if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 568 - if (self.comment != "") {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] 568 + if self.comment != "" {write!(f, "comment: {:?}", self.comment).unwrap();} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:61:16 [INFO] [stdout] | [INFO] [stdout] 61 | if (location.lon > self.south_east.lon) {self.south_east.lon = location.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 61 - if (location.lon > self.south_east.lon) {self.south_east.lon = location.lon} [INFO] [stdout] 61 + if location.lon > self.south_east.lon {self.south_east.lon = location.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::integer::sqrt` [INFO] [stdout] --> libs/geo/src/geometry.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | use num::integer::sqrt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | if (area.north_west.lat > self.north_west.lat) {self.north_west.lat = area.north_west.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - if (area.north_west.lat > self.north_west.lat) {self.north_west.lat = area.north_west.lat} [INFO] [stdout] 65 + if area.north_west.lat > self.north_west.lat {self.north_west.lat = area.north_west.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | if (location.lat > self.north_west.lat) {self.north_west.lat = location.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - if (location.lat > self.north_west.lat) {self.north_west.lat = location.lat} [INFO] [stdout] 58 + if location.lat > self.north_west.lat {self.north_west.lat = location.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | if (area.north_west.lon < self.north_west.lon) {self.north_west.lon = area.north_west.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - if (area.north_west.lon < self.north_west.lon) {self.north_west.lon = area.north_west.lon} [INFO] [stdout] 66 + if area.north_west.lon < self.north_west.lon {self.north_west.lon = area.north_west.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if (location.lon < self.north_west.lon) {self.north_west.lon = location.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - if (location.lon < self.north_west.lon) {self.north_west.lon = location.lon} [INFO] [stdout] 59 + if location.lon < self.north_west.lon {self.north_west.lon = location.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | if (area.south_east.lat < self.south_east.lat) {self.south_east.lat = area.south_east.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - if (area.south_east.lat < self.south_east.lat) {self.south_east.lat = area.south_east.lat} [INFO] [stdout] 67 + if area.south_east.lat < self.south_east.lat {self.south_east.lat = area.south_east.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if (location.lat < self.south_east.lat) {self.south_east.lat = location.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - if (location.lat < self.south_east.lat) {self.south_east.lat = location.lat} [INFO] [stdout] 60 + if location.lat < self.south_east.lat {self.south_east.lat = location.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if (area.south_east.lon > self.south_east.lon) {self.south_east.lon = area.south_east.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 68 - if (area.south_east.lon > self.south_east.lon) {self.south_east.lon = area.south_east.lon} [INFO] [stdout] 68 + if area.south_east.lon > self.south_east.lon {self.south_east.lon = area.south_east.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:61:16 [INFO] [stdout] | [INFO] [stdout] 61 | if (location.lon > self.south_east.lon) {self.south_east.lon = location.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 61 - if (location.lon > self.south_east.lon) {self.south_east.lon = location.lon} [INFO] [stdout] 61 + if location.lon > self.south_east.lon {self.south_east.lon = location.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:72:16 [INFO] [stdout] | [INFO] [stdout] 72 | if ((area.north_west.lat > self.north_west.lat) && (area.south_east.lat < self.south_east.lat) [INFO] [stdout] | ^ [INFO] [stdout] 73 | && (area.north_west.lon < self.north_west.lon) && (area.south_east.lon > self.south_east.lon)) { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 72 ~ if (area.north_west.lat > self.north_west.lat) && (area.south_east.lat < self.south_east.lat) [INFO] [stdout] 73 ~ && (area.north_west.lon < self.north_west.lon) && (area.south_east.lon > self.south_east.lon) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | if (area.north_west.lat > self.north_west.lat) {self.north_west.lat = area.north_west.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - if (area.north_west.lat > self.north_west.lat) {self.north_west.lat = area.north_west.lat} [INFO] [stdout] 65 + if area.north_west.lat > self.north_west.lat {self.north_west.lat = area.north_west.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | if (area.north_west.lon < self.north_west.lon) {self.north_west.lon = area.north_west.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - if (area.north_west.lon < self.north_west.lon) {self.north_west.lon = area.north_west.lon} [INFO] [stdout] 66 + if area.north_west.lon < self.north_west.lon {self.north_west.lon = area.north_west.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | if (area.south_east.lat < self.south_east.lat) {self.south_east.lat = area.south_east.lat} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - if (area.south_east.lat < self.south_east.lat) {self.south_east.lat = area.south_east.lat} [INFO] [stdout] 67 + if area.south_east.lat < self.south_east.lat {self.south_east.lat = area.south_east.lat} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if (area.south_east.lon > self.south_east.lon) {self.south_east.lon = area.south_east.lon} [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 68 - if (area.south_east.lon > self.south_east.lon) {self.south_east.lon = area.south_east.lon} [INFO] [stdout] 68 + if area.south_east.lon > self.south_east.lon {self.south_east.lon = area.south_east.lon} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> libs/geo/src/geometry.rs:72:16 [INFO] [stdout] | [INFO] [stdout] 72 | if ((area.north_west.lat > self.north_west.lat) && (area.south_east.lat < self.south_east.lat) [INFO] [stdout] | ^ [INFO] [stdout] 73 | && (area.north_west.lon < self.north_west.lon) && (area.south_east.lon > self.south_east.lon)) { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 72 ~ if (area.north_west.lat > self.north_west.lat) && (area.south_east.lat < self.south_east.lat) [INFO] [stdout] 73 ~ && (area.north_west.lon < self.north_west.lon) && (area.south_east.lon > self.south_east.lon) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/cache/src/cachedb.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | let mut f = File::open(path)?; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/cache/src/cachedb.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | let mut f = File::open(path)?; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/cache/src/cachedb.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 225 | let mut p = p.to_path_buf(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/cache/src/cachedb.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 225 | let mut p = p.to_path_buf(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `FileAttr` is more private than the item `Cache::get_attr` [INFO] [stdout] --> libs/cache/src/cachedb.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn get_attr(self: &Self, path: &OsString) -> Option<&FileAttr> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `Cache::get_attr` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileAttr` is only usable at visibility `pub(self)` [INFO] [stdout] --> libs/cache/src/cachedb.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | struct FileAttr { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `FileAttr` is more private than the item `Cache::set_path_sub` [INFO] [stdout] --> libs/cache/src/cachedb.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | / pub fn set_path_sub(path: &String, [INFO] [stdout] 221 | | create: bool, [INFO] [stdout] 222 | | list: &mut HashMap, [INFO] [stdout] 223 | | timetable: &mut Vec<(SystemTime, OsString)>) -> Result { [INFO] [stdout] | |_______________________________________________________________________________________________^ associated function `Cache::set_path_sub` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileAttr` is only usable at visibility `pub(self)` [INFO] [stdout] --> libs/cache/src/cachedb.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | struct FileAttr { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `parse` is never used [INFO] [stdout] --> libs/cache/src/cachedb.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl FileAttr { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 40 | fn parse(&self) -> Result<(i64, i64, i64), ParseIntError> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `FileAttr` is more private than the item `Cache::get_attr` [INFO] [stdout] --> libs/cache/src/cachedb.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn get_attr(self: &Self, path: &OsString) -> Option<&FileAttr> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `Cache::get_attr` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileAttr` is only usable at visibility `pub(self)` [INFO] [stdout] --> libs/cache/src/cachedb.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | struct FileAttr { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `quick_find`, `quick_find_sub`, and `add` are never used [INFO] [stdout] --> libs/cache/src/cachedb.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 81 | impl Cache { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | fn quick_find(self: &Self, t: &SystemTime) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 95 | fn quick_find_sub(self: &Self, t: &SystemTime, s: usize, e:usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 141 | fn add(self: &mut Self, path: &PathBuf, attr: FileAttr) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `FileAttr` is more private than the item `Cache::set_path_sub` [INFO] [stdout] --> libs/cache/src/cachedb.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | / pub fn set_path_sub(path: &String, [INFO] [stdout] 221 | | create: bool, [INFO] [stdout] 222 | | list: &mut HashMap, [INFO] [stdout] 223 | | timetable: &mut Vec<(SystemTime, OsString)>) -> Result { [INFO] [stdout] | |_______________________________________________________________________________________________^ associated function `Cache::set_path_sub` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileAttr` is only usable at visibility `pub(self)` [INFO] [stdout] --> libs/cache/src/cachedb.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | struct FileAttr { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `parse` is never used [INFO] [stdout] --> libs/cache/src/cachedb.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl FileAttr { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 40 | fn parse(&self) -> Result<(i64, i64, i64), ParseIntError> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `quick_find`, `quick_find_sub`, and `add` are never used [INFO] [stdout] --> libs/cache/src/cachedb.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 81 | impl Cache { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | fn quick_find(self: &Self, t: &SystemTime) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 95 | fn quick_find_sub(self: &Self, t: &SystemTime, s: usize, e:usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 141 | fn add(self: &mut Self, path: &PathBuf, attr: FileAttr) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bitfield::BitRangeMut` [INFO] [stdout] --> libs/geo/src/gpx.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | use bitfield::BitRangeMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/geometry.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | let mut route = self.process_gpx(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:344:41 [INFO] [stdout] | [INFO] [stdout] 344 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:352:41 [INFO] [stdout] | [INFO] [stdout] 352 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:360:41 [INFO] [stdout] | [INFO] [stdout] 360 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bitfield::BitRangeMut` [INFO] [stdout] --> libs/geo/src/gpx.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | use bitfield::BitRangeMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/gpx.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::complex::ComplexFloat` [INFO] [stdout] --> libs/geo/src/geometry.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | use num::complex::ComplexFloat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | let mut route = self.process_gpx(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:344:41 [INFO] [stdout] | [INFO] [stdout] 344 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:352:41 [INFO] [stdout] | [INFO] [stdout] 352 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:360:41 [INFO] [stdout] | [INFO] [stdout] 360 | ... error = false; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx.rs:378:21 [INFO] [stdout] | [INFO] [stdout] 378 | let mut p = &mut self.points[usize::from(i)]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx.rs:416:25 [INFO] [stdout] | [INFO] [stdout] 416 | let mut n = &mut self.points[i + 1]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `min` [INFO] [stdout] --> libs/geo/src/geometry.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | let min = self.alt.min(p.alt); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_min` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `file` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Parser { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 15 | file: OsString, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 22 | let file = File::open(name).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let file = BufReader::new(file); // Buffering is important for performance [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Some(Parser {file: name.clone(), parser: EventReader::new(file)}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | self.file.write(a.as_ref()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = self.file.write(a.as_ref()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx.rs:378:21 [INFO] [stdout] | [INFO] [stdout] 378 | let mut p = &mut self.points[usize::from(i)]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libs/geo/src/gpx.rs:416:25 [INFO] [stdout] | [INFO] [stdout] 416 | let mut n = &mut self.points[i + 1]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 106 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `min` [INFO] [stdout] --> libs/geo/src/geometry.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | let min = self.alt.min(p.alt); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_min` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `file` is never read [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Parser { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 15 | file: OsString, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `geo` (lib) due to 2 previous errors; 106 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libs/geo/src/gpx_parser.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 22 | let file = File::open(name).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let file = BufReader::new(file); // Buffering is important for performance [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Some(Parser {file: name.clone(), parser: EventReader::new(file)}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> libs/geo/src/gpx_writer.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | self.file.write(a.as_ref()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = self.file.write(a.as_ref()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 106 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `geo` (lib test) due to 2 previous errors; 106 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8729a3c0223192b91ae2aff13ad55a44e4d8e82a6b2c276c44b7f8d00d55dd8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8729a3c0223192b91ae2aff13ad55a44e4d8e82a6b2c276c44b7f8d00d55dd8d", kill_on_drop: false }` [INFO] [stdout] 8729a3c0223192b91ae2aff13ad55a44e4d8e82a6b2c276c44b7f8d00d55dd8d