[INFO] cloning repository https://github.com/palant/pfp-cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/palant/pfp-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpalant%2Fpfp-cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpalant%2Fpfp-cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1b475c062a84aaf715d01c784c327c1830c438b3 [INFO] checking palant/pfp-cli against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpalant%2Fpfp-cli" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/palant/pfp-cli on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/palant/pfp-cli [INFO] finished tweaking git repo https://github.com/palant/pfp-cli [INFO] tweaked toml for git repo https://github.com/palant/pfp-cli written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/palant/pfp-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded question v0.2.2 [INFO] [stderr] Downloaded os_pipe v1.0.1 [INFO] [stderr] Downloaded read-process-memory v0.1.4 [INFO] [stderr] Downloaded system-interface v0.21.0 [INFO] [stderr] Downloaded app_dirs2 v2.4.0 [INFO] [stderr] Downloaded fs-set-times v0.17.1 [INFO] [stderr] Downloaded io-lifetimes v0.7.2 [INFO] [stderr] Downloaded cap-primitives v0.25.2 [INFO] [stderr] Downloaded io-streams v0.12.0 [INFO] [stderr] Downloaded cap-std v0.25.2 [INFO] [stderr] Downloaded io-extras v0.15.0 [INFO] [stderr] Downloaded socketpair v0.16.0 [INFO] [stderr] Downloaded winx v0.33.0 [INFO] [stderr] Downloaded rustix v0.35.7 [INFO] [stderr] Downloaded duplex v0.13.0 [INFO] [stderr] Downloaded cap-fs-ext v0.25.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c1bb980e525eaf0034e27a7a2c66bc4481ee58715efc3085854a39a9a806cec [INFO] running `Command { std: "docker" "start" "-a" "2c1bb980e525eaf0034e27a7a2c66bc4481ee58715efc3085854a39a9a806cec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c1bb980e525eaf0034e27a7a2c66bc4481ee58715efc3085854a39a9a806cec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c1bb980e525eaf0034e27a7a2c66bc4481ee58715efc3085854a39a9a806cec", kill_on_drop: false }` [INFO] [stdout] 2c1bb980e525eaf0034e27a7a2c66bc4481ee58715efc3085854a39a9a806cec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 72f68a857fc130dd44a6d34d1a6e17bfb62f37edfdd9eb857786efc7adb386d1 [INFO] running `Command { std: "docker" "start" "-a" "72f68a857fc130dd44a6d34d1a6e17bfb62f37edfdd9eb857786efc7adb386d1", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling io-lifetimes v0.7.2 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling rustix v0.35.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking linux-raw-sys v0.0.46 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling io-extras v0.15.0 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling socketpair v0.16.0 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Checking zeroize v1.5.6 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling system-interface v0.21.0 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking os_pipe v1.0.1 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking polyval v0.5.3 [INFO] [stderr] Checking cipher v0.4.3 [INFO] [stderr] Checking ctr v0.8.0 [INFO] [stderr] Checking ghash v0.4.4 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking aead v0.4.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling backtrace v0.3.66 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking scrypt v0.10.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking aes-gcm v0.9.4 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking wildmatch v2.1.0 [INFO] [stderr] Compiling io-streams v0.12.0 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking xdg v2.4.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking object v0.29.0 [INFO] [stderr] Checking fd-lock v3.0.6 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Compiling proc-maps v0.2.1 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking duplex v0.13.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking parking v2.0.0 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking app_dirs2 v2.4.0 [INFO] [stderr] Checking question v0.2.2 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Checking qrcodegen v1.8.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking read-process-memory v0.1.4 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking subprocess v0.2.9 [INFO] [stderr] Checking memmem v0.1.1 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking shellwords v1.1.0 [INFO] [stderr] Compiling clap_derive v3.2.7 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling enumset_derive v0.6.0 [INFO] [stderr] Checking rustyline v9.1.2 [INFO] [stderr] Checking clap v3.2.11 [INFO] [stderr] Checking enumset v1.0.11 [INFO] [stderr] Checking rpassword v6.0.1 [INFO] [stderr] Checking pfp v0.1.0 (/opt/rustwide/workdir/pfp) [INFO] [stdout] warning: unused imports: `Value` and `json` [INFO] [stdout] --> pfp/src/json/mod.rs:10:44 [INFO] [stdout] | [INFO] [stdout] 10 | pub use serde_json::{from_slice, from_str, json, to_string, to_vec, Error, Value}; [INFO] [stdout] | ^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking pfp-cli v0.1.0 (/opt/rustwide/workdir/cli) [INFO] [stdout] warning: unexpected `cfg` condition name: `leaking_alloc` [INFO] [stdout] --> cli/src/main.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | #[cfg(leaking_alloc)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(leaking_alloc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(leaking_alloc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `logging_alloc` [INFO] [stdout] --> cli/src/main.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | #[cfg(logging_alloc)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(logging_alloc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(logging_alloc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `logging_alloc` [INFO] [stdout] --> cli/src/main.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | #[cfg(logging_alloc)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(logging_alloc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(logging_alloc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `logging_alloc` [INFO] [stdout] --> cli/src/main.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | #[cfg(not(logging_alloc))] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(logging_alloc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(logging_alloc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `logging_alloc` [INFO] [stdout] --> cli/src/main.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 22 | #[cfg(not(logging_alloc))] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(logging_alloc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(logging_alloc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `leaking_alloc` [INFO] [stdout] --> cli/src/main.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | #[cfg(leaking_alloc)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(leaking_alloc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(leaking_alloc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `logging_alloc` [INFO] [stdout] --> cli/src/main.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | #[cfg(logging_alloc)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(logging_alloc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(logging_alloc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `logging_alloc` [INFO] [stdout] --> cli/src/main.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | #[cfg(logging_alloc)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(logging_alloc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(logging_alloc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `logging_alloc` [INFO] [stdout] --> cli/src/main.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | #[cfg(not(logging_alloc))] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(logging_alloc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(logging_alloc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `logging_alloc` [INFO] [stdout] --> cli/src/main.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 22 | #[cfg(not(logging_alloc))] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(logging_alloc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(logging_alloc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [optimized + debuginfo] target(s) in 10.05s [INFO] running `Command { std: "docker" "inspect" "72f68a857fc130dd44a6d34d1a6e17bfb62f37edfdd9eb857786efc7adb386d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72f68a857fc130dd44a6d34d1a6e17bfb62f37edfdd9eb857786efc7adb386d1", kill_on_drop: false }` [INFO] [stdout] 72f68a857fc130dd44a6d34d1a6e17bfb62f37edfdd9eb857786efc7adb386d1 [INFO] checking palant/pfp-cli against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpalant%2Fpfp-cli" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/palant/pfp-cli on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/palant/pfp-cli [INFO] finished tweaking git repo https://github.com/palant/pfp-cli [INFO] tweaked toml for git repo https://github.com/palant/pfp-cli written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/palant/pfp-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 70380dbfa9506a461a03b15f9edbd96ef25a2e55017835eddba7ee28668f4574 [INFO] running `Command { std: "docker" "start" "-a" "70380dbfa9506a461a03b15f9edbd96ef25a2e55017835eddba7ee28668f4574", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "70380dbfa9506a461a03b15f9edbd96ef25a2e55017835eddba7ee28668f4574", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70380dbfa9506a461a03b15f9edbd96ef25a2e55017835eddba7ee28668f4574", kill_on_drop: false }` [INFO] [stdout] 70380dbfa9506a461a03b15f9edbd96ef25a2e55017835eddba7ee28668f4574 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a94268794795cbf3f99f985e95a0d061515346c317a8da64b0f9726f8b6792ef [INFO] running `Command { std: "docker" "start" "-a" "a94268794795cbf3f99f985e95a0d061515346c317a8da64b0f9726f8b6792ef", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling io-lifetimes v0.7.2 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling rustix v0.35.7 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Checking linux-raw-sys v0.0.46 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling io-extras v0.15.0 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling socketpair v0.16.0 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Checking zeroize v1.5.6 [INFO] [stderr] Compiling system-interface v0.21.0 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking os_pipe v1.0.1 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking cipher v0.4.3 [INFO] [stderr] Checking polyval v0.5.3 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking ghash v0.4.4 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking ctr v0.8.0 [INFO] [stderr] Checking aead v0.4.3 [INFO] [stderr] Compiling backtrace v0.3.66 [INFO] [stderr] Checking scrypt v0.10.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking aes-gcm v0.9.4 [INFO] [stderr] Compiling io-streams v0.12.0 [INFO] [stderr] Checking wildmatch v2.1.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking xdg v2.4.1 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking object v0.29.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking duplex v0.13.0 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking fd-lock v3.0.6 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Compiling proc-maps v0.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking parking v2.0.0 [INFO] [stderr] Checking app_dirs2 v2.4.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking qrcodegen v1.8.0 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking question v0.2.2 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking read-process-memory v0.1.4 [INFO] [stderr] Checking subprocess v0.2.9 [INFO] [stderr] Checking memmem v0.1.1 [INFO] [stderr] Checking shellwords v1.1.0 [INFO] [stderr] Compiling clap_derive v3.2.7 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Checking rustyline v9.1.2 [INFO] [stderr] Compiling enumset_derive v0.6.0 [INFO] [stderr] Checking clap v3.2.11 [INFO] [stderr] Checking enumset v1.0.11 [INFO] [stderr] Checking rpassword v6.0.1 [INFO] [stderr] Checking pfp v0.1.0 (/opt/rustwide/workdir/pfp) [INFO] [stdout] warning: unused imports: `Value` and `json` [INFO] [stdout] --> pfp/src/json/mod.rs:10:44 [INFO] [stdout] | [INFO] [stdout] 10 | pub use serde_json::{from_slice, from_str, json, to_string, to_vec, Error, Value}; [INFO] [stdout] | ^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/crypto.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | Ok(SecretVec::new( [INFO] [stdout] | ________^ [INFO] [stdout] 134 | | cipher [INFO] [stdout] 135 | | .decrypt(nonce, ciphertext.as_slice()) [INFO] [stdout] 136 | | .or(Err(Error::DecryptionFailure))?, [INFO] [stdout] 137 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/json/secret_serialization.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn deserialize<'de, D>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(SecretString::new(String::deserialize(d)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 58 | let decrypted = crypto::decrypt_data(value, encryption_key)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | json::from_slice(decrypted.expose_secret()).map_err(|error| Error::InvalidJson { error }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 96 | let decrypted = crypto::decrypt_data(ciphertext, encryption_key)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let hmac_secret = SecretString::new( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(SecretVec::new(decoded)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage.rs:157:20 [INFO] [stdout] | [INFO] [stdout] 157 | .ok_or(Error::NoSuchAlias) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage.rs:246:25 [INFO] [stdout] | [INFO] [stdout] 241 | password: GeneratedPassword, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | self.set(&key, &Password::Generated(password), encryption_key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage.rs:256:25 [INFO] [stdout] | [INFO] [stdout] 251 | password: StoredPassword, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | self.set(&key, &Password::Stored(password), encryption_key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/passwords.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(io: IO) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Self { [INFO] [stdout] 71 | storage: storage::Storage::new(io), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/passwords.rs:72:18 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(io: IO) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | key: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/passwords.rs:73:26 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(io: IO) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | hmac_secret: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/passwords.rs:74:31 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(io: IO) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | primary_password: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/passwords.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 368 | let password = self.storage.get_password( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(password.notes().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/recovery_codes.rs:237:8 [INFO] [stdout] | [INFO] [stdout] 219 | let encryption_key = passwords::get_encryption_key(primary_password, salt); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let decrypted = crypto::decrypt_data(&encrypted, &encryption_key)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let stripped = if end_pos == decrypted_len { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | Ok(SecretString::new(decrypted_str.to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage_io/file.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | fs::write(&self.path, &contents).map_err(|error| Error::FileWriteFailure { error }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage_types/password.rs:152:20 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn new(site: &str, name: &str, revision: &str, password: SecretString) -> StoredPassword { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | notes: SecretString::new(String::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pfp` (lib) due to 16 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/crypto.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | Ok(SecretVec::new( [INFO] [stdout] | ________^ [INFO] [stdout] 134 | | cipher [INFO] [stdout] 135 | | .decrypt(nonce, ciphertext.as_slice()) [INFO] [stdout] 136 | | .or(Err(Error::DecryptionFailure))?, [INFO] [stdout] 137 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/json/secret_serialization.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn deserialize<'de, D>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(SecretString::new(String::deserialize(d)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 58 | let decrypted = crypto::decrypt_data(value, encryption_key)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | json::from_slice(decrypted.expose_secret()).map_err(|error| Error::InvalidJson { error }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 96 | let decrypted = crypto::decrypt_data(ciphertext, encryption_key)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let hmac_secret = SecretString::new( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(SecretVec::new(decoded)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage.rs:157:20 [INFO] [stdout] | [INFO] [stdout] 157 | .ok_or(Error::NoSuchAlias) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage.rs:246:25 [INFO] [stdout] | [INFO] [stdout] 241 | password: GeneratedPassword, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | self.set(&key, &Password::Generated(password), encryption_key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage.rs:256:25 [INFO] [stdout] | [INFO] [stdout] 251 | password: StoredPassword, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | self.set(&key, &Password::Stored(password), encryption_key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/passwords.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(io: IO) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Self { [INFO] [stdout] 71 | storage: storage::Storage::new(io), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/passwords.rs:72:18 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(io: IO) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | key: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/passwords.rs:73:26 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(io: IO) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | hmac_secret: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/passwords.rs:74:31 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(io: IO) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | primary_password: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/passwords.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 368 | let password = self.storage.get_password( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(password.notes().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/recovery_codes.rs:237:8 [INFO] [stdout] | [INFO] [stdout] 219 | let encryption_key = passwords::get_encryption_key(primary_password, salt); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let decrypted = crypto::decrypt_data(&encrypted, &encryption_key)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let stripped = if end_pos == decrypted_len { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | Ok(SecretString::new(decrypted_str.to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage_io/file.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | fs::write(&self.path, &contents).map_err(|error| Error::FileWriteFailure { error }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pfp/src/storage_types/password.rs:152:20 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn new(site: &str, name: &str, revision: &str, password: SecretString) -> StoredPassword { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | notes: SecretString::new(String::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pfp` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "a94268794795cbf3f99f985e95a0d061515346c317a8da64b0f9726f8b6792ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a94268794795cbf3f99f985e95a0d061515346c317a8da64b0f9726f8b6792ef", kill_on_drop: false }` [INFO] [stdout] a94268794795cbf3f99f985e95a0d061515346c317a8da64b0f9726f8b6792ef