[INFO] cloning repository https://github.com/pakky94/rnes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pakky94/rnes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpakky94%2Frnes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpakky94%2Frnes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c46990af7dc6e3b06f8c26085ed850f357236be2 [INFO] checking pakky94/rnes against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpakky94%2Frnes" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/pakky94/rnes on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/pakky94/rnes [INFO] finished tweaking git repo https://github.com/pakky94/rnes [INFO] tweaked toml for git repo https://github.com/pakky94/rnes written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/pakky94/rnes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sdl2 v0.34.5 [INFO] [stderr] Downloaded time v0.3.2 [INFO] [stderr] Downloaded sdl2-sys v0.34.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04c2e1ae0804d3f7a37a6f9f21e82dc887f87ba367affe16a7a44a2f8814e4f9 [INFO] running `Command { std: "docker" "start" "-a" "04c2e1ae0804d3f7a37a6f9f21e82dc887f87ba367affe16a7a44a2f8814e4f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04c2e1ae0804d3f7a37a6f9f21e82dc887f87ba367affe16a7a44a2f8814e4f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04c2e1ae0804d3f7a37a6f9f21e82dc887f87ba367affe16a7a44a2f8814e4f9", kill_on_drop: false }` [INFO] [stdout] 04c2e1ae0804d3f7a37a6f9f21e82dc887f87ba367affe16a7a44a2f8814e4f9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b735d94d831c5170ae6ce10fcd7d3dbc833e64a429de401424e636b1424dd5e [INFO] running `Command { std: "docker" "start" "-a" "0b735d94d831c5170ae6ce10fcd7d3dbc833e64a429de401424e636b1424dd5e", kill_on_drop: false }` [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Compiling libc v0.2.102 [INFO] [stderr] Compiling sdl2 v0.34.5 [INFO] [stderr] Checking time v0.3.2 [INFO] [stderr] Compiling sdl2-sys v0.34.5 [INFO] [stderr] Checking rnes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `borrow::BorrowMut` [INFO] [stdout] --> src/apu/mod.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 12 | use std::{borrow::BorrowMut, collections::VecDeque}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `EXPANSION_ROM` and `PRG_ROM_LOWER` [INFO] [stdout] --> src/cartridge/mappers/mmc1.rs:5:29 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::addresses::{EXPANSION_ROM, PRG_ROM_LOWER, SAVE_RAM}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge` [INFO] [stdout] --> src/memory.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `borrow::BorrowMut` [INFO] [stdout] --> src/apu/mod.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 12 | use std::{borrow::BorrowMut, collections::VecDeque}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `EXPANSION_ROM` and `PRG_ROM_LOWER` [INFO] [stdout] --> src/cartridge/mappers/mmc1.rs:5:29 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::addresses::{EXPANSION_ROM, PRG_ROM_LOWER, SAVE_RAM}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge` [INFO] [stdout] --> src/memory.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge/mappers/nrom.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | fn set_save_ram(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge/mappers/nrom.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | fn set_save_ram(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge/mappers/mod.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | fn set_save_ram(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge/mappers/mod.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | fn set_save_ram(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Button` [INFO] [stdout] --> src/main.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 16 | use sdl2::controller::{Button, GameController}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/main.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Button` [INFO] [stdout] --> src/main.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 16 | use sdl2::controller::{Button, GameController}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/main.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `controller` [INFO] [stdout] --> src/main.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | let controller: Option = match ctrl_sys.open(0) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_controller` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `controller` [INFO] [stdout] --> src/main.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | let controller: Option = match ctrl_sys.open(0) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_controller` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.71s [INFO] running `Command { std: "docker" "inspect" "0b735d94d831c5170ae6ce10fcd7d3dbc833e64a429de401424e636b1424dd5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b735d94d831c5170ae6ce10fcd7d3dbc833e64a429de401424e636b1424dd5e", kill_on_drop: false }` [INFO] [stdout] 0b735d94d831c5170ae6ce10fcd7d3dbc833e64a429de401424e636b1424dd5e [INFO] checking pakky94/rnes against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpakky94%2Frnes" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/pakky94/rnes on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/pakky94/rnes [INFO] finished tweaking git repo https://github.com/pakky94/rnes [INFO] tweaked toml for git repo https://github.com/pakky94/rnes written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/pakky94/rnes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e23df11d5ae4ee4ffabe956733cf4ade9163612fb418435f99367bc67be5fdaa [INFO] running `Command { std: "docker" "start" "-a" "e23df11d5ae4ee4ffabe956733cf4ade9163612fb418435f99367bc67be5fdaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e23df11d5ae4ee4ffabe956733cf4ade9163612fb418435f99367bc67be5fdaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e23df11d5ae4ee4ffabe956733cf4ade9163612fb418435f99367bc67be5fdaa", kill_on_drop: false }` [INFO] [stdout] e23df11d5ae4ee4ffabe956733cf4ade9163612fb418435f99367bc67be5fdaa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a5670a29b127856f01eeffee4a88eb5167b2865f4cb873b192e666157fb00011 [INFO] running `Command { std: "docker" "start" "-a" "a5670a29b127856f01eeffee4a88eb5167b2865f4cb873b192e666157fb00011", kill_on_drop: false }` [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling libc v0.2.102 [INFO] [stderr] Compiling sdl2 v0.34.5 [INFO] [stderr] Checking time v0.3.2 [INFO] [stderr] Compiling sdl2-sys v0.34.5 [INFO] [stderr] Checking rnes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `borrow::BorrowMut` [INFO] [stdout] --> src/apu/mod.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 12 | use std::{borrow::BorrowMut, collections::VecDeque}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `EXPANSION_ROM` and `PRG_ROM_LOWER` [INFO] [stdout] --> src/cartridge/mappers/mmc1.rs:5:29 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::addresses::{EXPANSION_ROM, PRG_ROM_LOWER, SAVE_RAM}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge` [INFO] [stdout] --> src/memory.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `borrow::BorrowMut` [INFO] [stdout] --> src/apu/mod.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 12 | use std::{borrow::BorrowMut, collections::VecDeque}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `EXPANSION_ROM` and `PRG_ROM_LOWER` [INFO] [stdout] --> src/cartridge/mappers/mmc1.rs:5:29 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::addresses::{EXPANSION_ROM, PRG_ROM_LOWER, SAVE_RAM}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge` [INFO] [stdout] --> src/memory.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge/mappers/nrom.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | fn set_save_ram(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge/mappers/mod.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | fn set_save_ram(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge/mappers/nrom.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | fn set_save_ram(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/cartridge/mappers/mod.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | fn set_save_ram(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 37 | let (memory_handle, apu_mem, cpu_mem, ppu_mem) = memory::create_memory(); [INFO] [stdout] | ------------- ------- ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | apu: Apu::new(apu_mem), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 37 | let (memory_handle, apu_mem, cpu_mem, ppu_mem) = memory::create_memory(); [INFO] [stdout] | ------------- ------- ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | cpu: Cpu::new(cpu_mem), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 37 | let (memory_handle, apu_mem, cpu_mem, ppu_mem) = memory::create_memory(); [INFO] [stdout] | ------------- ------- ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | ppu: Ppu::new(ppu_mem), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:432:9 [INFO] [stdout] | [INFO] [stdout] 430 | let m = Rc::new(RefCell::new(MemoryInt::new())); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | ( [INFO] [stdout] 432 | MemoryHandle(Rc::clone(&m)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:433:9 [INFO] [stdout] | [INFO] [stdout] 430 | let m = Rc::new(RefCell::new(MemoryInt::new())); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 433 | ApuMemory(Rc::clone(&m)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 430 | let m = Rc::new(RefCell::new(MemoryInt::new())); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | CpuMemory(Rc::clone(&m)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 430 | let m = Rc::new(RefCell::new(MemoryInt::new())); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 435 | PpuMemory(Rc::clone(&m)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/roms.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 9 | let mut f = File::open(filename).map_err(|e| e.to_string())?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Ok(Cartridge::new(header, data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rnes` (lib) due to 9 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 37 | let (memory_handle, apu_mem, cpu_mem, ppu_mem) = memory::create_memory(); [INFO] [stdout] | ------------- ------- ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | apu: Apu::new(apu_mem), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 37 | let (memory_handle, apu_mem, cpu_mem, ppu_mem) = memory::create_memory(); [INFO] [stdout] | ------------- ------- ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | cpu: Cpu::new(cpu_mem), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 37 | let (memory_handle, apu_mem, cpu_mem, ppu_mem) = memory::create_memory(); [INFO] [stdout] | ------------- ------- ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | ppu: Ppu::new(ppu_mem), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:432:9 [INFO] [stdout] | [INFO] [stdout] 430 | let m = Rc::new(RefCell::new(MemoryInt::new())); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | ( [INFO] [stdout] 432 | MemoryHandle(Rc::clone(&m)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:433:9 [INFO] [stdout] | [INFO] [stdout] 430 | let m = Rc::new(RefCell::new(MemoryInt::new())); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 433 | ApuMemory(Rc::clone(&m)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 430 | let m = Rc::new(RefCell::new(MemoryInt::new())); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | CpuMemory(Rc::clone(&m)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 430 | let m = Rc::new(RefCell::new(MemoryInt::new())); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 435 | PpuMemory(Rc::clone(&m)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/roms.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 9 | let mut f = File::open(filename).map_err(|e| e.to_string())?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Ok(Cartridge::new(header, data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rnes` (lib test) due to 9 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a5670a29b127856f01eeffee4a88eb5167b2865f4cb873b192e666157fb00011", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5670a29b127856f01eeffee4a88eb5167b2865f4cb873b192e666157fb00011", kill_on_drop: false }` [INFO] [stdout] a5670a29b127856f01eeffee4a88eb5167b2865f4cb873b192e666157fb00011