[INFO] cloning repository https://github.com/p2mate/u64-monitor [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/p2mate/u64-monitor" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fp2mate%2Fu64-monitor", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fp2mate%2Fu64-monitor'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5839ecb7d821432e67c1bda9ca95f6ddcfbefde6 [INFO] checking p2mate/u64-monitor against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fp2mate%2Fu64-monitor" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/p2mate/u64-monitor on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/p2mate/u64-monitor [INFO] finished tweaking git repo https://github.com/p2mate/u64-monitor [INFO] tweaked toml for git repo https://github.com/p2mate/u64-monitor written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/p2mate/u64-monitor already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded parse_int v0.5.0 [INFO] [stderr] Downloaded signal-hook v0.1.16 [INFO] [stderr] Downloaded num-iter v0.1.42 [INFO] [stderr] Downloaded vcd v0.6.1 [INFO] [stderr] Downloaded num v0.1.42 [INFO] [stderr] Downloaded ftp v3.0.1 [INFO] [stderr] Downloaded arc-swap v0.4.7 [INFO] [stderr] Downloaded signal-hook-registry v1.2.1 [INFO] [stderr] Downloaded anyhow v1.0.38 [INFO] [stderr] Downloaded libc v0.2.74 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d78a51c22b79f2d3ec1b726dcd80dfd7c3b285baac53902cd888ac79b618bce6 [INFO] running `Command { std: "docker" "start" "-a" "d78a51c22b79f2d3ec1b726dcd80dfd7c3b285baac53902cd888ac79b618bce6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d78a51c22b79f2d3ec1b726dcd80dfd7c3b285baac53902cd888ac79b618bce6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d78a51c22b79f2d3ec1b726dcd80dfd7c3b285baac53902cd888ac79b618bce6", kill_on_drop: false }` [INFO] [stdout] d78a51c22b79f2d3ec1b726dcd80dfd7c3b285baac53902cd888ac79b618bce6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cbfe0da3f8faebf1c168ff30af1c52c322b9b2ca4f2c54b2a4a78d09ce8233b8 [INFO] running `Command { std: "docker" "start" "-a" "cbfe0da3f8faebf1c168ff30af1c52c322b9b2ca4f2c54b2a4a78d09ce8233b8", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.74 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking lazy_static v0.1.16 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking vcd v0.6.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking signal-hook-registry v1.2.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking signal-hook v0.1.16 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking parse_int v0.5.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking ftp v3.0.1 [INFO] [stderr] Checking u64-monitor v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `fs::File` [INFO] [stdout] --> src/u64ftp.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | fs::File, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SimulationCommand` and `Value` [INFO] [stdout] --> src/main.rs:205:19 [INFO] [stdout] | [INFO] [stdout] 205 | use vcd::{SimulationCommand, Value}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fs::File` [INFO] [stdout] --> src/u64ftp.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | fs::File, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SimulationCommand` and `Value` [INFO] [stdout] --> src/main.rs:205:19 [INFO] [stdout] | [INFO] [stdout] 205 | use vcd::{SimulationCommand, Value}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/u64ftp.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | _ => unreachable!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/u64ftp.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 52 | FileType::File(l) => write!( [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 59 | FileType::Dir => write!( [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 66 | _ => unreachable!(), [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/u64ftp.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | _ => unreachable!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/u64ftp.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 52 | FileType::File(l) => write!( [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 59 | FileType::Dir => write!( [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 66 | _ => unreachable!(), [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Stop` is never constructed [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 34 | enum UdpMinionCmd { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 35 | Start(crossbeam_channel::Sender>), [INFO] [stdout] 36 | Stop(crossbeam_channel::Sender>), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UdpMinionCmd` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `udp_rx_thread` is never read [INFO] [stdout] --> src/main.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 45 | struct UdpMinion { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 49 | udp_rx_thread: thread::JoinHandle>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UdpMinion` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_active` is never used [INFO] [stdout] --> src/ctrl6502.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 133 | impl ActiveLow { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 134 | pub fn is_active(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_write` is never used [INFO] [stdout] --> src/ctrl6502.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 163 | impl Ctrl6502RW { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 168 | pub fn is_write(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `U64Command` is never constructed [INFO] [stdout] --> src/u64ctrl.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | pub struct U64Command { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `U64Command` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `U64CommandTransaction` is never constructed [INFO] [stdout] --> src/u64ctrl.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct U64CommandTransaction { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `U64CommandTransaction` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `mount` and `run_cartridge` are never used [INFO] [stdout] --> src/u64ctrl.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 83 | impl U64Controller { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 165 | pub fn mount>(&self, name: P) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 173 | pub fn run_cartridge>(&self, name: P) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/u64ftp.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | drop(tcp_stream); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&TcpStream` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 88 - drop(tcp_stream); [INFO] [stdout] 88 + let _ = tcp_stream; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/u64ftp.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | drop(tcp_stream); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&TcpStream` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 133 - drop(tcp_stream); [INFO] [stdout] 133 + let _ = tcp_stream; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Stop` is never constructed [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 34 | enum UdpMinionCmd { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 35 | Start(crossbeam_channel::Sender>), [INFO] [stdout] 36 | Stop(crossbeam_channel::Sender>), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UdpMinionCmd` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `udp_rx_thread` is never read [INFO] [stdout] --> src/main.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 45 | struct UdpMinion { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 49 | udp_rx_thread: thread::JoinHandle>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UdpMinion` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_active` is never used [INFO] [stdout] --> src/ctrl6502.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 133 | impl ActiveLow { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 134 | pub fn is_active(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_write` is never used [INFO] [stdout] --> src/ctrl6502.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 163 | impl Ctrl6502RW { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 168 | pub fn is_write(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `U64Command` is never constructed [INFO] [stdout] --> src/u64ctrl.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | pub struct U64Command { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `U64Command` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `U64CommandTransaction` is never constructed [INFO] [stdout] --> src/u64ctrl.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct U64CommandTransaction { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `U64CommandTransaction` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `mount` and `run_cartridge` are never used [INFO] [stdout] --> src/u64ctrl.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 83 | impl U64Controller { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 165 | pub fn mount>(&self, name: P) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 173 | pub fn run_cartridge>(&self, name: P) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/u64ftp.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | drop(tcp_stream); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&TcpStream` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 88 - drop(tcp_stream); [INFO] [stdout] 88 + let _ = tcp_stream; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/u64ftp.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | drop(tcp_stream); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&TcpStream` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 133 - drop(tcp_stream); [INFO] [stdout] 133 + let _ = tcp_stream; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.94s [INFO] running `Command { std: "docker" "inspect" "cbfe0da3f8faebf1c168ff30af1c52c322b9b2ca4f2c54b2a4a78d09ce8233b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbfe0da3f8faebf1c168ff30af1c52c322b9b2ca4f2c54b2a4a78d09ce8233b8", kill_on_drop: false }` [INFO] [stdout] cbfe0da3f8faebf1c168ff30af1c52c322b9b2ca4f2c54b2a4a78d09ce8233b8 [INFO] checking p2mate/u64-monitor against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fp2mate%2Fu64-monitor" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/p2mate/u64-monitor on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/p2mate/u64-monitor [INFO] finished tweaking git repo https://github.com/p2mate/u64-monitor [INFO] tweaked toml for git repo https://github.com/p2mate/u64-monitor written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/p2mate/u64-monitor already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0bdb4caf2b846215c00377669358c174ecd0b278118319ec81fbd31842d74fef [INFO] running `Command { std: "docker" "start" "-a" "0bdb4caf2b846215c00377669358c174ecd0b278118319ec81fbd31842d74fef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0bdb4caf2b846215c00377669358c174ecd0b278118319ec81fbd31842d74fef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bdb4caf2b846215c00377669358c174ecd0b278118319ec81fbd31842d74fef", kill_on_drop: false }` [INFO] [stdout] 0bdb4caf2b846215c00377669358c174ecd0b278118319ec81fbd31842d74fef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 788d4daeec4722cb57d59ab0e1c1a92f3fce72b57ba45f0ceabbf7478d7af611 [INFO] running `Command { std: "docker" "start" "-a" "788d4daeec4722cb57d59ab0e1c1a92f3fce72b57ba45f0ceabbf7478d7af611", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.74 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking lazy_static v0.1.16 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking vcd v0.6.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.2.1 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking signal-hook v0.1.16 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking parse_int v0.5.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking ftp v3.0.1 [INFO] [stderr] Checking u64-monitor v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `fs::File` [INFO] [stdout] --> src/u64ftp.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | fs::File, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SimulationCommand` and `Value` [INFO] [stdout] --> src/main.rs:205:19 [INFO] [stdout] | [INFO] [stdout] 205 | use vcd::{SimulationCommand, Value}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fs::File` [INFO] [stdout] --> src/u64ftp.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | fs::File, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SimulationCommand` and `Value` [INFO] [stdout] --> src/main.rs:205:19 [INFO] [stdout] | [INFO] [stdout] 205 | use vcd::{SimulationCommand, Value}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/u64ftp.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | _ => unreachable!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/u64ftp.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 52 | FileType::File(l) => write!( [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 59 | FileType::Dir => write!( [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 66 | _ => unreachable!(), [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/u64ftp.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | _ => unreachable!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/u64ftp.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 52 | FileType::File(l) => write!( [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 59 | FileType::Dir => write!( [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 66 | _ => unreachable!(), [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Stop` is never constructed [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 34 | enum UdpMinionCmd { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 35 | Start(crossbeam_channel::Sender>), [INFO] [stdout] 36 | Stop(crossbeam_channel::Sender>), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UdpMinionCmd` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `udp_rx_thread` is never read [INFO] [stdout] --> src/main.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 45 | struct UdpMinion { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 49 | udp_rx_thread: thread::JoinHandle>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UdpMinion` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_active` is never used [INFO] [stdout] --> src/ctrl6502.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 133 | impl ActiveLow { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 134 | pub fn is_active(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_write` is never used [INFO] [stdout] --> src/ctrl6502.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 163 | impl Ctrl6502RW { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 168 | pub fn is_write(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `U64Command` is never constructed [INFO] [stdout] --> src/u64ctrl.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | pub struct U64Command { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `U64Command` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `U64CommandTransaction` is never constructed [INFO] [stdout] --> src/u64ctrl.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct U64CommandTransaction { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `U64CommandTransaction` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `mount` and `run_cartridge` are never used [INFO] [stdout] --> src/u64ctrl.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 83 | impl U64Controller { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 165 | pub fn mount>(&self, name: P) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 173 | pub fn run_cartridge>(&self, name: P) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 54 | let socket = UdpSocket::bind("0.0.0.0:11002")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let (cmd_tx, cmd_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let (udp_tx, udp_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let (request_stop, stop_received) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let udp_rx_thread = thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let minion_thread = thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(UdpMinion { [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | cmd_tx, [INFO] [stdout] 121 | | minion_thread: Some(minion_thread), [INFO] [stdout] 122 | | udp_rx_thread, [INFO] [stdout] 123 | | request_stop, [INFO] [stdout] 124 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 204 | fn new(writer: T) -> anyhow::Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | use vcd::{SimulationCommand, Value}; [INFO] [stdout] 206 | let mut handle = vcd::Writer::new(writer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Ok(VCDLogger { [INFO] [stdout] | ____________^ [INFO] [stdout] 234 | | handle, [INFO] [stdout] 235 | | addr, [INFO] [stdout] 236 | | data, [INFO] [stdout] ... | [INFO] [stdout] 244 | | phi2, [INFO] [stdout] 245 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 275 | fn new(handle: Box) -> anyhow::Result { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | Ok(SimpleLogger { handle }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:298:12 [INFO] [stdout] | [INFO] [stdout] 297 | fn new(logger: Box) -> anyhow::Result { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | Ok(LogMinion { [INFO] [stdout] | ____________^ [INFO] [stdout] 299 | | seq_number: None, [INFO] [stdout] 300 | | cycles: 0, [INFO] [stdout] 301 | | state: TraceState::Stop, [INFO] [stdout] ... | [INFO] [stdout] 304 | | logger, [INFO] [stdout] 305 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:451:81 [INFO] [stdout] | [INFO] [stdout] 449 | let logger = self.logminion.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | let rx = udp_rx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 451 | self.logminion_handle = Some(thread::spawn(move || log_minion_loop(&rx, logger.clone()))); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ctrl.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn new(ctrl_addr: A) -> anyhow::Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let ctrl_socket = TcpStream::connect(ctrl_addr)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | Ok(U64Controller { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | ctrl_socket: Arc::new(Mutex::new(ctrl_socket)), [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ctrl.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 207 | let socket = self.ctrl_socket.lock().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | socket.peer_addr().map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ftp.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 75 | let mut ftp = FtpStream::connect(peer)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | ftp.login("", "")?; [INFO] [stdout] 77 | Ok(U64Ftp { ftp }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/u64ftp.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | drop(tcp_stream); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&TcpStream` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 88 - drop(tcp_stream); [INFO] [stdout] 88 + let _ = tcp_stream; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ftp.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / PORT_RE [INFO] [stdout] 144 | | .captures(&line) [INFO] [stdout] 145 | | .ok_or(ftp::FtpError::InvalidResponse(format!("Unexpected response {}", line)).into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/u64ftp.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | drop(tcp_stream); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&TcpStream` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 133 - drop(tcp_stream); [INFO] [stdout] 133 + let _ = tcp_stream; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ftp.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 179 | remote: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | ) -> anyhow::Result<()> { [INFO] [stdout] 181 | let err = self.ftp.put(remote.as_ref(), local); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | / match err { [INFO] [stdout] 183 | | Err(FtpError::InvalidResponse(e)) if e.starts_with("452") => { Ok(())}, [INFO] [stdout] 184 | | _ => err [INFO] [stdout] 185 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ftp.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn get>(&mut self, remote: T) -> anyhow::Result>> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | self.ftp.simple_retr(remote.as_ref()).map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ftp.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn rm>(&mut self, remote: T) -> anyhow::Result<()> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | self.ftp.rm(remote.as_ref()).map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `u64-monitor` (bin "u64-monitor" test) due to 13 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variant `Stop` is never constructed [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 34 | enum UdpMinionCmd { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 35 | Start(crossbeam_channel::Sender>), [INFO] [stdout] 36 | Stop(crossbeam_channel::Sender>), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UdpMinionCmd` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `udp_rx_thread` is never read [INFO] [stdout] --> src/main.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 45 | struct UdpMinion { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 49 | udp_rx_thread: thread::JoinHandle>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UdpMinion` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_active` is never used [INFO] [stdout] --> src/ctrl6502.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 133 | impl ActiveLow { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 134 | pub fn is_active(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_write` is never used [INFO] [stdout] --> src/ctrl6502.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 163 | impl Ctrl6502RW { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 168 | pub fn is_write(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `U64Command` is never constructed [INFO] [stdout] --> src/u64ctrl.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | pub struct U64Command { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `U64Command` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `U64CommandTransaction` is never constructed [INFO] [stdout] --> src/u64ctrl.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct U64CommandTransaction { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `U64CommandTransaction` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `mount` and `run_cartridge` are never used [INFO] [stdout] --> src/u64ctrl.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 83 | impl U64Controller { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 165 | pub fn mount>(&self, name: P) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 173 | pub fn run_cartridge>(&self, name: P) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 54 | let socket = UdpSocket::bind("0.0.0.0:11002")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let (cmd_tx, cmd_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let (udp_tx, udp_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let (request_stop, stop_received) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let udp_rx_thread = thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let minion_thread = thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(UdpMinion { [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | cmd_tx, [INFO] [stdout] 121 | | minion_thread: Some(minion_thread), [INFO] [stdout] 122 | | udp_rx_thread, [INFO] [stdout] 123 | | request_stop, [INFO] [stdout] 124 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 204 | fn new(writer: T) -> anyhow::Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | use vcd::{SimulationCommand, Value}; [INFO] [stdout] 206 | let mut handle = vcd::Writer::new(writer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Ok(VCDLogger { [INFO] [stdout] | ____________^ [INFO] [stdout] 234 | | handle, [INFO] [stdout] 235 | | addr, [INFO] [stdout] 236 | | data, [INFO] [stdout] ... | [INFO] [stdout] 244 | | phi2, [INFO] [stdout] 245 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 275 | fn new(handle: Box) -> anyhow::Result { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | Ok(SimpleLogger { handle }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:298:12 [INFO] [stdout] | [INFO] [stdout] 297 | fn new(logger: Box) -> anyhow::Result { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | Ok(LogMinion { [INFO] [stdout] | ____________^ [INFO] [stdout] 299 | | seq_number: None, [INFO] [stdout] 300 | | cycles: 0, [INFO] [stdout] 301 | | state: TraceState::Stop, [INFO] [stdout] ... | [INFO] [stdout] 304 | | logger, [INFO] [stdout] 305 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:451:81 [INFO] [stdout] | [INFO] [stdout] 449 | let logger = self.logminion.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | let rx = udp_rx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 451 | self.logminion_handle = Some(thread::spawn(move || log_minion_loop(&rx, logger.clone()))); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ctrl.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn new(ctrl_addr: A) -> anyhow::Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let ctrl_socket = TcpStream::connect(ctrl_addr)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | Ok(U64Controller { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | ctrl_socket: Arc::new(Mutex::new(ctrl_socket)), [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ctrl.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 207 | let socket = self.ctrl_socket.lock().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | socket.peer_addr().map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ftp.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 75 | let mut ftp = FtpStream::connect(peer)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | ftp.login("", "")?; [INFO] [stdout] 77 | Ok(U64Ftp { ftp }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/u64ftp.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | drop(tcp_stream); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&TcpStream` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 88 - drop(tcp_stream); [INFO] [stdout] 88 + let _ = tcp_stream; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ftp.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / PORT_RE [INFO] [stdout] 144 | | .captures(&line) [INFO] [stdout] 145 | | .ok_or(ftp::FtpError::InvalidResponse(format!("Unexpected response {}", line)).into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/u64ftp.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | drop(tcp_stream); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&TcpStream` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 133 - drop(tcp_stream); [INFO] [stdout] 133 + let _ = tcp_stream; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ftp.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 179 | remote: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | ) -> anyhow::Result<()> { [INFO] [stdout] 181 | let err = self.ftp.put(remote.as_ref(), local); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | / match err { [INFO] [stdout] 183 | | Err(FtpError::InvalidResponse(e)) if e.starts_with("452") => { Ok(())}, [INFO] [stdout] 184 | | _ => err [INFO] [stdout] 185 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ftp.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn get>(&mut self, remote: T) -> anyhow::Result>> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | self.ftp.simple_retr(remote.as_ref()).map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/u64ftp.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn rm>(&mut self, remote: T) -> anyhow::Result<()> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | self.ftp.rm(remote.as_ref()).map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `u64-monitor` (bin "u64-monitor") due to 13 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "788d4daeec4722cb57d59ab0e1c1a92f3fce72b57ba45f0ceabbf7478d7af611", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "788d4daeec4722cb57d59ab0e1c1a92f3fce72b57ba45f0ceabbf7478d7af611", kill_on_drop: false }` [INFO] [stdout] 788d4daeec4722cb57d59ab0e1c1a92f3fce72b57ba45f0ceabbf7478d7af611