[INFO] cloning repository https://github.com/oxidecomputer/nvme [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/oxidecomputer/nvme" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Foxidecomputer%2Fnvme", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Foxidecomputer%2Fnvme'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5eee080475414a05956723b87bb8946489af2acb [INFO] checking oxidecomputer/nvme against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Foxidecomputer%2Fnvme" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/oxidecomputer/nvme on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/oxidecomputer/nvme [INFO] finished tweaking git repo https://github.com/oxidecomputer/nvme [INFO] tweaked toml for git repo https://github.com/oxidecomputer/nvme written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/oxidecomputer/nvme already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Updating libnvme v0.1.1 (/workspace/builds/worker-6-tc1/source/libnvme) -> v0.1.2 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thiserror-impl v1.0.57 [INFO] [stderr] Downloaded bitfield-struct v0.6.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.78 [INFO] [stderr] Downloaded thiserror v1.0.57 [INFO] [stderr] Downloaded syn v2.0.48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 70c7d37aaebfd4b2ecdc332ff288e7463c6814dd6f6faab75da8dc3084d74df9 [INFO] running `Command { std: "docker" "start" "-a" "70c7d37aaebfd4b2ecdc332ff288e7463c6814dd6f6faab75da8dc3084d74df9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "70c7d37aaebfd4b2ecdc332ff288e7463c6814dd6f6faab75da8dc3084d74df9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70c7d37aaebfd4b2ecdc332ff288e7463c6814dd6f6faab75da8dc3084d74df9", kill_on_drop: false }` [INFO] [stdout] 70c7d37aaebfd4b2ecdc332ff288e7463c6814dd6f6faab75da8dc3084d74df9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7138598263e00c6ab3d5d0945ecd35c128a01b2c18d80e332a340c1a621b41a6 [INFO] running `Command { std: "docker" "start" "-a" "7138598263e00c6ab3d5d0945ecd35c128a01b2c18d80e332a340c1a621b41a6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking nvme v0.1.0 (/opt/rustwide/workdir/nvme) [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling bitfield-struct v0.6.0 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking libnvme-sys v0.0.0 (/opt/rustwide/workdir/libnvme-sys) [INFO] [stderr] Checking libnvme v0.1.2 (/opt/rustwide/workdir/libnvme) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.70s [INFO] running `Command { std: "docker" "inspect" "7138598263e00c6ab3d5d0945ecd35c128a01b2c18d80e332a340c1a621b41a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7138598263e00c6ab3d5d0945ecd35c128a01b2c18d80e332a340c1a621b41a6", kill_on_drop: false }` [INFO] [stdout] 7138598263e00c6ab3d5d0945ecd35c128a01b2c18d80e332a340c1a621b41a6 [INFO] checking oxidecomputer/nvme against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Foxidecomputer%2Fnvme" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/oxidecomputer/nvme on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/oxidecomputer/nvme [INFO] finished tweaking git repo https://github.com/oxidecomputer/nvme [INFO] tweaked toml for git repo https://github.com/oxidecomputer/nvme written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/oxidecomputer/nvme already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Updating libnvme v0.1.1 (/workspace/builds/worker-6-tc2/source/libnvme) -> v0.1.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29b0ea7c85edc00356ff8b223cf99a2ea42c3872b731ce9dbf5a6f7a3695151b [INFO] running `Command { std: "docker" "start" "-a" "29b0ea7c85edc00356ff8b223cf99a2ea42c3872b731ce9dbf5a6f7a3695151b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29b0ea7c85edc00356ff8b223cf99a2ea42c3872b731ce9dbf5a6f7a3695151b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29b0ea7c85edc00356ff8b223cf99a2ea42c3872b731ce9dbf5a6f7a3695151b", kill_on_drop: false }` [INFO] [stdout] 29b0ea7c85edc00356ff8b223cf99a2ea42c3872b731ce9dbf5a6f7a3695151b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5550e84c0056845f3cf773979f41fddeac8cdf2126ed2f9996ee8a069acee8df [INFO] running `Command { std: "docker" "start" "-a" "5550e84c0056845f3cf773979f41fddeac8cdf2126ed2f9996ee8a069acee8df", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking nvme v0.1.0 (/opt/rustwide/workdir/nvme) [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling bitfield-struct v0.6.0 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking libnvme-sys v0.0.0 (/opt/rustwide/workdir/libnvme-sys) [INFO] [stderr] Checking libnvme v0.1.2 (/opt/rustwide/workdir/libnvme) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 80 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | ) -> Result, (Self, NvmeControllerError)> { [INFO] [stdout] 82 | self.lock_impl(ControllerLockLevel::Read, ControllerLockFlags::Block) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:83:57 [INFO] [stdout] | [INFO] [stdout] 83 | .map(|c| ReadLockedController { controller: Some(c) }) [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 87 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | ) -> Result, (Self, NvmeControllerError)> { [INFO] [stdout] 89 | self.lock_impl(ControllerLockLevel::Write, ControllerLockFlags::Block) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:90:58 [INFO] [stdout] | [INFO] [stdout] 90 | .map(|c| WriteLockedController { controller: Some(c) }) [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 94 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | match self.lock_impl( [INFO] [stdout] | _______________^ [INFO] [stdout] 98 | | ControllerLockLevel::Read, [INFO] [stdout] 99 | | ControllerLockFlags::DontBlock, [INFO] [stdout] 100 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:117:15 [INFO] [stdout] | [INFO] [stdout] 114 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | match self.lock_impl( [INFO] [stdout] | _______________^ [INFO] [stdout] 118 | | ControllerLockLevel::Write, [INFO] [stdout] 119 | | ControllerLockFlags::DontBlock, [INFO] [stdout] 120 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:355:9 [INFO] [stdout] | [INFO] [stdout] 354 | pub fn set_lbaf(self, lbaf: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | / self.controller [INFO] [stdout] 356 | | .check_result( [INFO] [stdout] 357 | | unsafe { nvme_format_req_set_lbaf(self.req, lbaf) }, [INFO] [stdout] 358 | | || format!("failed to set LBA format {lbaf} on format request"), [INFO] [stdout] 359 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:360:18 [INFO] [stdout] | [INFO] [stdout] 354 | pub fn set_lbaf(self, lbaf: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | .map(|_| self) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:364:9 [INFO] [stdout] | [INFO] [stdout] 363 | pub fn set_nsid(self, nsid: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | / self.controller [INFO] [stdout] 365 | | .check_result( [INFO] [stdout] 366 | | unsafe { nvme_format_req_set_nsid(self.req, nsid) }, [INFO] [stdout] 367 | | || format!("failed to set nsid {nsid} on format request"), [INFO] [stdout] 368 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:369:18 [INFO] [stdout] | [INFO] [stdout] 363 | pub fn set_nsid(self, nsid: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | .map(|_| self) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 372 | pub fn set_ses(self, ses: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | / self.controller [INFO] [stdout] 374 | | .check_result( [INFO] [stdout] 375 | | unsafe { nvme_format_req_set_ses(self.req, ses) }, [INFO] [stdout] 376 | | || format!("failed to set ses {ses} on format request"), [INFO] [stdout] 377 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:378:18 [INFO] [stdout] | [INFO] [stdout] 372 | pub fn set_ses(self, ses: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 378 | .map(|_| self) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/error.rs:17:28 [INFO] [stdout] | [INFO] [stdout] 13 | fn fatal_context>(&self, context: C) -> Self::Error { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | let syserr = std::io::Error::from_raw_os_error(syserr); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | self.current_error(InternalError { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 18 | | context: context.into(), [INFO] [stdout] 19 | | syserr, [INFO] [stdout] 20 | | errmsg, [INFO] [stdout] 21 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/firmware.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 297 | pub fn set_slot(self, slot: NvmeSlot) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | / self.controller [INFO] [stdout] 299 | | .check_result( [INFO] [stdout] 300 | | unsafe { [INFO] [stdout] 301 | | nvme_fw_commit_req_set_slot(self.req, u32::from(slot.0)) [INFO] [stdout] ... | [INFO] [stdout] 308 | | }, [INFO] [stdout] 309 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/firmware.rs:310:18 [INFO] [stdout] | [INFO] [stdout] 297 | pub fn set_slot(self, slot: NvmeSlot) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | .map(|_| self) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/firmware.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 315 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | / self.controller [INFO] [stdout] 319 | | .check_result( [INFO] [stdout] 320 | | unsafe { [INFO] [stdout] 321 | | nvme_fw_commit_req_set_action(self.req, action as u32) [INFO] [stdout] ... | [INFO] [stdout] 327 | | }, [INFO] [stdout] 328 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/firmware.rs:329:18 [INFO] [stdout] | [INFO] [stdout] 315 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | .map(|_| self) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/logpage.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 138 | let disc = NvmeLogDisc { inner: disc_ptr, _phantom: PhantomData }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let mut req = NvmeLogReq { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(LogPageInfo { size, req }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 80 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | ) -> Result, (Self, NvmeControllerError)> { [INFO] [stdout] 82 | self.lock_impl(ControllerLockLevel::Read, ControllerLockFlags::Block) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:83:57 [INFO] [stdout] | [INFO] [stdout] 83 | .map(|c| ReadLockedController { controller: Some(c) }) [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 87 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | ) -> Result, (Self, NvmeControllerError)> { [INFO] [stdout] 89 | self.lock_impl(ControllerLockLevel::Write, ControllerLockFlags::Block) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:90:58 [INFO] [stdout] | [INFO] [stdout] 90 | .map(|c| WriteLockedController { controller: Some(c) }) [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 94 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | match self.lock_impl( [INFO] [stdout] | _______________^ [INFO] [stdout] 98 | | ControllerLockLevel::Read, [INFO] [stdout] 99 | | ControllerLockFlags::DontBlock, [INFO] [stdout] 100 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:117:15 [INFO] [stdout] | [INFO] [stdout] 114 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | match self.lock_impl( [INFO] [stdout] | _______________^ [INFO] [stdout] 118 | | ControllerLockLevel::Write, [INFO] [stdout] 119 | | ControllerLockFlags::DontBlock, [INFO] [stdout] 120 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:355:9 [INFO] [stdout] | [INFO] [stdout] 354 | pub fn set_lbaf(self, lbaf: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | / self.controller [INFO] [stdout] 356 | | .check_result( [INFO] [stdout] 357 | | unsafe { nvme_format_req_set_lbaf(self.req, lbaf) }, [INFO] [stdout] 358 | | || format!("failed to set LBA format {lbaf} on format request"), [INFO] [stdout] 359 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:360:18 [INFO] [stdout] | [INFO] [stdout] 354 | pub fn set_lbaf(self, lbaf: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | .map(|_| self) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:364:9 [INFO] [stdout] | [INFO] [stdout] 363 | pub fn set_nsid(self, nsid: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | / self.controller [INFO] [stdout] 365 | | .check_result( [INFO] [stdout] 366 | | unsafe { nvme_format_req_set_nsid(self.req, nsid) }, [INFO] [stdout] 367 | | || format!("failed to set nsid {nsid} on format request"), [INFO] [stdout] 368 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:369:18 [INFO] [stdout] | [INFO] [stdout] 363 | pub fn set_nsid(self, nsid: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | .map(|_| self) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 372 | pub fn set_ses(self, ses: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | / self.controller [INFO] [stdout] 374 | | .check_result( [INFO] [stdout] 375 | | unsafe { nvme_format_req_set_ses(self.req, ses) }, [INFO] [stdout] 376 | | || format!("failed to set ses {ses} on format request"), [INFO] [stdout] 377 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/controller.rs:378:18 [INFO] [stdout] | [INFO] [stdout] 372 | pub fn set_ses(self, ses: u32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 378 | .map(|_| self) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/error.rs:17:28 [INFO] [stdout] | [INFO] [stdout] 13 | fn fatal_context>(&self, context: C) -> Self::Error { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | let syserr = std::io::Error::from_raw_os_error(syserr); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | self.current_error(InternalError { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 18 | | context: context.into(), [INFO] [stdout] 19 | | syserr, [INFO] [stdout] 20 | | errmsg, [INFO] [stdout] 21 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/firmware.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 297 | pub fn set_slot(self, slot: NvmeSlot) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | / self.controller [INFO] [stdout] 299 | | .check_result( [INFO] [stdout] 300 | | unsafe { [INFO] [stdout] 301 | | nvme_fw_commit_req_set_slot(self.req, u32::from(slot.0)) [INFO] [stdout] ... | [INFO] [stdout] 308 | | }, [INFO] [stdout] 309 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/firmware.rs:310:18 [INFO] [stdout] | [INFO] [stdout] 297 | pub fn set_slot(self, slot: NvmeSlot) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | .map(|_| self) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/firmware.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 315 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | / self.controller [INFO] [stdout] 319 | | .check_result( [INFO] [stdout] 320 | | unsafe { [INFO] [stdout] 321 | | nvme_fw_commit_req_set_action(self.req, action as u32) [INFO] [stdout] ... | [INFO] [stdout] 327 | | }, [INFO] [stdout] 328 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/firmware.rs:329:18 [INFO] [stdout] | [INFO] [stdout] 315 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | .map(|_| self) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libnvme/src/logpage.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 138 | let disc = NvmeLogDisc { inner: disc_ptr, _phantom: PhantomData }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let mut req = NvmeLogReq { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(LogPageInfo { size, req }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libnvme` (lib test) due to 19 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `libnvme` (lib) due to 19 previous errors [INFO] running `Command { std: "docker" "inspect" "5550e84c0056845f3cf773979f41fddeac8cdf2126ed2f9996ee8a069acee8df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5550e84c0056845f3cf773979f41fddeac8cdf2126ed2f9996ee8a069acee8df", kill_on_drop: false }` [INFO] [stdout] 5550e84c0056845f3cf773979f41fddeac8cdf2126ed2f9996ee8a069acee8df