[INFO] cloning repository https://github.com/odf/rust-systre [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/odf/rust-systre" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fodf%2Frust-systre", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fodf%2Frust-systre'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 64b4b05985b9a62fe702cb5d45276e5b1b895dc9 [INFO] checking odf/rust-systre against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fodf%2Frust-systre" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/odf/rust-systre on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/odf/rust-systre [INFO] finished tweaking git repo https://github.com/odf/rust-systre [INFO] tweaked toml for git repo https://github.com/odf/rust-systre written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/odf/rust-systre already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded itertools v0.10.5 [INFO] [stderr] Downloaded num-bigint v0.4.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 27d7219ec9711394e65560d16678185dbfdadb81a698ebec854975de5fe231e5 [INFO] running `Command { std: "docker" "start" "-a" "27d7219ec9711394e65560d16678185dbfdadb81a698ebec854975de5fe231e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "27d7219ec9711394e65560d16678185dbfdadb81a698ebec854975de5fe231e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27d7219ec9711394e65560d16678185dbfdadb81a698ebec854975de5fe231e5", kill_on_drop: false }` [INFO] [stdout] 27d7219ec9711394e65560d16678185dbfdadb81a698ebec854975de5fe231e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c79e32799bf4ad249ca9ff283577ba63cf43b380aef16789739794985a6f04dd [INFO] running `Command { std: "docker" "start" "-a" "c79e32799bf4ad249ca9ff283577ba63cf43b380aef16789739794985a6f04dd", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking rust-systre v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/spacegroups/finder.rs:181:15 [INFO] [stdout] | [INFO] [stdout] 181 | (todo!(), to_normalized) [INFO] [stdout] | ------- ^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | | [INFO] [stdout] | any code following this expression is unreachable [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/spacegroups/finder.rs:181:15 [INFO] [stdout] | [INFO] [stdout] 181 | (todo!(), to_normalized) [INFO] [stdout] | ------- ^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | | [INFO] [stdout] | any code following this expression is unreachable [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `centering` [INFO] [stdout] --> src/spacegroups/finder.rs:175:22 [INFO] [stdout] | [INFO] [stdout] 175 | let (normalized, centering) = normalized_basis_2d(crystal_system, &pcell); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_centering` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `to_normalized` [INFO] [stdout] --> src/spacegroups/finder.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | let to_normalized = (&normalized * &basis).transpose().inverse().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_to_normalized` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `dimension`, `crystal_system`, `centering`, `full_name`, `group_name`, and `extension` are never read [INFO] [stdout] --> src/spacegroups/types.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 88 | pub struct SpaceGroup { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 89 | dimension: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 90 | crystal_system: CrystalSystem, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 91 | centering: Centering, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 92 | full_name: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 93 | group_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 94 | extension: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cell`, `to_primitive`, and `ops` are never read [INFO] [stdout] --> src/spacegroups/basics.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | pub struct PrimitiveSetting { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 48 | cell: Vec>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 49 | to_primitive: CoordinateMap, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 50 | ops: Vec> [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/spacegroups/basics.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 54 | / impl PrimitiveSetting [INFO] [stdout] 55 | | where [INFO] [stdout] 56 | | CS: Clone + Eq, [INFO] [stdout] 57 | | CSP: Clone + Eq + Hash [INFO] [stdout] | |______________________________- associated function in this implementation [INFO] [stdout] 58 | { [INFO] [stdout] 59 | fn new(ops_all: &Vec>) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `dimension` is never read [INFO] [stdout] --> src/spacegroups/finder.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 9 | struct OperatorDetails { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 10 | matrix: Matrix, [INFO] [stdout] 11 | dimension: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `are_orthogonal` is never used [INFO] [stdout] --> src/spacegroups/finder.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | fn are_orthogonal(v: &[T], w: &[T]) -> bool [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `centering` [INFO] [stdout] --> src/spacegroups/finder.rs:175:22 [INFO] [stdout] | [INFO] [stdout] 175 | let (normalized, centering) = normalized_basis_2d(crystal_system, &pcell); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_centering` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `to_normalized` [INFO] [stdout] --> src/spacegroups/finder.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | let to_normalized = (&normalized * &basis).transpose().inverse().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_to_normalized` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `dimension`, `crystal_system`, `centering`, `full_name`, `group_name`, and `extension` are never read [INFO] [stdout] --> src/spacegroups/types.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 88 | pub struct SpaceGroup { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 89 | dimension: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 90 | crystal_system: CrystalSystem, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 91 | centering: Centering, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 92 | full_name: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 93 | group_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 94 | extension: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cell` and `ops` are never read [INFO] [stdout] --> src/spacegroups/basics.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | pub struct PrimitiveSetting { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 48 | cell: Vec>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 49 | to_primitive: CoordinateMap, [INFO] [stdout] 50 | ops: Vec> [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `are_orthogonal` is never used [INFO] [stdout] --> src/spacegroups/finder.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | fn are_orthogonal(v: &[T], w: &[T]) -> bool [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.27s [INFO] running `Command { std: "docker" "inspect" "c79e32799bf4ad249ca9ff283577ba63cf43b380aef16789739794985a6f04dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c79e32799bf4ad249ca9ff283577ba63cf43b380aef16789739794985a6f04dd", kill_on_drop: false }` [INFO] [stdout] c79e32799bf4ad249ca9ff283577ba63cf43b380aef16789739794985a6f04dd [INFO] checking odf/rust-systre against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fodf%2Frust-systre" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/odf/rust-systre on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/odf/rust-systre [INFO] finished tweaking git repo https://github.com/odf/rust-systre [INFO] tweaked toml for git repo https://github.com/odf/rust-systre written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/odf/rust-systre already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7515565f36e2e07f7216c8c2cf4ffa2c637d184bf650b56e2ddfadd8d1639aed [INFO] running `Command { std: "docker" "start" "-a" "7515565f36e2e07f7216c8c2cf4ffa2c637d184bf650b56e2ddfadd8d1639aed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7515565f36e2e07f7216c8c2cf4ffa2c637d184bf650b56e2ddfadd8d1639aed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7515565f36e2e07f7216c8c2cf4ffa2c637d184bf650b56e2ddfadd8d1639aed", kill_on_drop: false }` [INFO] [stdout] 7515565f36e2e07f7216c8c2cf4ffa2c637d184bf650b56e2ddfadd8d1639aed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c9b13f6b3fa1ae002e42d5bef7119564c0298df4f4822db9bc4c3b72865598d [INFO] running `Command { std: "docker" "start" "-a" "5c9b13f6b3fa1ae002e42d5bef7119564c0298df4f4822db9bc4c3b72865598d", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking rust-systre v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/spacegroups/finder.rs:181:15 [INFO] [stdout] | [INFO] [stdout] 181 | (todo!(), to_normalized) [INFO] [stdout] | ------- ^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | | [INFO] [stdout] | any code following this expression is unreachable [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/spacegroups/finder.rs:181:15 [INFO] [stdout] | [INFO] [stdout] 181 | (todo!(), to_normalized) [INFO] [stdout] | ------- ^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | | [INFO] [stdout] | any code following this expression is unreachable [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `centering` [INFO] [stdout] --> src/spacegroups/finder.rs:175:22 [INFO] [stdout] | [INFO] [stdout] 175 | let (normalized, centering) = normalized_basis_2d(crystal_system, &pcell); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_centering` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `to_normalized` [INFO] [stdout] --> src/spacegroups/finder.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | let to_normalized = (&normalized * &basis).transpose().inverse().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_to_normalized` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `dimension`, `crystal_system`, `centering`, `full_name`, `group_name`, and `extension` are never read [INFO] [stdout] --> src/spacegroups/types.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 88 | pub struct SpaceGroup { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 89 | dimension: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 90 | crystal_system: CrystalSystem, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 91 | centering: Centering, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 92 | full_name: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 93 | group_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 94 | extension: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cell`, `to_primitive`, and `ops` are never read [INFO] [stdout] --> src/spacegroups/basics.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | pub struct PrimitiveSetting { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 48 | cell: Vec>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 49 | to_primitive: CoordinateMap, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 50 | ops: Vec> [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/spacegroups/basics.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 54 | / impl PrimitiveSetting [INFO] [stdout] 55 | | where [INFO] [stdout] 56 | | CS: Clone + Eq, [INFO] [stdout] 57 | | CSP: Clone + Eq + Hash [INFO] [stdout] | |______________________________- associated function in this implementation [INFO] [stdout] 58 | { [INFO] [stdout] 59 | fn new(ops_all: &Vec>) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `dimension` is never read [INFO] [stdout] --> src/spacegroups/finder.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 9 | struct OperatorDetails { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 10 | matrix: Matrix, [INFO] [stdout] 11 | dimension: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `are_orthogonal` is never used [INFO] [stdout] --> src/spacegroups/finder.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | fn are_orthogonal(v: &[T], w: &[T]) -> bool [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/matrices.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 67 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Matrix::new(1, &Vec::from_iter(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/matrices.rs:297:54 [INFO] [stdout] | [INFO] [stdout] 297 | let data: Vec<_> = self.data.iter().map(|x| -x.clone()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/linear_algebra.rs:218:43 [INFO] [stdout] | [INFO] [stdout] 218 | v = v.iter().map(|x| -x.clone()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/linear_algebra.rs:322:14 [INFO] [stdout] | [INFO] [stdout] 302 | let mut basis = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | &basis.iter().map(|v| Matrix::row(&v)).collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/linear_algebra.rs:361:14 [INFO] [stdout] | [INFO] [stdout] 331 | let t = Matrix::hstack(&[self.clone(), rgt.clone()]).reduced_basis(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | let lft = t.submatrix(0..t.nrows, 0..colslft); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let rgt = t.submatrix(0..t.nrows, colslft..t.ncols); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | let t = Matrix::hstack(&[lft.transpose(), Matrix::identity(lft.ncols)]) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | .reduced_basis(); [INFO] [stdout] 344 | let b = t.submatrix(0..t.nrows, 0..lft.nrows).transpose(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | let u = t.submatrix(0..t.nrows, lft.nrows..t.ncols).transpose(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | [INFO] [stdout] 347 | let mut x = vec![]; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | let x = Matrix::vstack( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | Some(u * x) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 61 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Vector::new(&Vec::from_iter(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:122:42 [INFO] [stdout] | [INFO] [stdout] 122 | self.iter().cloned().map(|x| x % T::one()).collect() [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:326:21 [INFO] [stdout] | [INFO] [stdout] 325 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | Point::new(&Vec::from_iter(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:628:20 [INFO] [stdout] | [INFO] [stdout] 625 | fn adjust(src: AffineMap) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 628 | shift: Vector::from(src.shift.coords), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:635:29 [INFO] [stdout] | [INFO] [stdout] 634 | fn from(coords: Matrix) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 635 | Self::new(&coords, &Vector::zero(coords.nrows)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:769:20 [INFO] [stdout] | [INFO] [stdout] 768 | let cols: Vec<_> = basis.iter().map(|a| a.coords.clone()).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 769 | Self::new(&Matrix::hstack(&cols).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:792:20 [INFO] [stdout] | [INFO] [stdout] 791 | fn from(coords: Matrix) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 792 | Self::new(&coords.into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pgraphs.rs:651:13 [INFO] [stdout] | [INFO] [stdout] 651 | e.clone(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pgraphs.rs:652:13 [INFO] [stdout] | [INFO] [stdout] 652 | self.edge_map.get(rhs.edge_map.get(e).unwrap()).unwrap().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spacegroups/lattices.rs:162:6 [INFO] [stdout] | [INFO] [stdout] 133 | fn selling_reduced(u: &[T], v: &[T], w: &[T], dot: F, epsilon: &T) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let s = neg(&add(&add(&u, &v), &w)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut vs = [u.to_vec(), v.to_vec(), w.to_vec(), s]; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | (vs[0].clone(), vs[1].clone(), vs[2].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spacegroups/lattices.rs:162:21 [INFO] [stdout] | [INFO] [stdout] 133 | fn selling_reduced(u: &[T], v: &[T], w: &[T], dot: F, epsilon: &T) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let s = neg(&add(&add(&u, &v), &w)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut vs = [u.to_vec(), v.to_vec(), w.to_vec(), s]; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | (vs[0].clone(), vs[1].clone(), vs[2].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spacegroups/lattices.rs:162:36 [INFO] [stdout] | [INFO] [stdout] 133 | fn selling_reduced(u: &[T], v: &[T], w: &[T], dot: F, epsilon: &T) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let s = neg(&add(&add(&u, &v), &w)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut vs = [u.to_vec(), v.to_vec(), w.to_vec(), s]; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | (vs[0].clone(), vs[1].clone(), vs[2].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spacegroups/finder.rs:192:41 [INFO] [stdout] | [INFO] [stdout] 192 | .map(|op| OperatorDetails::from(op.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symmetries.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 181 | let mut result = HashSet::from([identity.clone()]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let mut queue = VecDeque::from([identity.clone()]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | result.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symmetries.rs:459:5 [INFO] [stdout] | [INFO] [stdout] 456 | fn map_vec<'a, A, B, F>(fun: F, input: &'a Vec) -> Vec [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 459 | input.iter().map(fun).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-systre` (lib) due to 21 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `centering` [INFO] [stdout] --> src/spacegroups/finder.rs:175:22 [INFO] [stdout] | [INFO] [stdout] 175 | let (normalized, centering) = normalized_basis_2d(crystal_system, &pcell); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_centering` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `to_normalized` [INFO] [stdout] --> src/spacegroups/finder.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | let to_normalized = (&normalized * &basis).transpose().inverse().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_to_normalized` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `dimension`, `crystal_system`, `centering`, `full_name`, `group_name`, and `extension` are never read [INFO] [stdout] --> src/spacegroups/types.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 88 | pub struct SpaceGroup { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 89 | dimension: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 90 | crystal_system: CrystalSystem, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 91 | centering: Centering, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 92 | full_name: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 93 | group_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 94 | extension: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cell` and `ops` are never read [INFO] [stdout] --> src/spacegroups/basics.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | pub struct PrimitiveSetting { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 48 | cell: Vec>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 49 | to_primitive: CoordinateMap, [INFO] [stdout] 50 | ops: Vec> [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `are_orthogonal` is never used [INFO] [stdout] --> src/spacegroups/finder.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | fn are_orthogonal(v: &[T], w: &[T]) -> bool [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/matrices.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 67 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Matrix::new(1, &Vec::from_iter(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/matrices.rs:297:54 [INFO] [stdout] | [INFO] [stdout] 297 | let data: Vec<_> = self.data.iter().map(|x| -x.clone()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/linear_algebra.rs:218:43 [INFO] [stdout] | [INFO] [stdout] 218 | v = v.iter().map(|x| -x.clone()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/linear_algebra.rs:322:14 [INFO] [stdout] | [INFO] [stdout] 302 | let mut basis = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | &basis.iter().map(|v| Matrix::row(&v)).collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/linear_algebra.rs:361:14 [INFO] [stdout] | [INFO] [stdout] 331 | let t = Matrix::hstack(&[self.clone(), rgt.clone()]).reduced_basis(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | let lft = t.submatrix(0..t.nrows, 0..colslft); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let rgt = t.submatrix(0..t.nrows, colslft..t.ncols); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | let t = Matrix::hstack(&[lft.transpose(), Matrix::identity(lft.ncols)]) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | .reduced_basis(); [INFO] [stdout] 344 | let b = t.submatrix(0..t.nrows, 0..lft.nrows).transpose(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | let u = t.submatrix(0..t.nrows, lft.nrows..t.ncols).transpose(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | [INFO] [stdout] 347 | let mut x = vec![]; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | let x = Matrix::vstack( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | Some(u * x) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 61 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Vector::new(&Vec::from_iter(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:122:42 [INFO] [stdout] | [INFO] [stdout] 122 | self.iter().cloned().map(|x| x % T::one()).collect() [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:326:21 [INFO] [stdout] | [INFO] [stdout] 325 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | Point::new(&Vec::from_iter(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:628:20 [INFO] [stdout] | [INFO] [stdout] 625 | fn adjust(src: AffineMap) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 628 | shift: Vector::from(src.shift.coords), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:635:29 [INFO] [stdout] | [INFO] [stdout] 634 | fn from(coords: Matrix) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 635 | Self::new(&coords, &Vector::zero(coords.nrows)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:769:20 [INFO] [stdout] | [INFO] [stdout] 768 | let cols: Vec<_> = basis.iter().map(|a| a.coords.clone()).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 769 | Self::new(&Matrix::hstack(&cols).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/geometry.rs:792:20 [INFO] [stdout] | [INFO] [stdout] 791 | fn from(coords: Matrix) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 792 | Self::new(&coords.into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pgraphs.rs:651:13 [INFO] [stdout] | [INFO] [stdout] 651 | e.clone(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pgraphs.rs:652:13 [INFO] [stdout] | [INFO] [stdout] 652 | self.edge_map.get(rhs.edge_map.get(e).unwrap()).unwrap().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spacegroups/lattices.rs:162:6 [INFO] [stdout] | [INFO] [stdout] 133 | fn selling_reduced(u: &[T], v: &[T], w: &[T], dot: F, epsilon: &T) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let s = neg(&add(&add(&u, &v), &w)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut vs = [u.to_vec(), v.to_vec(), w.to_vec(), s]; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | (vs[0].clone(), vs[1].clone(), vs[2].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spacegroups/lattices.rs:162:21 [INFO] [stdout] | [INFO] [stdout] 133 | fn selling_reduced(u: &[T], v: &[T], w: &[T], dot: F, epsilon: &T) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let s = neg(&add(&add(&u, &v), &w)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut vs = [u.to_vec(), v.to_vec(), w.to_vec(), s]; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | (vs[0].clone(), vs[1].clone(), vs[2].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spacegroups/lattices.rs:162:36 [INFO] [stdout] | [INFO] [stdout] 133 | fn selling_reduced(u: &[T], v: &[T], w: &[T], dot: F, epsilon: &T) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let s = neg(&add(&add(&u, &v), &w)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut vs = [u.to_vec(), v.to_vec(), w.to_vec(), s]; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | (vs[0].clone(), vs[1].clone(), vs[2].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spacegroups/finder.rs:192:41 [INFO] [stdout] | [INFO] [stdout] 192 | .map(|op| OperatorDetails::from(op.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symmetries.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 181 | let mut result = HashSet::from([identity.clone()]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let mut queue = VecDeque::from([identity.clone()]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | result.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symmetries.rs:459:5 [INFO] [stdout] | [INFO] [stdout] 456 | fn map_vec<'a, A, B, F>(fun: F, input: &'a Vec) -> Vec [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 459 | input.iter().map(fun).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-systre` (lib test) due to 21 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5c9b13f6b3fa1ae002e42d5bef7119564c0298df4f4822db9bc4c3b72865598d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c9b13f6b3fa1ae002e42d5bef7119564c0298df4f4822db9bc4c3b72865598d", kill_on_drop: false }` [INFO] [stdout] 5c9b13f6b3fa1ae002e42d5bef7119564c0298df4f4822db9bc4c3b72865598d