[INFO] cloning repository https://github.com/noamkatzir/express.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/noamkatzir/express.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnoamkatzir%2Fexpress.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnoamkatzir%2Fexpress.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 313044e2ea5a810393fa7b926895151f5d5a4eda [INFO] checking noamkatzir/express.rs against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnoamkatzir%2Fexpress.rs" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/noamkatzir/express.rs on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/noamkatzir/express.rs [INFO] finished tweaking git repo https://github.com/noamkatzir/express.rs [INFO] tweaked toml for git repo https://github.com/noamkatzir/express.rs written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/noamkatzir/express.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7d340680d3332648d0dd13cfac9cab4ed4f6bca07a154339c8b090c14351dfb7 [INFO] running `Command { std: "docker" "start" "-a" "7d340680d3332648d0dd13cfac9cab4ed4f6bca07a154339c8b090c14351dfb7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7d340680d3332648d0dd13cfac9cab4ed4f6bca07a154339c8b090c14351dfb7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d340680d3332648d0dd13cfac9cab4ed4f6bca07a154339c8b090c14351dfb7", kill_on_drop: false }` [INFO] [stdout] 7d340680d3332648d0dd13cfac9cab4ed4f6bca07a154339c8b090c14351dfb7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e10acf411ea4fe45a8a52bf4604d5a612cf0f2b03190f7b07db3a95f47b75a99 [INFO] running `Command { std: "docker" "start" "-a" "e10acf411ea4fe45a8a52bf4604d5a612cf0f2b03190f7b07db3a95f47b75a99", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.49 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling cc v1.0.30 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling crc32fast v1.1.2 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking num_cpus v1.10.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking express v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/router/router.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TcpListener` [INFO] [stdout] --> src/router/router.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | use std::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `threadpool::ThreadPool` [INFO] [stdout] --> src/router/router.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use threadpool::ThreadPool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/acceptor.rs:136:57 [INFO] [stdout] | [INFO] [stdout] 136 | fn parse_http_request(stream: &mut TcpStream) -> Result<(RequestBuilder),u8> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 136 - fn parse_http_request(stream: &mut TcpStream) -> Result<(RequestBuilder),u8> { [INFO] [stdout] 136 + fn parse_http_request(stream: &mut TcpStream) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/router/router.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TcpListener` [INFO] [stdout] --> src/router/router.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | use std::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `threadpool::ThreadPool` [INFO] [stdout] --> src/router/router.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use threadpool::ThreadPool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/acceptor.rs:136:57 [INFO] [stdout] | [INFO] [stdout] 136 | fn parse_http_request(stream: &mut TcpStream) -> Result<(RequestBuilder),u8> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 136 - fn parse_http_request(stream: &mut TcpStream) -> Result<(RequestBuilder),u8> { [INFO] [stdout] 136 + fn parse_http_request(stream: &mut TcpStream) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/router/route.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | cb: Option> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | cb: Option> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/router/route.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | cb: Option> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | cb: Option> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/router/route.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | impl RouteAction for Box { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | impl RouteAction for Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/router/route.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | impl RouteAction for Box { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | impl RouteAction for Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bind_on` [INFO] [stdout] --> src/router/router.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let bind_on = format!("{}:{}", host, port); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bind_on` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bind_on` [INFO] [stdout] --> src/router/router.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let bind_on = format!("{}:{}", host, port); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bind_on` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/router/reader.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | Variable(Bytes) [INFO] [stdout] | -------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 26 | Variable(()) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_http_request` is never used [INFO] [stdout] --> src/router/router.rs:73:4 [INFO] [stdout] | [INFO] [stdout] 73 | fn parse_http_request(mut stream: TcpStream) -> Result<(RequestBuilder, TcpStream),u8> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `run_request_callback` is never used [INFO] [stdout] --> src/router/router.rs:101:4 [INFO] [stdout] | [INFO] [stdout] 101 | fn run_request_callback(request: RequestBuilder, inner: Arc) -> RouterResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> src/acceptor.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Acceptor { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | inner: Arc [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/router/reader.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | Variable(Bytes) [INFO] [stdout] | -------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 26 | Variable(()) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_http_request` is never used [INFO] [stdout] --> src/router/router.rs:73:4 [INFO] [stdout] | [INFO] [stdout] 73 | fn parse_http_request(mut stream: TcpStream) -> Result<(RequestBuilder, TcpStream),u8> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `run_request_callback` is never used [INFO] [stdout] --> src/router/router.rs:101:4 [INFO] [stdout] | [INFO] [stdout] 101 | fn run_request_callback(request: RequestBuilder, inner: Arc) -> RouterResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> src/acceptor.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Acceptor { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | inner: Arc [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/bin/express.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/bin/express.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.20s [INFO] running `Command { std: "docker" "inspect" "e10acf411ea4fe45a8a52bf4604d5a612cf0f2b03190f7b07db3a95f47b75a99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e10acf411ea4fe45a8a52bf4604d5a612cf0f2b03190f7b07db3a95f47b75a99", kill_on_drop: false }` [INFO] [stdout] e10acf411ea4fe45a8a52bf4604d5a612cf0f2b03190f7b07db3a95f47b75a99 [INFO] checking noamkatzir/express.rs against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnoamkatzir%2Fexpress.rs" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/noamkatzir/express.rs on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/noamkatzir/express.rs [INFO] finished tweaking git repo https://github.com/noamkatzir/express.rs [INFO] tweaked toml for git repo https://github.com/noamkatzir/express.rs written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/noamkatzir/express.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5778d60d482be2d4806f8bdffcf60177e9a796f944ba4dd98d3cda3784fa083e [INFO] running `Command { std: "docker" "start" "-a" "5778d60d482be2d4806f8bdffcf60177e9a796f944ba4dd98d3cda3784fa083e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5778d60d482be2d4806f8bdffcf60177e9a796f944ba4dd98d3cda3784fa083e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5778d60d482be2d4806f8bdffcf60177e9a796f944ba4dd98d3cda3784fa083e", kill_on_drop: false }` [INFO] [stdout] 5778d60d482be2d4806f8bdffcf60177e9a796f944ba4dd98d3cda3784fa083e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc9d65a8869d63401a86aaad88dd744678e3873d09ac96114c9c42f40ecba199 [INFO] running `Command { std: "docker" "start" "-a" "fc9d65a8869d63401a86aaad88dd744678e3873d09ac96114c9c42f40ecba199", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.49 [INFO] [stderr] Compiling cc v1.0.30 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling crc32fast v1.1.2 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking num_cpus v1.10.0 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking express v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/router/router.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TcpListener` [INFO] [stdout] --> src/router/router.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | use std::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `threadpool::ThreadPool` [INFO] [stdout] --> src/router/router.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use threadpool::ThreadPool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/acceptor.rs:136:57 [INFO] [stdout] | [INFO] [stdout] 136 | fn parse_http_request(stream: &mut TcpStream) -> Result<(RequestBuilder),u8> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 136 - fn parse_http_request(stream: &mut TcpStream) -> Result<(RequestBuilder),u8> { [INFO] [stdout] 136 + fn parse_http_request(stream: &mut TcpStream) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/router/router.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TcpListener` [INFO] [stdout] --> src/router/router.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | use std::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `threadpool::ThreadPool` [INFO] [stdout] --> src/router/router.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use threadpool::ThreadPool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/acceptor.rs:136:57 [INFO] [stdout] | [INFO] [stdout] 136 | fn parse_http_request(stream: &mut TcpStream) -> Result<(RequestBuilder),u8> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 136 - fn parse_http_request(stream: &mut TcpStream) -> Result<(RequestBuilder),u8> { [INFO] [stdout] 136 + fn parse_http_request(stream: &mut TcpStream) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/router/route.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | cb: Option> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | cb: Option> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/router/route.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | cb: Option> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | cb: Option> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/router/route.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | impl RouteAction for Box { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | impl RouteAction for Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/router/route.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | impl RouteAction for Box { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | impl RouteAction for Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bind_on` [INFO] [stdout] --> src/router/router.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let bind_on = format!("{}:{}", host, port); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bind_on` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/router/reader.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | Variable(Bytes) [INFO] [stdout] | -------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 26 | Variable(()) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_http_request` is never used [INFO] [stdout] --> src/router/router.rs:73:4 [INFO] [stdout] | [INFO] [stdout] 73 | fn parse_http_request(mut stream: TcpStream) -> Result<(RequestBuilder, TcpStream),u8> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `run_request_callback` is never used [INFO] [stdout] --> src/router/router.rs:101:4 [INFO] [stdout] | [INFO] [stdout] 101 | fn run_request_callback(request: RequestBuilder, inner: Arc) -> RouterResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> src/acceptor.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Acceptor { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | inner: Arc [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router/route.rs:97:70 [INFO] [stdout] | [INFO] [stdout] 97 | let res: HashMap<_,_> = uri_params.iter().map(|(key,value)| (key.clone(), Bytes::from(*value))).collect(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router/route.rs:97:83 [INFO] [stdout] | [INFO] [stdout] 97 | let res: HashMap<_,_> = uri_params.iter().map(|(key,value)| (key.clone(), Bytes::from(*value))).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router/router.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 73 | fn parse_http_request(mut stream: TcpStream) -> Result<(RequestBuilder, TcpStream),u8> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let mut request = RequestBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok((request, stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:131:21 [INFO] [stdout] | [INFO] [stdout] 101 | fn new( id: usize, sender: mpsc::Sender, receiver: Arc>>, [INFO] [stdout] | ----------------------------- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | counter: Arc, inner: Arc) -> ConnectionHandler { [INFO] [stdout] | ------------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | let thread = thread::spawn(move ||{ [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `express` (lib test) due to 5 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `bind_on` [INFO] [stdout] --> src/router/router.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let bind_on = format!("{}:{}", host, port); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bind_on` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/router/reader.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | Variable(Bytes) [INFO] [stdout] | -------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 26 | Variable(()) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_http_request` is never used [INFO] [stdout] --> src/router/router.rs:73:4 [INFO] [stdout] | [INFO] [stdout] 73 | fn parse_http_request(mut stream: TcpStream) -> Result<(RequestBuilder, TcpStream),u8> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `run_request_callback` is never used [INFO] [stdout] --> src/router/router.rs:101:4 [INFO] [stdout] | [INFO] [stdout] 101 | fn run_request_callback(request: RequestBuilder, inner: Arc) -> RouterResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> src/acceptor.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Acceptor { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | inner: Arc [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router/route.rs:97:70 [INFO] [stdout] | [INFO] [stdout] 97 | let res: HashMap<_,_> = uri_params.iter().map(|(key,value)| (key.clone(), Bytes::from(*value))).collect(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router/route.rs:97:83 [INFO] [stdout] | [INFO] [stdout] 97 | let res: HashMap<_,_> = uri_params.iter().map(|(key,value)| (key.clone(), Bytes::from(*value))).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router/router.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 73 | fn parse_http_request(mut stream: TcpStream) -> Result<(RequestBuilder, TcpStream),u8> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let mut request = RequestBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok((request, stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:131:21 [INFO] [stdout] | [INFO] [stdout] 101 | fn new( id: usize, sender: mpsc::Sender, receiver: Arc>>, [INFO] [stdout] | ----------------------------- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | counter: Arc, inner: Arc) -> ConnectionHandler { [INFO] [stdout] | ------------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | let thread = thread::spawn(move ||{ [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `express` (lib) due to 5 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fc9d65a8869d63401a86aaad88dd744678e3873d09ac96114c9c42f40ecba199", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc9d65a8869d63401a86aaad88dd744678e3873d09ac96114c9c42f40ecba199", kill_on_drop: false }` [INFO] [stdout] fc9d65a8869d63401a86aaad88dd744678e3873d09ac96114c9c42f40ecba199