[INFO] cloning repository https://github.com/natassaf/ID2203-MMO [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/natassaf/ID2203-MMO" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnatassaf%2FID2203-MMO", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnatassaf%2FID2203-MMO'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7223c3d153953c28af9d73541cbbd0446a37d25d [INFO] checking natassaf/ID2203-MMO against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnatassaf%2FID2203-MMO" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/natassaf/ID2203-MMO on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/natassaf/ID2203-MMO [INFO] finished tweaking git repo https://github.com/natassaf/ID2203-MMO [INFO] tweaked toml for git repo https://github.com/natassaf/ID2203-MMO written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/natassaf/ID2203-MMO already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zerocopy v0.6.6 [INFO] [stderr] Downloaded omnipaxos_storage v0.2.2 [INFO] [stderr] Downloaded omnipaxos_macros v0.1.3 [INFO] [stderr] Downloaded page_size v0.4.2 [INFO] [stderr] Downloaded hermit-abi v0.3.5 [INFO] [stderr] Downloaded commitlog v0.2.0 [INFO] [stderr] Downloaded omnipaxos v0.2.2 [INFO] [stderr] Downloaded crc32c v0.6.5 [INFO] [stderr] Downloaded zerocopy-derive v0.6.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d2962a4fb665daece5a39d857926bf74942404d1aa0d893a4bd93c983b6c2ae4 [INFO] running `Command { std: "docker" "start" "-a" "d2962a4fb665daece5a39d857926bf74942404d1aa0d893a4bd93c983b6c2ae4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d2962a4fb665daece5a39d857926bf74942404d1aa0d893a4bd93c983b6c2ae4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2962a4fb665daece5a39d857926bf74942404d1aa0d893a4bd93c983b6c2ae4", kill_on_drop: false }` [INFO] [stdout] d2962a4fb665daece5a39d857926bf74942404d1aa0d893a4bd93c983b6c2ae4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 638c07b4029d6f56f4bab750bf94d28d2b2478db2a4796c0b64175d556a15083 [INFO] running `Command { std: "docker" "start" "-a" "638c07b4029d6f56f4bab750bf94d28d2b2478db2a4796c0b64175d556a15083", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking page_size v0.4.2 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling crc32c v0.6.5 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking commitlog v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling omnipaxos_macros v0.1.3 [INFO] [stderr] Compiling zerocopy-derive v0.6.6 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking zerocopy v0.6.6 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking omnipaxos v0.2.2 [INFO] [stderr] Checking omnipaxos_storage v0.2.2 [INFO] [stderr] Checking omni-spacetimedb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Arc`, `Mutex`, and `fs::File` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | fs::File, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | io::{Read, Write}, [INFO] [stdout] 8 | sync::{Arc, Mutex}, [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `omnipaxos::OmniPaxos` [INFO] [stdout] --> src/node/mod.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use omnipaxos::OmniPaxos; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `omnipaxos_storage::memory_storage::MemoryStorage` [INFO] [stdout] --> src/node/mod.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use omnipaxos_storage::memory_storage::MemoryStorage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc`, `Mutex`, and `fs::File` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | fs::File, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | io::{Read, Write}, [INFO] [stdout] 8 | sync::{Arc, Mutex}, [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `omnipaxos::OmniPaxos` [INFO] [stdout] --> src/node/mod.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use omnipaxos::OmniPaxos; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `remove_disconnected_nodes_interval` [INFO] [stdout] --> src/node/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | let mut remove_disconnected_nodes_interval = time::interval(UPDATE_DB_PERIOD ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_remove_disconnected_nodes_interval` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `receiver` [INFO] [stdout] --> src/node/mod.rs:94:25 [INFO] [stdout] | [INFO] [stdout] 94 | let receiver = msg.get_receiver(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_receiver` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/node/mod.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | let mut remove_disconnected_nodes_interval = time::interval(UPDATE_DB_PERIOD ); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `remove_disconnected_nodes_interval` [INFO] [stdout] --> src/node/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | let mut remove_disconnected_nodes_interval = time::interval(UPDATE_DB_PERIOD ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_remove_disconnected_nodes_interval` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `receiver` [INFO] [stdout] --> src/node/mod.rs:94:25 [INFO] [stdout] | [INFO] [stdout] 94 | let receiver = msg.get_receiver(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_receiver` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/node/mod.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | let mut remove_disconnected_nodes_interval = time::interval(UPDATE_DB_PERIOD ); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | Ok(res) => println!("entry appended successfully!"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx_offset` [INFO] [stdout] --> src/node/mod.rs:173:14 [INFO] [stdout] | [INFO] [stdout] 173 | for (tx_offset, tx_data) in decided_entries.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tx_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_offset` [INFO] [stdout] --> src/node/mod.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | let current_offset = self.datastore.get_cur_offset(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `repl_offset` [INFO] [stdout] --> src/node/mod.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 193 | let repl_offset = self.datastore.get_replicated_offset(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_repl_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/durability/mod.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct ObserverId(u64); [INFO] [stdout] | ---------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ObserverId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `serialize` and `deserialize` are never used [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 17 | impl OmniLogEntry { [INFO] [stdout] | ----------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | fn serialize(&self, writer: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | fn deserialize(reader: &mut R) -> std::io::Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | Ok(res) => println!("entry appended successfully!"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx_offset` [INFO] [stdout] --> src/node/mod.rs:173:14 [INFO] [stdout] | [INFO] [stdout] 173 | for (tx_offset, tx_data) in decided_entries.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tx_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_offset` [INFO] [stdout] --> src/node/mod.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | let current_offset = self.datastore.get_cur_offset(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `repl_offset` [INFO] [stdout] --> src/node/mod.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 193 | let repl_offset = self.datastore.get_replicated_offset(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_repl_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `nodes` [INFO] [stdout] --> src/node/mod.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | let mut nodes: HashMap>, JoinHandle<()>)> = HashMap::new(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_nodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/node/mod.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | let mut nodes: HashMap>, JoinHandle<()>)> = HashMap::new(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `handler` [INFO] [stdout] --> src/node/mod.rs:427:28 [INFO] [stdout] | [INFO] [stdout] 427 | let (alive_server, handler) = nodes.get(alive_servers[0]).unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_handler` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `handler` [INFO] [stdout] --> src/node/mod.rs:483:28 [INFO] [stdout] | [INFO] [stdout] 483 | let (alive_server, handler) = nodes.get(alive_servers[0]).unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_handler` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_leader` [INFO] [stdout] --> src/node/mod.rs:490:14 [INFO] [stdout] | [INFO] [stdout] 490 | let (new_leader,_) = nodes.get(&new_leader_id).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_leader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `leader_server` [INFO] [stdout] --> src/node/mod.rs:611:14 [INFO] [stdout] | [INFO] [stdout] 611 | let (leader_server,_ )= nodes.get(&leader_id).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_leader_server` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_replicated_tx` [INFO] [stdout] --> src/node/mod.rs:740:17 [INFO] [stdout] | [INFO] [stdout] 740 | let last_replicated_tx: example_datastore::Tx = following_server [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_replicated_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_replicated_tx` [INFO] [stdout] --> src/node/mod.rs:753:17 [INFO] [stdout] | [INFO] [stdout] 753 | let last_replicated_tx: example_datastore::Tx = following_server [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_replicated_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/durability/mod.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct ObserverId(u64); [INFO] [stdout] | ---------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ObserverId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `serialize` and `deserialize` are never used [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 17 | impl OmniLogEntry { [INFO] [stdout] | ----------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | fn serialize(&self, writer: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | fn deserialize(reader: &mut R) -> std::io::Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_example_transaction` is never used [INFO] [stdout] --> src/node/mod.rs:265:8 [INFO] [stdout] | [INFO] [stdout] 265 | fn get_example_transaction(datastore: &ExampleDatastore)->example_datastore::MutTx{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.01s [INFO] running `Command { std: "docker" "inspect" "638c07b4029d6f56f4bab750bf94d28d2b2478db2a4796c0b64175d556a15083", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "638c07b4029d6f56f4bab750bf94d28d2b2478db2a4796c0b64175d556a15083", kill_on_drop: false }` [INFO] [stdout] 638c07b4029d6f56f4bab750bf94d28d2b2478db2a4796c0b64175d556a15083 [INFO] checking natassaf/ID2203-MMO against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnatassaf%2FID2203-MMO" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/natassaf/ID2203-MMO on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/natassaf/ID2203-MMO [INFO] finished tweaking git repo https://github.com/natassaf/ID2203-MMO [INFO] tweaked toml for git repo https://github.com/natassaf/ID2203-MMO written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/natassaf/ID2203-MMO already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f0715d4102a4da3269850bb39fe7047d6d396346b520c983f660939c3ea67f1a [INFO] running `Command { std: "docker" "start" "-a" "f0715d4102a4da3269850bb39fe7047d6d396346b520c983f660939c3ea67f1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f0715d4102a4da3269850bb39fe7047d6d396346b520c983f660939c3ea67f1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0715d4102a4da3269850bb39fe7047d6d396346b520c983f660939c3ea67f1a", kill_on_drop: false }` [INFO] [stdout] f0715d4102a4da3269850bb39fe7047d6d396346b520c983f660939c3ea67f1a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e51753b0f9c85118e5cd3ad24acbb229377d5a75a6363cda16a41b688cd0001 [INFO] running `Command { std: "docker" "start" "-a" "8e51753b0f9c85118e5cd3ad24acbb229377d5a75a6363cda16a41b688cd0001", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking page_size v0.4.2 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling crc32c v0.6.5 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking commitlog v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling omnipaxos_macros v0.1.3 [INFO] [stderr] Compiling zerocopy-derive v0.6.6 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking zerocopy v0.6.6 [INFO] [stderr] Checking omnipaxos v0.2.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking omnipaxos_storage v0.2.2 [INFO] [stderr] Checking omni-spacetimedb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Arc`, `Mutex`, and `fs::File` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | fs::File, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | io::{Read, Write}, [INFO] [stdout] 8 | sync::{Arc, Mutex}, [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `omnipaxos::OmniPaxos` [INFO] [stdout] --> src/node/mod.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use omnipaxos::OmniPaxos; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `omnipaxos_storage::memory_storage::MemoryStorage` [INFO] [stdout] --> src/node/mod.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use omnipaxos_storage::memory_storage::MemoryStorage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc`, `Mutex`, and `fs::File` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | fs::File, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | io::{Read, Write}, [INFO] [stdout] 8 | sync::{Arc, Mutex}, [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `omnipaxos::OmniPaxos` [INFO] [stdout] --> src/node/mod.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use omnipaxos::OmniPaxos; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `remove_disconnected_nodes_interval` [INFO] [stdout] --> src/node/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | let mut remove_disconnected_nodes_interval = time::interval(UPDATE_DB_PERIOD ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_remove_disconnected_nodes_interval` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `receiver` [INFO] [stdout] --> src/node/mod.rs:94:25 [INFO] [stdout] | [INFO] [stdout] 94 | let receiver = msg.get_receiver(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_receiver` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/node/mod.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | let mut remove_disconnected_nodes_interval = time::interval(UPDATE_DB_PERIOD ); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `remove_disconnected_nodes_interval` [INFO] [stdout] --> src/node/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | let mut remove_disconnected_nodes_interval = time::interval(UPDATE_DB_PERIOD ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_remove_disconnected_nodes_interval` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `receiver` [INFO] [stdout] --> src/node/mod.rs:94:25 [INFO] [stdout] | [INFO] [stdout] 94 | let receiver = msg.get_receiver(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_receiver` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/node/mod.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | let mut remove_disconnected_nodes_interval = time::interval(UPDATE_DB_PERIOD ); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | Ok(res) => println!("entry appended successfully!"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx_offset` [INFO] [stdout] --> src/node/mod.rs:173:14 [INFO] [stdout] | [INFO] [stdout] 173 | for (tx_offset, tx_data) in decided_entries.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tx_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_offset` [INFO] [stdout] --> src/node/mod.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | let current_offset = self.datastore.get_cur_offset(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `repl_offset` [INFO] [stdout] --> src/node/mod.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 193 | let repl_offset = self.datastore.get_replicated_offset(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_repl_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/durability/mod.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct ObserverId(u64); [INFO] [stdout] | ---------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ObserverId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `serialize` and `deserialize` are never used [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 17 | impl OmniLogEntry { [INFO] [stdout] | ----------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | fn serialize(&self, writer: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | fn deserialize(reader: &mut R) -> std::io::Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 74 | let handles: Vec> = node_runners.into_iter().map(|mut node_runner| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | runtime.spawn(async move { [INFO] [stdout] | _______________________^ [INFO] [stdout] 76 | | node_runner.run().await; // Use tmp_node_runner in the spawned task [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 242 | mut tx: Self::MutTx, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | let tx_data = TxData { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | Ok(TxResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 284 | | tx_offset: offset, [INFO] [stdout] 285 | | tx_data, [INFO] [stdout] 286 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:270:38 [INFO] [stdout] | [INFO] [stdout] 270 | .map(|s| RowData(Arc::from(serialize_example_row(s).unwrap()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:277:38 [INFO] [stdout] | [INFO] [stdout] 277 | .map(|s| RowData(Arc::from(s.as_bytes()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(RowData(Arc::from(buffer.into_boxed_slice()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 71 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(InsertList { [INFO] [stdout] | ________^ [INFO] [stdout] 76 | | table_id, [INFO] [stdout] 77 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 95 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(DeleteList { [INFO] [stdout] | ________^ [INFO] [stdout] 100 | | table_id, [INFO] [stdout] 101 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 133 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(TxData { [INFO] [stdout] | ____________^ [INFO] [stdout] 153 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 154 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 155 | | truncs: Arc::from(truncs.into_boxed_slice()), [INFO] [stdout] 156 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | let tx_data = TxData::deserialize(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(LogEntry { tx_offset, tx_data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:150:18 [INFO] [stdout] | [INFO] [stdout] 147 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | Box::new(std::iter::from_fn(move || { [INFO] [stdout] | __________________^ [INFO] [stdout] 151 | | match LogEntry::deserialize(&mut file) { [INFO] [stdout] 152 | | Ok(log_entry) => Some((log_entry.tx_offset, log_entry.tx_data)), [INFO] [stdout] 153 | | Err(_) => None, [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:151:19 [INFO] [stdout] | [INFO] [stdout] 147 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | match LogEntry::deserialize(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | let tx_data = TxData::deserialize(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(OmniLogEntry { tx_offset, tx_data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:69:18 [INFO] [stdout] | [INFO] [stdout] 60 | let log_iter = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let decided_entries: Vec<(TxOffset, TxData)> = log_iter [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Box::new(decided_entries.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:66:68 [INFO] [stdout] | [INFO] [stdout] 66 | .filter_map(|log_entry| Self::decode_log_entry_decided(log_entry.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:85:18 [INFO] [stdout] | [INFO] [stdout] 76 | let entries_after_offset = match self.omnipaxos.read_decided_suffix(offset.0) { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Some(entries) => entries.clone(), [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let decided_entries: Vec<(TxOffset, TxData)> = entries_after_offset [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Box::new(decided_entries.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:82:68 [INFO] [stdout] | [INFO] [stdout] 82 | .filter_map(|log_entry| Self::decode_log_entry_decided(log_entry.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `omni-spacetimedb` (bin "omni-spacetimedb") due to 17 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | Ok(res) => println!("entry appended successfully!"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx_offset` [INFO] [stdout] --> src/node/mod.rs:173:14 [INFO] [stdout] | [INFO] [stdout] 173 | for (tx_offset, tx_data) in decided_entries.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tx_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_offset` [INFO] [stdout] --> src/node/mod.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | let current_offset = self.datastore.get_cur_offset(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `repl_offset` [INFO] [stdout] --> src/node/mod.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 193 | let repl_offset = self.datastore.get_replicated_offset(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_repl_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `nodes` [INFO] [stdout] --> src/node/mod.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | let mut nodes: HashMap>, JoinHandle<()>)> = HashMap::new(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_nodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/node/mod.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | let mut nodes: HashMap>, JoinHandle<()>)> = HashMap::new(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `handler` [INFO] [stdout] --> src/node/mod.rs:427:28 [INFO] [stdout] | [INFO] [stdout] 427 | let (alive_server, handler) = nodes.get(alive_servers[0]).unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_handler` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `handler` [INFO] [stdout] --> src/node/mod.rs:483:28 [INFO] [stdout] | [INFO] [stdout] 483 | let (alive_server, handler) = nodes.get(alive_servers[0]).unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_handler` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_leader` [INFO] [stdout] --> src/node/mod.rs:490:14 [INFO] [stdout] | [INFO] [stdout] 490 | let (new_leader,_) = nodes.get(&new_leader_id).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_leader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `leader_server` [INFO] [stdout] --> src/node/mod.rs:611:14 [INFO] [stdout] | [INFO] [stdout] 611 | let (leader_server,_ )= nodes.get(&leader_id).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_leader_server` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_replicated_tx` [INFO] [stdout] --> src/node/mod.rs:740:17 [INFO] [stdout] | [INFO] [stdout] 740 | let last_replicated_tx: example_datastore::Tx = following_server [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_replicated_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_replicated_tx` [INFO] [stdout] --> src/node/mod.rs:753:17 [INFO] [stdout] | [INFO] [stdout] 753 | let last_replicated_tx: example_datastore::Tx = following_server [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_replicated_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/durability/mod.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct ObserverId(u64); [INFO] [stdout] | ---------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ObserverId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `serialize` and `deserialize` are never used [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 17 | impl OmniLogEntry { [INFO] [stdout] | ----------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | fn serialize(&self, writer: &mut W) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | fn deserialize(reader: &mut R) -> std::io::Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_example_transaction` is never used [INFO] [stdout] --> src/node/mod.rs:265:8 [INFO] [stdout] | [INFO] [stdout] 265 | fn get_example_transaction(datastore: &ExampleDatastore)->example_datastore::MutTx{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 74 | let handles: Vec> = node_runners.into_iter().map(|mut node_runner| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | runtime.spawn(async move { [INFO] [stdout] | _______________________^ [INFO] [stdout] 76 | | node_runner.run().await; // Use tmp_node_runner in the spawned task [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 242 | mut tx: Self::MutTx, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | let tx_data = TxData { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | Ok(TxResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 284 | | tx_offset: offset, [INFO] [stdout] 285 | | tx_data, [INFO] [stdout] 286 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:270:38 [INFO] [stdout] | [INFO] [stdout] 270 | .map(|s| RowData(Arc::from(serialize_example_row(s).unwrap()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:277:38 [INFO] [stdout] | [INFO] [stdout] 277 | .map(|s| RowData(Arc::from(s.as_bytes()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(RowData(Arc::from(buffer.into_boxed_slice()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 71 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(InsertList { [INFO] [stdout] | ________^ [INFO] [stdout] 76 | | table_id, [INFO] [stdout] 77 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 95 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(DeleteList { [INFO] [stdout] | ________^ [INFO] [stdout] 100 | | table_id, [INFO] [stdout] 101 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 133 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(TxData { [INFO] [stdout] | ____________^ [INFO] [stdout] 153 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 154 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 155 | | truncs: Arc::from(truncs.into_boxed_slice()), [INFO] [stdout] 156 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | let tx_data = TxData::deserialize(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(LogEntry { tx_offset, tx_data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:150:18 [INFO] [stdout] | [INFO] [stdout] 147 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | Box::new(std::iter::from_fn(move || { [INFO] [stdout] | __________________^ [INFO] [stdout] 151 | | match LogEntry::deserialize(&mut file) { [INFO] [stdout] 152 | | Ok(log_entry) => Some((log_entry.tx_offset, log_entry.tx_data)), [INFO] [stdout] 153 | | Err(_) => None, [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:151:19 [INFO] [stdout] | [INFO] [stdout] 147 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | match LogEntry::deserialize(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | let tx_data = TxData::deserialize(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(OmniLogEntry { tx_offset, tx_data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:69:18 [INFO] [stdout] | [INFO] [stdout] 60 | let log_iter = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let decided_entries: Vec<(TxOffset, TxData)> = log_iter [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Box::new(decided_entries.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:66:68 [INFO] [stdout] | [INFO] [stdout] 66 | .filter_map(|log_entry| Self::decode_log_entry_decided(log_entry.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:85:18 [INFO] [stdout] | [INFO] [stdout] 76 | let entries_after_offset = match self.omnipaxos.read_decided_suffix(offset.0) { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Some(entries) => entries.clone(), [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let decided_entries: Vec<(TxOffset, TxData)> = entries_after_offset [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Box::new(decided_entries.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:82:68 [INFO] [stdout] | [INFO] [stdout] 82 | .filter_map(|log_entry| Self::decode_log_entry_decided(log_entry.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:478:61 [INFO] [stdout] | [INFO] [stdout] 478 | let _disc:Vec<()> = nodes.iter().map(|(node_id, _)| leader_server.lock().unwrap().disconnect(*node_id)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:491:57 [INFO] [stdout] | [INFO] [stdout] 491 | let _:Vec<()> = nodes.iter().map(|(node_id, _)| leader_server.lock().unwrap().reconnect(*node_id)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `omni-spacetimedb` (bin "omni-spacetimedb" test) due to 19 previous errors; 20 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8e51753b0f9c85118e5cd3ad24acbb229377d5a75a6363cda16a41b688cd0001", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e51753b0f9c85118e5cd3ad24acbb229377d5a75a6363cda16a41b688cd0001", kill_on_drop: false }` [INFO] [stdout] 8e51753b0f9c85118e5cd3ad24acbb229377d5a75a6363cda16a41b688cd0001