[INFO] cloning repository https://github.com/mxinden/kvs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mxinden/kvs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmxinden%2Fkvs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmxinden%2Fkvs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8d98845e342ae00baacb1d12711f4cde99101c39 [INFO] checking mxinden/kvs against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmxinden%2Fkvs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mxinden/kvs on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mxinden/kvs [INFO] finished tweaking git repo https://github.com/mxinden/kvs [INFO] tweaked toml for git repo https://github.com/mxinden/kvs written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/mxinden/kvs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded historian v4.0.3 [INFO] [stderr] Downloaded serde_bytes v0.11.1 [INFO] [stderr] Downloaded normalize-line-endings v0.2.2 [INFO] [stderr] Downloaded panic-control v0.1.4 [INFO] [stderr] Downloaded tinytemplate v1.0.2 [INFO] [stderr] Downloaded pagecache v0.17.0 [INFO] [stderr] Downloaded sled v0.24.1 [INFO] [stderr] Downloaded regex-automata v0.1.7 [INFO] [stderr] Downloaded bstr v0.2.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 482fb63aff7aa81fa11c149acbf9c650006e05677e8d9f638eb897315ebf6ba0 [INFO] running `Command { std: "docker" "start" "-a" "482fb63aff7aa81fa11c149acbf9c650006e05677e8d9f638eb897315ebf6ba0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "482fb63aff7aa81fa11c149acbf9c650006e05677e8d9f638eb897315ebf6ba0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "482fb63aff7aa81fa11c149acbf9c650006e05677e8d9f638eb897315ebf6ba0", kill_on_drop: false }` [INFO] [stdout] 482fb63aff7aa81fa11c149acbf9c650006e05677e8d9f638eb897315ebf6ba0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2a9b4cab71bca0945954b97543c2e9dd66e19b1cb1e11366ff8293d0e290bc14 [INFO] running `Command { std: "docker" "start" "-a" "2a9b4cab71bca0945954b97543c2e9dd66e19b1cb1e11366ff8293d0e290bc14", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.60 [INFO] [stderr] Compiling autocfg v0.1.5 [INFO] [stderr] Checking spin v0.5.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.40 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling serde v1.0.97 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling log v0.4.7 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling rayon-core v1.5.0 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Compiling regex v1.1.9 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking regex-syntax v0.6.8 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking getrandom v0.1.6 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Compiling rand_chacha v0.2.0 [INFO] [stderr] Checking aho-corasick v0.7.4 [INFO] [stderr] Compiling bincode v1.1.4 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking utf8-ranges v1.0.3 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Checking rayon v1.1.0 [INFO] [stderr] Checking rand_core v0.5.0 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking futures v0.1.28 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking historian v4.0.3 [INFO] [stderr] Checking rustc-demangle v0.1.15 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking rand v0.7.0 [INFO] [stderr] Checking backtrace v0.3.33 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking regex-automata v0.1.7 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Compiling escargot v0.4.0 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking predicates v1.0.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking panic-control v0.1.4 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.97 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking hashbrown v0.3.1 [INFO] [stderr] Checking serde_bytes v0.11.1 [INFO] [stderr] Checking bstr v0.2.2 [INFO] [stderr] Checking pagecache v0.17.0 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking tinytemplate v1.0.2 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stderr] Checking assert_cmd v0.11.1 [INFO] [stderr] Checking sled v0.24.1 [INFO] [stderr] Checking kvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/server.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/server.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/server.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/server.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/thread_pool/shared.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | type Job = Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | type Job = Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/thread_pool/shared.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | type Job = Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | type Job = Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `threads` [INFO] [stdout] --> src/thread_pool/naive.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | fn new(threads: u32) -> Result [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_threads` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `threads` [INFO] [stdout] --> src/thread_pool/naive.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | fn new(threads: u32) -> Result [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_threads` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/thread_pool/shared.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/thread_pool/shared.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rx` is never read [INFO] [stdout] --> src/thread_pool/shared.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct SharedQueueThreadPool { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] 12 | tx: Sender, [INFO] [stdout] 13 | rx: Arc>>, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rx` is never read [INFO] [stdout] --> src/thread_pool/shared.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct SharedQueueThreadPool { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] 12 | tx: Sender, [INFO] [stdout] 13 | rx: Arc>>, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/thread_pool/shared.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | self.tx.send(Box::new(job)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 63 | let _ = self.tx.send(Box::new(job)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/thread_pool/shared.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | self.tx.send(Box::new(job)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 63 | let _ = self.tx.send(Box::new(job)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AtomicUsize` and `Ordering` [INFO] [stdout] --> tests/thread_pool.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::atomic::{AtomicUsize, Ordering}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crossbeam_utils::sync::WaitGroup` [INFO] [stdout] --> tests/thread_pool.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crossbeam_utils::sync::WaitGroup; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/bin/kvs-server.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TcpListener` and `TcpStream` [INFO] [stdout] --> src/bin/kvs-server.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | use std::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/bin/kvs-server.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/bin/kvs-server.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Req`, `Resp`, and `SuccResp` [INFO] [stdout] --> src/bin/kvs-server.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | use kvs::network::{Req, Resp, SuccResp}; [INFO] [stdout] | ^^^ ^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/bin/kvs-server.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TcpListener` and `TcpStream` [INFO] [stdout] --> src/bin/kvs-server.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | use std::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/bin/kvs-server.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/bin/kvs-server.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Req`, `Resp`, and `SuccResp` [INFO] [stdout] --> src/bin/kvs-server.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | use kvs::network::{Req, Resp, SuccResp}; [INFO] [stdout] | ^^^ ^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Result` [INFO] [stdout] --> benches/store.rs:4:31 [INFO] [stdout] | [INFO] [stdout] 4 | use kvs::{KvStore, KvsEngine, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `criterion::black_box` [INFO] [stdout] --> benches/store.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use criterion::black_box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `kvs::thread_pool::ThreadPool` [INFO] [stdout] --> src/bin/kvs-server.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use kvs::thread_pool::ThreadPool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `kvs::thread_pool::ThreadPool` [INFO] [stdout] --> src/bin/kvs-server.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use kvs::thread_pool::ThreadPool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `KvsEngine` [INFO] [stdout] --> benches/store.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | use kvs::{KvStore, KvsEngine, Result}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `KvsEngine` [INFO] [stdout] --> tests/kv_store.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | use kvs::{KvStore, KvsEngine, Result}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.60s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: criterion v0.2.11 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "2a9b4cab71bca0945954b97543c2e9dd66e19b1cb1e11366ff8293d0e290bc14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a9b4cab71bca0945954b97543c2e9dd66e19b1cb1e11366ff8293d0e290bc14", kill_on_drop: false }` [INFO] [stdout] 2a9b4cab71bca0945954b97543c2e9dd66e19b1cb1e11366ff8293d0e290bc14 [INFO] checking mxinden/kvs against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmxinden%2Fkvs" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mxinden/kvs on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mxinden/kvs [INFO] finished tweaking git repo https://github.com/mxinden/kvs [INFO] tweaked toml for git repo https://github.com/mxinden/kvs written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/mxinden/kvs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 326167e4f3fab88bc7653a4515021edf9a8a0fd6ac577a20dda6de3b9fce553e [INFO] running `Command { std: "docker" "start" "-a" "326167e4f3fab88bc7653a4515021edf9a8a0fd6ac577a20dda6de3b9fce553e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "326167e4f3fab88bc7653a4515021edf9a8a0fd6ac577a20dda6de3b9fce553e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "326167e4f3fab88bc7653a4515021edf9a8a0fd6ac577a20dda6de3b9fce553e", kill_on_drop: false }` [INFO] [stdout] 326167e4f3fab88bc7653a4515021edf9a8a0fd6ac577a20dda6de3b9fce553e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4fd34f443703493814f28cda028b1aa12ad654c089553d98e741b75264f2ba5 [INFO] running `Command { std: "docker" "start" "-a" "a4fd34f443703493814f28cda028b1aa12ad654c089553d98e741b75264f2ba5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.60 [INFO] [stderr] Compiling autocfg v0.1.5 [INFO] [stderr] Checking spin v0.5.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.40 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling serde v1.0.97 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling log v0.4.7 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling rayon-core v1.5.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Compiling regex v1.1.9 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking regex-syntax v0.6.8 [INFO] [stderr] Checking getrandom v0.1.6 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling bincode v1.1.4 [INFO] [stderr] Compiling rand_chacha v0.2.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking aho-corasick v0.7.4 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Checking utf8-ranges v1.0.3 [INFO] [stderr] Checking rayon v1.1.0 [INFO] [stderr] Checking rand_core v0.5.0 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking rustc-demangle v0.1.15 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking futures v0.1.28 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking historian v4.0.3 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand v0.7.0 [INFO] [stderr] Checking backtrace v0.3.33 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking regex-automata v0.1.7 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Compiling escargot v0.4.0 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking predicates v1.0.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking panic-control v0.1.4 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.97 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking hashbrown v0.3.1 [INFO] [stderr] Checking serde_bytes v0.11.1 [INFO] [stderr] Checking bstr v0.2.2 [INFO] [stderr] Checking pagecache v0.17.0 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking tinytemplate v1.0.2 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stderr] Checking assert_cmd v0.11.1 [INFO] [stderr] Checking sled v0.24.1 [INFO] [stderr] Checking kvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/server.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/server.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/server.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/server.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/thread_pool/shared.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | type Job = Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | type Job = Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/thread_pool/shared.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | type Job = Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | type Job = Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `threads` [INFO] [stdout] --> src/thread_pool/naive.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | fn new(threads: u32) -> Result [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_threads` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/thread_pool/shared.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `threads` [INFO] [stdout] --> src/thread_pool/naive.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | fn new(threads: u32) -> Result [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_threads` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/thread_pool/shared.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rx` is never read [INFO] [stdout] --> src/thread_pool/shared.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct SharedQueueThreadPool { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] 12 | tx: Sender, [INFO] [stdout] 13 | rx: Arc>>, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/mod.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/mod.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/mod.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/shared.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 25 | let (tx, rx) = channel::(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let rx = Arc::new(Mutex::new(rx)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let mut handles = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(SharedQueueThreadPool { tx, rx, handles }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rx` is never read [INFO] [stdout] --> src/thread_pool/shared.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct SharedQueueThreadPool { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] 12 | tx: Sender, [INFO] [stdout] 13 | rx: Arc>>, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/mod.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/thread_pool/shared.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | self.tx.send(Box::new(job)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 63 | let _ = self.tx.send(Box::new(job)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/rayon.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 15 | let pool = rayon::ThreadPoolBuilder::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(RayonThreadPool { pool }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/mod.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | self.indexed_log_file.lock().unwrap().write(Command::Remove { k: k.clone() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/mod.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/shared.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 25 | let (tx, rx) = channel::(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let rx = Arc::new(Mutex::new(rx)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let mut handles = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(SharedQueueThreadPool { tx, rx, handles }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 217 | let mut write_file = std::fs::OpenOptions::new() [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let read_file = std::fs::OpenOptions::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let reader = std::io::BufReader::new(read_file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | [INFO] [stdout] 241 | Ok(LogFile{ [INFO] [stdout] | ____________^ [INFO] [stdout] 242 | | reader, [INFO] [stdout] 243 | | file: write_file, [INFO] [stdout] 244 | | position, [INFO] [stdout] 245 | | num_writes: 0, [INFO] [stdout] 246 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:296:21 [INFO] [stdout] | [INFO] [stdout] 296 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:40:43 [INFO] [stdout] | [INFO] [stdout] 38 | let stream = stream?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let db = self.db.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | self.pool.spawn(move || match handle(stream, db) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/thread_pool/shared.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | self.tx.send(Box::new(job)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 63 | let _ = self.tx.send(Box::new(job)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/rayon.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 15 | let pool = rayon::ThreadPoolBuilder::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(RayonThreadPool { pool }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | self.indexed_log_file.lock().unwrap().write(Command::Remove { k: k.clone() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 217 | let mut write_file = std::fs::OpenOptions::new() [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let read_file = std::fs::OpenOptions::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let reader = std::io::BufReader::new(read_file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | [INFO] [stdout] 241 | Ok(LogFile{ [INFO] [stdout] | ____________^ [INFO] [stdout] 242 | | reader, [INFO] [stdout] 243 | | file: write_file, [INFO] [stdout] 244 | | position, [INFO] [stdout] 245 | | num_writes: 0, [INFO] [stdout] 246 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:296:21 [INFO] [stdout] | [INFO] [stdout] 296 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:40:43 [INFO] [stdout] | [INFO] [stdout] 38 | let stream = stream?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let db = self.db.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | self.pool.spawn(move || match handle(stream, db) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib) due to 10 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 9 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib test) due to 10 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a4fd34f443703493814f28cda028b1aa12ad654c089553d98e741b75264f2ba5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4fd34f443703493814f28cda028b1aa12ad654c089553d98e741b75264f2ba5", kill_on_drop: false }` [INFO] [stdout] a4fd34f443703493814f28cda028b1aa12ad654c089553d98e741b75264f2ba5