[INFO] cloning repository https://github.com/mwc10/m5conv [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mwc10/m5conv" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmwc10%2Fm5conv", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmwc10%2Fm5conv'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5de3d7f1cc187b932800aebc3911d753e0383217 [INFO] checking mwc10/m5conv against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmwc10%2Fm5conv" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mwc10/m5conv on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mwc10/m5conv [INFO] finished tweaking git repo https://github.com/mwc10/m5conv [INFO] tweaked toml for git repo https://github.com/mwc10/m5conv written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/mwc10/m5conv already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded noisy_float v0.1.13 [INFO] [stderr] Downloaded encoding_rs_io v0.1.7 [INFO] [stderr] Downloaded bstr v0.2.14 [INFO] [stderr] Downloaded csv v1.1.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4921f9b49bae84c3259ec78f77d285b1de39b9d7cd474dfc4f34d40d28e4f539 [INFO] running `Command { std: "docker" "start" "-a" "4921f9b49bae84c3259ec78f77d285b1de39b9d7cd474dfc4f34d40d28e4f539", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4921f9b49bae84c3259ec78f77d285b1de39b9d7cd474dfc4f34d40d28e4f539", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4921f9b49bae84c3259ec78f77d285b1de39b9d7cd474dfc4f34d40d28e4f539", kill_on_drop: false }` [INFO] [stdout] 4921f9b49bae84c3259ec78f77d285b1de39b9d7cd474dfc4f34d40d28e4f539 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5edf5b107386b7f8c9fd280fffda9cafdac33bd3845268a0b63cb078d3117e7b [INFO] running `Command { std: "docker" "start" "-a" "5edf5b107386b7f8c9fd280fffda9cafdac33bd3845268a0b63cb078d3117e7b", kill_on_drop: false }` [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling encoding_rs v0.8.26 [INFO] [stderr] Compiling anyhow v1.0.37 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking noisy_float v0.1.13 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking bstr v0.2.14 [INFO] [stderr] Checking csv v1.1.5 [INFO] [stderr] Checking m5conv v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `read_mode` is never read [INFO] [stdout] --> src/m5.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) struct PlateSettings { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 74 | pub read_mode: ReadMode, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlateSettings` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `read_mode` is never read [INFO] [stdout] --> src/m5.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) struct PlateSettings { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 74 | pub read_mode: ReadMode, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlateSettings` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `row_start` and `col_start` are never read [INFO] [stdout] --> src/m5.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 103 | struct PlateInfo { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 104 | plate_size: u32, [INFO] [stdout] 105 | row_start: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 106 | row_span: u8, [INFO] [stdout] 107 | col_start: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlateInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `row_start` and `col_start` are never read [INFO] [stdout] --> src/m5.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 103 | struct PlateInfo { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 104 | plate_size: u32, [INFO] [stdout] 105 | row_start: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 106 | row_span: u8, [INFO] [stdout] 107 | col_start: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlateInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.25s [INFO] running `Command { std: "docker" "inspect" "5edf5b107386b7f8c9fd280fffda9cafdac33bd3845268a0b63cb078d3117e7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5edf5b107386b7f8c9fd280fffda9cafdac33bd3845268a0b63cb078d3117e7b", kill_on_drop: false }` [INFO] [stdout] 5edf5b107386b7f8c9fd280fffda9cafdac33bd3845268a0b63cb078d3117e7b [INFO] checking mwc10/m5conv against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmwc10%2Fm5conv" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mwc10/m5conv on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mwc10/m5conv [INFO] finished tweaking git repo https://github.com/mwc10/m5conv [INFO] tweaked toml for git repo https://github.com/mwc10/m5conv written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/mwc10/m5conv already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b615c2cec7f02e366820cf4e1946b8d8a121c8d1e43a756dd0a08c455d7f7301 [INFO] running `Command { std: "docker" "start" "-a" "b615c2cec7f02e366820cf4e1946b8d8a121c8d1e43a756dd0a08c455d7f7301", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b615c2cec7f02e366820cf4e1946b8d8a121c8d1e43a756dd0a08c455d7f7301", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b615c2cec7f02e366820cf4e1946b8d8a121c8d1e43a756dd0a08c455d7f7301", kill_on_drop: false }` [INFO] [stdout] b615c2cec7f02e366820cf4e1946b8d8a121c8d1e43a756dd0a08c455d7f7301 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 722cbcd5dd2949aa8adcef259d7e12ca5134d52c19bcf59908cfd97568ae2c20 [INFO] running `Command { std: "docker" "start" "-a" "722cbcd5dd2949aa8adcef259d7e12ca5134d52c19bcf59908cfd97568ae2c20", kill_on_drop: false }` [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling encoding_rs v0.8.26 [INFO] [stderr] Compiling anyhow v1.0.37 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking noisy_float v0.1.13 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking bstr v0.2.14 [INFO] [stderr] Checking csv v1.1.5 [INFO] [stderr] Checking m5conv v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `read_mode` is never read [INFO] [stdout] --> src/m5.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) struct PlateSettings { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 74 | pub read_mode: ReadMode, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlateSettings` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `row_start` and `col_start` are never read [INFO] [stdout] --> src/m5.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 103 | struct PlateInfo { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 104 | plate_size: u32, [INFO] [stdout] 105 | row_start: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 106 | row_span: u8, [INFO] [stdout] 107 | col_start: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlateInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `read_mode` is never read [INFO] [stdout] --> src/m5.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) struct PlateSettings { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 74 | pub read_mode: ReadMode, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlateSettings` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `row_start` and `col_start` are never read [INFO] [stdout] --> src/m5.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 103 | struct PlateInfo { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 104 | plate_size: u32, [INFO] [stdout] 105 | row_start: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 106 | row_span: u8, [INFO] [stdout] 107 | col_start: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlateInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 70 | fn parse_input(path: PathBuf, output: Box) -> anyhow::Result<()> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | // output text file seems to be in macroman encoding..? Just for the degree symbol... [INFO] [stdout] 72 | let decoder = DecodeReaderBytesBuilder::new() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let rdr = BufReader::new(decoder); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | output::write_csv(file, output).context("writing to output csv") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/m5.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn read_and_parse(mut rdr: R) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | / (0..block_count) [INFO] [stdout] 19 | | .map(|i| { [INFO] [stdout] 20 | | PlateBlock::from_rdr(&mut rdr, &mut buf) [INFO] [stdout] 21 | | .with_context(|| anyhow!("parsing block {}", i + 1)) [INFO] [stdout] 22 | | }) [INFO] [stdout] 23 | | .collect::>() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 70 | fn parse_input(path: PathBuf, output: Box) -> anyhow::Result<()> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | // output text file seems to be in macroman encoding..? Just for the degree symbol... [INFO] [stdout] 72 | let decoder = DecodeReaderBytesBuilder::new() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let rdr = BufReader::new(decoder); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | output::write_csv(file, output).context("writing to output csv") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/m5.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn read_and_parse(mut rdr: R) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | / (0..block_count) [INFO] [stdout] 19 | | .map(|i| { [INFO] [stdout] 20 | | PlateBlock::from_rdr(&mut rdr, &mut buf) [INFO] [stdout] 21 | | .with_context(|| anyhow!("parsing block {}", i + 1)) [INFO] [stdout] 22 | | }) [INFO] [stdout] 23 | | .collect::>() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) fn write_csv(file: M5File, wtr: Box) -> Result<()> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let mut wtr = csv::Writer::from_writer(wtr); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | / file.0 [INFO] [stdout] 29 | | .into_iter() [INFO] [stdout] 30 | | .try_for_each(|block| write_block(block, &mut wtr, &mut cache)) [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:58:35 [INFO] [stdout] | [INFO] [stdout] 53 | fn get_from(map: &mut HashMap, key: K, default: F) -> &V [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | map.entry(key).or_insert_with(|| default(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) fn rmap2(r1: Result, r2: Result, f: F) -> Result [INFO] [stdout] | ---------------- ---------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 6 | r1.and_then(|r1| r2.map(|r2| f(r1, r2))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) fn write_csv(file: M5File, wtr: Box) -> Result<()> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let mut wtr = csv::Writer::from_writer(wtr); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | / file.0 [INFO] [stdout] 29 | | .into_iter() [INFO] [stdout] 30 | | .try_for_each(|block| write_block(block, &mut wtr, &mut cache)) [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:6:29 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) fn rmap2(r1: Result, r2: Result, f: F) -> Result [INFO] [stdout] | -- - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 6 | r1.and_then(|r1| r2.map(|r2| f(r1, r2))) [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:58:35 [INFO] [stdout] | [INFO] [stdout] 53 | fn get_from(map: &mut HashMap, key: K, default: F) -> &V [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | map.entry(key).or_insert_with(|| default(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) fn rmap2(r1: Result, r2: Result, f: F) -> Result [INFO] [stdout] | ---------------- ---------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 6 | r1.and_then(|r1| r2.map(|r2| f(r1, r2))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:6:29 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) fn rmap2(r1: Result, r2: Result, f: F) -> Result [INFO] [stdout] | -- - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 6 | r1.and_then(|r1| r2.map(|r2| f(r1, r2))) [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `m5conv` (bin "m5conv") due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `m5conv` (bin "m5conv" test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "722cbcd5dd2949aa8adcef259d7e12ca5134d52c19bcf59908cfd97568ae2c20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "722cbcd5dd2949aa8adcef259d7e12ca5134d52c19bcf59908cfd97568ae2c20", kill_on_drop: false }` [INFO] [stdout] 722cbcd5dd2949aa8adcef259d7e12ca5134d52c19bcf59908cfd97568ae2c20