[INFO] cloning repository https://github.com/mtimkovich/slippi-db [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mtimkovich/slippi-db" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmtimkovich%2Fslippi-db", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmtimkovich%2Fslippi-db'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 825adaba3111eee5ebcf01d8e617af344c0b1adf [INFO] checking mtimkovich/slippi-db against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmtimkovich%2Fslippi-db" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mtimkovich/slippi-db on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mtimkovich/slippi-db [INFO] finished tweaking git repo https://github.com/mtimkovich/slippi-db [INFO] tweaked toml for git repo https://github.com/mtimkovich/slippi-db written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/mtimkovich/slippi-db already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/hohav/peppi` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hashlink v0.6.0 [INFO] [stderr] Downloaded vcpkg v0.2.12 [INFO] [stderr] Downloaded rusqlite v0.25.1 [INFO] [stderr] Downloaded pretty_env_logger v0.4.0 [INFO] [stderr] Downloaded serde_derive v1.0.125 [INFO] [stderr] Downloaded rayon-core v1.9.0 [INFO] [stderr] Downloaded serde v1.0.125 [INFO] [stderr] Downloaded rayon v1.5.0 [INFO] [stderr] Downloaded regex v1.4.5 [INFO] [stderr] Downloaded regex-syntax v0.6.23 [INFO] [stderr] Downloaded libc v0.2.93 [INFO] [stderr] Downloaded libsqlite3-sys v0.22.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8e22ddf24f84e205429f42120d607cea4d5648ed782f283ed94c864c44aa3246 [INFO] running `Command { std: "docker" "start" "-a" "8e22ddf24f84e205429f42120d607cea4d5648ed782f283ed94c864c44aa3246", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8e22ddf24f84e205429f42120d607cea4d5648ed782f283ed94c864c44aa3246", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e22ddf24f84e205429f42120d607cea4d5648ed782f283ed94c864c44aa3246", kill_on_drop: false }` [INFO] [stdout] 8e22ddf24f84e205429f42120d607cea4d5648ed782f283ed94c864c44aa3246 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b1da9addcd53a5e3e503fbcac682dabfbfb29e3d7aa87d6d1b79c6df3ad38e59 [INFO] running `Command { std: "docker" "start" "-a" "b1da9addcd53a5e3e503fbcac682dabfbfb29e3d7aa87d6d1b79c6df3ad38e59", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.69 [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking regex-syntax v0.6.23 [INFO] [stderr] Checking ahash v0.4.7 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Compiling peppi v0.1.0 (https://github.com/hohav/peppi#4c6ab146) [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking os_str_bytes v2.4.0 [INFO] [stderr] Checking hashlink v0.6.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.4 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling libsqlite3-sys v0.22.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking regex v1.4.5 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking env_logger v0.8.3 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 [INFO] [stderr] Checking clap v3.0.0-beta.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling toml v0.5.8 [INFO] [stderr] Checking rusqlite v0.25.1 [INFO] [stderr] Compiling proc-macro-crate v0.1.5 [INFO] [stderr] Compiling num_enum_derive v0.4.3 [INFO] [stderr] Checking num_enum v0.4.3 [INFO] [stderr] Checking slippi-db v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/players.rs:129:22 [INFO] [stdout] | [INFO] [stdout] 129 | Some(mut tb) => { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/players.rs:129:22 [INFO] [stdout] | [INFO] [stdout] 129 | Some(mut tb) => { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.77s [INFO] running `Command { std: "docker" "inspect" "b1da9addcd53a5e3e503fbcac682dabfbfb29e3d7aa87d6d1b79c6df3ad38e59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b1da9addcd53a5e3e503fbcac682dabfbfb29e3d7aa87d6d1b79c6df3ad38e59", kill_on_drop: false }` [INFO] [stdout] b1da9addcd53a5e3e503fbcac682dabfbfb29e3d7aa87d6d1b79c6df3ad38e59 [INFO] checking mtimkovich/slippi-db against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmtimkovich%2Fslippi-db" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mtimkovich/slippi-db on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mtimkovich/slippi-db [INFO] finished tweaking git repo https://github.com/mtimkovich/slippi-db [INFO] tweaked toml for git repo https://github.com/mtimkovich/slippi-db written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/mtimkovich/slippi-db already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8696a77f416d1bf8507c155a091846ea5be8e6bc788016eb0e635ffebb64b242 [INFO] running `Command { std: "docker" "start" "-a" "8696a77f416d1bf8507c155a091846ea5be8e6bc788016eb0e635ffebb64b242", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8696a77f416d1bf8507c155a091846ea5be8e6bc788016eb0e635ffebb64b242", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8696a77f416d1bf8507c155a091846ea5be8e6bc788016eb0e635ffebb64b242", kill_on_drop: false }` [INFO] [stdout] 8696a77f416d1bf8507c155a091846ea5be8e6bc788016eb0e635ffebb64b242 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9422f5daafe80adc4ddf541d68538223b4d9be62e8532e9b54eb444264b42ef1 [INFO] running `Command { std: "docker" "start" "-a" "9422f5daafe80adc4ddf541d68538223b4d9be62e8532e9b54eb444264b42ef1", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.69 [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking regex-syntax v0.6.23 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking ahash v0.4.7 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling peppi v0.1.0 (https://github.com/hohav/peppi#4c6ab146) [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Checking hashlink v0.6.0 [INFO] [stderr] Checking os_str_bytes v2.4.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.4 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling libsqlite3-sys v0.22.1 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking regex v1.4.5 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking env_logger v0.8.3 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 [INFO] [stderr] Checking clap v3.0.0-beta.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling toml v0.5.8 [INFO] [stderr] Checking rusqlite v0.25.1 [INFO] [stderr] Compiling proc-macro-crate v0.1.5 [INFO] [stderr] Compiling num_enum_derive v0.4.3 [INFO] [stderr] Checking num_enum v0.4.3 [INFO] [stderr] Checking slippi-db v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/players.rs:129:22 [INFO] [stdout] | [INFO] [stdout] 129 | Some(mut tb) => { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/players.rs:129:22 [INFO] [stdout] | [INFO] [stdout] 129 | Some(mut tb) => { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:112:11 [INFO] [stdout] | [INFO] [stdout] 106 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | match GameEntry::new(&game, &path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:26:26 [INFO] [stdout] | [INFO] [stdout] 24 | let fileset: HashSet<_> = files.into_iter().map(|f| f.display().to_string()).collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(fileset [INFO] [stdout] 26 | .difference(&self.get_filepaths()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 32 | let mut stmt = self.conn.prepare("select filepath from games")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let rows = stmt.query_map([], |row| row.get(0))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(rows.filter_map(|r| r.ok()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `slippi-db` (bin "slippi-db") due to 4 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:112:11 [INFO] [stdout] | [INFO] [stdout] 106 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | match GameEntry::new(&game, &path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:26:26 [INFO] [stdout] | [INFO] [stdout] 24 | let fileset: HashSet<_> = files.into_iter().map(|f| f.display().to_string()).collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(fileset [INFO] [stdout] 26 | .difference(&self.get_filepaths()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 32 | let mut stmt = self.conn.prepare("select filepath from games")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let rows = stmt.query_map([], |row| row.get(0))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(rows.filter_map(|r| r.ok()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `slippi-db` (bin "slippi-db" test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9422f5daafe80adc4ddf541d68538223b4d9be62e8532e9b54eb444264b42ef1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9422f5daafe80adc4ddf541d68538223b4d9be62e8532e9b54eb444264b42ef1", kill_on_drop: false }` [INFO] [stdout] 9422f5daafe80adc4ddf541d68538223b4d9be62e8532e9b54eb444264b42ef1