[INFO] cloning repository https://github.com/mattsmith24/mattmusic [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mattsmith24/mattmusic" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmattsmith24%2Fmattmusic", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmattsmith24%2Fmattmusic'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3545bf80198d4026c8eace4cd4d224d3b4ac075f [INFO] checking mattsmith24/mattmusic against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmattsmith24%2Fmattmusic" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mattsmith24/mattmusic on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mattsmith24/mattmusic [INFO] finished tweaking git repo https://github.com/mattsmith24/mattmusic [INFO] tweaked toml for git repo https://github.com/mattsmith24/mattmusic written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/mattsmith24/mattmusic already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dyn-clone v1.0.14 [INFO] [stderr] Downloaded serde v1.0.171 [INFO] [stderr] Downloaded coreaudio-sys v0.2.12 [INFO] [stderr] Downloaded itoa v1.0.8 [INFO] [stderr] Downloaded mach2 v0.4.1 [INFO] [stderr] Downloaded anstyle v1.0.1 [INFO] [stderr] Downloaded evalexpr v11.1.0 [INFO] [stderr] Downloaded clap v4.3.11 [INFO] [stderr] Downloaded alsa v0.7.0 [INFO] [stderr] Downloaded jni v0.20.0 [INFO] [stderr] Downloaded cpal v0.15.2 [INFO] [stderr] Downloaded serde_yaml v0.9.22 [INFO] [stderr] Downloaded clang-sys v1.6.1 [INFO] [stderr] Downloaded clap_builder v4.3.11 [INFO] [stderr] Downloaded oboe-sys v0.5.0 [INFO] [stderr] Downloaded coreaudio-rs v0.11.2 [INFO] [stderr] Downloaded ryu v1.0.14 [INFO] [stderr] Downloaded serde_derive v1.0.171 [INFO] [stderr] Downloaded oboe v0.5.0 [INFO] [stderr] Downloaded rustix v0.38.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aaa9194bcde3fc0883d3387ba73ec3ca7af95126456e0f66004d96e343df6a84 [INFO] running `Command { std: "docker" "start" "-a" "aaa9194bcde3fc0883d3387ba73ec3ca7af95126456e0f66004d96e343df6a84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aaa9194bcde3fc0883d3387ba73ec3ca7af95126456e0f66004d96e343df6a84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aaa9194bcde3fc0883d3387ba73ec3ca7af95126456e0f66004d96e343df6a84", kill_on_drop: false }` [INFO] [stdout] aaa9194bcde3fc0883d3387ba73ec3ca7af95126456e0f66004d96e343df6a84 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f07c01bc403d21507bba98f9dc233485454eb95aed7cf90db5841b0ca741ed46 [INFO] running `Command { std: "docker" "start" "-a" "f07c01bc403d21507bba98f9dc233485454eb95aed7cf90db5841b0ca741ed46", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling serde v1.0.171 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking ryu v1.0.14 [INFO] [stderr] Checking unsafe-libyaml v0.2.8 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking itoa v1.0.8 [INFO] [stderr] Checking evalexpr v11.1.0 [INFO] [stderr] Checking dyn-clone v1.0.14 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.11 [INFO] [stderr] Checking num-integer v0.1.45 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking alsa v0.7.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Compiling serde_derive v1.0.171 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Checking clap v4.3.11 [INFO] [stderr] Checking serde_yaml v0.9.22 [INFO] [stderr] Checking mattmusic v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/generative_waveform.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 75 | let mut data = state.downcast_mut::().unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/generative_waveform.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 75 | let mut data = state.downcast_mut::().unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pulse_train.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | let mut data = state.downcast_mut::().unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pulse_train.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | let mut data = state.downcast_mut::().unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sequence.rs:98:21 [INFO] [stdout] | [INFO] [stdout] 98 | let mut note_data = &mut data[note_idx]; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sequence.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | let mut note_data = &mut data[note_idx]; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sequence.rs:98:21 [INFO] [stdout] | [INFO] [stdout] 98 | let mut note_data = &mut data[note_idx]; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sequence.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | let mut note_data = &mut data[note_idx]; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:176:38 [INFO] [stdout] | [INFO] [stdout] 176 | let patch_name = parts[0].clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:179:66 [INFO] [stdout] | [INFO] [stdout] 179 | patch_source_input = Some(self.get_sound(parts[1].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:215:45 [INFO] [stdout] | [INFO] [stdout] 215 | substitute_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:251:45 [INFO] [stdout] | [INFO] [stdout] 251 | substitute_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:303:44 [INFO] [stdout] | [INFO] [stdout] 303 | evaluated_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:176:38 [INFO] [stdout] | [INFO] [stdout] 176 | let patch_name = parts[0].clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:179:66 [INFO] [stdout] | [INFO] [stdout] 179 | patch_source_input = Some(self.get_sound(parts[1].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:215:45 [INFO] [stdout] | [INFO] [stdout] 215 | substitute_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:251:45 [INFO] [stdout] | [INFO] [stdout] 251 | substitute_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:303:44 [INFO] [stdout] | [INFO] [stdout] 303 | evaluated_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.18s [INFO] running `Command { std: "docker" "inspect" "f07c01bc403d21507bba98f9dc233485454eb95aed7cf90db5841b0ca741ed46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f07c01bc403d21507bba98f9dc233485454eb95aed7cf90db5841b0ca741ed46", kill_on_drop: false }` [INFO] [stdout] f07c01bc403d21507bba98f9dc233485454eb95aed7cf90db5841b0ca741ed46 [INFO] checking mattsmith24/mattmusic against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmattsmith24%2Fmattmusic" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mattsmith24/mattmusic on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mattsmith24/mattmusic [INFO] finished tweaking git repo https://github.com/mattsmith24/mattmusic [INFO] tweaked toml for git repo https://github.com/mattsmith24/mattmusic written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/mattsmith24/mattmusic already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7a63ab65b255333b72d2fe26cf0113a449d1ece1f694c2aa583b9cc6942de45 [INFO] running `Command { std: "docker" "start" "-a" "f7a63ab65b255333b72d2fe26cf0113a449d1ece1f694c2aa583b9cc6942de45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7a63ab65b255333b72d2fe26cf0113a449d1ece1f694c2aa583b9cc6942de45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7a63ab65b255333b72d2fe26cf0113a449d1ece1f694c2aa583b9cc6942de45", kill_on_drop: false }` [INFO] [stdout] f7a63ab65b255333b72d2fe26cf0113a449d1ece1f694c2aa583b9cc6942de45 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aeeddd634dc14a118ece0d658ebde28f5de3b426de19fe44238bc9e6a9339f41 [INFO] running `Command { std: "docker" "start" "-a" "aeeddd634dc14a118ece0d658ebde28f5de3b426de19fe44238bc9e6a9339f41", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling serde v1.0.171 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Checking itoa v1.0.8 [INFO] [stderr] Checking unsafe-libyaml v0.2.8 [INFO] [stderr] Checking ryu v1.0.14 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking anyhow v1.0.71 [INFO] [stderr] Checking dyn-clone v1.0.14 [INFO] [stderr] Checking evalexpr v11.1.0 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking num-integer v0.1.45 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking clap_builder v4.3.11 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking alsa v0.7.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Compiling serde_derive v1.0.171 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Checking clap v4.3.11 [INFO] [stderr] Checking serde_yaml v0.9.22 [INFO] [stderr] Checking mattmusic v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/generative_waveform.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 75 | let mut data = state.downcast_mut::().unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/generative_waveform.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 75 | let mut data = state.downcast_mut::().unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pulse_train.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | let mut data = state.downcast_mut::().unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pulse_train.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | let mut data = state.downcast_mut::().unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sequence.rs:98:21 [INFO] [stdout] | [INFO] [stdout] 98 | let mut note_data = &mut data[note_idx]; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sequence.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | let mut note_data = &mut data[note_idx]; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sequence.rs:98:21 [INFO] [stdout] | [INFO] [stdout] 98 | let mut note_data = &mut data[note_idx]; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sequence.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | let mut note_data = &mut data[note_idx]; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer_reader.rs:47:18 [INFO] [stdout] | [INFO] [stdout] 45 | let buffer = reader.get_buffer(¶ms[0]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let duration = params[1].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 47 | Box::new(BufferReader::new(buffer, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer_writer.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 51 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let buffer = reader.get_buffer(¶ms[1]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Box::new(BufferWriter::new(input, buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cauchy_transfer.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 45 | let source = reader.get_sound(¶ms[0]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Box::new(Self::new(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cos_transfer.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 43 | let source = reader.get_sound(¶ms[0]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Box::new(Self::new(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/delay_line.rs:77:18 [INFO] [stdout] | [INFO] [stdout] 75 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let delay = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Box::new(DelayLine::new(input, delay)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gaussian_transfer.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 45 | let source = reader.get_sound(¶ms[0]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Box::new(Self::new(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generative_waveform.rs:113:18 [INFO] [stdout] | [INFO] [stdout] 107 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let gain = reader.get_knob(¶ms[3], 1.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Box::new(Self::new(freq, harmonic_index_increment, gain_exponent, gain, lock_phase, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hann_window.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 49 | let source = reader.get_sound(¶ms[0]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Box::new(Self::new(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import_wav.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 74 | let mut reader = hound::WavReader::open(filename).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let sweep = Ramp::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let wavetable = Wavetable::from_buffer(samples, Box::new(sweep), interpolation, period.round() as i32); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ImportWav { wavetable: Box::new(wavetable) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/oscillator.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 58 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let phase = reader.get_knob(¶ms[1], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 61 | Box::new(Self::new(freq, phase, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pitch_shift.rs:115:30 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn new(input: DynSoundSource, base_delay: i32, window_size: i32, freq: f32) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | // We need to use the input twice so prerender it and clone. [INFO] [stdout] 108 | let input0 = input; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let input1 = dyn_clone::clone_box(&*input0); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let circuit0 = new_circuit(input0, base_delay, window_size, freq, 0.0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let circuit1 = new_circuit(input1, base_delay, window_size, freq, std::f32::consts::PI); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let mut mix = Mix::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | PitchShift { output: Box::new(mix) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pitch_shift.rs:142:18 [INFO] [stdout] | [INFO] [stdout] 138 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | Box::new(PitchShift::new(input, base_delay.round() as i32, window_size.round() as i32, freq)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pulse_train.rs:96:18 [INFO] [stdout] | [INFO] [stdout] 93 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let duty = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 96 | Box::new(Self::new(freq, duty, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ramp.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 68 | let period = reader.get_knob(¶ms[0], reader.sample_rate as f32); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let amplitude = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 71 | Box::new(Self::new(period, amplitude, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer_reader.rs:47:18 [INFO] [stdout] | [INFO] [stdout] 45 | let buffer = reader.get_buffer(¶ms[0]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let duration = params[1].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 47 | Box::new(BufferReader::new(buffer, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_song.rs:170:30 [INFO] [stdout] | [INFO] [stdout] 168 | let magnitude = self.parse_knob(&parts[0], 1.0); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let angle = self.parse_knob(&parts[1], 1.0); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | ComplexKnob::new(Box::new(RealToComplex::new(magnitude, angle))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer_writer.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 51 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let buffer = reader.get_buffer(¶ms[1]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Box::new(BufferWriter::new(input, buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cauchy_transfer.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 45 | let source = reader.get_sound(¶ms[0]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Box::new(Self::new(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:176:38 [INFO] [stdout] | [INFO] [stdout] 176 | let patch_name = parts[0].clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:179:66 [INFO] [stdout] | [INFO] [stdout] 179 | patch_source_input = Some(self.get_sound(parts[1].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:215:45 [INFO] [stdout] | [INFO] [stdout] 215 | substitute_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cos_transfer.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 43 | let source = reader.get_sound(¶ms[0]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Box::new(Self::new(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:251:45 [INFO] [stdout] | [INFO] [stdout] 251 | substitute_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:303:44 [INFO] [stdout] | [INFO] [stdout] 303 | evaluated_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/delay_line.rs:77:18 [INFO] [stdout] | [INFO] [stdout] 75 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let delay = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Box::new(DelayLine::new(input, delay)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gaussian_transfer.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 45 | let source = reader.get_sound(¶ms[0]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Box::new(Self::new(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generative_waveform.rs:113:18 [INFO] [stdout] | [INFO] [stdout] 107 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let gain = reader.get_knob(¶ms[3], 1.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Box::new(Self::new(freq, harmonic_index_increment, gain_exponent, gain, lock_phase, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hann_window.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 49 | let source = reader.get_sound(¶ms[0]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Box::new(Self::new(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recirculating_delay.rs:75:21 [INFO] [stdout] | [INFO] [stdout] 56 | input: DynSoundSource, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let buffer = Arc::new(Mutex::new(Vec::<(f32,f32)>::new())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let buffer_reader = BufferReader::new(buffer.clone(), duration); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let mut sequence = Sequence::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | sequence.add(delay, Box::new(buffer_reader)); [INFO] [stdout] 65 | let mut multiply = Multiply::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let mut mix = Mix::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let buffer_writer = BufferWriter::new(Box::new(mix), buffer.clone()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | source: Box::new(buffer_writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recirculating_delay.rs:102:18 [INFO] [stdout] | [INFO] [stdout] 98 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Box::new(RecirculatingDelay::new(input, delay.round() as i32, delay_gain, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import_wav.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 74 | let mut reader = hound::WavReader::open(filename).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let sweep = Ramp::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let wavetable = Wavetable::from_buffer(samples, Box::new(sweep), interpolation, period.round() as i32); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ImportWav { wavetable: Box::new(wavetable) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reverberator.rs:56:32 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(input: DynSoundSource, gain: f32) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let buffer = Arc::new(Mutex::new(Vec::<(f32,f32)>::new())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | // Rotate + delaychain of: pi/10, 30ms, pi/10, 55ms, -pi/5, 80ms [INFO] [stdout] 40 | let rotation_1 = RotationTransfer::new(input, std::f32::consts::PI * 0.1); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let uneven_delay1 = UnevenDelay::new(Box::new(rotation_1), 0, 1440); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let rotation_2 = RotationTransfer::new(Box::new(uneven_delay1), std::f32::consts::PI * 0.1); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let uneven_delay2 = UnevenDelay::new(Box::new(rotation_2), 0, 2640); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let rotation_3 = RotationTransfer::new(Box::new(uneven_delay2), -std::f32::consts::PI * 0.2); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let uneven_delay3 = UnevenDelay::new(Box::new(rotation_3), 0, 3840); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | // recirculating delay 0.07, 0.04 and gain [INFO] [stdout] 47 | let buffer_reader = BufferReader::new(buffer.clone(), duration); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let uneven_delay4 = UnevenDelay::new(Box::new(buffer_reader), 3360, 1920); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let rotation_4 = RotationTransfer::new(Box::new(uneven_delay4), std::f32::consts::PI * 0.3); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut recirculating_gain = Multiply::new(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let mut mix = Mix::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Reverberator { output: Box::new(BufferWriter::new(Box::new(mix), buffer.clone())), duration: duration } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reverberator.rs:81:18 [INFO] [stdout] | [INFO] [stdout] 79 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let gain = params[1].parse::().unwrap(); [INFO] [stdout] 81 | Box::new(Reverberator::new(input, gain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotation_transfer.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 46 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let angle_of_rotation = params[1].parse::().unwrap(); [INFO] [stdout] 48 | Box::new(RotationTransfer::new(input, angle_of_rotation)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/saw.rs:20:36 [INFO] [stdout] | [INFO] [stdout] 16 | freq: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | gain: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Saw { generative_waveform: GenerativeWaveform::new( [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 21 | | freq, [INFO] [stdout] 22 | | 1, [INFO] [stdout] 23 | | 1, [INFO] [stdout] ... | [INFO] [stdout] 26 | | duration [INFO] [stdout] 27 | | ) } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/oscillator.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 58 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let phase = reader.get_knob(¶ms[1], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 61 | Box::new(Self::new(freq, phase, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/saw.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 49 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let strength = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 52 | Box::new(Self::new(freq, strength, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pitch_shift.rs:115:30 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn new(input: DynSoundSource, base_delay: i32, window_size: i32, freq: f32) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | // We need to use the input twice so prerender it and clone. [INFO] [stdout] 108 | let input0 = input; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let input1 = dyn_clone::clone_box(&*input0); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let circuit0 = new_circuit(input0, base_delay, window_size, freq, 0.0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let circuit1 = new_circuit(input1, base_delay, window_size, freq, std::f32::consts::PI); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let mut mix = Mix::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | PitchShift { output: Box::new(mix) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sine.rs:20:37 [INFO] [stdout] | [INFO] [stdout] 16 | freq: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | gain: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Sine { generative_waveform: GenerativeWaveform::new( [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 21 | | freq, [INFO] [stdout] 22 | | 1000000000, // A really high number so we don't add any frequencies [INFO] [stdout] 23 | | 1, [INFO] [stdout] ... | [INFO] [stdout] 26 | | duration [INFO] [stdout] 27 | | ) } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pitch_shift.rs:142:18 [INFO] [stdout] | [INFO] [stdout] 138 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | Box::new(PitchShift::new(input, base_delay.round() as i32, window_size.round() as i32, freq)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sine.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 50 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let strength = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 53 | Box::new(Sine::new(freq, strength, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pulse_train.rs:96:18 [INFO] [stdout] | [INFO] [stdout] 93 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let duty = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 96 | Box::new(Self::new(freq, duty, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/square.rs:20:39 [INFO] [stdout] | [INFO] [stdout] 16 | freq: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | gain: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Square { generative_waveform: GenerativeWaveform::new( [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 21 | | freq, [INFO] [stdout] 22 | | 2, [INFO] [stdout] 23 | | 1, [INFO] [stdout] ... | [INFO] [stdout] 26 | | duration [INFO] [stdout] 27 | | ) } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ramp.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 68 | let period = reader.get_knob(¶ms[0], reader.sample_rate as f32); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let amplitude = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 71 | Box::new(Self::new(period, amplitude, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/square.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 50 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let strength = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 53 | Box::new(Self::new(freq, strength, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time_box.rs:62:18 [INFO] [stdout] | [INFO] [stdout] 61 | let source = reader.get_sound(¶ms[2]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Box::new(Self::new(duration.round() as i32, ramp_time.round() as i32, source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triangle.rs:19:41 [INFO] [stdout] | [INFO] [stdout] 15 | freq: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | gain: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Triangle { generative_waveform: GenerativeWaveform::new( [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 20 | | freq, [INFO] [stdout] 21 | | 2, [INFO] [stdout] 22 | | 2, [INFO] [stdout] ... | [INFO] [stdout] 25 | | duration [INFO] [stdout] 26 | | ) } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triangle.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 49 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let strength = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 52 | Box::new(Self::new(freq, strength, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uneven_delay.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 57 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Box::new(UnevenDelay::new(input, left_delay.round() as i32, right_delay.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wavetable.rs:119:18 [INFO] [stdout] | [INFO] [stdout] 109 | let table = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let sweep = reader.get_sound(¶ms[1]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Box::new(Wavetable::new(table, sweep, interpolation, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/allpass_filter.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(input: DynSoundSource, gain: ComplexKnob) -> Self { [INFO] [stdout] | --------------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut poles = Vec::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | poles.push(gain.clone()); [INFO] [stdout] 18 | let zeros = Vec::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let mut zero2s = Vec::::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let normalize_dc = Box::new(DC::new(1.0, duration)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | AllpassFilter { [INFO] [stdout] 24 | filter: PoleZeroFilter::new(input, normalize_dc, poles, zeros, zero2s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/allpass_filter.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 52 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let gain = reader.get_complex_knob(¶ms[1]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Box::new(AllpassFilter::new(input, gain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_song.rs:170:30 [INFO] [stdout] | [INFO] [stdout] 168 | let magnitude = self.parse_knob(&parts[0], 1.0); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let angle = self.parse_knob(&parts[1], 1.0); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | ComplexKnob::new(Box::new(RealToComplex::new(magnitude, angle))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:176:38 [INFO] [stdout] | [INFO] [stdout] 176 | let patch_name = parts[0].clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:179:66 [INFO] [stdout] | [INFO] [stdout] 179 | patch_source_input = Some(self.get_sound(parts[1].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/band_pass_filter.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 94 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let centre = reader.get_sound(¶ms[1]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let bandwidth = reader.get_sound(¶ms[2]); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Box::new(BandPassFilter::new(input, centre, bandwidth)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:215:45 [INFO] [stdout] | [INFO] [stdout] 215 | substitute_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:251:45 [INFO] [stdout] | [INFO] [stdout] 251 | substitute_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/read_song.rs:303:44 [INFO] [stdout] | [INFO] [stdout] 303 | evaluated_param = param_str.clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/butterworth_bandpass_filter.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(input: DynSoundSource, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let mut pole_knobs = Vec::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut zero_knobs = Vec::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let zero2_knobs = Vec::::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let duration = input.duration(); [INFO] [stdout] 64 | let normalize_dc = Box::new(DC::new(normalize, duration)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ButterworthBandpassFilter { [INFO] [stdout] 66 | filter: PoleZeroFilter::new(input, normalize_dc, pole_knobs, zero_knobs, zero2_knobs), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/butterworth_bandpass_filter.rs:101:18 [INFO] [stdout] | [INFO] [stdout] 94 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Box::new(ButterworthBandpassFilter::new(input, num_points, pole_r, zero_r, center_freq, normalize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/butterworth_filter.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(input: DynSoundSource, num_points: usize, pole_r: f32, zero_r: f32, normalize: f32) -> Self [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let mut pole_knobs = Vec::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let mut zero_knobs = Vec::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let zero2_knobs = Vec::::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let duration = input.duration(); [INFO] [stdout] 55 | let normalize_dc = Box::new(DC::new(normalize, duration)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | ButterworthFilter { [INFO] [stdout] 57 | filter: PoleZeroFilter::new(input, normalize_dc, pole_knobs, zero_knobs, zero2_knobs), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/butterworth_filter.rs:90:18 [INFO] [stdout] | [INFO] [stdout] 85 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Box::new(ButterworthFilter::new(input, num_points, pole_r, zero_r, normalize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recirculating_delay.rs:75:21 [INFO] [stdout] | [INFO] [stdout] 56 | input: DynSoundSource, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let buffer = Arc::new(Mutex::new(Vec::<(f32,f32)>::new())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let buffer_reader = BufferReader::new(buffer.clone(), duration); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let mut sequence = Sequence::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | sequence.add(delay, Box::new(buffer_reader)); [INFO] [stdout] 65 | let mut multiply = Multiply::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let mut mix = Mix::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let buffer_writer = BufferWriter::new(Box::new(mix), buffer.clone()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | source: Box::new(buffer_writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recirculating_delay.rs:102:18 [INFO] [stdout] | [INFO] [stdout] 98 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Box::new(RecirculatingDelay::new(input, delay.round() as i32, delay_gain, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_non_recirculating_filter.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn new(input: DynSoundSource, complex_gain: ComplexKnob) -> Self { [INFO] [stdout] | --------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let duration = input.duration(); [INFO] [stdout] 73 | let complex_input = Box::new(RealToComplex::new(input, Box::new(DC::new(0.0, duration)))); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | ElementaryNonRecirculatingFilter { [INFO] [stdout] 75 | complex_filter: ComplexElementaryNonRecirculatingFilter::new(complex_input, complex_gain) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_non_recirculating_filter.rs:106:18 [INFO] [stdout] | [INFO] [stdout] 104 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let complex_gain = reader.get_complex_knob(¶ms[1]); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Box::new(ElementaryNonRecirculatingFilter::new(input, complex_gain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_non_recirculating_filter_2nd_form.rs:98:29 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new(input: DynSoundSource, complex_gain: ComplexKnob) -> Self { [INFO] [stdout] | --------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let duration = input.duration(); [INFO] [stdout] 96 | let complex_input = Box::new(RealToComplex::new(input, Box::new(DC::new(0.0, duration)))); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ElementaryNonRecirculatingFilter2 { [INFO] [stdout] 98 | complex_filter: ComplexElementaryNonRecirculatingFilter2::new(complex_input, complex_gain) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_non_recirculating_filter_2nd_form.rs:129:18 [INFO] [stdout] | [INFO] [stdout] 127 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let complex_gain = reader.get_complex_knob(¶ms[1]); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Box::new(ElementaryNonRecirculatingFilter2::new(input, complex_gain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reverberator.rs:56:32 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(input: DynSoundSource, gain: f32) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let buffer = Arc::new(Mutex::new(Vec::<(f32,f32)>::new())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | // Rotate + delaychain of: pi/10, 30ms, pi/10, 55ms, -pi/5, 80ms [INFO] [stdout] 40 | let rotation_1 = RotationTransfer::new(input, std::f32::consts::PI * 0.1); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let uneven_delay1 = UnevenDelay::new(Box::new(rotation_1), 0, 1440); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let rotation_2 = RotationTransfer::new(Box::new(uneven_delay1), std::f32::consts::PI * 0.1); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let uneven_delay2 = UnevenDelay::new(Box::new(rotation_2), 0, 2640); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let rotation_3 = RotationTransfer::new(Box::new(uneven_delay2), -std::f32::consts::PI * 0.2); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let uneven_delay3 = UnevenDelay::new(Box::new(rotation_3), 0, 3840); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | // recirculating delay 0.07, 0.04 and gain [INFO] [stdout] 47 | let buffer_reader = BufferReader::new(buffer.clone(), duration); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let uneven_delay4 = UnevenDelay::new(Box::new(buffer_reader), 3360, 1920); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let rotation_4 = RotationTransfer::new(Box::new(uneven_delay4), std::f32::consts::PI * 0.3); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut recirculating_gain = Multiply::new(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let mut mix = Mix::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Reverberator { output: Box::new(BufferWriter::new(Box::new(mix), buffer.clone())), duration: duration } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_recirculating_filter.rs:107:29 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(input: DynSoundSource, complex_gain: ComplexKnob) -> Self { [INFO] [stdout] | --------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let duration = input.duration(); [INFO] [stdout] 105 | let complex_input = Box::new(RealToComplex::new(input, Box::new(DC::new(0.0, duration)))); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | ElementaryRecirculatingFilter { [INFO] [stdout] 107 | complex_filter: ComplexElementaryRecirculatingFilter::new(complex_input, complex_gain), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reverberator.rs:81:18 [INFO] [stdout] | [INFO] [stdout] 79 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let gain = params[1].parse::().unwrap(); [INFO] [stdout] 81 | Box::new(Reverberator::new(input, gain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_recirculating_filter.rs:138:18 [INFO] [stdout] | [INFO] [stdout] 136 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let complex_gain = reader.get_complex_knob(¶ms[1]); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | Box::new(ElementaryRecirculatingFilter::new(input, complex_gain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotation_transfer.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 46 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let angle_of_rotation = params[1].parse::().unwrap(); [INFO] [stdout] 48 | Box::new(RotationTransfer::new(input, angle_of_rotation)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/high_pass_filter.rs:81:18 [INFO] [stdout] | [INFO] [stdout] 79 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let cutoff = reader.get_sound(¶ms[1]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Box::new(HighPassFilter::new(input, cutoff)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/saw.rs:20:36 [INFO] [stdout] | [INFO] [stdout] 16 | freq: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | gain: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Saw { generative_waveform: GenerativeWaveform::new( [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 21 | | freq, [INFO] [stdout] 22 | | 1, [INFO] [stdout] 23 | | 1, [INFO] [stdout] ... | [INFO] [stdout] 26 | | duration [INFO] [stdout] 27 | | ) } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/low_pass_filter.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 71 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let cutoff = reader.get_sound(¶ms[1]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Box::new(LowPassFilter::new(input, cutoff)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/saw.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 49 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let strength = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 52 | Box::new(Self::new(freq, strength, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sine.rs:20:37 [INFO] [stdout] | [INFO] [stdout] 16 | freq: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | gain: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Sine { generative_waveform: GenerativeWaveform::new( [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 21 | | freq, [INFO] [stdout] 22 | | 1000000000, // A really high number so we don't add any frequencies [INFO] [stdout] 23 | | 1, [INFO] [stdout] ... | [INFO] [stdout] 26 | | duration [INFO] [stdout] 27 | | ) } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sine.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 50 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let strength = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 53 | Box::new(Sine::new(freq, strength, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/pole_zero_filter.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 67 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let normalize: DynSoundSource; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let mut poles = Vec::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let mut zeros = Vec::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let mut zero2s = Vec::::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Box::new(PoleZeroFilter::new(input, normalize, poles, zeros, zero2s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/square.rs:20:39 [INFO] [stdout] | [INFO] [stdout] 16 | freq: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | gain: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Square { generative_waveform: GenerativeWaveform::new( [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 21 | | freq, [INFO] [stdout] 22 | | 2, [INFO] [stdout] 23 | | 1, [INFO] [stdout] ... | [INFO] [stdout] 26 | | duration [INFO] [stdout] 27 | | ) } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instruments/vibraphone.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 33 | let tremolo_wave = Sine::new(Knob::dc(5.0 / self.sample_rate as f32), Knob::dc(0.25), duration); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | let sine = Sine::new(Knob::dc(freq), Knob::dc(1.0), duration); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | let mut multiply = Multiply::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Box::new(TimeBox::new(duration, 88, Box::new(multiply))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/square.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 50 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let strength = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 53 | Box::new(Self::new(freq, strength, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time_box.rs:62:18 [INFO] [stdout] | [INFO] [stdout] 61 | let source = reader.get_sound(¶ms[2]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Box::new(Self::new(duration.round() as i32, ramp_time.round() as i32, source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triangle.rs:19:41 [INFO] [stdout] | [INFO] [stdout] 15 | freq: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | gain: Knob, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Triangle { generative_waveform: GenerativeWaveform::new( [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 20 | | freq, [INFO] [stdout] 21 | | 2, [INFO] [stdout] 22 | | 2, [INFO] [stdout] ... | [INFO] [stdout] 25 | | duration [INFO] [stdout] 26 | | ) } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instruments/square_ding.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 34 | let tremolo_wave = Sine::new(Knob::dc(5.0 / self.sample_rate as f32), Knob::dc(0.25), duration); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | let sine = Square::new(Knob::dc(freq), Knob::dc(1.0), duration); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | let mut multiply = Multiply::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Box::new(TimeBox::new(duration, 88, Box::new(multiply))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triangle.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 49 | let freq = reader.get_knob(¶ms[0], 1.0 / reader.sample_rate as f32); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let strength = reader.get_knob(¶ms[1], 1.0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let duration = params[2].parse::().unwrap() * reader.sample_rate as f32; [INFO] [stdout] 52 | Box::new(Self::new(freq, strength, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instruments/triangle_ding.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 34 | let tremolo_wave = Sine::new(Knob::dc(5.0 / self.sample_rate as f32), Knob::dc(0.25), duration); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | let sine = Triangle::new(Knob::dc(freq), Knob::dc(1.0), duration); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | let mut multiply = Multiply::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Box::new(TimeBox::new(duration, 88, Box::new(multiply))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uneven_delay.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 57 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Box::new(UnevenDelay::new(input, left_delay.round() as i32, right_delay.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wavetable.rs:119:18 [INFO] [stdout] | [INFO] [stdout] 109 | let table = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let sweep = reader.get_sound(¶ms[1]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Box::new(Wavetable::new(table, sweep, interpolation, duration.round() as i32)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instruments/saw_ding.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 33 | let tremolo_wave = Sine::new(Knob::dc(5.0 / self.sample_rate as f32), Knob::dc(0.25), duration); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | let sine = Saw::new(Knob::dc(freq), Knob::dc(1.0), duration); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | let mut multiply = Multiply::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Box::new(TimeBox::new(duration, 88, Box::new(multiply))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/allpass_filter.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(input: DynSoundSource, gain: ComplexKnob) -> Self { [INFO] [stdout] | --------------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut poles = Vec::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | poles.push(gain.clone()); [INFO] [stdout] 18 | let zeros = Vec::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let mut zero2s = Vec::::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let normalize_dc = Box::new(DC::new(1.0, duration)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | AllpassFilter { [INFO] [stdout] 24 | filter: PoleZeroFilter::new(input, normalize_dc, poles, zeros, zero2s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instruments/uphonium.rs:74:37 [INFO] [stdout] | [INFO] [stdout] 45 | let mut multiplier = Multiply::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut freq_multiplier = Multiply::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | freq_multiplier.add(Box::new(Sine::new(Knob::dc(freq), Knob::new(Box::new(envelope)), duration)), freq); [INFO] [stdout] 60 | let freq_knob = Knob::new(Box::new(freq_multiplier)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | // strength is the gain for oscillators [INFO] [stdout] 62 | let strength_knob = Knob::new(Box::new(multiplier)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let pure_tone = GenerativeWaveform::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let low_pass = LowPassFilter::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Box::new(PreRender::new(Box::new(low_pass))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/allpass_filter.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 52 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let gain = reader.get_complex_knob(¶ms[1]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Box::new(AllpassFilter::new(input, gain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/band_pass_filter.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 94 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let centre = reader.get_sound(¶ms[1]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let bandwidth = reader.get_sound(¶ms[2]); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Box::new(BandPassFilter::new(input, centre, bandwidth)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/butterworth_bandpass_filter.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(input: DynSoundSource, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let mut pole_knobs = Vec::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut zero_knobs = Vec::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let zero2_knobs = Vec::::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let duration = input.duration(); [INFO] [stdout] 64 | let normalize_dc = Box::new(DC::new(normalize, duration)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ButterworthBandpassFilter { [INFO] [stdout] 66 | filter: PoleZeroFilter::new(input, normalize_dc, pole_knobs, zero_knobs, zero2_knobs), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/butterworth_bandpass_filter.rs:101:18 [INFO] [stdout] | [INFO] [stdout] 94 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Box::new(ButterworthBandpassFilter::new(input, num_points, pole_r, zero_r, center_freq, normalize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/butterworth_filter.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(input: DynSoundSource, num_points: usize, pole_r: f32, zero_r: f32, normalize: f32) -> Self [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let mut pole_knobs = Vec::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let mut zero_knobs = Vec::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let zero2_knobs = Vec::::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let duration = input.duration(); [INFO] [stdout] 55 | let normalize_dc = Box::new(DC::new(normalize, duration)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | ButterworthFilter { [INFO] [stdout] 57 | filter: PoleZeroFilter::new(input, normalize_dc, pole_knobs, zero_knobs, zero2_knobs), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/butterworth_filter.rs:90:18 [INFO] [stdout] | [INFO] [stdout] 85 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Box::new(ButterworthFilter::new(input, num_points, pole_r, zero_r, normalize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_non_recirculating_filter.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn new(input: DynSoundSource, complex_gain: ComplexKnob) -> Self { [INFO] [stdout] | --------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let duration = input.duration(); [INFO] [stdout] 73 | let complex_input = Box::new(RealToComplex::new(input, Box::new(DC::new(0.0, duration)))); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | ElementaryNonRecirculatingFilter { [INFO] [stdout] 75 | complex_filter: ComplexElementaryNonRecirculatingFilter::new(complex_input, complex_gain) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_non_recirculating_filter.rs:106:18 [INFO] [stdout] | [INFO] [stdout] 104 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let complex_gain = reader.get_complex_knob(¶ms[1]); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Box::new(ElementaryNonRecirculatingFilter::new(input, complex_gain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_non_recirculating_filter_2nd_form.rs:98:29 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new(input: DynSoundSource, complex_gain: ComplexKnob) -> Self { [INFO] [stdout] | --------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let duration = input.duration(); [INFO] [stdout] 96 | let complex_input = Box::new(RealToComplex::new(input, Box::new(DC::new(0.0, duration)))); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ElementaryNonRecirculatingFilter2 { [INFO] [stdout] 98 | complex_filter: ComplexElementaryNonRecirculatingFilter2::new(complex_input, complex_gain) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_non_recirculating_filter_2nd_form.rs:129:18 [INFO] [stdout] | [INFO] [stdout] 127 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let complex_gain = reader.get_complex_knob(¶ms[1]); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Box::new(ElementaryNonRecirculatingFilter2::new(input, complex_gain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_recirculating_filter.rs:107:29 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(input: DynSoundSource, complex_gain: ComplexKnob) -> Self { [INFO] [stdout] | --------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let duration = input.duration(); [INFO] [stdout] 105 | let complex_input = Box::new(RealToComplex::new(input, Box::new(DC::new(0.0, duration)))); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | ElementaryRecirculatingFilter { [INFO] [stdout] 107 | complex_filter: ComplexElementaryRecirculatingFilter::new(complex_input, complex_gain), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/elementary_recirculating_filter.rs:138:18 [INFO] [stdout] | [INFO] [stdout] 136 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let complex_gain = reader.get_complex_knob(¶ms[1]); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | Box::new(ElementaryRecirculatingFilter::new(input, complex_gain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/high_pass_filter.rs:81:18 [INFO] [stdout] | [INFO] [stdout] 79 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let cutoff = reader.get_sound(¶ms[1]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Box::new(HighPassFilter::new(input, cutoff)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/low_pass_filter.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 71 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let cutoff = reader.get_sound(¶ms[1]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Box::new(LowPassFilter::new(input, cutoff)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/pole_zero_filter.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 67 | let input = reader.get_sound(¶ms[0]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let normalize: DynSoundSource; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let mut poles = Vec::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let mut zeros = Vec::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let mut zero2s = Vec::::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Box::new(PoleZeroFilter::new(input, normalize, poles, zeros, zero2s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instruments/vibraphone.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 33 | let tremolo_wave = Sine::new(Knob::dc(5.0 / self.sample_rate as f32), Knob::dc(0.25), duration); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | let sine = Sine::new(Knob::dc(freq), Knob::dc(1.0), duration); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | let mut multiply = Multiply::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Box::new(TimeBox::new(duration, 88, Box::new(multiply))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instruments/square_ding.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 34 | let tremolo_wave = Sine::new(Knob::dc(5.0 / self.sample_rate as f32), Knob::dc(0.25), duration); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | let sine = Square::new(Knob::dc(freq), Knob::dc(1.0), duration); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | let mut multiply = Multiply::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Box::new(TimeBox::new(duration, 88, Box::new(multiply))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instruments/triangle_ding.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 34 | let tremolo_wave = Sine::new(Knob::dc(5.0 / self.sample_rate as f32), Knob::dc(0.25), duration); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | let sine = Triangle::new(Knob::dc(freq), Knob::dc(1.0), duration); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | let mut multiply = Multiply::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Box::new(TimeBox::new(duration, 88, Box::new(multiply))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instruments/saw_ding.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 33 | let tremolo_wave = Sine::new(Knob::dc(5.0 / self.sample_rate as f32), Knob::dc(0.25), duration); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | let sine = Saw::new(Knob::dc(freq), Knob::dc(1.0), duration); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | let mut multiply = Multiply::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Box::new(TimeBox::new(duration, 88, Box::new(multiply))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instruments/uphonium.rs:74:37 [INFO] [stdout] | [INFO] [stdout] 45 | let mut multiplier = Multiply::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut freq_multiplier = Multiply::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | freq_multiplier.add(Box::new(Sine::new(Knob::dc(freq), Knob::new(Box::new(envelope)), duration)), freq); [INFO] [stdout] 60 | let freq_knob = Knob::new(Box::new(freq_multiplier)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | // strength is the gain for oscillators [INFO] [stdout] 62 | let strength_knob = Knob::new(Box::new(multiplier)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let pure_tone = GenerativeWaveform::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let low_pass = LowPassFilter::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Box::new(PreRender::new(Box::new(low_pass))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 52 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 52 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mattmusic` (bin "mattmusic" test) due to 53 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `mattmusic` (bin "mattmusic") due to 53 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aeeddd634dc14a118ece0d658ebde28f5de3b426de19fe44238bc9e6a9339f41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aeeddd634dc14a118ece0d658ebde28f5de3b426de19fe44238bc9e6a9339f41", kill_on_drop: false }` [INFO] [stdout] aeeddd634dc14a118ece0d658ebde28f5de3b426de19fe44238bc9e6a9339f41