[INFO] cloning repository https://github.com/mattjbray/rust-raytracing [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mattjbray/rust-raytracing" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmattjbray%2Frust-raytracing", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmattjbray%2Frust-raytracing'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b354ee8291ff5d474fb17edf67e1efc2f7e073f8 [INFO] checking mattjbray/rust-raytracing against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmattjbray%2Frust-raytracing" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mattjbray/rust-raytracing on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mattjbray/rust-raytracing [INFO] finished tweaking git repo https://github.com/mattjbray/rust-raytracing [INFO] tweaked toml for git repo https://github.com/mattjbray/rust-raytracing written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/mattjbray/rust-raytracing already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 86d7ab9463fac94bf1f954dc00534505a331f5de13a9bb581f262a54701d3d1a [INFO] running `Command { std: "docker" "start" "-a" "86d7ab9463fac94bf1f954dc00534505a331f5de13a9bb581f262a54701d3d1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "86d7ab9463fac94bf1f954dc00534505a331f5de13a9bb581f262a54701d3d1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86d7ab9463fac94bf1f954dc00534505a331f5de13a9bb581f262a54701d3d1a", kill_on_drop: false }` [INFO] [stdout] 86d7ab9463fac94bf1f954dc00534505a331f5de13a9bb581f262a54701d3d1a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 98dbeb0733cf3920add23d89c020e744abd065584dd10f03b7c3cb1c5b503162 [INFO] running `Command { std: "docker" "start" "-a" "98dbeb0733cf3920add23d89c020e744abd065584dd10f03b7c3cb1c5b503162", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling getrandom v0.2.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking rand_core v0.6.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.0 [INFO] [stderr] Checking rust-raytracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/camera.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sphere.rs:45:76 [INFO] [stdout] | [INFO] [stdout] 45 | let hit_record = Hit::new(t, p, &outward_normal, ray, self.material.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dyn Material` does not implement `Clone`, so calling `clone` on `&dyn Material` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/camera.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sphere.rs:45:76 [INFO] [stdout] | [INFO] [stdout] 45 | let hit_record = Hit::new(t, p, &outward_normal, ray, self.material.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dyn Material` does not implement `Clone`, so calling `clone` on `&dyn Material` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.47s [INFO] running `Command { std: "docker" "inspect" "98dbeb0733cf3920add23d89c020e744abd065584dd10f03b7c3cb1c5b503162", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98dbeb0733cf3920add23d89c020e744abd065584dd10f03b7c3cb1c5b503162", kill_on_drop: false }` [INFO] [stdout] 98dbeb0733cf3920add23d89c020e744abd065584dd10f03b7c3cb1c5b503162 [INFO] checking mattjbray/rust-raytracing against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmattjbray%2Frust-raytracing" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mattjbray/rust-raytracing on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mattjbray/rust-raytracing [INFO] finished tweaking git repo https://github.com/mattjbray/rust-raytracing [INFO] tweaked toml for git repo https://github.com/mattjbray/rust-raytracing written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/mattjbray/rust-raytracing already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f6894e5ec1780bc15f48c4e8d737e0e7196d2bcdbc8949d77b54977ef59d3906 [INFO] running `Command { std: "docker" "start" "-a" "f6894e5ec1780bc15f48c4e8d737e0e7196d2bcdbc8949d77b54977ef59d3906", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f6894e5ec1780bc15f48c4e8d737e0e7196d2bcdbc8949d77b54977ef59d3906", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6894e5ec1780bc15f48c4e8d737e0e7196d2bcdbc8949d77b54977ef59d3906", kill_on_drop: false }` [INFO] [stdout] f6894e5ec1780bc15f48c4e8d737e0e7196d2bcdbc8949d77b54977ef59d3906 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ea5de379b5be65d5a0e392b3e5456829fc3539c5670b30bf81e78847be01025a [INFO] running `Command { std: "docker" "start" "-a" "ea5de379b5be65d5a0e392b3e5456829fc3539c5670b30bf81e78847be01025a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling getrandom v0.2.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking rand_core v0.6.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.0 [INFO] [stderr] Checking rust-raytracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/camera.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sphere.rs:45:76 [INFO] [stdout] | [INFO] [stdout] 45 | let hit_record = Hit::new(t, p, &outward_normal, ray, self.material.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dyn Material` does not implement `Clone`, so calling `clone` on `&dyn Material` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec3.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn gen_range(rng: &mut impl rand::Rng, range: R) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | x: rng.gen_range(range.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec3.rs:21:30 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn gen_range(rng: &mut impl rand::Rng, range: R) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | y: rng.gen_range(range.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-raytracer` (bin "rust-raytracer") due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/camera.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/sphere.rs:45:76 [INFO] [stdout] | [INFO] [stdout] 45 | let hit_record = Hit::new(t, p, &outward_normal, ray, self.material.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dyn Material` does not implement `Clone`, so calling `clone` on `&dyn Material` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec3.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn gen_range(rng: &mut impl rand::Rng, range: R) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | x: rng.gen_range(range.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec3.rs:21:30 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn gen_range(rng: &mut impl rand::Rng, range: R) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | y: rng.gen_range(range.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-raytracer` (bin "rust-raytracer" test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ea5de379b5be65d5a0e392b3e5456829fc3539c5670b30bf81e78847be01025a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea5de379b5be65d5a0e392b3e5456829fc3539c5670b30bf81e78847be01025a", kill_on_drop: false }` [INFO] [stdout] ea5de379b5be65d5a0e392b3e5456829fc3539c5670b30bf81e78847be01025a