[INFO] cloning repository https://github.com/lukehoban/endo-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lukehoban/endo-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flukehoban%2Fendo-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flukehoban%2Fendo-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2e1fa8cf66fca99776edcd550e1c38a518a43622 [INFO] checking lukehoban/endo-rust against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flukehoban%2Fendo-rust" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/lukehoban/endo-rust on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/lukehoban/endo-rust [INFO] finished tweaking git repo https://github.com/lukehoban/endo-rust [INFO] tweaked toml for git repo https://github.com/lukehoban/endo-rust written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/lukehoban/endo-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num-iter v0.1.35 [INFO] [stderr] Downloaded adler32 v1.0.2 [INFO] [stderr] Downloaded inflate v0.3.4 [INFO] [stderr] Downloaded cfg-if v0.1.2 [INFO] [stderr] Downloaded deflate v0.7.18 [INFO] [stderr] Downloaded nodrop v0.1.12 [INFO] [stderr] Downloaded enum_primitive v0.1.1 [INFO] [stderr] Downloaded color_quant v1.0.0 [INFO] [stderr] Downloaded getopts v0.2.17 [INFO] [stderr] Downloaded either v1.5.0 [INFO] [stderr] Downloaded arrayvec v0.4.7 [INFO] [stderr] Downloaded byteorder v1.2.2 [INFO] [stderr] Downloaded gif v0.9.2 [INFO] [stderr] Downloaded jpeg-decoder v0.1.14 [INFO] [stderr] Downloaded rayon-core v1.4.0 [INFO] [stderr] Downloaded num-rational v0.1.42 [INFO] [stderr] Downloaded rand v0.4.2 [INFO] [stderr] Downloaded image v0.18.0 [INFO] [stderr] Downloaded rayon v1.0.1 [INFO] [stderr] Downloaded crossbeam-epoch v0.3.1 [INFO] [stderr] Downloaded crossbeam-deque v0.2.0 [INFO] [stderr] Downloaded lazy_static v1.0.0 [INFO] [stderr] Downloaded num-traits v0.2.2 [INFO] [stderr] Downloaded png v0.11.0 [INFO] [stderr] Downloaded num_cpus v1.8.0 [INFO] [stderr] Downloaded num-traits v0.1.43 [INFO] [stderr] Downloaded crossbeam-utils v0.2.2 [INFO] [stderr] Downloaded libc v0.2.40 [INFO] [stderr] Downloaded num-integer v0.1.36 [INFO] [stderr] Downloaded winapi v0.3.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd148f53a95ed985d06d631dbfd82356bda8d405ee17f10d731149cc781940d6 [INFO] running `Command { std: "docker" "start" "-a" "cd148f53a95ed985d06d631dbfd82356bda8d405ee17f10d731149cc781940d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd148f53a95ed985d06d631dbfd82356bda8d405ee17f10d731149cc781940d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd148f53a95ed985d06d631dbfd82356bda8d405ee17f10d731149cc781940d6", kill_on_drop: false }` [INFO] [stdout] cd148f53a95ed985d06d631dbfd82356bda8d405ee17f10d731149cc781940d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d6ee09464ac3b8c1c2510599975b6310a986ee556ea46b2f9c77eb54e268b755 [INFO] running `Command { std: "docker" "start" "-a" "d6ee09464ac3b8c1c2510599975b6310a986ee556ea46b2f9c77eb54e268b755", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking num-traits v0.2.2 [INFO] [stderr] Checking libc v0.2.40 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking adler32 v1.0.2 [INFO] [stderr] Checking byteorder v1.2.2 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking color_quant v1.0.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking xi-rope v0.0.0 (/opt/rustwide/workdir/rope) [INFO] [stderr] Checking getopts v0.2.17 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking inflate v0.3.4 [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> rope/src/tree.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 44 | fn compute_info(&Self::L) -> Self; [INFO] [stdout] | ^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Self::L` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> rope/src/tree.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | fn measure(&N, usize) -> usize; [INFO] [stdout] | ^^ help: try naming the parameter or explicitly ignoring it: `_: &N` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> rope/src/tree.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 120 | fn measure(&N, usize) -> usize; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: usize` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> rope/src/tree.rs:206:45 [INFO] [stdout] | [INFO] [stdout] 206 | NodeVal::Internal(ref nodes) => (nodes.len() >= MIN_CHILDREN) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 206 - NodeVal::Internal(ref nodes) => (nodes.len() >= MIN_CHILDREN) [INFO] [stdout] 206 + NodeVal::Internal(ref nodes) => nodes.len() >= MIN_CHILDREN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> rope/src/tree.rs:510:52 [INFO] [stdout] | [INFO] [stdout] 510 | pub fn prev>(&mut self) -> Option<(usize)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 510 - pub fn prev>(&mut self) -> Option<(usize)> { [INFO] [stdout] 510 + pub fn prev>(&mut self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> rope/src/tree.rs:556:52 [INFO] [stdout] | [INFO] [stdout] 556 | pub fn next>(&mut self) -> Option<(usize)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 556 - pub fn next>(&mut self) -> Option<(usize)> { [INFO] [stdout] 556 + pub fn next>(&mut self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> rope/src/interval.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | try!(write!(f, "{}, {}", self.start(), self.end())); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> rope/src/interval.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | try!(write!(f, "[")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> rope/src/interval.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | try!(write!(f, "(")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> rope/src/interval.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | try!(write!(f, "]")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> rope/src/interval.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | try!(write!(f, ")")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> rope/src/lib.rs:412:33 [INFO] [stdout] | [INFO] [stdout] 412 | NodeVal::Leaf(_) => (self.len() >= MIN_LEAF), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 412 - NodeVal::Leaf(_) => (self.len() >= MIN_LEAF), [INFO] [stdout] 412 + NodeVal::Leaf(_) => self.len() >= MIN_LEAF, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> rope/src/lib.rs:413:46 [INFO] [stdout] | [INFO] [stdout] 413 | NodeVal::Internal(ref pieces) => (pieces.len() >= MIN_CHILDREN) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 413 - NodeVal::Internal(ref pieces) => (pieces.len() >= MIN_CHILDREN) [INFO] [stdout] 413 + NodeVal::Internal(ref pieces) => pieces.len() >= MIN_CHILDREN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> rope/src/tree.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 232 | let mut node1 = Arc::make_mut(&mut rope1.0); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> rope/src/rope.rs:137:24 [INFO] [stdout] | [INFO] [stdout] 137 | pub struct LinesMetric(usize); // number of lines [INFO] [stdout] | ----------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking endo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/gene.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | let mut gene = &mut genes[i]; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/gene.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | let mut gene = &mut genes[i]; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 28 | Err(f) => { panic!(f.to_string()) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 28 | Err(f) => { panic!("{}", f.to_string()) } [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 28 | Err(f) => { panic!(f.to_string()) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 28 | Err(f) => { panic!("{}", f.to_string()) } [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.99s [INFO] running `Command { std: "docker" "inspect" "d6ee09464ac3b8c1c2510599975b6310a986ee556ea46b2f9c77eb54e268b755", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6ee09464ac3b8c1c2510599975b6310a986ee556ea46b2f9c77eb54e268b755", kill_on_drop: false }` [INFO] [stdout] d6ee09464ac3b8c1c2510599975b6310a986ee556ea46b2f9c77eb54e268b755 [INFO] checking lukehoban/endo-rust against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flukehoban%2Fendo-rust" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/lukehoban/endo-rust on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/lukehoban/endo-rust [INFO] finished tweaking git repo https://github.com/lukehoban/endo-rust [INFO] tweaked toml for git repo https://github.com/lukehoban/endo-rust written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/lukehoban/endo-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d6d168f9c71bc48e21210ca044f6570ea90a241728c741665dcedf7a79f5a1f [INFO] running `Command { std: "docker" "start" "-a" "9d6d168f9c71bc48e21210ca044f6570ea90a241728c741665dcedf7a79f5a1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d6d168f9c71bc48e21210ca044f6570ea90a241728c741665dcedf7a79f5a1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d6d168f9c71bc48e21210ca044f6570ea90a241728c741665dcedf7a79f5a1f", kill_on_drop: false }` [INFO] [stdout] 9d6d168f9c71bc48e21210ca044f6570ea90a241728c741665dcedf7a79f5a1f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 796f365ec1103b42060e774c910195a9047ccdca8dc9941b7f8037ce04bb7283 [INFO] running `Command { std: "docker" "start" "-a" "796f365ec1103b42060e774c910195a9047ccdca8dc9941b7f8037ce04bb7283", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking num-traits v0.2.2 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Checking libc v0.2.40 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking adler32 v1.0.2 [INFO] [stderr] Checking byteorder v1.2.2 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking color_quant v1.0.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking xi-rope v0.0.0 (/opt/rustwide/workdir/rope) [INFO] [stderr] Checking getopts v0.2.17 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking inflate v0.3.4 [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> rope/src/tree.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 44 | fn compute_info(&Self::L) -> Self; [INFO] [stdout] | ^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Self::L` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> rope/src/tree.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | fn measure(&N, usize) -> usize; [INFO] [stdout] | ^^ help: try naming the parameter or explicitly ignoring it: `_: &N` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> rope/src/tree.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 120 | fn measure(&N, usize) -> usize; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: usize` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> rope/src/tree.rs:206:45 [INFO] [stdout] | [INFO] [stdout] 206 | NodeVal::Internal(ref nodes) => (nodes.len() >= MIN_CHILDREN) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 206 - NodeVal::Internal(ref nodes) => (nodes.len() >= MIN_CHILDREN) [INFO] [stdout] 206 + NodeVal::Internal(ref nodes) => nodes.len() >= MIN_CHILDREN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> rope/src/tree.rs:510:52 [INFO] [stdout] | [INFO] [stdout] 510 | pub fn prev>(&mut self) -> Option<(usize)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 510 - pub fn prev>(&mut self) -> Option<(usize)> { [INFO] [stdout] 510 + pub fn prev>(&mut self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> rope/src/tree.rs:556:52 [INFO] [stdout] | [INFO] [stdout] 556 | pub fn next>(&mut self) -> Option<(usize)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 556 - pub fn next>(&mut self) -> Option<(usize)> { [INFO] [stdout] 556 + pub fn next>(&mut self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> rope/src/interval.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | try!(write!(f, "{}, {}", self.start(), self.end())); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> rope/src/interval.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | try!(write!(f, "[")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> rope/src/interval.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | try!(write!(f, "(")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> rope/src/interval.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | try!(write!(f, "]")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> rope/src/interval.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | try!(write!(f, ")")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> rope/src/lib.rs:412:33 [INFO] [stdout] | [INFO] [stdout] 412 | NodeVal::Leaf(_) => (self.len() >= MIN_LEAF), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 412 - NodeVal::Leaf(_) => (self.len() >= MIN_LEAF), [INFO] [stdout] 412 + NodeVal::Leaf(_) => self.len() >= MIN_LEAF, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> rope/src/lib.rs:413:46 [INFO] [stdout] | [INFO] [stdout] 413 | NodeVal::Internal(ref pieces) => (pieces.len() >= MIN_CHILDREN) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 413 - NodeVal::Internal(ref pieces) => (pieces.len() >= MIN_CHILDREN) [INFO] [stdout] 413 + NodeVal::Internal(ref pieces) => pieces.len() >= MIN_CHILDREN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> rope/src/tree.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 232 | let mut node1 = Arc::make_mut(&mut rope1.0); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> rope/src/rope.rs:137:24 [INFO] [stdout] | [INFO] [stdout] 137 | pub struct LinesMetric(usize); // number of lines [INFO] [stdout] | ----------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rope/src/tree.rs:149:14 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn from_leaf(l: N::L) -> Node { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let len = l.len(); [INFO] [stdout] 148 | let info = N::compute_info(&l); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | Node(Arc::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 150 | | NodeBody { [INFO] [stdout] 151 | | height: 0, [INFO] [stdout] 152 | | len: len, [INFO] [stdout] 153 | | info: info, [INFO] [stdout] 154 | | val: NodeVal::Leaf(l), [INFO] [stdout] 155 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rope/src/tree.rs:166:14 [INFO] [stdout] | [INFO] [stdout] 158 | fn from_nodes(nodes: Vec>) -> Node { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | let mut info = nodes[0].0.info.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Node(Arc::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 167 | | NodeBody { [INFO] [stdout] 168 | | height: height, [INFO] [stdout] 169 | | len: len, [INFO] [stdout] 170 | | info: info, [INFO] [stdout] 171 | | val: NodeVal::Internal(nodes), [INFO] [stdout] 172 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rope/src/tree.rs:231:15 [INFO] [stdout] | [INFO] [stdout] 226 | fn merge_leaves(mut rope1: Node, rope2: Node) -> Node { [INFO] [stdout] | ------------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | match { [INFO] [stdout] | _______________^ [INFO] [stdout] 232 | | let mut node1 = Arc::make_mut(&mut rope1.0); [INFO] [stdout] 233 | | let leaf2 = rope2.get_leaf(); [INFO] [stdout] 234 | | if let NodeVal::Leaf(ref mut leaf1) = node1.val { [INFO] [stdout] ... | [INFO] [stdout] 242 | | } [INFO] [stdout] 243 | | } { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rope/src/tree.rs:421:15 [INFO] [stdout] | [INFO] [stdout] 420 | pub fn push(&mut self, n: Node) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | match self.0.take() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rope/src/tree.rs:428:19 [INFO] [stdout] | [INFO] [stdout] 427 | pub fn push_leaf(&mut self, l: N::L) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | self.push(Node::from_leaf(l)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rope/src/delta.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn add(&mut self, interval: Interval, rope: Node) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | self.items.push(DeltaItem { [INFO] [stdout] | _________________________^ [INFO] [stdout] 43 | | interval: interval, [INFO] [stdout] 44 | | rope: rope, [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rope/src/spans.rs:137:30 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn add_span(&mut self, iv: Interval, data: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | self.leaf.spans.push(Span { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 138 | | iv: iv.translate_neg(self.len), [INFO] [stdout] 139 | | data: data, [INFO] [stdout] 140 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xi-rope` (lib) due to 8 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "796f365ec1103b42060e774c910195a9047ccdca8dc9941b7f8037ce04bb7283", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "796f365ec1103b42060e774c910195a9047ccdca8dc9941b7f8037ce04bb7283", kill_on_drop: false }` [INFO] [stdout] 796f365ec1103b42060e774c910195a9047ccdca8dc9941b7f8037ce04bb7283