[INFO] cloning repository https://github.com/logannc/valence [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/logannc/valence" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flogannc%2Fvalence", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flogannc%2Fvalence'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 25508413302813b1624d80dff886ce3c0b257ab5 [INFO] checking logannc/valence against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flogannc%2Fvalence" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/logannc/valence on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/logannc/valence [INFO] finished tweaking git repo https://github.com/logannc/valence [INFO] tweaked toml for git repo https://github.com/logannc/valence written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/logannc/valence already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-timer v0.2.7 [INFO] [stderr] Downloaded syn v0.15.18 [INFO] [stderr] Downloaded tokio-current-thread v0.1.3 [INFO] [stderr] Downloaded proc-macro2 v0.4.21 [INFO] [stderr] Downloaded tokio-uds v0.2.3 [INFO] [stderr] Downloaded tokio-threadpool v0.1.8 [INFO] [stderr] Downloaded tokio v0.1.11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e89eb23e5c57b128719d60e982af110ac110573ebb3bd2ca7e6519d07864f567 [INFO] running `Command { std: "docker" "start" "-a" "e89eb23e5c57b128719d60e982af110ac110573ebb3bd2ca7e6519d07864f567", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e89eb23e5c57b128719d60e982af110ac110573ebb3bd2ca7e6519d07864f567", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e89eb23e5c57b128719d60e982af110ac110573ebb3bd2ca7e6519d07864f567", kill_on_drop: false }` [INFO] [stdout] e89eb23e5c57b128719d60e982af110ac110573ebb3bd2ca7e6519d07864f567 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9b8373cec0ad44f4c3198d6e1a596dda8446fe0a4d724adf62c8adafa2c79918 [INFO] running `Command { std: "docker" "start" "-a" "9b8373cec0ad44f4c3198d6e1a596dda8446fe0a4d724adf62c8adafa2c79918", kill_on_drop: false }` [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking futures v0.1.25 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking crossbeam-utils v0.5.0 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking slab v0.4.1 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking lazycell v1.2.0 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling proc-macro2 v0.4.21 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking smallvec v0.6.5 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking lock_api v0.1.4 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking bytes v0.4.10 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-executor v0.1.5 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking tokio-threadpool v0.1.8 [INFO] [stderr] Checking tokio-current-thread v0.1.3 [INFO] [stderr] Checking tokio-timer v0.2.7 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking valence v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/client.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 40 | / loop { [INFO] [stdout] 41 | | let mut buf = String::new(); [INFO] [stdout] 42 | | std::io::stdin().read_line(&mut buf); [INFO] [stdout] 43 | | let msg = serialize(&ClientMessage::Message(buf)).unwrap().into(); [INFO] [stdout] 44 | | writer = writer.send(msg).wait().unwrap(); [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________- any code following this expression is unreachable [INFO] [stdout] 46 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/client.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 40 | / loop { [INFO] [stdout] 41 | | let mut buf = String::new(); [INFO] [stdout] 42 | | std::io::stdin().read_line(&mut buf); [INFO] [stdout] 43 | | let msg = serialize(&ClientMessage::Message(buf)).unwrap().into(); [INFO] [stdout] 44 | | writer = writer.send(msg).wait().unwrap(); [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________- any code following this expression is unreachable [INFO] [stdout] 46 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/network.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 143 | panic!("error: {}", err); [INFO] [stdout] | ------------------------ any code following this expression is unreachable [INFO] [stdout] 144 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/network.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 143 | panic!("error: {}", err); [INFO] [stdout] | ------------------------ any code following this expression is unreachable [INFO] [stdout] 144 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/network.rs:111:29 [INFO] [stdout] | [INFO] [stdout] 111 | ClientMessage::Join(name) => Ok(()), // Ignore this misbehaving message. [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/network.rs:111:29 [INFO] [stdout] | [INFO] [stdout] 111 | ClientMessage::Join(name) => Ok(()), // Ignore this misbehaving message. [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/network.rs:87:35 [INFO] [stdout] | [INFO] [stdout] 87 | .filter(|(&k, v)| k != ID) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/network.rs:87:35 [INFO] [stdout] | [INFO] [stdout] 87 | .filter(|(&k, v)| k != ID) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/network.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | Err(err) => Err(Error::from(ErrorKind::InvalidData)), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/network.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | Err(err) => Err(Error::from(ErrorKind::InvalidData)), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | std::io::stdin().read_line(&mut buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 42 | let _ = std::io::stdin().read_line(&mut buf); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | std::io::stdin().read_line(&mut buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 42 | let _ = std::io::stdin().read_line(&mut buf); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | peer.writer.start_send(serialized_msg.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 31 | let _ = peer.writer.start_send(serialized_msg.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | peer.writer.start_send(serialized_msg.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 31 | let _ = peer.writer.start_send(serialized_msg.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 44 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 44 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 58 | let ID = Uuid::new_v4(); [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 58 | let ID = Uuid::new_v4(); [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:77:46 [INFO] [stdout] | [INFO] [stdout] 77 | fn handle_client_message(msg: ClientMessage, ID: Uuid, peers: &mut Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:77:46 [INFO] [stdout] | [INFO] [stdout] 77 | fn handle_client_message(msg: ClientMessage, ID: Uuid, peers: &mut Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:115:34 [INFO] [stdout] | [INFO] [stdout] 115 | fn handle_frame(frame: BytesMut, ID: Uuid, mut peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:115:34 [INFO] [stdout] | [INFO] [stdout] 115 | fn handle_frame(frame: BytesMut, ID: Uuid, mut peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 121 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 121 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:126:22 [INFO] [stdout] | [INFO] [stdout] 126 | fn handle_disconnect(ID: Uuid, mut peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:126:22 [INFO] [stdout] | [INFO] [stdout] 126 | fn handle_disconnect(ID: Uuid, mut peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 131 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 131 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:137:10 [INFO] [stdout] | [INFO] [stdout] 137 | let (ID, framed_reader) = input; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:137:10 [INFO] [stdout] | [INFO] [stdout] 137 | let (ID, framed_reader) = input; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.09s [INFO] running `Command { std: "docker" "inspect" "9b8373cec0ad44f4c3198d6e1a596dda8446fe0a4d724adf62c8adafa2c79918", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b8373cec0ad44f4c3198d6e1a596dda8446fe0a4d724adf62c8adafa2c79918", kill_on_drop: false }` [INFO] [stdout] 9b8373cec0ad44f4c3198d6e1a596dda8446fe0a4d724adf62c8adafa2c79918 [INFO] checking logannc/valence against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flogannc%2Fvalence" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/logannc/valence on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/logannc/valence [INFO] finished tweaking git repo https://github.com/logannc/valence [INFO] tweaked toml for git repo https://github.com/logannc/valence written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/logannc/valence already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32a6c642b3495412488120274d60270e80e1c58b56755affd355fa587cdfb223 [INFO] running `Command { std: "docker" "start" "-a" "32a6c642b3495412488120274d60270e80e1c58b56755affd355fa587cdfb223", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32a6c642b3495412488120274d60270e80e1c58b56755affd355fa587cdfb223", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32a6c642b3495412488120274d60270e80e1c58b56755affd355fa587cdfb223", kill_on_drop: false }` [INFO] [stdout] 32a6c642b3495412488120274d60270e80e1c58b56755affd355fa587cdfb223 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 476b21a0717c06c2c91731a4c9619621b2a3c427628c22a0b0df26abcb9bc297 [INFO] running `Command { std: "docker" "start" "-a" "476b21a0717c06c2c91731a4c9619621b2a3c427628c22a0b0df26abcb9bc297", kill_on_drop: false }` [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking futures v0.1.25 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking crossbeam-utils v0.5.0 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking slab v0.4.1 [INFO] [stderr] Checking lazycell v1.2.0 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Compiling proc-macro2 v0.4.21 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Checking smallvec v0.6.5 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking lock_api v0.1.4 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking bytes v0.4.10 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking tokio-executor v0.1.5 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking tokio-threadpool v0.1.8 [INFO] [stderr] Checking tokio-timer v0.2.7 [INFO] [stderr] Checking tokio-current-thread v0.1.3 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking valence v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/client.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 40 | / loop { [INFO] [stdout] 41 | | let mut buf = String::new(); [INFO] [stdout] 42 | | std::io::stdin().read_line(&mut buf); [INFO] [stdout] 43 | | let msg = serialize(&ClientMessage::Message(buf)).unwrap().into(); [INFO] [stdout] 44 | | writer = writer.send(msg).wait().unwrap(); [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________- any code following this expression is unreachable [INFO] [stdout] 46 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/client.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 40 | / loop { [INFO] [stdout] 41 | | let mut buf = String::new(); [INFO] [stdout] 42 | | std::io::stdin().read_line(&mut buf); [INFO] [stdout] 43 | | let msg = serialize(&ClientMessage::Message(buf)).unwrap().into(); [INFO] [stdout] 44 | | writer = writer.send(msg).wait().unwrap(); [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________- any code following this expression is unreachable [INFO] [stdout] 46 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/network.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 143 | panic!("error: {}", err); [INFO] [stdout] | ------------------------ any code following this expression is unreachable [INFO] [stdout] 144 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/network.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 143 | panic!("error: {}", err); [INFO] [stdout] | ------------------------ any code following this expression is unreachable [INFO] [stdout] 144 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/network.rs:111:29 [INFO] [stdout] | [INFO] [stdout] 111 | ClientMessage::Join(name) => Ok(()), // Ignore this misbehaving message. [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/network.rs:87:35 [INFO] [stdout] | [INFO] [stdout] 87 | .filter(|(&k, v)| k != ID) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/network.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | Err(err) => Err(Error::from(ErrorKind::InvalidData)), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/network.rs:111:29 [INFO] [stdout] | [INFO] [stdout] 111 | ClientMessage::Join(name) => Ok(()), // Ignore this misbehaving message. [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/network.rs:87:35 [INFO] [stdout] | [INFO] [stdout] 87 | .filter(|(&k, v)| k != ID) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/network.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | Err(err) => Err(Error::from(ErrorKind::InvalidData)), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | std::io::stdin().read_line(&mut buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 42 | let _ = std::io::stdin().read_line(&mut buf); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | peer.writer.start_send(serialized_msg.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 31 | let _ = peer.writer.start_send(serialized_msg.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | std::io::stdin().read_line(&mut buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 42 | let _ = std::io::stdin().read_line(&mut buf); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | peer.writer.start_send(serialized_msg.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 31 | let _ = peer.writer.start_send(serialized_msg.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 44 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:54:11 [INFO] [stdout] | [INFO] [stdout] 49 | buf: BytesMut, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | framed_reader: FramedReader, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | framed_writer: FramedWriter, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | mut peers: Peers, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | ) -> Result<(Uuid, FramedReader), Error> { [INFO] [stdout] 54 | match deserialize(&*buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 58 | let ID = Uuid::new_v4(); [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:77:46 [INFO] [stdout] | [INFO] [stdout] 77 | fn handle_client_message(msg: ClientMessage, ID: Uuid, peers: &mut Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:115:34 [INFO] [stdout] | [INFO] [stdout] 115 | fn handle_frame(frame: BytesMut, ID: Uuid, mut peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 121 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:126:22 [INFO] [stdout] | [INFO] [stdout] 126 | fn handle_disconnect(ID: Uuid, mut peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 131 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:137:10 [INFO] [stdout] | [INFO] [stdout] 137 | let (ID, framed_reader) = input; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:140:56 [INFO] [stdout] | [INFO] [stdout] 136 | fn spawn_message_handler(input: (Uuid, FramedReader), peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | .for_each(move |frame| handle_frame(frame, ID, peers.clone())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:165:17 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn socket_handler(socket: TcpStream, peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | let framed_writer = FramedWrite::new(writer, LengthDelimitedCodec::new()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | .and_then(|(maybe_buf, framed_reader)| { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | |buf| handshake_handler(buf, framed_reader, framed_writer, peers), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:164:24 [INFO] [stdout] | [INFO] [stdout] 164 | || Err(Error::from(ErrorKind::UnexpectedEof)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:13:56 [INFO] [stdout] | [INFO] [stdout] 10 | let peers: Peers = Arc::new(Mutex::new(HashMap::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | .for_each(move |socket| socket_handler(socket, peers.clone())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:4:28 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 44 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:54:11 [INFO] [stdout] | [INFO] [stdout] 49 | buf: BytesMut, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | framed_reader: FramedReader, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | framed_writer: FramedWriter, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | mut peers: Peers, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | ) -> Result<(Uuid, FramedReader), Error> { [INFO] [stdout] 54 | match deserialize(&*buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 58 | let ID = Uuid::new_v4(); [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:77:46 [INFO] [stdout] | [INFO] [stdout] 77 | fn handle_client_message(msg: ClientMessage, ID: Uuid, peers: &mut Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:115:34 [INFO] [stdout] | [INFO] [stdout] 115 | fn handle_frame(frame: BytesMut, ID: Uuid, mut peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 121 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:126:22 [INFO] [stdout] | [INFO] [stdout] 126 | fn handle_disconnect(ID: Uuid, mut peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | peer.writer.poll_complete(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 131 | let _ = peer.writer.poll_complete(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ID` should have a snake case name [INFO] [stdout] --> src/network.rs:137:10 [INFO] [stdout] | [INFO] [stdout] 137 | let (ID, framed_reader) = input; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:140:56 [INFO] [stdout] | [INFO] [stdout] 136 | fn spawn_message_handler(input: (Uuid, FramedReader), peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | .for_each(move |frame| handle_frame(frame, ID, peers.clone())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:165:17 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn socket_handler(socket: TcpStream, peers: Peers) -> Result<(), Error> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | let framed_writer = FramedWrite::new(writer, LengthDelimitedCodec::new()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | .and_then(|(maybe_buf, framed_reader)| { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | |buf| handshake_handler(buf, framed_reader, framed_writer, peers), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:164:24 [INFO] [stdout] | [INFO] [stdout] 164 | || Err(Error::from(ErrorKind::UnexpectedEof)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:13:56 [INFO] [stdout] | [INFO] [stdout] 10 | let peers: Peers = Arc::new(Mutex::new(HashMap::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | .for_each(move |socket| socket_handler(socket, peers.clone())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:4:28 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valence` (bin "valence") due to 8 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `valence` (bin "valence" test) due to 8 previous errors; 15 warnings emitted [INFO] running `Command { std: "docker" "inspect" "476b21a0717c06c2c91731a4c9619621b2a3c427628c22a0b0df26abcb9bc297", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "476b21a0717c06c2c91731a4c9619621b2a3c427628c22a0b0df26abcb9bc297", kill_on_drop: false }` [INFO] [stdout] 476b21a0717c06c2c91731a4c9619621b2a3c427628c22a0b0df26abcb9bc297