[INFO] cloning repository https://github.com/llamachannel/timpani [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/llamachannel/timpani" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fllamachannel%2Ftimpani", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fllamachannel%2Ftimpani'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ddd641ca4d82510f5a3e240dbd7e92109ae40d72 [INFO] checking llamachannel/timpani against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fllamachannel%2Ftimpani" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/llamachannel/timpani on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/llamachannel/timpani [INFO] finished tweaking git repo https://github.com/llamachannel/timpani [INFO] tweaked toml for git repo https://github.com/llamachannel/timpani written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/llamachannel/timpani already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded radium v0.5.3 [INFO] [stderr] Downloaded bitvec v0.19.5 [INFO] [stderr] Downloaded nom v6.1.2 [INFO] [stderr] Downloaded lexical-core v0.7.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d59d913527b5b21e545efd4b4fd7d01861601248656ebb3b3356a4d00004ba9 [INFO] running `Command { std: "docker" "start" "-a" "8d59d913527b5b21e545efd4b4fd7d01861601248656ebb3b3356a4d00004ba9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d59d913527b5b21e545efd4b4fd7d01861601248656ebb3b3356a4d00004ba9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d59d913527b5b21e545efd4b4fd7d01861601248656ebb3b3356a4d00004ba9", kill_on_drop: false }` [INFO] [stdout] 8d59d913527b5b21e545efd4b4fd7d01861601248656ebb3b3356a4d00004ba9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5b233e94c0b346d814ba15d708f7eabf5011c5c6661c4460f7cf002054075930 [INFO] running `Command { std: "docker" "start" "-a" "5b233e94c0b346d814ba15d708f7eabf5011c5c6661c4460f7cf002054075930", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling nom v6.1.2 [INFO] [stderr] Checking bitvec v0.19.5 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking timpani v0.1.0-pre (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `nom::multi::many0` [INFO] [stdout] --> src/parser.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use nom::multi::many0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::multi::many0` [INFO] [stdout] --> src/parser.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use nom::multi::many0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ParseInfo` is never constructed [INFO] [stdout] --> src/parser.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | struct ParseInfo<'a, T> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parseStatement` is never used [INFO] [stdout] --> src/parser.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn parseStatement(input: &str) -> PResult { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parseStatement` should have a snake case name [INFO] [stdout] --> src/parser.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn parseStatement(input: &str) -> PResult { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `parse_statement` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | let mut parse_result = parse_expression("id(456)"); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr2` [INFO] [stdout] --> src/parser.rs:385:45 [INFO] [stdout] | [INFO] [stdout] 385 | if let Expression::BinOp(bin_op, expr1, expr2) = parse_result1.unwrap().1 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_expr2` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ParseInfo` is never constructed [INFO] [stdout] --> src/parser.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | struct ParseInfo<'a, T> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parseStatement` is never used [INFO] [stdout] --> src/parser.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn parseStatement(input: &str) -> PResult { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parseStatement` should have a snake case name [INFO] [stdout] --> src/parser.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn parseStatement(input: &str) -> PResult { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `parse_statement` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.50s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v6.1.2 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "5b233e94c0b346d814ba15d708f7eabf5011c5c6661c4460f7cf002054075930", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b233e94c0b346d814ba15d708f7eabf5011c5c6661c4460f7cf002054075930", kill_on_drop: false }` [INFO] [stdout] 5b233e94c0b346d814ba15d708f7eabf5011c5c6661c4460f7cf002054075930 [INFO] checking llamachannel/timpani against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fllamachannel%2Ftimpani" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/llamachannel/timpani on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/llamachannel/timpani [INFO] finished tweaking git repo https://github.com/llamachannel/timpani [INFO] tweaked toml for git repo https://github.com/llamachannel/timpani written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/llamachannel/timpani already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6918adcab8027272a46a3d2a70a54b839abac96985914c71e913f203b5fea9b9 [INFO] running `Command { std: "docker" "start" "-a" "6918adcab8027272a46a3d2a70a54b839abac96985914c71e913f203b5fea9b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6918adcab8027272a46a3d2a70a54b839abac96985914c71e913f203b5fea9b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6918adcab8027272a46a3d2a70a54b839abac96985914c71e913f203b5fea9b9", kill_on_drop: false }` [INFO] [stdout] 6918adcab8027272a46a3d2a70a54b839abac96985914c71e913f203b5fea9b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e43cb189c540a29257d7afde42ed7ec1e689e42a464e66e4138f06293302c2a1 [INFO] running `Command { std: "docker" "start" "-a" "e43cb189c540a29257d7afde42ed7ec1e689e42a464e66e4138f06293302c2a1", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Compiling nom v6.1.2 [INFO] [stderr] Checking bitvec v0.19.5 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking timpani v0.1.0-pre (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `nom::multi::many0` [INFO] [stdout] --> src/parser.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use nom::multi::many0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::multi::many0` [INFO] [stdout] --> src/parser.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use nom::multi::many0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ParseInfo` is never constructed [INFO] [stdout] --> src/parser.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | struct ParseInfo<'a, T> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parseStatement` is never used [INFO] [stdout] --> src/parser.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn parseStatement(input: &str) -> PResult { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:76:6 [INFO] [stdout] | [INFO] [stdout] 48 | let parse_fn = tag("function"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let parse_return = tag("return"); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let paren_open = tag("("); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let paren_close = tag(")"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let brace_open = tag("{"); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let brace_close = tag("}"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | /* '{' */ _, _, /* 'return' */ _, _, return_expr, _, /* ';' */ _, _, /* '}' */ _)) = tuple( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let the_function = Function { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok((the_input, the_function)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:138:6 [INFO] [stdout] | [INFO] [stdout] 127 | let parse_result = parse_expression(&input[1..input.len()-1]); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let (rem, sub_expr) = match parse_result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Err(e) => return Err(e), [INFO] [stdout] 130 | Ok((rem, expr)) => (rem, Box::new(expr)), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | Ok((rem, sub_expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:153:6 [INFO] [stdout] | [INFO] [stdout] 142 | let paren_open = tag("("); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | let paren_close = tag(")"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | // TODO: implement calling with arbitrary number of arguments [INFO] [stdout] 145 | let (the_input, (function_name, _, /* '(' */ _, _, maybe_arg_expr, _, /* ')' */ _ )) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut arguments = vec![]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok((the_input, (function_name, arguments))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:191:6 [INFO] [stdout] | [INFO] [stdout] 158 | let expr_result = parse_expression(input_text); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | let (rem, expr1) = expr_result.unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | [INFO] [stdout] 165 | let re = regex::Regex::new(r"[+-*/]|[=><]=?").unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let bin_op_parser = nom::regexp::str::re_find::>(re); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let expr_result2 = parse_expression(rem); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let (rem, expr2) = expr_result2.unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | Ok((rem, (bin_op_type, Box::new(expr1), Box::new(expr2)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parseStatement` should have a snake case name [INFO] [stdout] --> src/parser.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn parseStatement(input: &str) -> PResult { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `parse_statement` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:235:41 [INFO] [stdout] | [INFO] [stdout] 235 | ident_result.map(|(rem, ident)| (rem, Expression::Ident(ident))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `timpani` (lib) due to 6 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | let mut parse_result = parse_expression("id(456)"); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr2` [INFO] [stdout] --> src/parser.rs:385:45 [INFO] [stdout] | [INFO] [stdout] 385 | if let Expression::BinOp(bin_op, expr1, expr2) = parse_result1.unwrap().1 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_expr2` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ParseInfo` is never constructed [INFO] [stdout] --> src/parser.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | struct ParseInfo<'a, T> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parseStatement` is never used [INFO] [stdout] --> src/parser.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn parseStatement(input: &str) -> PResult { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:76:6 [INFO] [stdout] | [INFO] [stdout] 48 | let parse_fn = tag("function"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let parse_return = tag("return"); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let paren_open = tag("("); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let paren_close = tag(")"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let brace_open = tag("{"); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let brace_close = tag("}"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | /* '{' */ _, _, /* 'return' */ _, _, return_expr, _, /* ';' */ _, _, /* '}' */ _)) = tuple( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let the_function = Function { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok((the_input, the_function)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:138:6 [INFO] [stdout] | [INFO] [stdout] 127 | let parse_result = parse_expression(&input[1..input.len()-1]); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let (rem, sub_expr) = match parse_result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Err(e) => return Err(e), [INFO] [stdout] 130 | Ok((rem, expr)) => (rem, Box::new(expr)), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | Ok((rem, sub_expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:153:6 [INFO] [stdout] | [INFO] [stdout] 142 | let paren_open = tag("("); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | let paren_close = tag(")"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | // TODO: implement calling with arbitrary number of arguments [INFO] [stdout] 145 | let (the_input, (function_name, _, /* '(' */ _, _, maybe_arg_expr, _, /* ')' */ _ )) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut arguments = vec![]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok((the_input, (function_name, arguments))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:191:6 [INFO] [stdout] | [INFO] [stdout] 158 | let expr_result = parse_expression(input_text); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | let (rem, expr1) = expr_result.unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | [INFO] [stdout] 165 | let re = regex::Regex::new(r"[+-*/]|[=><]=?").unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let bin_op_parser = nom::regexp::str::re_find::>(re); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let expr_result2 = parse_expression(rem); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let (rem, expr2) = expr_result2.unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | Ok((rem, (bin_op_type, Box::new(expr1), Box::new(expr2)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parseStatement` should have a snake case name [INFO] [stdout] --> src/parser.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn parseStatement(input: &str) -> PResult { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `parse_statement` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:235:41 [INFO] [stdout] | [INFO] [stdout] 235 | ident_result.map(|(rem, ident)| (rem, Expression::Ident(ident))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `timpani` (lib test) due to 6 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e43cb189c540a29257d7afde42ed7ec1e689e42a464e66e4138f06293302c2a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e43cb189c540a29257d7afde42ed7ec1e689e42a464e66e4138f06293302c2a1", kill_on_drop: false }` [INFO] [stdout] e43cb189c540a29257d7afde42ed7ec1e689e42a464e66e4138f06293302c2a1