[INFO] cloning repository https://github.com/leonidas1712/nova [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/leonidas1712/nova" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fleonidas1712%2Fnova", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fleonidas1712%2Fnova'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 476d8b989093fda629b3fff9e72b145889b753e8 [INFO] checking leonidas1712/nova against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fleonidas1712%2Fnova" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/leonidas1712/nova on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/leonidas1712/nova [INFO] finished tweaking git repo https://github.com/leonidas1712/nova [INFO] tweaked toml for git repo https://github.com/leonidas1712/nova written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/leonidas1712/nova already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strum_macros v0.25.0 [INFO] [stderr] Downloaded uuid-macro-internal v1.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 61fbdf26d826da817306845ab909a0d307d671ac289a5cb7b4de11590e896cb3 [INFO] running `Command { std: "docker" "start" "-a" "61fbdf26d826da817306845ab909a0d307d671ac289a5cb7b4de11590e896cb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "61fbdf26d826da817306845ab909a0d307d671ac289a5cb7b4de11590e896cb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61fbdf26d826da817306845ab909a0d307d671ac289a5cb7b4de11590e896cb3", kill_on_drop: false }` [INFO] [stdout] 61fbdf26d826da817306845ab909a0d307d671ac289a5cb7b4de11590e896cb3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 58b863170990848b09ad1c944010c897e59e45bbc74c4fb3be5a21bd68398ca0 [INFO] running `Command { std: "docker" "start" "-a" "58b863170990848b09ad1c944010c897e59e45bbc74c4fb3be5a21bd68398ca0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Compiling rustversion v1.0.12 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking home v0.5.5 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking bitflags v2.3.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Compiling syn v2.0.22 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking nix v0.26.2 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Compiling uuid-macro-internal v1.4.0 [INFO] [stderr] Compiling strum_macros v0.25.0 [INFO] [stderr] Checking uuid v1.4.0 [INFO] [stderr] Checking fd-lock v3.0.12 [INFO] [stderr] Checking rustyline v12.0.0 [INFO] [stderr] Checking nova v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/evaluator/params.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | let mut fin_get = fin.apply(&args[0..2]); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser/parse_special.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | let mut l = lex!(valid); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.84s [INFO] running `Command { std: "docker" "inspect" "58b863170990848b09ad1c944010c897e59e45bbc74c4fb3be5a21bd68398ca0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58b863170990848b09ad1c944010c897e59e45bbc74c4fb3be5a21bd68398ca0", kill_on_drop: false }` [INFO] [stdout] 58b863170990848b09ad1c944010c897e59e45bbc74c4fb3be5a21bd68398ca0 [INFO] checking leonidas1712/nova against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fleonidas1712%2Fnova" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/leonidas1712/nova on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/leonidas1712/nova [INFO] finished tweaking git repo https://github.com/leonidas1712/nova [INFO] tweaked toml for git repo https://github.com/leonidas1712/nova written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/leonidas1712/nova already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9fc720e317527fcff5a959d015ea8f9fd10534161b03b1f2b9f89b4a0ae263a7 [INFO] running `Command { std: "docker" "start" "-a" "9fc720e317527fcff5a959d015ea8f9fd10534161b03b1f2b9f89b4a0ae263a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9fc720e317527fcff5a959d015ea8f9fd10534161b03b1f2b9f89b4a0ae263a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9fc720e317527fcff5a959d015ea8f9fd10534161b03b1f2b9f89b4a0ae263a7", kill_on_drop: false }` [INFO] [stdout] 9fc720e317527fcff5a959d015ea8f9fd10534161b03b1f2b9f89b4a0ae263a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba0fb9049fc6f18b38fec487ea1f453d60e7c53d29c233ded95f60c9edf34b5e [INFO] running `Command { std: "docker" "start" "-a" "ba0fb9049fc6f18b38fec487ea1f453d60e7c53d29c233ded95f60c9edf34b5e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling rustversion v1.0.12 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Checking bitflags v2.3.2 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking home v0.5.5 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Compiling syn v2.0.22 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking nix v0.26.2 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Compiling uuid-macro-internal v1.4.0 [INFO] [stderr] Compiling strum_macros v0.25.0 [INFO] [stderr] Checking uuid v1.4.0 [INFO] [stderr] Checking fd-lock v3.0.12 [INFO] [stderr] Checking rustyline v12.0.0 [INFO] [stderr] Checking nova v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/evaluator/params.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | let mut fin_get = fin.apply(&args[0..2]); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser/parse_special.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | let mut l = lex!(valid); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/builtins_tco.rs:49:49 [INFO] [stdout] | [INFO] [stdout] 49 | Arg::expect_all_eval(args).and_then(|f| f.into_iter().map(|x| x.expect_num()).collect()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/builtins_tco.rs:207:8 [INFO] [stdout] | [INFO] [stdout] 201 | let eval_args = ev!(args); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok(EvaluatedExpr(Bool(left.equals(right)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/builtins_tco.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | Ok(EvaluatedExpr(Unit)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let values = ev!(args); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | values.iter().for_each(|x| println!("{}", x.to_string())); [INFO] [stdout] 235 | unit!() [INFO] [stdout] | ------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `unit` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/context_tco.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 27 | let new_ctx = ctx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | EvalContext { [INFO] [stdout] 29 | ctx: Rc::new(RefCell::new(new_ctx)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/context_tco.rs:66:18 [INFO] [stdout] | [INFO] [stdout] 64 | let existing = self.read().clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | EvalContext { [INFO] [stdout] 66 | ctx: Rc::new(RefCell::new(existing)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/data_tco.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(context: EvalContext, value: DataValue) -> LetReturn { [INFO] [stdout] | -------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | LetReturn { [INFO] [stdout] 22 | context: Box::new(context), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/data_tco.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(context: EvalContext, value: DataValue) -> LetReturn { [INFO] [stdout] | -------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | value: Rc::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/data_tco.rs:162:66 [INFO] [stdout] | [INFO] [stdout] 162 | let k: Result> = args.into_iter().map(|a| a.clone().expect_eval()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/data_tco.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 169 | .map(|a| a.clone().expect_uneval()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/eval_helpers_tco.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 69 | let mut args: VecDeque = VecDeque::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | args.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/eval_helpers_tco.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 132 | let func = UserFunction::new(ctx, &fn_def); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let rc: Rc = Rc::new(func); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(SetFn(rc)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/evaluator_tco.rs:300:11 [INFO] [stdout] | [INFO] [stdout] 230 | fn evaluate_tco(expression: StackExpression, outer_call: bool) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | // try to match terminals [INFO] [stdout] 232 | let mut call_stack: VecDeque = VecDeque::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let mut fn_stack: VecDeque = VecDeque::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let mut results_queue: VecDeque = VecDeque::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | match results_queue.into_iter().last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/function_tco.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 68 | let mut stored_ctx = context.copy(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | params: Params::new_finite(params), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nova` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/builtins_tco.rs:49:49 [INFO] [stdout] | [INFO] [stdout] 49 | Arg::expect_all_eval(args).and_then(|f| f.into_iter().map(|x| x.expect_num()).collect()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/builtins_tco.rs:207:8 [INFO] [stdout] | [INFO] [stdout] 201 | let eval_args = ev!(args); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok(EvaluatedExpr(Bool(left.equals(right)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/builtins_tco.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | Ok(EvaluatedExpr(Unit)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let values = ev!(args); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | values.iter().for_each(|x| println!("{}", x.to_string())); [INFO] [stdout] 235 | unit!() [INFO] [stdout] | ------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `unit` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/context_tco.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 27 | let new_ctx = ctx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | EvalContext { [INFO] [stdout] 29 | ctx: Rc::new(RefCell::new(new_ctx)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/context_tco.rs:66:18 [INFO] [stdout] | [INFO] [stdout] 64 | let existing = self.read().clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | EvalContext { [INFO] [stdout] 66 | ctx: Rc::new(RefCell::new(existing)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/data_tco.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(context: EvalContext, value: DataValue) -> LetReturn { [INFO] [stdout] | -------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | LetReturn { [INFO] [stdout] 22 | context: Box::new(context), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/data_tco.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(context: EvalContext, value: DataValue) -> LetReturn { [INFO] [stdout] | -------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | value: Rc::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/data_tco.rs:162:66 [INFO] [stdout] | [INFO] [stdout] 162 | let k: Result> = args.into_iter().map(|a| a.clone().expect_eval()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/data_tco.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 169 | .map(|a| a.clone().expect_uneval()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/eval_helpers_tco.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 69 | let mut args: VecDeque = VecDeque::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | args.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/eval_helpers_tco.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 132 | let func = UserFunction::new(ctx, &fn_def); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let rc: Rc = Rc::new(func); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(SetFn(rc)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/evaluator_tco.rs:300:11 [INFO] [stdout] | [INFO] [stdout] 230 | fn evaluate_tco(expression: StackExpression, outer_call: bool) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | // try to match terminals [INFO] [stdout] 232 | let mut call_stack: VecDeque = VecDeque::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let mut fn_stack: VecDeque = VecDeque::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let mut results_queue: VecDeque = VecDeque::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | match results_queue.into_iter().last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/function_tco.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 68 | let mut stored_ctx = context.copy(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | params: Params::new_finite(params), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nova` (lib test) due to 14 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ba0fb9049fc6f18b38fec487ea1f453d60e7c53d29c233ded95f60c9edf34b5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba0fb9049fc6f18b38fec487ea1f453d60e7c53d29c233ded95f60c9edf34b5e", kill_on_drop: false }` [INFO] [stdout] ba0fb9049fc6f18b38fec487ea1f453d60e7c53d29c233ded95f60c9edf34b5e