[INFO] cloning repository https://github.com/lcq2/yasnese [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lcq2/yasnese" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flcq2%2Fyasnese", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flcq2%2Fyasnese'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 23dd3d95576fba5122a4d9d2df12d1d2c89560e8 [INFO] checking lcq2/yasnese against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flcq2%2Fyasnese" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/lcq2/yasnese on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/lcq2/yasnese [INFO] finished tweaking git repo https://github.com/lcq2/yasnese [INFO] tweaked toml for git repo https://github.com/lcq2/yasnese written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/lcq2/yasnese already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef90cf17ab658e9815630f7c2e3e6c484b790ccd37b574eff4baecae84dd2e34 [INFO] running `Command { std: "docker" "start" "-a" "ef90cf17ab658e9815630f7c2e3e6c484b790ccd37b574eff4baecae84dd2e34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef90cf17ab658e9815630f7c2e3e6c484b790ccd37b574eff4baecae84dd2e34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef90cf17ab658e9815630f7c2e3e6c484b790ccd37b574eff4baecae84dd2e34", kill_on_drop: false }` [INFO] [stdout] ef90cf17ab658e9815630f7c2e3e6c484b790ccd37b574eff4baecae84dd2e34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 248bd9b6b31bd4fe7c32c645b8319f6f3b076fa52138551ef9e69c62178d556e [INFO] running `Command { std: "docker" "start" "-a" "248bd9b6b31bd4fe7c32c645b8319f6f3b076fa52138551ef9e69c62178d556e", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling cfg-if v0.1.9 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling sdl2 v0.32.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling sdl2-sys v0.32.6 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking yasnese v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/nes/apu.rs:170:40 [INFO] [stdout] | [INFO] [stdout] 170 | self.freq_timer += (self.freq_timer >> self.sweep_shift as u16); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 170 - self.freq_timer += (self.freq_timer >> self.sweep_shift as u16); [INFO] [stdout] 170 + self.freq_timer += self.freq_timer >> self.sweep_shift as u16; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `WindowCanvas` [INFO] [stdout] --> src/nes/mod.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | use sdl2::render::{WindowCanvas, Texture}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::surface` [INFO] [stdout] --> src/nes/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use sdl2::surface; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Duration`, `SystemTime`, and `UNIX_EPOCH` [INFO] [stdout] --> src/nes/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | use std::time::{SystemTime, Duration, UNIX_EPOCH, Instant}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::pixels::PixelFormatEnum` [INFO] [stdout] --> src/nes/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use sdl2::pixels::PixelFormatEnum; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AudioFormatNum` [INFO] [stdout] --> src/nes/mod.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 16 | use sdl2::audio::{AudioQueue, AudioFormatNum}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/nes/apu.rs:170:40 [INFO] [stdout] | [INFO] [stdout] 170 | self.freq_timer += (self.freq_timer >> self.sweep_shift as u16); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 170 - self.freq_timer += (self.freq_timer >> self.sweep_shift as u16); [INFO] [stdout] 170 + self.freq_timer += self.freq_timer >> self.sweep_shift as u16; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `WindowCanvas` [INFO] [stdout] --> src/nes/mod.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | use sdl2::render::{WindowCanvas, Texture}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::surface` [INFO] [stdout] --> src/nes/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use sdl2::surface; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Duration`, `SystemTime`, and `UNIX_EPOCH` [INFO] [stdout] --> src/nes/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | use std::time::{SystemTime, Duration, UNIX_EPOCH, Instant}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::pixels::PixelFormatEnum` [INFO] [stdout] --> src/nes/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use sdl2::pixels::PixelFormatEnum; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AudioFormatNum` [INFO] [stdout] --> src/nes/mod.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 16 | use sdl2::audio::{AudioQueue, AudioFormatNum}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/nes/cpu.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 688 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/nes/cpu.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 307 | 0x69 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 308 | 0x65 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 309 | 0x75 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 310 | 0x6D => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 688 | _ => {} [INFO] [stdout] | ^ ...and 218 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl8` [INFO] [stdout] --> src/nes/rom.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let fl8 = reader.read_u8()?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fl8` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl9` [INFO] [stdout] --> src/nes/rom.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let fl9 = reader.read_u8()?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fl9` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl10` [INFO] [stdout] --> src/nes/rom.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | let fl10 = reader.read_u8()?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_fl10` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/nes/cpu.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 688 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/nes/cpu.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 307 | 0x69 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 308 | 0x65 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 309 | 0x75 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 310 | 0x6D => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 688 | _ => {} [INFO] [stdout] | ^ ...and 218 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/nes/ppu.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 287 | let mut addr = address & 0x3FFF; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl8` [INFO] [stdout] --> src/nes/rom.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let fl8 = reader.read_u8()?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fl8` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl9` [INFO] [stdout] --> src/nes/rom.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let fl9 = reader.read_u8()?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fl9` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl10` [INFO] [stdout] --> src/nes/rom.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | let fl10 = reader.read_u8()?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_fl10` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/nes/ppu.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 287 | let mut addr = address & 0x3FFF; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | let i = 0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `frame_count` is assigned to, but never used [INFO] [stdout] --> src/main.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | let mut frame_count = 0; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_frame_count` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/main.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | let mut t = SystemTime::now(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | let mut t = SystemTime::now(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `CPU_NMI_VECTOR` is never used [INFO] [stdout] --> src/nes/cpu.rs:32:7 [INFO] [stdout] | [INFO] [stdout] 32 | const CPU_NMI_VECTOR: u16 = 0xfffa; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:146:28 [INFO] [stdout] | [INFO] [stdout] 146 | struct AbsoluteYAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:162:28 [INFO] [stdout] | [INFO] [stdout] 162 | struct IndirectXAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:170:28 [INFO] [stdout] | [INFO] [stdout] 170 | struct IndirectYAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `load_into_ram` and `reset` are never used [INFO] [stdout] --> src/nes/bus.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl Bus { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 85 | pub fn load_into_ram(&mut self, data: &[u8], offset: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NES_ROM_HAS_TRAINER` is never used [INFO] [stdout] --> src/nes/rom.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const NES_ROM_HAS_TRAINER: u8 = 1 << 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NES_ROM_IGNORE_MIRRORING` is never used [INFO] [stdout] --> src/nes/rom.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const NES_ROM_IGNORE_MIRRORING: u8 = 1 << 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `has_ram` is never read [INFO] [stdout] --> src/nes/rom.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct NesRom { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | pub has_ram: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `sp0_hit` and `frame` are never read [INFO] [stdout] --> src/nes/ppu.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Ppu { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | sp0_hit: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | frame: u128 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_GRAYSCALE` is never used [INFO] [stdout] --> src/nes/ppu.rs:67:7 [INFO] [stdout] | [INFO] [stdout] 67 | const PPU_MASK_GRAYSCALE: u8 = 1 << 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_RED` is never used [INFO] [stdout] --> src/nes/ppu.rs:72:7 [INFO] [stdout] | [INFO] [stdout] 72 | const PPU_MASK_EMPH_RED: u8 = 1 << 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_GREEN` is never used [INFO] [stdout] --> src/nes/ppu.rs:73:7 [INFO] [stdout] | [INFO] [stdout] 73 | const PPU_MASK_EMPH_GREEN: u8 = 1 << 6; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_BLUE` is never used [INFO] [stdout] --> src/nes/ppu.rs:74:7 [INFO] [stdout] | [INFO] [stdout] 74 | const PPU_MASK_EMPH_BLUE: u8 = 1 << 7; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OAM_SPRITE_PALETTE` is never used [INFO] [stdout] --> src/nes/ppu.rs:76:7 [INFO] [stdout] | [INFO] [stdout] 76 | const OAM_SPRITE_PALETTE: u8 = 0b11; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OAM_SPRITE_PRIORITY` is never used [INFO] [stdout] --> src/nes/ppu.rs:77:7 [INFO] [stdout] | [INFO] [stdout] 77 | const OAM_SPRITE_PRIORITY: u8 = 1 << 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_VISIBLE_SCANLINES` is never used [INFO] [stdout] --> src/nes/ppu.rs:82:7 [INFO] [stdout] | [INFO] [stdout] 82 | const PPU_VISIBLE_SCANLINES: u32 = 240; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_VBLANK_SCANLINE` is never used [INFO] [stdout] --> src/nes/ppu.rs:84:7 [INFO] [stdout] | [INFO] [stdout] 84 | const PPU_VBLANK_SCANLINE: u32 = 241; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset` and `extract_y` are never used [INFO] [stdout] --> src/nes/ppu.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 148 | impl Ppu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 194 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 708 | fn extract_y(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS` is never used [INFO] [stdout] --> src/nes/apu.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const APU_STATUS: u16 = 0x4015; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_FRAME_COUNTER` is never used [INFO] [stdout] --> src/nes/apu.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | const APU_FRAME_COUNTER: u16 = 0x4017; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_PULSE1` is never used [INFO] [stdout] --> src/nes/apu.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | const APU_STATUS_PULSE1: u8 = 1 << 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_PULSE2` is never used [INFO] [stdout] --> src/nes/apu.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const APU_STATUS_PULSE2: u8 = 1 << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_TRIANGLE` is never used [INFO] [stdout] --> src/nes/apu.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const APU_STATUS_TRIANGLE: u8 = 1 << 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_NOISE` is never used [INFO] [stdout] --> src/nes/apu.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const APU_STATUS_NOISE: u8 = 1 << 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_DMC` is never used [INFO] [stdout] --> src/nes/apu.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const APU_STATUS_DMC: u8 = 1 << 4; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY_TABLE_MASK` is never used [INFO] [stdout] --> src/nes/apu.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const APU_PULSE_DUTY_TABLE_MASK: u8 = 0b1100_0000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY_TABLE_SHIFT` is never used [INFO] [stdout] --> src/nes/apu.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const APU_PULSE_DUTY_TABLE_SHIFT: u8 = 6; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY` is never used [INFO] [stdout] --> src/nes/apu.rs:24:7 [INFO] [stdout] | [INFO] [stdout] 24 | const APU_PULSE_DUTY: [[u8; 8]; 4] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset`, `step`, and `out` are never used [INFO] [stdout] --> src/nes/apu.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 56 | impl Pulse { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 81 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 123 | pub fn step(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 195 | pub fn out(&mut self) -> u8 { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Triangle` is never constructed [INFO] [stdout] --> src/nes/apu.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 203 | struct Triangle { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 207 | impl Triangle { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 208 | pub fn new() -> Triangle { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Noise` is never constructed [INFO] [stdout] --> src/nes/apu.rs:215:8 [INFO] [stdout] | [INFO] [stdout] 215 | struct Noise { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 219 | impl Noise { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 220 | pub fn new() -> Noise { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DMC` is never constructed [INFO] [stdout] --> src/nes/apu.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 227 | struct DMC { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 231 | impl DMC { [INFO] [stdout] | -------- associated function in this implementation [INFO] [stdout] 232 | pub fn new() -> DMC { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cycle`, `apu_cycle`, `accum`, `out_buf`, `out_index`, and `audio_ready` are never read [INFO] [stdout] --> src/nes/apu.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 239 | pub struct Apu { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 248 | cycle: u64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 249 | apu_cycle: u64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 250 | accum: f64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 251 | out_buf: [u8; 735], [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 252 | out_index: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 253 | audio_ready: bool [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset`, `mode0`, `mode1`, `sequencer`, `step`, and `run` are never used [INFO] [stdout] --> src/nes/apu.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 256 | impl Apu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 276 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 335 | fn mode0(&mut self) -> u16 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 360 | fn mode1(&mut self) -> u16 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 378 | fn sequencer(&mut self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 395 | fn step(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 428 | pub fn run(&mut self, cycles: u64) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | let i = 0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `frame_count` is assigned to, but never used [INFO] [stdout] --> src/main.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | let mut frame_count = 0; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_frame_count` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/main.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | let mut t = SystemTime::now(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | let mut t = SystemTime::now(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | canvas.set_logical_size(256, 240); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 43 | let _ = canvas.set_logical_size(256, 240); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/nes/mod.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / texture.with_lock(None, |buffer: &mut [u8], _pitch: usize| { [INFO] [stdout] 66 | | self.cpu.bus.ppu.copy_frame(buffer); [INFO] [stdout] 67 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 65 | let _ = texture.with_lock(None, |buffer: &mut [u8], _pitch: usize| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `CPU_NMI_VECTOR` is never used [INFO] [stdout] --> src/nes/cpu.rs:32:7 [INFO] [stdout] | [INFO] [stdout] 32 | const CPU_NMI_VECTOR: u16 = 0xfffa; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:146:28 [INFO] [stdout] | [INFO] [stdout] 146 | struct AbsoluteYAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:162:28 [INFO] [stdout] | [INFO] [stdout] 162 | struct IndirectXAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:170:28 [INFO] [stdout] | [INFO] [stdout] 170 | struct IndirectYAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `load_into_ram` and `reset` are never used [INFO] [stdout] --> src/nes/bus.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl Bus { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 85 | pub fn load_into_ram(&mut self, data: &[u8], offset: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NES_ROM_HAS_TRAINER` is never used [INFO] [stdout] --> src/nes/rom.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const NES_ROM_HAS_TRAINER: u8 = 1 << 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NES_ROM_IGNORE_MIRRORING` is never used [INFO] [stdout] --> src/nes/rom.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const NES_ROM_IGNORE_MIRRORING: u8 = 1 << 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `has_ram` is never read [INFO] [stdout] --> src/nes/rom.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct NesRom { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | pub has_ram: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `sp0_hit` and `frame` are never read [INFO] [stdout] --> src/nes/ppu.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Ppu { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | sp0_hit: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | frame: u128 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_GRAYSCALE` is never used [INFO] [stdout] --> src/nes/ppu.rs:67:7 [INFO] [stdout] | [INFO] [stdout] 67 | const PPU_MASK_GRAYSCALE: u8 = 1 << 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_RED` is never used [INFO] [stdout] --> src/nes/ppu.rs:72:7 [INFO] [stdout] | [INFO] [stdout] 72 | const PPU_MASK_EMPH_RED: u8 = 1 << 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_GREEN` is never used [INFO] [stdout] --> src/nes/ppu.rs:73:7 [INFO] [stdout] | [INFO] [stdout] 73 | const PPU_MASK_EMPH_GREEN: u8 = 1 << 6; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_BLUE` is never used [INFO] [stdout] --> src/nes/ppu.rs:74:7 [INFO] [stdout] | [INFO] [stdout] 74 | const PPU_MASK_EMPH_BLUE: u8 = 1 << 7; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OAM_SPRITE_PALETTE` is never used [INFO] [stdout] --> src/nes/ppu.rs:76:7 [INFO] [stdout] | [INFO] [stdout] 76 | const OAM_SPRITE_PALETTE: u8 = 0b11; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OAM_SPRITE_PRIORITY` is never used [INFO] [stdout] --> src/nes/ppu.rs:77:7 [INFO] [stdout] | [INFO] [stdout] 77 | const OAM_SPRITE_PRIORITY: u8 = 1 << 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_VISIBLE_SCANLINES` is never used [INFO] [stdout] --> src/nes/ppu.rs:82:7 [INFO] [stdout] | [INFO] [stdout] 82 | const PPU_VISIBLE_SCANLINES: u32 = 240; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_VBLANK_SCANLINE` is never used [INFO] [stdout] --> src/nes/ppu.rs:84:7 [INFO] [stdout] | [INFO] [stdout] 84 | const PPU_VBLANK_SCANLINE: u32 = 241; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset` and `extract_y` are never used [INFO] [stdout] --> src/nes/ppu.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 148 | impl Ppu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 194 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 708 | fn extract_y(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS` is never used [INFO] [stdout] --> src/nes/apu.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const APU_STATUS: u16 = 0x4015; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_FRAME_COUNTER` is never used [INFO] [stdout] --> src/nes/apu.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | const APU_FRAME_COUNTER: u16 = 0x4017; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_PULSE1` is never used [INFO] [stdout] --> src/nes/apu.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | const APU_STATUS_PULSE1: u8 = 1 << 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_PULSE2` is never used [INFO] [stdout] --> src/nes/apu.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const APU_STATUS_PULSE2: u8 = 1 << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_TRIANGLE` is never used [INFO] [stdout] --> src/nes/apu.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const APU_STATUS_TRIANGLE: u8 = 1 << 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_NOISE` is never used [INFO] [stdout] --> src/nes/apu.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const APU_STATUS_NOISE: u8 = 1 << 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_DMC` is never used [INFO] [stdout] --> src/nes/apu.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const APU_STATUS_DMC: u8 = 1 << 4; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY_TABLE_MASK` is never used [INFO] [stdout] --> src/nes/apu.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const APU_PULSE_DUTY_TABLE_MASK: u8 = 0b1100_0000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY_TABLE_SHIFT` is never used [INFO] [stdout] --> src/nes/apu.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const APU_PULSE_DUTY_TABLE_SHIFT: u8 = 6; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY` is never used [INFO] [stdout] --> src/nes/apu.rs:24:7 [INFO] [stdout] | [INFO] [stdout] 24 | const APU_PULSE_DUTY: [[u8; 8]; 4] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset`, `step`, and `out` are never used [INFO] [stdout] --> src/nes/apu.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 56 | impl Pulse { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 81 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 123 | pub fn step(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 195 | pub fn out(&mut self) -> u8 { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Triangle` is never constructed [INFO] [stdout] --> src/nes/apu.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 203 | struct Triangle { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 207 | impl Triangle { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 208 | pub fn new() -> Triangle { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Noise` is never constructed [INFO] [stdout] --> src/nes/apu.rs:215:8 [INFO] [stdout] | [INFO] [stdout] 215 | struct Noise { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 219 | impl Noise { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 220 | pub fn new() -> Noise { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DMC` is never constructed [INFO] [stdout] --> src/nes/apu.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 227 | struct DMC { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 231 | impl DMC { [INFO] [stdout] | -------- associated function in this implementation [INFO] [stdout] 232 | pub fn new() -> DMC { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cycle`, `apu_cycle`, `accum`, `out_buf`, `out_index`, and `audio_ready` are never read [INFO] [stdout] --> src/nes/apu.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 239 | pub struct Apu { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 248 | cycle: u64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 249 | apu_cycle: u64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 250 | accum: f64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 251 | out_buf: [u8; 735], [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 252 | out_index: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 253 | audio_ready: bool [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset`, `mode0`, `mode1`, `sequencer`, `step`, and `run` are never used [INFO] [stdout] --> src/nes/apu.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 256 | impl Apu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 276 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 335 | fn mode0(&mut self) -> u16 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 360 | fn mode1(&mut self) -> u16 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 378 | fn sequencer(&mut self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 395 | fn step(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 428 | pub fn run(&mut self, cycles: u64) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | canvas.set_logical_size(256, 240); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 43 | let _ = canvas.set_logical_size(256, 240); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 55 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/nes/mod.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / texture.with_lock(None, |buffer: &mut [u8], _pitch: usize| { [INFO] [stdout] 66 | | self.cpu.bus.ppu.copy_frame(buffer); [INFO] [stdout] 67 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 65 | let _ = texture.with_lock(None, |buffer: &mut [u8], _pitch: usize| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 55 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.49s [INFO] running `Command { std: "docker" "inspect" "248bd9b6b31bd4fe7c32c645b8319f6f3b076fa52138551ef9e69c62178d556e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "248bd9b6b31bd4fe7c32c645b8319f6f3b076fa52138551ef9e69c62178d556e", kill_on_drop: false }` [INFO] [stdout] 248bd9b6b31bd4fe7c32c645b8319f6f3b076fa52138551ef9e69c62178d556e [INFO] checking lcq2/yasnese against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flcq2%2Fyasnese" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/lcq2/yasnese on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/lcq2/yasnese [INFO] finished tweaking git repo https://github.com/lcq2/yasnese [INFO] tweaked toml for git repo https://github.com/lcq2/yasnese written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/lcq2/yasnese already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc6316b10dfe1b38477d845b6058596f4786453ba5adcaf4cb5e70f3e03d0075 [INFO] running `Command { std: "docker" "start" "-a" "cc6316b10dfe1b38477d845b6058596f4786453ba5adcaf4cb5e70f3e03d0075", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc6316b10dfe1b38477d845b6058596f4786453ba5adcaf4cb5e70f3e03d0075", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc6316b10dfe1b38477d845b6058596f4786453ba5adcaf4cb5e70f3e03d0075", kill_on_drop: false }` [INFO] [stdout] cc6316b10dfe1b38477d845b6058596f4786453ba5adcaf4cb5e70f3e03d0075 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b95b0b3bdc8c0d3bb0a179e5ad572559c34fe014c2983853246f73d4914e418d [INFO] running `Command { std: "docker" "start" "-a" "b95b0b3bdc8c0d3bb0a179e5ad572559c34fe014c2983853246f73d4914e418d", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling cfg-if v0.1.9 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling sdl2 v0.32.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling sdl2-sys v0.32.6 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking yasnese v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/nes/apu.rs:170:40 [INFO] [stdout] | [INFO] [stdout] 170 | self.freq_timer += (self.freq_timer >> self.sweep_shift as u16); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 170 - self.freq_timer += (self.freq_timer >> self.sweep_shift as u16); [INFO] [stdout] 170 + self.freq_timer += self.freq_timer >> self.sweep_shift as u16; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/nes/apu.rs:170:40 [INFO] [stdout] | [INFO] [stdout] 170 | self.freq_timer += (self.freq_timer >> self.sweep_shift as u16); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 170 - self.freq_timer += (self.freq_timer >> self.sweep_shift as u16); [INFO] [stdout] 170 + self.freq_timer += self.freq_timer >> self.sweep_shift as u16; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `WindowCanvas` [INFO] [stdout] --> src/nes/mod.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | use sdl2::render::{WindowCanvas, Texture}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::surface` [INFO] [stdout] --> src/nes/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use sdl2::surface; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Duration`, `SystemTime`, and `UNIX_EPOCH` [INFO] [stdout] --> src/nes/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | use std::time::{SystemTime, Duration, UNIX_EPOCH, Instant}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::pixels::PixelFormatEnum` [INFO] [stdout] --> src/nes/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use sdl2::pixels::PixelFormatEnum; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AudioFormatNum` [INFO] [stdout] --> src/nes/mod.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 16 | use sdl2::audio::{AudioQueue, AudioFormatNum}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `WindowCanvas` [INFO] [stdout] --> src/nes/mod.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | use sdl2::render::{WindowCanvas, Texture}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::surface` [INFO] [stdout] --> src/nes/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use sdl2::surface; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Duration`, `SystemTime`, and `UNIX_EPOCH` [INFO] [stdout] --> src/nes/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | use std::time::{SystemTime, Duration, UNIX_EPOCH, Instant}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::pixels::PixelFormatEnum` [INFO] [stdout] --> src/nes/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use sdl2::pixels::PixelFormatEnum; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AudioFormatNum` [INFO] [stdout] --> src/nes/mod.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 16 | use sdl2::audio::{AudioQueue, AudioFormatNum}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/nes/cpu.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 688 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/nes/cpu.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 307 | 0x69 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 308 | 0x65 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 309 | 0x75 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 310 | 0x6D => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 688 | _ => {} [INFO] [stdout] | ^ ...and 218 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/nes/cpu.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 688 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/nes/cpu.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 307 | 0x69 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 308 | 0x65 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 309 | 0x75 => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] 310 | 0x6D => self.adc::(), [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 688 | _ => {} [INFO] [stdout] | ^ ...and 218 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl8` [INFO] [stdout] --> src/nes/rom.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let fl8 = reader.read_u8()?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fl8` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl9` [INFO] [stdout] --> src/nes/rom.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let fl9 = reader.read_u8()?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fl9` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl10` [INFO] [stdout] --> src/nes/rom.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | let fl10 = reader.read_u8()?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_fl10` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/nes/ppu.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 287 | let mut addr = address & 0x3FFF; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl8` [INFO] [stdout] --> src/nes/rom.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let fl8 = reader.read_u8()?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fl8` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl9` [INFO] [stdout] --> src/nes/rom.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let fl9 = reader.read_u8()?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fl9` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fl10` [INFO] [stdout] --> src/nes/rom.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | let fl10 = reader.read_u8()?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_fl10` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/nes/ppu.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 287 | let mut addr = address & 0x3FFF; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | let i = 0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `frame_count` is assigned to, but never used [INFO] [stdout] --> src/main.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | let mut frame_count = 0; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_frame_count` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/main.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | let mut t = SystemTime::now(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | let mut t = SystemTime::now(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `CPU_NMI_VECTOR` is never used [INFO] [stdout] --> src/nes/cpu.rs:32:7 [INFO] [stdout] | [INFO] [stdout] 32 | const CPU_NMI_VECTOR: u16 = 0xfffa; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:146:28 [INFO] [stdout] | [INFO] [stdout] 146 | struct AbsoluteYAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:162:28 [INFO] [stdout] | [INFO] [stdout] 162 | struct IndirectXAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:170:28 [INFO] [stdout] | [INFO] [stdout] 170 | struct IndirectYAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `load_into_ram` and `reset` are never used [INFO] [stdout] --> src/nes/bus.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl Bus { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 85 | pub fn load_into_ram(&mut self, data: &[u8], offset: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NES_ROM_HAS_TRAINER` is never used [INFO] [stdout] --> src/nes/rom.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const NES_ROM_HAS_TRAINER: u8 = 1 << 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NES_ROM_IGNORE_MIRRORING` is never used [INFO] [stdout] --> src/nes/rom.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const NES_ROM_IGNORE_MIRRORING: u8 = 1 << 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `has_ram` is never read [INFO] [stdout] --> src/nes/rom.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct NesRom { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | pub has_ram: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `sp0_hit` and `frame` are never read [INFO] [stdout] --> src/nes/ppu.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Ppu { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | sp0_hit: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | frame: u128 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_GRAYSCALE` is never used [INFO] [stdout] --> src/nes/ppu.rs:67:7 [INFO] [stdout] | [INFO] [stdout] 67 | const PPU_MASK_GRAYSCALE: u8 = 1 << 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_RED` is never used [INFO] [stdout] --> src/nes/ppu.rs:72:7 [INFO] [stdout] | [INFO] [stdout] 72 | const PPU_MASK_EMPH_RED: u8 = 1 << 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_GREEN` is never used [INFO] [stdout] --> src/nes/ppu.rs:73:7 [INFO] [stdout] | [INFO] [stdout] 73 | const PPU_MASK_EMPH_GREEN: u8 = 1 << 6; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_BLUE` is never used [INFO] [stdout] --> src/nes/ppu.rs:74:7 [INFO] [stdout] | [INFO] [stdout] 74 | const PPU_MASK_EMPH_BLUE: u8 = 1 << 7; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OAM_SPRITE_PALETTE` is never used [INFO] [stdout] --> src/nes/ppu.rs:76:7 [INFO] [stdout] | [INFO] [stdout] 76 | const OAM_SPRITE_PALETTE: u8 = 0b11; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OAM_SPRITE_PRIORITY` is never used [INFO] [stdout] --> src/nes/ppu.rs:77:7 [INFO] [stdout] | [INFO] [stdout] 77 | const OAM_SPRITE_PRIORITY: u8 = 1 << 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_VISIBLE_SCANLINES` is never used [INFO] [stdout] --> src/nes/ppu.rs:82:7 [INFO] [stdout] | [INFO] [stdout] 82 | const PPU_VISIBLE_SCANLINES: u32 = 240; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | let i = 0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_VBLANK_SCANLINE` is never used [INFO] [stdout] --> src/nes/ppu.rs:84:7 [INFO] [stdout] | [INFO] [stdout] 84 | const PPU_VBLANK_SCANLINE: u32 = 241; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `frame_count` is assigned to, but never used [INFO] [stdout] --> src/main.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | let mut frame_count = 0; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_frame_count` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/main.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | let mut t = SystemTime::now(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset` and `extract_y` are never used [INFO] [stdout] --> src/nes/ppu.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 148 | impl Ppu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 194 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 708 | fn extract_y(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS` is never used [INFO] [stdout] --> src/nes/apu.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const APU_STATUS: u16 = 0x4015; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_FRAME_COUNTER` is never used [INFO] [stdout] --> src/nes/apu.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | const APU_FRAME_COUNTER: u16 = 0x4017; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_PULSE1` is never used [INFO] [stdout] --> src/nes/apu.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | const APU_STATUS_PULSE1: u8 = 1 << 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_PULSE2` is never used [INFO] [stdout] --> src/nes/apu.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const APU_STATUS_PULSE2: u8 = 1 << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_TRIANGLE` is never used [INFO] [stdout] --> src/nes/apu.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const APU_STATUS_TRIANGLE: u8 = 1 << 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_NOISE` is never used [INFO] [stdout] --> src/nes/apu.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const APU_STATUS_NOISE: u8 = 1 << 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_DMC` is never used [INFO] [stdout] --> src/nes/apu.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const APU_STATUS_DMC: u8 = 1 << 4; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY_TABLE_MASK` is never used [INFO] [stdout] --> src/nes/apu.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const APU_PULSE_DUTY_TABLE_MASK: u8 = 0b1100_0000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY_TABLE_SHIFT` is never used [INFO] [stdout] --> src/nes/apu.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const APU_PULSE_DUTY_TABLE_SHIFT: u8 = 6; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY` is never used [INFO] [stdout] --> src/nes/apu.rs:24:7 [INFO] [stdout] | [INFO] [stdout] 24 | const APU_PULSE_DUTY: [[u8; 8]; 4] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset`, `step`, and `out` are never used [INFO] [stdout] --> src/nes/apu.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 56 | impl Pulse { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 81 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 123 | pub fn step(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 195 | pub fn out(&mut self) -> u8 { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Triangle` is never constructed [INFO] [stdout] --> src/nes/apu.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 203 | struct Triangle { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 207 | impl Triangle { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 208 | pub fn new() -> Triangle { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Noise` is never constructed [INFO] [stdout] --> src/nes/apu.rs:215:8 [INFO] [stdout] | [INFO] [stdout] 215 | struct Noise { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 219 | impl Noise { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 220 | pub fn new() -> Noise { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DMC` is never constructed [INFO] [stdout] --> src/nes/apu.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 227 | struct DMC { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 231 | impl DMC { [INFO] [stdout] | -------- associated function in this implementation [INFO] [stdout] 232 | pub fn new() -> DMC { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cycle`, `apu_cycle`, `accum`, `out_buf`, `out_index`, and `audio_ready` are never read [INFO] [stdout] --> src/nes/apu.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 239 | pub struct Apu { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 248 | cycle: u64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 249 | apu_cycle: u64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 250 | accum: f64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 251 | out_buf: [u8; 735], [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 252 | out_index: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 253 | audio_ready: bool [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset`, `mode0`, `mode1`, `sequencer`, `step`, and `run` are never used [INFO] [stdout] --> src/nes/apu.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 256 | impl Apu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 276 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 335 | fn mode0(&mut self) -> u16 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 360 | fn mode1(&mut self) -> u16 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 378 | fn sequencer(&mut self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 395 | fn step(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 428 | pub fn run(&mut self, cycles: u64) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | let mut t = SystemTime::now(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `CPU_NMI_VECTOR` is never used [INFO] [stdout] --> src/nes/cpu.rs:32:7 [INFO] [stdout] | [INFO] [stdout] 32 | const CPU_NMI_VECTOR: u16 = 0xfffa; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:146:28 [INFO] [stdout] | [INFO] [stdout] 146 | struct AbsoluteYAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:162:28 [INFO] [stdout] | [INFO] [stdout] 162 | struct IndirectXAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/nes/cpu.rs:170:28 [INFO] [stdout] | [INFO] [stdout] 170 | struct IndirectYAddressing(u16); [INFO] [stdout] | ------------------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `load_into_ram` and `reset` are never used [INFO] [stdout] --> src/nes/bus.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl Bus { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 85 | pub fn load_into_ram(&mut self, data: &[u8], offset: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NES_ROM_HAS_TRAINER` is never used [INFO] [stdout] --> src/nes/rom.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const NES_ROM_HAS_TRAINER: u8 = 1 << 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NES_ROM_IGNORE_MIRRORING` is never used [INFO] [stdout] --> src/nes/rom.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const NES_ROM_IGNORE_MIRRORING: u8 = 1 << 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `has_ram` is never read [INFO] [stdout] --> src/nes/rom.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct NesRom { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | pub has_ram: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `sp0_hit` and `frame` are never read [INFO] [stdout] --> src/nes/ppu.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Ppu { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | sp0_hit: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | frame: u128 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_GRAYSCALE` is never used [INFO] [stdout] --> src/nes/ppu.rs:67:7 [INFO] [stdout] | [INFO] [stdout] 67 | const PPU_MASK_GRAYSCALE: u8 = 1 << 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_RED` is never used [INFO] [stdout] --> src/nes/ppu.rs:72:7 [INFO] [stdout] | [INFO] [stdout] 72 | const PPU_MASK_EMPH_RED: u8 = 1 << 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_GREEN` is never used [INFO] [stdout] --> src/nes/ppu.rs:73:7 [INFO] [stdout] | [INFO] [stdout] 73 | const PPU_MASK_EMPH_GREEN: u8 = 1 << 6; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_MASK_EMPH_BLUE` is never used [INFO] [stdout] --> src/nes/ppu.rs:74:7 [INFO] [stdout] | [INFO] [stdout] 74 | const PPU_MASK_EMPH_BLUE: u8 = 1 << 7; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OAM_SPRITE_PALETTE` is never used [INFO] [stdout] --> src/nes/ppu.rs:76:7 [INFO] [stdout] | [INFO] [stdout] 76 | const OAM_SPRITE_PALETTE: u8 = 0b11; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OAM_SPRITE_PRIORITY` is never used [INFO] [stdout] --> src/nes/ppu.rs:77:7 [INFO] [stdout] | [INFO] [stdout] 77 | const OAM_SPRITE_PRIORITY: u8 = 1 << 5; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_VISIBLE_SCANLINES` is never used [INFO] [stdout] --> src/nes/ppu.rs:82:7 [INFO] [stdout] | [INFO] [stdout] 82 | const PPU_VISIBLE_SCANLINES: u32 = 240; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PPU_VBLANK_SCANLINE` is never used [INFO] [stdout] --> src/nes/ppu.rs:84:7 [INFO] [stdout] | [INFO] [stdout] 84 | const PPU_VBLANK_SCANLINE: u32 = 241; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset` and `extract_y` are never used [INFO] [stdout] --> src/nes/ppu.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 148 | impl Ppu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 194 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 708 | fn extract_y(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS` is never used [INFO] [stdout] --> src/nes/apu.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const APU_STATUS: u16 = 0x4015; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_FRAME_COUNTER` is never used [INFO] [stdout] --> src/nes/apu.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | const APU_FRAME_COUNTER: u16 = 0x4017; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_PULSE1` is never used [INFO] [stdout] --> src/nes/apu.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | const APU_STATUS_PULSE1: u8 = 1 << 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_PULSE2` is never used [INFO] [stdout] --> src/nes/apu.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const APU_STATUS_PULSE2: u8 = 1 << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_TRIANGLE` is never used [INFO] [stdout] --> src/nes/apu.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const APU_STATUS_TRIANGLE: u8 = 1 << 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_NOISE` is never used [INFO] [stdout] --> src/nes/apu.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const APU_STATUS_NOISE: u8 = 1 << 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_STATUS_DMC` is never used [INFO] [stdout] --> src/nes/apu.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const APU_STATUS_DMC: u8 = 1 << 4; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY_TABLE_MASK` is never used [INFO] [stdout] --> src/nes/apu.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const APU_PULSE_DUTY_TABLE_MASK: u8 = 0b1100_0000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY_TABLE_SHIFT` is never used [INFO] [stdout] --> src/nes/apu.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const APU_PULSE_DUTY_TABLE_SHIFT: u8 = 6; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APU_PULSE_DUTY` is never used [INFO] [stdout] --> src/nes/apu.rs:24:7 [INFO] [stdout] | [INFO] [stdout] 24 | const APU_PULSE_DUTY: [[u8; 8]; 4] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset`, `step`, and `out` are never used [INFO] [stdout] --> src/nes/apu.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 56 | impl Pulse { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 81 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 123 | pub fn step(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 195 | pub fn out(&mut self) -> u8 { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Triangle` is never constructed [INFO] [stdout] --> src/nes/apu.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 203 | struct Triangle { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 207 | impl Triangle { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 208 | pub fn new() -> Triangle { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Noise` is never constructed [INFO] [stdout] --> src/nes/apu.rs:215:8 [INFO] [stdout] | [INFO] [stdout] 215 | struct Noise { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 219 | impl Noise { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 220 | pub fn new() -> Noise { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DMC` is never constructed [INFO] [stdout] --> src/nes/apu.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 227 | struct DMC { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | canvas.set_logical_size(256, 240); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 43 | let _ = canvas.set_logical_size(256, 240); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/nes/apu.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 231 | impl DMC { [INFO] [stdout] | -------- associated function in this implementation [INFO] [stdout] 232 | pub fn new() -> DMC { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cycle`, `apu_cycle`, `accum`, `out_buf`, `out_index`, and `audio_ready` are never read [INFO] [stdout] --> src/nes/apu.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 239 | pub struct Apu { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 248 | cycle: u64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 249 | apu_cycle: u64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 250 | accum: f64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 251 | out_buf: [u8; 735], [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 252 | out_index: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 253 | audio_ready: bool [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reset`, `mode0`, `mode1`, `sequencer`, `step`, and `run` are never used [INFO] [stdout] --> src/nes/apu.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 256 | impl Apu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 276 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 335 | fn mode0(&mut self) -> u16 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 360 | fn mode1(&mut self) -> u16 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 378 | fn sequencer(&mut self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 395 | fn step(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 428 | pub fn run(&mut self, cycles: u64) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nes/mod.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 29 | let mapper = mapper::from_file(romfile)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let ppu = ppu::Ppu::new(Rc::clone(&mapper)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let apu = apu::Apu::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let bus = bus::Bus::new(mapper, ppu, apu); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let cpu = cpu::Cpu::new(bus); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | Ok(Nes { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | cpu, [INFO] [stdout] 37 | | frame: 0, [INFO] [stdout] 38 | | last_frame: Instant::now() [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/nes/mod.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / texture.with_lock(None, |buffer: &mut [u8], _pitch: usize| { [INFO] [stdout] 66 | | self.cpu.bus.ppu.copy_frame(buffer); [INFO] [stdout] 67 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 65 | let _ = texture.with_lock(None, |buffer: &mut [u8], _pitch: usize| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nes/bus.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(mapper: Rc>, ppu: ppu::Ppu, apu: apu::Apu) -> Bus { [INFO] [stdout] | --------------------------------------- ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | mapper: Rc::clone(&mapper), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 55 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | canvas.set_logical_size(256, 240); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 43 | let _ = canvas.set_logical_size(256, 240); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nes/mod.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 29 | let mapper = mapper::from_file(romfile)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let ppu = ppu::Ppu::new(Rc::clone(&mapper)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let apu = apu::Apu::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let bus = bus::Bus::new(mapper, ppu, apu); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let cpu = cpu::Cpu::new(bus); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | Ok(Nes { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | cpu, [INFO] [stdout] 37 | | frame: 0, [INFO] [stdout] 38 | | last_frame: Instant::now() [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/nes/mod.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / texture.with_lock(None, |buffer: &mut [u8], _pitch: usize| { [INFO] [stdout] 66 | | self.cpu.bus.ppu.copy_frame(buffer); [INFO] [stdout] 67 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 65 | let _ = texture.with_lock(None, |buffer: &mut [u8], _pitch: usize| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nes/bus.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(mapper: Rc>, ppu: ppu::Ppu, apu: apu::Apu) -> Bus { [INFO] [stdout] | --------------------------------------- ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | mapper: Rc::clone(&mapper), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yasnese` (bin "yasnese") due to 3 previous errors; 55 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 55 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yasnese` (bin "yasnese" test) due to 3 previous errors; 55 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b95b0b3bdc8c0d3bb0a179e5ad572559c34fe014c2983853246f73d4914e418d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b95b0b3bdc8c0d3bb0a179e5ad572559c34fe014c2983853246f73d4914e418d", kill_on_drop: false }` [INFO] [stdout] b95b0b3bdc8c0d3bb0a179e5ad572559c34fe014c2983853246f73d4914e418d