[INFO] cloning repository https://github.com/lc0305/rust_tracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lc0305/rust_tracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flc0305%2Frust_tracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flc0305%2Frust_tracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 321e5a03cb7d3c522500acfb936f6dae761553d6 [INFO] checking lc0305/rust_tracer against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flc0305%2Frust_tracer" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/lc0305/rust_tracer on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/lc0305/rust_tracer [INFO] finished tweaking git repo https://github.com/lc0305/rust_tracer [INFO] tweaked toml for git repo https://github.com/lc0305/rust_tracer written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/lc0305/rust_tracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tiff v0.5.0 [INFO] [stderr] Downloaded adler32 v1.1.0 [INFO] [stderr] Downloaded matrixmultiply v0.2.3 [INFO] [stderr] Downloaded num-traits v0.2.12 [INFO] [stderr] Downloaded terminal_size v0.1.13 [INFO] [stderr] Downloaded termios v0.3.2 [INFO] [stderr] Downloaded bytemuck v1.2.0 [INFO] [stderr] Downloaded gif v0.10.3 [INFO] [stderr] Downloaded png v0.16.7 [INFO] [stderr] Downloaded crossbeam-channel v0.4.3 [INFO] [stderr] Downloaded rayon-core v1.7.1 [INFO] [stderr] Downloaded console v0.11.3 [INFO] [stderr] Downloaded crossbeam v0.7.3 [INFO] [stderr] Downloaded num-iter v0.1.41 [INFO] [stderr] Downloaded rayon v1.3.1 [INFO] [stderr] Downloaded image v0.23.7 [INFO] [stderr] Downloaded num-rational v0.3.0 [INFO] [stderr] Downloaded jpeg-decoder v0.1.20 [INFO] [stderr] Downloaded num-integer v0.1.43 [INFO] [stderr] Downloaded libc v0.2.73 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5a909d1cc276016b9d65e363d35fd8b4d09ff72f795a9c8dfdc71e4f667db656 [INFO] running `Command { std: "docker" "start" "-a" "5a909d1cc276016b9d65e363d35fd8b4d09ff72f795a9c8dfdc71e4f667db656", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5a909d1cc276016b9d65e363d35fd8b4d09ff72f795a9c8dfdc71e4f667db656", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a909d1cc276016b9d65e363d35fd8b4d09ff72f795a9c8dfdc71e4f667db656", kill_on_drop: false }` [INFO] [stdout] 5a909d1cc276016b9d65e363d35fd8b4d09ff72f795a9c8dfdc71e4f667db656 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5aa10db6964bb81916858c6ef487ca1bac9cf5990723a709240f1a9f30afcb50 [INFO] running `Command { std: "docker" "start" "-a" "5aa10db6964bb81916858c6ef487ca1bac9cf5990723a709240f1a9f30afcb50", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling libc v0.2.73 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling rayon-core v1.7.1 [INFO] [stderr] Checking adler32 v1.1.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Compiling ndarray v0.13.1 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling rayon v1.3.1 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.3.0 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking tiff v0.5.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking termios v0.3.2 [INFO] [stderr] Checking terminal_size v0.1.13 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking crossbeam-channel v0.4.3 [INFO] [stderr] Checking bytemuck v1.2.0 [INFO] [stderr] Checking png v0.16.7 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking console v0.11.3 [INFO] [stderr] Checking jpeg-decoder v0.1.20 [INFO] [stderr] Checking image v0.23.7 [INFO] [stderr] Checking raytracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `intersection` [INFO] [stdout] --> src/objects/mod.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 92 | fn get_color(&self, intersection: &Array1) -> &Array1 { [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_intersection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `intersection` [INFO] [stdout] --> src/objects/mod.rs:160:23 [INFO] [stdout] | [INFO] [stdout] 160 | fn get_normal(&self, intersection: &Array1) -> Array1 { [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_intersection` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scope` [INFO] [stdout] --> src/raytracer/mod.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | if let Ok(scope) = scope_result { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_scope` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `handle` [INFO] [stdout] --> src/raytracer/mod.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | let handle = scope.spawn(move |_| { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_handle` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_depth` [INFO] [stdout] --> src/raytracer/mod.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 151 | ... for current_depth in 0..self.depth_max { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_depth` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `object` [INFO] [stdout] --> src/raytracer/mod.rs:209:22 [INFO] [stdout] | [INFO] [stdout] 209 | .filter(|&(index, object)| index != obj_idx) [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_object` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/raytracer/mod.rs:210:11 [INFO] [stdout] | [INFO] [stdout] 210 | .map(|(index, object)| object.intersect(&s, &to_L)) [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:16:6 [INFO] [stdout] | [INFO] [stdout] 16 | let mut scene = Arc::get_mut(&mut scene_arc).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | let mut scene = Arc::get_mut(&mut scene_arc).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `clear_screen` is never used [INFO] [stdout] --> src/helper/mod.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn clear_screen() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/raytracer/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 43 | impl Camera { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 44 | pub fn new(position: Vector3D, direction: Vector3D) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `def_diffuse_c` and `def_specular_c` are never read [INFO] [stdout] --> src/raytracer/mod.rs:86:2 [INFO] [stdout] | [INFO] [stdout] 84 | pub struct RayTracer { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 85 | ambient: f32, [INFO] [stdout] 86 | def_diffuse_c: f32, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 87 | def_specular_c: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:198:7 [INFO] [stdout] | [INFO] [stdout] 198 | let M = ray_origin + &(ray_direction * t); [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:200:7 [INFO] [stdout] | [INFO] [stdout] 200 | let N = object.get_normal(&M); [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `to_L` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:202:7 [INFO] [stdout] | [INFO] [stdout] 202 | let to_L = normalize(&self.light.direction - &M); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `to_l` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `to_O` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:220:7 [INFO] [stdout] | [INFO] [stdout] 220 | let to_O = normalize(&self.camera.position - &M); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `to_o` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:237:3 [INFO] [stdout] | [INFO] [stdout] 237 | M: Array1, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:238:3 [INFO] [stdout] | [INFO] [stdout] 238 | N: Array1, [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `intersection` [INFO] [stdout] --> src/objects/mod.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 92 | fn get_color(&self, intersection: &Array1) -> &Array1 { [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_intersection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `intersection` [INFO] [stdout] --> src/objects/mod.rs:160:23 [INFO] [stdout] | [INFO] [stdout] 160 | fn get_normal(&self, intersection: &Array1) -> Array1 { [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_intersection` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scope` [INFO] [stdout] --> src/raytracer/mod.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | if let Ok(scope) = scope_result { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_scope` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `handle` [INFO] [stdout] --> src/raytracer/mod.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | let handle = scope.spawn(move |_| { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_handle` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_depth` [INFO] [stdout] --> src/raytracer/mod.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 151 | ... for current_depth in 0..self.depth_max { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_depth` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `object` [INFO] [stdout] --> src/raytracer/mod.rs:209:22 [INFO] [stdout] | [INFO] [stdout] 209 | .filter(|&(index, object)| index != obj_idx) [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_object` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/raytracer/mod.rs:210:11 [INFO] [stdout] | [INFO] [stdout] 210 | .map(|(index, object)| object.intersect(&s, &to_L)) [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:16:6 [INFO] [stdout] | [INFO] [stdout] 16 | let mut scene = Arc::get_mut(&mut scene_arc).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | let mut scene = Arc::get_mut(&mut scene_arc).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `clear_screen` is never used [INFO] [stdout] --> src/helper/mod.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn clear_screen() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/raytracer/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 43 | impl Camera { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 44 | pub fn new(position: Vector3D, direction: Vector3D) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `def_diffuse_c` and `def_specular_c` are never read [INFO] [stdout] --> src/raytracer/mod.rs:86:2 [INFO] [stdout] | [INFO] [stdout] 84 | pub struct RayTracer { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 85 | ambient: f32, [INFO] [stdout] 86 | def_diffuse_c: f32, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 87 | def_specular_c: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:198:7 [INFO] [stdout] | [INFO] [stdout] 198 | let M = ray_origin + &(ray_direction * t); [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:200:7 [INFO] [stdout] | [INFO] [stdout] 200 | let N = object.get_normal(&M); [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `to_L` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:202:7 [INFO] [stdout] | [INFO] [stdout] 202 | let to_L = normalize(&self.light.direction - &M); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `to_l` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `to_O` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:220:7 [INFO] [stdout] | [INFO] [stdout] 220 | let to_O = normalize(&self.camera.position - &M); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `to_o` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:237:3 [INFO] [stdout] | [INFO] [stdout] 237 | M: Array1, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:238:3 [INFO] [stdout] | [INFO] [stdout] 238 | N: Array1, [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.63s [INFO] running `Command { std: "docker" "inspect" "5aa10db6964bb81916858c6ef487ca1bac9cf5990723a709240f1a9f30afcb50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5aa10db6964bb81916858c6ef487ca1bac9cf5990723a709240f1a9f30afcb50", kill_on_drop: false }` [INFO] [stdout] 5aa10db6964bb81916858c6ef487ca1bac9cf5990723a709240f1a9f30afcb50 [INFO] checking lc0305/rust_tracer against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flc0305%2Frust_tracer" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/lc0305/rust_tracer on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/lc0305/rust_tracer [INFO] finished tweaking git repo https://github.com/lc0305/rust_tracer [INFO] tweaked toml for git repo https://github.com/lc0305/rust_tracer written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/lc0305/rust_tracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8167a21c7b750ba787c554283c00c13513b3fe5059c670e34a3fc50c0fba344e [INFO] running `Command { std: "docker" "start" "-a" "8167a21c7b750ba787c554283c00c13513b3fe5059c670e34a3fc50c0fba344e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8167a21c7b750ba787c554283c00c13513b3fe5059c670e34a3fc50c0fba344e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8167a21c7b750ba787c554283c00c13513b3fe5059c670e34a3fc50c0fba344e", kill_on_drop: false }` [INFO] [stdout] 8167a21c7b750ba787c554283c00c13513b3fe5059c670e34a3fc50c0fba344e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af770584bf86eba404f8ad0ea3630d6a1c578f249256b8e853252569b7b8a1cd [INFO] running `Command { std: "docker" "start" "-a" "af770584bf86eba404f8ad0ea3630d6a1c578f249256b8e853252569b7b8a1cd", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling libc v0.2.73 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling rayon-core v1.7.1 [INFO] [stderr] Checking adler32 v1.1.0 [INFO] [stderr] Compiling rayon v1.3.1 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.3.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Compiling ndarray v0.13.1 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking tiff v0.5.0 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking png v0.16.7 [INFO] [stderr] Checking crossbeam-channel v0.4.3 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking termios v0.3.2 [INFO] [stderr] Checking terminal_size v0.1.13 [INFO] [stderr] Checking bytemuck v1.2.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking console v0.11.3 [INFO] [stderr] Checking jpeg-decoder v0.1.20 [INFO] [stderr] Checking image v0.23.7 [INFO] [stderr] Checking raytracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `intersection` [INFO] [stdout] --> src/objects/mod.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 92 | fn get_color(&self, intersection: &Array1) -> &Array1 { [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_intersection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `intersection` [INFO] [stdout] --> src/objects/mod.rs:160:23 [INFO] [stdout] | [INFO] [stdout] 160 | fn get_normal(&self, intersection: &Array1) -> Array1 { [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_intersection` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scope` [INFO] [stdout] --> src/raytracer/mod.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | if let Ok(scope) = scope_result { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_scope` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `handle` [INFO] [stdout] --> src/raytracer/mod.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | let handle = scope.spawn(move |_| { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_handle` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_depth` [INFO] [stdout] --> src/raytracer/mod.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 151 | ... for current_depth in 0..self.depth_max { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_depth` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `object` [INFO] [stdout] --> src/raytracer/mod.rs:209:22 [INFO] [stdout] | [INFO] [stdout] 209 | .filter(|&(index, object)| index != obj_idx) [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_object` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/raytracer/mod.rs:210:11 [INFO] [stdout] | [INFO] [stdout] 210 | .map(|(index, object)| object.intersect(&s, &to_L)) [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:16:6 [INFO] [stdout] | [INFO] [stdout] 16 | let mut scene = Arc::get_mut(&mut scene_arc).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `intersection` [INFO] [stdout] --> src/objects/mod.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 92 | fn get_color(&self, intersection: &Array1) -> &Array1 { [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_intersection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `intersection` [INFO] [stdout] --> src/objects/mod.rs:160:23 [INFO] [stdout] | [INFO] [stdout] 160 | fn get_normal(&self, intersection: &Array1) -> Array1 { [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_intersection` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scope` [INFO] [stdout] --> src/raytracer/mod.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | if let Ok(scope) = scope_result { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_scope` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `handle` [INFO] [stdout] --> src/raytracer/mod.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | let handle = scope.spawn(move |_| { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_handle` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_depth` [INFO] [stdout] --> src/raytracer/mod.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 151 | ... for current_depth in 0..self.depth_max { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_depth` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | let mut scene = Arc::get_mut(&mut scene_arc).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `clear_screen` is never used [INFO] [stdout] --> src/helper/mod.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn clear_screen() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/raytracer/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 43 | impl Camera { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 44 | pub fn new(position: Vector3D, direction: Vector3D) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `def_diffuse_c` and `def_specular_c` are never read [INFO] [stdout] --> src/raytracer/mod.rs:86:2 [INFO] [stdout] | [INFO] [stdout] 84 | pub struct RayTracer { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 85 | ambient: f32, [INFO] [stdout] 86 | def_diffuse_c: f32, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 87 | def_specular_c: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/mod.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(position: Vector3D, radius: f32, color: Array1, reflection: f32, diffuse_c: f32, specular_c: f32) -> Arc { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 53 | | position: position.to_ndarray(), [INFO] [stdout] 54 | | radius, [INFO] [stdout] 55 | | color, [INFO] [stdout] ... | [INFO] [stdout] 58 | | specular_c, [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/mod.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 124 | pub fn new(postion: Vector3D, normal: Vector3D, reflection: f32, diffuse_c: f32, specular_c: f32, colors: (Array1::, Array1::)) -... [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Arc::new(Checkerboard { [INFO] [stdout] | __________________^ [INFO] [stdout] 126 | | postion: postion.to_ndarray(), [INFO] [stdout] 127 | | normal: normal.to_ndarray(), [INFO] [stdout] 128 | | reflection, [INFO] [stdout] ... | [INFO] [stdout] 132 | | black: colors.0, [INFO] [stdout] 133 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raytracer/mod.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn new(color: Array1, direction: Vector3D) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | direction: direction.to_ndarray(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `object` [INFO] [stdout] --> src/raytracer/mod.rs:209:22 [INFO] [stdout] | [INFO] [stdout] 209 | .filter(|&(index, object)| index != obj_idx) [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_object` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:198:7 [INFO] [stdout] | [INFO] [stdout] 198 | let M = ray_origin + &(ray_direction * t); [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:200:7 [INFO] [stdout] | [INFO] [stdout] 200 | let N = object.get_normal(&M); [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `to_L` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:202:7 [INFO] [stdout] | [INFO] [stdout] 202 | let to_L = normalize(&self.light.direction - &M); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `to_l` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/raytracer/mod.rs:210:11 [INFO] [stdout] | [INFO] [stdout] 210 | .map(|(index, object)| object.intersect(&s, &to_L)) [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `to_O` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:220:7 [INFO] [stdout] | [INFO] [stdout] 220 | let to_O = normalize(&self.camera.position - &M); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `to_o` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:237:3 [INFO] [stdout] | [INFO] [stdout] 237 | M: Array1, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:238:3 [INFO] [stdout] | [INFO] [stdout] 238 | N: Array1, [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raytracer` (bin "raytracer") due to 4 previous errors; 18 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:16:6 [INFO] [stdout] | [INFO] [stdout] 16 | let mut scene = Arc::get_mut(&mut scene_arc).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | let mut scene = Arc::get_mut(&mut scene_arc).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `clear_screen` is never used [INFO] [stdout] --> src/helper/mod.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn clear_screen() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/raytracer/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 43 | impl Camera { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 44 | pub fn new(position: Vector3D, direction: Vector3D) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `def_diffuse_c` and `def_specular_c` are never read [INFO] [stdout] --> src/raytracer/mod.rs:86:2 [INFO] [stdout] | [INFO] [stdout] 84 | pub struct RayTracer { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 85 | ambient: f32, [INFO] [stdout] 86 | def_diffuse_c: f32, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 87 | def_specular_c: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/mod.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(position: Vector3D, radius: f32, color: Array1, reflection: f32, diffuse_c: f32, specular_c: f32) -> Arc { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 53 | | position: position.to_ndarray(), [INFO] [stdout] 54 | | radius, [INFO] [stdout] 55 | | color, [INFO] [stdout] ... | [INFO] [stdout] 58 | | specular_c, [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects/mod.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 124 | pub fn new(postion: Vector3D, normal: Vector3D, reflection: f32, diffuse_c: f32, specular_c: f32, colors: (Array1::, Array1::)) -... [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Arc::new(Checkerboard { [INFO] [stdout] | __________________^ [INFO] [stdout] 126 | | postion: postion.to_ndarray(), [INFO] [stdout] 127 | | normal: normal.to_ndarray(), [INFO] [stdout] 128 | | reflection, [INFO] [stdout] ... | [INFO] [stdout] 132 | | black: colors.0, [INFO] [stdout] 133 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raytracer/mod.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn new(color: Array1, direction: Vector3D) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | direction: direction.to_ndarray(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:198:7 [INFO] [stdout] | [INFO] [stdout] 198 | let M = ray_origin + &(ray_direction * t); [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:200:7 [INFO] [stdout] | [INFO] [stdout] 200 | let N = object.get_normal(&M); [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `to_L` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:202:7 [INFO] [stdout] | [INFO] [stdout] 202 | let to_L = normalize(&self.light.direction - &M); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `to_l` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `to_O` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:220:7 [INFO] [stdout] | [INFO] [stdout] 220 | let to_O = normalize(&self.camera.position - &M); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `to_o` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:237:3 [INFO] [stdout] | [INFO] [stdout] 237 | M: Array1, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N` should have a snake case name [INFO] [stdout] --> src/raytracer/mod.rs:238:3 [INFO] [stdout] | [INFO] [stdout] 238 | N: Array1, [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raytracer` (bin "raytracer" test) due to 4 previous errors; 18 warnings emitted [INFO] running `Command { std: "docker" "inspect" "af770584bf86eba404f8ad0ea3630d6a1c578f249256b8e853252569b7b8a1cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af770584bf86eba404f8ad0ea3630d6a1c578f249256b8e853252569b7b8a1cd", kill_on_drop: false }` [INFO] [stdout] af770584bf86eba404f8ad0ea3630d6a1c578f249256b8e853252569b7b8a1cd