[INFO] cloning repository https://github.com/kingfree/rust-lists [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kingfree/rust-lists" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkingfree%2Frust-lists", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkingfree%2Frust-lists'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3b529328280374620cafa34ab8a6f5e857ec8d69 [INFO] checking kingfree/rust-lists against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkingfree%2Frust-lists" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/kingfree/rust-lists on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/kingfree/rust-lists [INFO] finished tweaking git repo https://github.com/kingfree/rust-lists [INFO] tweaked toml for git repo https://github.com/kingfree/rust-lists written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/kingfree/rust-lists already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bdb462ead66086df55c59a2b7488e15560756ecdabfce37f4eb5364aee62d13f [INFO] running `Command { std: "docker" "start" "-a" "bdb462ead66086df55c59a2b7488e15560756ecdabfce37f4eb5364aee62d13f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bdb462ead66086df55c59a2b7488e15560756ecdabfce37f4eb5364aee62d13f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bdb462ead66086df55c59a2b7488e15560756ecdabfce37f4eb5364aee62d13f", kill_on_drop: false }` [INFO] [stdout] bdb462ead66086df55c59a2b7488e15560756ecdabfce37f4eb5364aee62d13f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aea0f4d7aeaaea7b1a81ca63c39021ecb9fa7a76740bead0e0d9eb7306e2900d [INFO] running `Command { std: "docker" "start" "-a" "aea0f4d7aeaaea7b1a81ca63c39021ecb9fa7a76740bead0e0d9eb7306e2900d", kill_on_drop: false }` [INFO] [stderr] Checking rust-lists v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::List` [INFO] [stdout] --> src/fifth.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | use super::List; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> src/fourth.rs:171:18 [INFO] [stdout] | [INFO] [stdout] 171 | let (next, elem) = Ref::map_split(node_ref, |node| (&node.next, &node.elem)); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `List` is never constructed [INFO] [stdout] --> src/silly1.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | struct List { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/silly1.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 6 | impl List { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 7 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 14 | pub fn push_left(&mut self, elem: T) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 17 | pub fn push_right(&mut self, elem: T) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn pop_left(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn pop_right(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 26 | pub fn peek_left(&self) -> Option<&T> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn peek_right(&self) -> Option<&T> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn peek_left_mut(&mut self) -> Option<&mut T> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn peek_right_mut(&mut self) -> Option<&mut T> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn go_left(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn go_right(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> src/fourth.rs:171:18 [INFO] [stdout] | [INFO] [stdout] 171 | let (next, elem) = Ref::map_split(node_ref, |node| (&node.next, &node.elem)); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `peek_left_mut`, `peek_right_mut`, and `go_right` are never used [INFO] [stdout] --> src/silly1.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 6 | impl List { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn peek_left_mut(&mut self) -> Option<&mut T> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn peek_right_mut(&mut self) -> Option<&mut T> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn go_right(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.18s [INFO] running `Command { std: "docker" "inspect" "aea0f4d7aeaaea7b1a81ca63c39021ecb9fa7a76740bead0e0d9eb7306e2900d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aea0f4d7aeaaea7b1a81ca63c39021ecb9fa7a76740bead0e0d9eb7306e2900d", kill_on_drop: false }` [INFO] [stdout] aea0f4d7aeaaea7b1a81ca63c39021ecb9fa7a76740bead0e0d9eb7306e2900d [INFO] checking kingfree/rust-lists against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkingfree%2Frust-lists" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/kingfree/rust-lists on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/kingfree/rust-lists [INFO] finished tweaking git repo https://github.com/kingfree/rust-lists [INFO] tweaked toml for git repo https://github.com/kingfree/rust-lists written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/kingfree/rust-lists already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 487e4ddaec60ecd7c9762f30c5a8d4a55460b3c8cc143c763f5ee0dd76ef69c5 [INFO] running `Command { std: "docker" "start" "-a" "487e4ddaec60ecd7c9762f30c5a8d4a55460b3c8cc143c763f5ee0dd76ef69c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "487e4ddaec60ecd7c9762f30c5a8d4a55460b3c8cc143c763f5ee0dd76ef69c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "487e4ddaec60ecd7c9762f30c5a8d4a55460b3c8cc143c763f5ee0dd76ef69c5", kill_on_drop: false }` [INFO] [stdout] 487e4ddaec60ecd7c9762f30c5a8d4a55460b3c8cc143c763f5ee0dd76ef69c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8bebb5a8d99383534f22e7cc674b8a8e2695e30195917aae6be3a2436679e76c [INFO] running `Command { std: "docker" "start" "-a" "8bebb5a8d99383534f22e7cc674b8a8e2695e30195917aae6be3a2436679e76c", kill_on_drop: false }` [INFO] [stderr] Checking rust-lists v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::List` [INFO] [stdout] --> src/fifth.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | use super::List; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> src/fourth.rs:171:18 [INFO] [stdout] | [INFO] [stdout] 171 | let (next, elem) = Ref::map_split(node_ref, |node| (&node.next, &node.elem)); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `List` is never constructed [INFO] [stdout] --> src/silly1.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | struct List { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/silly1.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 6 | impl List { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 7 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 14 | pub fn push_left(&mut self, elem: T) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 17 | pub fn push_right(&mut self, elem: T) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn pop_left(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn pop_right(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 26 | pub fn peek_left(&self) -> Option<&T> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn peek_right(&self) -> Option<&T> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn peek_left_mut(&mut self) -> Option<&mut T> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn peek_right_mut(&mut self) -> Option<&mut T> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn go_left(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn go_right(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 18 | fn new(elem: T) -> Rc> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Rc::new(RefCell::new(Node { [INFO] [stdout] | _________________^ [INFO] [stdout] 20 | | elem, [INFO] [stdout] 21 | | prev: None, [INFO] [stdout] 22 | | next: None, [INFO] [stdout] 23 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn push_front(&mut self, elem: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | // new node needs +2 links, everything else should be +0 [INFO] [stdout] 37 | let new_head = Node::new(elem); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | match self.head.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 57 | self.head.take().map(|old_head| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Rc::try_unwrap(old_head).ok().unwrap().into_inner().elem [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:80:34 [INFO] [stdout] | [INFO] [stdout] 80 | .map(|node| Ref::map(node.borrow(), |node| &node.elem)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn push_back(&mut self, elem: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let new_tail = Node::new(elem); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | match self.tail.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 99 | self.tail.take().map(|old_tail| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Rc::try_unwrap(old_tail).ok().unwrap().into_inner().elem [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:116:34 [INFO] [stdout] | [INFO] [stdout] 116 | .map(|node| Ref::map(node.borrow(), |node| &node.elem)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:122:37 [INFO] [stdout] | [INFO] [stdout] 122 | .map(|node| RefMut::map(node.borrow_mut(), |node| &mut node.elem)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:128:37 [INFO] [stdout] | [INFO] [stdout] 128 | .map(|node| RefMut::map(node.borrow_mut(), |node| &mut node.elem)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/third.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn prepend(&self, elem: T) -> List { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | List { [INFO] [stdout] 21 | head: Some(Rc::new(Node { [INFO] [stdout] | ___________________^ [INFO] [stdout] 22 | | elem, [INFO] [stdout] 23 | | next: self.head.clone(), [INFO] [stdout] 24 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-lists` (lib) due to 11 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> src/fourth.rs:171:18 [INFO] [stdout] | [INFO] [stdout] 171 | let (next, elem) = Ref::map_split(node_ref, |node| (&node.next, &node.elem)); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `peek_left_mut`, `peek_right_mut`, and `go_right` are never used [INFO] [stdout] --> src/silly1.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 6 | impl List { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn peek_left_mut(&mut self) -> Option<&mut T> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn peek_right_mut(&mut self) -> Option<&mut T> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn go_right(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 18 | fn new(elem: T) -> Rc> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Rc::new(RefCell::new(Node { [INFO] [stdout] | _________________^ [INFO] [stdout] 20 | | elem, [INFO] [stdout] 21 | | prev: None, [INFO] [stdout] 22 | | next: None, [INFO] [stdout] 23 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn push_front(&mut self, elem: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | // new node needs +2 links, everything else should be +0 [INFO] [stdout] 37 | let new_head = Node::new(elem); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | match self.head.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 57 | self.head.take().map(|old_head| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Rc::try_unwrap(old_head).ok().unwrap().into_inner().elem [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:80:34 [INFO] [stdout] | [INFO] [stdout] 80 | .map(|node| Ref::map(node.borrow(), |node| &node.elem)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn push_back(&mut self, elem: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let new_tail = Node::new(elem); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | match self.tail.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 99 | self.tail.take().map(|old_tail| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Rc::try_unwrap(old_tail).ok().unwrap().into_inner().elem [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:116:34 [INFO] [stdout] | [INFO] [stdout] 116 | .map(|node| Ref::map(node.borrow(), |node| &node.elem)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:122:37 [INFO] [stdout] | [INFO] [stdout] 122 | .map(|node| RefMut::map(node.borrow_mut(), |node| &mut node.elem)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:128:37 [INFO] [stdout] | [INFO] [stdout] 128 | .map(|node| RefMut::map(node.borrow_mut(), |node| &mut node.elem)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/third.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn prepend(&self, elem: T) -> List { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | List { [INFO] [stdout] 21 | head: Some(Rc::new(Node { [INFO] [stdout] | ___________________^ [INFO] [stdout] 22 | | elem, [INFO] [stdout] 23 | | next: self.head.clone(), [INFO] [stdout] 24 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-lists` (lib test) due to 11 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8bebb5a8d99383534f22e7cc674b8a8e2695e30195917aae6be3a2436679e76c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bebb5a8d99383534f22e7cc674b8a8e2695e30195917aae6be3a2436679e76c", kill_on_drop: false }` [INFO] [stdout] 8bebb5a8d99383534f22e7cc674b8a8e2695e30195917aae6be3a2436679e76c