[INFO] cloning repository https://github.com/kameczera/crafting-interpreters [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kameczera/crafting-interpreters" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkameczera%2Fcrafting-interpreters", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkameczera%2Fcrafting-interpreters'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 37eab3f15eb9d5ab4ac3c41e39a604cec8e36003 [INFO] checking kameczera/crafting-interpreters against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkameczera%2Fcrafting-interpreters" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/kameczera/crafting-interpreters on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/kameczera/crafting-interpreters [INFO] finished tweaking git repo https://github.com/kameczera/crafting-interpreters [INFO] tweaked toml for git repo https://github.com/kameczera/crafting-interpreters written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/kameczera/crafting-interpreters already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 180a2c9a1b37f4e1168e63df6f18f181a9dda0ae0f70628d436cad00b035995d [INFO] running `Command { std: "docker" "start" "-a" "180a2c9a1b37f4e1168e63df6f18f181a9dda0ae0f70628d436cad00b035995d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "180a2c9a1b37f4e1168e63df6f18f181a9dda0ae0f70628d436cad00b035995d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "180a2c9a1b37f4e1168e63df6f18f181a9dda0ae0f70628d436cad00b035995d", kill_on_drop: false }` [INFO] [stdout] 180a2c9a1b37f4e1168e63df6f18f181a9dda0ae0f70628d436cad00b035995d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0383e96ba01abaac9a512f8e70f2f088e8c93521ac34d5a14b24442d552997e1 [INFO] running `Command { std: "docker" "start" "-a" "0383e96ba01abaac9a512f8e70f2f088e8c93521ac34d5a14b24442d552997e1", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking lox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/lox/lang.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lox::expr` [INFO] [stdout] --> src/lox/lang.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::lox::expr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lox::interpreter` [INFO] [stdout] --> src/lox/lang.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::lox::interpreter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lox/parser.rs:419:16 [INFO] [stdout] | [INFO] [stdout] 419 | if (self.check(token_type)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 419 - if (self.check(token_type)) { [INFO] [stdout] 419 + if self.check(token_type) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/lox/interpreter.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | objects::{self, *}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lox/interpreter.rs:200:31 [INFO] [stdout] | [INFO] [stdout] 200 | } else if let (Object::String(left_value)) = values.0 { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 200 - } else if let (Object::String(left_value)) = values.0 { [INFO] [stdout] 200 + } else if let Object::String(left_value) = values.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::mem` [INFO] [stdout] --> src/lox/environment.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::mem; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/lox/lang.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lox::expr` [INFO] [stdout] --> src/lox/lang.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::lox::expr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lox::interpreter` [INFO] [stdout] --> src/lox/lang.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::lox::interpreter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lox/parser.rs:419:16 [INFO] [stdout] | [INFO] [stdout] 419 | if (self.check(token_type)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 419 - if (self.check(token_type)) { [INFO] [stdout] 419 + if self.check(token_type) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/lox/interpreter.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | objects::{self, *}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lox/interpreter.rs:200:31 [INFO] [stdout] | [INFO] [stdout] 200 | } else if let (Object::String(left_value)) = values.0 { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 200 - } else if let (Object::String(left_value)) = values.0 { [INFO] [stdout] 200 + } else if let Object::String(left_value) = values.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::mem` [INFO] [stdout] --> src/lox/environment.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::mem; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lox/interpreter.rs:318:13 [INFO] [stdout] | [INFO] [stdout] 318 | let mut right = self.evaluate(*expr.right)?; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `number` [INFO] [stdout] --> src/lox/interpreter.rs:348:31 [INFO] [stdout] | [INFO] [stdout] 348 | if let Object::Number(number) = operand { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_number` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lox/interpreter.rs:318:13 [INFO] [stdout] | [INFO] [stdout] 318 | let mut right = self.evaluate(*expr.right)?; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `number` [INFO] [stdout] --> src/lox/interpreter.rs:348:31 [INFO] [stdout] | [INFO] [stdout] 348 | if let Object::Number(number) = operand { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_number` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lox/objects.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | if let Object::String(s) = self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lox/objects.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 58 | if let Object::Number(s) = self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `to_string` and `to_string_lexeme` are never used [INFO] [stdout] --> src/lox/token.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Token { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn to_string(&self) -> String { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn to_string_lexeme(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `error` is never used [INFO] [stdout] --> src/lox/lang.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Lox { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 76 | pub fn error(&mut self, line: u32, message: String) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_father` is never used [INFO] [stdout] --> src/lox/environment.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> Environment<'a> { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn set_father(&mut self, enclosing: Rc>>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `bool`, `is_string`, `string`, and `is_number` are never used [INFO] [stdout] --> src/lox/objects.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl Object { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn bool(self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn is_string(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn string(self) -> String { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | pub fn is_number(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lox/objects.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | if let Object::String(s) = self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lox/objects.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 58 | if let Object::Number(s) = self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/parser.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | self.consume(TokenType::RightBrace, String::from("Expect '}' after block.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = self.consume(TokenType::RightBrace, String::from("Expect '}' after block.")); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `to_string` and `to_string_lexeme` are never used [INFO] [stdout] --> src/lox/token.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Token { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn to_string(&self) -> String { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn to_string_lexeme(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `error` is never used [INFO] [stdout] --> src/lox/lang.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Lox { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 76 | pub fn error(&mut self, line: u32, message: String) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_father` is never used [INFO] [stdout] --> src/lox/environment.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> Environment<'a> { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn set_father(&mut self, enclosing: Rc>>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `bool`, `is_string`, `string`, and `is_number` are never used [INFO] [stdout] --> src/lox/objects.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl Object { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn bool(self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn is_string(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn string(self) -> String { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | pub fn is_number(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/interpreter.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | self.execute(*if_branch.then_branch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 104 | let _ = self.execute(*if_branch.then_branch); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/interpreter.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | self.execute(*if_branch.else_branch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 109 | let _ = self.execute(*if_branch.else_branch); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/parser.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | self.consume(TokenType::RightBrace, String::from("Expect '}' after block.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = self.consume(TokenType::RightBrace, String::from("Expect '}' after block.")); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/interpreter.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | self.execute(*if_branch.then_branch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 104 | let _ = self.execute(*if_branch.then_branch); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/interpreter.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | self.execute(*if_branch.else_branch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 109 | let _ = self.execute(*if_branch.else_branch); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.49s [INFO] running `Command { std: "docker" "inspect" "0383e96ba01abaac9a512f8e70f2f088e8c93521ac34d5a14b24442d552997e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0383e96ba01abaac9a512f8e70f2f088e8c93521ac34d5a14b24442d552997e1", kill_on_drop: false }` [INFO] [stdout] 0383e96ba01abaac9a512f8e70f2f088e8c93521ac34d5a14b24442d552997e1 [INFO] checking kameczera/crafting-interpreters against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkameczera%2Fcrafting-interpreters" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/kameczera/crafting-interpreters on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/kameczera/crafting-interpreters [INFO] finished tweaking git repo https://github.com/kameczera/crafting-interpreters [INFO] tweaked toml for git repo https://github.com/kameczera/crafting-interpreters written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/kameczera/crafting-interpreters already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2705c0dc8bdecca55e9e3033ae06840439e264202f286504dcd45524e1546bfe [INFO] running `Command { std: "docker" "start" "-a" "2705c0dc8bdecca55e9e3033ae06840439e264202f286504dcd45524e1546bfe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2705c0dc8bdecca55e9e3033ae06840439e264202f286504dcd45524e1546bfe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2705c0dc8bdecca55e9e3033ae06840439e264202f286504dcd45524e1546bfe", kill_on_drop: false }` [INFO] [stdout] 2705c0dc8bdecca55e9e3033ae06840439e264202f286504dcd45524e1546bfe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 98c52814af7282f4b8ffe22e01cf5cb588dcfe79f835247b0a0cede4bbf28a0d [INFO] running `Command { std: "docker" "start" "-a" "98c52814af7282f4b8ffe22e01cf5cb588dcfe79f835247b0a0cede4bbf28a0d", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking lox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/lox/lang.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lox::expr` [INFO] [stdout] --> src/lox/lang.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::lox::expr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lox::interpreter` [INFO] [stdout] --> src/lox/lang.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::lox::interpreter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lox/parser.rs:419:16 [INFO] [stdout] | [INFO] [stdout] 419 | if (self.check(token_type)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 419 - if (self.check(token_type)) { [INFO] [stdout] 419 + if self.check(token_type) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/lox/interpreter.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | objects::{self, *}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lox/interpreter.rs:200:31 [INFO] [stdout] | [INFO] [stdout] 200 | } else if let (Object::String(left_value)) = values.0 { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 200 - } else if let (Object::String(left_value)) = values.0 { [INFO] [stdout] 200 + } else if let Object::String(left_value) = values.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::mem` [INFO] [stdout] --> src/lox/environment.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::mem; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/lox/lang.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lox::expr` [INFO] [stdout] --> src/lox/lang.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::lox::expr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lox::interpreter` [INFO] [stdout] --> src/lox/lang.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::lox::interpreter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lox/parser.rs:419:16 [INFO] [stdout] | [INFO] [stdout] 419 | if (self.check(token_type)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 419 - if (self.check(token_type)) { [INFO] [stdout] 419 + if self.check(token_type) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/lox/interpreter.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | objects::{self, *}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lox/interpreter.rs:200:31 [INFO] [stdout] | [INFO] [stdout] 200 | } else if let (Object::String(left_value)) = values.0 { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 200 - } else if let (Object::String(left_value)) = values.0 { [INFO] [stdout] 200 + } else if let Object::String(left_value) = values.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::mem` [INFO] [stdout] --> src/lox/environment.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::mem; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lox/interpreter.rs:318:13 [INFO] [stdout] | [INFO] [stdout] 318 | let mut right = self.evaluate(*expr.right)?; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `number` [INFO] [stdout] --> src/lox/interpreter.rs:348:31 [INFO] [stdout] | [INFO] [stdout] 348 | if let Object::Number(number) = operand { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_number` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lox/objects.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | if let Object::String(s) = self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lox/objects.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 58 | if let Object::Number(s) = self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `to_string` and `to_string_lexeme` are never used [INFO] [stdout] --> src/lox/token.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Token { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn to_string(&self) -> String { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn to_string_lexeme(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `error` is never used [INFO] [stdout] --> src/lox/lang.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Lox { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 76 | pub fn error(&mut self, line: u32, message: String) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_father` is never used [INFO] [stdout] --> src/lox/environment.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> Environment<'a> { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn set_father(&mut self, enclosing: Rc>>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `bool`, `is_string`, `string`, and `is_number` are never used [INFO] [stdout] --> src/lox/objects.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl Object { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn bool(self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn is_string(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn string(self) -> String { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | pub fn is_number(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/parser.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | self.consume(TokenType::RightBrace, String::from("Expect '}' after block.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = self.consume(TokenType::RightBrace, String::from("Expect '}' after block.")); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn binary(left: Expr, operator: Token, right: Expr) -> Self { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Expr::Binary(Binary { [INFO] [stdout] | ______________________^ [INFO] [stdout] 67 | | left: Box::new(left), [INFO] [stdout] 68 | | operator: operator, [INFO] [stdout] 69 | | right: Box::new(right), [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn ternary(expression: Expr, true_part: Expr, false_part: Expr) -> Self { [INFO] [stdout] | ---------------- --------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | Expr::Ternary(Ternary { [INFO] [stdout] | _______________________^ [INFO] [stdout] 75 | | expression: Box::new(expression), [INFO] [stdout] 76 | | true_part: Box::new(true_part), [INFO] [stdout] 77 | | false_part: Box::new(false_part), [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:82:22 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn unary(operator: Token, right: Expr) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Expr::Unary (Unary { [INFO] [stdout] | ______________________^ [INFO] [stdout] 83 | | operator: operator, [INFO] [stdout] 84 | | right: Box::new(right), [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:95:23 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn logical(left: Expr, operator: Token, right: Expr) -> Self { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Expr::Logical(Logical { [INFO] [stdout] | _______________________^ [INFO] [stdout] 96 | | left: Box::new(left), [INFO] [stdout] 97 | | operator: operator, [INFO] [stdout] 98 | | right: Box::new(right), [INFO] [stdout] 99 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:103:24 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn grouping(expression: Expr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Expr::Grouping(Grouping { [INFO] [stdout] | ________________________^ [INFO] [stdout] 104 | | expression: Box::new(expression), [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:114:22 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn assign(name: Token, value: Expr) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Expr::Assign(Assign { [INFO] [stdout] | ______________________^ [INFO] [stdout] 115 | | name: name, [INFO] [stdout] 116 | | value: Box::new(value), [INFO] [stdout] 117 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/interpreter.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | self.execute(*if_branch.then_branch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 104 | let _ = self.execute(*if_branch.then_branch); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/interpreter.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | self.execute(*if_branch.else_branch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 109 | let _ = self.execute(*if_branch.else_branch); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/interpreter.rs:162:15 [INFO] [stdout] | [INFO] [stdout] 160 | fn visit_assign_expr(&mut self, expr: Assign) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let value = self.evaluate(*expr.value)?; [INFO] [stdout] 162 | match self.environment.borrow_mut().assign(expr.name, &value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:50:31 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn expression(expression: Expr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Statement::Expression(Expression { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 51 | | expression: Box::new(expression), [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:56:26 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn print(expression: Expr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Statement::Print(Print { [INFO] [stdout] | __________________________^ [INFO] [stdout] 57 | | expression: Box::new(expression), [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:62:23 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn if_branch(condition: Expr, then_branch: Statement, else_brach: Statement) -> Self { [INFO] [stdout] | --------------- ---------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Statement::If(If { [INFO] [stdout] | _______________________^ [INFO] [stdout] 63 | | condition: Box::new(condition), [INFO] [stdout] 64 | | then_branch: Box::new(then_branch), [INFO] [stdout] 65 | | else_branch: Box::new(else_brach) [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn while_branch(condition: Expr, body: Statement) -> Self { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Statement::While(While { [INFO] [stdout] | __________________________^ [INFO] [stdout] 71 | | condition: Box::new(condition), [INFO] [stdout] 72 | | body: Box::new(body), [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:77:24 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn var(name: Token, initializer: Expr) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Statement::Var(Var { [INFO] [stdout] | ________________________^ [INFO] [stdout] 78 | | name: name, [INFO] [stdout] 79 | | initializer: Box::new(initializer), [INFO] [stdout] 80 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:84:26 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn block(statements: Vec) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Statement::Block(Block { [INFO] [stdout] | __________________________^ [INFO] [stdout] 85 | | statements: statements, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lox` (bin "lox" test) due to 14 previous errors; 18 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lox/interpreter.rs:318:13 [INFO] [stdout] | [INFO] [stdout] 318 | let mut right = self.evaluate(*expr.right)?; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `number` [INFO] [stdout] --> src/lox/interpreter.rs:348:31 [INFO] [stdout] | [INFO] [stdout] 348 | if let Object::Number(number) = operand { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_number` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lox/objects.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | if let Object::String(s) = self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lox/objects.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 58 | if let Object::Number(s) = self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `to_string` and `to_string_lexeme` are never used [INFO] [stdout] --> src/lox/token.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Token { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn to_string(&self) -> String { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn to_string_lexeme(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `error` is never used [INFO] [stdout] --> src/lox/lang.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Lox { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 76 | pub fn error(&mut self, line: u32, message: String) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_father` is never used [INFO] [stdout] --> src/lox/environment.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> Environment<'a> { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn set_father(&mut self, enclosing: Rc>>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `bool`, `is_string`, `string`, and `is_number` are never used [INFO] [stdout] --> src/lox/objects.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl Object { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn bool(self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn is_string(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn string(self) -> String { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | pub fn is_number(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/parser.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | self.consume(TokenType::RightBrace, String::from("Expect '}' after block.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = self.consume(TokenType::RightBrace, String::from("Expect '}' after block.")); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn binary(left: Expr, operator: Token, right: Expr) -> Self { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Expr::Binary(Binary { [INFO] [stdout] | ______________________^ [INFO] [stdout] 67 | | left: Box::new(left), [INFO] [stdout] 68 | | operator: operator, [INFO] [stdout] 69 | | right: Box::new(right), [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn ternary(expression: Expr, true_part: Expr, false_part: Expr) -> Self { [INFO] [stdout] | ---------------- --------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | Expr::Ternary(Ternary { [INFO] [stdout] | _______________________^ [INFO] [stdout] 75 | | expression: Box::new(expression), [INFO] [stdout] 76 | | true_part: Box::new(true_part), [INFO] [stdout] 77 | | false_part: Box::new(false_part), [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:82:22 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn unary(operator: Token, right: Expr) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Expr::Unary (Unary { [INFO] [stdout] | ______________________^ [INFO] [stdout] 83 | | operator: operator, [INFO] [stdout] 84 | | right: Box::new(right), [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:95:23 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn logical(left: Expr, operator: Token, right: Expr) -> Self { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Expr::Logical(Logical { [INFO] [stdout] | _______________________^ [INFO] [stdout] 96 | | left: Box::new(left), [INFO] [stdout] 97 | | operator: operator, [INFO] [stdout] 98 | | right: Box::new(right), [INFO] [stdout] 99 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:103:24 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn grouping(expression: Expr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Expr::Grouping(Grouping { [INFO] [stdout] | ________________________^ [INFO] [stdout] 104 | | expression: Box::new(expression), [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/expr.rs:114:22 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn assign(name: Token, value: Expr) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Expr::Assign(Assign { [INFO] [stdout] | ______________________^ [INFO] [stdout] 115 | | name: name, [INFO] [stdout] 116 | | value: Box::new(value), [INFO] [stdout] 117 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/interpreter.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | self.execute(*if_branch.then_branch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 104 | let _ = self.execute(*if_branch.then_branch); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lox/interpreter.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | self.execute(*if_branch.else_branch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 109 | let _ = self.execute(*if_branch.else_branch); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/interpreter.rs:162:15 [INFO] [stdout] | [INFO] [stdout] 160 | fn visit_assign_expr(&mut self, expr: Assign) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let value = self.evaluate(*expr.value)?; [INFO] [stdout] 162 | match self.environment.borrow_mut().assign(expr.name, &value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:50:31 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn expression(expression: Expr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Statement::Expression(Expression { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 51 | | expression: Box::new(expression), [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:56:26 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn print(expression: Expr) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Statement::Print(Print { [INFO] [stdout] | __________________________^ [INFO] [stdout] 57 | | expression: Box::new(expression), [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:62:23 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn if_branch(condition: Expr, then_branch: Statement, else_brach: Statement) -> Self { [INFO] [stdout] | --------------- ---------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Statement::If(If { [INFO] [stdout] | _______________________^ [INFO] [stdout] 63 | | condition: Box::new(condition), [INFO] [stdout] 64 | | then_branch: Box::new(then_branch), [INFO] [stdout] 65 | | else_branch: Box::new(else_brach) [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn while_branch(condition: Expr, body: Statement) -> Self { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Statement::While(While { [INFO] [stdout] | __________________________^ [INFO] [stdout] 71 | | condition: Box::new(condition), [INFO] [stdout] 72 | | body: Box::new(body), [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:77:24 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn var(name: Token, initializer: Expr) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Statement::Var(Var { [INFO] [stdout] | ________________________^ [INFO] [stdout] 78 | | name: name, [INFO] [stdout] 79 | | initializer: Box::new(initializer), [INFO] [stdout] 80 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lox/stmt.rs:84:26 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn block(statements: Vec) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Statement::Block(Block { [INFO] [stdout] | __________________________^ [INFO] [stdout] 85 | | statements: statements, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lox` (bin "lox") due to 14 previous errors; 18 warnings emitted [INFO] running `Command { std: "docker" "inspect" "98c52814af7282f4b8ffe22e01cf5cb588dcfe79f835247b0a0cede4bbf28a0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98c52814af7282f4b8ffe22e01cf5cb588dcfe79f835247b0a0cede4bbf28a0d", kill_on_drop: false }` [INFO] [stdout] 98c52814af7282f4b8ffe22e01cf5cb588dcfe79f835247b0a0cede4bbf28a0d