[INFO] cloning repository https://github.com/jtbeckha/mp3v0fs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jtbeckha/mp3v0fs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtbeckha%2Fmp3v0fs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtbeckha%2Fmp3v0fs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 296d69cbaa39f7aef153d23bc4a0c2b5052e1c23 [INFO] checking jtbeckha/mp3v0fs against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtbeckha%2Fmp3v0fs" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jtbeckha/mp3v0fs on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jtbeckha/mp3v0fs [INFO] finished tweaking git repo https://github.com/jtbeckha/mp3v0fs [INFO] tweaked toml for git repo https://github.com/jtbeckha/mp3v0fs written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/jtbeckha/mp3v0fs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/jtbeckha/claxon.git` [INFO] [stderr] Updating git repository `https://github.com/zargony/fuse-rs.git` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded id3 v0.3.0 [INFO] [stderr] Downloaded simplelog v0.5.3 [INFO] [stderr] Downloaded simplemad v0.9.0 [INFO] [stderr] Downloaded simplemad_sys v0.5.0 [INFO] [stderr] Downloaded lame-sys v0.1.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64ecd02e234c73c11415a05d4c6603d8420b1a63eff75a62415fa56c7054566e [INFO] running `Command { std: "docker" "start" "-a" "64ecd02e234c73c11415a05d4c6603d8420b1a63eff75a62415fa56c7054566e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64ecd02e234c73c11415a05d4c6603d8420b1a63eff75a62415fa56c7054566e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64ecd02e234c73c11415a05d4c6603d8420b1a63eff75a62415fa56c7054566e", kill_on_drop: false }` [INFO] [stdout] 64ecd02e234c73c11415a05d4c6603d8420b1a63eff75a62415fa56c7054566e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b2a1009a74c6508fdcca5345802ae019164780f2372124244fad5f00f7f081a3 [INFO] running `Command { std: "docker" "start" "-a" "b2a1009a74c6508fdcca5345802ae019164780f2372124244fad5f00f7f081a3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling fuse-sys v0.4.0-dev (https://github.com/zargony/fuse-rs.git?rev=42e29d964e2b24e32e21b179b77e4d0d0a0857ac#42e29d96) [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling derive_builder v0.7.2 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking miniz_oxide v0.3.3 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling lame-sys v0.1.2 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking flate2 v1.0.12 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking fuse-abi v0.4.0-dev (https://github.com/zargony/fuse-rs.git?rev=42e29d964e2b24e32e21b179b77e4d0d0a0857ac#42e29d96) [INFO] [stderr] Checking thread-scoped v1.0.2 [INFO] [stderr] Checking fuse v0.4.0-dev (https://github.com/zargony/fuse-rs.git?rev=42e29d964e2b24e32e21b179b77e4d0d0a0857ac#42e29d96) [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Compiling simplemad_sys v0.5.0 [INFO] [stderr] Checking libc v0.1.12 [INFO] [stderr] Checking claxon v0.4.2 (https://github.com/jtbeckha/claxon.git#38ec00b5) [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking simplemad v0.9.0 [INFO] [stderr] Compiling darling_core v0.9.0 [INFO] [stderr] Compiling darling_macro v0.9.0 [INFO] [stderr] Compiling darling v0.9.0 [INFO] [stderr] Compiling derive_builder_core v0.5.0 [INFO] [stderr] Checking id3 v0.3.0 [INFO] [stderr] Checking mp3v0fs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/inode.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut inode_entry = match self.inodes_by_path.get_mut(path) { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/inode.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut inode_entry = match self.inodes_by_path.get_mut(path) { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/encode.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | std::mem::replace(&mut self.output_buffer[self.tag_size + index], byte); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 205 | let _ = std::mem::replace(&mut self.output_buffer[self.tag_size + index], byte); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:283:65 [INFO] [stdout] | [INFO] [stdout] 283 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:284:75 [INFO] [stdout] | [INFO] [stdout] 284 | CString::new(name.to_os_string().into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ----------------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:293:65 [INFO] [stdout] | [INFO] [stdout] 293 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:294:75 [INFO] [stdout] | [INFO] [stdout] 294 | CString::new(name.to_os_string().into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ----------------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:315:65 [INFO] [stdout] | [INFO] [stdout] 315 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:324:65 [INFO] [stdout] | [INFO] [stdout] 324 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/encode.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | std::mem::replace(&mut self.output_buffer[self.tag_size + index], byte); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 205 | let _ = std::mem::replace(&mut self.output_buffer[self.tag_size + index], byte); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:283:65 [INFO] [stdout] | [INFO] [stdout] 283 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:284:75 [INFO] [stdout] | [INFO] [stdout] 284 | CString::new(name.to_os_string().into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ----------------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:293:65 [INFO] [stdout] | [INFO] [stdout] 293 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:294:75 [INFO] [stdout] | [INFO] [stdout] 294 | CString::new(name.to_os_string().into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ----------------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:315:65 [INFO] [stdout] | [INFO] [stdout] 315 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:324:65 [INFO] [stdout] | [INFO] [stdout] 324 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.34s [INFO] running `Command { std: "docker" "inspect" "b2a1009a74c6508fdcca5345802ae019164780f2372124244fad5f00f7f081a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2a1009a74c6508fdcca5345802ae019164780f2372124244fad5f00f7f081a3", kill_on_drop: false }` [INFO] [stdout] b2a1009a74c6508fdcca5345802ae019164780f2372124244fad5f00f7f081a3 [INFO] checking jtbeckha/mp3v0fs against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtbeckha%2Fmp3v0fs" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jtbeckha/mp3v0fs on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jtbeckha/mp3v0fs [INFO] finished tweaking git repo https://github.com/jtbeckha/mp3v0fs [INFO] tweaked toml for git repo https://github.com/jtbeckha/mp3v0fs written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/jtbeckha/mp3v0fs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cbf8bb85994171f3dea6c1e6194c1010cc909375fb188290441ec931b4f619df [INFO] running `Command { std: "docker" "start" "-a" "cbf8bb85994171f3dea6c1e6194c1010cc909375fb188290441ec931b4f619df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cbf8bb85994171f3dea6c1e6194c1010cc909375fb188290441ec931b4f619df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbf8bb85994171f3dea6c1e6194c1010cc909375fb188290441ec931b4f619df", kill_on_drop: false }` [INFO] [stdout] cbf8bb85994171f3dea6c1e6194c1010cc909375fb188290441ec931b4f619df [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0572f14b3875ad3fe244ba83d806decfc652045e4ebd052bfb762259bdf942c [INFO] running `Command { std: "docker" "start" "-a" "a0572f14b3875ad3fe244ba83d806decfc652045e4ebd052bfb762259bdf942c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling fuse-sys v0.4.0-dev (https://github.com/zargony/fuse-rs.git?rev=42e29d964e2b24e32e21b179b77e4d0d0a0857ac#42e29d96) [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling derive_builder v0.7.2 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking miniz_oxide v0.3.3 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Compiling lame-sys v0.1.2 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking flate2 v1.0.12 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking thread-scoped v1.0.2 [INFO] [stderr] Checking fuse-abi v0.4.0-dev (https://github.com/zargony/fuse-rs.git?rev=42e29d964e2b24e32e21b179b77e4d0d0a0857ac#42e29d96) [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking fuse v0.4.0-dev (https://github.com/zargony/fuse-rs.git?rev=42e29d964e2b24e32e21b179b77e4d0d0a0857ac#42e29d96) [INFO] [stderr] Compiling simplemad_sys v0.5.0 [INFO] [stderr] Checking libc v0.1.12 [INFO] [stderr] Checking claxon v0.4.2 (https://github.com/jtbeckha/claxon.git#38ec00b5) [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Compiling darling_core v0.9.0 [INFO] [stderr] Checking simplemad v0.9.0 [INFO] [stderr] Compiling darling_macro v0.9.0 [INFO] [stderr] Compiling darling v0.9.0 [INFO] [stderr] Compiling derive_builder_core v0.5.0 [INFO] [stderr] Checking id3 v0.3.0 [INFO] [stderr] Checking mp3v0fs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/inode.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut inode_entry = match self.inodes_by_path.get_mut(path) { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:106:27 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn new(flac_reader: FlacReader) -> FlacToMp3Encoder { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let mut lame = Lame::new().expect("Failed to initialize LAME context"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | flac_samples: flac_reader.samples_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:107:27 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn new(flac_reader: FlacReader) -> FlacToMp3Encoder { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let mut lame = Lame::new().expect("Failed to initialize LAME context"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | lame_wrapper: LameWrapper { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 108 | | lame: Arc::from(Mutex::new(lame)) [INFO] [stdout] 109 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/encode.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | std::mem::replace(&mut self.output_buffer[self.tag_size + index], byte); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 205 | let _ = std::mem::replace(&mut self.output_buffer[self.tag_size + index], byte); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3v0fs.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 68 | Err(e) => return Err(e) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | atime: metadata.accessed().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3v0fs.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 68 | Err(e) => return Err(e) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | mtime: metadata.modified().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3v0fs.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 68 | Err(e) => return Err(e) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | ctime: metadata.modified().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3v0fs.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 68 | Err(e) => return Err(e) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | crtime: metadata.modified().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:283:65 [INFO] [stdout] | [INFO] [stdout] 283 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:284:75 [INFO] [stdout] | [INFO] [stdout] 284 | CString::new(name.to_os_string().into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ----------------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:293:65 [INFO] [stdout] | [INFO] [stdout] 293 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:294:75 [INFO] [stdout] | [INFO] [stdout] 294 | CString::new(name.to_os_string().into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ----------------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:315:65 [INFO] [stdout] | [INFO] [stdout] 315 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:324:65 [INFO] [stdout] | [INFO] [stdout] 324 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/inode.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut inode_entry = match self.inodes_by_path.get_mut(path) { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:106:27 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn new(flac_reader: FlacReader) -> FlacToMp3Encoder { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let mut lame = Lame::new().expect("Failed to initialize LAME context"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | flac_samples: flac_reader.samples_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:107:27 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn new(flac_reader: FlacReader) -> FlacToMp3Encoder { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let mut lame = Lame::new().expect("Failed to initialize LAME context"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | lame_wrapper: LameWrapper { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 108 | | lame: Arc::from(Mutex::new(lame)) [INFO] [stdout] 109 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mp3v0fs` (lib) due to 7 previous errors; 8 warnings emitted [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/encode.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | std::mem::replace(&mut self.output_buffer[self.tag_size + index], byte); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 205 | let _ = std::mem::replace(&mut self.output_buffer[self.tag_size + index], byte); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3v0fs.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 68 | Err(e) => return Err(e) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | atime: metadata.accessed().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3v0fs.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 68 | Err(e) => return Err(e) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | mtime: metadata.modified().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3v0fs.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 68 | Err(e) => return Err(e) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | ctime: metadata.modified().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3v0fs.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 68 | Err(e) => return Err(e) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | crtime: metadata.modified().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:283:65 [INFO] [stdout] | [INFO] [stdout] 283 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:284:75 [INFO] [stdout] | [INFO] [stdout] 284 | CString::new(name.to_os_string().into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ----------------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:293:65 [INFO] [stdout] | [INFO] [stdout] 293 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:294:75 [INFO] [stdout] | [INFO] [stdout] 294 | CString::new(name.to_os_string().into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ----------------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:315:65 [INFO] [stdout] | [INFO] [stdout] 315 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/mp3v0fs.rs:324:65 [INFO] [stdout] | [INFO] [stdout] 324 | CString::new(real_path.into_vec()).unwrap().as_ptr(), [INFO] [stdout] | ------------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mp3v0fs` (lib test) due to 7 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a0572f14b3875ad3fe244ba83d806decfc652045e4ebd052bfb762259bdf942c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0572f14b3875ad3fe244ba83d806decfc652045e4ebd052bfb762259bdf942c", kill_on_drop: false }` [INFO] [stdout] a0572f14b3875ad3fe244ba83d806decfc652045e4ebd052bfb762259bdf942c