[INFO] cloning repository https://github.com/jonathanlofgren/advent_of_code_2020 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jonathanlofgren/advent_of_code_2020" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonathanlofgren%2Fadvent_of_code_2020", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonathanlofgren%2Fadvent_of_code_2020'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2bdee1bac231ee5e88317ed957de8123e5b640fc [INFO] checking jonathanlofgren/advent_of_code_2020 against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonathanlofgren%2Fadvent_of_code_2020" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jonathanlofgren/advent_of_code_2020 on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jonathanlofgren/advent_of_code_2020 [INFO] finished tweaking git repo https://github.com/jonathanlofgren/advent_of_code_2020 [INFO] tweaked toml for git repo https://github.com/jonathanlofgren/advent_of_code_2020 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/jonathanlofgren/advent_of_code_2020 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1e145071262496af5e33eec0c04f1bedaa60f4fb70bc6a7cc11b846eac655e7c [INFO] running `Command { std: "docker" "start" "-a" "1e145071262496af5e33eec0c04f1bedaa60f4fb70bc6a7cc11b846eac655e7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e145071262496af5e33eec0c04f1bedaa60f4fb70bc6a7cc11b846eac655e7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e145071262496af5e33eec0c04f1bedaa60f4fb70bc6a7cc11b846eac655e7c", kill_on_drop: false }` [INFO] [stdout] 1e145071262496af5e33eec0c04f1bedaa60f4fb70bc6a7cc11b846eac655e7c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 382eac98ab89d46d569c31ee922606ebedd8dfe638401a4ad5a757038fc134ce [INFO] running `Command { std: "docker" "start" "-a" "382eac98ab89d46d569c31ee922606ebedd8dfe638401a4ad5a757038fc134ce", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking advent_of_code v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/day_7.rs:52:65 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap().clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Vec` does not implement `Clone`, so calling `clone` on `&Vec` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 52 - .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap().clone())) [INFO] [stdout] 52 + .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/day_7.rs:52:65 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap().clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Vec` does not implement `Clone`, so calling `clone` on `&Vec` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 52 - .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap().clone())) [INFO] [stdout] 52 + .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.68s [INFO] running `Command { std: "docker" "inspect" "382eac98ab89d46d569c31ee922606ebedd8dfe638401a4ad5a757038fc134ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "382eac98ab89d46d569c31ee922606ebedd8dfe638401a4ad5a757038fc134ce", kill_on_drop: false }` [INFO] [stdout] 382eac98ab89d46d569c31ee922606ebedd8dfe638401a4ad5a757038fc134ce [INFO] checking jonathanlofgren/advent_of_code_2020 against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonathanlofgren%2Fadvent_of_code_2020" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jonathanlofgren/advent_of_code_2020 on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jonathanlofgren/advent_of_code_2020 [INFO] finished tweaking git repo https://github.com/jonathanlofgren/advent_of_code_2020 [INFO] tweaked toml for git repo https://github.com/jonathanlofgren/advent_of_code_2020 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/jonathanlofgren/advent_of_code_2020 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b94410acd67f1f866b5243cf0e4d166390467e58bfe4a588a41b43574d9f8fce [INFO] running `Command { std: "docker" "start" "-a" "b94410acd67f1f866b5243cf0e4d166390467e58bfe4a588a41b43574d9f8fce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b94410acd67f1f866b5243cf0e4d166390467e58bfe4a588a41b43574d9f8fce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b94410acd67f1f866b5243cf0e4d166390467e58bfe4a588a41b43574d9f8fce", kill_on_drop: false }` [INFO] [stdout] b94410acd67f1f866b5243cf0e4d166390467e58bfe4a588a41b43574d9f8fce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60511dc6de4decef4e1c13fb28ea15e095d3f18b730cb7838960fbee1a5ae8e8 [INFO] running `Command { std: "docker" "start" "-a" "60511dc6de4decef4e1c13fb28ea15e095d3f18b730cb7838960fbee1a5ae8e8", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking advent_of_code v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | .map(|x| x.parse().ok().unwrap()) // To Option to avoid needing Debug trait [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/day_7.rs:52:65 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap().clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Vec` does not implement `Clone`, so calling `clone` on `&Vec` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 52 - .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap().clone())) [INFO] [stdout] 52 + .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day_6.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | .map(|s| s.replace("\n", "").chars().collect::>().len()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day_6.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 17 | let sets: Vec> = x.split("\n").map(|s| s.chars().collect()).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let set0 = sets[0].clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | / sets[1..] [INFO] [stdout] 21 | | .iter() [INFO] [stdout] 22 | | .fold(set0, |l, r| l.intersection(r).cloned().collect::>()) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent_of_code` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | .map(|x| x.parse().ok().unwrap()) // To Option to avoid needing Debug trait [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/day_7.rs:52:65 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap().clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Vec` does not implement `Clone`, so calling `clone` on `&Vec` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 52 - .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap().clone())) [INFO] [stdout] 52 + .map(|r| (r.bag.clone(), r.can_contain.as_ref().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day_6.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | .map(|s| s.replace("\n", "").chars().collect::>().len()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day_6.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 17 | let sets: Vec> = x.split("\n").map(|s| s.chars().collect()).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let set0 = sets[0].clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | / sets[1..] [INFO] [stdout] 21 | | .iter() [INFO] [stdout] 22 | | .fold(set0, |l, r| l.intersection(r).cloned().collect::>()) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent_of_code` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "60511dc6de4decef4e1c13fb28ea15e095d3f18b730cb7838960fbee1a5ae8e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60511dc6de4decef4e1c13fb28ea15e095d3f18b730cb7838960fbee1a5ae8e8", kill_on_drop: false }` [INFO] [stdout] 60511dc6de4decef4e1c13fb28ea15e095d3f18b730cb7838960fbee1a5ae8e8