[INFO] cloning repository https://github.com/jamesfer/datafusion-parallelism [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jamesfer/datafusion-parallelism" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjamesfer%2Fdatafusion-parallelism", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjamesfer%2Fdatafusion-parallelism'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 263740eec9444b410753f93aa8728aecdc4c745f [INFO] checking jamesfer/datafusion-parallelism against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjamesfer%2Fdatafusion-parallelism" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jamesfer/datafusion-parallelism on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jamesfer/datafusion-parallelism [INFO] finished tweaking git repo https://github.com/jamesfer/datafusion-parallelism [INFO] tweaked toml for git repo https://github.com/jamesfer/datafusion-parallelism written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/jamesfer/datafusion-parallelism already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded str_stack v0.1.0 [INFO] [stderr] Downloaded datafusion-physical-expr-common v40.0.0 [INFO] [stderr] Downloaded datafusion-common-runtime v40.0.0 [INFO] [stderr] Downloaded pprof v0.13.0 [INFO] [stderr] Downloaded boxcar v0.2.5 [INFO] [stderr] Downloaded datafusion-execution v40.0.0 [INFO] [stderr] Downloaded arrow-row v52.2.0 [INFO] [stderr] Downloaded arrow-arith v52.2.0 [INFO] [stderr] Downloaded arrow-schema v52.2.0 [INFO] [stderr] Downloaded arrow-csv v52.2.0 [INFO] [stderr] Downloaded datafusion-functions-array v40.0.0 [INFO] [stderr] Downloaded datafusion-functions-aggregate v40.0.0 [INFO] [stderr] Downloaded arrow-buffer v52.2.0 [INFO] [stderr] Downloaded arrow v52.2.0 [INFO] [stderr] Downloaded datafusion-functions v40.0.0 [INFO] [stderr] Downloaded datafusion-sql v40.0.0 [INFO] [stderr] Downloaded arrow-cast v52.2.0 [INFO] [stderr] Downloaded datafusion-common v40.0.0 [INFO] [stderr] Downloaded datafusion-optimizer v40.0.0 [INFO] [stderr] Downloaded datafusion-physical-expr v40.0.0 [INFO] [stderr] Downloaded arrow-array v52.2.0 [INFO] [stderr] Downloaded object_store v0.10.2 [INFO] [stderr] Downloaded datafusion-expr v40.0.0 [INFO] [stderr] Downloaded arrow-ipc v52.2.0 [INFO] [stderr] Downloaded symbolic-demangle v12.10.0 [INFO] [stderr] Downloaded datafusion-physical-plan v40.0.0 [INFO] [stderr] Downloaded inferno v0.11.20 [INFO] [stderr] Downloaded arrow-data v52.2.0 [INFO] [stderr] Downloaded arrow-select v52.2.0 [INFO] [stderr] Downloaded arrow-json v52.2.0 [INFO] [stderr] Downloaded arrow-ord v52.2.0 [INFO] [stderr] Downloaded arrow-string v52.2.0 [INFO] [stderr] Downloaded symbolic-common v12.10.0 [INFO] [stderr] Downloaded datafusion v40.0.0 [INFO] [stderr] Downloaded parquet v52.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d1de026cf2ab41bafcacfed03658c80f34b42266e07964ccf4ec0dad4c5598f3 [INFO] running `Command { std: "docker" "start" "-a" "d1de026cf2ab41bafcacfed03658c80f34b42266e07964ccf4ec0dad4c5598f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d1de026cf2ab41bafcacfed03658c80f34b42266e07964ccf4ec0dad4c5598f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1de026cf2ab41bafcacfed03658c80f34b42266e07964ccf4ec0dad4c5598f3", kill_on_drop: false }` [INFO] [stdout] d1de026cf2ab41bafcacfed03658c80f34b42266e07964ccf4ec0dad4c5598f3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b460fa8bfb1f90bf1425f9d5158b460ce396badca3c2155384f32e0f23f08ab [INFO] running `Command { std: "docker" "start" "-a" "4b460fa8bfb1f90bf1425f9d5158b460ce396badca3c2155384f32e0f23f08ab", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling cc v1.1.7 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling zstd-sys v2.0.12+zstd.1.5.6 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v52.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling regex v1.10.5 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking arrow-data v52.2.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Compiling zstd-safe v7.2.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Checking arrow-array v52.2.0 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Compiling sqlparser_derive v0.2.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling seq-macro v0.3.5 [INFO] [stderr] Checking sqlparser v0.47.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking object_store v0.10.2 [INFO] [stderr] Checking arrow-select v52.2.0 [INFO] [stderr] Checking arrow-row v52.2.0 [INFO] [stderr] Checking arrow-arith v52.2.0 [INFO] [stderr] Checking arrow-cast v52.2.0 [INFO] [stderr] Checking arrow-string v52.2.0 [INFO] [stderr] Checking arrow-ord v52.2.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking arrow-ipc v52.2.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking arrow-csv v52.2.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking arrow-json v52.2.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking arrow v52.2.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling blake3 v1.5.3 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking object v0.36.2 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking parquet v52.2.0 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking datafusion-common-runtime v40.0.0 [INFO] [stderr] Compiling cpuprofiler v0.0.4 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Compiling cpp_demangle v0.4.3 [INFO] [stderr] Checking boxcar v0.2.5 [INFO] [stderr] Checking debugid v0.8.0 [INFO] [stderr] Compiling findshlibs v0.10.2 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling symbolic-demangle v12.10.0 [INFO] [stderr] Checking bytemuck v1.16.1 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rgb v0.8.45 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking symbolic-common v12.10.0 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking quick-xml v0.26.0 [INFO] [stderr] Compiling pprof v0.13.0 [INFO] [stderr] Checking str_stack v0.1.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking inferno v0.11.20 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking datafusion-common v40.0.0 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking datafusion-expr v40.0.0 [INFO] [stderr] Checking datafusion-execution v40.0.0 [INFO] [stderr] Checking datafusion-physical-expr-common v40.0.0 [INFO] [stderr] Checking datafusion-sql v40.0.0 [INFO] [stderr] Checking datafusion-functions v40.0.0 [INFO] [stderr] Checking datafusion-physical-expr v40.0.0 [INFO] [stderr] Checking datafusion-functions-aggregate v40.0.0 [INFO] [stderr] Checking datafusion-physical-plan v40.0.0 [INFO] [stderr] Checking datafusion-optimizer v40.0.0 [INFO] [stderr] Checking datafusion-functions-array v40.0.0 [INFO] [stderr] Checking datafusion v40.0.0 [INFO] [stderr] Checking datafusion-parallelism v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Entry`, `OccupiedEntry`, and `VacantEntry` [INFO] [stdout] --> src/utils/concurrent_join_map.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | use dashmap::{DashMap, Entry, Map, OccupiedEntry, SharedValue, VacantEntry}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::once_notify` [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::utils::once_notify; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::future::Future` [INFO] [stdout] --> src/utils/once_notify.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::future::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AcquireError` and `SemaphorePermit` [INFO] [stdout] --> src/utils/once_notify.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | use tokio::sync::{AcquireError, Semaphore, SemaphorePermit}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version1/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version2/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version3/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Future` [INFO] [stdout] --> src/version3/inner_hash_join.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | use std::future::{Future, ready}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Entry`, `OccupiedEntry`, and `VacantEntry` [INFO] [stdout] --> src/utils/concurrent_join_map.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | use dashmap::{DashMap, Entry, Map, OccupiedEntry, SharedValue, VacantEntry}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::once_notify` [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::utils::once_notify; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::future::Future` [INFO] [stdout] --> src/utils/once_notify.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::future::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AcquireError` and `SemaphorePermit` [INFO] [stdout] --> src/utils/once_notify.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | use tokio::sync::{AcquireError, Semaphore, SemaphorePermit}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version1/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version2/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version3/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Future` [INFO] [stdout] --> src/version3/inner_hash_join.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | use std::future::{Future, ready}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DefaultDisplay` [INFO] [stdout] --> src/lib.rs:25:45 [INFO] [stdout] | [INFO] [stdout] 25 | use datafusion_physical_plan::{collect, DefaultDisplay, displayable}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/version1/inner_hash_join.rs:173:31 [INFO] [stdout] | [INFO] [stdout] 173 | .map_err(|err| DataFusionError::Internal("Send error".to_string())), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/version1/inner_hash_join.rs:173:31 [INFO] [stdout] | [INFO] [stdout] 173 | .map_err(|err| DataFusionError::Internal("Send error".to_string())), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version1/inner_hash_join.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version3/inner_hash_join.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version2/inner_hash_join.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/utils/limited_rc.rs:15:19 [INFO] [stdout] | [INFO] [stdout] 15 | .map(|i| Self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version1/parallel_join.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version1/parallel_join.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version1/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version2/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version2/parallel_join.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version2/parallel_join.rs:124:27 [INFO] [stdout] | [INFO] [stdout] 124 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/version2/inner_hash_join.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | let size = input.num_rows(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version3/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version3/parallel_join.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version3/parallel_join.rs:124:27 [INFO] [stdout] | [INFO] [stdout] 124 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version1/inner_hash_join.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version3/inner_hash_join.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version2/inner_hash_join.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_overflow` and `get_entries` are never used [INFO] [stdout] --> src/utils/concurrent_join_map.rs:198:8 [INFO] [stdout] | [INFO] [stdout] 166 | / impl ReadOnlyJoinMap [INFO] [stdout] 167 | | where T: Eq + Hash + Clone { [INFO] [stdout] | |__________________________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 198 | fn get_overflow(&self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 202 | fn get_entries(&self) -> Vec<(&T, &usize)> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/utils/limited_rc.rs:15:19 [INFO] [stdout] | [INFO] [stdout] 15 | .map(|i| Self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:442:13 [INFO] [stdout] | [INFO] [stdout] 442 | for i in 0..32 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `j` [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:444:17 [INFO] [stdout] | [INFO] [stdout] 444 | for j in 0..64 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_j` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `read_only_maps` [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:450:13 [INFO] [stdout] | [INFO] [stdout] 450 | let read_only_maps = maps.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_read_only_maps` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version1/parallel_join.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version1/parallel_join.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version1/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version2/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking datafusion-parallelism-tcp v0.1.0 (/opt/rustwide/workdir/tpc) [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version2/parallel_join.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version2/parallel_join.rs:124:27 [INFO] [stdout] | [INFO] [stdout] 124 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/version2/inner_hash_join.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | let size = input.num_rows(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version3/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version3/parallel_join.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version3/parallel_join.rs:124:27 [INFO] [stdout] | [INFO] [stdout] 124 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | let mut display_plan = displayable(plan.as_ref()); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | let mut display_plan = displayable(plan.as_ref()); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Int32Array` and `StringArray` [INFO] [stdout] --> src/bin/main.rs:3:32 [INFO] [stdout] | [INFO] [stdout] 3 | use datafusion::arrow::array::{Int32Array, StringArray}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 188 | let mut display_plan = displayable(plan.as_ref()); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 256 | let mut display_plan = displayable(plan.as_ref()); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Int32Array` and `StringArray` [INFO] [stdout] --> src/bin/main.rs:3:32 [INFO] [stdout] | [INFO] [stdout] 3 | use datafusion::arrow::array::{Int32Array, StringArray}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Int32Array` and `StringArray` [INFO] [stdout] --> benches/my_benchmark.rs:8:32 [INFO] [stdout] | [INFO] [stdout] 8 | use datafusion::arrow::array::{Int32Array, StringArray}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/lib.rs:390:27 [INFO] [stdout] | [INFO] [stdout] 390 | fn execute(&self, ctx: Arc) -> SendableRecordBatchStream { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_overflow` and `get_entries` are never used [INFO] [stdout] --> src/utils/concurrent_join_map.rs:198:8 [INFO] [stdout] | [INFO] [stdout] 166 | / impl ReadOnlyJoinMap [INFO] [stdout] 167 | | where T: Eq + Hash + Clone { [INFO] [stdout] | |__________________________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 198 | fn get_overflow(&self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 202 | fn get_entries(&self) -> Vec<(&T, &usize)> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 33 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/bin/main.rs:133:23 [INFO] [stdout] | [INFO] [stdout] 133 | fn execute(&self, ctx: Arc) -> SendableRecordBatchStream { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/bin/main.rs:133:23 [INFO] [stdout] | [INFO] [stdout] 133 | fn execute(&self, ctx: Arc) -> SendableRecordBatchStream { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `criterion::async_executor::AsyncExecutor` [INFO] [stdout] --> benches/my_benchmark.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use criterion::async_executor::AsyncExecutor; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `benchmark_id` [INFO] [stdout] --> benches/my_benchmark.rs:40:35 [INFO] [stdout] | [INFO] [stdout] 40 | fn start_profiling(&mut self, benchmark_id: &str, benchmark_dir: &Path) { [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_benchmark_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `benchmark_dir` [INFO] [stdout] --> benches/my_benchmark.rs:40:55 [INFO] [stdout] | [INFO] [stdout] 40 | fn start_profiling(&mut self, benchmark_id: &str, benchmark_dir: &Path) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_benchmark_dir` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `benchmark_id` [INFO] [stdout] --> benches/my_benchmark.rs:49:34 [INFO] [stdout] | [INFO] [stdout] 49 | fn stop_profiling(&mut self, benchmark_id: &str, benchmark_dir: &Path) { [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_benchmark_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `benchmark_dir` [INFO] [stdout] --> benches/my_benchmark.rs:49:54 [INFO] [stdout] | [INFO] [stdout] 49 | fn stop_profiling(&mut self, benchmark_id: &str, benchmark_dir: &Path) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_benchmark_dir` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> benches/my_benchmark.rs:133:23 [INFO] [stdout] | [INFO] [stdout] 133 | fn execute(&self, ctx: Arc) -> SendableRecordBatchStream { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 32.87s [INFO] running `Command { std: "docker" "inspect" "4b460fa8bfb1f90bf1425f9d5158b460ce396badca3c2155384f32e0f23f08ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b460fa8bfb1f90bf1425f9d5158b460ce396badca3c2155384f32e0f23f08ab", kill_on_drop: false }` [INFO] [stdout] 4b460fa8bfb1f90bf1425f9d5158b460ce396badca3c2155384f32e0f23f08ab [INFO] checking jamesfer/datafusion-parallelism against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjamesfer%2Fdatafusion-parallelism" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jamesfer/datafusion-parallelism on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jamesfer/datafusion-parallelism [INFO] finished tweaking git repo https://github.com/jamesfer/datafusion-parallelism [INFO] tweaked toml for git repo https://github.com/jamesfer/datafusion-parallelism written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/jamesfer/datafusion-parallelism already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c190b3a0e508ed32fec3885644f1b7d964ff638a01b73462590a8f171e444c79 [INFO] running `Command { std: "docker" "start" "-a" "c190b3a0e508ed32fec3885644f1b7d964ff638a01b73462590a8f171e444c79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c190b3a0e508ed32fec3885644f1b7d964ff638a01b73462590a8f171e444c79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c190b3a0e508ed32fec3885644f1b7d964ff638a01b73462590a8f171e444c79", kill_on_drop: false }` [INFO] [stdout] c190b3a0e508ed32fec3885644f1b7d964ff638a01b73462590a8f171e444c79 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ef2a2fdae75f185a044bd5c6b080ecafd672a9fcb966abe8e5034eb40ee2fdd [INFO] running `Command { std: "docker" "start" "-a" "3ef2a2fdae75f185a044bd5c6b080ecafd672a9fcb966abe8e5034eb40ee2fdd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling cc v1.1.7 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling zstd-sys v2.0.12+zstd.1.5.6 [INFO] [stderr] Checking arrow-buffer v52.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Compiling regex v1.10.5 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking arrow-data v52.2.0 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Compiling zstd-safe v7.2.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking arrow-array v52.2.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Compiling sqlparser_derive v0.2.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling seq-macro v0.3.5 [INFO] [stderr] Checking object_store v0.10.2 [INFO] [stderr] Checking sqlparser v0.47.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking arrow-select v52.2.0 [INFO] [stderr] Checking arrow-row v52.2.0 [INFO] [stderr] Checking arrow-arith v52.2.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking arrow-cast v52.2.0 [INFO] [stderr] Checking arrow-ord v52.2.0 [INFO] [stderr] Checking arrow-string v52.2.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking arrow-ipc v52.2.0 [INFO] [stderr] Checking arrow-csv v52.2.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking arrow-json v52.2.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking arrow v52.2.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling blake3 v1.5.3 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking object v0.36.2 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking parquet v52.2.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking datafusion-common-runtime v40.0.0 [INFO] [stderr] Compiling cpuprofiler v0.0.4 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking boxcar v0.2.5 [INFO] [stderr] Compiling cpp_demangle v0.4.3 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking debugid v0.8.0 [INFO] [stderr] Compiling findshlibs v0.10.2 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking bytemuck v1.16.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling symbolic-demangle v12.10.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking symbolic-common v12.10.0 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking rgb v0.8.45 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking quick-xml v0.26.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling pprof v0.13.0 [INFO] [stderr] Checking str_stack v0.1.0 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Checking inferno v0.11.20 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking datafusion-common v40.0.0 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking datafusion-expr v40.0.0 [INFO] [stderr] Checking datafusion-execution v40.0.0 [INFO] [stderr] Checking datafusion-physical-expr-common v40.0.0 [INFO] [stderr] Checking datafusion-sql v40.0.0 [INFO] [stderr] Checking datafusion-functions v40.0.0 [INFO] [stderr] Checking datafusion-physical-expr v40.0.0 [INFO] [stderr] Checking datafusion-functions-aggregate v40.0.0 [INFO] [stderr] Checking datafusion-physical-plan v40.0.0 [INFO] [stderr] Checking datafusion-optimizer v40.0.0 [INFO] [stderr] Checking datafusion-functions-array v40.0.0 [INFO] [stderr] Checking datafusion v40.0.0 [INFO] [stderr] Checking datafusion-parallelism v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Entry`, `OccupiedEntry`, and `VacantEntry` [INFO] [stdout] --> src/utils/concurrent_join_map.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | use dashmap::{DashMap, Entry, Map, OccupiedEntry, SharedValue, VacantEntry}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::once_notify` [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::utils::once_notify; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::future::Future` [INFO] [stdout] --> src/utils/once_notify.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::future::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AcquireError` and `SemaphorePermit` [INFO] [stdout] --> src/utils/once_notify.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | use tokio::sync::{AcquireError, Semaphore, SemaphorePermit}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version1/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version2/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version3/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Future` [INFO] [stdout] --> src/version3/inner_hash_join.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | use std::future::{Future, ready}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Entry`, `OccupiedEntry`, and `VacantEntry` [INFO] [stdout] --> src/utils/concurrent_join_map.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | use dashmap::{DashMap, Entry, Map, OccupiedEntry, SharedValue, VacantEntry}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::once_notify` [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::utils::once_notify; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::future::Future` [INFO] [stdout] --> src/utils/once_notify.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::future::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AcquireError` and `SemaphorePermit` [INFO] [stdout] --> src/utils/once_notify.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | use tokio::sync::{AcquireError, Semaphore, SemaphorePermit}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version1/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version2/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/version3/use_parallel_join_rule.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Future` [INFO] [stdout] --> src/version3/inner_hash_join.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | use std::future::{Future, ready}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DefaultDisplay` [INFO] [stdout] --> src/lib.rs:25:45 [INFO] [stdout] | [INFO] [stdout] 25 | use datafusion_physical_plan::{collect, DefaultDisplay, displayable}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/version1/inner_hash_join.rs:173:31 [INFO] [stdout] | [INFO] [stdout] 173 | .map_err(|err| DataFusionError::Internal("Send error".to_string())), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/version1/inner_hash_join.rs:173:31 [INFO] [stdout] | [INFO] [stdout] 173 | .map_err(|err| DataFusionError::Internal("Send error".to_string())), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version1/inner_hash_join.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version3/inner_hash_join.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version2/inner_hash_join.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/utils/limited_rc.rs:15:19 [INFO] [stdout] | [INFO] [stdout] 15 | .map(|i| Self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version1/parallel_join.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version1/parallel_join.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version1/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version2/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version2/parallel_join.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version2/parallel_join.rs:124:27 [INFO] [stdout] | [INFO] [stdout] 124 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/version2/inner_hash_join.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | let size = input.num_rows(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version3/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version3/parallel_join.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version1/inner_hash_join.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version3/parallel_join.rs:124:27 [INFO] [stdout] | [INFO] [stdout] 124 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version3/inner_hash_join.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `datafusion::execution::RecordBatchStream` [INFO] [stdout] --> src/version2/inner_hash_join.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use datafusion::execution::RecordBatchStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_overflow` and `get_entries` are never used [INFO] [stdout] --> src/utils/concurrent_join_map.rs:198:8 [INFO] [stdout] | [INFO] [stdout] 166 | / impl ReadOnlyJoinMap [INFO] [stdout] 167 | | where T: Eq + Hash + Clone { [INFO] [stdout] | |__________________________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 198 | fn get_overflow(&self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 202 | fn get_entries(&self) -> Vec<(&T, &usize)> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_sql.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 23 | let mut optimizer_rules = PhysicalOptimizer::default().rules; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let mut options = ConfigOptions::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | options.sql_parser.dialect = "postgres".to_string(); [INFO] [stdout] 38 | / SessionState::new_with_config_rt( [INFO] [stdout] 39 | | options.into(), [INFO] [stdout] 40 | | Arc::new(RuntimeEnv::default()), [INFO] [stdout] 41 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_sql.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn make_session_state_with_catalog(catalog_provider_list: Arc, use_new_join_rule: bool) -> SessionState { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | // Use the physical optimizer [INFO] [stdout] 47 | let mut optimizer_rules = PhysicalOptimizer::default().rules; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut options = ConfigOptions::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | options.sql_parser.dialect = "postgres".to_string(); [INFO] [stdout] 54 | / SessionState::new_with_config_rt_and_catalog_list( [INFO] [stdout] 55 | | options.into(), [INFO] [stdout] 56 | | Arc::new(RuntimeEnv::default()), [INFO] [stdout] 57 | | catalog_provider_list, [INFO] [stdout] 58 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/concurrent_join_map.rs:143:46 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn append_block(&self, size: usize, with_inserter: F) -> usize [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | where F: FnOnce(&mut Inserter) { [INFO] [stdout] 143 | self.buffers.create_new_buffer(size, |offset, buffer| { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 144 | | let mut inserter = Inserter::new(offset, &self.map, buffer); [INFO] [stdout] 145 | | with_inserter(&mut inserter) [INFO] [stdout] 146 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/concurrent_join_map.rs:155:30 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn compact(self) -> ReadOnlyJoinMap { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | ReadOnlyJoinMap::new(self.map.into_read_only(), self.buffers.compact()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/limited_rc.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 16 | inner: Arc::clone(&inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:134:43 [INFO] [stdout] | [INFO] [stdout] 134 | shards_to_compact_sender: sender.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:135:45 [INFO] [stdout] | [INFO] [stdout] 135 | shards_to_compact_receiver: receiver.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:136:42 [INFO] [stdout] | [INFO] [stdout] 136 | compacted_shards_sender: broadcaster.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:137:30 [INFO] [stdout] | [INFO] [stdout] 137 | once_notify: once_notify.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 355 | let shards = (0..shard_number).map(|_| Shard::new_empty()).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | let shard_copies = LimitedRc::new_copies(shards, count); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | let compactors = ShardCompactor::create(count, shard_number); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 363 | [INFO] [stdout] 364 | let global_offset = LimitedRc::new_copies(Mutex::new((0usize, 0usize)), count); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | [INFO] [stdout] 366 | / global_offset.into_iter() [INFO] [stdout] 367 | | .zip(shard_copies.into_iter()) [INFO] [stdout] 368 | | .zip(compactors.into_iter()) [INFO] [stdout] 369 | | .map(|((global_offset, shards), compactor)| WritablePartitionedConcurrentJoinMap::new(global_offset, shards, compactor)) [INFO] [stdout] | |________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/inner_hash_join.rs:71:15 [INFO] [stdout] | [INFO] [stdout] 70 | left.try_for_each(|record_batch| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | ready(process_input_batch( [INFO] [stdout] | _______________^ [INFO] [stdout] 72 | | record_batch, [INFO] [stdout] 73 | | &join_map, [INFO] [stdout] 74 | | &build_expressions, [INFO] [stdout] 75 | | batch_list, [INFO] [stdout] 76 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/inner_hash_join.rs:108:27 [INFO] [stdout] | [INFO] [stdout] 108 | .map(|expression| expression.evaluate(batch)?.into_array(batch.num_rows())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/inner_hash_join.rs:162:32 [INFO] [stdout] | [INFO] [stdout] 162 | .ok_or(DataFusionError::Internal("Batch list missing index from sorted list".to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/parallel_join.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 30 | fn compute_properties(eq: EquivalenceProperties, left: &Arc) -> PlanProperties { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Partitioning::RoundRobinBatch(left.output_partitioning().partition_count()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/parallel_join.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 56 | let eq_from_hash_join = value.properties().eq_properties.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let properties = ParallelJoin::compute_properties(eq_from_hash_join.clone(), &value.left); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | Ok(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | properties, [INFO] [stdout] 61 | | [INFO] [stdout] 62 | | left: value.left.clone(), [INFO] [stdout] ... | [INFO] [stdout] 69 | | // batch_list: Arc::new(boxcar::Vec::new()), [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/parallel_join.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 104 | fn with_new_children(self: Arc, children: Vec>) -> datafusion_common::Result> { [INFO] [stdout] | ---- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let left = Arc::clone(&children[0]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Ok(Arc::new(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | properties: ParallelJoin::compute_properties(self.properties.eq_properties.clone(), &left), [INFO] [stdout] 108 | | [INFO] [stdout] 109 | | left, [INFO] [stdout] ... | [INFO] [stdout] 114 | | execution_state: self.execution_state.clone(), [INFO] [stdout] 115 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/parallel_join.rs:153:23 [INFO] [stdout] | [INFO] [stdout] 120 | let state = self.execution_state.get_or_init(|| ParallelJoinExecutionState::new(parallelism)) [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let join_schema = Arc::new(join_schema); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | let left_stream = left_c.execute(partition, Arc::clone(&context))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let right_stream = right_c.execute(partition, context)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let on = self.on.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | ).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/parallel_join_execution_state.rs:37:59 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|(join_map, batch_list)| AtomicCell::new(Some(ParallelJoinExecutionStateInstance { [INFO] [stdout] | ___________________----------------------__________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | | join_map, [INFO] [stdout] 39 | | batch_list, [INFO] [stdout] 40 | | compacted_join_map_sender: broadcast_sender_cell.clone(), [INFO] [stdout] 41 | | compacted_join_map_receiver: broadcast_sender.subscribe(), [INFO] [stdout] 42 | | }))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/use_parallel_join_rule.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(plan.transform(transform)?.data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/utils/limited_rc.rs:15:19 [INFO] [stdout] | [INFO] [stdout] 15 | .map(|i| Self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/parallel_join_execution_state.rs:29:59 [INFO] [stdout] | [INFO] [stdout] 29 | .map(|(join_map, batch_list)| AtomicCell::new(Some(ParallelJoinExecutionStateInstance { [INFO] [stdout] | ___________________----------------------__________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | | join_map, [INFO] [stdout] 31 | | batch_list, [INFO] [stdout] 32 | | }))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/use_parallel_join_rule.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(plan.transform(transform)?.data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/parallel_join.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 29 | fn compute_properties(eq: EquivalenceProperties, left: &Arc) -> PlanProperties { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Partitioning::RoundRobinBatch(left.output_partitioning().partition_count()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/parallel_join.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 55 | let eq_from_hash_join = value.properties().eq_properties.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let properties = ParallelJoin::compute_properties(eq_from_hash_join.clone(), &value.left); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | [INFO] [stdout] 58 | Ok(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | properties, [INFO] [stdout] 60 | | [INFO] [stdout] 61 | | left: value.left.clone(), [INFO] [stdout] ... | [INFO] [stdout] 68 | | // batch_list: Arc::new(boxcar::Vec::new()), [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/parallel_join.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 103 | fn with_new_children(self: Arc, children: Vec>) -> datafusion_common::Result> { [INFO] [stdout] | ---- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let left = Arc::clone(&children[0]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Ok(Arc::new(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | properties: ParallelJoin::compute_properties(self.properties.eq_properties.clone(), &left), [INFO] [stdout] 107 | | [INFO] [stdout] 108 | | left, [INFO] [stdout] ... | [INFO] [stdout] 113 | | execution_state: self.execution_state.clone(), [INFO] [stdout] 114 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/parallel_join.rs:150:23 [INFO] [stdout] | [INFO] [stdout] 119 | let state = self.execution_state.get_or_init(|| ParallelJoinExecutionState::new(parallelism)) [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let join_schema = Arc::new(join_schema); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let left_stream = left_c.execute(partition, Arc::clone(&context))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let right_stream = right_c.execute(partition, context)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let on = self.on.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | ).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/inner_hash_join.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 66 | left.try_for_each(|record_batch| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | ready(process_input_batch( [INFO] [stdout] | _______________^ [INFO] [stdout] 68 | | record_batch, [INFO] [stdout] 69 | | &join_map, [INFO] [stdout] 70 | | &build_expressions, [INFO] [stdout] 71 | | batch_list, [INFO] [stdout] 72 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/inner_hash_join.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | .map(|expression| expression.evaluate(batch)?.into_array(batch.num_rows())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/inner_hash_join.rs:152:28 [INFO] [stdout] | [INFO] [stdout] 152 | .ok_or(DataFusionError::Internal("Batch list missing index from sorted list".to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/parallel_join_execution_state.rs:34:59 [INFO] [stdout] | [INFO] [stdout] 34 | .map(|(join_map, batch_list)| AtomicCell::new(Some(ParallelJoinExecutionStateInstance { [INFO] [stdout] | ___________________----------------------__________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | | join_map, [INFO] [stdout] 36 | | batch_list, [INFO] [stdout] 37 | | compute_compacted_batch_list: compute_compacted_batch_list.clone(), [INFO] [stdout] 38 | | }))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/use_parallel_join_rule.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(plan.transform(transform)?.data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/parallel_join.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 29 | fn compute_properties(eq: EquivalenceProperties, left: &Arc) -> PlanProperties { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Partitioning::RoundRobinBatch(left.output_partitioning().partition_count()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/parallel_join.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 55 | let eq_from_hash_join = value.properties().eq_properties.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let properties = ParallelJoin::compute_properties(eq_from_hash_join.clone(), &value.left); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | [INFO] [stdout] 58 | Ok(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | properties, [INFO] [stdout] 60 | | [INFO] [stdout] 61 | | left: value.left.clone(), [INFO] [stdout] ... | [INFO] [stdout] 68 | | // batch_list: Arc::new(boxcar::Vec::new()), [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/parallel_join.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 103 | fn with_new_children(self: Arc, children: Vec>) -> datafusion_common::Result> { [INFO] [stdout] | ---- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let left = Arc::clone(&children[0]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Ok(Arc::new(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | properties: ParallelJoin::compute_properties(self.properties.eq_properties.clone(), &left), [INFO] [stdout] 107 | | [INFO] [stdout] 108 | | left, [INFO] [stdout] ... | [INFO] [stdout] 113 | | execution_state: self.execution_state.clone(), [INFO] [stdout] 114 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/parallel_join.rs:151:23 [INFO] [stdout] | [INFO] [stdout] 119 | let state = self.execution_state.get_or_init(|| ParallelJoinExecutionState::new(parallelism)) [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let join_schema = Arc::new(join_schema); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let left_stream = left_c.execute(partition, Arc::clone(&context))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let right_stream = right_c.execute(partition, context)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let on = self.on.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | ).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/inner_hash_join.rs:71:15 [INFO] [stdout] | [INFO] [stdout] 70 | left.try_for_each(|record_batch| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | ready(process_input_batch( [INFO] [stdout] | _______________^ [INFO] [stdout] 72 | | record_batch, [INFO] [stdout] 73 | | &join_map, [INFO] [stdout] 74 | | &build_expressions, [INFO] [stdout] 75 | | batch_list, [INFO] [stdout] 76 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/inner_hash_join.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | .map(|expression| expression.evaluate(batch)?.into_array(batch.num_rows())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/inner_hash_join.rs:191:8 [INFO] [stdout] | [INFO] [stdout] 191 | Ok(concat_batches(input_schema, batches)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/inner_hash_join.rs:188:24 [INFO] [stdout] | [INFO] [stdout] 188 | .ok_or(DataFusionError::Internal("Batch list missing index from sorted list".to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 38 previous errors; 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:442:13 [INFO] [stdout] | [INFO] [stdout] 442 | for i in 0..32 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `j` [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:444:17 [INFO] [stdout] | [INFO] [stdout] 444 | for j in 0..64 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_j` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `read_only_maps` [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:450:13 [INFO] [stdout] | [INFO] [stdout] 450 | let read_only_maps = maps.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_read_only_maps` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `datafusion-parallelism` (lib) due to 39 previous errors; 24 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version1/parallel_join.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version1/parallel_join.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version1/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version2/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version2/parallel_join.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version2/parallel_join.rs:124:27 [INFO] [stdout] | [INFO] [stdout] 124 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/version2/inner_hash_join.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | let size = input.num_rows(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/version3/use_parallel_join_rule.rs:15:54 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/version3/parallel_join.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | fn fmt_as(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `column_indices` [INFO] [stdout] --> src/version3/parallel_join.rs:124:27 [INFO] [stdout] | [INFO] [stdout] 124 | let (join_schema, column_indices) = [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_column_indices` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | let mut display_plan = displayable(plan.as_ref()); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | let mut display_plan = displayable(plan.as_ref()); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 188 | let mut display_plan = displayable(plan.as_ref()); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 256 | let mut display_plan = displayable(plan.as_ref()); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/lib.rs:390:27 [INFO] [stdout] | [INFO] [stdout] 390 | fn execute(&self, ctx: Arc) -> SendableRecordBatchStream { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_overflow` and `get_entries` are never used [INFO] [stdout] --> src/utils/concurrent_join_map.rs:198:8 [INFO] [stdout] | [INFO] [stdout] 166 | / impl ReadOnlyJoinMap [INFO] [stdout] 167 | | where T: Eq + Hash + Clone { [INFO] [stdout] | |__________________________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 198 | fn get_overflow(&self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 202 | fn get_entries(&self) -> Vec<(&T, &usize)> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_sql.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 23 | let mut optimizer_rules = PhysicalOptimizer::default().rules; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let mut options = ConfigOptions::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | options.sql_parser.dialect = "postgres".to_string(); [INFO] [stdout] 38 | / SessionState::new_with_config_rt( [INFO] [stdout] 39 | | options.into(), [INFO] [stdout] 40 | | Arc::new(RuntimeEnv::default()), [INFO] [stdout] 41 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_sql.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn make_session_state_with_catalog(catalog_provider_list: Arc, use_new_join_rule: bool) -> SessionState { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | // Use the physical optimizer [INFO] [stdout] 47 | let mut optimizer_rules = PhysicalOptimizer::default().rules; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut options = ConfigOptions::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | options.sql_parser.dialect = "postgres".to_string(); [INFO] [stdout] 54 | / SessionState::new_with_config_rt_and_catalog_list( [INFO] [stdout] 55 | | options.into(), [INFO] [stdout] 56 | | Arc::new(RuntimeEnv::default()), [INFO] [stdout] 57 | | catalog_provider_list, [INFO] [stdout] 58 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/concurrent_join_map.rs:143:46 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn append_block(&self, size: usize, with_inserter: F) -> usize [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | where F: FnOnce(&mut Inserter) { [INFO] [stdout] 143 | self.buffers.create_new_buffer(size, |offset, buffer| { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 144 | | let mut inserter = Inserter::new(offset, &self.map, buffer); [INFO] [stdout] 145 | | with_inserter(&mut inserter) [INFO] [stdout] 146 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/concurrent_join_map.rs:155:30 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn compact(self) -> ReadOnlyJoinMap { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | ReadOnlyJoinMap::new(self.map.into_read_only(), self.buffers.compact()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/limited_rc.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 16 | inner: Arc::clone(&inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:134:43 [INFO] [stdout] | [INFO] [stdout] 134 | shards_to_compact_sender: sender.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:135:45 [INFO] [stdout] | [INFO] [stdout] 135 | shards_to_compact_receiver: receiver.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:136:42 [INFO] [stdout] | [INFO] [stdout] 136 | compacted_shards_sender: broadcaster.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:137:30 [INFO] [stdout] | [INFO] [stdout] 137 | once_notify: once_notify.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 355 | let shards = (0..shard_number).map(|_| Shard::new_empty()).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | let shard_copies = LimitedRc::new_copies(shards, count); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | let compactors = ShardCompactor::create(count, shard_number); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 363 | [INFO] [stdout] 364 | let global_offset = LimitedRc::new_copies(Mutex::new((0usize, 0usize)), count); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | [INFO] [stdout] 366 | / global_offset.into_iter() [INFO] [stdout] 367 | | .zip(shard_copies.into_iter()) [INFO] [stdout] 368 | | .zip(compactors.into_iter()) [INFO] [stdout] 369 | | .map(|((global_offset, shards), compactor)| WritablePartitionedConcurrentJoinMap::new(global_offset, shards, compactor)) [INFO] [stdout] | |________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:386:30 [INFO] [stdout] | [INFO] [stdout] 386 | .map(|map| spawn(map.compact())) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:404:30 [INFO] [stdout] | [INFO] [stdout] 404 | .map(|map| spawn(map.compact())) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:425:30 [INFO] [stdout] | [INFO] [stdout] 425 | .map(|map| spawn(map.compact())) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/partitioned_concurrent_join_map.rs:451:30 [INFO] [stdout] | [INFO] [stdout] 451 | .map(|map| spawn(map.compact())) [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/inner_hash_join.rs:71:15 [INFO] [stdout] | [INFO] [stdout] 70 | left.try_for_each(|record_batch| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | ready(process_input_batch( [INFO] [stdout] | _______________^ [INFO] [stdout] 72 | | record_batch, [INFO] [stdout] 73 | | &join_map, [INFO] [stdout] 74 | | &build_expressions, [INFO] [stdout] 75 | | batch_list, [INFO] [stdout] 76 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/inner_hash_join.rs:108:27 [INFO] [stdout] | [INFO] [stdout] 108 | .map(|expression| expression.evaluate(batch)?.into_array(batch.num_rows())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/inner_hash_join.rs:162:32 [INFO] [stdout] | [INFO] [stdout] 162 | .ok_or(DataFusionError::Internal("Batch list missing index from sorted list".to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/parallel_join.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 30 | fn compute_properties(eq: EquivalenceProperties, left: &Arc) -> PlanProperties { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Partitioning::RoundRobinBatch(left.output_partitioning().partition_count()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/parallel_join.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 56 | let eq_from_hash_join = value.properties().eq_properties.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let properties = ParallelJoin::compute_properties(eq_from_hash_join.clone(), &value.left); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | Ok(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | properties, [INFO] [stdout] 61 | | [INFO] [stdout] 62 | | left: value.left.clone(), [INFO] [stdout] ... | [INFO] [stdout] 69 | | // batch_list: Arc::new(boxcar::Vec::new()), [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/parallel_join.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 104 | fn with_new_children(self: Arc, children: Vec>) -> datafusion_common::Result> { [INFO] [stdout] | ---- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let left = Arc::clone(&children[0]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Ok(Arc::new(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | properties: ParallelJoin::compute_properties(self.properties.eq_properties.clone(), &left), [INFO] [stdout] 108 | | [INFO] [stdout] 109 | | left, [INFO] [stdout] ... | [INFO] [stdout] 114 | | execution_state: self.execution_state.clone(), [INFO] [stdout] 115 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/parallel_join.rs:153:23 [INFO] [stdout] | [INFO] [stdout] 120 | let state = self.execution_state.get_or_init(|| ParallelJoinExecutionState::new(parallelism)) [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let join_schema = Arc::new(join_schema); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | let left_stream = left_c.execute(partition, Arc::clone(&context))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let right_stream = right_c.execute(partition, context)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let on = self.on.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | ).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/parallel_join_execution_state.rs:37:59 [INFO] [stdout] | [INFO] [stdout] 37 | .map(|(join_map, batch_list)| AtomicCell::new(Some(ParallelJoinExecutionStateInstance { [INFO] [stdout] | ___________________----------------------__________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | | join_map, [INFO] [stdout] 39 | | batch_list, [INFO] [stdout] 40 | | compacted_join_map_sender: broadcast_sender_cell.clone(), [INFO] [stdout] 41 | | compacted_join_map_receiver: broadcast_sender.subscribe(), [INFO] [stdout] 42 | | }))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version1/use_parallel_join_rule.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(plan.transform(transform)?.data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/parallel_join_execution_state.rs:29:59 [INFO] [stdout] | [INFO] [stdout] 29 | .map(|(join_map, batch_list)| AtomicCell::new(Some(ParallelJoinExecutionStateInstance { [INFO] [stdout] | ___________________----------------------__________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | | join_map, [INFO] [stdout] 31 | | batch_list, [INFO] [stdout] 32 | | }))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/use_parallel_join_rule.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(plan.transform(transform)?.data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/parallel_join.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 29 | fn compute_properties(eq: EquivalenceProperties, left: &Arc) -> PlanProperties { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Partitioning::RoundRobinBatch(left.output_partitioning().partition_count()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/parallel_join.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 55 | let eq_from_hash_join = value.properties().eq_properties.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let properties = ParallelJoin::compute_properties(eq_from_hash_join.clone(), &value.left); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | [INFO] [stdout] 58 | Ok(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | properties, [INFO] [stdout] 60 | | [INFO] [stdout] 61 | | left: value.left.clone(), [INFO] [stdout] ... | [INFO] [stdout] 68 | | // batch_list: Arc::new(boxcar::Vec::new()), [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/parallel_join.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 103 | fn with_new_children(self: Arc, children: Vec>) -> datafusion_common::Result> { [INFO] [stdout] | ---- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let left = Arc::clone(&children[0]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Ok(Arc::new(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | properties: ParallelJoin::compute_properties(self.properties.eq_properties.clone(), &left), [INFO] [stdout] 107 | | [INFO] [stdout] 108 | | left, [INFO] [stdout] ... | [INFO] [stdout] 113 | | execution_state: self.execution_state.clone(), [INFO] [stdout] 114 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/parallel_join.rs:150:23 [INFO] [stdout] | [INFO] [stdout] 119 | let state = self.execution_state.get_or_init(|| ParallelJoinExecutionState::new(parallelism)) [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let join_schema = Arc::new(join_schema); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let left_stream = left_c.execute(partition, Arc::clone(&context))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let right_stream = right_c.execute(partition, context)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let on = self.on.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | ).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/inner_hash_join.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 66 | left.try_for_each(|record_batch| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | ready(process_input_batch( [INFO] [stdout] | _______________^ [INFO] [stdout] 68 | | record_batch, [INFO] [stdout] 69 | | &join_map, [INFO] [stdout] 70 | | &build_expressions, [INFO] [stdout] 71 | | batch_list, [INFO] [stdout] 72 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/inner_hash_join.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | .map(|expression| expression.evaluate(batch)?.into_array(batch.num_rows())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version2/inner_hash_join.rs:152:28 [INFO] [stdout] | [INFO] [stdout] 152 | .ok_or(DataFusionError::Internal("Batch list missing index from sorted list".to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/parallel_join_execution_state.rs:34:59 [INFO] [stdout] | [INFO] [stdout] 34 | .map(|(join_map, batch_list)| AtomicCell::new(Some(ParallelJoinExecutionStateInstance { [INFO] [stdout] | ___________________----------------------__________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | | join_map, [INFO] [stdout] 36 | | batch_list, [INFO] [stdout] 37 | | compute_compacted_batch_list: compute_compacted_batch_list.clone(), [INFO] [stdout] 38 | | }))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/use_parallel_join_rule.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | fn optimize(&self, plan: Arc, config: &ConfigOptions) -> datafusion_common::Result> { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(plan.transform(transform)?.data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/parallel_join.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 29 | fn compute_properties(eq: EquivalenceProperties, left: &Arc) -> PlanProperties { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Partitioning::RoundRobinBatch(left.output_partitioning().partition_count()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/parallel_join.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 55 | let eq_from_hash_join = value.properties().eq_properties.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let properties = ParallelJoin::compute_properties(eq_from_hash_join.clone(), &value.left); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | [INFO] [stdout] 58 | Ok(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | properties, [INFO] [stdout] 60 | | [INFO] [stdout] 61 | | left: value.left.clone(), [INFO] [stdout] ... | [INFO] [stdout] 68 | | // batch_list: Arc::new(boxcar::Vec::new()), [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/parallel_join.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 103 | fn with_new_children(self: Arc, children: Vec>) -> datafusion_common::Result> { [INFO] [stdout] | ---- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let left = Arc::clone(&children[0]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Ok(Arc::new(ParallelJoin { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | properties: ParallelJoin::compute_properties(self.properties.eq_properties.clone(), &left), [INFO] [stdout] 107 | | [INFO] [stdout] 108 | | left, [INFO] [stdout] ... | [INFO] [stdout] 113 | | execution_state: self.execution_state.clone(), [INFO] [stdout] 114 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/parallel_join.rs:151:23 [INFO] [stdout] | [INFO] [stdout] 119 | let state = self.execution_state.get_or_init(|| ParallelJoinExecutionState::new(parallelism)) [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let join_schema = Arc::new(join_schema); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let left_stream = left_c.execute(partition, Arc::clone(&context))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let right_stream = right_c.execute(partition, context)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let on = self.on.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | ).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/inner_hash_join.rs:71:15 [INFO] [stdout] | [INFO] [stdout] 70 | left.try_for_each(|record_batch| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | ready(process_input_batch( [INFO] [stdout] | _______________^ [INFO] [stdout] 72 | | record_batch, [INFO] [stdout] 73 | | &join_map, [INFO] [stdout] 74 | | &build_expressions, [INFO] [stdout] 75 | | batch_list, [INFO] [stdout] 76 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/inner_hash_join.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | .map(|expression| expression.evaluate(batch)?.into_array(batch.num_rows())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/inner_hash_join.rs:191:8 [INFO] [stdout] | [INFO] [stdout] 191 | Ok(concat_batches(input_schema, batches)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version3/inner_hash_join.rs:188:24 [INFO] [stdout] | [INFO] [stdout] 188 | .ok_or(DataFusionError::Internal("Batch list missing index from sorted list".to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:62 [INFO] [stdout] | [INFO] [stdout] 58 | let columns = single_result.columns().iter().map(|c| take(&*c, &indices, None).unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:62 [INFO] [stdout] | [INFO] [stdout] 126 | let columns = single_result.columns().iter().map(|c| take(&*c, &indices, None).unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:194:62 [INFO] [stdout] | [INFO] [stdout] 194 | let columns = single_result.columns().iter().map(|c| take(&*c, &indices, None).unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:262:62 [INFO] [stdout] | [INFO] [stdout] 262 | let columns = single_result.columns().iter().map(|c| take(&*c, &indices, None).unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:394:22 [INFO] [stdout] | [INFO] [stdout] 390 | fn execute(&self, ctx: Arc) -> SendableRecordBatchStream { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | let batches = self.data.clone().into_iter() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 394 | Box::pin(RecordBatchStreamAdapter::new(self.schema.clone(), futures::stream::iter(batches))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 47 previous errors; 33 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `datafusion-parallelism` (lib test) due to 48 previous errors; 33 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3ef2a2fdae75f185a044bd5c6b080ecafd672a9fcb966abe8e5034eb40ee2fdd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ef2a2fdae75f185a044bd5c6b080ecafd672a9fcb966abe8e5034eb40ee2fdd", kill_on_drop: false }` [INFO] [stdout] 3ef2a2fdae75f185a044bd5c6b080ecafd672a9fcb966abe8e5034eb40ee2fdd