[INFO] cloning repository https://github.com/hernangonzalez/codecrafters-redis-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hernangonzalez/codecrafters-redis-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhernangonzalez%2Fcodecrafters-redis-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhernangonzalez%2Fcodecrafters-redis-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cb8b7dfccc30ad04334bf68496e421da9892a450 [INFO] checking hernangonzalez/codecrafters-redis-rust against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhernangonzalez%2Fcodecrafters-redis-rust" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/hernangonzalez/codecrafters-redis-rust on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/hernangonzalez/codecrafters-redis-rust [INFO] finished tweaking git repo https://github.com/hernangonzalez/codecrafters-redis-rust [INFO] tweaked toml for git repo https://github.com/hernangonzalez/codecrafters-redis-rust written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/hernangonzalez/codecrafters-redis-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f2be14967713bb5f5d05f8f1608efc4e3274327ff3cb381655cbb3e25e7388be [INFO] running `Command { std: "docker" "start" "-a" "f2be14967713bb5f5d05f8f1608efc4e3274327ff3cb381655cbb3e25e7388be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f2be14967713bb5f5d05f8f1608efc4e3274327ff3cb381655cbb3e25e7388be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2be14967713bb5f5d05f8f1608efc4e3274327ff3cb381655cbb3e25e7388be", kill_on_drop: false }` [INFO] [stdout] f2be14967713bb5f5d05f8f1608efc4e3274327ff3cb381655cbb3e25e7388be [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1bc4ef7afad32c01a2938bf23bf77d48112f9fb7554cfa6dd937e8ddbdb5d6df [INFO] running `Command { std: "docker" "start" "-a" "1bc4ef7afad32c01a2938bf23bf77d48112f9fb7554cfa6dd937e8ddbdb5d6df", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.138 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling syn v1.0.67 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling parking_lot_core v0.9.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling anyhow v1.0.59 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking bytes v1.3.0 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling tokio v1.23.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking signal-hook-registry v1.2.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling tokio-macros v1.8.2 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking redis-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/db/file.rs:52:16 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Aux(String, String); [INFO] [stdout] | --- ^^^^^^ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `Aux` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/db/file.rs:147:28 [INFO] [stdout] | [INFO] [stdout] 147 | pub struct RedisFile(File, u32); [INFO] [stdout] | --------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `RedisFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/db/file.rs:52:16 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Aux(String, String); [INFO] [stdout] | --- ^^^^^^ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `Aux` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/db/file.rs:147:28 [INFO] [stdout] | [INFO] [stdout] 147 | pub struct RedisFile(File, u32); [INFO] [stdout] | --------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `RedisFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.53s [INFO] running `Command { std: "docker" "inspect" "1bc4ef7afad32c01a2938bf23bf77d48112f9fb7554cfa6dd937e8ddbdb5d6df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1bc4ef7afad32c01a2938bf23bf77d48112f9fb7554cfa6dd937e8ddbdb5d6df", kill_on_drop: false }` [INFO] [stdout] 1bc4ef7afad32c01a2938bf23bf77d48112f9fb7554cfa6dd937e8ddbdb5d6df [INFO] checking hernangonzalez/codecrafters-redis-rust against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhernangonzalez%2Fcodecrafters-redis-rust" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/hernangonzalez/codecrafters-redis-rust on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/hernangonzalez/codecrafters-redis-rust [INFO] finished tweaking git repo https://github.com/hernangonzalez/codecrafters-redis-rust [INFO] tweaked toml for git repo https://github.com/hernangonzalez/codecrafters-redis-rust written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/hernangonzalez/codecrafters-redis-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3aef02206277e8af3235376e953fe7f7dbfe4e8404a4d5bf73413f361c37da01 [INFO] running `Command { std: "docker" "start" "-a" "3aef02206277e8af3235376e953fe7f7dbfe4e8404a4d5bf73413f361c37da01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3aef02206277e8af3235376e953fe7f7dbfe4e8404a4d5bf73413f361c37da01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3aef02206277e8af3235376e953fe7f7dbfe4e8404a4d5bf73413f361c37da01", kill_on_drop: false }` [INFO] [stdout] 3aef02206277e8af3235376e953fe7f7dbfe4e8404a4d5bf73413f361c37da01 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5fd5877707419567a5228891b1e3e73bdef82ffd47dafd56237c88d8f41167fa [INFO] running `Command { std: "docker" "start" "-a" "5fd5877707419567a5228891b1e3e73bdef82ffd47dafd56237c88d8f41167fa", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.138 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.67 [INFO] [stderr] Compiling parking_lot_core v0.9.5 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling anyhow v1.0.59 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking bytes v1.3.0 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling tokio v1.23.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking signal-hook-registry v1.2.2 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Compiling tokio-macros v1.8.2 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking redis-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/db/file.rs:52:16 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Aux(String, String); [INFO] [stdout] | --- ^^^^^^ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `Aux` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/db/file.rs:147:28 [INFO] [stdout] | [INFO] [stdout] 147 | pub struct RedisFile(File, u32); [INFO] [stdout] | --------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `RedisFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 20 | fn all_entries(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | / self.into_iter() [INFO] [stdout] 22 | | .flat_map(|s| match s { [INFO] [stdout] 23 | | Section::Entry(e) => Some(e), [INFO] [stdout] 24 | | _ => None, [INFO] [stdout] 25 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 37 | fn all_keys(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | self.all_entries().map(|(k, _)| k).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | fn find(self, key: &str) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | self.all_entries() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 137 | let val = match kind { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | Kind::String => codec::string::read(reader).map(Value::String), [INFO] [stdout] 139 | k => Err(anyhow::anyhow!("Kind not supported: {k:?}")), [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | val.map(|v| Entry(ts, key, v)).map(Section::Entry) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file.rs:153:15 [INFO] [stdout] | [INFO] [stdout] 153 | match File::open(p) { [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 159 | fn sanity_check(f: File) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let mut file = f; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let mut buffer = BytesMut::zeroed(REDIS_RDB.len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(RedisFile(file, ver.parse()?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 174 | let mut file = File::create(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Ok(RedisFile(file, REDIS_VER.parse()?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file.rs:186:25 [INFO] [stdout] | [INFO] [stdout] 185 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | RedisFileReader(BufReader::new(self.0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/db/file.rs:52:16 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Aux(String, String); [INFO] [stdout] | --- ^^^^^^ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `Aux` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/db/file.rs:147:28 [INFO] [stdout] | [INFO] [stdout] 147 | pub struct RedisFile(File, u32); [INFO] [stdout] | --------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `RedisFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 20 | fn all_entries(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | / self.into_iter() [INFO] [stdout] 22 | | .flat_map(|s| match s { [INFO] [stdout] 23 | | Section::Entry(e) => Some(e), [INFO] [stdout] 24 | | _ => None, [INFO] [stdout] 25 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 37 | fn all_keys(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | self.all_entries().map(|(k, _)| k).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | fn find(self, key: &str) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | self.all_entries() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-starter-rust` (bin "redis-starter-rust") due to 9 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 137 | let val = match kind { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | Kind::String => codec::string::read(reader).map(Value::String), [INFO] [stdout] 139 | k => Err(anyhow::anyhow!("Kind not supported: {k:?}")), [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | val.map(|v| Entry(ts, key, v)).map(Section::Entry) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file.rs:153:15 [INFO] [stdout] | [INFO] [stdout] 153 | match File::open(p) { [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 159 | fn sanity_check(f: File) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let mut file = f; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let mut buffer = BytesMut::zeroed(REDIS_RDB.len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(RedisFile(file, ver.parse()?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 174 | let mut file = File::create(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Ok(RedisFile(file, REDIS_VER.parse()?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file.rs:186:25 [INFO] [stdout] | [INFO] [stdout] 185 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | RedisFileReader(BufReader::new(self.0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-starter-rust` (bin "redis-starter-rust" test) due to 9 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5fd5877707419567a5228891b1e3e73bdef82ffd47dafd56237c88d8f41167fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fd5877707419567a5228891b1e3e73bdef82ffd47dafd56237c88d8f41167fa", kill_on_drop: false }` [INFO] [stdout] 5fd5877707419567a5228891b1e3e73bdef82ffd47dafd56237c88d8f41167fa