[INFO] cloning repository https://github.com/fr0stylo/cachetcp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fr0stylo/cachetcp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffr0stylo%2Fcachetcp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffr0stylo%2Fcachetcp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1be4b73e1e443d15fb094d6942be92ee50cb1571 [INFO] checking fr0stylo/cachetcp against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffr0stylo%2Fcachetcp" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/fr0stylo/cachetcp on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/fr0stylo/cachetcp [INFO] finished tweaking git repo https://github.com/fr0stylo/cachetcp [INFO] tweaked toml for git repo https://github.com/fr0stylo/cachetcp written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/fr0stylo/cachetcp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c3ad608d75e26df3d48099e444db07b148de54b7a6f1db6b3cab95e00b91d15 [INFO] running `Command { std: "docker" "start" "-a" "6c3ad608d75e26df3d48099e444db07b148de54b7a6f1db6b3cab95e00b91d15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c3ad608d75e26df3d48099e444db07b148de54b7a6f1db6b3cab95e00b91d15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c3ad608d75e26df3d48099e444db07b148de54b7a6f1db6b3cab95e00b91d15", kill_on_drop: false }` [INFO] [stdout] 6c3ad608d75e26df3d48099e444db07b148de54b7a6f1db6b3cab95e00b91d15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 18fdb0a538aaf0bfd53313c1dff73b278017d932da7e5f586b4fa6b7346c40a2 [INFO] running `Command { std: "docker" "start" "-a" "18fdb0a538aaf0bfd53313c1dff73b278017d932da7e5f586b4fa6b7346c40a2", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking cachetcp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `BufReader`, `BufWriter`, `Error`, `Read`, `Write`, and `mem::size_of` [INFO] [stdout] --> src/proto/mod.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | io::{BufReader, BufWriter, Error, Read, Write}, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ ^^^^^ ^^^^ ^^^^^ [INFO] [stdout] 4 | mem::size_of, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufReader`, `BufWriter`, `Error`, `Read`, `Write`, and `mem::size_of` [INFO] [stdout] --> src/proto/mod.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | io::{BufReader, BufWriter, Error, Read, Write}, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ ^^^^^ ^^^^ ^^^^^ [INFO] [stdout] 4 | mem::size_of, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AsyncRead` and `AsyncWrite` [INFO] [stdout] --> src/proto/mod.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio::io::{AsyncRead, AsyncWrite}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `time::SystemTime` [INFO] [stdout] --> src/proto/nonblocking/mod.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{io::Error, mem::size_of, pin::Pin, time::SystemTime}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AsyncRead` and `AsyncWrite` [INFO] [stdout] --> src/proto/mod.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio::io::{AsyncRead, AsyncWrite}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/persistance/wal.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `time::SystemTime` [INFO] [stdout] --> src/proto/nonblocking/mod.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{io::Error, mem::size_of, pin::Pin, time::SystemTime}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/persistance/wal.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::future::Future` [INFO] [stdout] --> src/storage/storage.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::future::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::future::Future` [INFO] [stdout] --> src/storage/storage.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::future::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::pin::Pin` [INFO] [stdout] --> src/storage/storage.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::pin::Pin; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::pin::Pin` [INFO] [stdout] --> src/storage/storage.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::pin::Pin; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Context` and `Poll` [INFO] [stdout] --> src/storage/storage.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::task::{Context, Poll}; [INFO] [stdout] | ^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Context` and `Poll` [INFO] [stdout] --> src/storage/storage.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::task::{Context, Poll}; [INFO] [stdout] | ^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cli/mod.rs:13:36 [INFO] [stdout] | [INFO] [stdout] 13 | #[clap(long, default_value_t = ("./wal.log".to_string()))] [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - #[clap(long, default_value_t = ("./wal.log".to_string()))] [INFO] [stdout] 13 + #[clap(long, default_value_t = "./wal.log".to_string())] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cli/mod.rs:13:36 [INFO] [stdout] | [INFO] [stdout] 13 | #[clap(long, default_value_t = ("./wal.log".to_string()))] [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - #[clap(long, default_value_t = ("./wal.log".to_string()))] [INFO] [stdout] 13 + #[clap(long, default_value_t = "./wal.log".to_string())] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cli/mod.rs:16:36 [INFO] [stdout] | [INFO] [stdout] 16 | #[clap(long, default_value_t = ("./storage.log".to_string()))] [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - #[clap(long, default_value_t = ("./storage.log".to_string()))] [INFO] [stdout] 16 + #[clap(long, default_value_t = "./storage.log".to_string())] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cli/mod.rs:16:36 [INFO] [stdout] | [INFO] [stdout] 16 | #[clap(long, default_value_t = ("./storage.log".to_string()))] [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - #[clap(long, default_value_t = ("./storage.log".to_string()))] [INFO] [stdout] 16 + #[clap(long, default_value_t = "./storage.log".to_string())] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/storage/storage.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: Some... [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/storage/storage.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: Some... [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/persistance/snapshot.rs:68:38 [INFO] [stdout] | [INFO] [stdout] 68 | ... Some(x) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/persistance/snapshot.rs:68:38 [INFO] [stdout] | [INFO] [stdout] 68 | ... Some(x) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/persistance/wal.rs:81:38 [INFO] [stdout] | [INFO] [stdout] 81 | ... Some(x) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/persistance/wal.rs:81:38 [INFO] [stdout] | [INFO] [stdout] 81 | ... Some(x) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/persistance/wal.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let mut result = 0u64; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/persistance/wal.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let mut result = 0u64; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/storage/storage.rs:90:33 [INFO] [stdout] | [INFO] [stdout] 90 | let res = g.extract_if(|x, entry| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/storage/storage.rs:90:33 [INFO] [stdout] | [INFO] [stdout] 90 | let res = g.extract_if(|x, entry| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/storage.rs:104:32 [INFO] [stdout] | [INFO] [stdout] 104 | pub async fn expire(&self, mut tx: &UnboundedSender) { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/storage.rs:104:32 [INFO] [stdout] | [INFO] [stdout] 104 | pub async fn expire(&self, mut tx: &UnboundedSender) { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cc` is never read [INFO] [stdout] --> src/storage/storage.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct Storage { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 45 | cc: CacheStorage, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Storage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cc` is never read [INFO] [stdout] --> src/storage/storage.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct Storage { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 45 | cc: CacheStorage, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Storage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:59:82 [INFO] [stdout] | [INFO] [stdout] 59 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: None... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:59:82 [INFO] [stdout] | [INFO] [stdout] 59 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: None... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:65:82 [INFO] [stdout] | [INFO] [stdout] 65 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: Some... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:65:82 [INFO] [stdout] | [INFO] [stdout] 65 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: Some... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:71:46 [INFO] [stdout] | [INFO] [stdout] 71 | match self.stash.lock().await.get(key.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:71:46 [INFO] [stdout] | [INFO] [stdout] 71 | match self.stash.lock().await.get(key.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:82:49 [INFO] [stdout] | [INFO] [stdout] 82 | match self.stash.lock().await.remove(key.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:82:49 [INFO] [stdout] | [INFO] [stdout] 82 | match self.stash.lock().await.remove(key.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `cachetcp::proto::CommandMessage::DELETE` [INFO] [stdout] --> src/main.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use cachetcp::proto::CommandMessage::DELETE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `cachetcp::proto::CommandMessage::DELETE` [INFO] [stdout] --> src/main.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use cachetcp::proto::CommandMessage::DELETE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/main.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let s = i.to_be_bytes(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/main.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let s = i.to_be_bytes(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/main.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 111 | async fn handle_testing(args: &cli::Args) -> Result<(), std::io::Error> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/main.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 111 | async fn handle_testing(args: &cli::Args) -> Result<(), std::io::Error> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | _ => handle_server(&args).await, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/main.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 138 | cli::Runtime::Client => handle_client(&args).await, [INFO] [stdout] | -------------------- matches some of the same values [INFO] [stdout] 139 | // cli::Runtime::Client => cli::start_interactive(), [INFO] [stdout] 140 | cli::Runtime::Testing => handle_testing(&args).await, [INFO] [stdout] | --------------------- matches some of the same values [INFO] [stdout] 141 | cli::Runtime::Server => handle_server(&args).await, [INFO] [stdout] | -------------------- matches some of the same values [INFO] [stdout] 142 | _ => handle_server(&args).await, [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | _ => handle_server(&args).await, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/main.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 138 | cli::Runtime::Client => handle_client(&args).await, [INFO] [stdout] | -------------------- matches some of the same values [INFO] [stdout] 139 | // cli::Runtime::Client => cli::start_interactive(), [INFO] [stdout] 140 | cli::Runtime::Testing => handle_testing(&args).await, [INFO] [stdout] | --------------------- matches some of the same values [INFO] [stdout] 141 | cli::Runtime::Server => handle_server(&args).await, [INFO] [stdout] | -------------------- matches some of the same values [INFO] [stdout] 142 | _ => handle_server(&args).await, [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.15s [INFO] running `Command { std: "docker" "inspect" "18fdb0a538aaf0bfd53313c1dff73b278017d932da7e5f586b4fa6b7346c40a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18fdb0a538aaf0bfd53313c1dff73b278017d932da7e5f586b4fa6b7346c40a2", kill_on_drop: false }` [INFO] [stdout] 18fdb0a538aaf0bfd53313c1dff73b278017d932da7e5f586b4fa6b7346c40a2 [INFO] checking fr0stylo/cachetcp against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffr0stylo%2Fcachetcp" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/fr0stylo/cachetcp on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/fr0stylo/cachetcp [INFO] finished tweaking git repo https://github.com/fr0stylo/cachetcp [INFO] tweaked toml for git repo https://github.com/fr0stylo/cachetcp written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/fr0stylo/cachetcp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3bbadebf30159054f7f9234da639c1dc301b523d601edc5ff51f27373e1aec6c [INFO] running `Command { std: "docker" "start" "-a" "3bbadebf30159054f7f9234da639c1dc301b523d601edc5ff51f27373e1aec6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3bbadebf30159054f7f9234da639c1dc301b523d601edc5ff51f27373e1aec6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bbadebf30159054f7f9234da639c1dc301b523d601edc5ff51f27373e1aec6c", kill_on_drop: false }` [INFO] [stdout] 3bbadebf30159054f7f9234da639c1dc301b523d601edc5ff51f27373e1aec6c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d766593ae04c571dd39e456b7faf92eafa48eceb02b189e9eb127f223e41c959 [INFO] running `Command { std: "docker" "start" "-a" "d766593ae04c571dd39e456b7faf92eafa48eceb02b189e9eb127f223e41c959", kill_on_drop: false }` [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking cachetcp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `BufReader`, `BufWriter`, `Error`, `Read`, `Write`, and `mem::size_of` [INFO] [stdout] --> src/proto/mod.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | io::{BufReader, BufWriter, Error, Read, Write}, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ ^^^^^ ^^^^ ^^^^^ [INFO] [stdout] 4 | mem::size_of, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AsyncRead` and `AsyncWrite` [INFO] [stdout] --> src/proto/mod.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio::io::{AsyncRead, AsyncWrite}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `time::SystemTime` [INFO] [stdout] --> src/proto/nonblocking/mod.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{io::Error, mem::size_of, pin::Pin, time::SystemTime}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/persistance/wal.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::future::Future` [INFO] [stdout] --> src/storage/storage.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::future::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::pin::Pin` [INFO] [stdout] --> src/storage/storage.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::pin::Pin; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Context` and `Poll` [INFO] [stdout] --> src/storage/storage.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::task::{Context, Poll}; [INFO] [stdout] | ^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cli/mod.rs:13:36 [INFO] [stdout] | [INFO] [stdout] 13 | #[clap(long, default_value_t = ("./wal.log".to_string()))] [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - #[clap(long, default_value_t = ("./wal.log".to_string()))] [INFO] [stdout] 13 + #[clap(long, default_value_t = "./wal.log".to_string())] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cli/mod.rs:16:36 [INFO] [stdout] | [INFO] [stdout] 16 | #[clap(long, default_value_t = ("./storage.log".to_string()))] [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - #[clap(long, default_value_t = ("./storage.log".to_string()))] [INFO] [stdout] 16 + #[clap(long, default_value_t = "./storage.log".to_string())] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufReader`, `BufWriter`, `Error`, `Read`, `Write`, and `mem::size_of` [INFO] [stdout] --> src/proto/mod.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | io::{BufReader, BufWriter, Error, Read, Write}, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ ^^^^^ ^^^^ ^^^^^ [INFO] [stdout] 4 | mem::size_of, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AsyncRead` and `AsyncWrite` [INFO] [stdout] --> src/proto/mod.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio::io::{AsyncRead, AsyncWrite}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `time::SystemTime` [INFO] [stdout] --> src/proto/nonblocking/mod.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{io::Error, mem::size_of, pin::Pin, time::SystemTime}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/persistance/wal.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::future::Future` [INFO] [stdout] --> src/storage/storage.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::future::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::pin::Pin` [INFO] [stdout] --> src/storage/storage.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::pin::Pin; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Context` and `Poll` [INFO] [stdout] --> src/storage/storage.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::task::{Context, Poll}; [INFO] [stdout] | ^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cli/mod.rs:13:36 [INFO] [stdout] | [INFO] [stdout] 13 | #[clap(long, default_value_t = ("./wal.log".to_string()))] [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - #[clap(long, default_value_t = ("./wal.log".to_string()))] [INFO] [stdout] 13 + #[clap(long, default_value_t = "./wal.log".to_string())] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cli/mod.rs:16:36 [INFO] [stdout] | [INFO] [stdout] 16 | #[clap(long, default_value_t = ("./storage.log".to_string()))] [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 16 - #[clap(long, default_value_t = ("./storage.log".to_string()))] [INFO] [stdout] 16 + #[clap(long, default_value_t = "./storage.log".to_string())] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/storage/storage.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: Some... [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/storage/storage.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: Some... [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/persistance/snapshot.rs:68:38 [INFO] [stdout] | [INFO] [stdout] 68 | ... Some(x) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/persistance/snapshot.rs:68:38 [INFO] [stdout] | [INFO] [stdout] 68 | ... Some(x) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/persistance/wal.rs:81:38 [INFO] [stdout] | [INFO] [stdout] 81 | ... Some(x) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/persistance/wal.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let mut result = 0u64; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/persistance/wal.rs:81:38 [INFO] [stdout] | [INFO] [stdout] 81 | ... Some(x) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/persistance/wal.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let mut result = 0u64; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/storage/storage.rs:90:33 [INFO] [stdout] | [INFO] [stdout] 90 | let res = g.extract_if(|x, entry| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/storage.rs:104:32 [INFO] [stdout] | [INFO] [stdout] 104 | pub async fn expire(&self, mut tx: &UnboundedSender) { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/storage/storage.rs:90:33 [INFO] [stdout] | [INFO] [stdout] 90 | let res = g.extract_if(|x, entry| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/storage/storage.rs:104:32 [INFO] [stdout] | [INFO] [stdout] 104 | pub async fn expire(&self, mut tx: &UnboundedSender) { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cc` is never read [INFO] [stdout] --> src/storage/storage.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct Storage { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 45 | cc: CacheStorage, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Storage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/storage.rs:54:20 [INFO] [stdout] | [INFO] [stdout] 51 | let cc = Arc::new(Mutex::new(HashMap::>::new())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | stash: Arc::new(Mutex::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:59:82 [INFO] [stdout] | [INFO] [stdout] 59 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: None... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:65:82 [INFO] [stdout] | [INFO] [stdout] 65 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: Some... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:71:46 [INFO] [stdout] | [INFO] [stdout] 71 | match self.stash.lock().await.get(key.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:82:49 [INFO] [stdout] | [INFO] [stdout] 82 | match self.stash.lock().await.remove(key.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cc` is never read [INFO] [stdout] --> src/storage/storage.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct Storage { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 45 | cc: CacheStorage, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Storage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/storage.rs:54:20 [INFO] [stdout] | [INFO] [stdout] 51 | let cc = Arc::new(Mutex::new(HashMap::>::new())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | stash: Arc::new(Mutex::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:59:82 [INFO] [stdout] | [INFO] [stdout] 59 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: None... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:65:82 [INFO] [stdout] | [INFO] [stdout] 65 | ... let res = self.stash.lock().await.insert(key.to_owned(), Entry { key: key.clone().to_owned(), value: data.clone(), expires_at: Some... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:71:46 [INFO] [stdout] | [INFO] [stdout] 71 | match self.stash.lock().await.get(key.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/storage/storage.rs:82:49 [INFO] [stdout] | [INFO] [stdout] 82 | match self.stash.lock().await.remove(key.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cachetcp` (lib) due to 2 previous errors; 20 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cachetcp` (lib test) due to 2 previous errors; 20 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d766593ae04c571dd39e456b7faf92eafa48eceb02b189e9eb127f223e41c959", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d766593ae04c571dd39e456b7faf92eafa48eceb02b189e9eb127f223e41c959", kill_on_drop: false }` [INFO] [stdout] d766593ae04c571dd39e456b7faf92eafa48eceb02b189e9eb127f223e41c959