[INFO] cloning repository https://github.com/fhaynes/iridium [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fhaynes/iridium" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffhaynes%2Firidium", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffhaynes%2Firidium'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2cfad1c94d712a9899d6e0d39d373309965c2bff [INFO] checking fhaynes/iridium against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffhaynes%2Firidium" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/fhaynes/iridium on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/fhaynes/iridium [INFO] finished tweaking git repo https://github.com/fhaynes/iridium [INFO] tweaked toml for git repo https://github.com/fhaynes/iridium written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/fhaynes/iridium already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wincolor v1.0.1 [INFO] [stderr] Downloaded itertools-num v0.1.2 [INFO] [stderr] Downloaded termcolor v1.0.4 [INFO] [stderr] Downloaded failure_derive v0.1.3 [INFO] [stderr] Downloaded thread-scoped v1.0.2 [INFO] [stderr] Downloaded quote v0.6.9 [INFO] [stderr] Downloaded criterion-plot v0.2.5 [INFO] [stderr] Downloaded byteorder v1.2.7 [INFO] [stderr] Downloaded simplelog v0.5.3 [INFO] [stderr] Downloaded synstructure v0.10.1 [INFO] [stderr] Downloaded csv-core v0.1.4 [INFO] [stderr] Downloaded syn v0.15.18 [INFO] [stderr] Downloaded handlebars v0.32.4 [INFO] [stderr] Downloaded itertools v0.7.8 [INFO] [stderr] Downloaded failure v0.1.3 [INFO] [stderr] Downloaded pest_derive v1.0.8 [INFO] [stderr] Downloaded term v0.5.1 [INFO] [stderr] Downloaded uuid v0.7.1 [INFO] [stderr] Downloaded criterion-stats v0.2.5 [INFO] [stderr] Downloaded walkdir v2.2.6 [INFO] [stderr] Downloaded criterion v0.2.5 [INFO] [stderr] Downloaded regex-syntax v0.6.2 [INFO] [stderr] Downloaded regex v1.0.5 [INFO] [stderr] Downloaded csv v1.0.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] efbd73abc2a4fcd9328cf205bf99ae81fdf770385f5ac90e9b212b2efcc82179 [INFO] running `Command { std: "docker" "start" "-a" "efbd73abc2a4fcd9328cf205bf99ae81fdf770385f5ac90e9b212b2efcc82179", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "efbd73abc2a4fcd9328cf205bf99ae81fdf770385f5ac90e9b212b2efcc82179", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "efbd73abc2a4fcd9328cf205bf99ae81fdf770385f5ac90e9b212b2efcc82179", kill_on_drop: false }` [INFO] [stdout] efbd73abc2a4fcd9328cf205bf99ae81fdf770385f5ac90e9b212b2efcc82179 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac70b5fc85a731cc85063fbbfb3dcbcd81c2b66c41714c19fc4e08c06464ca62 [INFO] running `Command { std: "docker" "start" "-a" "ac70b5fc85a731cc85063fbbfb3dcbcd81c2b66c41714c19fc4e08c06464ca62", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Compiling proc-macro2 v0.4.20 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Compiling regex v1.0.5 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking ucd-util v0.1.2 [INFO] [stderr] Compiling cc v1.0.25 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Compiling ryu v0.2.6 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Checking regex-syntax v0.6.2 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking humantime v1.1.1 [INFO] [stderr] Compiling pest v1.0.6 [INFO] [stderr] Checking termcolor v1.0.4 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking rustc-demangle v0.1.9 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking thread-scoped v1.0.2 [INFO] [stderr] Checking walkdir v2.2.6 [INFO] [stderr] Compiling quote v0.6.9 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Checking itertools-num v0.1.2 [INFO] [stderr] Checking criterion-plot v0.2.5 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking criterion-stats v0.2.5 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Compiling pest_derive v1.0.8 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking serde_json v1.0.32 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Checking criterion v0.2.5 [INFO] [stderr] Checking iridium v0.0.33 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/comment_parsers.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / /// Looks for a comment start [INFO] [stdout] 5 | | /// Examples: [INFO] [stdout] | |_------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/directive_parsers.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | /// Will try to parse out any of the Directive forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/instruction_parsers.rs:233:1 [INFO] [stdout] | [INFO] [stdout] 233 | /// Will try to parse out any of the Instruction forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// Parser for all numbers, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 8 | | /// #100 [INFO] [stdout] | |_-------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / /// Parser for all floats, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 31 | | /// #100.0 [INFO] [stdout] | |_---------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/client.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(mut hello) = IridiumMessage::hello(alias, &self.bind_port.clone().unwrap()) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:30:33 [INFO] [stdout] | [INFO] [stdout] 30 | ... let mut cmgr_lock = cmgr.read().unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut cmgr = connection_manager.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/assembler/mod.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Assembler { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 61 | buf: [u8; 4], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Assembler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `symbol_type` is never read [INFO] [stdout] --> src/assembler/symbols.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 5 | symbol_type: SymbolType, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `at` and `application_id` are never read [INFO] [stdout] --> src/vm.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct VMEvent { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 41 | pub event: VMEventType, [INFO] [stdout] 42 | at: DateTime, [INFO] [stdout] | ^^ [INFO] [stdout] 43 | application_id: Uuid, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMEvent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::str::::trim_end` that must be used [INFO] [stdout] --> src/remote/client.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | buf.trim_end(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the trimmed string as a new slice, without modifying the original [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 80 | let _ = buf.trim_end(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/repl/mod.rs:308:46 [INFO] [stdout] | [INFO] [stdout] 308 | let addr = ip.to_owned() + ":" + port.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | let mut vm = VM::new() [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | let mut rx = repl.rx_pipe.take(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PIE_HEADER_LENGTH` and `PIE_HEADER_PREFIX` [INFO] [stdout] --> benches/iridium.rs:6:26 [INFO] [stdout] | [INFO] [stdout] 6 | use iridium::assembler::{PIE_HEADER_LENGTH, PIE_HEADER_PREFIX}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | let mut vm = VM::new() [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | let mut rx = repl.rx_pipe.take(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/comment_parsers.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / /// Looks for a comment start [INFO] [stdout] 5 | | /// Examples: [INFO] [stdout] | |_------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/directive_parsers.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | /// Will try to parse out any of the Directive forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/instruction_parsers.rs:233:1 [INFO] [stdout] | [INFO] [stdout] 233 | /// Will try to parse out any of the Instruction forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// Parser for all numbers, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 8 | | /// #100 [INFO] [stdout] | |_-------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / /// Parser for all floats, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 31 | | /// #100.0 [INFO] [stdout] | |_---------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/client.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(mut hello) = IridiumMessage::hello(alias, &self.bind_port.clone().unwrap()) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:30:33 [INFO] [stdout] | [INFO] [stdout] 30 | ... let mut cmgr_lock = cmgr.read().unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut cmgr = connection_manager.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/assembler/mod.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Assembler { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 61 | buf: [u8; 4], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Assembler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `symbol_type` is never read [INFO] [stdout] --> src/assembler/symbols.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 5 | symbol_type: SymbolType, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `at` and `application_id` are never read [INFO] [stdout] --> src/vm.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct VMEvent { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 41 | pub event: VMEventType, [INFO] [stdout] 42 | at: DateTime, [INFO] [stdout] | ^^ [INFO] [stdout] 43 | application_id: Uuid, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMEvent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::str::::trim_end` that must be used [INFO] [stdout] --> src/remote/client.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | buf.trim_end(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the trimmed string as a new slice, without modifying the original [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 80 | let _ = buf.trim_end(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/repl/mod.rs:308:46 [INFO] [stdout] | [INFO] [stdout] 308 | let addr = ip.to_owned() + ":" + port.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.99s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: criterion v0.2.5, nom v4.1.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "ac70b5fc85a731cc85063fbbfb3dcbcd81c2b66c41714c19fc4e08c06464ca62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac70b5fc85a731cc85063fbbfb3dcbcd81c2b66c41714c19fc4e08c06464ca62", kill_on_drop: false }` [INFO] [stdout] ac70b5fc85a731cc85063fbbfb3dcbcd81c2b66c41714c19fc4e08c06464ca62 [INFO] checking fhaynes/iridium against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffhaynes%2Firidium" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/fhaynes/iridium on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/fhaynes/iridium [INFO] finished tweaking git repo https://github.com/fhaynes/iridium [INFO] tweaked toml for git repo https://github.com/fhaynes/iridium written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/fhaynes/iridium already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 612c3fae4d53ba97644cda567a0b3bab26389557aa802d69e0dc0d855ad7f13e [INFO] running `Command { std: "docker" "start" "-a" "612c3fae4d53ba97644cda567a0b3bab26389557aa802d69e0dc0d855ad7f13e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "612c3fae4d53ba97644cda567a0b3bab26389557aa802d69e0dc0d855ad7f13e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "612c3fae4d53ba97644cda567a0b3bab26389557aa802d69e0dc0d855ad7f13e", kill_on_drop: false }` [INFO] [stdout] 612c3fae4d53ba97644cda567a0b3bab26389557aa802d69e0dc0d855ad7f13e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6c197324a2147845a0207768e3094d5b39a63b947404c98fad354eee9abe6e74 [INFO] running `Command { std: "docker" "start" "-a" "6c197324a2147845a0207768e3094d5b39a63b947404c98fad354eee9abe6e74", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling proc-macro2 v0.4.20 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking ucd-util v0.1.2 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Compiling regex v1.0.5 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling cc v1.0.25 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Compiling ryu v0.2.6 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Checking regex-syntax v0.6.2 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking humantime v1.1.1 [INFO] [stderr] Checking rustc-demangle v0.1.9 [INFO] [stderr] Checking termcolor v1.0.4 [INFO] [stderr] Compiling pest v1.0.6 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking thread-scoped v1.0.2 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking walkdir v2.2.6 [INFO] [stderr] Compiling quote v0.6.9 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking itertools-num v0.1.2 [INFO] [stderr] Checking criterion-stats v0.2.5 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking criterion-plot v0.2.5 [INFO] [stderr] Compiling pest_derive v1.0.8 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking serde_json v1.0.32 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Checking iridium v0.0.33 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.2.5 [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/comment_parsers.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / /// Looks for a comment start [INFO] [stdout] 5 | | /// Examples: [INFO] [stdout] | |_------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/directive_parsers.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | /// Will try to parse out any of the Directive forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/instruction_parsers.rs:233:1 [INFO] [stdout] | [INFO] [stdout] 233 | /// Will try to parse out any of the Instruction forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// Parser for all numbers, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 8 | | /// #100 [INFO] [stdout] | |_-------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / /// Parser for all floats, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 31 | | /// #100.0 [INFO] [stdout] | |_---------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/client.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(mut hello) = IridiumMessage::hello(alias, &self.bind_port.clone().unwrap()) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:30:33 [INFO] [stdout] | [INFO] [stdout] 30 | ... let mut cmgr_lock = cmgr.read().unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut cmgr = connection_manager.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/assembler/mod.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Assembler { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 61 | buf: [u8; 4], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Assembler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `symbol_type` is never read [INFO] [stdout] --> src/assembler/symbols.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 5 | symbol_type: SymbolType, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `at` and `application_id` are never read [INFO] [stdout] --> src/vm.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct VMEvent { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 41 | pub event: VMEventType, [INFO] [stdout] 42 | at: DateTime, [INFO] [stdout] | ^^ [INFO] [stdout] 43 | application_id: Uuid, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMEvent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cluster/alias.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 9 | let mut f = File::open(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | match f.read_to_string(&mut alias) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cluster/alias.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 24 | let mut f = File::create(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | match f.write_all(alias.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cluster/client.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(stream: TcpStream, manager: Arc>, bind_port: String) -> ClusterClient { [INFO] [stdout] | ----------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | // TODO: Handle this better [INFO] [stdout] 29 | let reader = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let writer = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let (tx, rx) = channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | reader: BufReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cluster/client.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(stream: TcpStream, manager: Arc>, bind_port: String) -> ClusterClient { [INFO] [stdout] | ----------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | // TODO: Handle this better [INFO] [stdout] 29 | let reader = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let writer = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let (tx, rx) = channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | writer: BufWriter::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cluster/client.rs:37:18 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(stream: TcpStream, manager: Arc>, bind_port: String) -> ClusterClient { [INFO] [stdout] | ----------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | // TODO: Handle this better [INFO] [stdout] 29 | let reader = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let writer = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let (tx, rx) = channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | _tx: Some(Arc::new(Mutex::new(tx))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cluster/client.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(stream: TcpStream, manager: Arc>, bind_port: String) -> ClusterClient { [INFO] [stdout] | ----------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | // TODO: Handle this better [INFO] [stdout] 29 | let reader = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let writer = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let (tx, rx) = channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | rx: Some(Arc::new(Mutex::new(rx))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cluster/message.rs:9:21 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote/client.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(stream: TcpStream) -> Client { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | // TODO: Handle this better [INFO] [stdout] 19 | let reader = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let writer = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let vm = VM::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let repl = repl::REPL::new(vm); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | reader: BufReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote/client.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(stream: TcpStream) -> Client { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | // TODO: Handle this better [INFO] [stdout] 19 | let reader = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let writer = stream.try_clone().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let vm = VM::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let repl = repl::REPL::new(vm); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | writer: BufWriter::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::str::::trim_end` that must be used [INFO] [stdout] --> src/remote/client.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | buf.trim_end(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the trimmed string as a new slice, without modifying the original [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 80 | let _ = buf.trim_end(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repl/mod.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(vm: VM) -> REPL { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let (tx, rx): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | tx_pipe: Some(Box::new(tx)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repl/mod.rs:47:22 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(vm: VM) -> REPL { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let (tx, rx): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | rx_pipe: Some(Box::new(rx)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repl/mod.rs:150:15 [INFO] [stdout] | [INFO] [stdout] 142 | let mut f = match File::open(&filename) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | match f.read_to_string(&mut contents) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/repl/mod.rs:308:46 [INFO] [stdout] | [INFO] [stdout] 308 | let addr = ip.to_owned() + ":" + port.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/mod.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn get_thread(&mut self, mut vm: VM) -> thread::JoinHandle> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 18 | | let events = vm.run(); [INFO] [stdout] 19 | | println!("VM Events"); [INFO] [stdout] 20 | | println!("--------------------------"); [INFO] [stdout] ... | [INFO] [stdout] 24 | | events [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iridium` (lib) due to 14 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6c197324a2147845a0207768e3094d5b39a63b947404c98fad354eee9abe6e74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c197324a2147845a0207768e3094d5b39a63b947404c98fad354eee9abe6e74", kill_on_drop: false }` [INFO] [stdout] 6c197324a2147845a0207768e3094d5b39a63b947404c98fad354eee9abe6e74